Re: [PATCH] ARM: dts: add missing ux500 device trees

2012-11-06 Thread Linus Walleij
On Tue, Nov 6, 2012 at 2:51 PM, Fabio Baltieri wrote: > This adds hrefprev60, hrefv60plus and ccu9540 to device trees compiled > during build. > > Cc: Linus Walleij > Acked-by: Lee Jones > Signed-off-by: Fabio Baltieri Acked-by: Linus Walleij Yours, Linus Walleij -- T

[PATCH 1/5] gpiolib: fix up function prototypes etc

2012-11-06 Thread Linus Walleij
From: Linus Walleij Commit 69e1601bca88809dc118abd1becb02c15a02ec71 "gpiolib: provide provision to register pin ranges" Got most of it's function prototypes wrong, so fix this up by: - Moving the void declarations into static inlines in (previously the actual prototypes were

[PATCH 2/5] gpiolib-of: staticize the pin range calls

2012-11-06 Thread Linus Walleij
From: Linus Walleij Commit 69e1601bca88809dc118abd1becb02c15a02ec71 "gpiolib: provide provision to register pin ranges" Declared the of_gpiochip_[add|remove]_pin_range() global while they should be static as they are only ever used in this file. Let's convert them to static.

[PATCH 3/5] gpiolib: remove duplicate pin range code

2012-11-06 Thread Linus Walleij
From: Linus Walleij Commit 69e1601bca88809dc118abd1becb02c15a02ec71 "gpiolib: provide provision to register pin ranges" Introduced both of_gpiochip_remove_pin_range() and gpiochip_remove_pin_ranges(). But the contents are exactly the same so remove the OF one and rely on the range d

[PATCH 4/5] gpiolib: call pin removal in chip removal function

2012-11-06 Thread Linus Walleij
From: Linus Walleij This makes us call gpiochio_remove_pin_ranges() in the gpiochip_remove() function, so we get rid of ranges when freeing the chip. Signed-off-by: Linus Walleij --- drivers/gpio/gpiolib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpiolib.c b/drivers

[PATCH 5/5] gpiolib: separation of pin concerns

2012-11-06 Thread Linus Walleij
From: Linus Walleij The fact that of_gpiochip_add_pin_range() and gpiochip_add_pin_range() share too much code is fragile and will invariably mean that bugs need to be fixed in two places instead of one. So separate the concerns of gpiolib.c and gpiolib-of.c and have the latter call the former

[PATCH] gpiolib: iron out include ladder mistakes

2012-11-06 Thread Linus Walleij
From: Linus Walleij The <*/gpio.h> includes are updated again: now we need to account for the problem introduced by commit: 595679a8038584df7b9398bf34f61db3c038bfea "gpiolib: fix up function prototypes etc" Actually we need static inlines in include/asm-generic/gpio.h as well s

Re: How about a gpio_get(device *, char *) function?

2012-11-07 Thread Linus Walleij
can work from there. I think it adds the proper opaqueness factor. I don't really like the "gpioh_*" prefix instead of just gpio_* but I guess there is not polymorphism to exploit as transition path here :-P Yours, Linus Walleij -- To unsubscribe from this list: send the line "un

Re: How about a gpio_get(device *, char *) function?

2012-11-07 Thread Linus Walleij
the time. Yes, I just think we should return an opaque struct from day 1, so just a little, little bit more to shield us. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo in

[GIT PULL] pinctrl fixes for v3.7 rc:s

2012-11-08 Thread Linus Walleij
Hi Linus, here is a set of pinctrl fixes for the current -rc series. Details in the signed tag. Please pull it in! Yours, Linus Walleij The following changes since commit 8f0d8163b50e01f398b14bcd4dc039ac5ab18d64: Linux 3.7-rc3 (2012-10-28 12:24:48 -0700) are available in the git repository

[PATCH 1/2] ARM: ux500: add PRCM register base for pinctrl

2012-11-08 Thread Linus Walleij
From: Jonas Aaberg This adds the PRCM register range base as a resource to the pinctrl driver do we can break the dependency to the PRCMU driver and handle these registers in the driver alone. Cc: a...@kernel.org Signed-off-by: Jonas Aaberg Signed-off-by: Linus Walleij --- ARM SoC guys: this

[PATCH 2/2] pinctrl/nomadik: make independent of prcmu driver

2012-11-08 Thread Linus Walleij
ction. Cc: Loic Pallardy Signed-off-by: Jonas Aaberg Signed-off-by: Linus Walleij --- drivers/pinctrl/pinctrl-nomadik-db8500.c | 4 +-- drivers/pinctrl/pinctrl-nomadik-db8540.c | 4 +-- drivers/pinctrl/pinctrl-nomadik-stn8815.c | 4 +-- drivers/pinctrl/pinctrl-nomadik.c

Re: [PATCH 1/5] gpiolib: fix up function prototypes etc

2012-11-08 Thread Linus Walleij
On Wed, Nov 7, 2012 at 6:09 AM, Viresh Kumar wrote: > On 6 November 2012 20:46, Linus Walleij >> -void gpiochip_add_pin_range(struct gpio_chip *chip, const char >> *pinctl_name, >> - unsigned int pin_base, unsigned int npins); >> -void gpiochip_remove_

Re: [PATCH 3/5] gpiolib: remove duplicate pin range code

2012-11-08 Thread Linus Walleij
On Wed, Nov 7, 2012 at 6:14 AM, viresh kumar wrote: > On Tue, Nov 6, 2012 at 8:46 PM, Linus Walleij > wrote: >> From: Linus Walleij >> >> Commit 69e1601bca88809dc118abd1becb02c15a02ec71 >> "gpiolib: provide provision to register pin ranges" >> &

Re: [PATCH] gpiolib: iron out include ladder mistakes

2012-11-08 Thread Linus Walleij
On Tue, Nov 6, 2012 at 10:40 PM, Stephen Warren wrote: > On 11/06/2012 09:21 AM, Linus Walleij wrote: >> And we need to keep the static inlines in >> but here for the !CONFIG_GENERIC_GPIO case, and then we >> may as well throw in a few warnings like the other >> p

Re: linux-next: build failure after merge of the final tree (pinctrl tree related)

2012-11-08 Thread Linus Walleij
otypes just above the actual definition of struct gpio_chip :-P Fixing up and respinning the patch, I've added the compulsory return value as well. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord..

[PATCH v2] gpiolib: iron out include ladder mistakes

2012-11-08 Thread Linus Walleij
From: Linus Walleij The <*/gpio.h> includes are updated again: now we need to account for the problem introduced by commit: 595679a8038584df7b9398bf34f61db3c038bfea "gpiolib: fix up function prototypes etc" Actually we need static inlines in include/asm-generic/gpio.h as well s

Re: [PATCHv2] gpio-mcp23s08: Build I2C support even when CONFIG_I2C=m

2012-11-08 Thread Linus Walleij
or either > since building both this driver and I2C as modules is possible. > > Signed-off-by: Daniel M. Weeks Thanks, patch merged to my fixes branch. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to ma

Re: [PATCH 2/2] gpio: tegra: fix suspend/resume apis

2012-11-08 Thread Linus Walleij
t; Signed-off-by: Laxman Dewangan OK patch applied to my devel branch, with Stephens ACK and I also fixed the whitespace issue he pointed out. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord

Re: [PATCH V2] gpio: tegra: fix suspend/resume apis

2012-11-08 Thread Linus Walleij
On Thu, Nov 8, 2012 at 5:22 AM, Laxman Dewangan wrote: > Changes from V1: > - It was 2/2/ for prev patch and dropping 1/2. > - nit cleanup in change. > - Added ack from Stephen as it is acked in 2/2. Oh I didn't see you respun it yourself. Anyway it's applied now. Your

Re: [PATCH 1/2] gpio: tegra: Staticize non-exported symbols

2012-11-08 Thread Linus Walleij
On Thu, Nov 8, 2012 at 3:45 AM, Axel Lin wrote: > Both tegra_gpio_request() and tegra_gpio_free() are not referenced outside of > this file, make them static. > > Signed-off-by: Axel Lin Applied with Stephen's ACK. Yours, Linus Walleij -- To unsubscribe from this li

Re: [PATCH 2/2] gpio: tegra: Drop exporting static functions

2012-11-08 Thread Linus Walleij
On Thu, Nov 8, 2012 at 3:47 AM, Axel Lin wrote: > Both tegra_gpio_enable() and tegra_gpio_disable() are static functions, it > does > not make sense to export them. > > Signed-off-by: Axel Lin Applied with Stephen's ACK. Yours, Linus Walleij -- To unsubscribe from this

Re: [PATCH] gpio: mvebu: Set free callback for gpio_chip

2012-11-08 Thread Linus Walleij
t; > Signed-off-by: Axel Lin Applied with Thomas' ACK, thanks! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-in

Re: linux-next: manual merge of the arm-soc tree with the pinctrl tree

2012-11-09 Thread Linus Walleij
commit 44e47ccf8ab6 ("Merge branch 'next/multiplatform' into > for-next") from the arm-soc tree. > > I fixed it up (see below) and can carry the fix as necessary (no action > is required). This looks like the correct fix, thanks a lot Stephen! Yours, Linus Walleij -

Re: [PATCH 2/2] pinctrl/nomadik: make independent of prcmu driver

2012-11-09 Thread Linus Walleij
pass it as a separate parameter to the > relevant init functions; wouldn't that make the patch much smaller? OK point taken, I'm sending a v2... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to major

[PATCH v2] pinctrl/nomadik: make independent of prcmu driver

2012-11-09 Thread Linus Walleij
ction. Take this opportunity to add kerneldoc to the pinctrl state container. Cc: Loic Pallardy Signed-off-by: Jonas Aaberg Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Have the pointer in the pin controller state container instead of as part of SoC data. --- drivers/pinctrl

[PATCH] pinctrl/nomadik: db8540: fix moduartstmmux_oc4_1 pin group definition.

2012-11-09 Thread Linus Walleij
From: Jean-Nicolas Graux One group definition was missing, so add it. Signed-off-by: Jean-Nicolas Graux Signed-off-by: Linus Walleij --- drivers/pinctrl/pinctrl-nomadik-db8540.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/pinctrl-nomadik-db8540.c b/drivers/pinctrl

[PATCH] RFC: pinctrl: grab default handler with bus notifiers

2012-11-11 Thread Linus Walleij
From: Linus Walleij This makes the pinctrl subsystem auto-grab the pinctrl handle and set the "default" (PINCTRL_STATE_DEFAULT) state for every device that is present on the platform or AMBA (PrimeCell) bus right before probe. This will account for the lion's share of embedded

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-11-11 Thread Linus Walleij
On Thu, Nov 1, 2012 at 3:01 PM, Linus Walleij wrote: > On Thu, Nov 1, 2012 at 1:07 PM, Mark Brown > wrote: >> On Thu, Nov 01, 2012 at 09:54:00AM +0100, Linus Walleij wrote: > >> For the pin hogging I'd actually been thinking separately that we should >>

Re: [PATCH] pinctrl: Staticize pinconf_ops

2012-11-11 Thread Linus Walleij
OK I had to merge down all my topic branches to the devel branch to apply this on top, but we are at -rc5 so it's about time! Applied with Dong's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to m

Re: [PATCH] pinctrl: samsung: Remove a redundant settting for ctrldesc->npins

2012-11-11 Thread Linus Walleij
On Tue, Nov 6, 2012 at 4:28 PM, Axel Lin wrote: > Set it once is enough. > > Signed-off-by: Axel Lin Applied with Kyungmin's ACK, thanks! Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord

Re: [PATCH 1/2] pinctrl: lantiq: Remove ltq_pmx_disable() function

2012-11-11 Thread Linus Walleij
gt; Thus remove ltq_pmx_disable() function. > > Signed-off-by: Axel Lin Applied with John's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http:/

Re: [PATCH 2/2] pinctrl: lantiq: Staticize non-exported symbols

2012-11-11 Thread Linus Walleij
On Wed, Nov 7, 2012 at 5:10 PM, Axel Lin wrote: > Both ltq_pinctrl_dt_node_to_map() and ltq_pinctrl_dt_free_map() are not > referenced outside of this file. Make them static. > > Signed-off-by: Axel Lin Applied with John's ACK. Yours, Linus Walleij -- To unsubscribe from th

Re: [PATCH] pwm-backlight: Pinctrl-fy

2012-11-11 Thread Linus Walleij
you need to bail out and be revisited later. On a related key we have this debate going on with some subsystem maintainers as to whether we should try do centralize boilerplate like this, the lates suggestion is: http://marc.info/?l=linux-kernel&m=135263661110528&w=2 The fun never ends... You

Re: [PATCH v2] pinctrl/nomadik: make independent of prcmu driver

2012-11-11 Thread Linus Walleij
;s been in for a while, so this patch in itself is not making things more fragile, it came with the first Alt-Cx patch. So it is indeed based on good faith in the maps. I'm poking Jean-Nicolas to have a look at hardening this with some check, ping! > Aside from that, this seems fine. Much

Re: [PATCH] pinctrl: pinmux: Release all taken pins in pinmux_enable_setting error paths

2012-11-11 Thread Linus Walleij
a pretty important fix Axel! :-) Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: linux-next: manual merge of the arm-soc tree with the pinctrl tree

2012-12-25 Thread Linus Walleij
already sent to Linus Torvalds via arm-soc > tree today. In addition, I applied with Linus Walleij's ack ;-) > > Linus Walleij, please drop the patch in your tree. Sorry I didn't notify > about that when I got the patch from Choi. OK dropped it, sorry for the delay... Yours,

Re: [PATCH 4/4 v2] net/smsc911x: Provide common clock functionality

2012-12-25 Thread Linus Walleij
*/ > + if (IS_ERR(pdata->clk)) { > + clk_put(pdata->clk); > + pdata->clk = NULL; > + } Should be !IS_ERR() Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[GIT PULL] pinctrl fixes for v3.8

2013-01-02 Thread Linus Walleij
Hi Linus, these are the first few pinctrl fixes for the v3.8 cycle, the information is in the signed tag as usual. Please pull it in! Yours, Linus Walleij The following changes since commit a49f0d1ea3ec94fc7cf33a7c36a16343b74bd565: Linux 3.8-rc1 (2012-12-21 17:19:00 -0800) are available in

[PATCH] mfd: tc3589x: use simple irqdomain

2013-01-02 Thread Linus Walleij
e Jones Signed-off-by: Linus Walleij --- Hi Sam, this should go into the fixes for stable unless issues are found, it fixes a regression for us. --- drivers/mfd/tc3589x.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/

[PATCH v2] mfd: tc3589x: use simple irqdomain

2013-01-02 Thread Linus Walleij
e we're at it. Cc: sta...@kernel.org Acked-by: Lee Jones Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Update commit message after comments from Lee, add ACK, no changes to the patche per se. Hi Sam, this should go into the fixes for stable unless issues are found, it fixes a

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-02 Thread Linus Walleij
On Wed, Dec 12, 2012 at 10:54 PM, Greg Kroah-Hartman wrote: > On Wed, Dec 12, 2012 at 09:25:07PM +0100, Linus Walleij wrote: >> From: Linus Walleij >> >> This makes the device core auto-grab the pinctrl handle and set >> the "default" (PINCTRL_STATE_DEFAU

Re: [PATCH 4/4 v3] net/smsc911x: Provide common clock functionality

2013-01-03 Thread Linus Walleij
continue to assume that no clock > is required for the chip to run successfully. > > Cc: Steve Glendinning > Cc: net...@vger.kernel.org > Signed-off-by: Lee Jones Looks all right to me now: Reviewed-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send

[PATCH v3] pinctrl/nomadik: add device tree support

2013-01-03 Thread Linus Walleij
From: Gabriel Fernandez This implements pin multiplexing and pin configuration for the Nomadik pin controller using the device tree. Signed-off-by: Gabriel Fernandez Reviewed-by: Stephen Warren Reviewed-by: Philippe Langlais Signed-off-by: Linus Walleij --- ChangeLog v2->v3: - Repl

Re: [PATCH 00/21] gpio: ab8500: Bring AB8500 back to life

2013-01-04 Thread Linus Walleij
On Wed, Dec 19, 2012 at 3:18 PM, Linus Walleij wrote: > On Fri, Dec 14, 2012 at 5:19 PM, Lee Jones wrote: > >> The ab8500 GPIO driver is currently 'BROKEN', due to a lack of >> updates and recent frame-work adoption. This patch-set aims to >> bring the driver

[PATCH] pinctrl/nomadik: Add "ste,config" property

2013-01-04 Thread Linus Walleij
From: Gabriel Fernandez The "ste,config" property will contain the pin config node. It will be easier to define a pin configuration and use it by reference without duplicating lines tedious. Signed-off-by: Gabriel Fernandez Signed-off-by: Linus Walleij --- This is made as an add-o

[PATCH] pinctrl: add pinconf-generic defines for output

2013-01-04 Thread Linus Walleij
From: Linus Walleij This adds a definition of a generic output configuration for a certain pin when using the generic pin configuration library. Whereas driving pins low/high is usually a GPIO business, you may want to set up pins into a default state using hogs, and never touch them again. This

Re: [PATCH 00/21] gpio: ab8500: Bring AB8500 back to life

2012-12-19 Thread Linus Walleij
two pin controllers and the first with an off-SoC pin controller. But any cleanups are welcome now, and I know you're already up to more patching... Let us make sure we chisel out a real nice pinctrl/pinctrl-abx500.c driver by the end of this kernel cycle so things are under (pin)control again.

[PATCH] mfd: db8500-prcmu: fix irqdomain usage

2012-12-19 Thread Linus Walleij
From: Linus Walleij This fixes two issues with the DB8500 PRCMU irqdomain: - You have to state the irq base 0 to get a linear domain for the DT case from irq_domain_add_simple() - The irqdomain was not used to translate the initial irq request using irq_create_mapping() making the linear

Re: [PATCH 0/2] clocksource: nomadik-mtu: support timer-based delay

2012-12-19 Thread Linus Walleij
On Mon, Dec 17, 2012 at 7:59 PM, John Stultz wrote: > On 12/17/2012 10:38 AM, Linus Walleij wrote: >> >> On Mon, Dec 17, 2012 at 12:36 PM, Fabio Baltieri >> wrote: >>> >>> On Tue, Dec 04, 2012 at 11:10:43AM +0100, Fabio Baltieri wrote: >>>>

[PATCH v2] pinctrl/nomadik: add device tree support

2012-12-20 Thread Linus Walleij
From: Gabriel Fernandez This implements pin multiplexing and pin configuration for the Nomadik pin controller using the device tree. Signed-off-by: Gabriel Fernandez Reviewed-by: Philippe Langlais Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Fix use of - (dash) over underscore

Re: [PATCH] mfd: db8500-prcmu: fix irqdomain usage

2012-12-20 Thread Linus Walleij
not quite trivial to use ... irqdomain seems like it will bite us repeatedly for the next few years. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH v2] mfd: db8500-prcmu: fix irqdomain usage

2012-12-20 Thread Linus Walleij
From: Linus Walleij This fixes two issues with the DB8500 PRCMU irqdomain: - You have to state the irq base 0 to get a linear domain for the DT case from irq_domain_add_simple() - The irqdomain was not used to translate the initial irq request using irq_create_mapping() making the linear

Re: [PATCH] mfd: support stmpe1801 18 bits enhanced port expander

2012-12-20 Thread Linus Walleij
s not supported yet. > > Signed-off-by: Jean-Nicolas Graux Acked-by: Linus Walleij Albeit I've looked at it already during development so it'd be nice to get a second opinion from Grant on the GPIO portions. Yours, Linus Walleij -- To unsubscribe from this list: send the line &q

Re: [PATCH 2/2] ARM: ux500: add pinctrl address resources

2012-12-20 Thread Linus Walleij
nctrl"; I inserted a comment here like this: pinctrl@80157000 { + // This is actually the PRCMU base address reg = <0x80157000 0x2000>; Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-k

Re: [PATCH 1/2] pinctrl: samsung: Fix compile error in pinctrl-exynos5440/samsung.c

2012-12-20 Thread Linus Walleij
On Mon, Dec 17, 2012 at 3:02 AM, Jonghwan Choi wrote: > error: drivers/pinctrl/pinctrl-exynos5440.o: multiple definition of 'pcfgs' > drivers/pinctrl/pinctrl-samsung.o: previous definition here > > Signed-off-by: Jonghwan Choi Patch applied. Yours, Linus Walleij -- To

Re: [PATCH 2/2] pinctrl: exynos5440: Fix compile error in pinctrl-exynos5440/samsung.c

2012-12-20 Thread Linus Walleij
On Mon, Dec 17, 2012 at 3:03 AM, Jonghwan Choi wrote: > error: drivers/pinctrl/pinctrl-exynos5440.o: multiple definition of 'pcfgs' > drivers/pinctrl/pinctrl-samsung.o: previous definition here > > Signed-off-by: Jonghwan Choi Patch applied. Yours, Linus Walleij -- To

Re: [PATCH 0/9] drivers: mailbox: framework creation

2012-12-20 Thread Linus Walleij
patch series so you have my Acked-by. Since it's a new subsystem and affects a few ARM architectures can we merge this into the ARM SoC tree once we have consensus, so we get some rotation in linux-next that way? Olof/Arnd? Yours, Linus Walleij -- To unsubscribe from this list: send the line &

Re: [PATCH 1/4] ARM: ux500: Provide a means to obtain the SMSC9115 clock when DT is enabled

2012-12-20 Thread Linus Walleij
n be used in searches during allocation time. > > Signed-off-by: Lee Jones Acked-by: Linus Walleij I think that the best way to fix this regression is to gather ACKs from the involved subsystems and push it throug ARM SoC directly. I thing Cc: sta...@kernel.org needs to be added to all patc

Re: [PATCH 4/4] net/smsc911x: Provide common clock functionality

2012-12-20 Thread Linus Walleij
continue to assume that no clock > is required for the chip to run successfully. > > Cc: Steve Glendinning > Cc: net...@vger.kernel.org > Signed-off-by: Lee Jones Seems to me like it'll do the trick. Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this

Re: [PATCH] RFC: pinctrl: grab default handler with bus notifiers

2012-11-15 Thread Linus Walleij
so desired for consistency we can define something like #define PINCTRL_STATE_DECOUPLED "decoupled" in include/linux/pinctrl/pinctrl-state.h to clearly mark that this is a state where the device is not using any pins at all. Yours, Linus Walleij Yours, Linus Walleij -- To unsubscribe fr

Re: [PATCH 1/1] ARM: ux500: Describe UART platform registering issues more accurately

2012-11-15 Thread Linus Walleij
ones Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/2] Boottime: A tool for automatic measurement of kernel/bootloader boot time

2012-11-15 Thread Linus Walleij
memory size etc so this would probably be done the same way: a standard binding like for everything else, then put the data in there. I don't know if Lee has a modifiable U-boot to try out such concepts on though? Yours, Linus Walleij -- To unsubscribe from this list: send the line "uns

Re: [PATCH] pinctrl: nomadik: Staticize non-exported symbols

2012-11-15 Thread Linus Walleij
On Thu, Nov 15, 2012 at 5:01 PM, Axel Lin wrote: > They are not referenced outside of this file, make them static. > > Signed-off-by: Axel Lin Applied with Lee's ACK, thanks! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [RFC] staging: ste_rmi4: merge into the main kernel tree

2012-11-15 Thread Linus Walleij
d device tree support, of course, that would decopule it completely from the platform using it. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel

Re: [RFC] staging: ste_rmi4: merge into the main kernel tree

2012-11-15 Thread Linus Walleij
On Thu, Nov 15, 2012 at 7:55 PM, Dmitry Torokhov wrote: > On Thu, Nov 15, 2012 at 06:41:26PM +0100, Linus Walleij wrote: >> >> The benefit is that the ugliness in >> drivers/staging/ste_rmi4/board-mop500-u8500uib-rmi4.c >> can be avoided, as today we're unable to

Re: [PATCH] RFC: pinctrl: grab default handler with bus notifiers

2012-11-16 Thread Linus Walleij
On Thu, Nov 15, 2012 at 7:23 PM, Stephen Warren wrote: > On 11/15/2012 07:03 AM, Linus Walleij wrote: >> OK I'll have to come up with a patch to the device core >> instead... it'll be much simpler anyway and if both of you guys >> can back it I guess Greg might be

Re: [PATCH] ARM: integrator: use BUG_ON where possible

2012-11-17 Thread Linus Walleij
On Mon, Nov 12, 2012 at 9:44 PM, Arnd Bergmann wrote: >> Signed-off-by: Sasha Levin > > Linus Walleij is doing most of the integrator work these days, maybe he > wants to apply the patch. > > Acked-by: Arnd Bergmann OK I'll apply it to my stash and submit a pull requ

Re: [PATCH V2] gpio: tegra: read output value when gpio is set in direction_out

2012-11-17 Thread Linus Walleij
On Fri, Nov 9, 2012 at 7:04 AM, Laxman Dewangan wrote: > Read the output value when gpio is set for the output mode for > gpio_get_value(). Reading input value in direction out does not > give correct value. > > Signed-off-by: Laxman Dewangan Applied v2 with Stephen'

Re: [PATCH] gpio: twl4030: Use only TWL4030_MODULE_LED for LED configuration

2012-11-17 Thread Linus Walleij
; No functional changes. > > Signed-off-by: Peter Ujfalusi OK if you say so. Patch applied! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger

Re: [PATCH] gpio: gpio-max710x: Support device tree probing

2012-11-17 Thread Linus Walleij
On Thu, Nov 15, 2012 at 2:59 PM, Roland Stigge wrote: > For probing via device tree, we need to support the case without > platform_data. > In this case, chip.base is set to -1 for automatic numbering. > > Signed-off-by: Roland Stigge Patch applied with Wolfram's ACK. T

Re: [PATCH 06/14] pinctrl: samsung: Update error check for unsigned variables

2012-11-17 Thread Linus Walleij
On Fri, Nov 16, 2012 at 7:50 AM, Tushar Behera wrote: > Checking '< 0' for unsigned variables always returns false. For error > codes, use IS_ERR_VALUE() instead. > > CC: Linus Walleij > Signed-off-by: Tushar Behera > --- > drivers/pinctrl/pinctrl-samsung

[GIT PULL] gpio fixes for v3.7

2012-11-17 Thread Linus Walleij
Hi Linus, hopefully these are the last few GPIO fixes for this merge window. Info is in the tag as usual. Please pull them in. Yours, Linus Walleij The following changes since commit 77b67063bb6bce6d475e910d3b886a606d0d91f7: Linux 3.7-rc5 (2012-11-11 13:44:33 +0100) are available in the

Re: [RFC PATCH 01/06] input/rmi4: Public header and documentation

2012-11-17 Thread Linus Walleij
les, one for debugfs and one for > sysfs. > > > Signed-off-by: Christopher Heiny > Cut this white line. > Cc: Dmitry Torokhov > Cc: Linus Walleij > Cc: Naveen Kumar Gaddipati > Cc: Joeri de Gram There is always room for improvement, but you've done a massive job

Re: [RFC PATCH 02/06] input/rmi4: Core files

2012-11-17 Thread Linus Walleij
ts from Greg & Dmitry, which will probably be just as demanding :-) But FWIW: Reviewed-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

Re: [RFC PATCH 03/06] input/rmi4: I2C physical interface

2012-11-17 Thread Linus Walleij
t; select is dependent on the physical layer used to communicate with the RMi4 > device). > > > Signed-off-by: Christopher Heiny > Cut that blank line on all patches. > Cc: Dmitry Torokhov > Cc: Linus Walleij > Cc: Naveen Kumar Gaddipati > Cc: Joeri de Gram >

Re: [RFC PATCH 04/06] input/rmi4: Config files and makefiles

2012-11-17 Thread Linus Walleij
On Sat, Nov 17, 2012 at 4:58 AM, Christopher Heiny wrote: > Infrastructure files for configuration and building. > > > Signed-off-by: Christopher Heiny > Cut blank line. > Cc: Dmitry Torokhov > Cc: Linus Walleij > Cc: Naveen Kumar Gaddipati > Cc: Joeri de Gram

Re: [RFC PATCH 06/06] input/rmi4: F11 - 2D touch interface

2012-11-17 Thread Linus Walleij
is included for > certain legacy sensors. > > > Signed-off-by: Christopher Heiny > Cut blank line. > To: Henrik Rydberg > Cc: Dmitry Torokhov > Cc: Linus Walleij > Cc: Naveen Kumar Gaddipati > Cc: Joeri de Gram I'm happy. Now you only need to convinc

Re: [RFC PATCH 05/06] input/rmi4: F01 - device control

2012-11-17 Thread Linus Walleij
irmware reflash). > > > Signed-off-by: Christopher Heiny > Cut blank line. > Cc: Dmitry Torokhov > Cc: Linus Walleij > Cc: Naveen Kumar Gaddipati > Cc: Joeri de Gram All other comments I've had appear to be fixed. Reviewed-by: Linus Walleij Yours, Linus Walleij --

Re: [PATCH V2 RESEND] gpio: tegra: read output value when gpio is set in direction_out

2012-11-17 Thread Linus Walleij
. sorry no clue why you haven't seen it? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] gpio: twl4030: Use only TWL4030_MODULE_LED for LED configuration

2012-11-19 Thread Linus Walleij
-specific PWM, being used as a PWM with eternal dutycycle and then being used as GPIO. Well, we get to deal with it ... :-/ Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo in

[PATCH] gpiolib: let gpiochip_add_pin_range() specify offset

2012-11-20 Thread Linus Walleij
From: Linus Walleij Like with commit 3c739ad0df5eb41cd7adad879eda6aa09879eb76 it is not always enough to specify all the pins of a gpio_chip from offset zero to be added to a pin map range, since the mapping from GPIO to pin controller may not be linear at all, but need to be broken into a few

Re: [PATCH] gpiolib: let gpiochip_add_pin_range() specify offset

2012-11-20 Thread Linus Walleij
On Tue, Nov 20, 2012 at 1:55 PM, Viresh Kumar wrote: > On 20 November 2012 17:15, Linus Walleij wrote: >> From: Linus Walleij >> >> Like with commit 3c739ad0df5eb41cd7adad879eda6aa09879eb76 >> it is not always enough to specify all the pins of a gpio_chip >>

[PATCH 3/7] pinctrl: make range registration defer properly

2012-11-20 Thread Linus Walleij
From: Linus Walleij This makes the pinctrl_find_and_add_gpio_range() return -EPROBE_DEFER if the range hosting pin controller cannot be located. We may assume that the common case for why adding a range fails is that the targe pin controller device has not probed yet. Signed-off-by: Linus

[PATCH 2/7] gpiolib: rename find_pinctrl_*

2012-11-20 Thread Linus Walleij
From: Linus Walleij Rename the function find_pinctrl_and_add_gpio_range() to pinctrl_find_and_add_gpio_range() so as to be consistent with the rest of the functions. Signed-off-by: Linus Walleij --- drivers/gpio/gpiolib.c | 2 +- drivers/pinctrl/core.c | 4 ++-- include

[PATCH 1/7 v2] gpiolib: let gpiochip_add_pin_range() specify offset

2012-11-20 Thread Linus Walleij
From: Linus Walleij Like with commit 3c739ad0df5eb41cd7adad879eda6aa09879eb76 it is not always enough to specify all the pins of a gpio_chip from offset zero to be added to a pin map range, since the mapping from GPIO to pin controller may not be linear at all, but need to be broken into a few

[PATCH 4/7] gpiolib: return any error code from range creation

2012-11-20 Thread Linus Walleij
From: Linus Walleij If we try to create a range for a certain GPIO chip and the target pin controller is not yet available it may return a probe deferral error code, so handle this all the way our by checking the error code. Signed-off-by: Linus Walleij --- drivers/gpio/gpiolib.c | 3 ++- 1

[PATCH 5/7] pinctrl: add function to retrieve range from pin

2012-11-20 Thread Linus Walleij
From: Linus Walleij This adds a function to the pinctrl core to retrieve the GPIO range associated with a certain pin for a certain controller. This is needed when a pinctrl driver want to look up the corresponding struct gpio_chip for a certain pin. As the GPIO drivers can now create these

[PATCH 7/7] pinctrl/u300/coh901: stop spawning pinctrl from GPIO

2012-11-20 Thread Linus Walleij
From: Linus Walleij Let's stop spawning the pinctrl driver from the GPIO driver, we have these two mechanisms broken apart now, and they can each probe in isolation. If the GPIO driver cannot find its pin controller (pinctrl-u300), the pin controller core will tell it to defer probing. S

[PATCH 6/7] pinctrl/u300/coh901: let the gpio_chip register the range

2012-11-20 Thread Linus Walleij
From: Linus Walleij Instead of having the pinctrl driver register the GPIO range for the gpio_chip, making it necessary to instantiate the pin controller from the GPIO driver and pass the GPIO chip as platform data, now let the GPIO chip driver register it's own ranges and have the pi

Re: [PATCH] gpio: twl4030: Use only TWL4030_MODULE_LED for LED configuration

2012-11-20 Thread Linus Walleij
On Mon, Nov 19, 2012 at 1:19 PM, Peter Ujfalusi wrote: > On 11/19/2012 11:40 AM, Linus Walleij wrote: >> So what we're dealing with is: a LED-specific PWM, being used >> as a PWM with eternal dutycycle and then being used as GPIO. >> >> Well, we get to deal w

Re: [GIT PULL] at91: fixes for 3.7-rc7

2012-11-20 Thread Linus Walleij
On Mon, Nov 19, 2012 at 6:29 PM, Nicolas Ferre wrote: > If you do not take it for 3.7, maybe we will have to queue these patches > on top of our AT91 pinctrl work (on Linus Walleij side), so, you do need > to queue this one for the moment... Tell me what the outcome is, if I should m

Re: [PATCH 1/2] pinmux: Add TB10x pinmux driver

2013-04-17 Thread Linus Walleij
state->pctl)) { > + dev_err(&pdev->dev, "could not register TB10x pin driver\n"); > + ret = PTR_ERR(state->pctl); > + goto pinctrl_reg_fail; > + } > + > + return 0; > + > +pinctrl_reg_fail: > +

Re: [PATCH 2/2] GPIO: Add TB10x GPIO driver

2013-04-17 Thread Linus Walleij
ret = -ENOMEM; > + goto fail_irq_domain; > + } > + } This part looks nice! > +fail_irq_domain: > + free_irq(tb10x_gpio->irq, tb10x_gpio); > +fail_request_irq: > +fail_get_irq: > + ret = gpiochip_remove(&tb10x_gpio->g

Re: [PATCH v2] UCB1400: Pass ucb1400-gpio data through ac97 bus

2013-04-17 Thread Linus Walleij
On Sun, Apr 14, 2013 at 8:35 PM, Marek Vasut wrote: > Cc: Linus Walleij > Cc: Jean Delvare > Cc: Samuel Ortiz > Cc: Mark Brown > Cc: Guenter Roeck > Cc: linux-kernel > Cc: Grant Likely > Signed-off-by: Marek Vasut Acked-by: Linus Walleij Sam, please pick it u

Re: [Linaro-QA-Service] [linux-next] Snowball build broken

2013-04-17 Thread Linus Walleij
On Tue, Apr 16, 2013 at 3:48 PM, Naresh Kamboju wrote: > On 12 April 2013 04:07, Linus Walleij wrote: >> Hey it works. Didn't see this before I fixed it tho :-) >> http://marc.info/?l=linux-kernel&m=136567139910888&w=2 > > This commit not yet been merged in to

Re: [RFC] Pinctrl: driver design supporting gpiolib

2013-04-17 Thread Linus Walleij
ay. > Solution For usecase 3) Have the client use the above 2 solutions > for respective situations. Yes pinctrl and GPIO can be used at the same time. > Please let me know if you believe there is a better way to handle use case 2 > and 3 No I think you've got it! :-) Y

Re: [PATCH 1/2] gpio: samsung: Remove OF support for s3c24xx

2013-04-17 Thread Linus Walleij
his reverts commit 172c6a13653ac8cd6a231293b87c93821e90c1d6 > gpio: samsung: add devicetree init for s3c24xx arches > > Cc: Heiko Stübner > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park Acked-by: Linus Walleij I guess this goes to go into the Samsung tree

Re: [PATCH RFC 2/2] gpio: samsung: Remove OF support for Exynos4/5

2013-04-17 Thread Linus Walleij
*/ > + if (of_have_populated_dt()) > + return -ENODEV; > > samsung_gpiolib_set_cfg(samsung_gpio_cfgs, > ARRAY_SIZE(samsung_gpio_cfgs)); Oh is that how you do it? It looks fragile. Can't you check if you have the pinctrl node atleast? Yours, Linus Walleij --

Re: [PATCH] pinctrl: pinctrl-abx500: fix issue when no pdata

2013-04-18 Thread Linus Walleij
On Thu, Apr 18, 2013 at 9:15 AM, Patrice CHOTARD wrote: > Fix an issue when probing pinctrl-abx500 with no > platform data > > Signed-off-by: Patrice Chotard Patch applied, thanks! Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&

<    5   6   7   8   9   10   11   12   13   14   >