The error check in cpsw_probe_dt() has an '&&' where an '||' is
meant to be. This causes a NULL pointer dereference when incomplet DT
data is passed to the driver ('phy_id' property for cpsw_emac1
missing).
Signed-off-by: Lothar Waßmann
---
drivers/net
mach-omap2/omap_device.c:821:3: warning: return makes pointer from
integer without a cast
arch/arm/mach-omap2/omap_device.c:826:3: warning: return makes pointer from
integer without a cast
Signed-off-by: Lothar Waßmann
---
arch/arm/mach-omap2/omap_device.c |4 ++--
1 files changed, 2 insert
und has to be enabled in the driver. The mx28 has this
> >> bug
> >> fixed, so we don't need this quite costly workaround.
> >
> > What about defining in imx28.dtsi:
> > compatible = "fsl,imx28-flexcan".
>
> It already works with changi
case, we could end up with similar issues.
>
This has already been fixed in commit:
e98b44e9 usb: chipidea: prevent endless loop registering platform_devices when
probe fails
in linux-next
Lothar Waßmann
--
___
Ka-Ro electronics GmbH | Pas
rtc_device_release().
Signed-off-by: Lothar Waßmann
---
drivers/rtc/class.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/rtc/class.c b/drivers/rtc/class.c
index f8a0aab..5143629 100644
--- a/drivers/rtc/class.c
+++ b/drivers/rtc/class.c
@@ -244,7 +244,6 @@ void
compiling the i.MX pwm driver produces the following warning:
|drivers/pwm/pwm-imx.c: In function 'imx_pwm_probe':
|drivers/pwm/pwm-imx.c:281:7: warning: assignment discards qualifiers from
pointer target type
Apply a 'const' attribute to the affected variable declaration.
S
()
Signed-off-by: Lothar Waßmann
---
drivers/mtd/nand/mxc_nand.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index d316324..d965809 100644
--- a/drivers/mtd/nand/mxc_nand.c
+++ b/drivers/mtd/nand/mxc_nand.c
#x27; to 'const char const *' as advised by checkpatch.pl
Signed-off-by: Lothar Waßmann
---
drivers/mtd/nand/mxc_nand.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index d316324..fb98775 100644
-
kfree(imx_drm_encoder) is already being called at the label
'err_register'.
Signed-off-by: Lothar Waßmann
---
drivers/staging/imx-drm/imx-drm-core.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-drm-core.c
b/drivers/staging/imx-d
- convert bogus IS_ERR_OR_NULL() to IS_ERR()
- fix copy/paste error
- check return value of ipu_crtc_init()
Signed-off-by: Lothar Waßmann
---
drivers/staging/imx-drm/ipuv3-crtc.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c
ipu_reset() can fail with a timeout. Check the return value and act
appropriately.
Signed-off-by: Lothar Waßmann
---
drivers/staging/imx-drm/ipu-v3/ipu-common.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-common.c
b/drivers
om getting stuck in this case.
Signed-off-by: Lothar Waßmann
---
drivers/rtc/rtc-stmp3xxx.c | 35 +--
1 files changed, 25 insertions(+), 10 deletions(-)
diff --git a/drivers/rtc/rtc-stmp3xxx.c b/drivers/rtc/rtc-stmp3xxx.c
index 767fee2..2601953 100644
--- a/drive
Signed-off-by: Lothar Waßmann
---
drivers/dma/of-dma.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c
index 75334bd..0b88dd3 100644
--- a/drivers/dma/of-dma.c
+++ b/drivers/dma/of-dma.c
@@ -160,7 +160,8 @@ struct dma_chan
mamux->clk);
> +
> + clk_prepare_enable(fsl_edmamux->clk);
>
What, if this fails?
> +
> + ret = of_property_read_u32_index(phandle, "fsl,dmamux-id", 0,
> + &fsl_edmamux->mux_id);
> + if (ret)
> +
return 0;
}
return 1;
}
#else /* CONFIG_USE_GENERIC_SMP_HELPERS */
static int __try_remote_softirq(struct call_single_data *cp, int cpu, int
softirq)
{
return 1;
}
#endif
Lothar Waßmann
--
___
Ka-Ro electr
Signed-off-by: Lothar Waßmann
---
drivers/usb/chipidea/core.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index b726c49..bd6e7a4 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
Signed-off-by: Lothar Waßmann
---
sound/soc/mxs/mxs-saif.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/soc/mxs/mxs-saif.c b/sound/soc/mxs/mxs-saif.c
index c294fbb..f1d1f9e 100644
--- a/sound/soc/mxs/mxs-saif.c
+++ b/sound/soc/mxs/mxs-saif.c
@@ -229,6 +229,7
Signed-off-by: Lothar Waßmann
---
sound/soc/soc-dmaengine-pcm.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/soc/soc-dmaengine-pcm.c b/sound/soc/soc-dmaengine-pcm.c
index bbc1257..111b7d92 100644
--- a/sound/soc/soc-dmaengine-pcm.c
+++ b/sound/soc/soc
The pointer to a platform_device struct must not be dereferenced after
the device has been unregistered.
This bug produces a crash when unloading the ci13xxx kernel module
compiled with CONFIG_PAGE_POISONING enabled.
Signed-off-by: Lothar Waßmann
---
drivers/usb/chipidea/core.c |3 ++-
1
set the 'onwer' field of the registered snd_soc_card object to prevent
removal of the module when its resources are in use.
Signed-off-by: Lothar Waßmann
---
sound/soc/fsl/imx-sgtl5000.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/fsl/imx-sg
also set MODULE_AUTHOR and MODULE_DESCRIPTION
Signed-off-by: Lothar Waßmann
---
sound/soc/fsl/imx-pcm.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/sound/soc/fsl/imx-pcm.c b/sound/soc/fsl/imx-pcm.c
index 93dc360..d5cd9ef 100644
--- a/sound/soc/fsl/imx-pcm.c
+++ b
Due to a broken make rule, imx-pcm-dma.c or imx-pcm-fiq.c (whatever is
selected via Kconfig) will not be compiled when building as module,
resulting in a non-functional sound driver.
Signed-off-by: Lothar Waßmann
---
sound/soc/fsl/Makefile |8 ++--
1 files changed, 6 insertions(+), 2
Hi,
Mark Brown writes:
> On Thu, Nov 22, 2012 at 01:31:06PM +0100, Lothar Waßmann wrote:
>
> > obj-$(CONFIG_SND_SOC_IMX_PCM) += snd-soc-imx-pcm.o
> > snd-soc-imx-pcm-y := imx-pcm.o
> > -snd-soc-imx-pcm-$(CONFIG_SND_SOC_IMX_PCM_FIQ) += imx-pcm-fi
Hi,
> On Thu, Nov 22, 2012 at 01:31:09PM +0100, Lothar Waßmann wrote:
> >
> > Signed-off-by: Lothar Waßmann
>
> Why?
>
I thought that was obvious... To be able to compile the mxs sound
driver as module.
Lothar Waßmann
--
__
l5000 <-> 63fcc000.ssi mapping ok
Signed-off-by: Lothar Waßmann
---
sound/soc/fsl/Makefile | 10 +++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/sound/soc/fsl/Makefile b/sound/soc/fsl/Makefile
index 515ba66..afd3479 100644
--- a/sound/soc/fsl/Makefile
+++ b/so
Hi,
Mark Brown writes:
> On Fri, Nov 23, 2012 at 10:12:13AM +0100, Lothar Waßmann wrote:
> > Due to a broken make rule, sound/soc/fsl/imx-pcm-dma.c or
> > sound/soc/fsl/imx-pcm-fiq.c (whatever is selected via Kconfig) will
> > not be compiled into imx-pcm.o when bu
Hi,
Mark Brown writes:
> On Fri, Nov 23, 2012 at 08:21:22AM +0100, Lothar Waßmann wrote:
> > > On Thu, Nov 22, 2012 at 01:31:09PM +0100, Lothar Waßmann wrote:
>
> > > Why?
>
> > I thought that was obvious... To be able to compile the mxs sound
> > driver
7;y' when selected.
Signed-off-by: Lothar Waßmann
---
sound/soc/fsl/Kconfig |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 10fd172..3b98159 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -112,
Hi,
On Fri, 17 Jun 2016 15:17:19 +0100 Lee Jones wrote:
> On Sat, 11 Jun 2016, Lothar Waßmann wrote:
> > On Fri, 10 Jun 2016 15:54:49 +0100 Lee Jones wrote:
> > > On Fri, 10 Jun 2016, Lothar Waßmann wrote:
> > > > On Fri, 10 Jun 2016 08:44:49 +0100 Lee Jones wrote:
Hi,
On Mon, 16 Oct 2017 09:17:26 +0200 Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Oct 11, 2017 at 01:05:38PM +0200, Lothar Waßmann wrote:
> > diff --git a/arch/arm/boot/dts/imx28-tx28.dts
> > b/arch/arm/boot/dts/imx28-tx28.dts
> > index 211e67d..3c852f7 100644
Hi,
On Mon, 16 Oct 2017 17:13:29 -0500 Rob Herring wrote:
> On Wed, Oct 11, 2017 at 6:23 AM, Lothar Waßmann
> wrote:
> > The Ka-Ro electronics MB7 baseboard has an on-board LCD->LVDS
> > converter that requires a fixed pixelclk polarity, no matter what the
> > pan
The 'ipu1' alias is already defined in imx6q.dtsi. There is no need to
redefine it here.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6q-tx6q-11x0-mb7.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6q-tx6q-11x0-mb7.dts
b/arch/arm/boot/dts/imx6q
This patchset updates the dts files for the Ka-Ro electronics GmbH TX6
module series and adds some include files to facilitate supporting
various SoM/baseboard combinations.
Changes vs. v1:
- rebased to imx/dt branch
- eliminate use of 'interrupts-extended' property according to Uwe
Kleine-König
Currently the display (LCD or LVDS) configuration is duplicated with
slight variations in each TX6 module specific file.
Move it to an include file for simplification and consistency.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6dl-tx6dl-comtft.dts| 74 +--
arch/arm/boot
The current TX6Q module HW revision is 3 reflected in the module name
suffix '-1030' (-1130 for LVDS).
Change the model string to prevent confusion about what DTS file to
use for these modules.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6q-tx6q-1010.dts | 4 ++--
arch/ar
As the DS1339 driver now supports enabling the trickle charge feature
via DTB, add the appropriate properties to utilize this feature.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi
b
Create .dts files for various Ka-Ro electronics TX modules on the MB7
baseboard.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/Makefile | 8
arch/arm/boot/dts/imx6dl-tx6s-8034-mb7.dts | 48
arch/arm/boot/dts/imx6dl-tx6s-8035-mb7.dts | 48
Move the MB7 specific settings to a separate .dtsi file to facilitate
supporting more module variants with this baseboard.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6dl-tx6u-81xx-mb7.dts | 9 +--
arch/arm/boot/dts/imx6q-tx6q-11x0-mb7.dts | 42 +
arch/arm/boot/dts
pinctrl settings from the PHY subnode to the FEC node.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 20 +++-
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi
b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
index a50bf71
Convert the DTS sound setup to use the simple-audio-card driver.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 50 --
1 file changed, 42 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi
b/arch/arm/boot
Define the required properties to enable I2C bus recovery supported by
the I2C subsystem.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi
b/arch
The display, that incorporates this touchpanel is obsolete and won't
be supported any more.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6dl-tx6u-811x.dts | 23 +--
arch/arm/boot/dts/imx6dl-tx6u-81xx-mb7.dts | 22 +-
arch/arm/boot/dts/
Under certain circumstances the ethernet PHY cannot be detected on
Ka-Ro electronics TX6 modules. Using a phy-reset-post-delay of at least
2ms alleviates this problem. Define it to 10ms to be on the safe side.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 1 +
1 file
-DIMM
Temp. Range -40°C to 105°C
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/Makefile | 2 +
arch/arm/boot/dts/imx6qp-tx6qp-8037.dts | 86 +++
arch/arm/boot/dts/imx6qp-tx6qp-8137.dts | 90 +
3 files changed, 178
Define the required properties to enable I2C bus recovery supported by
the I2C subsystem.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi
b/arch
Currently the display (LCD or LVDS) configuration is duplicated with
slight variations in each TX6 module specific file.
Move it to an include file for simplification and consistency.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6dl-tx6dl-comtft.dts| 74 +--
arch/arm/boot
Create .dts files for various Ka-Ro electronics TX modules on the MB7
baseboard.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/Makefile | 8
arch/arm/boot/dts/imx6dl-tx6s-8034-mb7.dts | 48
arch/arm/boot/dts/imx6dl-tx6s-8035-mb7.dts | 48
Please ignore the V2 series. I accidentally sent the patches from a
wrong directory.
This patchset updates the dts files for the Ka-Ro electronics GmbH TX6
module series and adds some include files to facilitate supporting
various SoM/baseboard combinations.
Changes vs. v2:
- resent the correct p
The 'ipu1' alias is already defined in imx6q.dtsi. There is no need to
redefine it here.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6q-tx6q-11x0-mb7.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6q-tx6q-11x0-mb7.dts
b/arch/arm/boot/dts/imx6q
As the DS1339 driver now supports enabling the trickle charge feature
via DTB, add the appropriate properties to utilize this feature.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi
b
Under certain circumstances the ethernet PHY cannot be detected on
Ka-Ro electronics TX6 modules. Using a phy-reset-post-delay of at least
2ms alleviates this problem. Define it to 10ms to be on the safe side.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 1 +
1 file
Convert the DTS sound setup to use the simple-audio-card driver.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 50 --
1 file changed, 42 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi
b/arch/arm/boot
The current TX6Q module HW revision is 3 reflected in the module name
suffix '-1030' (-1130 for LVDS).
Change the model string to prevent confusion about what DTS file to
use for these modules.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6q-tx6q-1010.dts | 4 ++--
arch/ar
-DIMM
Temp. Range -40°C to 105°C
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/Makefile | 2 +
arch/arm/boot/dts/imx6qp-tx6qp-8037.dts | 86 +++
arch/arm/boot/dts/imx6qp-tx6qp-8137.dts | 90 +
3 files changed, 178
Move the MB7 specific settings to a separate .dtsi file to facilitate
supporting more module variants with this baseboard.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6dl-tx6u-81xx-mb7.dts | 9 +--
arch/arm/boot/dts/imx6q-tx6q-11x0-mb7.dts | 42 +
arch/arm/boot/dts
pinctrl settings from the PHY subnode to the FEC node.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi
b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
index a50bf71
The display, that incorporates this touchpanel is obsolete and won't
be supported any more.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6dl-tx6u-811x.dts | 23 +--
arch/arm/boot/dts/imx6dl-tx6u-81xx-mb7.dts | 22 +-
arch/arm/boot/dts/
Hi,
On Mon, 16 Oct 2017 18:33:17 -0200 Fabio Estevam wrote:
> Hi Lothar,
>
> On Fri, Oct 13, 2017 at 7:43 AM, Lothar Waßmann
> wrote:
>
> > +/ {
> > + aliases {
> > + lcdif_24bit_pins_a = &pinctrl_disp0_3;
> > + mmc
Hi,
On Tue, 17 Oct 2017 14:08:18 +0200 Thierry Reding wrote:
> On Wed, Oct 11, 2017 at 01:23:33PM +0200, Lothar Waßmann wrote:
> > Create a macro that eases the definition of display mode parameters by
> > accecpting the parameters:
> > freq, hactive, hfront-porch,
Hi,
On Tue, 17 Oct 2017 14:14:22 +0200 Thierry Reding wrote:
> On Wed, Oct 11, 2017 at 01:23:36PM +0200, Lothar Waßmann wrote:
> > The Ka-Ro electronics MB7 baseboard has an on-board LCD->LVDS
> > converter that requires a fixed pixelclk polarity, no matter what the
> &
Hi,
On Tue, 17 Oct 2017 14:12:40 +0200 Thierry Reding wrote:
> On Wed, Oct 11, 2017 at 01:23:35PM +0200, Lothar Waßmann wrote:
> > The baseboards for the Ka-Ro electronics series of i.MX modules
> > use a 24bit LCD interface, no matter what LCD bus width the SoC on the
> >
Hi,
On Tue, 17 Oct 2017 14:09:37 +0200 Thierry Reding wrote:
> On Wed, Oct 11, 2017 at 01:23:34PM +0200, Lothar Waßmann wrote:
> > Use the newly defined macro to generate the display_mode data entries
> > for all panels. This reduces the code size significantly and makes th
Hi,
On Tue, 17 Oct 2017 15:08:31 +0200 Thierry Reding wrote:
> On Tue, Oct 17, 2017 at 03:05:16PM +0200, Lothar Waßmann wrote:
> > Hi,
> >
> > On Tue, 17 Oct 2017 14:09:37 +0200 Thierry Reding wrote:
> > > On Wed, Oct 11, 2017 at 01:23:34PM +0200, Lothar Waßman
Hi,
On Tue, 17 Oct 2017 14:45:04 +0200 Thierry Reding wrote:
> On Tue, Oct 17, 2017 at 02:25:07PM +0200, Lothar Waßmann wrote:
> > Hi,
> >
> > On Tue, 17 Oct 2017 14:14:22 +0200 Thierry Reding wrote:
> > > On Wed, Oct 11, 2017 at 01:23:36PM +0200, Lothar Wa
These patches implement some measures to prevent backlight flicker
when the backlight is being switched on for a display with an active
low brightness control pin.
These patches implement some measures to prevent backlight flicker
when the backlight is being switched on for a display with an active
low brightness control pin.
GIT: [PATCH 1/2] backlight: pwm_bl: Enable PWM before switching regulator
GIT: [PATCH 2/2] backlight: pwm_bl: add configurable delay be
PWM before switching backlight power on to prevent this.
Signed-off-by: Lothar Waßmann
---
drivers/video/backlight/pwm_bl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index 002f1ce..921f322 100644
--- a
When switching the backlight on, the LCD may need some time to adjust
to the configured PWM duty cycle. Add a configurable delay between
configuring the PWM and enabling the backlight regulator to account
for this.
Signed-off-by: Lothar Waßmann
---
.../bindings/leds/backlight/pwm-backlight.txt
Hi,
On Fri, 10 Nov 2017 12:22:15 +0100 Enric Balletbo i Serra wrote:
> Hi all,
>
> On 08/11/17 11:48, Daniel Thompson wrote:
> > On 26/10/17 13:49, Lothar Waßmann wrote:
> >> These patches implement some measures to prevent backlight flicker
> >> when the bac
Hi,
On Wed, 18 Oct 2017 10:13:32 +0800 Shawn Guo wrote:
> On Mon, Oct 16, 2017 at 10:56:32AM +0200, Lothar Waßmann wrote:
> > Hi,
> >
> > On Mon, 16 Oct 2017 09:17:26 +0200 Uwe Kleine-König wrote:
> > > Hello,
> > >
> > > On Wed, Oct 11
gt; +
> + If unsure, say N.
> +
> + To compile this driver as a module, choose M here: the
> + moduel will be called imx6ul_tsc.
>
s/moduel/module/
Lothar Waßmann
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a messa
dev_err(mt8173_nor->dev, "execute cmd failed!\n");
>
> mt8173_nor_execute_cmd() will already have printed an error message.
>
And mt8173_nor_execute_cmd()/mt8173_nor_set_cmd() returned an error
code which should be promoted to the caller rather than
inventing a new one.
Michal Vokáč wrote:
> Output of the PWM block of i.MX SoCs is always zero volts when the block
> is disabled. This can caue issues when inverted PWM polarity is needed.
> With inverted polarity a duty cycle = 0% corresponds to solid high level
> on the output. If the PWM is dissabled its output i
Michal Vokáč wrote:
> On 22.8.2018 08:14, Lothar Waßmann wrote:
> > Michal Vokáč wrote:
> >
> >> Output of the PWM block of i.MX SoCs is always zero volts when the block
> >> is disabled. This can caue issues when inverted PWM polarity is needed.
> >&g
Michal Vokáč wrote:
> On 22.8.2018 13:17, Lothar Waßmann wrote:
> > Michal Vokáč wrote:
> >
> >> On 22.8.2018 08:14, Lothar Waßmann wrote:
> >>> Michal Vokáč wrote:
> >>>
> >>>> Output of the PWM block of i.MX SoCs i
Michal Vokáč wrote:
> On 22.8.2018 16:10, Lothar Waßmann wrote:
> > My use case is attaching different displays to the same baseboard,
> > where some displays have the brightness control pin inverted with
> > respect to the others. It's easy to change the compatible
in u-boot.
>
Unfortunately there are both types of displays. Some with an ENABLE
pin, some without.
Lothar Waßmann
--
___
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Ge
*reset_gpio;
> > struct gpio_desc *wake_gpio;
> > @@ -993,6 +995,23 @@ static int edt_ft5x06_ts_probe(struct i2c_client
> > *client,
> >
> > tsdata->max_support_points = chip_data->max_support_points;
> >
> > + tsdata->vcc = de
: Lothar Waßmann
---
Documentation/devicetree/bindings/sound/fsl,esai.txt | 4 ++--
arch/arm/boot/dts/imx6ull.dtsi | 17 +
sound/soc/fsl/fsl_esai.c | 1 +
3 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/Documentation
This patchset addresses some differences between i.MX6UL and i.MX6ULL
which have slipped through the cracks so far.
- UART8 is not on SPBA but on AIPS-3
- i.MX6ULL has an ESAI interface in the address range of the UART8 on i.MX6UL
- i.MX6ULL does not have a CAAM unit nor SIM interfaces
/imx6ull.dtsi) file.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6ul-14x14-evk.dts | 480 +---
arch/arm/boot/dts/imx6ull-14x14-evk.dts | 5 +-
2 files changed, 5 insertions(+), 480 deletions(-)
diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dts
b/arch/arm/boot
The i.MX6ULL doesn't have the CAAM engine nor any SIM interface.
These are currently not implemented for i.MX6UL but it cannot hurt to
delete the corresponding nodes from the i.MX6ULL DTB anyway.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6ull.dtsi | 6 ++
1 file chang
UART8 on i.MX6ULL is not located on the SPBA bus like on i.MX6UL but
on the (otherwise unused) AIPS-3 bus.
Create the appropriate AIPS-3 bus configuration and move the uart8
definition where it belongs.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6ull.dtsi | 29
/imx6ull.dtsi) file.
Signed-off-by: Lothar Waßmann
---
Changes vs v1:
- The newly created .dtsi file was missing
arch/arm/boot/dts/imx6ul-14x14-evk.dts | 480 +--
arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 488
arch/arm/boot/dts/imx6ull-14x14
<&sdma 29 1 0>;
> dma-names = "rx", "tx";
> + fsl,fifo-depth = <15>;
> status = "disabled";
> };
>
You are changing the global .dtsi file. Did you test this change with
all devices that are affected by it?
Lothar Waßmann
Hi,
On Thu, 8 Mar 2018 16:38:32 +0100 Martin Kaiser wrote:
> Hi Lothar,
>
> Thus wrote Lothar Waßmann (l...@karo-electronics.de):
>
> > > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> > > index 9725705..cf70df2 100644
> >
Hi,
On Fri, 09 Mar 2018 10:27:12 +0100 Lucas Stach wrote:
> Hi Lothar,
>
> Am Freitag, den 09.03.2018, 09:37 +0100 schrieb Lothar Waßmann:
> > Hi,
> >
> > On Thu, 8 Mar 2018 16:38:32 +0100 Martin Kaiser wrote:
> > > Hi Lothar,
> > >
> > > &
enables both clocks explicitly. So they are not unused.
>
>
> Doing something like this is not an option for ssi, this will not work with
> imx31, 35 etc.
>
> Therefore, I suggest setting ssi1_ipg_per as parent of ssi1_ipg.
>
The right wayto fix this is to add the missing ipg_per clock to the DTB
rather than introducing a bogus clock relationship that doesn't exist
in hardware.
The sound/soc/fsl/fsl_ssi.c driver does already handle a second clock
as bitclock. It only needs to be specified in the DTB:
&ssi1 {
clocks = <&clks 117>, <&clk 55>;
clock-names = "ipg", "baud";
};
Lothar Waßmann
gainst GND = 0V
> >- against VCC = 0V
> > - Measure resistance against VCC: Hi-Z
> >
> > The pin is in Hi-Z mode. That is fine but that does not satisfy any
> > logic level.
> >
> > b) working variant
> > - Request the GPIO, configure i
Uwe Kleine-König wrote:
> Hallo Lothar,
>
> On Mon, Nov 26, 2018 at 10:11:16AM +0100, Lothar Waßmann wrote:
> > Uwe Kleine-König wrote:
> > > @Lothar: if Michal did something different than you expected, please
> > > tell us with a few more details.
>
> >>> On Thu, Nov 22, 2018 at 03:42:14PM +, Vokáč Michal wrote:
> > >>>> On 16.11.2018 09:25, Uwe Kleine-König wrote:
> > >>>>> On Fri, Nov 16, 2018 at 08:34:30AM +0100, Lothar Waßmann wrote:
> > >>>>>> No. You c
t = PTR_ERR(rtc);
> + return ret;
> + }
> +
> + rtc->ops = &imx_sc_rtc_ops;
> + rtc->range_min = 0;
> + rtc->range_max = U32_MAX;
> +
> + ret = rtc_register_device(rtc);
> + if (ret) {
> + dev_err(&pdev-&
ranges = <0x5f00 0x0 0x5f00 0x100>;
> };
> +
> + rtc: rtc {
> + compatible = "nxp,imx8qxp-sc-rtc";
> + };
> };
IMO this should be disabled by default.
Lothar Waßmann
Anson Huang wrote:
> Hi, Lothar
>
> Best Regards!
> Anson Huang
>
> > -Original Message-----
> > From: Lothar Waßmann [mailto:l...@karo-electronics.de]
> > Sent: 2018年11月28日 17:04
> > To: Anson Huang
> > Cc: a.zu...@towertech.it; alexandr
0; i < sensor_num; i++) {
> + struct imx_sc_sensor *sensor = &data->sensor[i];
> +
> + sensor_np = of_get_next_child(np, sensor_np);
> + ret = imx_sc_thermal_get_sensor_id(sensor_np,
> &sensor->resource_id);
> + if (ret < 0) {
> + dev_err(&pdev->dev,
> + "failed to get valid sensor resource id: %d\n",
> + ret);
> + break;
> + }
> +
> + ret = imx_sc_thermal_register_sensor(pdev, sensor);
> + if (ret) {
> + dev_err(&pdev->dev, "failed to register thermal sensor:
> %d\n",
> + ret);
> + break;
> + }
> + }
> +
> + of_node_put(np);
> + of_node_put(sensor_np);
> +
> + return ret;
> +}
> +
> +static const struct of_device_id imx_sc_thermal_table[] = {
> + { .compatible = "nxp,imx8qxp-sc-thermal", },
> + {},
> +};
s/{},/{}/
Lothar Waßmann
rl, so that only the
selected pull-up/down is relevant. The pin function and GPIO register
settings don't matter at all in this case.
Lothar Waßmann
--
___
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-
correctly the backlight won't work as
expected...
The PWM driver is driving the pins, so that is where the pinctrls
belong.
Lothar Waßmann
--
___
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +
work.
> >
> > So whatever new feature you need to introduce it needs to be done in
> > such a way that the existing dtb's will continue working.
> But actually existing dtb is not right since the critical power rail
> missing 'regulator-always-on'. It's a fix patch for dts, not related
> with following dtb/kernel break rules, just a simple dts patch. Why
> should we make promise for the wrong dtbs?
>
Because they are living in the outside world on real devices.
Lothar Waßmann
Hi,
> Take this out of the main .probe() routine in order to facilitate the
> introduction of different ways to obtain 'duty cycle' information.
>
> Signed-off-by: Lee Jones
> ---
> drivers/mfd/mfd-child.c | 47
> drivers/regulator/pwm-regulator.c | 77
>
ite understand this. If you have two DMA channels, can you
> not
> use them both to do full-duplex SPI transfer ?
>
SPI != I2C
Lothar Waßmann
--
___
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-
1 - 100 of 454 matches
Mail list logo
