Re: [PATCH v4 23/25] media: i2c: imx258: Add support for reset gpio

2024-04-15 Thread Luis Garcia
On 4/15/24 10:00, Tommaso Merciai wrote: > Hi Luis, > > On Sun, Apr 14, 2024 at 02:35:01PM -0600, g...@luigi311.com wrote: >> From: Luis Garcia >> >> It was documented in DT, but not implemented. > > Good catch :-) > >> >> Signed-off-

Re: [PATCH v4 24/25] media:i2c: imx258: Use v4l2_link_freq_to_bitmap helper

2024-04-15 Thread Luis Garcia
On 4/15/24 09:18, Tommaso Merciai wrote: > Hi Luis, > > On Sun, Apr 14, 2024 at 02:35:02PM -0600, g...@luigi311.com wrote: >> From: Luis Garcia >> >> Use the v4l2_link_freq_to_bitmap() helper to figure out which >> driver-supported link freq can be used on

Re: [PATCH v4 02/25] media: i2c: imx258: Make image geometry meet sensor requirements

2024-04-15 Thread Luis Garcia
for the binned modes so that they meet the >> sensor requirements. >> >> This does change the Bayer order as the default configuration is for >> H flips to be enabled, so readout is from Y_STA_END to Y_ADD_STA, >> and this patch has changed Y_STA_END. >&

Re: [PATCH v3 22/25] dt-bindings: media: imx258: Add binding for powerdown-gpio

2024-04-15 Thread Luis Garcia
On 4/3/24 12:49, Pavel Machek wrote: > Hi! > >> From: Luis Garcia >> >> Add powerdown-gpio binding as it is required for some boards > > "." at end of sentence. > >> Signed-off-by: Ondrej Jirman >> Signed-off-by: Luis Garcia > >

Re: [PATCH v4 25/25] media: i2c: imx258: Convert to new CCI register access helpers

2024-04-15 Thread Luis Garcia
On 4/15/24 08:47, Tommaso Merciai wrote: > Hi Luis, > > On Sun, Apr 14, 2024 at 02:35:03PM -0600, g...@luigi311.com wrote: >> From: Luis Garcia >> >> Use the new comon CCI register access helpers to replace the private >> register access helpers in the imx258

Re: [PATCH v3 23/25] drivers: media: i2c: imx258: Add support for powerdown gpio

2024-04-04 Thread Luis Garcia
gt; Hi Luis, Ondrej, >>>> >>>> On Wed, Apr 03, 2024 at 09:03:52AM -0600, g...@luigi311.com wrote: >>>>> From: Luis Garcia >>>>> >>>>> On some boards powerdown signal needs to be deasserted for this >>>>> se

Re: [PATCH v3 11/25] media: i2c: imx258: Add get_selection for pixel array information

2024-04-08 Thread Luis Garcia
On 4/3/24 12:46, Pavel Machek wrote: > Hi! > >> Libcamera requires the cropping information for each mode, so >> add this information to the driver. > >> @@ -116,6 +124,9 @@ struct imx258_mode { >> u32 link_freq_index; >> /* Default register values */ >> struct imx258_reg_list

Re: [PATCH v3 21/25] drivers: media: i2c: imx258: Use macros

2024-04-05 Thread Luis Garcia
On 4/4/24 00:46, Sakari Ailus wrote: > On Wed, Apr 03, 2024 at 01:17:26PM -0600, Luigi311 wrote: >> On 4/3/24 10:23, Sakari Ailus wrote: >>> Hi Luis, >>> >>> On Wed, Apr 03, 2024 at 09:03:50AM -0600, g...@luigi311.com wrote: >>>> From: Luis Gar

Re: [PATCH v3 09/25] media: i2c: imx258: Add support for running on 2 CSI data lanes

2024-04-05 Thread Luis Garcia
On 4/3/24 12:45, Pavel Machek wrote: > Hi! > >> +/* >> + * 4208x3120 @ 30 fps needs 1267Mbps/lane, 4 lanes. >> + * To avoid further computation of clock settings, adopt the same per >> + * lane data rate when using 2 lanes, thus allowing a maximum of 15fps. >> + */ >> +static const struct

Re: [PATCH v3 21/25] drivers: media: i2c: imx258: Use macros

2024-04-05 Thread Luis Garcia
On 4/5/24 08:11, Tommaso Merciai wrote: > Hi Luis, > > On Fri, Apr 05, 2024 at 04:33:38AM -0600, Luis Garcia wrote: >> On 4/4/24 00:46, Sakari Ailus wrote: >>> On Wed, Apr 03, 2024 at 01:17:26PM -0600, Luigi311 wrote: >>>> On 4/3/24 10:23, Sakari Ailus wrot

Re: [PATCH v3 05/25] media: i2c: imx258: Add regulator control

2024-04-05 Thread Luis Garcia
On 4/3/24 12:44, Pavel Machek wrote: > Hi! > >> The device tree bindings define the relevant regulators for the >> sensor, so update the driver to request the regulators and control >> them at the appropriate times. > >> @@ -995,9 +1007,19 @@ static int imx258_power_on(struct device *dev) >>

Re: [PATCH v3 11/25] media: i2c: imx258: Add get_selection for pixel array information

2024-04-06 Thread Luis Garcia
On 4/3/24 12:46, Pavel Machek wrote: > Hi! > >> Libcamera requires the cropping information for each mode, so >> add this information to the driver. > >> @@ -116,6 +124,9 @@ struct imx258_mode { >> u32 link_freq_index; >> /* Default register values */ >> struct imx258_reg_list

Re: [PATCH v5 21/25] dt-bindings: media: imx258: Add binding for powerdown-gpio

2024-06-02 Thread Luis Garcia
On 5/20/24 06:50, Sakari Ailus wrote: > On Fri, May 17, 2024 at 08:31:35AM +, Sakari Ailus wrote: >> Hi Luis, >> >> On Wed, May 01, 2024 at 09:24:38AM -0600, g...@luigi311.com wrote: >>> From: Ondrej Jirman >>> >>> Add powerdown-gpio binding as it is required for some boards. >> >> I thought

Re: [PATCH v6 00/23] imx258 improvement series

2024-06-03 Thread Luis Garcia
On 6/2/24 14:13, g...@luigi311.com wrote: > From: Luis Garcia > > v6: > - Drop powerdown-gpio patches > - per Sakari Ailus request as it is not part or > not used by the sensor > - I tested without it and PPP still works > - Dave mentioned its n

kernel panics when SMP-booting on a Nexcom Peak 7220VL2G

2007-10-01 Thread Luis Garcia-Vega
Hi list, I'm getting kernel panics when I boot a pair of Xeon 2.8GHz on a Nexcom PEAK 7220VL2G board (one of those system on a board setups). I'm running the stock Red Hat Enterprise 4.5 kernel. I mentioned a pair, because the system boots fine with the Uniprocessor kernel. I thought it could

kernel panics when SMP-booting on a Nexcom Peak 7220VL2G

2007-10-01 Thread Luis Garcia-Vega
Hi list, I'm getting kernel panics when I boot a pair of Xeon 2.8GHz on a Nexcom PEAK 7220VL2G board (one of those system on a board setups). I'm running the stock Red Hat Enterprise 4.5 kernel. I mentioned a pair, because the system boots fine with the Uniprocessor kernel. I thought it could