[PATCH] kconfig: remove a spurious self-assignment

2018-08-30 Thread Lukas Bulwahn
The self assignment was probably introduced by an automated code refactoring in commit 694c49a7c01c ("kconfig: drop localization support"). The issue was identified by a self-assign warning when running make menuconfig with clang. Signed-off-by: Lukas Bulwahn --- scripts/kconfig/m

Re: clang warning: implicit conversion in intel_ddi.c:1481

2018-02-01 Thread Lukas Bulwahn
Hi Greg, On Thu, 1 Feb 2018, Greg KH wrote: > On Thu, Feb 01, 2018 at 06:33:30PM +0100, Ozan Alpay wrote: > > Dear Rodrigo Vivi, Ville Syrjälä, > > > > My name is Ozan Alpay, and I am a student mentored by Lukas Bulwahn. We > > intend to use static analysis to

[PATCH v3] fixdep: exit with error code in error branches of do_config_file()

2018-01-08 Thread Lukas Bulwahn
the review of a previous patch that intended to address a memory leak detected by a static analysis tool. Link: https://lkml.org/lkml/2017/12/14/736 Suggested-by: Nicholas Mc Guire Suggested-by: Masahiro Yamada Signed-off-by: Lukas Bulwahn --- compile tested on top of next-20180108 with cla

Re: [PATCH v2] fixdep: exit with error code in error branches of do_config_file()

2018-01-08 Thread Lukas Bulwahn
On Sun, 31 Dec 2017, Masahiro Yamada wrote: 2017-12-22 4:10 GMT+09:00 Lukas Bulwahn : diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c index bbf62cb..4274610 100644 --- a/scripts/basic/fixdep.c +++ b/scripts/basic/fixdep.c @@ -284,19 +284,18 @@ static void do_config_file(const

[PATCH] net: make config lines follow common pattern

2023-11-23 Thread Lukas Bulwahn
o simplify life for kernel developers that use basic regular expressions to find and extract kernel configs, make all config lines follow this common pattern. No functional change, just helpful stylistic clean-up. Signed-off-by: Lukas Bulwahn --- drivers/net/ethernet/cavium/Kconfig | 4 +--

[PATCH] MAINTAINERS: remove section LIBNVDIMM BLK: MMIO-APERTURE DRIVER

2022-03-15 Thread Lukas Bulwahn
YSTEM, and all patches to region_devs.c will still reach the same developers as before. Signed-off-by: Lukas Bulwahn --- Dan, please pick this minor clean-up patch in your -next tree on top of the commit above. MAINTAINERS | 11 --- 1 file changed, 11 deletions(-) diff --git a/MAI

[PATCH RESEND] fs: drop unused fput_atomic definition

2019-04-10 Thread Lukas Bulwahn
efcounter.cocci rule pointing to the use of atomic_t in fput_atomic. Suggested-by: Krystian Radlak Signed-off-by: Lukas Bulwahn --- v1: - sent on 2018-01-12, got no response https://lore.kernel.org/lkml/20190112055430.5860-1-lukas.bulw...@gmail.com/ v1 resend: - rebased to v5.1-rc4 - add

[PATCH] MAINTAINERS: replace non-matching patterns for loongson{2,3}

2021-02-10 Thread Lukas Bulwahn
ivers/*/*/*loongson3* warning: no file matchesF:drivers/*/*loongson3* As in the last two and half years, no further files and drivers have showed up to match those patterns, just name the one file that matches explicitly and delete the others without a match. Signed-off-by: Lukas Bulwahn

[PATCH RESEND] MAINTAINERS: replace non-matching patterns for loongson{2,3}

2021-02-10 Thread Lukas Bulwahn
ivers/*/*/*loongson3* warning: no file matchesF:drivers/*/*loongson3* As in the last two and half years, no further files and drivers have showed up to match those patterns, just name the one file that matches explicitly and delete the others without a match. Signed-off-by: Lukas Bulwahn

[PATCH] platform/x86: thinkpad_acpi: rectify length of title underline

2021-01-28 Thread Lukas Bulwahn
WARNING: Title underline too short. Rectify length of subsection title underline. Signed-off-by: Lukas Bulwahn --- applies cleanly on next-20210128 Nitin, please ack. Hans, please pick this minor fixup for your platform/x86 -next tree. Documentation/admin-guide/laptops/thinkpad-acpi.rst

[PATCH] block: remove typo in kernel-doc of set_disk_ro()

2021-01-28 Thread Lukas Bulwahn
27;set_disk_ro' warning: Excess function parameter 'ready_only' description in 'set_disk_ro' Remove that typo in the kernel-doc for set_disk_ro(). Signed-off-by: Lukas Bulwahn --- Jens, please pick this minor fix on your block-next tree. block/genhd.c | 2 +- 1 file ch

[PATCH] block: drop removed argument from kernel-doc of blk_execute_rq()

2021-01-28 Thread Lukas Bulwahn
x27;blk_execute_rq' Drop removed argument from kernel-doc of blk_execute_rq() as well. Signed-off-by: Lukas Bulwahn --- Jens, please pick this minor fix on your block-next tree. block/blk-exec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/blk-exec.c b/block/blk-exec.c index 0ab

[PATCH] MAINTAINERS: adjust to gdth scsi driver removal

2021-01-28 Thread Lukas Bulwahn
emoved now. Signed-off-by: Lukas Bulwahn --- applies cleanly on next-20210128 Hannes, Martin, please pick this minor fix-up on your scsi-next tree. MAINTAINERS | 7 --- 1 file changed, 7 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index dfb1f1af32bb..5e1fec71f21b 100644 --- a/MAINTAI

[PATCH for -next] docs: drop removed pti_intel_mid from driver-api index

2021-01-30 Thread Lukas Bulwahn
g document 'driver-api/pti_intel_mid' Remove pti_intel_mid from driver-api index. Signed-off-by: Lukas Bulwahn --- applies cleanly on next-20210129 Greg, please pick this minor fixup on top of the commit above. Documentation/driver-api/index.rst | 1 - 1 file changed, 1 delet

[PATCH for -next] docs: hwmon: rectify table in max16601.rst

2021-01-30 Thread Lukas Bulwahn
NING: Malformed table. Adjust the column length of that table for this longer row to fit. Signed-off-by: Lukas Bulwahn --- applies cleanly on next-20210129 Guenter, please pick this minor fixup for your hwmon-next tree. Documentation/hwmon/max16601.rst | 143 +++ 1 f

Re: [Linux-kernel-mentees] Patches from the future - can checkpatch help?

2021-02-01 Thread Lukas Bulwahn
On Mon, Feb 1, 2021 at 5:37 PM Greg KH wrote: > > On Mon, Feb 01, 2021 at 10:04:01PM +0530, Dwaipayan Ray wrote: > > Hi, > > on linux-next, > > $ git log --pretty=format:"%h%x09%ad" | awk '$6>2021 {print $1}' > > gives: > > 4a2d78822fdf > > 12ca45fea91c > > 09f2724a786f > > > > These are patches f

[PATCH] fscache: rectify minor kernel-doc issues

2021-02-03 Thread Lukas Bulwahn
The command './scripts/kernel-doc -none include/linux/fscache.h' reports some minor mismatches of the kernel-doc and function signature, which are easily resolved. Rectify the kernel-doc, such that no issues remain for fscache.h. Signed-off-by: Lukas Bulwahn --- applies cleanly

[PATCH 2/5] fs: update kernel-doc for vfs_rename()

2021-02-04 Thread Lukas Bulwahn
scriptions checkable against the actual implementation. Signed-off-by: Lukas Bulwahn --- fs/namei.c | 9 + include/linux/fs.h | 11 +++ 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index f131d3efec63..98ea56ebcaf0 100644 --- a/

[PATCH 4/5] fs: update kernel-doc for vfs_tmpfile()

2021-02-04 Thread Lukas Bulwahn
mpfile' warning: Excess function parameter 'open_flags' description in 'vfs_tmpfile' Fix this typo in kernel-doc of vfs_tmpfile(). Signed-off-by: Lukas Bulwahn --- fs/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/namei.c b/fs/namei.c index

[PATCH 3/5] fs: update kernel-doc for may_create_in_sticky()

2021-02-04 Thread Lukas Bulwahn
parameter 'dir_mode' description in 'may_create_in_sticky' warning: Excess function parameter 'dir_uid' description in 'may_create_in_sticky' Drop removed arguments from kernel-doc of may_create_in_sticky(). Signed-off-by: Lukas Bulwahn --- fs/namei.c |

[PATCH 0/5] kernel-doc fixes to latest fs changes

2021-02-04 Thread Lukas Bulwahn
this patchset was motivated by new warnings with make htmldocs appearing on linux-next in the last week. Please apply this on top of your latest work in fs on top of the mount user namespace refactoring, cf. the commits referred in the individual commit messages. Lukas Bulwahn (5): fs: turn

[PATCH 5/5] fs: update kernel-doc for new mnt_userns argument

2021-02-04 Thread Lukas Bulwahn
ber 'mnt_userns' not described in '__vfs_removexattr_locked' Copy the existing kernel-doc description for that new argument from __vfs_setxattr_noperm() to the other functions as well. Signed-off-by: Lukas Bulwahn --- fs/libfs.c | 1 + fs/xattr.c | 2 ++ 2 files c

[PATCH 1/5] fs: turn some comments into kernel-doc

2021-02-04 Thread Lukas Bulwahn
check: ./scripts/kernel-doc -none include/linux/fs.h currently reports no issues in this file. Signed-off-by: Lukas Bulwahn --- include/linux/fs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index 3482146b11b0..04b6b142dfcf 1

Re: Small student project idea on appropriate integration trees in MAINTAINERS

2021-02-04 Thread Lukas Bulwahn
On Fri, Jan 29, 2021 at 12:54 AM Jonathan Corbet wrote: > > On Fri, 22 Jan 2021 09:22:24 +0100 > Lukas Bulwahn wrote: > > > In this project, we can make use of: > > > > - gitdm [git://git.lwn.net/gitdm.git]: gitdm includes some scripts to > > parse MAINTAI

[PATCH] net/mlx5: docs: correct section reference in table of contents

2021-02-05 Thread Lukas Bulwahn
rget name: "mlx5 port function". Correct the section reference in table of contents to the actual name of section in the documentation. Also, tune another section underline while visiting this document. Signed-off-by: Lukas Bulwahn --- Saeed, please pick this patch for yo

Re: [RFC v2] scripts: kernel-doc: fix typedef support for struct/union parsing

2021-02-25 Thread Lukas Bulwahn
: error: Cannot parse struct or union! < include/linux/zstd.h:181: error: Cannot parse struct or union! 18857d18853 < include/linux/zstd.h:936: error: Cannot parse struct or union! So, again: Tested-by: Lukas Bulwahn Aditya, can you please pick up my rephrasing and send out a v3. Lukas

Re: [PATCH v7 0/2] checkpatch: add verbose mode

2021-02-25 Thread Lukas Bulwahn
On Thu, Feb 25, 2021 at 7:08 PM Dwaipayan Ray wrote: > > On Thu, Feb 25, 2021 at 11:03 PM Joe Perches wrote: > > > > On Mon, 2021-02-22 at 13:22 +0530, Dwaipayan Ray wrote: > > > Add a new verbose mode to checkpatch. The verbose test > > > descriptions are read from the checkpatch documentation >

[PATCH for Dwaipayan] MAINTAINERS: clarify responsibility for checkpatch documentation

2021-02-25 Thread Lukas Bulwahn
counterpart. Link: https://lore.kernel.org/lkml/bcee822d1934772f47702ee257bc735c8f467088.ca...@perches.com/ Signed-off-by: Lukas Bulwahn --- applies cleanly on next-20210226 Dwaipayan, you probably want to add this patch to your patch series for checkpatch documentation. Feel free to add your

Re: [PATCH 2/5] MAINTAINERS: remove linux-mips.org references

2021-02-26 Thread Lukas Bulwahn
On Tue, Feb 23, 2021 at 10:48 AM Philippe Mathieu-Daudé wrote: > > On Mon, Feb 22, 2021 at 5:22 PM Lukas Bulwahn wrote: > > > > The domain lookup for linux-mips.org fails for quite some time now. Hence, > > webpages, the patchwork instance and Ralf Baechle's ema

Re: [PATCH v2] media: add a subsystem profile documentation

2021-02-27 Thread Lukas Bulwahn
On Thu, Feb 25, 2021 at 2:41 PM Mauro Carvalho Chehab wrote: > > Document the basic policies of the media subsystem profile. > > Signed-off-by: Mauro Carvalho Chehab > --- > > v2: fix the Documentation/*/media directories > > > Documentation/driver-api/media/index.rst | 2 + > .../media/m

[PATCH] doc: zh_CN: use doc reference to resolve undefined label warning

2020-05-31 Thread Lukas Bulwahn
Documentation generation warns: Documentation/translations/zh_CN/filesystems/debugfs.rst:5: WARNING: undefined label: debugfs_index Use doc reference for files rather than introducing a label to refer to. This resolves the warning above. Signed-off-by: Lukas Bulwahn --- Jonathan, please

[PATCH] docs: it_IT: address invalid reference warnings

2020-05-31 Thread Lukas Bulwahn
it_IT/process/howto.rst: WARNING: undefined label: it_managementstyle Refer to English documentation, as Italian translation does not exist, and add labels for Italian process documents to resolve label references. Signed-off-by: Lukas Bulwahn --- Jonathan, please pick this quick fix of

Re: [PATCH v2] checkpatch: Fix the usage of capture group ( ... )

2020-07-29 Thread Lukas Bulwahn
n't be accomplished due to usage of capture group and > `$1` in the same regular expression. > > Fix this by placing the capture group in the condition before `&&`. > Thus, `$1` can be initialized to the text that capture group matches > thereby setting it to the

Re: [PATCH v7] Makefile: Add clang-tidy and static analyzer support to makefile

2020-08-01 Thread Lukas Bulwahn
On Tue, 28 Jul 2020, 'Nathan Huckleberry' via Clang Built Linux wrote: > This patch adds clang-tidy and the clang static-analyzer as make > targets. The goal of this patch is to make static analysis tools > usable and extendable by any developer or researcher who is familiar > with basic c++. >

[PATCH] MAINTAINERS: update QUALCOMM IOMMU after Arm SSMU drivers move

2020-08-01 Thread Lukas Bulwahn
./scripts/get_maintainer.pl --self-test=patterns complains: warning: no file matchesF:drivers/iommu/qcom_iommu.c Update the file entry in MAINTAINERS to the new location. Signed-off-by: Lukas Bulwahn --- Will, please ack. Joerg, please pick this minor non-urgent patch for your -next branch

[PATCH] doc/zh_CN: resolve undefined label warning in admin-guide index

2020-08-02 Thread Lukas Bulwahn
Documentation generation warns: Documentation/translations/zh_CN/admin-guide/index.rst:3: WARNING: undefined label: documentation/admin-guide/index.rst Use doc reference for .rst files to resolve the warning. Fixes: 37a607cf2318 ("doc/zh_CN: add admin-guide index") Signed-off

[PATCH] doc/zh_CN: fix title heading markup in admin-guide cpu-load

2020-08-02 Thread Lukas Bulwahn
Documentation generation warns: Documentation/translations/zh_CN/admin-guide/cpu-load.rst:1: WARNING: Title overline too short. Extend title heading markup by one. It was just off by one. Fixes: e210c66d567c ("doc/zh_CN: add cpu-load Chinese version") Signed-off-by: Lukas Bulwahn

[PATCH] dma-buf.rst: repair length of title underline

2020-08-08 Thread Lukas Bulwahn
f.rst: Document why indefinite fences are a bad idea") Signed-off-by: Lukas Bulwahn --- Daniel, please pick this minor non-urgent fix to your new documentation. Documentation/driver-api/dma-buf.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/drive

[PATCH] drm/amd/display: remove unintended executable mode

2020-08-19 Thread Lukas Bulwahn
d dcn30 Headers (v2)") added the four header files {dpcs,dcn}_3_0_0_{offset,sh_mask}.h as executable, i.e., mode 755. Set to the usual modes for source and headers files and clean up those mistakes. No functional change. Signed-off-by: Lukas Bulwahn --- applies cleanly on current master and

[PATCH -next] drm/amd/display: tweak the kerneldoc for active_vblank_irq_count

2021-01-11 Thread Lukas Bulwahn
lank_irq_count. Signed-off-by: Lukas Bulwahn --- applies on amdgpu's -next and next-20210111 Bhawanpreet, Nick, please review and ack. Alex, Christian, please pick on top of the commit above. drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[PATCH -next] scsi: docs: ABI: sysfs-driver-ufs: rectify table formatting

2021-01-11 Thread Lukas Bulwahn
Malformed table. Text in column margin in table line 15. Rectify table formatting for DeepSleep power mode. Signed-off-by: Lukas Bulwahn --- Adrian, please ack. Martin, please pick on your scsi-next tree. Documentation/ABI/testing/sysfs-driver-ufs | 10 ++ 1 file changed, 6 insert

[PATCH -next] fpga: dfl-pci: rectify ReST formatting

2021-01-11 Thread Lukas Bulwahn
t. 523: WARNING: Unexpected indentation. 523: WARNING: Blank line required after table. 524: WARNING: Block quote ends without a blank line; unexpected unindent. Rectify ReST formatting in ./Documentation/fpga/dfl.rst. Signed-off-by: Lukas Bulwahn --- applies cleanly on next-202101

Re: [PATCH -next] fpga: dfl-pci: rectify ReST formatting

2021-01-11 Thread Lukas Bulwahn
On Mon, Jan 11, 2021 at 4:52 PM Greg Kroah-Hartman wrote: > > On Mon, Jan 11, 2021 at 12:21:13PM +0100, Lukas Bulwahn wrote: > > Commit fa41d10589be ("fpga: dfl-pci: locate DFLs by PCIe vendor specific > > capability") provides documentation to the FPGA Device Feat

Re: [PATCH -next] fpga: dfl-pci: rectify ReST formatting

2021-01-11 Thread Lukas Bulwahn
On Mon, Jan 11, 2021 at 4:55 PM Moritz Fischer wrote: > > Hi Lukas, > > On Mon, Jan 11, 2021 at 12:21:13PM +0100, Lukas Bulwahn wrote: > > Commit fa41d10589be ("fpga: dfl-pci: locate DFLs by PCIe vendor specific > > capability") provides documentation to the FP

[PATCH -next] f2fs: docs: rectify the table header in sysfs-fs-f2fs

2021-01-11 Thread Lukas Bulwahn
2: WARNING: Malformed table. Rectify the table header. Signed-off-by: Lukas Bulwahn --- applies cleanly on next-20210112 Documentation/ABI/testing/sysfs-fs-f2fs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testin

[PATCH] block: drop dead assignments in loop_init()

2020-12-11 Thread Lukas Bulwahn
d optimize this, the resulting object code is identical before and after this change. No functional change. No change in object code. Signed-off-by: Lukas Bulwahn --- Christoph, please ack. Jens, please pick this minor non-urgent clean-up patch on your block -next tree on top of Christoph'

Re: [PATCH] block: drop dead assignments in loop_init()

2020-12-11 Thread Lukas Bulwahn
On Fri, Dec 11, 2020 at 7:23 PM Julia Lawall wrote: > > > > On Fri, 11 Dec 2020, Lukas Bulwahn wrote: > > > Commit 8410d38c2552 ("loop: use __register_blkdev to allocate devices on > > demand") simplified loop_init(); so computing the range of the block regio

[PATCH v2] block: drop dead assignments in loop_init()

2020-12-11 Thread Lukas Bulwahn
d optimize this, the resulting object code is identical before and after this change. No functional change. No change in object code. Signed-off-by: Lukas Bulwahn --- v1 -> v2: - replaced if block with ternary operator after Julia's style comment Christoph, please ack. Jens, please p

Re: [PATCH] x86: ia32_setup_rt_frame(): propagate __user annotations properly

2020-12-11 Thread Lukas Bulwahn
On Fri, Dec 11, 2020 at 7:47 PM Borislav Petkov wrote: > > On Mon, Dec 07, 2020 at 01:41:41PM +0100, Lukas Bulwahn wrote: > > Thomas, Ingo, Boris, please pick this minor non-urgent clean-up patch. > > Why? > > Isn't it obvious that when you send a patch to us, the

[PATCH v3] block: drop dead assignments in loop_init()

2020-12-11 Thread Lukas Bulwahn
d optimize this, the resulting object code is identical before and after this change. No functional change. No change in object code. Signed-off-by: Lukas Bulwahn --- v1 -> v2: - replaced if block with ternary operator after Julia's style comment v2 -> v3: - use if instead of t

Re: [PATCH] leds: Use DEVICE_ATTR_{RW, RO, WO} macros

2020-12-13 Thread Lukas Bulwahn
---" (see HERE! as marker). For testing, you can generate the objdump of the binary before and after and compare if that is as expected. Other than that, the change itself looks good to me, so: Reviewed-by: Lukas Bulwahn Thanks, Dwaipayan, for fixing this up. Will you also add a checkpatc

Re: [PATCH v2] Documentation: process: Correct numbering

2020-12-22 Thread Lukas Bulwahn
On Mon, Dec 21, 2020 at 5:52 PM Jonathan Corbet wrote: > > On Tue, 15 Dec 2020 20:42:36 + > Milan Lakhani wrote: > > > Renumber the steps in submit-checklist.rst as some numbers were skipped. > > > > Fixes: 72deb455b5ec ("block: remove CONFIG_LBDAF") > > Signed-off-by: Milan Lakhani > > ---

Re: [PATCH v2] Documentation: process: Correct numbering

2020-12-22 Thread Lukas Bulwahn
On Tue, Dec 22, 2020 at 5:36 PM Randy Dunlap wrote: > > On 12/22/20 8:23 AM, Lukas Bulwahn wrote: > > On Mon, Dec 21, 2020 at 5:52 PM Jonathan Corbet wrote: > >> > >> On Tue, 15 Dec 2020 20:42:36 + > >> Milan Lakhani wrote: > >> > >

[PATCH] signal: propagate __user annotations properly

2020-12-07 Thread Lukas Bulwahn
the __user annotation to repair this chain of propagating __user annotations. Signed-off-by: Lukas Bulwahn --- applies cleanly on current master (v5.10-rc7) and next-20201204 Christian, please pick this minor non-urgent clean-up patch. kernel/signal.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH] bpf: propagate __user annotations properly

2020-12-07 Thread Lukas Bulwahn
__user annotations in __htab_map_lookup_and_delete_batch(). Signed-off-by: Lukas Bulwahn --- applies cleanly on current master (v5.10-rc7) and next-20201204 BPF maintainers, please pick this minor non-urgent clean-up patch. kernel/bpf/hashtab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] x86: ia32_setup_rt_frame(): propagate __user annotations properly

2020-12-07 Thread Lukas Bulwahn
#x27;__user' of expression warning: incorrect type in argument 1 (different address spaces) expected void const volatile [noderef] __user *ptr got unsigned long long [usertype] * Add the __user annotation to restore the propagation of address spaces. Signed-off-by: Lukas Bulwahn --- applie

Re: [PATCH] signal: propagate __user annotations properly

2020-12-07 Thread Lukas Bulwahn
On Mon, Dec 7, 2020 at 2:04 PM Christian Brauner wrote: > > On Mon, Dec 07, 2020 at 01:36:10PM +0100, Lukas Bulwahn wrote: > > Commit 3eb39f47934f ("signal: add pidfd_send_signal() syscall") introduced > > copy_siginfo_from_user_any(), but missed to add the __use

[PATCH] hwmon: pmbus: correct title underline length

2020-12-07 Thread Lukas Bulwahn
the title underline to the correct length. Signed-off-by: Lukas Bulwahn --- applies on next-20201207 and the hwmon -next tree Guenter, Jean, please pick this minor doc fix on your -next tree. Documentation/hwmon/q54sj108a2.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [PATCH] bpf: propagate __user annotations properly

2020-12-07 Thread Lukas Bulwahn
On Mon, Dec 7, 2020 at 5:12 PM Yonghong Song wrote: > > > > On 12/7/20 4:37 AM, Lukas Bulwahn wrote: > > __htab_map_lookup_and_delete_batch() stores a user pointer in the local > > variable ubatch and uses that in copy_{from,to}_user(), but ubatch misses a > >

[PATCH] RDMA/restrack: update kernel documentation for ib_create_named_qp()

2020-12-07 Thread Lukas Bulwahn
iniband/core/verbs.c:1206: warning: Function parameter or member 'caller' not described in 'ib_create_named_qp' Add a description for this new argument based on the description of the same argument in other related functions. Signed-off-by: Lukas Bulwahn --- applies on next-

[PATCH for doc-next] doc/zh_CN: adjust table markup in mips/ingenic-tcu.rst

2021-01-12 Thread Lukas Bulwahn
is warning. Signed-off-by: Lukas Bulwahn --- applies cleanly on next-20210113 Yanteng, please ack. Jonathan, please pick this doc warning fixup on your -next tree. Documentation/translations/zh_CN/mips/ingenic-tcu.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Doc

[PATCH for doc-next] doc/zh_CN: mips: use doc references instead

2021-01-12 Thread Lukas Bulwahn
: Lukas Bulwahn --- applies cleanly on next-20210113 Yanteng, please ack. Jonathan, please pick this doc warning fixup on your -next tree. Documentation/translations/zh_CN/mips/booting.rst | 2 +- Documentation/translations/zh_CN/mips/features.rst| 2 +- Documentation/translations/zh_CN

Re: [PATCH bpf-next v2 1/2] docs: bpf: Fixup atomics markup

2021-01-18 Thread Lukas Bulwahn
I suggest dropping this comment above starting from NB and the link; it is not relevant for the history. You can of course move it below the "---"; so it is not picked up into the git history. Other than that: Reviewed-by: Lukas Bulwahn > Signed-off-by: Brendan Jackman

[PATCH] arch/Kconfig: update a broken file reference

2021-01-19 Thread Lukas Bulwahn
HAVE_64BIT_ALIGNED_ACCESS"") Signed-off-by: Lukas Bulwahn --- applies cleanly on current master and next-20210118 Steven, could you pick this fix to your commit or, at least, ack it so that Jonathan can pick it? arch/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

[PATCH for can-next] MAINTAINERS: adjust entry to tcan4x5x file split

2021-01-07 Thread Lukas Bulwahn
NERS. Hence, ./scripts/get_maintainer.pl --self-test=patterns complains: warning: no file matchesF:drivers/net/can/m_can/tcan4x5x.c Adjust the file entry in MAINTAINERS to the tcan4x5x file splitting. Signed-off-by: Lukas Bulwahn --- applies cleanly on next-20210107, not for current master

Re: [PATCH 00/10] Fix documentation warnings at linux-next

2021-01-14 Thread Lukas Bulwahn
[reduced the recipient list to the main responsible ones and list] Hi Mauro, hi Jonathan, We both, Mauro and I, have been submitting patches to address the documentation warnings on linux-next. If it is okay with you, Mauro, I would like to take responsibility for the task to send out the patches

Related work to MAINTAINERS truth and fiction

2021-01-14 Thread Lukas Bulwahn
Hi Jonathan, thanks for your interesting article, MAINTAINERS truth and fiction, https://lwn.net/Articles/842415/. Just some pointers to related work: Pia Eichinger has done some related analysis and work in this area as part of her bachelor's thesis on Maintainers Expectations vs. Maintainers R

[PATCH] drm/dp_helper: tweak kerneldoc to address warning

2021-01-15 Thread Lukas Bulwahn
escription warning: Function parameter or member 'color_spc' not described Tweak the kerneldoc for drm_dp_downstream_rgb_to_ycbcr_conversion(). Fixes: 07c9b8634fb6 ("drm/dp_helper: Add helpers to configure PCONs RGB-YCbCr Conversion") Signed-off-by: Lukas Bulwahn --- applies cle

[PATCH] fs: anon_inodes: rephrase to appropriate kernel-doc

2021-01-15 Thread Lukas Bulwahn
Commit e7e832ce6fa7 ("fs: add LSM-supporting anon-inode interface") adds more kerneldoc description, but also a few new warnings on anon_inode_getfd_secure() due to missing parameter descriptions. Rephrase to appropriate kernel-doc for anon_inode_getfd_secure(). Signed-off-by: Luk

Re: [PATCH 00/10] Fix documentation warnings at linux-next

2021-01-15 Thread Lukas Bulwahn
On Fri, Jan 15, 2021 at 10:49 AM Mauro Carvalho Chehab wrote: > > Hi Lukas, > > Em Fri, 15 Jan 2021 07:12:38 +0100 > Lukas Bulwahn escreveu: > > > [reduced the recipient list to the main responsible ones and list] > > > > Hi Mauro, hi Jonathan, > > >

Re: Checkpatch still worries about include/asm/ ?

2021-03-18 Thread Lukas Bulwahn
On Thu, Mar 18, 2021 at 5:47 PM Dwaipayan Ray wrote: > > Hello, > include/asm/ got removed a long time back (probably v1.1.45). > Checkpatch still worries about that: > > if ($realfile =~ m@^include/asm/@) { > ERROR("MODIFIED_INCLUDE_ASM", > "do not modify files in include/asm, change architecture

[PATCH] MAINTAINERS: remove obsolete OMAP HWMOD DATA FOR OMAP4-BASED DEVICES

2021-03-18 Thread Lukas Bulwahn
./scripts/get_maintainer.pl --self-test=patterns complains: warning: no file matches F: arch/arm/mach-omap2/omap_hwmod_44xx_data.c Remove the obsolete OMAP HWMOD DATA FOR OMAP4-BASED DEVICES section. Signed-off-by: Lukas Bulwahn --- MAINTAINERS | 6 -- 1 file changed, 6 deletions(-) di

Re: [RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file

2021-03-18 Thread Lukas Bulwahn
On Thu, Mar 18, 2021 at 5:37 PM Jonathan Corbet wrote: > > Lukas Bulwahn writes: > > > I wonder if we could extend kernel-doc (not your preferred option as > > it seems) for a new dedicated warning message or maintain a separate > > kernel-doc sanity checking script

Re: [RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file

2021-03-20 Thread Lukas Bulwahn
On Sat, Mar 20, 2021 at 1:45 PM Aditya Srivastava wrote: > > On 20/3/21 12:23 pm, Aditya wrote: > > On 18/3/21 11:48 pm, Jonathan Corbet wrote: > >> Lukas Bulwahn writes: > >> > >>> Yeah, and as this line-counting is really just a poor man's >

Re: [PATCH] ntfs: fix incorrect kernel-doc comment syntax in files

2021-03-21 Thread Lukas Bulwahn
On Sat, Mar 20, 2021 at 5:29 PM Aditya Srivastava wrote: > > The opening comment mark '/**' is used for highlighting the beginning of > kernel-doc comments. > There are certain files in fs/ntfs which follow this syntax, but the > content inside does not comply with kernel-doc. > Such lines were pr

[PATCH] watchdog: fix syntactic kernel-doc issues

2021-03-21 Thread Lukas Bulwahn
Excess function parameter" and "Function parameter or member not described". These warnings would need to be addressed in a second pass with a bit more insight into the APIs and purpose of the functions in the watchdog subsystem. Signed-off-by: Lukas Bulwahn --- Guenter, Wim, please

[PATCH] devicetree: replace invalid kernel-doc comment headers

2021-03-22 Thread Lukas Bulwahn
The opening comment mark '/**' is used for indicating the beginning of kernel-doc comments. Replace uses of '/**' for invalid cases in dt-binding headers and dts. Signed-off-by: Lukas Bulwahn --- Rob, please pick this quick kernel-doc cleanup patch. arch/arm64/boot/dts/his

Re: [EXTERNAL]Re: [PATCH 0/5] Remove dead linux-mips.org references

2021-03-22 Thread Lukas Bulwahn
On Mon, Feb 22, 2021 at 7:19 PM Kurt Martin wrote: > > Hi Everybody, > > This is Kurt Martin. I'm part of the MIPS Customer Engineering team at Wave > Computing. Some of you may remember me. I have just established contact > with Ralf, and I will be working with him to restore linux-mips.org

[PATCH 0/2] kernel-doc and MAINTAINERS clean-up

2021-03-22 Thread Lukas Bulwahn
de/ directory for MEMORY MANAGEMENT. Andrew, please pick this clean-up patch series for mm. Link: https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html Lukas Bulwahn (2): MAINTAINERS: assign pagewalk.h to MEMORY MANAGEMENT pagewalk: prefix struct kernel-doc descriptions MAINTAINER

[PATCH 1/2] MAINTAINERS: assign pagewalk.h to MEMORY MANAGEMENT

2021-03-22 Thread Lukas Bulwahn
e original ./include/linux/mm.h clearly marks this file part of MEMORY MANAGEMENT. Assign ./include/linux/pagewalk.h to MEMORY MANAGEMENT. Signed-off-by: Lukas Bulwahn --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 728216e3919c..46a1eddbc3e4 10

[PATCH 2/2] pagewalk: prefix struct kernel-doc descriptions

2021-03-22 Thread Lukas Bulwahn
t mm_walk ' A kernel-doc description for a structure requires to prefix the struct name with the keyword 'struct'. So, do that such that no further kernel-doc warnings are reported for this file. Signed-off-by: Lukas Bulwahn --- include/linux/pagewalk.h | 4 ++-- 1 file changed, 2 ins

Re: [Ksummit-discuss] RFC: create mailing list "linux-issues" focussed on issues/bugs and regressions

2021-03-22 Thread Lukas Bulwahn
On Mon, Mar 22, 2021 at 4:38 PM Thorsten Leemhuis wrote: > > > Lo! I want to provide users with an easier way to search our multitude > of mailing lists for reports about issues (aka bugs), as reporting the > same kernel problem multiple times has known downsides for everyone > involved. That's wh

[PATCH 0/5] Rectify file references for dt-bindings in MAINTAINERS

2021-03-15 Thread Lukas Bulwahn
next-20210315. Could you pick this series for your devicetree bindings tree? No functional change, just cleaning up MAINTAINERS. Lukas Link: https://lore.kernel.org/lkml/20210208071619.3234-1-lukas.bulw...@gmail.com/ Lukas Bulwahn (5): MAINTAINERS: rectify some references automatically

[PATCH 1/5] MAINTAINERS: rectify some references automatically

2021-03-15 Thread Lukas Bulwahn
Some references in MAINTAINERS can be automatically rectified with ./scripts/documentation-file-ref-check --fix. Adjust those file entries with this script. Signed-off-by: Lukas Bulwahn --- MAINTAINERS | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff

[PATCH 2/5] MAINTAINERS: rectify entry for ARM/TOSHIBA VISCONTI ARCHITECTURE

2021-03-15 Thread Lukas Bulwahn
originating from the same patch series however adds the file toshiba,visconti-pinctrl.yaml in that directory instead. So, refer to toshiba,visconti-pinctrl.yaml in the ARM/TOSHIBA VISCONTI ARCHITECTURE section instead. Signed-off-by: Lukas Bulwahn --- MAINTAINERS | 2 +- 1 file changed, 1 inse

[PATCH 3/5] MAINTAINERS: rectify entry for HIKEY960 ONBOARD USB GPIO HUB DRIVER

2021-03-15 Thread Lukas Bulwahn
So, just drop this file reference in HIKEY960 ONBOARD USB GPIO HUB DRIVER. Signed-off-by: Lukas Bulwahn --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 89404ca760b9..66c756c68bfd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8085,7 +8085,6 @@

[PATCH 4/5] MAINTAINERS: rectify entry for INTEL KEEM BAY DRM DRIVER

2021-03-15 Thread Lukas Bulwahn
from the same patch series however adds the file intel,keembay-display.yaml in that directory instead. So, refer to intel,keembay-display.yaml in the INTEL KEEM BAY DRM DRIVER section instead. Signed-off-by: Lukas Bulwahn --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH 5/5] MAINTAINERS: rectify entries for dt-bindings

2021-03-15 Thread Lukas Bulwahn
;dt-bindings:iio:proximity:st,vl53l0x yaml conversion"): proximity/vl53l0x.txt -> proximity/st,vl53l0x.yaml All these txt files above are referenced in MAINTAINERS. Adjust the sections with references to converted dt-bindings yaml files. As .../dac/adi,ad5758.yaml is already covered by .../*/a

[PATCH 0/2] kernel-doc and MAINTAINERS clean-up

2021-03-26 Thread Lukas Bulwahn
include/ directory for ARM/QUALCOMM SUPPORT. Andy, Bjorn, please pick this clean-up patch series for your tree. Link: https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html Lukas Bulwahn (2): MAINTAINERS: add another entry for ARM/QUALCOMM SUPPORT soc: qcom: addres

[PATCH 2/2] soc: qcom: address kernel-doc warnings

2021-03-26 Thread Lukas Bulwahn
'struct llcc_drv_data ' Address all those warnings by: - prefixing kernel-doc descriptions for structs with the keyword 'struct', - turning a kernel-doc comment that does not follow the kernel-doc syntax into a normal comment, and - correcting a parameter name in a kernel-doc c

[PATCH 1/2] MAINTAINERS: add another entry for ARM/QUALCOMM SUPPORT

2021-03-26 Thread Lukas Bulwahn
a file entry for this directory to ARM/QUALCOMM SUPPORT. Signed-off-by: Lukas Bulwahn --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 67b104202602..ec43d5c3a1a4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2298,6 +2298,7 @@ F:drivers

[PATCH] MAINTAINERS: repair reference in HYCON HY46XX TOUCHSCREEN SUPPORT

2021-04-18 Thread Lukas Bulwahn
complains: warning: no file matchesF:drivers/input/touchscreen/hy46xx.c Repair the file entry by referring to the right location. Signed-off-by: Lukas Bulwahn --- applies cleanly on next-20210419 Guilio, please ack. Dmitry, please pick this minor clean up patch for your -next tree. MAINT

[PATCH] MAINTAINERS: adjust to removing i2c designware platform data

2021-04-18 Thread Lukas Bulwahn
g: no file matches F: include/linux/platform_data/i2c-designware.h Remove the file entry to this removed file as well. Signed-off-by: Lukas Bulwahn --- applies cleanly on next-20210419 Andy, please ack. Lee, please pick this minor patch on your -next tree. MAINTAINERS | 1 - 1 file changed,

[PATCH 2/3] MAINTAINERS: rectify entry for HIKEY960 ONBOARD USB GPIO HUB DRIVER

2021-04-19 Thread Lukas Bulwahn
So, just drop this file reference in HIKEY960 ONBOARD USB GPIO HUB DRIVER. Signed-off-by: Lukas Bulwahn --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index d31c8058b17f..4f152717365c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8239,7 +8239,6 @@

[PATCH 1/3] MAINTAINERS: rectify entry for ARM/TOSHIBA VISCONTI ARCHITECTURE

2021-04-19 Thread Lukas Bulwahn
originating from the same patch series however adds the file toshiba,visconti-pinctrl.yaml in that directory instead. So, refer to toshiba,visconti-pinctrl.yaml in the ARM/TOSHIBA VISCONTI ARCHITECTURE section instead. Signed-off-by: Lukas Bulwahn --- MAINTAINERS | 2 +- 1 file changed, 1 inse

[PATCH RESEND 0/3] Rectify file references for dt-bindings in MAINTAINERS

2021-04-19 Thread Lukas Bulwahn
devicetree bindings tree? No functional change, just cleaning up MAINTAINERS. Lukas Link: https://lore.kernel.org/lkml/20210315160451.7469-1-lukas.bulw...@gmail.com/ Adjustment from original to resend version: - drop subsumed patches Lukas Bulwahn (3): MAINTAINERS: rectify entry for ARM/TOSHIBA

[PATCH 3/3] MAINTAINERS: rectify entry for INTEL KEEM BAY DRM DRIVER

2021-04-19 Thread Lukas Bulwahn
from the same patch series however adds the file intel,keembay-display.yaml in that directory instead. So, refer to intel,keembay-display.yaml in the INTEL KEEM BAY DRM DRIVER section instead. Signed-off-by: Lukas Bulwahn --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Invalid License ID: GPL-3.0 for arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi

2021-04-20 Thread Lukas Bulwahn
Dear Qing, ./scripts/spdxcheck.py reports: arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi: 1:28 Invalid License ID: GPL-3.0 You have contributed this file with commit b1a792601f26 ("MIPS: Loongson64: DeviceTree for Loongson-2K1000") to the current linux-next. Do you intend to contribute thi

Re: [PATCH 13/13] MAINTAINERS: Add entry for the bitmap API

2021-03-16 Thread Lukas Bulwahn
On Wed, Mar 17, 2021 at 5:57 AM Joe Perches wrote: > > On Tue, 2021-03-16 at 21:47 -0700, Yury Norov wrote: > > [CC Andy Whitcroft, Joe Perches, Dwaipayan Ray, Lukas Bulwahn] > > > > On Tue, Mar 16, 2021 at 01:45:51PM +0200, Andy Shevchenko wrote: > > > On Mon,

Re: [RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file

2021-03-18 Thread Lukas Bulwahn
On Mon, Mar 15, 2021 at 8:25 PM Jonathan Corbet wrote: > > Aditya writes: > > >> The opening comment mark /** is used for kernel-doc comments [1] > >> > >> [1] > >> https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html#how-to-format-kernel-doc-comments > >> > > > > Hi Markus! > > That'

  1   2   3   4   >