Re: [PATCH v3 2/2] mtd: spi-nor: parse SFDP Sector Map Parameter Table

2018-09-11 Thread Marek Vasut
entify which Erase Types are supported by > each sector. > > Signed-off-by: Tudor Ambarus Reviewed-by: Marek Vasut -- Best regards, Marek Vasut

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-09-11 Thread Marek Vasut
torm session, so: > > Suggested-by: Cristian Birsan > Signed-off-by: Tudor Ambarus Reviewed-by: Marek Vasut -- Best regards, Marek Vasut

Re: [PATCH] mmc: mxs-mmc: Add support for non-removable cards

2013-04-05 Thread Marek Vasut
Dear Alexandre Pereira da Silva, > Some boards and card slots doesn't have card detect feature available. > In that case allow to mark the cards as non-removable, via devicetree. > > Signed-off-by: Alexandre Pereira da Silva Looks good, Reviewed-by: Marek Vasut btw. did you know

Re: [PATCH] ARM: dts: imx23-olinuxino: Set the sdcard as non-removable

2013-04-05 Thread Marek Vasut
fectly removable to me ... on all possible models and even prototypes and hybrids too ;-) Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] ARM: dts: imx23-olinuxino: Set the sdcard as non-removable

2013-04-05 Thread Marek Vasut
well on this board, so I don't get it. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] mmc: mxs-mmc: Add support for non-removable cards

2013-04-05 Thread Marek Vasut
Dear Mark Brown, > On Fri, Apr 05, 2013 at 08:37:39AM +0200, Marek Vasut wrote: > > btw. did you know you can let git send-email automatically handle CC for > > you so you don't have to type it into the command line by simply > > sticking > > > > Cc: Us E

Re: [PATCH] ARM: dts: imx23-olinuxino: Set the sdcard as non-removable

2013-04-05 Thread Marek Vasut
Dear Alexandre Pereira da Silva, > On Fri, Apr 5, 2013 at 11:11 AM, Marek Vasut wrote: > > The CD line is working perfectly well on this board, so I don't get it. > > In the schematics of this board, the SSP1_DETECT pin is connected to > the green led. As I see, there is no

Re: [PATCH] mmc: mxs-mmc: Add broken-cd devicetree property

2013-04-06 Thread Marek Vasut
lling must be > > > used. - non-removable: non-removable slot (like eMMC); assume always > > > present. > > > > But mxs-mmc set MMC_CAP_NEEDS_POLL unconditionally. > > I will work on a better way to fix this. NEEDS_POLL looks nice and seems to fit this ca

Re: [PATCH RFC] ARM: dts: mxs: leave card detect out of common mmc pins config

2013-04-08 Thread Marek Vasut
hat has CD support has to reference > 'mmc0_cd_cfg'. That's not necessarily true. > > > The driver will call get_cd() upon probing, which returns the status of > > the CD line. Please check these two platforms before applying. > > Ok, let's wait for people owning the boards to

Re: [PATCH RFC] ARM: dts: mxs: leave card detect out of common mmc pins config

2013-04-09 Thread Marek Vasut
Dear Hector Palacios, > Dear Marek Vasut, > > On 04/08/2013 06:28 PM, Marek Vasut wrote: > > Dear Shawn Guo, > > > >> On Mon, Apr 08, 2013 at 03:58:05PM +0200, Hector Palacios wrote: > >>> On 04/08/2013 02:48 PM, Shawn Guo wrote: > >>>>

Re: [PATCH RFC] ARM: dts: mxs: leave card detect out of common mmc pins config

2013-04-09 Thread Marek Vasut
Hi Hector, > Dear Marek Vasut, > > On 04/09/2013 10:15 AM, Marek Vasut wrote: > > Dear Hector Palacios, > > > >> Dear Marek Vasut, > >> > >> On 04/08/2013 06:28 PM, Marek Vasut wrote: > >>> Dear Shawn Guo, > >>>

Re: [PATCH 2/5] ARM: mxs-lradc: Simplify mxs_lradc_trigger_init error handle

2013-07-15 Thread Marek Vasut
dont want to do that in case of failure > - return 0; > + return ret; > } > > static void mxs_lradc_trigger_remove(struct iio_dev *iio) Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH 2/5] ARM: mxs-lradc: Simplify mxs_lradc_trigger_init error handle

2013-07-15 Thread Marek Vasut
Dear Otavio Salvador, > On Mon, Jul 15, 2013 at 11:24 AM, Marek Vasut wrote: > > Dear Otavio Salvador, > > > >> As we have a 'ret' variable with the iio_trigger_register return, this > >> can be used as result. > >> > >> Signed-off-by: Otavio

Re: [PATCH] m25p80 / fast read

2013-08-12 Thread Marek Vasut
rnels. This series adds a flag > to the chip specific data to solve this. Also some unnecessary ifdefs > are removed. > > Sascha Went through the whole series, Acked-by: Marek Vasut Thanks! Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH 1/4] mtd: m25p80: Pass flags through CAT25_INFO macro

2013-08-12 Thread Marek Vasut
at25c17", CAT25_INFO( 256, 8, 32, 2, M25P_NO_ERASE) }, > + { "cat25128", CAT25_INFO(2048, 8, 64, 2, M25P_NO_ERASE) }, > { }, > }; > MODULE_DEVICE_TABLE(spi, m25p_ids); I can't say I like the growing macro magic (voodoo?) in this file, but your patch does

Re: [PATCH] ARM: pxa/colibri: fix build with CONFIG_USB_OHCI_HCD=y

2013-11-07 Thread Marek Vasut
lboard.c:68: error: implicit declaration of > function 'IOMEM' make[1]: *** [arch/arm/mach-pxa/colibri-evalboard.o] > Error 1 > make: *** [arch/arm/mach-pxa] Error 2 > > Signed-off-by: Dmitry Artamonow Acked-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this list:

Possible bug in firmware/Makefile

2013-11-26 Thread Marek Vasut
there a way to specify the extra firmware file to be built into the kernel on the kernel build command line please? Thank you very much! Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.o

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-12 Thread Marek Vasut
"setting\n"); 372 return -EIO; 373 } btw. (idea for subsequent patch) this pch_dbg() should be fixed to be a one- liner /wrt the text so we can grep for the error messages. Such text arg should never be split in multiple lines in kernel. Best regards, Marek Vasut

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-12 Thread Marek Vasut
Dear Andreas Werner, > On Tue, Nov 12, 2013 at 07:00:59PM +0100, Marek Vasut wrote: > > Dear Andreas Werner, > > > > > Using the i2c-eg20t driver and call i2cdetect or probe on the bus, > > > the driver will print a lot of error messages if there was no ACK >

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-13 Thread Marek Vasut
Dear Andreas Werner, > On Tue, Nov 12, 2013 at 07:33:40PM +0100, Marek Vasut wrote: > > Dear Andreas Werner, > > > > > On Tue, Nov 12, 2013 at 07:00:59PM +0100, Marek Vasut wrote: > > > > Dear Andreas Werner, > > > > > > > > > Us

Re: [PATCH] gpio: ucb1400: Can be built as a module

2013-04-17 Thread Marek Vasut
Dear Jean Delvare, > With the recent code cleanup from Marek Vasut, driver gpio-ucb1400 can > be built as a module, so change symbol GPIO_UCB1400 from bool to > tristate. > > Signed-off-by: Jean Delvare > Cc: Marek Vasut > Cc: Grant Likely > Cc: Linus Walleij

Re: [PATCH] video: mxsfb: Fix colors display on lower color depth

2013-04-18 Thread Marek Vasut
= <18>; But it's also true we have all 24 data lines routed to the LCD. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH RESEND] video: mxsfb: Fix colors display on lower color depth

2013-04-22 Thread Marek Vasut
tant part of the color definition. > > So, to fix the colors display, just get back to the default controller > behaviour. > > Signed-off-by: Maxime Ripard Did you receive my latest email? Check M28EVK (imx28-m28evk.dts), it uses 18bit LCD and works without this patch I think.

Re: [PATCH RESEND] video: mxsfb: Fix colors display on lower color depth

2013-04-22 Thread Marek Vasut
Dear Maxime Ripard, > Hi Marek, > > Le 22/04/2013 11:16, Marek Vasut a écrit : > > Dear Maxime Ripard, > > > >> The current code always registers as a 32 bits display, and uses the > >> hardware to drop the MSB of each color to abjust to the

Re: How usable is spi-mxs driver?

2013-04-22 Thread Marek Vasut
ick that allows bi-directional communication. It can't do full duplex. I tested it with master-slave communication (half- duplex) and various SPI flashes. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to ma

[PATCH v2] UCB1400: Pass ucb1400-gpio data through ac97 bus

2013-04-14 Thread Marek Vasut
Cc: Linus Walleij Cc: Jean Delvare Cc: Samuel Ortiz Cc: Mark Brown Cc: Guenter Roeck Cc: linux-kernel Cc: Grant Likely Signed-off-by: Marek Vasut --- drivers/gpio/gpio-ucb1400.c | 19 ++- drivers/mfd/ucb1400_core.c |5 + include/linux/ucb1400.h | 18

Re: [PATCH v2] UCB1400: Pass ucb1400-gpio data through ac97 bus

2013-04-14 Thread Marek Vasut
Dear Marek Vasut, > Cc: Linus Walleij > Cc: Jean Delvare > Cc: Samuel Ortiz > Cc: Mark Brown > Cc: Guenter Roeck > Cc: linux-kernel > Cc: Grant Likely > Signed-off-by: Marek Vasut > --- > drivers/gpio/gpio-ucb1400.c | 19 ++- > d

Re: BUG: soft lockup when recording audio on MX28EVK with ASoC sgtl5000

2013-03-25 Thread Marek Vasut
13 > [ 936.449389] [] (__irq_svc+0x44/0x54) from [] > (cpu_arm926_switch_mm+0x8/0x20) > [ 936.458217] [] (cpu_arm926_switch_mm+0x8/0x20) from > [] (0xc6e303c0) > > The system does not completely die but it is extremely slow and almost > unusable, I checked that

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-27 Thread Marek Vasut
On Thursday, February 27, 2014 at 07:05:14 AM, Yuan Yao wrote: [...] > */ @@ -63,6 +68,9 @@ > /* Default value */ > #define IMX_I2C_BIT_RATE 10 /* 100kHz */ > > +/* enable DMA if transfer size is bigger than this threshold */ > +#define IMX_I2C_DMA_THRESHOLD16 So what's

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Marek Vasut
On Friday, February 28, 2014 at 06:19:18 AM, Yao Yuan wrote: [...] > > > @@ -213,6 +238,7 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata = { > > > > > > .ndivs = ARRAY_SIZE(vf610_i2c_clk_div), > > > .i2sr_clr_opcode= I2SR_CLR_OPCODE_W1C, > > > .i2cr_ien_opcode

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Marek Vasut
On Friday, February 28, 2014 at 03:23:52 AM, Shawn Guo wrote: > On Fri, Feb 28, 2014 at 10:13:02AM +0800, Shawn Guo wrote: > > On Thu, Feb 27, 2014 at 09:39:35PM +0100, Marek Vasut wrote: > > > > @@ -193,6 +216,7 @@ static const struct imx_i2c_hwdata &g

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Marek Vasut
> > > Sorry, I don't quite understand this. If you have two DMA channels, can > > you not use them both to do full-duplex SPI transfer ? > > Sorry, There are also hard for me. I don't understand what is full-duplex > for dma? Sorry, nevermind. I was confused by this

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Marek Vasut
On Friday, February 28, 2014 at 11:59:25 AM, Lothar Waßmann wrote: > Hi, > > Marek Vasut wrote: > > On Friday, February 28, 2014 at 06:19:18 AM, Yao Yuan wrote: > > > > [...] > > > > > Yes, here have two dma channels, one for RX and the other one fo

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-03-03 Thread Marek Vasut
On Monday, March 03, 2014 at 11:23:33 AM, Yao Yuan wrote: > Hi, Marek > > Marek Vasut wrote: > > On Thursday, February 27, 2014 at 07:05:14 AM, Yuan Yao wrote: > > > > [...] > > > > > +static void i2c_imx_dma_free(struct imx_i2c_struct *i2c_imx) { >

Re: [PATCH v2 1/2] i2c: add DMA support for freescale i2c driver

2014-03-05 Thread Marek Vasut
On Wednesday, March 05, 2014 at 07:52:31 AM, Yuan Yao wrote: > Add dma support for i2c. This function depend on DMA driver. > You can turn on it by write both the dmas and dma-name properties in dts > node. > > Signed-off-by: Yuan Yao > --- [...] > struct imx_i2c_struct { > struct

Re: [PATCH v2 1/2] i2c: add DMA support for freescale i2c driver

2014-03-05 Thread Marek Vasut
On Thursday, March 06, 2014 at 05:36:14 AM, Yao Yuan wrote: > On Thu, March 06, 2014 at 11:23:50 AM, Marek Vasut wrote: > > On Wednesday, March 05, 2014 at 07:52:31 AM, Yuan Yao wrote: > > > Add dma support for i2c. This function depend on DMA driver. > > > You c

Re: [PATCH v2 1/2] i2c: add DMA support for freescale i2c driver

2014-03-06 Thread Marek Vasut
On Thursday, March 06, 2014 at 06:02:03 AM, Yao Yuan wrote: > On Thu, March 06, 2014 at 12:44:14 PM, Marek Vasut wrote: > > On Thursday, March 06, 2014 at 05:36:14 AM, Yao Yuan wrote: > > > On Thu, March 06, 2014 at 11:23:50 AM, Marek Vasut wrote: > > > > On Wednesd

Re: [PATCH] reset: Add optional resets and stubs

2014-03-08 Thread Marek Vasut
e drivers > can be compiled with CONFIG_RESET_CONTROLLER disabled. > Also, device_reset is annotated with __must_check. Drivers ignoring the > return value should use device_reset_optional instead. > > Signed-off-by: Philipp Zabel Nice. Reviewed-by: Marek Vasut Best regards, Marek

Re: [PATCHv5 RESEND 4/4] iio: mxs-lradc: convert is_divided to a bitmap

2014-01-01 Thread Marek Vasut
anyway in a new years burst of > trying to clear the outstanding stuff in my in box ;) > > Applied to the togreg branch of iio.git > > Thanks, I dont mind, thanks for geting these in. And happy new year to you guys :) Best regards, Marek Vasut -- To unsubscribe from this list: se

Re: [PATCH 3/9] i2c: i2c-mxs: replace platform_driver_probe to support deferred probing

2013-10-08 Thread Marek Vasut
n't get lost in a deferred probe. > > Signed-off-by: Wolfram Sang > Cc: Marek Vasut Certainly makes sense, Acked-by: Marek Vasut Thanks! Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...

Re: KSZ8051 breakage

2013-09-18 Thread Marek Vasut
lso propose to convert the 50MHZ flag to OF as well. > > Other option is to handle this the same way as the 50MHZ flag, that is > being set by board code. I wouldn't mind, but we should use something generic the other PHYs can use as well. Best regards, Marek Vasut -- To unsubscr

Re: [PATCH -next] staging/iio/adc: MXS_LRADC depends on INPUT

2013-10-21 Thread Marek Vasut
ndefined reference to `input_event' > drivers/built-in.o:include/linux/input.h:389: more undefined references to > `input_event' follow > > Signed-off-by: Randy Dunlap Acked-by: Marek Vasut Thanks! Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 5/7] regulator: palmas: Use devm_regulator_register

2013-09-04 Thread Marek Vasut
eanup */ > @@ -1021,7 +1021,7 @@ static int palmas_regulators_probe(struct > platform_device *pdev) id, reg_init); > if (ret) { > regulator_unregister(pmic->rdev[id]); > - goto err_unregister_regulator; >

Re: [PATCH 6/7] regulator: rc5t583: Use devm_regulator_register

2013-09-04 Thread Marek Vasut
-208,7 +191,6 @@ static struct platform_driver rc5t583_regulator_driver > = { .owner= THIS_MODULE, > }, > .probe = rc5t583_regulator_probe, > - .remove = rc5t583_regulator_remove, > }; > > static int __init rc5t583_regulator_init(void) Next

Re: [PATCH 1/7] regulator: anatop-regulator: Use devm_regulator_register

2013-09-04 Thread Marek Vasut
Dear Sachin Kamat, > devm_* simplifies the code. > > Signed-off-by: Sachin Kamat Makes sense Acked-by: Marek Vasut > --- > This series is compile tested. > --- > drivers/regulator/anatop-regulator.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) &

Re: [PATCH 3/7] regulator: mc13783: Use devm_regulator_register

2013-09-04 Thread Marek Vasut
Dear Sachin Kamat, > devm_* simplifies the code. > > Signed-off-by: Sachin Kamat Acked-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH 4/7] regulator: mc13892: Use devm_regulator_register

2013-09-04 Thread Marek Vasut
Dear Sachin Kamat, > devm_* simplifies the code. > > Signed-off-by: Sachin Kamat Acked-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH 2/7] regulator: isl6271a-regulator: Use devm_regulator_register

2013-09-04 Thread Marek Vasut
Dear Sachin Kamat, > devm_* simplifies the code. > > Signed-off-by: Sachin Kamat Acked-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH v2 1/5] iio: mxs-lradc: change the realbits to 12

2013-07-19 Thread Marek Vasut
bits), instead of between 0 and 0xfff (12 bits). > > Signed-off-by: Hector Palacios Acked-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v2 2/5] ARM: dts: add reference voltage property for MXS LRADC

2013-07-19 Thread Marek Vasut
t;, "fsl,imx23-lradc" This is a separate fix, but I think it's not that important to rework the whole patchset because of it. Acked-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH v2 5/5] iio: mxs-lradc: add write_raw function to modify scale

2013-07-19 Thread Marek Vasut
LUS_NANO; > +} > + > static ssize_t mxs_lradc_show_scale_available_ch(struct device *dev, > struct device_attribute *attr, > char *buf, > @@ -400,6 +451,8 @@ static const struct attribute_group > mxs_lradc_attribute_group = { static const struct iio_info > mxs_lr

Re: [PATCH v2 3/5] iio: mxs-lradc: add scale attribute to channels

2013-07-19 Thread Marek Vasut
\ > .sign = 'u',\ > @@ -960,6 +977,12 @@ static int mxs_lradc_probe(struct platform_device > *pdev) goto err_addr; > } > > + /* Grab Vref array from DT */ > + ret = of_property_read_u32_array(node, "fsl,vref",

Re: [PATCH v2 5/5] iio: mxs-lradc: add write_raw function to modify scale

2013-07-19 Thread Marek Vasut
Dear Hector Palacios, > Dear Marek, > > On 07/19/2013 04:39 PM, Marek Vasut wrote: > > Dear Hector Palacios, > > > >> Added write_raw function to manipulate the optional divider_by_two > >> through the scaling attribute out of the available scales. &g

Re: [PATCH v2 3/5] iio: mxs-lradc: add scale attribute to channels

2013-07-19 Thread Marek Vasut
Dear Hector Palacios, > Dear Marek, > > On 07/19/2013 04:30 PM, Marek Vasut wrote: > >> @@ -228,39 +230,12 @@ struct mxs_lradc { > >> > >> #define LRADC_RESOLUTION 12 > >> #define LRADC_SINGLE_SAMPLE_MASK ((1 << LRA

Re: [PATCH v2 5/5] iio: mxs-lradc: add write_raw function to modify scale

2013-07-20 Thread Marek Vasut
Dear Jonathan Cameron, > On 07/19/2013 05:22 PM, Hector Palacios wrote: > > Dear Marek, > > > > On 07/19/2013 06:17 PM, Marek Vasut wrote: > >>> Here you have three entries per channel: > >>> in_voltageX_raw-> the sample raw value >

Re: [PATCH v2 3/5] iio: mxs-lradc: add scale attribute to channels

2013-07-22 Thread Marek Vasut
Dear Hector Palacios, > Hi Marek, > > On 07/19/2013 06:14 PM, Marek Vasut wrote: > > Dear Hector Palacios, > > > >> Dear Marek, > >> > >> On 07/19/2013 04:30 PM, Marek Vasut wrote: > >>>> @@ -228,39 +230,12 @

Re: [PATCH v2 3/5] iio: mxs-lradc: add scale attribute to channels

2013-07-22 Thread Marek Vasut
Hi Hector, > Hi Marek, > > On 07/22/2013 09:42 AM, Marek Vasut wrote: > > Dear Hector Palacios, > > > >> Hi Marek, > >> > >> On 07/19/2013 06:14 PM, Marek Vasut wrote: > >>> Dear Hector Palacios, > >>> >

Re: [PATCH v3 5/5] iio: mxs-lradc: add write_raw function to modify scale

2013-07-22 Thread Marek Vasut
Dear Hector Palacios, > Added write_raw function to manipulate the optional divider_by_two > through the scaling attribute out of the available scales. > > Signed-off-by: Hector Palacios > --- Yep, looks nicer, Reviewed-by: Marek Vasut Best regards, Marek Vasut -- To u

Re: [PATCH v3 4/5] iio: mxs-lradc: add scale_available file to channels

2013-07-22 Thread Marek Vasut
.nano = > + do_div(scale_uv, 1) * 10; Are we not loosing precission here? > + lradc->scale_avail[i][s].integer = scale_uv; > + } > + } > + > /* Configure the hardware. */ > mxs_lradc_hw_init(lra

Re: [PATCH v3 2/5] ARM: dts: add reference voltage property for MXS LRADC

2013-07-22 Thread Marek Vasut
/msg36691.ht > ml I guess I'm not alone with that opinion. > > - Lars He's talking about different versions of the IP block, this is the same IP block, just connected to different inputs. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH V3 5/5] input: pxa27x-keypad: add device tree support

2013-06-19 Thread Marek Vasut
rrupt for the keypad controller > +- marvell,debounce-interval : How long time the key will be Is there no generic prop name for this debounce interval? Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: MXS USB otg device support

2013-05-28 Thread Marek Vasut
re working on that? > > I am not aware of the latest status about chipidea usb otg support for > i.mx. I gave up on tracking that mayhem. > Please post this question in the linux-usb list and add Peter Chen, the > folks from Pengutronix and Alexander Shishkin in Cc. Good idea. A

Re: [PATCH 1/2] phy/micrel: Add support for KSZ8031

2013-03-11 Thread Marek Vasut
s I dont have any board with this one, yet I think this change is correct, so: Reviewed-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

Re: [PATCH] imx-drm: parallel-display: honor 'native-mode' property when selecting video mode from DT

2014-01-13 Thread Marek Vasut
> their .dts files, the patch does not change the behaviour of this > driver on the affected platforms. > > Signed-off-by: Lothar Waßmann Looks OK to me, thanks. Reviewed-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH 2/3] iio: mxs-lradc: fix invalid channel number detection

2014-01-13 Thread Marek Vasut
15. > > Signed-off-by: Alexandre Belloni Why don't you remove the check entirely then ? Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ke

Re: [PATCH 4/7] drivers/pci/host: don't check resource with devm_ioremap_resource

2014-01-14 Thread Marek Vasut
On Tuesday, January 14, 2014 at 12:58:55 PM, Wolfram Sang wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang True that, Acked-by: Marek Vasut > --- > > Should go via subsyst

Re: [PATCH 3.5 057/103] HID: add quirk for Freescale i.MX23 ROM recovery

2013-12-18 Thread Marek Vasut
source/linux/+bug/1258332 Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 3.5 057/103] HID: add quirk for Freescale i.MX23 ROM recovery

2013-12-18 Thread Marek Vasut
On Wednesday, December 18, 2013 at 05:16:13 PM, Luis Henriques wrote: > Hi Marek, > > On Tue, Dec 17, 2013 at 08:39:03PM +0100, Marek Vasut wrote: > > On Tuesday, December 17, 2013 at 07:12:46 PM, Luis Henriques wrote: > > > 3.5.7.28 -stable review patch. If anyone ha

Re: [PATCH 10/12] backlight: lms283gf05: Remove unnecessary OOM messages

2014-02-06 Thread Marek Vasut
On Thursday, February 06, 2014 at 09:26:26 AM, Jingoo Han wrote: > The site-specific OOM messages are unnecessary, because they > duplicate the MM subsystem generic OOM message. > > Signed-off-by: Jingoo Han Acked-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe fr

Re: [PATCH v2] iio: mxs-lradc: remove useless check

2014-01-18 Thread Marek Vasut
exandre Belloni > --- > drivers/staging/iio/adc/mxs-lradc.c | 4 > 1 file changed, 4 deletions(-) Changelog's missing ;-) Acked-by: Marek Vasut > diff --git a/drivers/staging/iio/adc/mxs-lradc.c > b/drivers/staging/iio/adc/mxs-lradc.c index 7fc66a6a6e36..d304156ca2f7 > 100644 &g

Re: [PATCH 1/2] iio: add IIO_DISTANCE type

2014-01-31 Thread Marek Vasut
IIO_PRESSURE, > IIO_HUMIDITYRELATIVE, > + IIO_DISTANCE, > }; > > enum iio_modifier { Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/2] iio: Add AS3935 lightning sensor support

2014-01-31 Thread Marek Vasut
On Friday, January 31, 2014 at 04:38:23 PM, Matt Ranostay wrote: [...] > diff --git a/Documentation/devicetree/bindings/iio/distance/as3935.txt > b/Documentation/devicetree/bindings/iio/distance/as3935.txt new file mode > 100644 > index 000..af35827 > --- /dev/null > +++

Re: [PATCH 2/2] iio: Add AS3935 lightning sensor support

2014-01-31 Thread Marek Vasut
is because you probably want to protect them against concurent execution so the chip won't be confused if a user were to poke something via SYSFS twice. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to major

Re: [PATCHv5 RESEND 0/4] iio: mxs-lradc: add support to optional divider_by_two

2013-12-23 Thread Marek Vasut
219 insertions(+), 3 > deletions(-) Why is there a resend please ? Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCHv5 RESEND 0/4] iio: mxs-lradc: add support to optional divider_by_two

2013-12-23 Thread Marek Vasut
On Monday, December 23, 2013 at 08:22:04 PM, Alexandre Belloni wrote: > On 23/12/2013 19:54, Marek Vasut wrote: > > On Monday, December 23, 2013 at 06:48:00 PM, Alexandre Belloni wrote: > >> Hello, > >> > >> This is v5 of the patchset that adds support to the o

Re: gpio-ucb1400

2013-03-30 Thread Marek Vasut
thing, please let me know. > > Interestingly, the author made an attempt to fix that with [1]. It looks > like the rest of that series was merged, but this patch wasn't, though I > don't find any information about the reason. It's been a while. Guenter, thanks for finding that link,

Re: gpio-ucb1400

2013-03-31 Thread Marek Vasut
Dear Guenter Roeck, > On Sat, Mar 30, 2013 at 08:20:44PM +0100, Marek Vasut wrote: > > Dear Guenter Roeck, > > > > > On Fri, Mar 29, 2013 at 08:46:39PM +0100, Jean Delvare wrote: > > > > Hi all, > > > > > > > > In Septem

Re: [PATCHv3 2/3] ARM: mxs: cfa10049: Switch bus i2c1 to bitbanging

2013-07-02 Thread Marek Vasut
nly one question comes to mind with this email -- what do LRADC and I2C have to do with each other here ? It'd be nice if someone could summarize on what I should focus and possibly prepare a testcase. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCHv4 0/3] iio: mxs-lradc: add support to optional divider_by_two

2013-12-08 Thread Marek Vasut
ed, 219 insertions(+), 3 > deletions(-) Looks OK to me for all but the tweaks Jonathan requested, thanks! Whole series otherwise: Acked-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord

Re: [PATCH] ARM: dts: stmpe-ts: fix wrong bindings

2013-12-09 Thread Marek Vasut
e error is obvious. The device > probably works anyway since the device/driver will use default values. Full agreement here. Reviewed-by: Marek Vasut btw. I plan to rework the STMPE TS as it doesn't work nicely on my device at all. I am seriously lacking time, but I will try! ;-) Best

Re: [PATCH] ARM: pxa: prevent PXA270 occasional reboot freezes

2013-12-10 Thread Marek Vasut
ratum 71) > >> + * we put SDRAM into self-refresh to prevent that > >> + */ > >> + while (1) > >> + writel_relaxed(MDREFR_SLFRSH, MDREFR); > >> > >> } > >> > >> void pxa_restart(enum reboot_mode mode, c

Re: [PATCH 05/17] pci: host: pcie-dra7xx: add support for pcie-dra7xx controller

2014-05-06 Thread Marek Vasut
On Tuesday, May 06, 2014 at 03:33:51 PM, Kishon Vijay Abraham I wrote: > Added support for pcie controller in dra7xx. This driver re-uses > the designware core code that is already present in kernel. [...] > +#define to_dra7xx_pcie(x)container_of((x), struct dra7xx_pcie, pp) > + > +static

Re: [PATCH] crypto: caam: Introduce the use of the managed version of kzalloc

2014-06-01 Thread Marek Vasut
wing Coccinelle semantic patch was used for making the change: Reviewed-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 1/2] iio: mxs-lradc: fix divider

2014-06-10 Thread Marek Vasut
ent, and enable / disable > the divider as required. > > Signed-off-by: Robert Hodaszi Acked-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH 2/2] iio: mxs-lradc: add ADC channel 9 as a copy of channel 8

2014-06-10 Thread Marek Vasut
On Tuesday, June 10, 2014 at 03:41:35 PM, Robert Hodaszi wrote: > Commit c8231a9af8147f8a401fc55931ec44abfb937660 ("iio: mxs-lradc: compute > temperature from channel 8 and 9") merged channel 8 and channel 9 to create > an IIO_TEMP channel. It changed the number of LRADC channels, which could >

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-04 Thread Marek Vasut
nly to the relevant parts when replying so it's easier to find your commments in the entire body of text. > > + if (!dma->chan_tx) { > > + dev_info(dev, "DMA tx channel request failed\n"); > > + ret = -ENODEV; > > +

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-04 Thread Marek Vasut
} > + > + txdesc->callback = i2c_imx_dma_callback; > + txdesc->callback_param = i2c_imx; > + dmaengine_submit(txdesc); > + dma_async_issue_pending(dma->chan_using); > + > + return 0; > +} [...] Other than those two things, Reviewed-by: Mare

Re: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

2014-03-22 Thread Marek Vasut
On Thursday, March 13, 2014 at 02:47:56 AM, Yuan Yao wrote: > Add dma support for i2c. This function depend on DMA driver. > You can turn on it by write both the dmas and dma-name properties in dts > node. > > Signed-off-by: Yuan Yao > --- > drivers/i2c/busses/i2c-imx.c | 354 >

Re: New NAND driver

2014-03-24 Thread Marek Vasut
47 patches for reviewing purposes. One nand driver in 47 patches ? Whoa ;-) Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/major

Re: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

2014-03-25 Thread Marek Vasut
> > Then you won't need a separate variable, for this purpose ... right ? > > Sorry and I think what I know is just to check whether it is NULL. > Then for the second question, maybe there are some other ways, But I think > it is more tidy and easier understanding for using a separat

Re: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

2014-03-26 Thread Marek Vasut
On Wednesday, March 26, 2014 at 06:56:34 AM, Yao Yuan wrote: > On Wednesday, March 26, 2014 at 11:43:27 AM, Marek Vasut wrote: > > On Wednesday, March 26, 2014 at 04:08:27 AM, Yao Yuan wrote: > > > > [...] > > > > > > > + i2c_im

Re: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

2014-03-26 Thread Marek Vasut
On Wednesday, March 26, 2014 at 08:08:28 AM, Yao Yuan wrote: > On Wednesday, March 26, 2014 at 02:27:46 PM, Marek Vasut wrote: > > On Wednesday, March 26, 2014 at 06:56:34 AM, Yao Yuan wrote: > > > On Wednesday, March 26, 2014 at 11:43:27 AM, Marek Vasut wrote: > > > >

Re: [RFC PATCH 03/12] pci: host: pcie-designware: Use *base-mask* for configuring the iATU

2014-03-27 Thread Marek Vasut
ranslation window the > > *base* should be programmed as 0x000_. Whenever we try to write to > > say 0x2000_, it will be translated to whatever we have programmed in > > the translation window with base as 0x000_. > > > > Signed-off-by: Kishon Vijay Abraham I

Re: [PATCH 2/3] ARM: sun7i: dt: Add Security System to A20 SoC DTS

2014-05-24 Thread Marek Vasut
clock-names = "ahb", "mod"; > + }; > + > spi2: spi@01c17000 { > compatible = "allwinner,sun4i-a10-spi"; > reg = <0x01c17000 0x1000>; Best regards, Marek Vasut -- To

Re: [PATCH] crypto: x86/sha1: fix coverity CID 1195603

2014-05-24 Thread Marek Vasut
ying this. I suppose changing the commit message to "align the code with sha256 ... NOTE: this also fixed CIDxyz." would work better and might get this applied ? I think unification of code is always good. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "uns

Re: [PATCH 3/3] crypto: Add Allwinner Security System crypto accelerator

2014-05-24 Thread Marek Vasut
On Thursday, May 22, 2014 at 05:09:56 PM, LABBE Corentin wrote: Do I have to repeat myself ? :) > Signed-off-by: LABBE Corentin > --- > drivers/crypto/Kconfig| 49 ++ > drivers/crypto/Makefile |1 + > drivers/crypto/sunxi-ss.c | 1476 > +

Re: [PATCH 1/3] dt: Add DT bindings documentation for SUNXI Security System

2014-05-24 Thread Marek Vasut
; +- clock-names : Name of the functional clock, should be "ahb" and "mod". > + Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 3/3] crypto: Add Allwinner Security System crypto accelerator

2014-05-24 Thread Marek Vasut
t; can I add a sunxi-ss directory in drivers/crypto ? > > Yes, I think a subdirectory would be best. Full ACK on this one. Use drivers/crypto/sunxi-ss/ . [...] Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messa

Re: [PATCH 1/3] dt: Add DT bindings documentation for SUNXI Security System

2014-05-24 Thread Marek Vasut
On Saturday, May 24, 2014 at 09:20:03 PM, Tomasz Figa wrote: > Hi Marek, > > On 24.05.2014 13:21, Marek Vasut wrote: > > On Thursday, May 22, 2014 at 05:09:54 PM, LABBE Corentin wrote: > > > > Missing commit message. Please fix this and send a V2. > > &

Re: [PATCH 1/3] dt: Add DT bindings documentation for SUNXI Security System

2014-05-24 Thread Marek Vasut
atasheets...). Better get the DT stuff correctly right from the start. That's why I'm asking what chips contains the IP block, so we can guess the right name. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

<    4   5   6   7   8   9   10   11   12   13   >