Re: [PATCH v21 05/10] fs/ntfs3: Add attrib operations

Hi Konstantin, It looks like you've renamed the xattrs again since I last checked this - is there a reason for this? As I said in my previous messages, it makes sense for these to be the same as the de facto standard (user.DOSATTRIB and security.NTACL) used by Wine, Samba, and my Windows btrfs dr

Re: [PATCH v17 08/10] fs/ntfs3: Add Kconfig, Makefile and doc

On 18/1/21 11:43 am, Konstantin Komarov wrote: > From: Kari Argillander > Sent: Monday, January 4, 2021 1:08 AM >> To: Konstantin Komarov >> Cc: linux-fsde...@vger.kernel.org; v...@zeniv.linux.org.uk; >> linux-kernel@vger.kernel.org; p...@kernel.org; dste...@suse.cz; >> aap...@suse.com; wi...@in

Re: [PATCH v18 01/10] fs/ntfs3: Add headers and misc files

Hi Konstantin, Shouldn't upcase_unicode_char be using the NTFS pseudo-file $UpCase? That way you should also be covered for other bicameral alphabets. Mark On 22/1/21 2:01 pm, Konstantin Komarov wrote: > This adds headers and misc files > > Signed-off-by: Konstantin Komarov > --- > fs/ntfs3/d

[RFC PATCH 02/19] btrfs: add encryption dependencies to Kconfig

Signed-off-by: Mark Harmstone --- fs/btrfs/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig index 23537bc8c827..e6b3b51da91f 100644 --- a/fs/btrfs/Kconfig +++ b/fs/btrfs/Kconfig @@ -12,6 +12,10 @@ config BTRFS_FS select RAID6_PQ

[RFC PATCH 03/19] btrfs: load key tree

Signed-off-by: Mark Harmstone --- fs/btrfs/ctree.h | 2 ++ fs/btrfs/disk-io.c | 11 +++ 2 files changed, 13 insertions(+) diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index 68f322f600a0..bd2e59dd0eba 100644 --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h @@ -758,6 +758,7 @@ struct

[RFC PATCH 01/19] btrfs: add encryption structs and constants

fprintf(stderr, "add_btrfs_key returned %i\n", ret); goto end2; } /* Set xattr */ sprintf(keyhex, "%016llx", args.salt); ret = setxattr(argv[1], "btrfs.key", keyhex, strlen(keyhex), 0); if (ret) { fprin

[RFC PATCH 04/19] btrfs: allow encrypted volumes to be mounted

Signed-off-by: Mark Harmstone --- fs/btrfs/ctree.h| 3 ++- fs/btrfs/encryption.h | 20 fs/btrfs/tree-checker.c | 39 +-- 3 files changed, 51 insertions(+), 11 deletions(-) create mode 100644 fs/btrfs/encryption.h diff --git a

[RFC PATCH 08/19] btrfs: change extract in prop_handler to write into string

Signed-off-by: Mark Harmstone --- fs/btrfs/props.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/fs/btrfs/props.c b/fs/btrfs/props.c index dc6140013ae8..e57a4edc88c4 100644 --- a/fs/btrfs/props.c +++ b/fs/btrfs/props.c @@ -19,7 +19,7 @@ struct

[RFC PATCH 18/19] btrfs: return encrypted flag to statx

Signed-off-by: Mark Harmstone --- fs/btrfs/inode.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 8f58f492abc8..beaeeafe467a 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -9637,11 +9637,14 @@ static int btrfs_getattr

[RFC PATCH 19/19] btrfs: translate encryption flag to FS_ENCRYPT_FL

Signed-off-by: Mark Harmstone --- fs/btrfs/ioctl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 6589656e3988..af054390d78d 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -123,6 +123,8 @@ static unsigned int

[RFC PATCH 17/19] btrfs: don't allow direct IO of encrypted extents

Signed-off-by: Mark Harmstone --- fs/btrfs/inode.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index f8bc7174f7e3..8f58f492abc8 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -7945,6 +7945,17 @@ static int btrfs_get_blocks_direct

[RFC PATCH 11/19] btrfs: allow writing encrypted inline extents

Signed-off-by: Mark Harmstone --- fs/btrfs/ctree.h | 5 +- fs/btrfs/encryption.c | 156 +- fs/btrfs/encryption.h | 9 +++ fs/btrfs/inode.c | 99 +++ fs/btrfs/ioctl.c | 2 +- 5 files changed, 254 insertions

[RFC PATCH 16/19] btrfs: add encryption incompat flag to sysfs

Signed-off-by: Mark Harmstone --- fs/btrfs/sysfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index 3717c864ba23..6bd70188ea62 100644 --- a/fs/btrfs/sysfs.c +++ b/fs/btrfs/sysfs.c @@ -191,6 +191,7 @@ BTRFS_FEAT_ATTR_INCOMPAT(extended_iref

[RFC PATCH 15/19] btrfs: allow writing compressed, encrypted, inline extents

Signed-off-by: Mark Harmstone --- fs/btrfs/inode.c | 16 1 file changed, 16 insertions(+) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 61481833f5e4..f8bc7174f7e3 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -219,6 +219,22 @@ static int insert_inline_extent

[RFC PATCH 12/19] btrfs: allow reading normal encrypted extents

Signed-off-by: Mark Harmstone --- fs/btrfs/ctree.h | 6 +++ fs/btrfs/encryption.c | 37 + fs/btrfs/encryption.h | 3 ++ fs/btrfs/extent_io.c | 96 --- fs/btrfs/extent_io.h | 2 + fs/btrfs/extent_map.c | 16 +++- fs/btrfs

[RFC PATCH 13/19] btrfs: allow writing normal and compressed encrypted extents

Signed-off-by: Mark Harmstone --- fs/btrfs/encryption.c | 125 fs/btrfs/encryption.h | 8 ++ fs/btrfs/extent_io.c| 20 +++-- fs/btrfs/inode.c| 180 ++-- fs/btrfs/ordered-data.c | 19 +++-- fs/btrfs/ordered

[RFC PATCH 14/19] btrfs: allow reading compressed encrypted extents

Signed-off-by: Mark Harmstone --- fs/btrfs/compression.c | 22 ++ fs/btrfs/compression.h | 7 +++ 2 files changed, 29 insertions(+) diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c index 2955a4ea2fa8..55d7b97a7dc9 100644 --- a/fs/btrfs/compression.c +++ b/fs

[RFC PATCH 10/19] btrfs: allow reading encrypted inline extents

Signed-off-by: Mark Harmstone --- fs/btrfs/encryption.c | 305 ++ fs/btrfs/encryption.h | 3 + fs/btrfs/inode.c | 72 +- 3 files changed, 379 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/encryption.c b/fs/btrfs/encryption.c index

[RFC PATCH 06/19] btrfs: add ioctl BTRFS_IOC_GET_KEY_SALT

Signed-off-by: Mark Harmstone --- fs/btrfs/Makefile | 2 +- fs/btrfs/ctree.h | 4 + fs/btrfs/disk-io.c | 6 ++ fs/btrfs/encryption.c | 58 + fs/btrfs/encryption.h | 3 + fs/btrfs/ioctl.c | 170

[RFC PATCH 09/19] btrfs: add btrfs.key property

Signed-off-by: Mark Harmstone --- fs/btrfs/btrfs_inode.h | 5 fs/btrfs/ctree.h | 1 + fs/btrfs/inode.c | 1 + fs/btrfs/props.c | 68 ++ 4 files changed, 75 insertions(+) diff --git a/fs/btrfs/btrfs_inode.h b/fs/btrfs

[RFC PATCH 05/19] btrfs: add key list

Signed-off-by: Mark Harmstone --- fs/btrfs/ctree.h | 5 + fs/btrfs/disk-io.c| 18 ++ fs/btrfs/encryption.h | 13 + 3 files changed, 36 insertions(+) diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index 723e9b38e0aa..3f3356a2d145 100644 --- a/fs/btrfs

[RFC PATCH 07/19] btrfs: add new keys to key root when flushed

Signed-off-by: Mark Harmstone --- fs/btrfs/transaction.c | 79 +- 1 file changed, 78 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c index d1eeef9ec5da..a6c8d49b6962 100644 --- a/fs/btrfs/transaction.c +++ b/fs

Re: [PATCH v3 05/10] fs/ntfs3: Add attrib operations

Konstantin, can you please reply to my comments from the last time you submitted this patch? I'm concerned that if your patches are accepted, it becomes an awful lot more difficult to correct design flaws like these.

Re: [PATCH v2 05/10] fs/ntfs3: Add attrib operations

Hi Konstantin, I have an interest in this - I wrote the Btrfs driver for Windows, which also had to deal with the issue of how to map NTFS concept to Linux xattrs. Unless there's a good reason, I think it'd be in everyone's interests if we used the same conventions. You have four(!) different

Re: [PATCH v2 05/10] fs/ntfs3: Add attrib operations

On 28/8/20 5:52 pm, Konstantin Komarov wrote: > Hi Mark! Thanks for the feedback. It's reasonable concern, but the open > question is how to access those NTFS attributes which extend the DOS > attributes. user.DOSATTRIB may be good for FAT32 as DOS attributes are stored > in 8bit. > However, this

Re: [PATCH v6 05/10] fs/ntfs3: Add attrib operations

Could I suggest that system.ntfs_security be renamed to security.NTACL? That's what WinBtrfs uses, and it means you'd be able to create a working Btrfs copy of a Windows installation just by using rsync. IIRC Samba also understands xattrs called security.NTACL, when you've put it in the right mode.