Re: [PATCH v2 0/2] scsi: ufs: Fix power drain and hci quirk for WriteBooster

2021-01-07 Thread Martin K. Petersen
https://git.kernel.org/mkp/scsi/c/1d53864c3617 [2/2] scsi: ufs: Relax the condition of UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL https://git.kernel.org/mkp/scsi/c/21acf4601cc6 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvfc: fix missing cast of ibmvfc_event pointer to u64 handle

2021-01-07 Thread Martin K. Petersen
e] val > ibmvfc.c:2375:36: sparse: got struct ibmvfc_event *[assigned] evt > > [...] Applied to 5.11/scsi-fixes, thanks! [1/1] ibmvfc: fix missing cast of ibmvfc_event pointer to u64 handle https://git.kernel.org/mkp/scsi/c/901d01c8e50c -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v5 0/2] Two UFS fixes

2021-01-07 Thread Martin K. Petersen
fix livelock of ufshcd_clear_ua_wluns https://git.kernel.org/mkp/scsi/c/4ee7ee530bc2 [2/2] scsi: ufs: fix tm request correctly when non-fatal error happens https://git.kernel.org/mkp/scsi/c/eeb1b55b6e25 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ufs: ufshcd-pltfrm depends on HAS_IOMEM

2021-01-07 Thread Martin K. Petersen
org/mkp/scsi/c/5e6ddadf7637 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: megaraid_sas: Fix MEGASAS_IOC_FIRMWARE regression

2021-01-07 Thread Martin K. Petersen
0. > Severity: Critical > Message ID: PCI1308 > > [...] Applied to 5.11/scsi-fixes, thanks! [1/1] scsi: megaraid_sas: Fix MEGASAS_IOC_FIRMWARE regression https://git.kernel.org/mkp/scsi/c/b112036535ed -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ufs: Correct the lun used in eh_device_reset_handler() callback

2021-01-07 Thread Martin K. Petersen
callback https://git.kernel.org/mkp/scsi/c/35fc4cd34426 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] scsi: sd: remove obsolete variable in sd_remove()

2021-01-07 Thread Martin K. Petersen
gt; Hence, make W=1 warns: > > drivers/scsi/sd.c:3516:8: > warning: variable 'devt' set but not used [-Wunused-but-set-variable] > > [...] Applied to 5.11/scsi-fixes, thanks! [1/1] scsi: sd: remove obsolete variable in sd_remove() https://git.kernel.org/mkp/scsi/c/be255335

Re: [PATCH] [v2] scsi: scsi_debug: Fix memleak in scsi_debug_init

2021-01-07 Thread Martin K. Petersen
(). Applied to 5.11/scsi-fixes, thanks! [1/1] scsi: scsi_debug: Fix memleak in scsi_debug_init https://git.kernel.org/mkp/scsi/c/3b01d7ea4dae -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/3] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback() -- Take 2

2021-01-07 Thread Martin K. Petersen
n in > question (patch 3/3); patch 1/3 emerged from internal review of these > two patches and is a related fix. Applied to 5.12/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH V4] scsi: ufs-debugfs: Add error counters

2021-01-07 Thread Martin K. Petersen
gt; initialization is done in link order, so move ufshcd-core to the top > of the Makefile. Applied to 5.12/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3] scsi: ufs: Replace sprintf and snprintf with sysfs_emit

2021-01-07 Thread Martin K. Petersen
Bean, > sprintf and snprintf may cause output defect in sysfs content, it is > better to use new added sysfs_emit function which knows the size of > the temporary buffer. Applied to 5.12/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH -next] scsi: ufs: fix all Kconfig help text indentation

2021-01-07 Thread Martin K. Petersen
Randy, > Use consistent and expected indentation for all Kconfig text. Applied to 5.12/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 0/5] ibmvfc: MQ preparatory locking work

2021-01-07 Thread Martin K. Petersen
; from the host lock reducing lock contention while also relaxing > locking for submissions and completions to simply the list lock of the > queue in question. Applied to 5.12/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v4 0/6] Several changes for the UPIU trace

2021-01-07 Thread Martin K. Petersen
query RSP in query trace > scsi: ufs: Distinguish between TM request UPIU and response UPIU in TM > UPIU trace > scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM Applied to 5.12/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 4/5] ibmvfc: complete commands outside the host/queue lock

2021-01-05 Thread Martin K. Petersen
l patches. thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/2] hisi_sas: Expose hw queues for v2 hw and remove unused code

2021-01-05 Thread Martin K. Petersen
John, > Patch "scsi: hisi_sas: Expose HW queues for v2 hw" was not merged for > v5.11, so resending for v5.12. Any changes to it? 5.11/postmerge is sitting in my fixes branch. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] scsi: ufs: fix livelock of ufshcd_clear_ua_wluns

2021-01-05 Thread Martin K. Petersen
xisting patch. Both b4 and patchwork get confused. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 0/4] scsi: ufs: Cleanup and refactor clock scaling

2021-01-05 Thread Martin K. Petersen
. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v5 5/5] scsi: hisi_sas: Expose HW queues for v2 hw

2020-12-11 Thread Martin K. Petersen
s > rebased for those. I'll do a postmerge branch for a few things, including your patch and the megaraid patch. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] Revert "scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()"

2020-12-11 Thread Martin K. Petersen
Wei, > Sorry for the last minute patch. We would very like this goes into > 5.10 if possible; otherwise Linux 5.10 is going to be broken on > Hyper-V. :-( Applied to 5.10/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3] scsi: ufs: Remove pre-defined initial voltage values of device powers

2020-12-09 Thread Martin K. Petersen
-1p8" is declared in > device tree) > (3). 2.40V - 2.70V (Supported since UFS 3.x) > > [...] Applied to 5.11/scsi-queue, thanks! [1/1] scsi: ufs: Remove pre-defined initial voltage values of device powers https://git.kernel.org/mkp/scsi/c/5b44a07b6bb2

Re: [PATCH v3] scsi: NCR5380: Remove context check

2020-12-09 Thread Martin K. Petersen
context should either be > separated, or the context be explicitly conveyed in an argument passed > by the caller. > > [...] Applied to 5.11/scsi-queue, thanks! [1/1] scsi: NCR5380: Remove context check https://git.kernel.org/mkp/scsi/c/e7734ef14ead -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: fnic: fix error return code in fnic_probe()

2020-12-09 Thread Martin K. Petersen
https://git.kernel.org/mkp/scsi/c/d4fc94fe6557 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: qla4xxx: remove redundant assignment to variable rval

2020-12-09 Thread Martin K. Petersen
x: remove redundant assignment to variable rval https://git.kernel.org/mkp/scsi/c/3a5b9fa2cc5f -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] scsi: qla2xxx: remove trailing semicolon in macro definition

2020-12-09 Thread Martin K. Petersen
scsi/c/8f525bc2a7b2 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: iscsi: fix inappropriate use of put_device

2020-12-09 Thread Martin K. Petersen
: iscsi: fix inappropriate use of put_device https://git.kernel.org/mkp/scsi/c/6dc1c7ab6f04 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: qedi: fix missing destroy_workqueue() on error in __qedi_probe

2020-12-09 Thread Martin K. Petersen
oy_workqueue() on error in __qedi_probe https://git.kernel.org/mkp/scsi/c/62eebd5247c4 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v5 0/4] scsi: ufs: Refine error history and introduce event_notify vop

2020-12-09 Thread Martin K. Petersen
https://git.kernel.org/mkp/scsi/c/e965e5e00b23 [3/4] scsi: ufs: Introduce event_notify variant function https://git.kernel.org/mkp/scsi/c/172614a9d0e8 [4/4] scsi: ufs-mediatek: Introduce event_notify implementation https://git.kernel.org/mkp/scsi/c/ca1bb061d644 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v1 0/4] scsi: ufs: Cleanup phy_initialization vop

2020-12-09 Thread Martin K. Petersen
e phy_initialization helper https://git.kernel.org/mkp/scsi/c/92bcebe4b6d6 [3/4] scsi: ufs-cdns: Use phy_initialization helper https://git.kernel.org/mkp/scsi/c/885445736bc0 [4/4] scsi: ufs-dwc: Use phy_initialization helper https://git.kernel.org/mkp/scsi/c/ab98105484fc -- Martin K.

Re: [PATCH] ufshcd: fix Wsometimes-uninitialized warning

2020-12-09 Thread Martin K. Petersen
~~ > > [...] Applied to 5.11/scsi-queue, thanks! [1/1] ufshcd: fix Wsometimes-uninitialized warning https://git.kernel.org/mkp/scsi/c/4c60244dc372 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] SCSI: cxgb4i: fix TLS dependency

2020-12-09 Thread Martin K. Petersen
> SCSI_CXGB4_ISCSI to 'm' whenever TLS=m. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 0/2] scsi: ufs: Re-enable WB after device reset

2020-12-09 Thread Martin K. Petersen
Stanley, > This series fixes up an issue that WB is not re-enabled after device > reset. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/1] scsi: ufs-mediatek: use correct path to fix compiling error

2020-12-09 Thread Martin K. Petersen
Zhen, > So without "CFLAGS_ufs-mediatek.o := -I$(src)", the current directory "." > is "include/trace/", the relative path of ufs-mediatek-trace.h is > "../../drivers/scsi/ufs/". Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: problem booting 5.10

2020-12-09 Thread Martin K. Petersen
Julia, > 5.10-rc7 plus these three commits boots fine. Great! Thanks for confirming. -- Martin K. Petersen Oracle Linux Engineering

Re: [dm-devel] [RFC PATCH v2 1/2] block: add simple copy support

2020-12-08 Thread Martin K. Petersen
oblem (if at all)... -- Martin K. Petersen Oracle Linux Engineering

Re: [RFC PATCH v2 0/2] add simple copy support

2020-12-08 Thread Martin K. Petersen
uation was hard to resolve. The QoS guarantee was somewhat addressed by Fred in T10. But I agree we need some sort of toggle. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v1 0/2] scsi: ufs: Allow regulators being always on

2020-12-08 Thread Martin K. Petersen
Stanley, > This series allow vendors to keep the regulator always-on, and provide > an implementation on MediaTek UFS platforms. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/4] scsi: ufs-pci: Fixes for Intel controllers

2020-12-08 Thread Martin K. Petersen
very from hibernate exit errors for Intel > controllers > scsi: ufs-pci: Enable UFSHCD_CAP_RPM_AUTOSUSPEND for Intel controllers Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] scsi: ufs: clear uac for RPMB after ufshcd resets

2020-12-08 Thread Martin K. Petersen
Jaegeuk, > If RPMB is not provisioned, we may see RPMB failure after UFS suspend/resume. > Inject request_sense to clear uac in ufshcd reset flow. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/2] two UFS changes

2020-12-08 Thread Martin K. Petersen
Bean, > Bean Huo (2): > scsi: ufs: Remove an unused macro definition POWER_DESC_MAX_SIZE > scsi: ufs: Fix wrong print message in dev_err() Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: problem booting 5.10

2020-12-08 Thread Martin K. Petersen
Linus, > I'll take this as an "ack" for the revert, though ;) Indeed! -- Martin K. Petersen Oracle Linux Engineering

Re: problem booting 5.10

2020-12-08 Thread Martin K. Petersen
Jens, > Thanks for testing! Linus, do you just want to revert this, or do you > want me to queue it up? Oh, I just realized the megaraid patch went in through block. -- Martin K. Petersen Oracle Linux Engineering

Re: problem booting 5.10

2020-12-08 Thread Martin K. Petersen
Julia, > This solves the problem. Starting from 5.10-rc7 and doing this revert, I > get a kernel that boots. Thanks for testing! I'll go ahead and revert 103fbf8e4020 in 5.10/scsi-fixes. We can revisit this change in 5.11 when Ming's fixes are in place. -- Martin K. Petersen

Re: problem booting 5.10

2020-12-08 Thread Martin K. Petersen
l take a look this afternoon. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: hisi_sas: Select a suitable queue for internal IOs

2020-12-07 Thread Martin K. Petersen
https://git.kernel.org/mkp/scsi/c/359db63378ed -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH][next] scsi: pm8001: remove space in a debug message

2020-12-07 Thread Martin K. Petersen
54e28a -- Martin K. Petersen Oracle Linux Engineering

Re: (subset) [PATCH 000/141] Fix fall-through warnings for Clang

2020-12-07 Thread Martin K. Petersen
eak/goto/return/fallthrough statements instead of just > letting the code fall through to the next case. > > [...] Applied to 5.11/scsi-queue, thanks! [054/141] target: Fix fall-through warnings for Clang https://git.kernel.org/mkp/scsi/c/492096ecfa39 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/1] scsi: ufs: Remove scale down gear hard code

2020-12-07 Thread Martin K. Petersen
92a216 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: qla4xxx: remove redundant assignment to variable rval

2020-12-07 Thread Martin K. Petersen
Colin, > The variable rval is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] scsi: qla2xxx: remove trailing semicolon in macro definition

2020-12-07 Thread Martin K. Petersen
Tom, > The macro use will already have a semicolon. Remove unneeded escaped > newline. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: fnic: fix error return code in fnic_probe()

2020-12-07 Thread Martin K. Petersen
Zhang, > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ufshcd: fix Wsometimes-uninitialized warning

2020-12-07 Thread Martin K. Petersen
BUG_ON(1); > ^ Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3] scsi: NCR5380: Remove context check

2020-12-07 Thread Martin K. Petersen
Ahmed, > NCR5380_poll_politely2() uses in_interrupt() and irqs_disabled() to > check if it is safe to sleep. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3] scsi: ufs: Remove pre-defined initial voltage values of device powers

2020-12-07 Thread Martin K. Petersen
Stanley, > UFS specficication allows different VCC configurations for UFS devices, > for example, Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v1 0/4] scsi: ufs: Cleanup phy_initialization vop

2020-12-07 Thread Martin K. Petersen
Stanley, > This series simply cleans up UFS vops and shall not change any > functionality. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v5 0/4] scsi: ufs: Refine error history and introduce event_notify vop

2020-12-07 Thread Martin K. Petersen
Stanley, > This series refines error history functions and introduces a new > event_notify vop to allow vendor to get notification of important > events. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] SCSI: bnx2i: requires MMU

2020-12-03 Thread Martin K. Petersen
is kconfig warning: > > [...] Applied to 5.10/scsi-fixes, thanks! [1/1] SCSI: bnx2i: requires MMU https://git.kernel.org/mkp/scsi/c/2d586494c4a0 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: be2iscsi: revert "Fix a theoretical leak in beiscsi_create_eqs()"

2020-12-03 Thread Martin K. Petersen
gt; does is memset the whole struct to zero which overwrites the assignment. Added Cc: stable and applied to 5.10/scsi-fixes, thanks! [1/1] scsi: be2iscsi: revert "Fix a theoretical leak in beiscsi_create_eqs()" https://git.kernel.org/mkp/scsi/c/eeaf06af6f87 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: storvsc: Fix error return in storvsc_probe()

2020-11-30 Thread Martin K. Petersen
i/c/6112ff4e8f39 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()

2020-11-30 Thread Martin K. Petersen
llback() https://git.kernel.org/mkp/scsi/c/3b8c72d076c4 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-30 Thread Martin K. Petersen
Gustavo, > This series aims to fix almost all remaining fall-through warnings in > order to enable -Wimplicit-fallthrough for Clang. Applied 20-22,54,120-124 to 5.11/scsi-staging, thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] SCSI: bnx2i: requires MMU

2020-11-30 Thread Martin K. Petersen
Randy, > The SCSI_BNX2_ISCSI kconfig symbol selects CNIC and CNIC selects UIO, > which depends on MMU. Since 'select' does not follow dependency > chains, add the same MMU dependency to SCSI_BNX2_ISCSI. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Ora

Re: [PATCH 1/1] scsi: ufs: Remove scale down gear hard code

2020-11-30 Thread Martin K. Petersen
Can, > Instead of making the scale down gear a hard code, make it a member of > ufs_clk_scaling struct. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: fnic: Change shost_printk with FNIC_FCS_DBG

2020-11-30 Thread Martin K. Petersen
s internal version. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: fnic: Change shost_printk() to FNIC_FCS_DBG() https://git.kernel.org/mkp/scsi/c/90b3a938031f -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v4 00/29] scsi: use generic power management

2020-11-30 Thread Martin K. Petersen
/scsi/c/0aea8a8f3a77 [29/29] scsi: pmcraid: Use generic power management https://git.kernel.org/mkp/scsi/c/ac85cca31637 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/2] scsi: pm8001: logging neatening

2020-11-30 Thread Martin K. Petersen
f pm8001_ha in pm8001_printk() explicit https://git.kernel.org/mkp/scsi/c/89eddb401080 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: fnic: Change shost_printk to FNIC_MAIN_DBG

2020-11-30 Thread Martin K. Petersen
_MAIN_DBG() https://git.kernel.org/mkp/scsi/c/875d4eda3bd6 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi/atari_scsi: Fix race condition between .queuecommand and EH

2020-11-30 Thread Martin K. Petersen
tween .queuecommand and EH https://git.kernel.org/mkp/scsi/c/03fe6a640a05 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: pm8001: remove casting kcalloc

2020-11-30 Thread Martin K. Petersen
On Fri, 20 Nov 2020 08:36:48 +, Xu Wang wrote: > Remove casting the values returned by kcalloc. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: pm8001: Remove typecast for pointer returned by kcalloc() https://git.kernel.org/mkp/scsi/c/27a34943bd89 -- Martin K. Petersen Ora

Re: [PATCH] scsi: fnic: set scsi_set_resid only for underflow

2020-11-30 Thread Martin K. Petersen
6a6805 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: fnic: Validate io_req before others

2020-11-30 Thread Martin K. Petersen
kp/scsi/c/3256b4682386 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ufs: Adjust logic in common ADAPT helper

2020-11-30 Thread Martin K. Petersen
DAPT > gear_tx != UFS_HS_G4 => PA_NO_ADAPT > > [...] Applied to 5.11/scsi-queue, thanks! [1/1] scsi: ufs: Adjust logic in common ADAPT helper https://git.kernel.org/mkp/scsi/c/66df79ccbc2f -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi/NCR5380: Reduce NCR5380_maybe_release_dma_irq() call sites

2020-11-30 Thread Martin K. Petersen
) call sites https://git.kernel.org/mkp/scsi/c/bdd1cc0377d3 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: fnic: Avoid looping in TRANS ETH on unload

2020-11-30 Thread Martin K. Petersen
void looping in TRANS ETH on unload https://git.kernel.org/mkp/scsi/c/f9e2beb990f0 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ufs: Remove unnecessary if condition in ufshcd_suspend()

2020-11-30 Thread Martin K. Petersen
Bean, > In the case that auto_bkops_enable is false, which means auto bkops > has been disabled, so no need to call ufshcd_disable_auto_bkops(). Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 0/3] hisi_sas: A small bunch of misc patches

2020-11-30 Thread Martin K. Petersen
staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH][next] scsi: pm8001: remove space in a debug message

2020-11-30 Thread Martin K. Petersen
Colin, > There are two words that need separating with a space in a > pm8001_dbg message. Fix it. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/2] scsi: pm8001: Further neatening and whitespace

2020-11-30 Thread Martin K. Petersen
Joe, > Make the logging macro uses clearer and fix a whitespace defect. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ufs: Adjust logic in common ADAPT helper

2020-11-23 Thread Martin K. Petersen
Bjorn, > The introduction of ufshcd_dme_configure_adapt() refactored out > duplication from the Mediatek and Qualcomm drivers. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH][next] scsi: lpfc: Fix memory leak on lcb_context

2020-11-23 Thread Martin K. Petersen
r exit error path that also kfree's the same > object, allowing a line of code to be removed. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: lpfc: Fix memory leak on lcb_context https://git.kernel.org/mkp/scsi/c/14c1dd950411 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 0/6] ibmvfc: Protocol definition updates and new targetWWPN Support

2020-11-23 Thread Martin K. Petersen
kp/scsi/c/5a9d16f71c26 [5/6] scsi: ibmvfc: Add support for target_wwpn field in v2 MADs and vfcFrame https://git.kernel.org/mkp/scsi/c/ebc7c74bd2dc [6/6] scsi: ibmvfc: Advertise client support for targetWWPN using v2 commands https://git.kernel.org/mkp/scsi/c/e4af87b7079e -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/3] ibmvfc: byte swap login_buf.resp values in attribute show functions

2020-11-23 Thread Martin K. Petersen
emove trailing semicolon https://git.kernel.org/mkp/scsi/c/4e0716199ab6 [3/3] scsi: ibmvfc: Use correlation token to tag commands https://git.kernel.org/mkp/scsi/c/2aa0102c6688 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v5 0/5] scsi: ufs: add some fixes

2020-11-23 Thread Martin K. Petersen
csi: ufs: Fix clkgating on/off https://git.kernel.org/mkp/scsi/c/8eb456be75af [7/7] scsi: ufs: Show LBA and length for UNMAP commands https://git.kernel.org/mkp/scsi/c/3754cde8df91 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH][next] scsi: lpfc: remove dead code on second !ndlp check

2020-11-23 Thread Martin K. Petersen
an never can be reached because the previous check > exited via issue_ct_rsp_exit. This is deadcode and can be removed. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: lpfc: Remove dead code on second !ndlp check https://git.kernel.org/mkp/scsi/c/61795a5316ad -- Martin K. Petersen

Re: [PATCH][next] scsi: lpfc: fix pointer defereference before it is null checked issue

2020-11-23 Thread Martin K. Petersen
cmd has been null checked. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: lpfc: Fix pointer defereference before it is null checked issue https://git.kernel.org/mkp/scsi/c/1e7dddb2e76a -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: fnic: Change shost_printk with FNIC_FCS_DBG

2020-11-23 Thread Martin K. Petersen
Karan, > Replacing shost_printk with FNIC_FCS_DBG so that these log messages > are controlled by fnic_log_level flag in fnic_fip_handler_timer. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: fnic: Validate io_req before others

2020-11-23 Thread Martin K. Petersen
Karan, > We need to check for a valid io_req before we check other data. Also, > removing redundant checks. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: fnic: set scsi_set_resid only for underflow

2020-11-23 Thread Martin K. Petersen
Karan, > Fix to set scsi_set_resid() only if FCPIO_ICMND_CMPL_RESID_UNDER is > set. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: fnic: Avoid looping in TRANS ETH on unload

2020-11-23 Thread Martin K. Petersen
Karan, > This change is to avoid looping in fnic_scsi_abort_io before sending > fw reset when fnic is in TRANS ETH state and when we have not received > any link events. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: fnic: Change shost_printk to FNIC_MAIN_DBG

2020-11-23 Thread Martin K. Petersen
Karan, > Replacing shost_printk with FNIC_MAIN_DBG so that these log messages > are controlled by fnic_log_level flag in fnic_handle_link. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/2] scsi: pm8001: logging neatening

2020-11-23 Thread Martin K. Petersen
Joe, > Reduce code duplication and generic neatening of logging macros Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi/NCR5380: Reduce NCR5380_maybe_release_dma_irq() call sites

2020-11-23 Thread Martin K. Petersen
Finn, > Refactor to avoid needless calls to NCR5380_maybe_release_dma_irq(). > This makes the machine code smaller and the source more readable. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi/atari_scsi: Fix race condition between .queuecommand and EH

2020-11-23 Thread Martin K. Petersen
gain. This will result in a lost > DMA interrupt and a command timeout. Fix this by excluding EH and > interrupt handlers while the new command is enqueued. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: pm8001: remove casting kcalloc

2020-11-23 Thread Martin K. Petersen
Xu, > Remove casting the values returned by kcalloc. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/1] scsi: pm8001: pm8001_hwi: Remove unused variable 'value'

2020-11-19 Thread Martin K. Petersen
riable ‘value’ set but > not used [-Wunused-but-set-variable] Applied to 5.11/scsi-queue, thanks! [1/1] scsi: pm8001: Remove unused variable 'value' https://git.kernel.org/mkp/scsi/c/a364a3ea32da -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH -next] scsi: be2iscsi: Mark beiscsi_attrs with static keyword

2020-11-19 Thread Martin K. Petersen
https://git.kernel.org/mkp/scsi/c/4ab2990a5ce1 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v1 0/9] scsi: ufs: Refactoring and cleanups

2020-11-19 Thread Martin K. Petersen
9/9] scsi: ufs: ufs-qcom: Use common ADAPT configuration function https://git.kernel.org/mkp/scsi/c/d9fa1e731e24 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ufs: Add retry flow for failed hba enabling

2020-11-19 Thread Martin K. Petersen
ant function "ufshcd_vops_hce_enable_notify()". Applied to 5.11/scsi-queue, thanks! [1/1] scsi: ufs: Add retry flow for failed HBA enabling https://git.kernel.org/mkp/scsi/c/6081b12ceb7d -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: qla4xxx: Remove redundant assignment to variable rval

2020-11-19 Thread Martin K. Petersen
https://git.kernel.org/mkp/scsi/c/cf4d4d8ebdb8 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: core: fix -Wformat

2020-11-19 Thread Martin K. Petersen
_rd_attr(can_queue, "%hd\n"); > ^ > %d Applied to 5.11/scsi-queue, thanks! [1/1] scsi: core: Fix -Wformat for scsi_host https://git.kernel.org/mkp/scsi/c/883928201b00 -- Martin K. Petersen Oracle Linux Engineering

<    1   2   3   4   5   6   7   8   9   10   >