Re: [PATCH 4/6] ARM: tegra: Add soctherm and thermal zones to Tegra124 device tree

2014-07-21 Thread Matthew Longnecker
On 6/27/2014 1:11 AM, Mikko Perttunen wrote: This adds the soctherm thermal sensing and management unit to the Tegra124 device tree along with the four thermal zones it exports. Mikko, soctherm doesn't "export thermal zones". I would rewrite your desription like this: Extend the Tegra124 d

Re: [PATCH 4/6] ARM: tegra: Add soctherm and thermal zones to Tegra124 device tree

2014-07-21 Thread Matthew Longnecker
On 6/27/2014 1:11 AM, Mikko Perttunen wrote: This adds the soctherm thermal sensing and management unit to the Tegra124 device tree along with the four thermal zones it exports. Mikko, soctherm doesn't "export thermal zones". I would rewrite your desription like this: Extend the Tegra124 d

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2014-01-02 Thread Matthew Longnecker
Eduardo, For the most part, this binding is really well thought out. It makes a lot of sense to me (as someone who has been working with thermal management in Linux/Android-based mobile devices for a few years). However, I have one substantive criticism. On 11/12/2013 11:46 AM, Eduardo Valen

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2014-01-02 Thread Matthew Longnecker
I think the platform driver may set governor for the thermal zone, so how about to add a property named as "governor", and parse it to tzp->governor_name, something like: ret = of_property_read_string(child, "governor", &str); if (ret == 0)