[PATCH V6 0/2] powerpc/dlpar: Correct display of hot-add/hot-remove CPUs and memory

2017-06-20 Thread Michael Bringmann
Processor Home Node (VPHN) capabilities information provided by the pHyp. The VPHN handling in Linux is disabled, if PRRN handling is present. Signed-off-by: Michael Bringmann Michael Bringmann (2): powerpc/hotplug: Add option to define max nodes allowing dynamic growth of resources. powe

[PATCH V6 1/2] powerpc/hotplug: Ensure enough nodes avail for operations

2017-06-20 Thread Michael Bringmann
will read this value and use it to ensure that all of the desired nodes are setup in the 'node_possible_map', and elsewhere. Signed-off-by: Michael Bringmann --- --- arch/powerpc/mm/numa.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/arch/powe

[PATCH V6 2/2] powerpc/numa: Update CPU topology when VPHN enabled

2017-06-20 Thread Michael Bringmann
information provided by the pHyp. Also, update initialization checks for device-tree attributes to independently recognize PRRN or VPHN usage. Signed-off-by: Michael Bringmann --- Changes in V6: -- Place extern of timed_topology_update() proto under additional #ifdef for hotplug-cpu. --- arch

Re: [PATCH V6 0/2] powerpc/dlpar: Correct display of hot-add/hot-remove CPUs and memory

2017-06-21 Thread Michael Bringmann
One of the patches was doubled and sent twice yesterday. Will update number regardless in future. On 06/21/2017 04:54 AM, Michael Ellerman wrote: > Michael Bringmann writes: > >> On Power systems with shared configurations of CPUs and memory, there >> are some issues w

Re: [PATCH V6 1/2] powerpc/hotplug: Ensure enough nodes avail for operations

2017-06-21 Thread Michael Bringmann
On 06/21/2017 04:52 AM, Michael Ellerman wrote: > Michael Bringmann writes: > >> powerpc/hotplug: On systems like PowerPC which allow 'hot-add' of CPU >> or memory resources, it may occur that the new resources are to be >> inserted into nodes that were not

Re: [PATCH 2/2] powerpc/hotplug: Ensure nodes initialized for hotplug

2017-10-17 Thread Michael Bringmann
On 10/16/2017 07:54 AM, Michael Ellerman wrote: > Michael Bringmann writes: > >> powerpc/hotplug: On systems like PowerPC which allow 'hot-add' of CPU, >> it may occur that the new resources are to be inserted into nodes >> that were not used for memory re

Re: [PATCH 1/2] powerpc/nodes: Ensure enough nodes avail for operations

2017-10-17 Thread Michael Bringmann
See below. On 10/16/2017 07:33 AM, Michael Ellerman wrote: > Michael Bringmann writes: > >> powerpc/nodes: On systems like PowerPC which allow 'hot-add' of CPU > > This is a powerpc-only patch, so saying "systems like PowerPC" is > confusing. What yo

Re: [PATCH 1/2] powerpc/nodes: Ensure enough nodes avail for operations

2017-10-17 Thread Michael Bringmann
On 10/17/2017 12:02 PM, Nathan Fontenot wrote: > On 10/17/2017 11:14 AM, Michael Bringmann wrote: >> See below. >> >> On 10/16/2017 07:33 AM, Michael Ellerman wrote: >>> Michael Bringmann writes: >>> >>>> powerpc/nodes: On systems like Pow

Re: [PATCH V2 2/2]: powerpc/hotplug/mm: Fix hot-add memory node assoc

2017-05-26 Thread Michael Bringmann
>> arch/powerpc/mm/numa.c |7 --- >> 1 file changed, 7 deletions(-) >> >> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c >> index 15c2dd5..18f3038 100644 >> --- a/arch/powerpc/mm/numa.c >> +++ b/arch/powerpc/mm/numa.c >> @@ -907,13 +907,6 @@ void __init initmem_init(void) >>

Re: [Patch 2/2]: powerpc/hotplug/mm: Fix hot-add memory node assoc

2017-05-26 Thread Michael Bringmann
I am running into this problem on PowerPC systems where Balbir's patch set was targeted. So, yes, I do need to be able to add/enable a new numa node during system execution in cases where more resources (memory, virtual processors) are added to the system dynamically. On 05/25/2017 10:46 PM, Mich

[PATCH V3 1/2] powerpc/numa: Update CPU topology when VPHN enabled

2017-05-26 Thread Michael Bringmann
information provided by the pHyp. The VPHN handling in Linux is disabled, if PRRN handling is present. Signed-off-by: Michael Bringmann --- Changes in V3: -- Remove change unrelated to this patch --- arch/powerpc/mm/numa.c | 19 ++- arch/powerpc/platforms/pseries/dlpar.c

[PATCH V3 2/2] powerpc/hotplug/mm: Fix hot-add memory node assoc

2017-05-26 Thread Michael Bringmann
to subsequent DLPAR hotplug-memory operations, even if they are not needed at boot time. Signed-off-by: Michael Bringmann --- Changes in V3: -- Remove code not relevant to this defect. --- arch/powerpc/mm/numa.c |7 --- 1 file changed, 7 deletions(-) diff --git a/arch/powerpc/mm

[PATCH V4 2/2] powerpc/hotplug/mm: Fix hot-add memory node assoc

2017-05-26 Thread Michael Bringmann
to subsequent DLPAR hotplug-memory operations, even if they are not needed at boot time. Signed-off-by: Michael Bringmann --- --- arch/powerpc/mm/numa.c |7 --- 1 file changed, 7 deletions(-) diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index afcee3f..49d5222 100644

[PATCH V4 1/2] powerpc/numa: Update CPU topology when VPHN enabled

2017-05-26 Thread Michael Bringmann
information provided by the pHyp. The VPHN handling in Linux is disabled, if PRRN handling is present. Signed-off-by: Michael Bringmann --- Changes in V4: -- Fix conditional compile bug. --- arch/powerpc/mm/numa.c | 19 ++- arch/powerpc/platforms/pseries/dlpar.c |2

[PATCH V6 0/2] pseries/nodes: Fix issues with memoryless nodes

2017-11-01 Thread Michael Bringmann
pseries/nodes: Ensure enough nodes avail for operations pseries/initnodes: Ensure nodes initialized for hotplug Signed-off-by: Michael Bringmann Michael Bringmann (2): pseries/nodes: Ensure enough nodes avail for operations pseries/initnodes: Ensure nodes initialized for hotplug

[PATCH V6 2/2] pseries/initnodes: Ensure nodes initialized for hotplug

2017-11-01 Thread Michael Bringmann
ent. This patch fixes some problems encountered at runtime with configurations that support memory-less nodes, or that hot-add CPUs into nodes that are memoryless during system execution after boot. Signed-off-by: Michael Bringmann --- Changes in V6: -- Add some needed node initialization to ru

[PATCH V6 1/2] pseries/nodes: Ensure enough nodes avail for operations

2017-11-01 Thread Michael Bringmann
will be performed to define or enable additional nodes. Signed-off-by: Michael Bringmann --- Changes in V6: -- Remove some node initialization/allocation from boot setup --- arch/powerpc/mm/numa.c | 40 +--- 1 file changed, 37 insertions(+), 3 deletions(-

[PATCH 0/3] powerpc/hotplug: Fix affinity assoc for LPAR migration

2017-11-02 Thread Michael Bringmann
layers to reset the associativity of the blocks and any other related data structures. Signed-off-by: Michael Bringmann Michael Bringmann (3): powerpc/hotplug/memory: Apply assoc mem updates from 'ibm,dynamic-memory' Post LPAR Migration powerpc/hotplug/memory: Apply assoc lookup arr

[PATCH 1/3] hotplug/memory: Apply assoc mem updates Post Migration Topo

2017-11-02 Thread Michael Bringmann
ology migration requires us to compare the aa_index values of the old/new properties and 'readd' any block for which the setting has changed. Signed-off-by: Michael Bringmann --- arch/powerpc/platforms/pseries/hotplug-cpu.c| 64 +++ arch/powerpc/platforms/pserie

[PATCH 3/3] postmigration/memory: Associativity & ibm,dynamic-memory-v2

2017-11-02 Thread Michael Bringmann
ology migration requires us to compare the 'aa_index' values of the old/new properties and 'readd' any block for which the setting has changed. Signed-off-by: Michael Bringmann --- arch/powerpc/include/asm/prom.h | 12 ++ arch/powerpc/platfo

[PATCH 2/3] postmigration/memory: Review assoc lookup array changes

2017-11-02 Thread Michael Bringmann
structures. In the process of the 're-add', the appropriate entry of the property 'ibm,dynamic-memory' would be updated as well as any other applicable system data structures. Signed-off-by: Michael Bringmann --- arch/powerpc/platforms/pseries/hotplug-memory.c | 123 +++

[PATCH V4 0/2] pseries/nodes: Fix issues with memoryless nodes

2017-10-24 Thread Michael Bringmann
From: Michael Bringmann To: linuxppc-...@lists.ozlabs.org To: linux-kernel@vger.kernel.org Cc: Michael Bringmann Cc: Nathan Fontenot Cc: Michael Ellerman Cc: John Allen Subject: [PATCH V4 0/2] pseries/nodes: Fix issues with memoryless nodes pseries/nodes: Ensure enough nodes avail for

[PATCH V5 0/2] pseries/nodes: Fix issues with memoryless nodes

2017-10-26 Thread Michael Bringmann
pseries/nodes: Ensure enough nodes avail for operations pseries/initnodes: Ensure nodes initialized for hotplug Signed-off-by: Michael Bringmann Michael Bringmann (2): pseries/nodes: Ensure enough nodes avail for operations pseries/initnodes: Ensure nodes initialized for hotplug

[PATCH V5 1/2] pseries/nodes: Ensure enough nodes avail for operations

2017-10-26 Thread Michael Bringmann
will be performed to define or enable additional nodes. Signed-off-by: Michael Bringmann --- Changes in V5: -- Remove unnecessary error check --- arch/powerpc/mm/numa.c | 38 +++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/mm/numa

[PATCH V5 2/2] pseries/initnodes: Ensure nodes initialized for hotplug

2017-10-26 Thread Michael Bringmann
ent. This patch fixes some problems encountered at runtime with configurations that support memory-less nodes, or that hot-add resources during system execution after boot. Signed-off-by: Michael Bringmann --- Changes in V5: -- Reorganize code used to associatively map CPUs to nodes and

[PATCH V2 0/3] pseries/nodes: Fix issues with memoryless nodes

2017-10-18 Thread Michael Bringmann
pseries/nodes: Ensure enough nodes avail for operations pseries/findnodes: Find nodes with memory when booting memoryless nodes pseries/initnodes: Ensure nodes initialized for hotplug Signed-off-by: Michael Bringmann Michael Bringmann (3): pseries/nodes: Ensure enough nodes avail for

[PATCH V2 2/3] pseries/findnodes: Find nodes with memory for memoryless nodes

2017-10-18 Thread Michael Bringmann
pology.h' to modules that are allocating node-specific memory at boot, and allows such references to find available memory in another node. Signed-off-by: Michael Bringmann --- block/blk-mq-cpumap.c |3 ++- mm/page_alloc.c |1 + 2 files changed, 3 insertions(+), 1 deletion

[PATCH V2 1/3] pseries/nodes: Ensure enough nodes avail for operations

2017-10-18 Thread Michael Bringmann
will be performed to define or enable additional nodes. Signed-off-by: Michael Bringmann --- arch/powerpc/mm/numa.c | 39 --- 1 file changed, 36 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index ec098b3..f885a

[PATCH V2 3/3] pseries/initnodes: Ensure nodes initialized for hotplug

2017-10-18 Thread Michael Bringmann
ent. This patch fixes some problems encountered at runtime with configurations that support memory-less nodes, or that hot-add resources during system execution after boot. Signed-off-by: Michael Bringmann --- arch/powerpc/mm/numa.c | 27 --- 1 file changed, 24 insert

[RFC 0/6] powerpc/pseries: Refactor code to centralize drcinfo parsing

2018-12-14 Thread Michael Bringmann
-domains, and the compressed ibm,drc-info into the platform-specific code for the Pseries features. Signed-off-by: Michael W. Bringmann Michael Bringmann (6): powerpc:/drc Define interface to acquire arch-specific drc info pseries/drcinfo: Fix bug parsing ibm,drc-info pseries/drcinfo: Pseries

[RFC 1/6] powerpc:/drc Define interface to acquire arch-specific drc info

2018-12-14 Thread Michael Bringmann
: Michael Bringmann --- include/linux/topology.h |9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/topology.h b/include/linux/topology.h index cb0775e..df97f5f 100644 --- a/include/linux/topology.h +++ b/include/linux/topology.h @@ -44,6 +44,15 @@ int

[RFC 2/6] pseries/drcinfo: Fix bug parsing ibm,drc-info

2018-12-14 Thread Michael Bringmann
Replace use of of_prop_next_u32() in when parsing 'ibm,drc-info' structure to simplify and reduce parsing code. Signed-off-by: Michael Bringmann Fixes: 3f38000eda48 ("powerpc/firmware: Add definitions for new drc-info firmware feature" -- end of patch series applied to pow

[RFC 5/6] powerpc/pci/hotplug: Use common drcinfo parsing

2018-12-14 Thread Michael Bringmann
arch_find_drc_match. All functions that were used just to support the previous parsing implementation have been moved. Signed-off-by: Michael Bringmann --- drivers/pci/hotplug/rpaphp_core.c | 232 - 1 file changed, 28 insertions(+), 204 deletions(-) diff --git a

[RFC 4/6] powerpc/pseries: Use common drcinfo parsing

2018-12-14 Thread Michael Bringmann
pseries_energy.c and hotplug-cpu.c to use the common parser. Changes include creating appropriate callback functions and passing callback-specific data blocks into arch_find_drc_match. Signed-off-by: Michael Bringmann --- arch/powerpc/platforms/pseries/hotplug-cpu.c| 83 +++- arch

[RFC 3/6] pseries/drcinfo: Pseries impl of arch_find_drc_info

2018-12-14 Thread Michael Bringmann
: Michael Bringmann --- arch/powerpc/include/asm/prom.h |3 arch/powerpc/platforms/pseries/of_helpers.c | 299 +++ include/linux/topology.h|2 3 files changed, 298 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/include/asm

Re: [PATCH 2/2] of: __of_detach_node() - remove node from phandle cache

2018-12-14 Thread Michael Bringmann
; will incorrectly find the stale entry. Remove the node from the >> cache. >> >> Add paranoia checks in of_find_node_by_phandle() as a second level >> of defense (do not return cached node if detached, do not add node >> to cache if detached). >> >> Reported-by

Re: [PATCH v03] powerpc/mobility: Fix node detach/rename problem

2018-12-14 Thread Michael Bringmann
On 12/12/2018 08:57 PM, Michael Ellerman wrote: > Frank Rowand writes: >> On 12/11/18 8:07 AM, Rob Herring wrote: >>> On Tue, Dec 11, 2018 at 7:29 AM Michael Ellerman >>> wrote: > ... diff --git a/drivers/of/base.c b/drivers/of/base.c index 09692c9b32a7..d8e4534c0686 100644 --- a/

Re: [PATCH] pseries/hotplug: Add more delay in pseries_cpu_die while waiting for rtas-stop

2018-12-10 Thread Michael Bringmann
I have asked Scott Mayes to take a look at one of these crashes from the phyp side. I will let you know if he finds anything notable. Michael On 12/07/2018 08:40 PM, Thiago Jung Bauermann wrote: > > Gautham R Shenoy writes: >> On Fri, Dec 07, 2018 at 04:13:11PM +0530, Gautham R Shenoy wrote: >

Re: [PATCH v03] powerpc/mobility: Fix node detach/rename problem

2018-12-11 Thread Michael Bringmann
frowand.l...@gmail.com > devicet...@vger.kernel.org > linux-kernel@vger.kernel.org Thanks. > > Michael Bringmann writes: >> The PPC mobility code receives RTAS requests to delete nodes with >> platform-/hardware-specific attributes when restarting the kernel >> aft

Re: [PATCH v03] powerpc/mobility: Fix node detach/rename problem

2018-12-11 Thread Michael Bringmann
--- Snip --- >> >> The mobility.c code continues on during the second migration, accepts >> the definitions of the new nodes from the PHYP and ends up renaming >> the new properties e.g. >> >> [ 4565.827296] Duplicate name in base, renamed to "ibm,platform-facilities#1" >> >> There is no check lik

[RFC 0/3] powerpc/pseries: Remap hw to kernel cpu indexes

2018-12-11 Thread Michael Bringmann
associativity changes during the lifetime of a system. These interfaces exchange the thread_index provided by the 'ibm,ppc-interrupt-server#s' properties, for an internal index to be used by kernel scheduling interfaces. Signed-off-by: Michael Bringmann Michael Bringmann (3): po

[RFC 2/3] powerpc/numa: Define mapping between HW and kernel cpus

2018-12-11 Thread Michael Bringmann
during the lifetime of a system. These interfaces will be used entirely within the powerpc kernel code to maintain separation between the machine and kernel contexts. Signed-off-by: Michael Bringmann --- arch/powerpc/include/asm/topology.h | 31 +++ arch/powerpc/platforms/pseries

[RFC 3/3] powerpc/numa: Apply mapping between HW and kernel cpus

2018-12-11 Thread Michael Bringmann
changes during the lifetime of a system. These interfaces exchange the thread_index provided by the 'ibm,ppc-interrupt-server#s' properties, for an internal index to be used by kernel scheduling interfaces. Signed-off-by: Michael Bringmann --- arch/powerpc/mm/numa.c

[RFC 1/3] powerpc/numa: Conditionally online new nodes

2018-12-11 Thread Michael Bringmann
Add argument to allow caller to determine whether the node identified for a cpu after an associativity / affinity change should be inited. Signed-off-by: Michael Bringmann --- arch/powerpc/include/asm/topology.h |2 +- arch/powerpc/mm/numa.c |6

Re: [PATCH] pseries/hotplug: Add more delay in pseries_cpu_die while waiting for rtas-stop

2018-12-11 Thread Michael Bringmann
code from PHYP's H_SET_DR_STATE h-call. On 12/10/2018 02:31 PM, Thiago Jung Bauermann wrote: > > Hello Michael, > > Michael Bringmann writes: > >> I have asked Scott Mayes to take a look at one of these crashes from >> the phyp side. I will let you know if he fin

[PATCH v03] powerpc/numa: Perform full re-add of CPU for PRRN/VPHN topology update

2019-02-06 Thread Michael Bringmann
2018 ] [Replace patch submission: Subject: [PATCH] powerpc/topology: Update numa mask when cpu node mapping changes From: Srikar Dronamraju Date: Wed Oct 10 15:24:46 AEDT 2018 ] Signed-off-by: Michael Bringmann --- Changes in v03: -- Fixed under-scheduling of topo updates. Changes in v02: -- Reuse mo

Re: [RFC 1/6] powerpc:/drc Define interface to acquire arch-specific drc info

2019-01-25 Thread Michael Bringmann
Adding Nathan Lynch On 1/24/19 6:04 PM, Tyrel Datwyler wrote: > On 12/14/2018 12:50 PM, Michael Bringmann wrote: >> Define interface to acquire arch-specific drc info to match against >> hotpluggable devices. The current implementation exposes several >> pseries-sp

Re: [RFC 3/6] pseries/drcinfo: Pseries impl of arch_find_drc_info

2019-01-25 Thread Michael Bringmann
Adding Nathan Lynch. Yes. We can amend the title. On 1/24/19 6:04 PM, Tyrel Datwyler wrote: > On 12/14/2018 12:51 PM, Michael Bringmann wrote: >> This patch provides a common interface to parse ibm,drc-indexes, >> ibm,drc-names, ibm,drc-types, ibm,drc-power-domains, or ibm,d

Re: [RFC 1/6] powerpc:/drc Define interface to acquire arch-specific drc info

2019-01-25 Thread Michael Bringmann
Adding Nathan Lynch. On 1/24/19 6:10 PM, Tyrel Datwyler wrote: > On 12/14/2018 12:50 PM, Michael Bringmann wrote: >> Define interface to acquire arch-specific drc info to match against >> hotpluggable devices. The current implementation exposes several >> pseries-sp

Re: [RFC 5/6] powerpc/pci/hotplug: Use common drcinfo parsing

2019-01-25 Thread Michael Bringmann
Adding Nathan Lynch. On 1/24/19 6:29 PM, Tyrel Datwyler wrote: > On 01/14/2019 04:28 PM, Bjorn Helgaas wrote: >> On Fri, Dec 14, 2018 at 02:51:31PM -0600, Michael Bringmann wrote: >>> The implementation of the pseries-specific drc info properties >>> is currently impl

Re: [RFC 1/6] powerpc:/drc Define interface to acquire arch-specific drc info

2019-01-28 Thread Michael Bringmann
On 1/25/19 10:09 AM, Michael Bringmann wrote: > Adding Nathan Lynch > > On 1/24/19 6:04 PM, Tyrel Datwyler wrote: >> On 12/14/2018 12:50 PM, Michael Bringmann wrote: >>> Define interface to acquire arch-specific drc info to match against >>> hotpluggable dev

[PATCH v04] powerpc/numa: Perform full re-add of CPU for PRRN/VPHN topology update

2019-02-14 Thread Michael Bringmann
To: linuxppc-...@lists.ozlabs.org To: linux-kernel@vger.kernel.org Benjamin Herrenschmidt Paul Mackerras Michael Ellerman Nathan Lynch Corentin Labbe Tyrel Datwyler Srikar Dronamraju Guenter Roeck Michael Bringmann "Oliver O'Halloran" Russell Currey Haren Myneni Al

[PATCH] powerpc/pseries: Fix dn reference error in dlpar_cpu_remove_by_index

2019-02-19 Thread Michael Bringmann
count will still be decremented. Signed-off-by: Michael Bringmann diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c index 97feb6e..9537bb9 100644 --- a/arch/powerpc/platforms/pseries/hotplug-cpu.c +++ b/arch/powerpc/platforms/pseries/hot

Re: [PATCH] powerpc/pseries: Fix dn reference error in dlpar_cpu_remove_by_index

2019-02-20 Thread Michael Bringmann
On 2/19/19 2:03 PM, Tyrel Datwyler wrote: > On 02/19/2019 07:46 AM, Michael Bringmann wrote: >> powerpc/pseries: Fix dn reference error in dlpar_cpu_remove_by_index() >> >> A reference to the device node of the CPU to be removed is released >> upon successful removal o

Re: [RFC 1/6] powerpc:/drc Define interface to acquire arch-specific drc info

2019-01-29 Thread Michael Bringmann
On 1/29/19 3:31 AM, Michael Ellerman wrote: > Tyrel Datwyler writes: >> On 12/14/2018 12:50 PM, Michael Bringmann wrote: >>> Define interface to acquire arch-specific drc info to match against >>> hotpluggable devices. The current implementation exposes several &

Re: [PATCH] pseries/hotplug: Add more delay in pseries_cpu_die while waiting for rtas-stop

2019-01-14 Thread Michael Bringmann
On 1/9/19 12:08 AM, Gautham R Shenoy wrote: > I did some testing during the holidays. Here are the observations: > > 1) With just your patch (without any additional debug patch), if I run > DLPAR on /off operations on a system that has SMT=off, I am able to > see a crash involving RTAS stack corr

REPOST [PATCH v04] powerpc/numa: Perform full re-add of CPU for PRRN/VPHN topology update

2019-03-05 Thread Michael Bringmann
2018 ] [Replace patch submission: Subject: [PATCH] powerpc/topology: Update numa mask when cpu node mapping changes From: Srikar Dronamraju Date: Wed Oct 10 15:24:46 AEDT 2018 ] Signed-off-by: Michael Bringmann --- Changes in v04: -- Revise tests in topology_timer_fn to check vphn_enabled b

Re: [Patch 2/2]: powerpc/hotplug/mm: Fix hot-add memory node assoc

2017-05-23 Thread Michael Bringmann
On 05/23/2017 04:49 PM, Reza Arbab wrote: > On Tue, May 23, 2017 at 03:05:08PM -0500, Michael Bringmann wrote: >> On 05/23/2017 10:52 AM, Reza Arbab wrote: >>> On Tue, May 23, 2017 at 10:15:44AM -0500, Michael Bringmann wrote: >>>> +static void setup_nodes(void) &

Re: [Patch 2/2]: powerpc/hotplug/mm: Fix hot-add memory node assoc

2017-05-23 Thread Michael Bringmann
On 05/23/2017 04:49 PM, Reza Arbab wrote: > On Tue, May 23, 2017 at 03:05:08PM -0500, Michael Bringmann wrote: >> On 05/23/2017 10:52 AM, Reza Arbab wrote: >>> On Tue, May 23, 2017 at 10:15:44AM -0500, Michael Bringmann wrote: >>>> +static void setup_nodes(void) &

Re: [PATCH] workqueue: Ensure that cpumask set for pools created after boot

2017-05-24 Thread Michael Bringmann
On 05/23/2017 03:10 PM, Tejun Heo wrote: > Hello, > > On Tue, May 23, 2017 at 03:09:07PM -0500, Michael Bringmann wrote: >> To confirm, you want the WARN_ON(cpumask_any(pool->attrs->cpumask) >= >> NR_CPUS) >> at the point where I place my current patch? >

Re: [PATCH] workqueue: Ensure that cpumask set for pools created after boot

2017-05-24 Thread Michael Bringmann
On 05/23/2017 03:10 PM, Tejun Heo wrote: > Hello, > > On Tue, May 23, 2017 at 03:09:07PM -0500, Michael Bringmann wrote: >> To confirm, you want the WARN_ON(cpumask_any(pool->attrs->cpumask) >= >> NR_CPUS) >> at the point where I place my current patch? >

Re: [Patch 2/2]: powerpc/hotplug/mm: Fix hot-add memory node assoc

2017-05-24 Thread Michael Bringmann
I will get a log based on the latest 4.12 kernel to show what happens one way or the other, with this patch removed. On 05/24/2017 09:36 AM, Reza Arbab wrote: > On Tue, May 23, 2017 at 05:44:23PM -0500, Michael Bringmann wrote: >> On 05/23/2017 04:49 PM, Reza Arbab wrote: >>> On

Re: [Patch 2/2]: powerpc/hotplug/mm: Fix hot-add memory node assoc

2017-05-24 Thread Michael Bringmann
On 05/24/2017 06:19 AM, Michael Ellerman wrote: > Michael Bringmann writes: > >> On 05/23/2017 04:49 PM, Reza Arbab wrote: >>> On Tue, May 23, 2017 at 03:05:08PM -0500, Michael Bringmann wrote: >>>> On 05/23/2017 10:52 AM, Reza Arbab wrote: >>>&

Re: [Patch 2/2]: powerpc/hotplug/mm: Fix hot-add memory node assoc

2017-05-25 Thread Michael Bringmann
On 05/25/2017 01:19 AM, Michael Ellerman wrote: > Michael Bringmann writes: > >> On 05/24/2017 06:19 AM, Michael Ellerman wrote: >>> Michael Bringmann writes: >>>> >>>> With or without 3af229f2071f, we would still need to add something

[PATCH V2] workqueue: Ensure that cpumask set for pools created after boot

2017-05-25 Thread Michael Bringmann
created, attached, and woken up. If the mask is not set up, then the kernel will crash when 'wakeup_process' is unable to find a valid CPU to which to assign the new worker. Signed-off-by: Michael Bringmann --- Changes in V2: -- Only fill in empty cpumasks. --- kernel/workqueu

Re: [Patch 2/2]: powerpc/hotplug/mm: Fix hot-add memory node assoc

2017-05-25 Thread Michael Bringmann
On 05/25/2017 10:10 AM, Reza Arbab wrote: > On Thu, May 25, 2017 at 04:19:53PM +1000, Michael Ellerman wrote: >> The commit message for 3af229f2071f says: >> >>In practice, we never see a system with 256 NUMA nodes, and in fact, we >>do not support node hotplug on power in the first place

Re: [PATCH] workqueue: Ensure that cpumask set for pools created after boot

2017-05-25 Thread Michael Bringmann
I will try that patch shortly. I also updated my patch to be conditional on whether the pool's cpumask attribute was empty. You should have received V2 of that patch by now. As to your remark about 'proper subset of possible cpumask for the node', would that not be the case when we are removing

[PATCH V2 1/2] powerpc/numa: Update CPU topology when VPHN enabled

2017-05-25 Thread Michael Bringmann
information provided by the pHyp. The VPHN handling in Linux is disabled, if PRRN handling is present. Signed-off-by: Michael Bringmann --- arch/powerpc/mm/numa.c | 19 ++- arch/powerpc/platforms/pseries/dlpar.c |2 ++ arch/powerpc/platforms/pseries/hotplug

[PATCH V2 2/2]: powerpc/hotplug/mm: Fix hot-add memory node assoc

2017-05-25 Thread Michael Bringmann
. Signed-off-by: Michael Bringmann --- Changes in V2: -- Simplify patches to ensure more nodes in possible map, removing code from PowerPC numa.c that constrained possible map to size of online map. --- arch/powerpc/mm/numa.c |7 --- 1 file changed, 7 deletions(-) diff --git a/arch

Re: [PATCH] workqueue: Ensure that cpumask set for pools created after boot

2017-06-28 Thread Michael Bringmann
/2017 03:10 PM, Tejun Heo wrote: > Hello, > > On Tue, Jun 13, 2017 at 03:04:30PM -0500, Michael Bringmann wrote: >> @@ -3564,19 +3564,28 @@ static struct pool_workqueue >> *alloc_unbound_pwq(struct workqueue_struct *wq, >> static bool wq_calc_node_cpumask(const struct

[PATCH V8 0/2] powerpc/dlpar: Correct display of hot-add/hot-remove CPUs and memory

2017-07-11 Thread Michael Bringmann
Processor Home Node (VPHN) capabilities information provided by the pHyp. The VPHN handling in Linux is disabled, if PRRN handling is present. Signed-off-by: Michael Bringmann Michael Bringmann (2): powerpc/hotplug: Add option to define max nodes allowing dynamic growth of resources. powe

[PATCH V8 1/2] powerpc/hotplug: Ensure enough nodes avail for operations

2017-07-11 Thread Michael Bringmann
will read this value and use it to ensure that all of the desired nodes are setup in the 'node_possible_map', and elsewhere. Signed-off-by: Michael Bringmann --- --- arch/powerpc/mm/numa.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/arch/powe

[PATCH V8 2/2] powerpc/numa: Update CPU topology when VPHN enabled

2017-07-11 Thread Michael Bringmann
information provided by the pHyp. Also, update initialization checks for device-tree attributes to independently recognize PRRN or VPHN usage. Signed-off-by: Michael Bringmann --- Changes in V8: -- Fix a conditional compile bug. --- arch/powerpc/include/asm/topology.h | 14 ++ arch

Re: [PATCH V2 2/3] pseries/findnodes: Find nodes with memory for memoryless nodes

2017-11-15 Thread Michael Bringmann
Hi Michael, > > Michael Bringmann writes: >> pseries/findnodes: On pseries systems which allow 'hot-add' of > > This isn't a powerpc or pseries patch, so the subject/prefix is wrong. > > Also because you're changing generic code you need to provide an &g

[PATCH V11 0/3] powerpc/dlpar: Correct display of hot-add/hot-remove CPUs and memory

2017-08-28 Thread Michael Bringmann
the VPHN code from the NUMA code better, and move relevant functions to another file. Signed-off-by: Michael Bringmann Michael Bringmann (3): powerpc/numa: Update CPU topology when VPHN enabled powerpc/nodes: Ensure enough nodes avail for operations powerpc/vphn: Rearrange file contents for im

[PATCH V11 2/3] powerpc/nodes: Ensure enough nodes avail for operations

2017-08-28 Thread Michael Bringmann
he instruction, nodes_and(node_possible_map, node_possible_map, node_online_map); presently seen in the function arch/powerpc/mm/numa.c:initmem_init(). If the property is not present at boot, no operation will be performed to define or enable additional nodes. Signed-off-by: Michael Bringmann --

[PATCH V11 1/3] powerpc/numa: Update CPU topology when VPHN enabled

2017-08-28 Thread Michael Bringmann
information provided by the pHyp. Also, update initialization checks for device-tree attributes to independently recognize PRRN or VPHN usage. Signed-off-by: Michael Bringmann --- Changes in V11: -- Cleanup presentation of patch changes --- arch/powerpc/include/asm/topology.h | 14

[PATCH V11 3/3] powerpc/vphn: Better integrate vphn source code

2017-08-28 Thread Michael Bringmann
powerpc/vphn: Reorganize source code in order to better distinguish the VPHN code from the NUMA code better, by moving relevant functions to appropriate files. Signed-off-by: Michael Bringmann --- arch/powerpc/include/asm/topology.h|6 arch/powerpc/mm/numa.c | 550

[PATCH V10 0/2] powerpc/dlpar: Correct display of hot-add/hot-remove CPUs and memory

2017-08-24 Thread Michael Bringmann
.] This new setting will override the instruction, nodes_and(node_possible_map, node_possible_map, node_online_map); presently seen in the function arch/powerpc/mm/numa.c:initmem_init(). If the property is not present at boot, no operation will be performed to define or enable additional nodes. Si

[PATCH V10 1/2] powerpc/numa: Update CPU topology when VPHN enabled

2017-08-24 Thread Michael Bringmann
information provided by the pHyp. Also, update initialization checks for device-tree attributes to independently recognize PRRN or VPHN usage. Finally, try to distinguish the VPHN code from the NUMA code better, and move relevant functions to another file. Signed-off-by: Michael Bringmann --- Changes in

[PATCH V10 2/2] powerpc/nodes: Ensure enough nodes avail for operations

2017-08-24 Thread Michael Bringmann
From: Michael Bringmann To: linuxppc-...@lists.ozlabs.org To: linux-kernel@vger.kernel.org Cc: Michael Ellerman Cc: Michael Bringmann Cc: John Allen Cc: Nathan Fontenot Subject: [PATCH V10 2/2] powerpc/nodes: Ensure enough nodes avail for operations powerpc/nodes: On systems like PowerPC

[PATCH 0/2] powerpc/nodes/hotplug: Fix problem with memoryless nodes

2017-09-18 Thread Michael Bringmann
bootup. Many different configurations of PowerPC resources may need to be supported depending upon the environment. This patch fixes some problems encountered at runtime with configurations that support memory-less nodes, but which allow CPUs to be added at and after boot. Signed-off-by: Michael

[PATCH 1/2] powerpc/nodes: Ensure enough nodes avail for operations

2017-09-18 Thread Michael Bringmann
fine or enable additional nodes. Signed-off-by: Michael Bringmann --- arch/powerpc/mm/numa.c | 47 +++ 1 file changed, 47 insertions(+) diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index ec098b3..b385cd0 100644 --- a/arch/powerp

[PATCH 2/2] powerpc/hotplug: Ensure nodes initialized for hotplug

2017-09-18 Thread Michael Bringmann
nvironment. This patch fixes some problems encountered at runtime with configurations that support memory-less nodes, but which allow CPUs to be added at and after boot. Signed-off-by: Michael Bringmann --- arch/powerpc/mm/numa.c | 17 +++-- 1 file changed, 15 insertions(+), 2

[PATCH V14 0/4] powerpc/vphn: Update CPU topology when VPHN enabled

2017-09-08 Thread Michael Bringmann
detected and configured sooner. Also, fix an end-of-updates processing problem observed occasionally in numa_update_cpu_topology(). Signed-off-by: Michael Bringmann Michael Bringmann (4): powerpc/vphn: Update CPU topology when VPHN enabled powerpc/vphn: Improve recognition of PRRN/VPHN

[PATCH V14 2/4] powerpc/vphn: Improve recognition of PRRN/VPHN

2017-09-08 Thread Michael Bringmann
: Michael Bringmann --- Changes in V14: -- Code cleanup to reduce patch sizes --- arch/powerpc/mm/numa.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index 3ae031d..5f5ff46 100644 --- a/arch/powerpc/mm/numa.c +++ b

[PATCH V14 1/4] powerpc/vphn: Update CPU topology when VPHN enabled

2017-09-08 Thread Michael Bringmann
the CPU. Signed-off-by: Michael Bringmann --- Changes in V14: -- Cleanup some duplicate code. Change a trace stmt to debug. --- arch/powerpc/mm/numa.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c

[PATCH V14 4/4] powerpc/vphn: Fix numa update end-loop bug

2017-09-08 Thread Michael Bringmann
(). Signed-off-by: Michael Bringmann --- Changes in V14: -- More code cleanup --- arch/powerpc/mm/numa.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index 32f5f8d..ec098b3 100644 --- a/arch/powerpc/mm/numa.c +++ b

[PATCH V14 3/4] powerpc/hotplug: Improve responsiveness of hotplug change

2017-09-08 Thread Michael Bringmann
value to better ensure that the CPU topology is detected and configured sooner. Signed-off-by: Michael Bringmann --- Changes in V14: -- Restore accidentally deleted reset of topology timer. --- arch/powerpc/include/asm/topology.h |8 arch/powerpc/mm/numa.c

[PATCH V12] powerpc/vphn: Update CPU topology when VPHN enabled

2017-08-31 Thread Michael Bringmann
detected and configured sooner. Also, fix an end-of-updates processing problem observed occasionally in numa_update_cpu_topology(). Signed-off-by: Michael Bringmann --- Changes in V12: -- Reorganize some of the updates to minimize kernel impact. -- Improve documentation of this patch. --- arch

[PATCH V13 0/4] powerpc/vphn: Update CPU topology when VPHN enabled

2017-09-01 Thread Michael Bringmann
detected and configured sooner. Also, fix an end-of-updates processing problem observed occasionally in numa_update_cpu_topology(). Signed-off-by: Michael Bringmann Michael Bringmann (4): powerpc/vphn: Update CPU topology when VPHN enabled powerpc/vphn: Improve recognition of PRRN/VPHN

[PATCH V13 1/4] powerpc/vphn: Update CPU topology when VPHN enabled

2017-09-01 Thread Michael Bringmann
the CPU. Signed-off-by: Michael Bringmann --- Changes in V13: -- Split patch for improved review --- arch/powerpc/mm/numa.c | 31 --- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index b95c584

[PATCH V13 2/4] powerpc/vphn: Improve recognition of PRRN/VPHN

2017-09-01 Thread Michael Bringmann
: Michael Bringmann --- Changes in V13: -- Split patch to improve review --- arch/powerpc/mm/numa.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index 312f6ee..c08d736 100644 --- a/arch/powerpc/mm/numa.c +++ b/arch

[PATCH V13 3/4] powerpc/hotplug: Improve responsiveness of hotplug change

2017-09-01 Thread Michael Bringmann
value to better ensure that the CPU topology is detected and configured sooner. Signed-off-by: Michael Bringmann --- arch/powerpc/include/asm/topology.h |8 arch/powerpc/mm/numa.c | 21 - arch/powerpc/platforms/pseries/hotplug-cpu.c

[PATCH V13 4/4] powerpc/vphn: Fix numa update end-loop bug

2017-09-01 Thread Michael Bringmann
(). Signed-off-by: Michael Bringmann --- arch/powerpc/mm/numa.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index 3a5b334..fccf23f 100644 --- a/arch/powerpc/mm/numa.c +++ b/arch/powerpc/mm/numa.c @@ -1410,6 +1410,13 @@ int

Re: [PATCH V13 4/4] powerpc/vphn: Fix numa update end-loop bug

2017-09-06 Thread Michael Bringmann
On 09/06/2017 09:45 AM, Nathan Fontenot wrote: > On 09/01/2017 10:48 AM, Michael Bringmann wrote: >> powerpc/vphn: On Power systems with shared configurations of CPUs >> and memory, there are some issues with the association of additional >> CPUs and memory to nodes when

[PATCH V9 0/2] powerpc/dlpar: Correct display of hot-add/hot-remove CPUs and memory

2017-08-21 Thread Michael Bringmann
he instruction, nodes_and(node_possible_map, node_possible_map, node_online_map); presently seen in the function arch/powerpc/mm/numa.c:initmem_init(). If the property is not present at boot, no operation will be performed to define or enable additional nodes. Signed-off-by: Michael Br

[PATCH V9 2/2] powerpc/nodes: Ensure enough nodes avail for operations

2017-08-21 Thread Michael Bringmann
To: linuxppc-...@lists.ozlabs.org From: Michael Bringmann To: linux-kernel@vger.kernel.org Cc: Michael Ellerman Cc: Michael Bringmann Cc: John Allen Cc: Nathan Fontenot Subject: [PATCH V9 2/2] powerpc/nodes: Ensure enough nodes avail for operations powerpc/nodes: On systems like PowerPC

[PATCH V9 1/2] powerpc/numa: Update CPU topology when VPHN enabled

2017-08-21 Thread Michael Bringmann
information provided by the pHyp. Also, update initialization checks for device-tree attributes to independently recognize PRRN or VPHN usage. Signed-off-by: Michael Bringmann --- arch/powerpc/include/asm/topology.h | 14 ++ arch/powerpc/mm/numa.c | 64

[PATCH] workqueue: Ensure that cpumask set for pools created after boot

2017-05-10 Thread Michael Bringmann
created, attached, and woken up. If the mask is not set up, then the kernel will crash when 'wakeup_process' is unable to find a valid CPU to which to assign the new worker. Signed-off-by: Michael Bringmann --- diff --git a/kernel/workqueue.c b/kernel/workqueue.c index c74bf39..6091

  1   2   >