Re: [PATCH 09/20] of/fdt: create common debugfs

2014-04-04 Thread Michal Simek
On 04/04/2014 03:32 PM, Rob Herring wrote: On Fri, Apr 4, 2014 at 8:22 AM, Michal Simek mon...@monstr.eu wrote: On 04/04/2014 03:00 PM, Rob Herring wrote: On Fri, Apr 4, 2014 at 7:16 AM, Michal Simek mon...@monstr.eu wrote: On 04/04/2014 12:16 AM, Rob Herring wrote: From: Rob Herring r

Re: [PATCH v2 1/5] ARM: zynq: DT: Add 'clock-latency' property

2014-04-06 Thread Michal Simek
mike.looijm...@topic.nl Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com Tested-by: Mike Looijmans mike.looijm...@topic.nl Signed-off-by: Michal Simek michal.si...@xilinx.com --- This is a fix from our vendor tree Changes in v2: - This patch has been added --- arch/arm/boot

Re: [PATCH v5 3/3] ARM: zynq: dt: Add I2C nodes to Zynq device tree

2014-04-06 Thread Michal Simek
On 04/04/2014 11:27 PM, Soren Brinkmann wrote: Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com Tested-by: Michal Simek michal.si...@xilinx.com --- Changes in v5: - use lower case hex digits in 'reg' property Changes in v4: None Changes in v3: None Changes in v2: - replace

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-06 Thread Michal Simek
some weeks ago regarding this. IRC the origin idea to use this was especially for people who writing these DTS by hand which is not our case - at least for majority of our customers. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854

Re: [PATCH 06/10] ARM: EXYNOS: Add support for mapping PMU base address via DT

2014-04-07 Thread Michal Simek
On 04/05/2014 12:58 PM, Pankaj Dubey wrote: On 04/03/2014 06:07 PM, Sylwester Nawrocki wrote: On 02/04/14 14:15, Michal Simek wrote: There were some patches posted for syscon to make it available in earlier system initialization stage: https://lkml.org/lkml/2014/2/19/218 I haven't finished

Re: [PATCH v7 1/2] can: xilinx CAN controller support

2014-04-07 Thread Michal Simek
you apply these patches you should apply 2/2 before 1/2. There is new checking for binding. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel

Re: [PATCH 09/20] of/fdt: create common debugfs

2014-04-07 Thread Michal Simek
On 04/07/2014 02:42 AM, Rob Herring wrote: On Fri, Apr 4, 2014 at 9:11 AM, Michal Simek mon...@monstr.eu wrote: On 04/04/2014 03:32 PM, Rob Herring wrote: On Fri, Apr 4, 2014 at 8:22 AM, Michal Simek mon...@monstr.eu wrote: On 04/04/2014 03:00 PM, Rob Herring wrote: On Fri, Apr 4, 2014 at 7

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-07 Thread Michal Simek
Hi Mike, On 04/07/2014 02:17 PM, Mike Looijmans wrote: On 04/07/2014 07:58 AM, Michal Simek wrote: Hi Soren, On 04/05/2014 01:14 AM, Soren Brinkmann wrote: Convert all Zynq DT files to the dtc preprocessor include syntax. This allows to include header files in the devicetrees like other

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-08 Thread Michal Simek
On 04/07/2014 08:02 PM, Steffen Trumtrar wrote: Hi! On Mon, Apr 07, 2014 at 11:10:12AM -0600, Jason Gunthorpe wrote: On Mon, Apr 07, 2014 at 02:24:07PM +0200, Michal Simek wrote: Device-tree BSP and in 2014.01 there will be new BSP which just generate them directly from the Vivado tools

[PATCH] asm-generic/io.h: Add default configuration for readX/writeX_relaxed

2014-04-08 Thread Michal Simek
compilation failures on architectures which don't define them. Signed-off-by: Michal Simek michal.si...@xilinx.com --- git://git.monstr.eu/linux-2.6-microblaze xnext/io 4b9d4a7ed112d0b68b654f09b87ad16ccd644a47 asm-generic/io.h: Add default configuration for readX/writeX_relaxed elapsed time: 59m

[PATCH v3] mfd: syscon: Support early initialization

2014-04-08 Thread Michal Simek
to regmap via regmap_attach_dev(). For early syscon initialization is necessary to extend struct syscon and provide remove function which unmap all early init structures. Signed-off-by: Michal Simek michal.si...@xilinx.com --- Changes in v3: - Keep backward compatibility for platform drivers

Re: [PATCH] asm-generic/io.h: Add default configuration for readX/writeX_relaxed

2014-04-08 Thread Michal Simek
Hi Sam, On 04/08/2014 07:50 PM, Sam Ravnborg wrote: On Tue, Apr 08, 2014 at 09:16:01AM +0200, Michal Simek wrote: Define default readX/writeX_relaxed IO helper functions for all archs which use asm-generic/io.h. Using COMPILE_TEST, moving drivers out of arch/arm and removing architecture

Re: [GIT PULL] serial: Cadence

2014-04-23 Thread Michal Simek
On 04/24/2014 01:48 AM, Greg Kroah-Hartman wrote: On Wed, Apr 23, 2014 at 08:11:15AM +0200, Michal Simek wrote: Hi Greg, this is around for a while and I would like to close it. I have applied patches 1-7 from v3. Patches 8 and 9 should go through arm-soc tree and I will add them to my zynq

Re: Microblaze image hanging in qemu with 3.15-rc

2014-04-24 Thread Michal Simek
On 04/23/2014 05:45 PM, Guenter Roeck wrote: On Wed, Apr 23, 2014 at 04:12:59PM +0200, Michal Simek wrote: On 04/23/2014 03:38 PM, Guenter Roeck wrote: On 04/22/2014 10:32 PM, Michal Simek wrote: Hi Guenter, On 04/22/2014 07:23 PM, Guenter Roeck wrote: Hi all, when trying to run

Re: [GIT PULL] serial: Cadence

2014-04-24 Thread Michal Simek
On 04/25/2014 01:23 AM, Greg Kroah-Hartman wrote: On Thu, Apr 24, 2014 at 07:30:48AM +0200, Michal Simek wrote: On 04/24/2014 01:48 AM, Greg Kroah-Hartman wrote: On Wed, Apr 23, 2014 at 08:11:15AM +0200, Michal Simek wrote: Hi Greg, this is around for a while and I would like to close it. I

Re: Microblaze image hanging in qemu with 3.15-rc

2014-04-25 Thread Michal Simek
On 04/24/2014 03:38 PM, Guenter Roeck wrote: On 04/23/2014 11:16 PM, Michal Simek wrote: On 04/23/2014 05:45 PM, Guenter Roeck wrote: On Wed, Apr 23, 2014 at 04:12:59PM +0200, Michal Simek wrote: On 04/23/2014 03:38 PM, Guenter Roeck wrote: On 04/22/2014 10:32 PM, Michal Simek wrote: Hi

Re: Microblaze image hanging in qemu with 3.15-rc

2014-04-25 Thread Michal Simek
On 04/25/2014 03:51 PM, Guenter Roeck wrote: On 04/25/2014 06:29 AM, Guenter Roeck wrote: On 04/25/2014 12:25 AM, Michal Simek wrote: [ ... ] It should be pretty easy to fix it in timer_write function like this. diff --git a/hw/timer/xilinx_timer.c b/hw/timer/xilinx_timer.c index 6113b97

Re: [PATCH] clk: zynq: Leave debug clocks in bootup state

2014-04-22 Thread Michal Simek
On 04/17/2014 08:40 PM, Soren Brinkmann wrote: Make sure debug clocks stay enabled if the bootloader enabled them. Otherwise debug HW may crash due to bus-hangs caused by stopped clocks. Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com --- drivers/clk/zynq/clkc.c | 12

Re: [PATCH v3 2/3] dma: Add Xilinx Video DMA DT Binding Documentation

2014-04-22 Thread Michal Simek
...@kernel.org Thanks Rob, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian

Re: [PATCH 02/18] microblaze: io: remove dummy relaxed accessor macros

2014-04-22 Thread Michal Simek
On 04/17/2014 03:44 PM, Will Deacon wrote: These are now defined by asm-generic/io.h, so we don't need the private definitions anymore. Cc: Michal Simek mon...@monstr.eu Signed-off-by: Will Deacon will.dea...@arm.com --- arch/microblaze/include/asm/io.h | 8 1 file changed, 8

Re: [PATCH 18/18] asm-generic: io: define relaxed accessor macros unconditionally

2014-04-22 Thread Michal Simek
architecture io.h exactly I have done it for Microblaze. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U

Re: Microblaze image hanging in qemu with 3.15-rc

2014-04-22 Thread Michal Simek
with my configuration or with my qemu command line ? Is this BE/LE version? Which qemu do you use? There is endian autodetection in timer and intc driver which can caused this problem. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854

[GIT PULL] serial: Cadence

2014-04-23 Thread Michal Simek
to 05a06a30d212f76e7822ef1093fa002baac021a7: tty: xuartps: Rebrand driver as Cadence UART (2014-04-23 08:00:10 +0200) tty: Cadence uart rebranding and cleanup Michal Simek (2

Re: [RESEND PATCH v3 9/9] ARM: zynq: DT: Migrate UART to Cadence binding

2014-04-23 Thread Michal Simek
...@xilinx.com Acked-by: Rob Herring r...@kernel.org Tested-by: Michal Simek michal.si...@xilinx.com --- This change depends on 'tty: xuartps: Rebrand driver as Cadence UART', which introduces the new clock-names. Changes in v3: None Changes in v2: None Signed-off-by: Soren Brinkmann soren.brinkm

Re: [RESEND PATCH v3 8/9] tty: cadence: Document DT binding

2014-04-23 Thread Michal Simek
On 04/05/2014 02:23 AM, Soren Brinkmann wrote: Add binding documentation for the Cadence UART. Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com Acked-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Acked-by: Rob Herring r...@kernel.org Tested-by: Michal Simek michal.si

Re: [PATCH 18/18] asm-generic: io: define relaxed accessor macros unconditionally

2014-04-23 Thread Michal Simek
Hi Will, On 04/22/2014 05:18 PM, Will Deacon wrote: Hi Michal, On Tue, Apr 22, 2014 at 03:09:46PM +0100, Michal Simek wrote: On 04/17/2014 03:44 PM, Will Deacon wrote: Now that no architectures using asm-generic/io.h define their own relaxed accessors, the dummy definitions can be used

Re: [PATCH v3] mfd: syscon: Support early initialization

2014-04-23 Thread Michal Simek
On 04/10/2014 08:17 AM, Michal Simek wrote: On 04/10/2014 08:20 AM, Pankaj Dubey wrote: Hi Michal, On 04/09/2014 12:00 AM, Michal Simek wrote: Some platforms need to get system controller ready as soon as possible. The patch provides early_syscon_initialization which create early mapping

Re: [PATCH 18/18] asm-generic: io: define relaxed accessor macros unconditionally

2014-04-23 Thread Michal Simek
which was introduce by this change. You should check them too if you haven't done it. As follow up we should move these to asm-generic/io.h too ioremap_writethrough ioremap_nocache ioremap_fullcache - used nowhere ioremap_wc Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w

Re: [PATCH v3] mfd: syscon: Support early initialization

2014-04-23 Thread Michal Simek
On 04/23/2014 10:22 AM, Pankaj Dubey wrote: On 04/23/2014 04:27 PM, Michal Simek wrote: On 04/10/2014 08:17 AM, Michal Simek wrote: On 04/10/2014 08:20 AM, Pankaj Dubey wrote: Hi Michal, On 04/09/2014 12:00 AM, Michal Simek wrote: Some platforms need to get system controller ready as soon

Re: [PATCH v3] mfd: syscon: Support early initialization

2014-04-23 Thread Michal Simek
to share driver private data without pdev. Maybe there is better way how to do it that's why please let me know if you are aware about it. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http

Re: [PATCH v2 17/21] of/fdt: introduce of_get_flat_dt_size

2014-04-23 Thread Michal Simek
) } /** + * of_get_flat_dt_size - Return the total size of the FDT + */ It looks like that you are trying to use kernel-doc format but I believe this will caused kernel-doc warning. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854

Re: [PATCH v2 18/21] powerpc: use libfdt accessors for header data

2014-04-23 Thread Michal Simek
of_get_flat_dt_size() that's why I expect you will use it here too. size = of_get_flat_dt_size(); The same is for 14/21 where you can use this new function too. It means moving 14/21 to the end and using this new function makes more sense. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID

Re: [PATCH v2 14/21] of/fdt: create common debugfs

2014-04-23 Thread Michal Simek
support is added. This changes the path of the blob from $arch/flat-device-tree to device-tree/flat-device-tree. Signed-off-by: Rob Herring r...@kernel.org Cc: Michal Simek mon...@monstr.eu Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc

Re: Microblaze image hanging in qemu with 3.15-rc

2014-04-23 Thread Michal Simek
On 04/23/2014 03:38 PM, Guenter Roeck wrote: On 04/22/2014 10:32 PM, Michal Simek wrote: Hi Guenter, On 04/22/2014 07:23 PM, Guenter Roeck wrote: Hi all, when trying to run a microblaze image with 3.15-rc1 or 3.15-rc2 in qemu, I get the following hangup. This used to work with earlier

Re: [PATCH v2 18/21] powerpc: use libfdt accessors for header data

2014-04-23 Thread Michal Simek
On 04/23/2014 04:05 PM, Rob Herring wrote: On Wed, Apr 23, 2014 at 8:48 AM, Michal Simek mon...@monstr.eu wrote: On 04/23/2014 03:18 AM, Rob Herring wrote: From: Rob Herring r...@kernel.org With libfdt support, we can take advantage of helper accessors in libfdt for accessing the FDT header

Re: [PATCH v2 00/21] FDT clean-ups and libfdt support

2014-04-23 Thread Michal Simek
in the unflattening code where walking up the tree was not being handled correctly (thanks to Michal Simek). I re-worked things a bit to avoid globally adding libfdt include paths. A branch is available here[1], and I plan to put into linux-next in a few days. Please test! I've compiled on arm

Re: [RFC PATCH v2] edac: synopsys: Added EDAC support for zynq ddr ecc controller

2014-04-10 Thread Michal Simek
debugging. For ARM multiplatform kernel I think that it is almost must to use vendor prefixes for all platform/driver code. All drivers can use instead of name_probe just probe but I don't think this is the right way to go. The rest was commented by Punnaiah. Thanks, Michal -- Michal Simek, Ing

Re: [RFC PATCH] edac: add support for ARM PL310 L2 cache parity

2014-04-10 Thread Michal Simek
edac interface. Or it is just easy way to do but using edac interface is right solution and how to do it properly is different question. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http

Re: [PATCH v3] mfd: syscon: Support early initialization

2014-04-10 Thread Michal Simek
On 04/10/2014 08:20 AM, Pankaj Dubey wrote: Hi Michal, On 04/09/2014 12:00 AM, Michal Simek wrote: Some platforms need to get system controller ready as soon as possible. The patch provides early_syscon_initialization which create early mapping for all syscon compatible devices

Re: [RFC PATCH v2] edac: synopsys: Added EDAC support for zynq ddr ecc controller

2014-04-10 Thread Michal Simek
On 04/10/2014 11:21 AM, Borislav Petkov wrote: On Thu, Apr 10, 2014 at 08:01:36AM +0200, Michal Simek wrote: Just add it to Zynq maintainer fragment as we are doing for non zynq/xilinx drivers. Yep, as a file pattern F: yep. At least the is the first time when someone saying that only

Re: [RFC PATCH] edac: add support for ARM PL310 L2 cache parity

2014-04-10 Thread Michal Simek
, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq

Re: [RFC PATCH v2] edac: synopsys: Added EDAC support for zynq ddr ecc controller

2014-04-10 Thread Michal Simek
On 04/10/2014 12:00 PM, Borislav Petkov wrote: On Thu, Apr 10, 2014 at 11:49:57AM +0200, Michal Simek wrote: I agree with you that we can use shorter name. I have checked this with Punnaiah and I can't see any problem to have more edac drivers in the system. For zynq there is primary ddr

Re: [RFC PATCH v2] edac: synopsys: Added EDAC support for zynq ddr ecc controller

2014-04-10 Thread Michal Simek
On 04/10/2014 12:05 PM, Borislav Petkov wrote: On Thu, Apr 10, 2014 at 12:00:47PM +0200, Borislav Petkov wrote: Then you'll have to check whether edac can even stomach more than one drivers in parallel. TTBOMK, no one has ever done this so far... Yadda yadda. Alternatively, you could put

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-10 Thread Michal Simek
On 04/08/2014 07:27 PM, Jason Gunthorpe wrote: On Tue, Apr 08, 2014 at 09:03:27AM +0200, Michal Simek wrote: If in doubt follow common mainline practice. Although using includes for DT is not necessarily common practice, readability of DTs is really important IMHO. Let me give you one

[GIT PULL] arch/microblaze changes for 3.15

2014-04-11 Thread Michal Simek
code - Clean platform handling - Enable some syscalls Guenter Roeck (2): microblaze: Rename global function heartbeat() microblaze: Drop architecture-specific declaration of early_printk Michal Simek (12): microblaze

Re: [PATCH 1/2] GPIO: Add driver for Zynq GPIO controller

2014-04-11 Thread Michal Simek
On 04/10/2014 07:52 PM, Linus Walleij wrote: On Wed, Apr 2, 2014 at 7:56 AM, Michal Simek mon...@monstr.eu wrote: On 03/31/2014 10:22 AM, Linus Walleij wrote: On Sat, Mar 29, 2014 at 5:44 AM, Harini Katakam harinikatakamli...@gmail.com wrote: On Sat, Mar 29, 2014 at 3:20 AM, Linus Walleij

Re: [PATCH RFC 3/3] nand: pl353: Add driver for arm pl353 smc nand interface

2014-03-31 Thread Michal Simek
MTD_NAND_PL353 + tristate ARM Pl353 NAND flash driver + depends on MTD_NAND ARM + select PL353_SMC Here should be probably depends on PL353_SMC. I just found it. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer

Re: [PATCH RFC 3/3] nand: pl353: Add driver for arm pl353 smc nand interface

2014-03-31 Thread Michal Simek
On 03/31/2014 02:46 PM, Michal Simek wrote: On 03/27/2014 07:21 PM, Punnaiah Choudary Kalluri wrote: Add driver for arm pl353 static memory controller nand interface. This controller is used in xilinx zynq soc for interfacing the nand flash memory. Signed-off-by: Punnaiah Choudary Kalluri

Re: [PATCH 1/2] watchdog: Add Cadence WDT driver

2014-04-01 Thread Michal Simek
implementation where all these io accesses should be done via smc calls and having IO helper function is easier for change. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt

Re: FIQ on xilinx cortex a9 zynq

2014-04-01 Thread Michal Simek
can run in non secure mode. Regarding GIC setup here should be experts to tell you how to do it. If you need some help to get Linux running on Zynq in non secure mode please ping me we can look at it. I tried it some months ago. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID

Re: [PATCH 1/2] watchdog: Add Cadence WDT driver

2014-04-01 Thread Michal Simek
On 04/02/2014 02:32 AM, Guenter Roeck wrote: On 04/01/2014 04:20 AM, Michal Simek wrote: Hi Guenter, +/** + * struct cdns_wdt - Watchdog device structure + * @regs: baseaddress of device + * @rst: reset flag + * @clk: struct clk * of a clock source + * @prescaler: for saving prescaler

Re: [PATCH 1/2] GPIO: Add driver for Zynq GPIO controller

2014-04-01 Thread Michal Simek
inline int zynq_gpio_writereg(struct zynq_gpio *gpio, u32 offset, u32 val) { writel_relaxed(val, gpio-base_addr + offset); return 0; } Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze

Re: [PATCH v7 1/2] dma: Add Xilinx Video DMA DT Binding Documentation

2014-04-02 Thread Michal Simek
-- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform

Re: [PATCH 02/10] ARM: EXYNOS: Correct file path in comment message

2014-04-02 Thread Michal Simek
Electronics Co., Ltd. * http://www.samsung.com Shouldn't you just remove it entirely? I had the same file names in the whole microblaze tree and some months/years later this was just broken everywhere. That's why it is just easier to remove it entirely. Thanks, Michal -- Michal Simek

Re: [PATCH 06/10] ARM: EXYNOS: Add support for mapping PMU base address via DT

2014-04-02 Thread Michal Simek
in earlier system initialization stage: https://lkml.org/lkml/2014/2/19/218 I haven't finished this yet. I have to look at it again. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http

Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-04-03 Thread Michal Simek
); + return ret; + } + + xi2c-suspended = 0; + + return 0; +} +#endif Can you also please remove this #ifdef and use __maybe_used instead? Better not to have any ifdef in the code. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0

Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-04-03 Thread Michal Simek
suggestion to do it came from CAN maintainer. It is valid in general for ifdef. I have checked all our drivers and we are changing them to use __maybe_used because then we can easily find out if there is any problem when function prototype has changed. Thanks, Michal -- Michal Simek, Ing. (M.Eng

Re: [PATCH linux-next] arm: zynq: fix compilation warning

2013-06-27 Thread Michal Simek
...@freescale.com Cc: Robin Holt h...@sgi.com Cc: Michal Simek michal.si...@xilinx.com Cc: Russell King li...@arm.linux.org.uk Cc: triv...@kernel.org --- Hi, This warning was seen on linux-next tag next-20130627, with config ARM multi_v7_defconfig. Best regards, V. arch/arm/mach

Re: [PATCH v3 2/2] uio: Remove uio_pdrv and use uio_pdrv_genirq instead

2013-07-01 Thread Michal Simek
Hi Greg, On 06/27/2013 01:17 AM, Pavel Machek wrote: On Wed 2013-06-26 11:52:12, Michal Simek wrote: The patch UIO: fix uio_pdrv_genirq with device tree but no interrupt (sha1: e3a3c3a205554e564751cd9c0276b2af813d7a92) add support to use this driver with no interrupts. uio_pdrv_genirq also

Re: [PATCH RFC] mfd: syscon: Decouple syscon interface from syscon devices

2014-06-18 Thread Michal Simek
subsystem is not able to work with regmap anyway. Moving to proper location is just the last step. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux

Re: [PATCH v4] pcie: Add Xilinx PCIe Host Bridge IP driver

2014-07-22 Thread Michal Simek
On 07/22/2014 06:08 PM, Bjorn Helgaas wrote: On Mon, Jul 21, 2014 at 11:10 PM, Srikanth Thokala stho...@xilinx.com wrote: On Wed, Jul 16, 2014 at 11:08 PM, Bjorn Helgaas bhelg...@google.com wrote: ... I see I forgot to ask for a MAINTAINERS entry for this driver. Can you add one? There was

Re: [PATCH 1/1] ARM: dts: zynq: Add Parallella device tree

2014-07-08 Thread Michal Simek
On 06/30/2014 07:15 AM, Olof Johansson wrote: Hi, On Sun, Jun 29, 2014 at 1:50 PM, Andreas Färber afaer...@suse.de wrote: This allows to boot the Adapteva Parallella board to serial console. Cc: Andreas Olofsson andr...@adapteva.com Signed-off-by: Andreas Färber afaer...@suse.de Nice

Re: [PATCH v3 2/2] devicetree: Add Cadence WDT devicetree bindings documentation

2014-07-14 Thread Michal Simek
On 07/14/2014 02:16 PM, Harini Katakam wrote: Add cadence-wdt bindings documentation. Signed-off-by: Harini Katakam hari...@xilinx.com --- v3 changes: - Change reset property type and improve description. - Improve description of clocks and interrupts. - Use watchdog@ in the example. -

Re: [PATCH 1/1] ARM: dts: zynq: Add Parallella device tree

2014-07-15 Thread Michal Simek
On 07/14/2014 08:12 PM, Olof Johansson wrote: On Tue, Jul 8, 2014 at 4:18 AM, Michal Simek michal.si...@xilinx.com wrote: On 06/30/2014 07:15 AM, Olof Johansson wrote: Hi, On Sun, Jun 29, 2014 at 1:50 PM, Andreas Färber afaer...@suse.de wrote: This allows to boot the Adapteva Parallella

Re: [PATCH] devicetree: macb: Document clock properties

2013-12-19 Thread Michal Simek
nicolas.fe...@atmel.com Has someone taken this patch? If not, Rob can you please add it to your tree? Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux

[PATCH v5 1/3] i2c: xilinx: Fix i2c checkpatch warnings

2013-12-19 Thread Michal Simek
From: Kedareswara rao Appana appana.durga@xilinx.com Code changes to fix checkpatch warnings listed below. - WARNING: please, no space before tabs - WARNING: quoted string split across lines Signed-off-by: Kedareswara rao Appana appa...@xilinx.com Signed-off-by: Michal Simek michal.si

[PATCH v5 2/3] i2c: xilinx: Do not enable irq before irq handler

2013-12-19 Thread Michal Simek
IRQ handler has to be register first before IRQ is enabled in xiic_reinit(). Signed-off-by: Michal Simek michal.si...@xilinx.com --- Changes in v5: None Changes in v4: None Changes in v3: - New patch in this patchset based on my discussion with Wolfram https://lkml.org/lkml/2013/10/4/148

[PATCH v5 3/3] i2c: xilinx: Use devm_* functions

2013-12-19 Thread Michal Simek
From: Kedareswara rao Appana appana.durga@xilinx.com Simplified the probe and remove functions using devm_* functions Signed-off-by: Kedareswara rao Appana appa...@xilinx.com Signed-off-by: Michal Simek michal.si...@xilinx.com --- Changes in v5: - dev_get_platdata casting was removed in i2c

[PATCH] MAINTAINERS: Setup proper record for Xilinx Zynq

2013-12-19 Thread Michal Simek
Setup correct zynq entry. - Add missing cadence_ttc_timer maintainership - Add zynq wildcard - Add xilinx wildcard Signed-off-by: Michal Simek michal.si...@xilinx.com --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1344816..5f6e3ae 100644

[PATCH] microblaze: timer: Use generic sched_clock implementation

2013-12-20 Thread Michal Simek
Remove sched_clock from the driver and use setup_check_clock function. Signed-off-by: Michal Simek michal.si...@xilinx.com --- Thomas: Can you please review this patch? I would like to be sure that I have done it correctly. Thanks, Michal --- arch/microblaze/Kconfig| 1 + arch

[PATCH] microblaze: extable: Sort the exception table at build time

2013-12-20 Thread Michal Simek
the exception table at build time (sha1: adace89562c7a9645b8dc84f6e1ac7ba8756094e) Signed-off-by: Michal Simek michal.si...@xilinx.com --- arch/microblaze/Kconfig | 1 + scripts/sortextable.c | 5 + 2 files changed, 6 insertions(+) diff --git a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig

Re: [PATCH 01/10] watchdog: xilinx: Convert driver to the watchdog framework

2014-02-09 Thread Michal Simek
On 02/09/2014 09:03 PM, Guenter Roeck wrote: On 01/31/2014 06:18 AM, Michal Simek wrote: - Remove uneeded headers, fops functions - Use xilinx_wdt prefix in start/stop/keepalive functions and in new structures Signed-off-by: Michal Simek michal.si...@xilinx.com Hi Michal, static

Re: [PATCH 10/10] watchdog: xilinx: Enable this driver for Zynq

2014-02-09 Thread Michal Simek
On 02/10/2014 01:51 AM, Guenter Roeck wrote: On 01/31/2014 06:18 AM, Michal Simek wrote: Enable this driver for Zynq. Move it to architecture independent Kconfig part. Signed-off-by: Michal Simek michal.si...@xilinx.com --- Build tested by zero day testing system. --- Hi Michal, I

Re: [PATCH v3] ARM: dts: zynq: Add SPI

2014-07-28 Thread Michal Simek
On 07/25/2014 04:42 PM, Sören Brinkmann wrote: On Fri, 2014-07-25 at 01:12PM +0200, Andreas Färber wrote: Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Soren Brinkmann soren.brinkm...@xilinx.com Applied to zynq/dt. Thanks, Michal -- To unsubscribe from this list: send the line

[PATCH v3] ARM: zynq: DT: Add CAN node

2014-07-28 Thread Michal Simek
Add node describing Zynq's CAN controller. Signed-off-by: Michal Simek michal.si...@xilinx.com --- Changes in v3: - Fix clocks description for can1 Changes in v2: - Add can1 - Enable can0 for zc702 - Use status property arch/arm/boot/dts/zynq-7000.dtsi | 26 +- arch

Re: [PATCH v2] ARM: zynq: DT: Add CAN node

2014-07-28 Thread Michal Simek
On 07/25/2014 05:00 PM, Sören Brinkmann wrote: On Fri, 2014-07-25 at 08:52AM +0200, Michal Simek wrote: Add node describing Zynq's CAN controller. Signed-off-by: Michal Simek michal.si...@xilinx.com --- Changes in v2: - Add can1 - Enable can0 for zc702 - Use status property arch/arm

Re: [LINUX PATCH] ARM: zynq: DT: Remove DMA from board DTs

2014-07-28 Thread Michal Simek
Brinkmann soren.brinkm...@xilinx.com --- When the 'status' property was removed from the DMA node, this had been overlooked. Indeed, Reviewed-by: Andreas Färber afaer...@suse.de Applied. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0

Re: [PATCH] ARM: zynq: DT: Clarify Xilinx Zynq platform

2014-07-30 Thread Michal Simek
On 07/25/2014 10:15 AM, Michal Simek wrote: ep107 was emulation platform and compatible string have been changed long time ago. ARM: zynq: dts: split up device tree (sha1: e06f1a9ed7ebff170ba05d2606d079fb36c6a52d) Signed-off-by: Michal Simek michal.si...@xilinx.com --- Documentation

Re: [RFA][PATCH 22/27] microblaze: ftrace: Remove check of obsolete variable function_trace_stop

2014-07-18 Thread Michal Simek
/kernel/git/rostedt/linux-trace.git rfc/remove-function-trace-stop I have tested this full branch and there is no issue on Microblaze that's why here is: Tested-by: Michal Simek mon...@monstr.eu Thanks, Michal signature.asc Description: OpenPGP digital signature

Re: [RFA][PATCH 06/27] microblaze: ftrace: Add call to ftrace_graph_is_dead() in function graph code

2014-07-18 Thread Michal Simek
graph error, disable only function graph tracing. To do this, the arch code must call ftrace_graph_is_dead() before it implements function graph. Cc: Michal Simek mon...@monstr.eu Signed-off-by: Steven Rostedt rost...@goodmis.org --- arch/microblaze/kernel/ftrace.c | 3 +++ 1 file changed

Re: [PATCH] ARM: zynq: dt: Add GPIO node

2014-07-18 Thread Michal Simek
On 07/10/2014 08:53 PM, Soren Brinkmann wrote: Add node describing Zynq's GPIO controller. Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com --- The GPIO driver and binding documentation is staged in Linus' GPIO tree. Sören arch/arm/boot/dts/zynq-7000.dtsi | 10

Re: [RFC PATCH v3] edac: synps: Added EDAC support for zynq ddr ecc controller

2014-07-31 Thread Michal Simek
; pawel.m...@arm.com; Michal Simek; mark.rutl...@arm.com; ijc+devicet...@hellion.org.uk; Kumar Gala; Rob Landley; devicet...@vger.kernel.org; linux-...@vger.kernel.org; linux- e...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- ker...@lists.infradead.org; Punnaiah Choudary; Anirudha Sarangi

Re: [RFC PATCH v3] edac: synps: Added EDAC support for zynq ddr ecc controller

2014-07-31 Thread Michal Simek
On 07/31/2014 01:33 PM, Borislav Petkov wrote: On Wed, Jul 30, 2014 at 03:41:47PM +, Punnaiah Choudary Kalluri wrote: So you're telling me that you want one edac driver for *two* memory controllers which can be present on a single system *at* *the* *same* *time*? Is that it? Yes. Oh,

Re: [RFC PATCH v3] edac: synps: Added EDAC support for zynq ddr ecc controller

2014-07-31 Thread Michal Simek
On 07/31/2014 03:17 PM, Borislav Petkov wrote: On Thu, Jul 31, 2014 at 02:13:48PM +0200, Michal Simek wrote: Mixing two drivers in the one file is not a good idea because with more memory controllers it is just a mess and you are not able to cover all cases. Why is it a mess? Mixing

Re: [PATCH 1/3] ARM: zynq: DT: Fix Ethernet phy modes

2014-08-21 Thread Michal Simek
On 08/20/2014 05:56 PM, Soren Brinkmann wrote: The used PHYs should be qualified as 'rgmii-id' instead of just 'rgmii'. For the Zed board this seems to make a difference between working and broken Ethernet. Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com ---

Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys

2014-08-21 Thread Michal Simek
On 08/20/2014 05:56 PM, Soren Brinkmann wrote: Add missing Ethernet phys to Zynq DTs. Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com --- arch/arm/boot/dts/zynq-zc702.dts | 6 ++ arch/arm/boot/dts/zynq-zc706.dts | 6 ++ arch/arm/boot/dts/zynq-zed.dts | 6 ++ 3

Re: [PATCH 2/3] ARM: zynq: DT: Move size/address properties to dtsi

2014-08-21 Thread Michal Simek
On 08/20/2014 06:00 PM, Andreas Färber wrote: Am 20.08.2014 17:56, schrieb Soren Brinkmann: Move the GEM's size and address cells properties to the common dtsi file. Cc: Andreas Färber afaer...@suse.de Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com ---

[GIT PULL] arch/microblaze fixes for 3.17-rc2

2014-08-21 Thread Michal Simek
- Wire-up seccomp/getrandom/memfd_create syscalls Michal Simek (3): microblaze: Wire-up seccomp syscall microblaze: Wire-up getrandom syscall microblaze: Wire-up memfd_create syscall arch/microblaze/include/uapi

Re: [PATCH 1/9] ARM: zynq: PM: Enable A9 internal clock gating feature

2014-08-21 Thread Michal Simek
On 08/20/2014 10:41 PM, Soren Brinkmann wrote: Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com --- arch/arm/mach-zynq/common.c | 6 ++ arch/arm/mach-zynq/common.h | 11 +++ arch/arm/mach-zynq/platsmp.c | 9 + 3 files changed, 26 insertions(+) diff --git

Re: [PATCH 4/9] ARM: zynq: PM: Enable DDR self-refresh and clock stop

2014-08-21 Thread Michal Simek
On 08/20/2014 10:41 PM, Soren Brinkmann wrote: The DDR controller can detect idle periods and leverage low power features like self-refresh and clock stop. When new requests occur, the DDRC resumes normal operation. Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com ---

Re: [PATCH 9/9] ARM: zynq: Rename 'zynq_platform_cpu_die'

2014-08-21 Thread Michal Simek
On 08/20/2014 10:41 PM, Soren Brinkmann wrote: Match the naming pattern of all other SMP ops and rename zynq_platform_cpu_die -- zynq_cpu_die. Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com --- arch/arm/mach-zynq/platsmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH 9/9] ARM: zynq: Rename 'zynq_platform_cpu_die'

2014-08-21 Thread Michal Simek
On 08/21/2014 09:02 PM, Sören Brinkmann wrote: On Thu, 2014-08-21 at 02:28PM +0200, Michal Simek wrote: On 08/20/2014 10:41 PM, Soren Brinkmann wrote: Match the naming pattern of all other SMP ops and rename zynq_platform_cpu_die -- zynq_cpu_die. Signed-off-by: Soren Brinkmann soren.brinkm

Re: [PATCH v5] pcie: Add Xilinx PCIe Host Bridge IP driver

2014-08-12 Thread Michal Simek
on this one? Srikanth: Isn't pcie-xilinx.c better name if this is just pcie host bridge? Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel

[PATCH] watchdog: xilinx: Remove .owner field for driver

2014-08-13 Thread Michal Simek
in platform_driver_register anyway. Signed-off-by: Michal Simek michal.si...@xilinx.com --- drivers/watchdog/of_xilinx_wdt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c index 1e6e28df5d7b..b2e1b4cbbdc1 100644 --- a/drivers

[PATCH 2/2] spi: cadence: Remove .owner field for driver

2014-08-13 Thread Michal Simek
in platform_driver_register anyway. Signed-off-by: Michal Simek michal.si...@xilinx.com --- drivers/spi/spi-cadence.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c index 562ff83debd9..7b811e38c7ad 100644 --- a/drivers/spi/spi-cadence.c +++ b

[PATCH 1/2] spi: xilinx: Remove .owner field for driver

2014-08-13 Thread Michal Simek
in platform_driver_register anyway. Signed-off-by: Michal Simek michal.si...@xilinx.com --- drivers/spi/spi-xilinx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c index 4d8efb16573d..79bd84f43430 100644 --- a/drivers/spi/spi-xilinx.c +++ b

[PATCH 1/2] tty: serial: xuartps: Remove .owner field for driver

2014-08-13 Thread Michal Simek
in platform_driver_register anyway. Signed-off-by: Michal Simek michal.si...@xilinx.com --- drivers/tty/serial/xilinx_uartps.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 01951d27cc03..c3c252db8b61 100644

[PATCH 2/2] tty: serial: uartlite: Remove .owner field for driver

2014-08-13 Thread Michal Simek
in platform_driver_register anyway. Signed-off-by: Michal Simek michal.si...@xilinx.com --- drivers/tty/serial/uartlite.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c index 9fc22f40796e..189f52e3111f 100644 --- a/drivers/tty/serial

[PATCH] net: xilinx: Remove .owner field for driver

2014-08-13 Thread Michal Simek
in platform_driver_register anyway. Signed-off-by: Michal Simek michal.si...@xilinx.com --- drivers/net/ethernet/xilinx/ll_temac_main.c | 1 - drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 - drivers/net/ethernet/xilinx/xilinx_emaclite.c | 1 - 3 files changed, 3 deletions(-) diff

[PATCH 1/2] i2c: cadence: Remove .owner field for driver

2014-08-13 Thread Michal Simek
in platform_driver_register anyway. Signed-off-by: Michal Simek michal.si...@xilinx.com --- drivers/i2c/busses/i2c-cadence.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c index 63f3f03ecc9b..04d0a7e449ef 100644 --- a/drivers/i2c

<    3   4   5   6   7   8   9   10   11   12   >