Re: [PATCH 05/11] spi/pxa2xx: make clock rate configurable from platform data

2013-01-10 Thread Mika Westerberg
On Thu, Jan 10, 2013 at 01:33:19PM +, Mark Brown wrote: > On Thu, Jan 10, 2013 at 02:18:08PM +0100, Rafael J. Wysocki wrote: > > On Thursday, January 10, 2013 12:51:59 PM Mark Brown wrote: > > > > Sounds sensible, yes - about what I'd expect. Is it possible to match > > > on CPUID or similar

Re: Cherryview wake up events

2016-09-19 Thread Mika Westerberg
r tables at: > https://linuxtv.org/~js/e200ha/ > > During the last weeks I read what I could about the hardware > and ACPI, and poked at it with acpidbg, devmem, ioport > and in kernel source, but to no avail. > > On Thu, Sep 15, 2016 at 06:52:10PM +0300, Mika Westerberg wro

Re: [REGRESSION? v4.8] i2c-core: acpi_i2c_get_info() touches non-existent devices

2016-09-19 Thread Mika Westerberg
On Mon, Sep 19, 2016 at 11:48:07AM +0300, Mika Westerberg wrote: > On Mon, Sep 19, 2016 at 12:30:53AM +0200, Nicolai Stange wrote: > > Hi, > > > > I'm encountering the following: > > > > [ 10.409490] ERROR: Unable to locate IOAPIC for GSI 37 > > &g

Re: [REGRESSION? v4.8] i2c-core: acpi_i2c_get_info() touches non-existent devices

2016-09-20 Thread Mika Westerberg
On Mon, Sep 19, 2016 at 03:58:52PM +0200, Nicolai Stange wrote: > > Can you try if the following patch cures the problem? > > Unfortunately not. That patch installs the check after the > acpi_i2c_get_info() invocation which is part of the backtrace above. Ah, indeed it needs to happen before we p

[PATCH] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter

2016-09-20 Thread Mika Westerberg
for GSI 37 To fix this we pass the I2C adapter to i2c_acpi_get_info() and make sure the handle matches the one in the I2cSerialBus() resource before doing anything else to the device. Reported-by: Nicolai Stange Signed-off-by: Mika Westerberg --- drivers/i2c/i2c-core.c | 12 +++- 1 file

Re: Cherryview wake up events

2016-09-20 Thread Mika Westerberg
On Mon, Sep 19, 2016 at 10:36:22PM +0200, Johannes Stezenbach wrote: > On Mon, Sep 19, 2016 at 02:56:19PM +0300, Mika Westerberg wrote: > > On Mon, Sep 19, 2016 at 01:21:17PM +0200, Johannes Stezenbach wrote: > > > > > > The LID causes a gpio irq: > > > 1

Re: Cherryview wake up events

2016-09-20 Thread Mika Westerberg
On Tue, Sep 20, 2016 at 12:14:50PM +0200, Johannes Stezenbach wrote: > On Tue, Sep 20, 2016 at 12:18:40PM +0300, Mika Westerberg wrote: > > On Mon, Sep 19, 2016 at 10:36:22PM +0200, Johannes Stezenbach wrote: > > > Now my question is, is this pin 0x004E the same as this > &g

Re: [PATCH] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter

2016-09-20 Thread Mika Westerberg
On Tue, Sep 20, 2016 at 12:32:11PM +0200, Nicolai Stange wrote: > Your patch fixes my issue, so feel free to add a > > Tested-by: Nicolai Stange Thanks! > for this either. > > But please see my remark below. > > > Mika Westerberg writes: > > > When

[PATCH v3 2/3] pinctrl: cherryview: Do not add all southwest and north GPIOs to IRQ domain

2016-09-20 Thread Mika Westerberg
with the GPE in question set. To make this all work as expected we only add those GPIOs to the IRQ domain that can actually generate interrupts (IntSel value 0-7) and skip others. Signed-off-by: Mika Westerberg --- drivers/pinctrl/intel/pinctrl-cherryview.c | 34 +- 1

[PATCH v3 3/3] pinctrl: cherryview: Convert to use devm_gpiochip_add_data()

2016-09-20 Thread Mika Westerberg
This simplifies the error handling and allows us to drop the whole chv_pinctrl_remove() function. Signed-off-by: Mika Westerberg --- drivers/pinctrl/intel/pinctrl-cherryview.c | 21 +++-- 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/drivers/pinctrl/intel

[PATCH v3 0/3] gpio / pinctrl: cherryview: Fix missing events from EC

2016-09-20 Thread Mika Westerberg
ust return if gpiochip_irqchip_exclude_irq() fails (and also this simplifies the driver). Mika Westerberg (3): gpiolib: Make it possible to exclude GPIOs from IRQ domain pinctrl: cherryview: Do not add all southwest and north GPIOs to IRQ domain pinctrl: cherryview: Convert to use devm_gpio

[PATCH v3 1/3] gpiolib: Make it possible to exclude GPIOs from IRQ domain

2016-09-20 Thread Mika Westerberg
gpiochip_irqchip_add() is called, this mask is checked and all GPIOs with bit is set are added to the IRQ domain created for the GPIO chip. Suggested-by: Linus Walleij Signed-off-by: Mika Westerberg --- Documentation/gpio/driver.txt | 6 drivers/gpio/gpiolib.c| 66

[PATCH v2 0/4] ACPI / watchdog: Add support for WDAT (Watchdog Action Table)

2016-09-20 Thread Mika Westerberg
/gg463320.aspx [2] https://msdn.microsoft.com/en-us/openspecifications/dn646766.aspx [3] http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1230607.html Mika Westerberg (4): ACPI / watchdog: Add support for WDAT hardware watchdog mfd: lpc_ich: Do not create iTCO watchdog when WDAT table

[PATCH v2 3/4] i2c: i801: Do not create iTCO watchdog when WDAT table exists

2016-09-20 Thread Mika Westerberg
table. Signed-off-by: Mika Westerberg Reviewed-by: Guenter Roeck --- drivers/i2c/busses/i2c-i801.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index 5ef9b733d153..26298af73232 100644 --- a/drivers/i2c/busses

[PATCH v2 2/4] mfd: lpc_ich: Do not create iTCO watchdog when WDAT table exists

2016-09-20 Thread Mika Westerberg
table. Signed-off-by: Mika Westerberg Reviewed-by: Guenter Roeck --- drivers/mfd/lpc_ich.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c index bd3aa4578346..c8dee47b45d9 100644 --- a/drivers/mfd/lpc_ich.c +++ b/drivers/mfd/lpc_ich.c

[PATCH v2 1/4] ACPI / watchdog: Add support for WDAT hardware watchdog

2016-09-20 Thread Mika Westerberg
not loaded. Signed-off-by: Mika Westerberg --- drivers/acpi/Kconfig | 3 + drivers/acpi/Makefile| 1 + drivers/acpi/acpi_watchdog.c | 123 ++ drivers/acpi/internal.h | 10 + drivers/acpi/scan.c | 1 + drivers/watchdog/Kconfig | 13 ++ drivers

[PATCH v2 4/4] platform/x86: intel_pmc_ipc: Do not create iTCO watchdog when WDAT table exists

2016-09-20 Thread Mika Westerberg
WDAT table. Signed-off-by: Mika Westerberg Reviewed-by: Guenter Roeck --- drivers/platform/x86/intel_pmc_ipc.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c index b86e1bcaa055

Re: iTCO_wdt watchdog on Asus P10S-WS motherboard FREEZES MOTHERBOARD COMPLETELY

2016-09-20 Thread Mika Westerberg
On Thu, Sep 08, 2016 at 07:01:09PM +0200, David Madore wrote: > TL;DR: the iTCO_wdt watchdog on the Asus P10S-WS motherboard, instead > of rebooting the machine, places the motherboard in a completely > nonfunctional state, from which it can be revived only by a hard power > cycle. I suspect this

Re: [PATCH v2 1/4] ACPI / watchdog: Add support for WDAT hardware watchdog

2016-09-20 Thread Mika Westerberg
On Tue, Sep 20, 2016 at 06:37:23AM -0700, Guenter Roeck wrote: > > + for (i = 0; i < tbl->entries; i++) { > > + const struct acpi_generic_address *gas; > > + struct wdat_instruction *instr; > > + struct list_head *instructions; > > + unsigned int action; >

[PATCH v2] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter

2016-09-20 Thread Mika Westerberg
for GSI 37 To fix this we pass the I2C adapter to i2c_acpi_get_info() and make sure the handle matches the one in the I2cSerialBus() resource before doing anything else to the device. Reported-and-tested-by: Nicolai Stange Signed-off-by: Mika Westerberg --- Changes from v1: * Require that AC

Re: [PATCH v2] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter

2016-09-21 Thread Mika Westerberg
On Wed, Sep 21, 2016 at 07:48:35AM +0200, Wolfram Sang wrote: > On Tue, Sep 20, 2016 at 04:59:25PM +0300, Mika Westerberg wrote: > > When enumerating I2C devices connected to an I2C adapter we scan the whole > > namespace (as it is possible to have devices anywhere in that namespac

Re: Cherryview wake up events

2016-09-21 Thread Mika Westerberg
On Tue, Sep 20, 2016 at 11:11:53PM +0200, Johannes Stezenbach wrote: > On Tue, Sep 20, 2016 at 05:59:43PM +0200, Johannes Stezenbach wrote: > > On Tue, Sep 20, 2016 at 01:40:14PM +0300, Mika Westerberg wrote: > > > If yes, it probably does not have the normal Fixed power button

Re: [PATCH v2] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter

2016-09-22 Thread Mika Westerberg
On Wed, Sep 21, 2016 at 06:14:38PM +0200, Wolfram Sang wrote: > On Wed, Sep 21, 2016 at 11:45:02AM +0300, Mika Westerberg wrote: > > On Wed, Sep 21, 2016 at 07:48:35AM +0200, Wolfram Sang wrote: > > > On Tue, Sep 20, 2016 at 04:59:25PM +0300, Mika Westerberg wrote: > >

Re: [PATCH v2] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter

2016-09-22 Thread Mika Westerberg
On Thu, Sep 22, 2016 at 10:59:24AM +0200, Wolfram Sang wrote: > > > > Huh? It doesn't apply on top of rc7 here? What did you base it on? > > > > It is based on linux-next as it is on top of Jarkko's I2C ACPI namespace > > cleanup patches. I'm wondering if I make an updated patch on top of > > v4.

Re: [PATCH v2] gpio: add Intel WhiskeyCove GPIO driver

2016-06-20 Thread Mika Westerberg
On Sun, Jun 19, 2016 at 08:54:32PM -0700, Bin Gao wrote: > > > +#define DRV_NAME "bxt_wcove_gpio" > > > > Drop this. > We have _TWO_ places using DRV_NAME(near the end of the file): > static struct platform_driver wcove_gpio_driver = { >.driver = { >.name = DRV_NAME, >

Re: [PATCH v3] gpio: sch: Fix Oops on module load on Asus Eee PC 1201

2016-06-20 Thread Mika Westerberg
s advice (https://lkml.org/lkml/2016/5/9/61) and > consists in modifying sch_gpio_reg_get and sch_gpio_reg_set to take a > sch_gpio struct directly instead of a gpio_chip, which avoids the call to > gpiochip_get_data. > > Thanks Mika for your patience with me :-) > > Signed-

Re: [PATCH v4 1/2] i2c: qup: add ACPI support

2016-06-20 Thread Mika Westerberg
On Sat, Jun 18, 2016 at 04:10:34PM +0200, Wolfram Sang wrote: > On Wed, Jun 08, 2016 at 12:19:44PM -0600, Austin Christ wrote: > > From: Naveen Kaje > > > > Add support to get the device parameters from ACPI. Assume > > that the clocks are managed by firmware. > > Adding Mika to CC: Can you have

Re: [PATCH] HID: i2c-hid: set power sleep before shutdown

2016-06-20 Thread Mika Westerberg
On Sat, Jun 18, 2016 at 06:50:30PM +0800, Guohua Zhong wrote: > Add i2c_hid_shutdown for i2c-hid driver to send suspend cmd & > disable irq before device shutdown. > > Some HW design is that the power to i2c hid device won't down > after device shutdown. Also the i2c-hid driver do not send suspend

Re: [PATCH v3 1/5] ACPICA: Namespace: Fix a regression that MLC support triggers dead lock in dynamic table loading

2016-06-20 Thread Mika Westerberg
r-table execution of module-level code > This patch fixes this regression by unlocking the interpreter lock before > invoking MLC. However the unlocking is done to the acpi_ns_load_table(), in > which, the interpreter lock should be locked by acpi_ns_parse_table() but > wasn'

Re: [PATCH v4 1/2] i2c: qup: add ACPI support

2016-06-20 Thread Mika Westerberg
On Mon, Jun 20, 2016 at 10:00:46AM -0500, Timur Tabi wrote: > Mika Westerberg wrote: > > Use has_acpi_companion() if you need to. > > Is has_acpi_companion() the preferred alternative to ACPI_HANDLE()? We > frequently need to write code that does something different on ACPI

Re: [PATCH v3 2/3] x86/platform/p2sb: New Primary to Sideband bridge support driver for Intel SOC's

2016-06-21 Thread Mika Westerberg
On Tue, Jun 21, 2016 at 05:03:20AM +, Tan, Jui Nee wrote: > > Maybe, or make it modular and use MODULE_DEVICE_TABLE(x86cpu, ...) to > > match the corresponding CPUs. > > We need CONFIG_X86_INTEL_NON_ACPI Kconfig option to select CONFIG_PINCTRL. > This is to solve kbuidbot complaint about kernel

Re: [PATCH v4 1/5] ACPICA: Namespace: Fix a regression that MLC support triggers dead lock in dynamic table loading

2016-06-21 Thread Mika Westerberg
r-table execution of module-level code > This patch fixes this regression by unlocking the interpreter lock before > invoking MLC. However the unlocking is done to the acpi_ns_load_table(), in > which, the interpreter lock should be locked by acpi_ns_parse_table() but > wasn'

Re: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device

2016-06-21 Thread Mika Westerberg
On Mon, Jun 20, 2016 at 12:38:58PM +0100, Adam Thomson wrote: > For device nodes in both DT and ACPI, it possible to have named > child nodes which contain properties (an existing example being > gpio-leds). This adds a function to find a named child node for > a device which can be used by drivers

Re: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device

2016-06-21 Thread Mika Westerberg
On Tue, Jun 21, 2016 at 11:50:01AM +, Opensource [Adam Thomson] wrote: > 21 June 2016 12:42, Rafael J. Wysocki wrote: > > > > > +static inline bool acpi_data_node_match(struct fwnode_handle *fwnode, > > > > + const char *name) > > > > +{ > > > > + re

Re: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device

2016-06-21 Thread Mika Westerberg
On Tue, Jun 21, 2016 at 01:42:16PM +0200, Rafael J. Wysocki wrote: > > > +static inline bool acpi_data_node_match(struct fwnode_handle *fwnode, > > > + const char *name) > > > +{ > > > + return is_acpi_data_node(fwnode) ? > > > + (!strcasecmp(to_acpi_data_nod

Re: Cherryview wake up events

2016-09-23 Thread Mika Westerberg
On Wed, Sep 21, 2016 at 11:16:35AM +0200, Johannes Stezenbach wrote: > On Wed, Sep 21, 2016 at 12:06:14PM +0300, Mika Westerberg wrote: > > On Tue, Sep 20, 2016 at 11:11:53PM +0200, Johannes Stezenbach wrote: > > > Or it is because the PNP0C40 device depends on GpioInt from PMIC

[PATCH 4/5] ACPI / property: Allow holes in reference properties

2016-09-23 Thread Mika Westerberg
means "no entry" or NULL reference. To support this we add a new function acpi_node_get_property_reference_fixed_args() that takes number of expected arguments as parameter. Function returns -ENOENT if the corresponding index resolves to the "no entry" reference. Signed-of

[PATCH 2/5] ACPI / gpio: Add support for naming GPIOs

2016-09-23 Thread Mika Westerberg
DT has property 'gpio-line-names' to name GPIO lines the controller has if present. Use this very same property in ACPI as well to provide nice names for the GPIOS. Signed-off-by: Mika Westerberg --- Documentation/acpi/gpio-properties.txt | 21 + drivers/gpio/gpio

[PATCH 5/5] ACPI / gpio: Allow holes in list of GPIOs for a device

2016-09-23 Thread Mika Westerberg
acpi_node_get_property_reference_fixed_args() instead. In addition we make acpi_gpio_package_count() to handle holes as well (this matches the DT version). Signed-off-by: Mika Westerberg --- Documentation/acpi/gpio-properties.txt | 15 +++ drivers/gpio/gpiolib-acpi.c| 32

[PATCH 1/5] ACPI / documentation: Use recommended name in GPIO property names

2016-09-23 Thread Mika Westerberg
The recommended property name for all kinds of GPIOs is to end it with "-gpios" even if there is only one GPIO. Update the documentation to follow this fact. Signed-off-by: Mika Westerberg --- Documentation/acpi/gpio-properties.txt | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH 3/5] ACPI / gpio: Add hogging support

2016-09-23 Thread Mika Westerberg
chanism to ACPI analogous to Device Tree. Signed-off-by: Mika Westerberg --- Documentation/acpi/gpio-properties.txt | 26 drivers/gpio/gpiolib-acpi.c| 72 ++ 2 files changed, 98 insertions(+) diff --git a/Documentation/acpi/gpio-propert

[PATCH 0/5] ACPI / gpio: Updates to properties

2016-09-23 Thread Mika Westerberg
settings (which may be wrong as it knows nothing about which devices have been connected). Mika Westerberg (5): ACPI / documentation: Use recommended name in GPIO property names ACPI / gpio: Add support for naming GPIOs ACPI / gpio: Add hogging support ACPI / property: Allow holes in

Re: [PATCH v3 2/3] pinctrl: cherryview: Do not add all southwest and north GPIOs to IRQ domain

2016-09-23 Thread Mika Westerberg
On Fri, Sep 23, 2016 at 02:58:47PM +0200, Linus Walleij wrote: > On Tue, Sep 20, 2016 at 2:15 PM, Mika Westerberg > wrote: > > > It turns out that for north and southwest communities, they can only > > generate GPIO interrupts for lower 8 interrupts (IntSel value). The uppe

Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe

2016-09-08 Thread Mika Westerberg
On Thu, Sep 08, 2016 at 06:13:03PM +0800, Phidias Chiang wrote: > On Thu, Aug 18, 2016 at 04:58:13PM +0300, Mika Westerberg wrote: > > On Thu, Aug 18, 2016 at 03:52:57PM +0200, Anisse Astier wrote: > > > On Thu, Aug 18, 2016 at 2:13 PM, Mika Westerberg > > > wrote: >

Re: [RFC PATCH] gpio/gpiolib: Forbid irqchip default trigger if probed over DT

2016-09-08 Thread Mika Westerberg
On Thu, Sep 08, 2016 at 12:13:27AM +0200, Linus Walleij wrote: > On Tue, Sep 6, 2016 at 3:59 PM, Marc Zyngier wrote: > > > Using a default trigger is a bad idea if using DT to configure > > interrupts, as the device's interrupt specifier will always contain > > the trigger configuration. > > > >

Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe

2016-09-08 Thread Mika Westerberg
On Fri, Sep 09, 2016 at 12:28:43AM +0800, Phidias Chiang wrote: > On Thu, Sep 08, 2016 at 01:24:02PM +0300, Mika Westerberg wrote: > > On Thu, Sep 08, 2016 at 06:13:03PM +0800, Phidias Chiang wrote: > > > On Thu, Aug 18, 2016 at 04:58:13PM +0300, Mika Westerberg wrote: > >

Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe

2016-09-09 Thread Mika Westerberg
On Fri, Sep 09, 2016 at 04:23:58PM +0800, Phidias Chiang wrote: > On Fri, Sep 09, 2016 at 09:18:34AM +0300, Mika Westerberg wrote: > > On Fri, Sep 09, 2016 at 12:28:43AM +0800, Phidias Chiang wrote: > > > > Hmm, how can that happen? The patch removes clearing of INTMASK and

Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe

2016-09-13 Thread Mika Westerberg
On Tue, Sep 13, 2016 at 11:18:49AM +0200, Linus Walleij wrote: > On Mon, Sep 12, 2016 at 3:11 PM, Mika Westerberg > wrote: > > On Mon, Sep 12, 2016 at 09:04:44PM +0800, Phidias Chiang wrote: > >> On Mon, Sep 12, 2016 at 12:04:01PM +0300, Mika Westerberg wrote: > >&

Re: [RESEND RFC PATCH 0/5] platform drivers for UP Board

2016-09-13 Thread Mika Westerberg
On Tue, Sep 13, 2016 at 12:42:52PM +0300, Andy Shevchenko wrote: > On Mon, 2016-07-04 at 17:07 +0100, Dan O'Donovan wrote: > > [Re-sending to a wider audience suggested by Darren Hart] > > > > The UP Board is a new SBC based on the Intel Atom X5-Z8350 "Cherry  > > Trail" SoC and features a 40-pin

Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe

2016-09-13 Thread Mika Westerberg
On Tue, Sep 13, 2016 at 02:22:25PM +0200, Linus Walleij wrote: > On Tue, Sep 13, 2016 at 11:33 AM, Mika Westerberg > wrote: > > On Tue, Sep 13, 2016 at 11:18:49AM +0200, Linus Walleij wrote: > >> On Mon, Sep 12, 2016 at 3:11 PM, Mika Westerberg > >> wrote: > &

[PATCH 0/4] ACPI: Add support for WDAT (Watchdog Action Table)

2016-09-13 Thread Mika Westerberg
watchdog (WDAT) should be used instead. [1] http://msdn.microsoft.com/en-us/windows/hardware/gg463320.aspx [2] https://msdn.microsoft.com/en-us/openspecifications/dn646766.aspx Mika Westerberg (4): ACPI / watchdog: Add support for WDAT hardware watchdog mfd: lpc_ich: Do not create iTCO watchdog

[PATCH 2/4] mfd: lpc_ich: Do not create iTCO watchdog when WDAT table exists

2016-09-13 Thread Mika Westerberg
table. Signed-off-by: Mika Westerberg --- drivers/mfd/lpc_ich.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c index bd3aa4578346..c8dee47b45d9 100644 --- a/drivers/mfd/lpc_ich.c +++ b/drivers/mfd/lpc_ich.c @@ -984,6 +984,10 @@ static int

[PATCH 4/4] platform/x86: intel_pmc_ipc: Do not create iTCO watchdog when WDAT table exists

2016-09-13 Thread Mika Westerberg
WDAT table. Signed-off-by: Mika Westerberg --- drivers/platform/x86/intel_pmc_ipc.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c index b86e1bcaa055..a511d518206b 100644 --- a/drivers

[PATCH 1/4] ACPI / watchdog: Add support for WDAT hardware watchdog

2016-09-13 Thread Mika Westerberg
not loaded. Signed-off-by: Mika Westerberg --- drivers/acpi/Kconfig | 16 ++ drivers/acpi/Makefile| 2 + drivers/acpi/acpi_watchdog.c | 123 ++ drivers/acpi/internal.h | 10 + drivers/acpi/scan.c | 1 + drivers/acpi/wdat_wdt.c | 524

[PATCH 3/4] i2c: i801: Do not create iTCO watchdog when WDAT table exists

2016-09-13 Thread Mika Westerberg
table. Signed-off-by: Mika Westerberg --- drivers/i2c/busses/i2c-i801.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index 5ef9b733d153..26298af73232 100644 --- a/drivers/i2c/busses/i2c-i801.c +++ b/drivers

Re: [PATCH 1/4] ACPI / watchdog: Add support for WDAT hardware watchdog

2016-09-14 Thread Mika Westerberg
On Tue, Sep 13, 2016 at 02:00:25PM -0700, Guenter Roeck wrote: > On 09/13/2016 08:23 AM, Mika Westerberg wrote: > > Starting from Intel Skylake the iTCO watchdog timer registers were moved to > > reside in the same register space with SMBus host controller. Not all > >

Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe

2016-09-14 Thread Mika Westerberg
On Tue, Sep 13, 2016 at 10:57:31PM +0200, Linus Walleij wrote: > On Tue, Sep 13, 2016 at 2:52 PM, Mika Westerberg > wrote: > > [Me] > >> A-ha! But why are you registering a irqdomain entry for an interrupt > >> that cannot be used, hm? > > > > Unfortunat

Re: [PATCH v2 0/8] PCI: pciehp: Rework hotplug interrupt routine

2016-09-14 Thread Mika Westerberg
rs/pci/hotplug/pciehp_ctrl.c | 83 - > drivers/pci/hotplug/pciehp_hpc.c | 94 > - > 2 files changed, 82 insertions(+), 95 deletions(-) I don't have any machines with native PCIe hotplug support enabled but regardless the series looks good to me, Reviewed-by: Mika Westerberg

Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe

2016-09-14 Thread Mika Westerberg
On Wed, Sep 14, 2016 at 02:46:01PM +0200, Linus Walleij wrote: > > I'm going to re-read the hardware spec and see if there is anything we > > can do about this. The newer hardware (Skylake, Broxton) has a bit that > > tells the IRQ is routed directly to I/O-APIC but unfortunately Braswell > > misse

Re: [PATCH 1/4] ACPI / watchdog: Add support for WDAT hardware watchdog

2016-09-14 Thread Mika Westerberg
On Wed, Sep 14, 2016 at 07:54:34AM -0700, Guenter Roeck wrote: > On 09/14/2016 01:06 AM, Mika Westerberg wrote: > > On Tue, Sep 13, 2016 at 02:00:25PM -0700, Guenter Roeck wrote: > > > On 09/13/2016 08:23 AM, Mika Westerberg wrote: > > > > Starting from Intel S

Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe

2016-09-15 Thread Mika Westerberg
On Thu, Sep 15, 2016 at 02:39:47PM +0200, Linus Walleij wrote: > On Wed, Sep 14, 2016 at 5:12 PM, Mika Westerberg > wrote: > > On Wed, Sep 14, 2016 at 02:46:01PM +0200, Linus Walleij wrote: > >> > I'm going to re-read the hardware spec and see if there is anything we

[PATCH 1/2] gpiolib: Add possibility to mask which GPIOs are added to IRQ domain

2016-09-15 Thread Mika Westerberg
. To make this possible we add valid_mask to each gpio_chip and by default assume all GPIOs can be used as interrupts. Drivers can then tune this using clear_bit() or similar before they call gpiochip_irqchip_add(). Suggested-by: Linus Walleij Signed-off-by: Mika Westerberg --- drivers/gpio

[PATCH 2/2] pinctrl: cherryview: Do not add all southwest and north GPIOs to IRQ domain

2016-09-15 Thread Mika Westerberg
with the GPE in question set. To make this all work as expected we only add those GPIOs to the IRQ domain that can actually generate interrupts (IntSel value 0-7) and skip others. Reported-by: Phidias Chiang Signed-off-by: Mika Westerberg --- Hi Phidias and Anisse, Can you try this series out? It

Re: [PATCH 1/2] gpiolib: Add possibility to mask which GPIOs are added to IRQ domain

2016-09-15 Thread Mika Westerberg
On Thu, Sep 15, 2016 at 05:07:58PM +0100, Marc Zyngier wrote: > Mika, > > On 15/09/16 16:52, Mika Westerberg wrote: > > When using GPIO irqchip helpers to setup irqchip for a gpiolib based > > driver, it is not possible to select which GPIOs to add to the IRQ domain. > &g

Re: [PATCH] thunderbolt: fix incorrect value assigned to req->response_type

2017-08-16 Thread Mika Westerberg
On Tue, Aug 15, 2017 at 06:22:59PM +0300, Dan Carpenter wrote: > On Tue, Aug 15, 2017 at 05:38:34PM +0300, Mika Westerberg wrote: > > On Tue, Aug 15, 2017 at 03:31:33PM +0100, Colin King wrote: > > > From: Colin Ian King > > > > > > req->res

Re: [PATCH] thunderbolt: fix incorrect value assigned to req->response_type

2017-08-17 Thread Mika Westerberg
On Wed, Aug 16, 2017 at 09:13:27AM -0700, Greg Kroah-Hartman wrote: > On Wed, Aug 16, 2017 at 11:10:01AM +0300, Mika Westerberg wrote: > > On Tue, Aug 15, 2017 at 06:22:59PM +0300, Dan Carpenter wrote: > > > On Tue, Aug 15, 2017 at 05:38:34PM +0300, Mika Westerberg wrote: >

[PATCH 1/2] pinctrl: intel: Add Intel Cannon Lake PCH-H pin controller support

2017-08-18 Thread Mika Westerberg
This is desktop version Intel Cannon Lake PCH. The GPIO hardware is the same but pin list differs a bit. Add support for this to the existing Cannon Lake pin controller driver. Signed-off-by: Andy Shevchenko Signed-off-by: Mika Westerberg --- drivers/pinctrl/intel/pinctrl-cannonlake.c | 424

[PATCH 2/2] pinctrl: intel: Add Intel Lewisburg GPIO support

2017-08-18 Thread Mika Westerberg
Intel Lewisburg has the same GPIO hardware than Intel Sunrisepoint-H except few differences in register offsets and pin lists. Because of this we add a separate pinctrl driver for Lewisburg. Signed-off-by: Mika Westerberg --- drivers/pinctrl/intel/Kconfig | 8 + drivers/pinctrl

Re: [PATCH 2/6] ACPI / PM: Consolidate device wakeup settings code

2017-06-22 Thread Mika Westerberg
On Mon, Jun 19, 2017 at 11:33:52PM +0200, Rafael J. Wysocki wrote: > -#ifdef CONFIG_PM_SLEEP > -/** > - * acpi_pm_device_sleep_wake - Enable or disable device to wake up the > system. > - * @dev: Device to enable/desible to wake up the system from sleep states. > - * @enable: Whether to enable or

Re: [PATCH 0/6] PM: Unify the handling of device wakeup settings

2017-06-22 Thread Mika Westerberg
t tree in a couple of days. Apart from that one minor comment, this looks good to me. I'm happy that we get rid of those run_wake things which I always find really confusing :) For the whole series, Reviewed-by: Mika Westerberg

[PATCH v2 26/27] thunderbolt: Add documentation how Thunderbolt bus can be used

2017-05-26 Thread Mika Westerberg
Since there are no such tool yet that handles all the low-level details of connecting devices and upgrading their firmware, add a small document that shows how the Thunderbolt bus can be used directly from command line. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by

[PATCH v2 07/27] thunderbolt: Allow passing NULL to tb_ctl_free()

2017-05-26 Thread Mika Westerberg
Following the usual pattern used in many places, we allow passing NULL pointer to tb_ctl_free(). Then the user can call the function regardless if it has allocated control channel or not making the code bit simpler. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/ctl.c | 4 1 file

[PATCH v2 27/27] MAINTAINERS: Add maintainers for Thunderbolt driver

2017-05-26 Thread Mika Westerberg
We will be helping Andreas to maintain the Thunderbolt driver. Signed-off-by: Michael Jamet Signed-off-by: Yehezkel Bernat Signed-off-by: Mika Westerberg Reviewed-by: Andy Shevchenko --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH v2 19/27] thunderbolt: Add new Thunderbolt PCI IDs

2017-05-26 Thread Mika Westerberg
Add Intel Win Ridge (Thunderbolt 2) and Alpine Ridge (Thunderbolt 3) controller PCI IDs to the list of supported devices. This code is based on the work done by Amir Levy and Michael Jamet. Signed-off-by: Michael Jamet Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by

[PATCH v2 01/27] thunderbolt: Use const buffer pointer in write operations

2017-05-26 Thread Mika Westerberg
These functions should not (and do not) modify the argument in any way so make it const. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Michael Jamet Reviewed-by: Greg Kroah-Hartman Reviewed-by: Andy Shevchenko --- drivers/thunderbolt/ctl.c | 8 drivers

[PATCH v2 03/27] thunderbolt: Do not try to read UID if DROM offset is read as 0

2017-05-26 Thread Mika Westerberg
At least Falcon Ridge when in host mode does not have any kind of DROM available and reading DROM offset returns 0 for these. Do not try to read DROM any further in that case. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Michael Jamet Reviewed-by: Andy Shevchenko

[PATCH v2 25/27] thunderbolt: Add support for host and device NVM firmware upgrade

2017-05-26 Thread Mika Westerberg
NVM firmware image and triggering power cycle. This code is based on the work done by Amir Levy and Michael Jamet. Signed-off-by: Michael Jamet Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Andy Shevchenko --- Documentation/ABI/testing/sysfs-bus-thunderbolt | 26

[PATCH v2 09/27] thunderbolt: Convert switch to a device

2017-05-26 Thread Mika Westerberg
implementation used on Macs. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Michael Jamet Reviewed-by: Andy Shevchenko --- Documentation/ABI/testing/sysfs-bus-thunderbolt | 20 ++ drivers/thunderbolt/eeprom.c| 2 + drivers/thunderbolt/switch.c

[PATCH v2 08/27] thunderbolt: Introduce thunderbolt bus and connection manager

2017-05-26 Thread Mika Westerberg
abstract connection manager specific operations into a new structure tb_cm_ops and convert the existing tb.c to fill those accordingly. This makes it easier to add support for the internal connection manager in subsequent patches. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat

[PATCH v2 13/27] thunderbolt: Read vendor and device name from DROM

2017-05-26 Thread Mika Westerberg
The device DROM contains name of the vendor and device among other things. Extract this information and expose it to the userspace via two new attributes. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Michael Jamet --- Documentation/ABI/testing/sysfs-bus-thunderbolt

[PATCH v2 12/27] thunderbolt: Refactor and fix parsing of port drom entries

2017-05-26 Thread Mika Westerberg
tb_drom_parse_entries() to accommodate for parsing of other entry types than TB_DROM_ENTRY_PORT. Signed-off-by: Lukas Wunner Signed-off-by: Mika Westerberg --- drivers/thunderbolt/eeprom.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers

[PATCH v2 00/27] Thunderbolt security levels and NVM firmware upgrade

2017-05-26 Thread Mika Westerberg
() for nvm_ida in the same way we do for tb_domain_ida. - Always add nvm_version and nvm_authenticate attributes but their visibility is determined by the existense of sw->dma_port. [1] https://lkml.org/lkml/2016/11/9/341 [2] http://git.infradead.org/users/hch/vfs.git/shortlog/refs/he

Re: [PATCH 1/8] i2c: rename core source file to allow refactorization

2017-05-26 Thread Mika Westerberg
object name constant to avoid regressions. > > Signed-off-by: Wolfram Sang Reviewed-by: Mika Westerberg

[PATCH v2 20/27] thunderbolt: Add support for NHI mailbox

2017-05-26 Thread Mika Westerberg
The host controller includes two sets of registers that are used to communicate with the firmware. Add functions that can be used to access these registers. This code is based on the work done by Amir Levy and Michael Jamet. Signed-off-by: Michael Jamet Signed-off-by: Mika Westerberg Reviewed

[PATCH v2 18/27] thunderbolt: Rework control channel to be more reliable

2017-05-26 Thread Mika Westerberg
no need to take the global domain lock when sending configuration packets anymore. This is useful when we add support for cross-domain (XDomain) communication later on. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Michael Jamet Reviewed-by: Andy Shevchenko

[PATCH v2 23/27] thunderbolt: Do not touch the hardware if the NHI is gone on resume

2017-05-26 Thread Mika Westerberg
check it before we re-enable rings. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Michael Jamet Reviewed-by: Andy Shevchenko --- drivers/thunderbolt/nhi.c | 12 drivers/thunderbolt/nhi.h | 3 +++ 2 files changed, 15 insertions(+) diff --git a/drivers

[PATCH v2 22/27] thunderbolt: Add support for DMA configuration based mailbox

2017-05-26 Thread Mika Westerberg
sed on the work done by Amir Levy and Michael Jamet. Signed-off-by: Michael Jamet Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Andy Shevchenko --- drivers/thunderbolt/Makefile | 2 +- drivers/thunderbolt/dma_port.c |

[PATCH v2 24/27] thunderbolt: Add support for Internal Connection Manager (ICM)

2017-05-26 Thread Mika Westerberg
based on the work done by Amir Levy and Michael Jamet. Signed-off-by: Michael Jamet Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Andy Shevchenko --- Documentation/ABI/testing/sysfs-bus-thunderbolt | 48 + drivers/thunderbolt/Kconfig | 12 +-

[PATCH v2 16/27] thunderbolt: Expose make_header() to other files

2017-05-26 Thread Mika Westerberg
We will be using this function in files introduced in subsequent patches. While there the function is renamed to tb_cfg_make_header() following tb_cfg_get_route(). Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Michael Jamet Reviewed-by: Andy Shevchenko --- drivers

[PATCH v2 21/27] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-26 Thread Mika Westerberg
. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Michael Jamet --- drivers/thunderbolt/switch.c | 50 +--- drivers/thunderbolt/tb.h | 2 ++ 2 files changed, 35 insertions(+), 17 deletions(-) diff --git a/drivers/thunderbolt

[PATCH v2 11/27] thunderbolt: Do not fail if DROM data CRC32 is invalid

2017-05-26 Thread Mika Westerberg
. We still keep the warning there. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Michael Jamet Reviewed-by: Andy Shevchenko --- drivers/thunderbolt/eeprom.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/thunderbolt/eeprom.c b/drivers

[PATCH v2 14/27] thunderbolt: Move control channel messages to tb_msgs.h

2017-05-26 Thread Mika Westerberg
changes intended. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Michael Jamet Reviewed-by: Andy Shevchenko --- drivers/thunderbolt/ctl.c | 76 - drivers/thunderbolt/ctl.h | 16 +-- drivers/thunderbolt/tb_msgs.h | 108

Re: [PATCH 5/8] i2c: break out ACPI support into seperate file

2017-05-26 Thread Mika Westerberg
On Fri, May 26, 2017 at 10:20:56AM +0200, Wolfram Sang wrote: > Removes some ifdeffery. Also add the new file to the relevant > MAINTAINERS section. > > Signed-off-by: Wolfram Sang Reviewed-by: Mika Westerberg

[PATCH v2 17/27] thunderbolt: Let the connection manager handle all notifications

2017-05-26 Thread Mika Westerberg
connection manager implementation. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Michael Jamet Reviewed-by: Andy Shevchenko --- drivers/thunderbolt/ctl.c| 86 ++-- drivers/thunderbolt/ctl.h| 5 +-- drivers/thunderbolt

[PATCH v2 15/27] thunderbolt: Expose get_route() to other files

2017-05-26 Thread Mika Westerberg
We are going to use it when we change the connection manager to handle events itself. Also rename it to follow naming convention used in functions exposed in ctl.h. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Michael Jamet Reviewed-by: Andy Shevchenko --- drivers

[PATCH v2 05/27] thunderbolt: Add MSI-X support

2017-05-26 Thread Mika Westerberg
tb_nhi to follow kernel-doc format more closely. This code is based on the work done by Amir Levy and Michael Jamet. Signed-off-by: Michael Jamet Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Andy Shevchenko --- drivers/thunderbolt/ctl.c | 4 +- drivers

[PATCH v2 10/27] thunderbolt: Fail switch adding operation if reading DROM fails

2017-05-26 Thread Mika Westerberg
-coded. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Michael Jamet Reviewed-by: Andy Shevchenko --- drivers/thunderbolt/switch.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c index

[PATCH v2 04/27] thunderbolt: Do not warn about newer DROM versions

2017-05-26 Thread Mika Westerberg
DROM version 2 is compatible with the previous generation so no need to warn about that. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Michael Jamet Reviewed-by: Andy Shevchenko --- drivers/thunderbolt/eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v2 06/27] thunderbolt: Rework capability handling

2017-05-26 Thread Mika Westerberg
capabilities for ports and switches. Then convert the current users over these. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Michael Jamet Reviewed-by: Andy Shevchenko --- drivers/thunderbolt/cap.c| 169 +-- drivers/thunderbolt

[PATCH v2 02/27] thunderbolt: No need to read UID of the root switch on resume

2017-05-26 Thread Mika Westerberg
The root switch is part of the host controller and cannot be physically removed, so there is no point of reading UID again on resume in order to check if the root switch is still the same. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/switch.c | 29 ++--- 1 file

<    1   2   3   4   5   6   7   8   9   10   >