Re: [PATCH v2 07/27] thunderbolt: Allow passing NULL to tb_ctl_free()

2017-05-28 Thread Mika Westerberg
On Sat, May 27, 2017 at 06:41:28PM +0300, Andy Shevchenko wrote: > On Fri, May 26, 2017 at 7:09 PM, Mika Westerberg > wrote: > > Following the usual pattern used in many places, we allow passing NULL > > pointer to tb_ctl_free(). Then the user can call the function regard

Re: [PATCH v2 09/27] thunderbolt: Convert switch to a device

2017-05-28 Thread Mika Westerberg
On Sat, May 27, 2017 at 06:45:24PM +0300, Andy Shevchenko wrote: > On Fri, May 26, 2017 at 7:09 PM, Mika Westerberg > wrote: > > Thunderbolt domain consists of switches that are connected to each > > other, forming a bus. This will convert each switch into a real Linux > &

Re: [PATCH v2 13/27] thunderbolt: Read vendor and device name from DROM

2017-05-28 Thread Mika Westerberg
On Sat, May 27, 2017 at 06:57:38PM +0300, Andy Shevchenko wrote: > On Fri, May 26, 2017 at 7:09 PM, Mika Westerberg > wrote: > > The device DROM contains name of the vendor and device among other > > things. Extract this information and expose it to the userspace via two

Re: [PATCH v2 22/27] thunderbolt: Add support for DMA configuration based mailbox

2017-05-28 Thread Mika Westerberg
On Sat, May 27, 2017 at 07:08:34PM +0300, Andy Shevchenko wrote: > On Fri, May 26, 2017 at 7:09 PM, Mika Westerberg > wrote: > > The DMA (NHI) port of a switch provides access to the NVM of the host > > controller (and devices starting from Intel Alpine Ridge). The NVM >

Re: [PATCH v2 24/27] thunderbolt: Add support for Internal Connection Manager (ICM)

2017-05-28 Thread Mika Westerberg
On Sat, May 27, 2017 at 11:45:21PM +0300, Andy Shevchenko wrote: > On Fri, May 26, 2017 at 7:09 PM, Mika Westerberg > wrote: > > > +static inline u8 dual_link_from_link(u8 link) > > +{ > > + return link ? ((link - 1) ^ 0x01) + 1 : 0; > > +}

Re: [PATCH] acpi: configfs: Unload SSDT on configfs entry removal

2017-05-29 Thread Mika Westerberg
On Mon, May 29, 2017 at 01:33:29PM +0200, Jan Kiszka wrote: > Enhance acpi_load_table to also return the table index. Use that index > to unload the table again when the corresponding directory in configfs > gets removed. This allows to change SSDTs without rebooting the system. > It also allows to

Re: Excessive logging in thunderbolt driver

2017-11-01 Thread Mika Westerberg
On Tue, Oct 31, 2017 at 10:45:46PM +0100, Stephen Hemminger wrote: > The thunderbolt driver needs to stop logging. > All these debug messages and the laptop is on battery with no devices > connected. > (I did use a USB key, but that is not a thunderbolt device). > > IMHO a production driver shoul

Re: [PATCH v2] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

2017-10-24 Thread Mika Westerberg
On Mon, Oct 23, 2017 at 11:59:39PM -0700, Bin Meng wrote: > The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform > data. Select it in the Kconfig. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: > - Enforce dependency on PCI > > drivers/mtd/spi-nor/Kconfig | 3 ++- > 1

Re: [PATCH] spi-nor: intel-spi: Remove EXPERT dependency

2017-10-24 Thread Mika Westerberg
superfluous hence remove it. > > Suggested-by: Arnd Bergmann > Signed-off-by: Bin Meng Acked-by: Mika Westerberg

[PATCH v3] PCI: pciehp: Check for valid PCI_BRIDGE_CONTROL in pciehp_unconfigure_device()

2017-10-24 Thread Mika Westerberg
read bctl value against 0x (device is not present anymore) before determining whether the device is a display or not. Signed-off-by: Mika Westerberg --- Hi Bjorn, This is an updated version of the patch 8/8 in my "PCI: Improvements for native PCIe hotplug" patch series and applies

[PATCH] thunderbolt: Drop sequence number check from tb_xdomain_match()

2017-10-25 Thread Mika Westerberg
k to macOS again, fix this so that we drop the whole sequence number check. This effectively works exactly the same than it worked before the aforementioned commit. This also follows the logic the original P2P networking code used. Signed-off-by: Mika Westerberg --- This applies on top of net-next.

[PATCH v4] PCI: pciehp: Drop checking of PCI_BRIDGE_CONTROL in pciehp_unconfigure_device()

2017-10-25 Thread Mika Westerberg
is what this patch does. Signed-off-by: Mika Westerberg --- The previous version of the patch can be found here: https://patchwork.kernel.org/patch/10024145/ Changes from the previous version: * Drop the whole PCI_BRIDGE_CONTROL check * Update patch subject to reflect that drivers/pci

Re: [PATCH] thunderbolt: tb: fix use after free in tb_activate_pcie_devices

2017-11-06 Thread Mika Westerberg
and connection > manager") > Signed-off-by: Gustavo A. R. Silva Good catch! Acked-by: Mika Westerberg Greg, can you pick this to your char-misc tree? Thanks. > --- > drivers/thunderbolt/tb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/thunderb

[PATCH] MAINTAINERS: Add git tree for Thunderbolt development

2017-11-06 Thread Mika Westerberg
I will be gathering Thunderbolt related patches to this git tree with help of other Thunderbolt maintainers. Signed-off-by: Mika Westerberg --- Hi Andreas and Greg, If you are fine, I can pick up Thunderbolt related patches to this tree and then forward them to Greg via pull requests or patch

Re: [PATCH v1 1/1] mtd: intel-spi: Add support for Intel Lewisburg SPI serial flash controller

2017-10-29 Thread Mika Westerberg
On Sun, Oct 29, 2017 at 11:09:50AM +0100, Marek Vasut wrote: > On 10/29/2017 10:57 AM, sathyanarayanan.kuppusw...@linux.intel.com wrote: > > From: Kuppuswamy Sathyanarayanan > > > > > > This patch adds PCI IDs for Intel Lewisburg PCH SPI serial flash controller. > > > > Signed-off-by: Kuppuswam

Re: [PATCH v1 1/1] mtd: intel-spi: Add support for Intel Lewisburg SPI serial flash controller

2017-10-29 Thread Mika Westerberg
On Sun, Oct 29, 2017 at 12:18:28PM -0700, Kuppuswamy, Sathyanarayanan wrote: > Mika, Shall I re-base this patch to add super SKU ID? Yes, please.

Re: [PATCH v2 1/1] mtd: intel-spi: Add Intel Lewisburg PCH SPI super SKU PCI ID

2017-10-30 Thread Mika Westerberg
On Sun, Oct 29, 2017 at 03:17:35PM -0700, sathyanarayanan.kuppusw...@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > This patch adds Intel Lewisburg PCH SPI serial flash controller super > SKU PCI ID. > > Signed-off-by: Kuppuswamy Sathyanarayanan > Acked-by: Mika Westerberg

Re: [PATCH v2 1/1] mtd: intel-spi: Add Intel Lewisburg PCH SPI super SKU PCI ID

2017-10-31 Thread Mika Westerberg
On Mon, Oct 30, 2017 at 03:28:46PM -0700, sathyanarayanan kuppuswamy wrote: > Hi, > > > On 10/30/2017 03:58 AM, Cyrille Pitchen wrote: > > Applied to the spi-nor/next branch of l2-mtd > > > > Just for info, this patch didn't apply directly, it misses a line in the > > list of > > PCI IDS: > >

Re: [Dell XPS 13 9343] Random kernel Oops at boot with "acpi=ht", disappearing with "acpi=off"

2015-10-05 Thread Mika Westerberg
On Sat, Oct 03, 2015 at 12:11:54PM +0200, Niccolò Belli wrote: > On venerdì 2 ottobre 2015 12:19:19 CEST, Mika Westerberg wrote: > >On Fri, Oct 02, 2015 at 11:59:38AM +0200, Niccolò Belli wrote: > >>Hi, > >>This laptop suffers of random kernel hangs at boot: I tested

Re: [Dell XPS 13 9343] Random kernel Oops at boot with "acpi=ht", disappearing with "acpi=off"

2015-10-05 Thread Mika Westerberg
On Mon, Oct 05, 2015 at 03:41:09PM +0200, Niccolò Belli wrote: > Il lunedì 5 ottobre 2015 12:46:45 CEST, Mika Westerberg ha scritto: > >On Sat, Oct 03, 2015 at 12:11:54PM +0200, Niccolò Belli wrote: > >>On venerdì 2 ottobre 2015 12:19:19 CEST, Mika Westerberg wrote: ... > >

[PATCH v2] HID: multitouch: Fetch feature reports on demand for Win8 devices

2015-10-07 Thread Mika Westerberg
preventing initial feature report retrieval for Win8 devices. Instead we fetch reports as needed in mt_feature_mapping(). This prevents fetching reports which might cause problems with the device in question. Suggested-by: Benjamin Tissoires Signed-off-by: Mika Westerberg --- Added check for MT_CLS_WIN_8

Re: [PATCH 1/2] i2c: scan entire ACPI namespace for I2C connections

2015-10-12 Thread Mika Westerberg
s controller, i2c-core.c:acpi_i2c_register_devices() as only > searching devices that are descendants of the bus controller. > > This change corrects acpi_i2c_register_devices() to walk the entire ACPI > namespace searching for I2C connections. > > Suggested-by: Mika Westerberg

Re: [PATCH 2/2] i2c: add ACPI support for I2C mux ports

2015-10-12 Thread Mika Westerberg
On Fri, Oct 09, 2015 at 05:41:47PM -0700, Dustin Byford wrote: > Although I2C mux devices are easily enumerated using ACPI (_HID/_CID or > device property compatible string match) enumerating I2C client devices > connected through a I2C mux device requires a little extra work. > > This change impl

Re: [PATCH 2/2] i2c: add ACPI support for I2C mux ports

2015-10-13 Thread Mika Westerberg
On Mon, Oct 12, 2015 at 11:32:31AM -0700, Dustin Byford wrote: > I've been trying to consider the options, perhaps you can help my > understanding. Using the i801 driver as an example, the device is PCI > and the companion is associated with the PCI dev. The driver creates > another device for th

Question related to patch: x86/irq: Remove x86_io_apic_ops.set_affinity and related interfaces

2015-09-08 Thread Mika Westerberg
Hi Jiang and Thomas, With recent kernels I'm getting crash when a GPIO interrupt triggers. For unknown reasons I'm not able to capture the crash on the serial console so I did following change to irq_move_masked_irq(): assert_raw_spin_locked(&desc->lock); to WARN_ON(!raw_spin_is

Re: Question related to patch: x86/irq: Remove x86_io_apic_ops.set_affinity and related interfaces

2015-09-08 Thread Mika Westerberg
On Tue, Sep 08, 2015 at 04:02:29PM +0200, Thomas Gleixner wrote: > On Tue, 8 Sep 2015, Mika Westerberg wrote: > > It says that there are no users for x86_io_apic_ops.set_affinity but then > > it does this: > > > > - x86_io_apic_ops.set_

Re: Question related to patch: x86/irq: Remove x86_io_apic_ops.set_affinity and related interfaces

2015-09-08 Thread Mika Westerberg
On Tue, Sep 08, 2015 at 04:25:44PM +0200, Thomas Gleixner wrote: > On Tue, 8 Sep 2015, Mika Westerberg wrote: > > > + chip = irq_data_get_chip(idata); > > > > There seems to be no irq_data_get_chip() helper in current mainline. So > > get_irq_chip

Re: [PATCH v2 1/4] i2c: designware-platdrv: enable RuntimePM before registering to the core

2015-10-15 Thread Mika Westerberg
On Thu, Oct 15, 2015 at 01:49:25PM +0200, Wolfram Sang wrote: > On Fri, Oct 09, 2015 at 10:39:24AM +0100, Wolfram Sang wrote: > > From: Wolfram Sang > > > > The core may register clients attached to this master which may use > > funtionality from the master. So, RuntimePM must be enabled before,

Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration

2015-10-21 Thread Mika Westerberg
On Wed, Oct 21, 2015 at 09:11:33AM +0800, Ken Xue wrote: > On Tue, 2015-10-20 at 14:17 +0300, Mika Westerberg wrote: > > On Tue, Oct 20, 2015 at 02:38:01PM +0800, Ken Xue wrote: > > > DW I2C driver tries to register a clk from id->driver_data as an > > > alternati

Re: [PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-21 Thread Mika Westerberg
On Wed, Oct 21, 2015 at 01:12:01AM +0200, Rafael J. Wysocki wrote: > Well, we already have that in the MFD case, but in principle it may be > problematic for things like power management (say you want to put a > child device into D3, so you use _PS3 on its ACPI companion and then > the parent is po

Re: [PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-21 Thread Mika Westerberg
On Tue, Oct 20, 2015 at 10:49:59AM -0700, Dustin Byford wrote: > I considered it, but I thought a default that fairly closely matches the > old behavior was more convenient. > > On the other hand, leaving it up to the controllers makes it all very > explicit and perhaps simpler to reason about. >

Re: [PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-21 Thread Mika Westerberg
On Wed, Oct 21, 2015 at 01:21:16AM -0700, Dustin Byford wrote: > On Wed Oct 21 11:12, Mika Westerberg wrote: > > On Tue, Oct 20, 2015 at 10:49:59AM -0700, Dustin Byford wrote: > > > I considered it, but I thought a default that fairly closely matches the > > > old b

Re: [PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-21 Thread Mika Westerberg
On Wed, Oct 21, 2015 at 01:52:41AM -0700, Dustin Byford wrote: > On Wed Oct 21 11:34, Mika Westerberg wrote: > > On Wed, Oct 21, 2015 at 01:21:16AM -0700, Dustin Byford wrote: > > > On Wed Oct 21 11:12, Mika Westerberg wrote: > > > > On Tue, Oct 20, 2015 at 10:49:5

Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration

2015-10-21 Thread Mika Westerberg
On Wed, Oct 21, 2015 at 04:42:23PM +0800, Ken Xue wrote: > On Wed, 2015-10-21 at 10:28 +0300, Mika Westerberg wrote: > > On Wed, Oct 21, 2015 at 09:11:33AM +0800, Ken Xue wrote: > > > On Tue, 2015-10-20 at 14:17 +0300, Mika Westerberg wrote: > > > > On Tue, Oct 20,

Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration

2015-10-21 Thread Mika Westerberg
On Wed, Oct 21, 2015 at 05:37:53PM +0800, Ken Xue wrote: > On Wed, 2015-10-21 at 12:25 +0300, Mika Westerberg wrote: > > On Wed, Oct 21, 2015 at 04:42:23PM +0800, Ken Xue wrote: > > > On Wed, 2015-10-21 at 10:28 +0300, Mika Westerberg wrote: > > > > On Wed, Oct 21,

Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration

2015-10-21 Thread Mika Westerberg
On Wed, Oct 21, 2015 at 05:50:02PM +0800, Ken Xue wrote: > After apd was accept in kernel V4.1, there is no issue. But between 3.18 > and V4.1, there will be a problem. We care about that because? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message t

[PATCH 2/3] pinctrl: intel: Allow requesting pins which are in ACPI mode as GPIOs

2015-10-21 Thread Mika Westerberg
their usage as interrupts. We also rename function intel_pad_reserved_for_acpi() to be intel_pad_acpi_mode() which reflects the actual meaning better. Signed-off-by: Mika Westerberg --- drivers/pinctrl/intel/pinctrl-intel.c | 16 1 file changed, 12 insertions(+), 4 deletions

[PATCH 0/3] pinctrl: Add support for Intel Broxton SoC

2015-10-21 Thread Mika Westerberg
specific pin configuration. Mika Westerberg (3): pinctrl: intel: Add support for multiple GPIO chips sharing the interrupt pinctrl: intel: Allow requesting pins which are in ACPI mode as GPIOs pinctrl: intel: Add Intel Broxton pin controller support drivers/pinctrl/intel/Kconfig |8

[PATCH 1/3] pinctrl: intel: Add support for multiple GPIO chips sharing the interrupt

2015-10-21 Thread Mika Westerberg
IRQF_SHARED with the flags. Signed-off-by: Mika Westerberg --- drivers/pinctrl/intel/pinctrl-intel.c | 52 +-- 1 file changed, 37 insertions(+), 15 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index

[PATCH 3/3] pinctrl: intel: Add Intel Broxton pin controller support

2015-10-21 Thread Mika Westerberg
This driver adds pinctrl/GPIO support for Intel Broxton. The GPIO controller is based on the same hardware design that is already used in Intel Sunrisepoint so we leverage the core driver here. Signed-off-by: Mika Westerberg --- drivers/pinctrl/intel/Kconfig |8 + drivers/pinctrl

Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration

2015-10-21 Thread Mika Westerberg
On Wed, Oct 21, 2015 at 05:50:02PM +0800, Ken Xue wrote: > On Wed, 2015-10-21 at 12:49 +0300, Mika Westerberg wrote: > > On Wed, Oct 21, 2015 at 05:37:53PM +0800, Ken Xue wrote: > > > On Wed, 2015-10-21 at 12:25 +0300, Mika Westerberg wrote: > > > > On Wed, Oct 21,

Re: [PATCH] ACPI / property: Fix subnode lookup scope for data-only subnodes

2015-10-21 Thread Mika Westerberg
property: Add support for data-only subnodes) > Signed-off-by: Rafael J. Wysocki Reviewed-by: Mika Westerberg All my tests still pass so you can also add Tested-by: Mika Westerberg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration

2015-10-20 Thread Mika Westerberg
On Tue, Oct 20, 2015 at 02:38:01PM +0800, Ken Xue wrote: > DW I2C driver tries to register a clk from id->driver_data as an > alternative way besides intel lpss. But code doesn't register the > clk to clkdev. So, devm_clk_get will fail during probe. > > The patch can fix this issue. Since you now

Re: [PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-20 Thread Mika Westerberg
On Mon, Oct 19, 2015 at 03:29:00PM -0700, Dustin Byford wrote: > Although I2C mux devices are easily enumerated using ACPI (_HID/_CID or > device property compatible string match) enumerating I2C client devices > connected through a I2C mux device requires a little extra work. > > This change impl

[PATCH 1/3] pwm: lpss: Add support for multiple PWMs

2015-10-20 Thread Mika Westerberg
New Intel SoCs such as Broxton will have four PWMs per PCI (or ACPI) device. Each PWM has 1k of register space allocated from the parent device. Add support for this. Signed-off-by: Mika Westerberg --- drivers/pwm/pwm-lpss.c | 48 +++- drivers/pwm/pwm

[PATCH 3/3] pwm: lpss: Add more Intel Broxton IDs

2015-10-20 Thread Mika Westerberg
Add more Intel Broxton ACPI and PCI IDs to the driver supported devices list. Signed-off-by: Mika Westerberg --- drivers/pwm/pwm-lpss-pci.c | 1 + drivers/pwm/pwm-lpss-platform.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/pwm/pwm-lpss-pci.c b/drivers/pwm/pwm-lpss-pci.c

[PATCH 2/3] pwm: lpss: Support all four PWMs on Intel Broxton

2015-10-20 Thread Mika Westerberg
Intel Broxton has similar PWM than Intel Braswell but instead of one it has four PWMs included in one PCI/ACPI device. This patch adds support for all the four PWMs and changes the PCI part of the driver to use 'pwm_lpss_bxt_info' instead. Signed-off-by: Mika Westerberg --- drivers/pw

Re: [PATCH 1/1] i2c: designware: reverts "i2c: designware: Add support for AMD I2C controller"

2015-10-23 Thread Mika Westerberg
AMD0010. clkdev is supposed > to be already registered in APD. > > So, revert old design and make AMD0010 looks like other ones. > > Signed-off-by: Ken Xue > Signed-off-by: Xiangliang Yu You could also mention that the commit never even worked. Anyway, I'm happy that this

Re: [PATCH v4 1/2] acpi: add acpi_preset_companion() stub

2015-10-23 Thread Mika Westerberg
turn false; > } > > +static inline void acpi_preset_companion(struct device *dev, > + struct acpi_device *parent, u64 addr) > +{ > + return; This return is not needed. Acked-by: Mika Westerberg > +} > + > static inline const c

Re: [PATCH v4 2/2] i2c: add ACPI support for I2C mux ports

2015-10-23 Thread Mika Westerberg
t; > Signed-off-by: Dustin Byford This looks good to me. You did also some stylistic changes to the drivers in question which I think should be placed to a separate patches. Regardless of that, Acked-by: Mika Westerberg I'll leave this up to Rafael and Wolfram to decide how to go fo

Re: [PATCH v4 2/2] i2c: add ACPI support for I2C mux ports

2015-10-23 Thread Mika Westerberg
On Fri, Oct 23, 2015 at 12:16:11PM +0200, Wolfram Sang wrote: > On Fri, Oct 23, 2015 at 11:40:13AM +0300, Mika Westerberg wrote: > > On Thu, Oct 22, 2015 at 02:17:42AM -0700, Dustin Byford wrote: > > > Although I2C mux devices are easily enumerated using ACPI (_HID/_CID or >

Re: [PATCH v4 2/2] i2c: add ACPI support for I2C mux ports

2015-10-23 Thread Mika Westerberg
On Fri, Oct 23, 2015 at 04:13:11PM +0300, Mika Westerberg wrote: > On Fri, Oct 23, 2015 at 12:16:11PM +0200, Wolfram Sang wrote: > > On Fri, Oct 23, 2015 at 11:40:13AM +0300, Mika Westerberg wrote: > > > On Thu, Oct 22, 2015 at 02:17:42AM -0700, Dustin Byford wrote: > &

[PATCH v3] pwm: lpss: Add support for runtime PM

2015-10-26 Thread Mika Westerberg
From: Qipeng Zha To be able to save some power when PWM is not in use, add support for runtime PM for this driver. This also allows the platform to transition to low power S0ix states when the system is idle. Signed-off-by: Huiquan Zhong Signed-off-by: Qipeng Zha Signed-off-by: Mika

[PATCH 1/2] genirq: Fix typo in documentation of enumeration field name

2015-10-01 Thread Mika Westerberg
It should say IRQ_NESTED_THREAD instead of IRQ_NESTED_TRHEAD. Signed-off-by: Mika Westerberg --- include/linux/irq.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/irq.h b/include/linux/irq.h index 11bf09288ddb..5c9a5281610f 100644 --- a/include/linux/irq.h

[PATCH 2/2] genirq: Remove unused functions irqd_[set|clr]_chained_irq_inprogress()

2015-10-01 Thread Mika Westerberg
These two functions are not used anywhere in the kernel source tree so remove them. Signed-off-by: Mika Westerberg --- include/linux/irq.h | 15 --- 1 file changed, 15 deletions(-) diff --git a/include/linux/irq.h b/include/linux/irq.h index 5c9a5281610f..6bcfe8ac7594 100644 --- a

CPU hotplug and chained interrupts on x86

2015-10-01 Thread Mika Westerberg
Hi Thomas, On Intel Braswell system (this affect others if they are using chained interrupts on x86) both CPUs can handle interrupts which trigger when GPIO line changes state if programmed to do so. We have SD-card card detection signal that is connected to a GPIO line: # cat /proc/interrupts

Re: CPU hotplug and chained interrupts on x86

2015-10-01 Thread Mika Westerberg
On Thu, Oct 01, 2015 at 11:45:23PM +0200, Thomas Gleixner wrote: > On Thu, 1 Oct 2015, Thomas Gleixner wrote: > > On Thu, 1 Oct 2015, Mika Westerberg wrote: > > > Now if I plug/unplug the card I may get few interrupts to CPU0 but rest > > > of the interrupts never happe

[PATCH 1/2] genirq: Introduce a new flag IRQ_IS_CHAINED for chained interrupts

2015-10-01 Thread Mika Westerberg
set by the core code when chained interrupt handler is installed. We also make it possible for core and architecture code to check the flag by introducing function irq_has_chained_handler() for this. Signed-off-by: Mika Westerberg --- include/linux/irq.h | 6 +- kernel/irq/chip.c | 11

[PATCH 2/2] x86/irq: Take chained interrupts into account in fixup_irqs()

2015-10-01 Thread Mika Westerberg
still contains both CPUs even if CPU1 is already offline. This means that the IO-APIC still routes interrupts to the other CPU as well. Fix this by correcting affinity also for interrupts that have chained handler installed. Signed-off-by: Mika Westerberg --- Discussion about the issue can be read

Re: [Dell XPS 13 9343] Random kernel Oops at boot with "acpi=ht", disappearing with "acpi=off"

2015-10-02 Thread Mika Westerberg
On Fri, Oct 02, 2015 at 11:59:38AM +0200, Niccolò Belli wrote: > Hi, > This laptop suffers of random kernel hangs at boot: I tested kernel 4.1.8, > 4.2.1 and 4.3-rc3 and they are all affected. > Every time I turn on my laptop I have to boot several times to be able to > reach the sddm login because

[PATCH v2] genirq: Allow migration of chained interrupts by installing default action

2015-10-05 Thread Mika Westerberg
ion != NULL). Also make the default action handler to emit a warning if for some reason a chained handler ends up calling it. Signed-off-by: Mika Westerberg --- I needed to declare chained_action in internals.h because otherwise chained IRQs get listed in /proc/interrupts. kernel/irq/chi

Re: [PATCH] PCI: shpchp: Fix probing logic inversion

2018-06-25 Thread Mika Westerberg
On Thu, Jun 21, 2018 at 05:47:15PM +0100, Marc Zyngier wrote: > Until recently, shpc_probe() would bail out pretty early in the > absence of the SHPC capability. A logic change in the way the > driver now checks that capability makes it go and probe the > firmware anyway, with ugly consequences if

Re: [PATCH] PCI: shpchp: Fix probing logic inversion

2018-06-25 Thread Mika Westerberg
On Mon, Jun 25, 2018 at 02:13:26PM +0100, Marc Zyngier wrote: > On 25/06/18 13:52, Mika Westerberg wrote: > > On Thu, Jun 21, 2018 at 05:47:15PM +0100, Marc Zyngier wrote: > >> Until recently, shpc_probe() would bail out pretty early in the > >> absence of the SHPC ca

Re: [PATCH] ACPI / LPSS: Avoid PM quirks on suspend and resume from hibernation

2018-07-26 Thread Mika Westerberg
and resume from > S3) > Link: https://bugs.launchpad.net/bugs/1774950 > Reported-by: Kai-Heng Feng > Cc: 4.15+ # 4.15+ > Signed-off-by: Rafael J. Wysocki Reviewed-by: Mika Westerberg

[PATCH 3/7] thunderbolt: Do not unnecessarily call ICM get route

2018-07-25 Thread Mika Westerberg
This command is not really fast and can make resume time slower. We only need to get route again if the link was changed and during initial device connected message. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/icm.c | 35 ++- 1 file changed, 26

[PATCH 2/7] thunderbolt: Use 64-bit DMA mask if supported by the platform

2018-07-25 Thread Mika Westerberg
PCI defaults to 32-bit DMA mask but this device is capable of full 64-bit addressing, so make sure we first try 64-bit DMA mask before falling back to the default 32-bit. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/nhi.c | 8 1 file changed, 8 insertions(+) diff --git a

[PATCH 5/7] thunderbolt: Use correct ICM commands in system suspend

2018-07-25 Thread Mika Westerberg
The correct way to put the ICM into suspend state is to send it NHI_MAILBOX_DRV_UNLOADS mailbox command. NHI_MAILBOX_SAVE_DEVS is not needed on Intel Titan Ridge so we can skip it. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/icm.c | 18 +- 1 file changed, 13

[PATCH 0/7] thunderbolt: Changes for v4.19 merge window

2018-07-25 Thread Mika Westerberg
t-for-v4.19 for you to fetch changes up to 33a7231d8ebbc4a4e05adcbc7ac053ad20dbc054: thunderbolt: Remove redundant variable 'approved' (2018-07-15 09:40:25 +0300) Colin Ian King (1): thunderbolt: Remove redundant variable 'approved' Mika Westerberg (5): thunderbol

[PATCH 7/7] thunderbolt: Remove redundant variable 'approved'

2018-07-25 Thread Mika Westerberg
From: Colin Ian King Variable 'approved' is being assigned but is never used hence it is redundant and can be removed. Cleans up clang warning: warning: variable 'approved' set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King Signed-off-by: Mika West

[PATCH 1/7] thunderbolt: Fix small typo in variable name

2018-07-25 Thread Mika Westerberg
From: Nathan Ciobanu Fixes small variable name typo and the associated checkpatch spelling warning. Signed-off-by: Nathan Ciobanu Signed-off-by: Mika Westerberg --- drivers/thunderbolt/tb_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thunderbolt/tb_regs.h

[PATCH 6/7] thunderbolt: Add support for runtime PM

2018-07-25 Thread Mika Westerberg
there is a remote wake event (device is connected or disconnected), or when there is access from userspace that requires hardware access. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/domain.c | 42 +++- drivers/thunderbolt/icm.c | 119

[PATCH 4/7] thunderbolt: No need to take tb->lock in domain suspend/complete

2018-07-25 Thread Mika Westerberg
If the connection manager implementation needs to touch the domain structures it ought to take the lock itself. Currently only ICM implements these hooks and it does not need the lock because we there will be no notifications before driver ready message is sent to it. Signed-off-by: Mika

Re: [PATCH 6/7] thunderbolt: Add support for runtime PM

2018-07-25 Thread Mika Westerberg
On Wed, Jul 25, 2018 at 10:17:01AM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 25, 2018 at 11:03:20AM +0300, Mika Westerberg wrote: > > When Thunderbolt host controller is set to RTD3 mode (Runtime D3) it is > > present all the time. Because of this it is important to runtime

[PATCH v2 6/7] thunderbolt: Add support for runtime PM

2018-07-25 Thread Mika Westerberg
there is a remote wake event (device is connected or disconnected), or when there is access from userspace that requires hardware access. Signed-off-by: Mika Westerberg --- Rebased on top of char-misc-testing which includes 007a74907dee ("thunderbolt: Notify userspace when boot_acl is ch

Re: [PATCH] thunderbolt: remove redundant variable 'approved'

2018-07-14 Thread Mika Westerberg
On Fri, Jul 13, 2018 at 09:57:25AM +0100, Colin King wrote: > From: Colin Ian King > > Variable 'approved' is being assigned but is never used hence it is > redundant and can be removed. > > Cleans up clang warning: > warning: variable 'approved' set but not used [-Wunused-but-set-variable] > >

Re: [PATCH v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a module

2018-01-23 Thread Mika Westerberg
On Wed, Jan 24, 2018 at 06:56:16AM +0100, Wolfram Sang wrote: > On Wed, Jan 03, 2018 at 03:02:31PM +0100, Eric Auger wrote: > > If I2C is built as a module, ACPI_I2C_OPREGION cannot be set > > and any ACPI opregion calls targeting I2C fail with no opregion found. > > > > This patch allows ACPI_I2C

Re: [PATCH v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a module

2018-01-24 Thread Mika Westerberg
On Wed, Jan 24, 2018 at 08:29:44AM -0500, Sinan Kaya wrote: > +linux-acpi > > On 1/24/2018 1:27 AM, Mika Westerberg wrote: > > On Wed, Jan 24, 2018 at 06:56:16AM +0100, Wolfram Sang wrote: > >> On Wed, Jan 03, 2018 at 03:02:31PM +0100, Eric Auger wrote: > >

[PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems

2017-05-15 Thread Mika Westerberg
d separate entries). Instead of adding each machine to the quirk table, we use DMI_PRODUCT_FAMILY of "Intel_Strago" that hopefully covers most of the machines out there currently. Link: https://bugzilla.kernel.org/show_bug.cgi?id=194945 Suggested: Dmitry Torokhov Signed-off-by: Mika West

[PATCH 1/3] firmware: dmi: Add DMI_PRODUCT_FAMILY identification string

2017-05-15 Thread Mika Westerberg
userspace through sysfs attribute just like the existing ones. Suggested-by: Dmitry Torokhov Signed-off-by: Mika Westerberg --- drivers/firmware/dmi-id.c | 2 ++ drivers/firmware/dmi_scan.c | 1 + include/linux/mod_devicetable.h | 1 + 3 files changed, 4 insertions(+) diff --git a

[PATCH 2/3] pinctrl: cherryview: Add terminate entry for dmi_system_id tables

2017-05-15 Thread Mika Westerberg
From: Wei Yongjun Make sure dmi_system_id tables are NULL terminated. Fixes: 703650278372 ("pinctrl: cherryview: Add a quirk to make Acer Chromebook keyboard work again") Signed-off-by: Wei Yongjun Signed-off-by: Mika Westerberg --- drivers/pinctrl/intel/pinctrl-cherryview.c | 3 +

[PATCH 0/3] pinctrl: cherryview: Extend the DMI quirk to Intel_Strago systems

2017-05-15 Thread Mika Westerberg
. Related bugzilla entry: https://bugzilla.kernel.org/show_bug.cgi?id=194945 I'm including fix from Yongjun as well because I did not find it in v4.12-rc1 possibly because it just was forgotten. Mika Westerberg (2): firmware: dmi: Add DMI_PRODUCT_FAMILY identification string pinctrl: cherr

[PATCH] nvmem: core: Prevent memory leak when device is unregistered

2017-05-15 Thread Mika Westerberg
. Signed-off-by: Mika Westerberg --- drivers/nvmem/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 8c830a80a648..112c8072e0f3 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -528,7 +528,7 @@ int

Re: [PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems

2017-05-15 Thread Mika Westerberg
On Mon, May 15, 2017 at 02:14:38PM +0300, Andy Shevchenko wrote: > On Mon, 2017-05-15 at 14:01 +0300, Mika Westerberg wrote: > > It turns out there are quite many Chromebooks out there that have the > > same keyboard issue than Acer Chromebook. All of them are based on > > I

Re: Regression due to "PCI: Do not allocate more buses than available in parent"

2018-01-12 Thread Mika Westerberg
Hi, On Fri, Jan 12, 2018 at 04:07:44PM +0100, Sebastian Reichel wrote: > Hi, > > I have an ARM/DT based system [0], that no longer finds its ethernet cards > behind a PCIe switch. I bisected the problem and ended up on > a20c7f36bd3d. I tried providing some space using the suggested > "pci=hpbus

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-20 Thread Mika Westerberg
On Fri, Jan 19, 2018 at 07:07:29PM +0100, Marcin Wojtas wrote: > Hi Mika, Hi, > 2018-01-18 14:00 GMT+01:00 Andrew Lunn : > >> I CC'ed Mika since he is more familiar with handling these bits of ACPI > >> specs - I wonder whether this is a problem that cropped up on x86 > >> systems too. > > > > Hi

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-21 Thread Mika Westerberg
On Sun, Jan 21, 2018 at 02:08:40AM +0100, Andrew Lunn wrote: > > I'm not familiar with MDIO bus but an alternative to GeneriSerialBus > > would be to follow what SDIO is doing, e.g have the PHY devices listed > > below the MDIO controller and use _ADR to describe their "address" on > > that bus. Yo

Re: Missing watchdog after ACPI watchdog creation failure

2018-01-18 Thread Mika Westerberg
On Wed, Jan 17, 2018 at 12:53:41PM +0100, Takashi Iwai wrote: > Unfortunately we couldn't get approval yet, since it's a prototype > machine. In that case, I think the system itself and its ACPI tables should be fixed if possible. Windows relies on that table as well so unless there is something t

Re: Missing watchdog after ACPI watchdog creation failure

2018-01-18 Thread Mika Westerberg
On Thu, Jan 18, 2018 at 12:20:32PM +0200, Mika Westerberg wrote: > On Wed, Jan 17, 2018 at 12:53:41PM +0100, Takashi Iwai wrote: > > Unfortunately we couldn't get approval yet, since it's a prototype > > machine. > > In that case, I think the system itself and its A

Re: Missing watchdog after ACPI watchdog creation failure

2018-01-10 Thread Mika Westerberg
On Wed, Jan 10, 2018 at 04:13:51PM +0100, Takashi Iwai wrote: > Hi, > > on the recent kernels, i2c-i801 skips the creation of iTCO wdt when > ACPI WDAT is present. It's fine when ACPI really creates the watchdog > device. But, we've got a report showing that the watchdog is missing > on some mac

Re: [PATCH] ACPI / LPSS: Do not instiate a platform_dev for devs without a mmio resource

2018-01-15 Thread Mika Westerberg
Signed-off-by: Hans de Goede Seems like a good way to fix it IMHO, Acked-by: Mika Westerberg

Re: [PATCH] pinctrl: intel: Implement intel_gpio_get_direction callback

2018-03-06 Thread Mika Westerberg
f-tree.) > > > > > > An earlier version of this patch was reviewed some time ago by Andy > > > Shevchenko outside of the mailing lists: > > > <https://github.com/emutex/ubilinux-kernel/commit/708a776f2ffd1b1c> > > > > > Yes, this one look good! > > Reviewed-by: Andy Shevchenko Acked-by: Mika Westerberg

Re: [PATCH v1] x86/PCI: Make pci=earlydump output neat

2018-04-11 Thread Mika Westerberg
); > + for (i = 0; i < 256; i += 4) > + value[i/4] = read_pci_config(bus, slot, func, i); Please be consistent with your use of whitespace: 256 / 4 vs. i/4. Other than that looks good and certainly is an improvement, Reviewed-by: Mika Westerberg

Re: [PATCH] firmware: dmi_scan: Fix UUID length safety check

2018-04-10 Thread Mika Westerberg
#x27;t expect this bug to cause problem in practice because all > implementations I have seen had length 8, 25 or 27 bytes, in line > with the SMBIOS specifications. But let's fix it still. > > Signed-off-by: Jean Delvare > Fixes: a814c3597a6b ("firmware: dmi_scan:

Re: [PATCH v3 00/18] thunderbolt: Add support for Intel Titan Ridge

2018-03-09 Thread Mika Westerberg
On Fri, Mar 02, 2018 at 03:38:34PM +0300, Mika Westerberg wrote: > Mika Westerberg (13): > thunderbolt: Resume control channel after hibernation image is created > thunderbolt: Serialize PCIe tunnel creation with PCI rescan > thunderbolt: Handle connecting device in place of h

[PATCH] thunderbolt: Prevent crash when ICM firmware is not running

2018-03-09 Thread Mika Westerberg
: f67cf491175a ("thunderbolt: Add support for Internal Connection Manager (ICM)") Reported-by: Jordan Glover Signed-off-by: Mika Westerberg Cc: sta...@vger.kernel.org --- drivers/thunderbolt/icm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/thunderbolt/icm.c b/drivers/thunder

Re: [PATCH] thunderbolt: Prevent crash when ICM firmware is not running

2018-03-14 Thread Mika Westerberg
On Fri, Mar 09, 2018 at 01:44:34PM +0300, Mika Westerberg wrote: > On Lenovo ThinkPad Yoga 370 (and possibly some other Lenovo models as > well) the Thunderbolt host controller sometimes comes up in such way > that the ICM firmware is not running properly. This is most likely an > i

Re: [PATCH] platform/x86: intel-wmi-thunderbolt: Add dynamic debugging

2018-09-26 Thread Mika Westerberg
> https://github.com/hughsie/fwupd/commit/ef6f1d76983c9b66 > https://github.com/hughsie/fwupd/commit/c07ce5b4889a5384 > > To allow easier debugging of this situation add output that can be turned > on with dynamic debugging to better root cause this problem. > > Suggested-by:

[PATCH 1/1] thunderbolt: Prevent root port runtime suspend during NVM upgrade

2018-11-26 Thread Mika Westerberg
port goes into D3cold and never wakes up unless userspace does PCI config space access, such as running 'lscpi'. For this reason we explicitly prevent the root port from runtime suspending during NVM upgrade. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/swi

[PATCH 0/1] thunderbolt: Fix for v4.20-rc5

2018-11-26 Thread Mika Westerberg
port runtime suspend during NVM upgrade (2018-11-15 13:28:09 +0300) thunderbolt: Fix for v4.20-rc5 ---- Mika Westerberg (1): thunderbolt: Prevent root port runtime su

[PATCH v2 2/4] iommu/vt-d: Force IOMMU on for platform opt in hint

2018-11-26 Thread Mika Westerberg
. This can be turned off by adding "intel_iommu=off" in the kernel command line, if any problems are found. [1] https://docs.microsoft.com/en-us/windows/security/information-protection/kernel-dma-protection-for-thunderbolt Cc: Jacob Pan Cc: Sohil Mehta Signed-off-by: Lu Baolu Signed-of

<    2   3   4   5   6   7   8   9   10   11   >