On Tue, Oct 13, 2015 at 4:50 AM, Christoph Hellwig wrote:
> On Wed, Aug 12, 2015 at 12:07:15AM -0700, Ming Lin wrote:
>> From: Ming Lin
>>
>> The split code in blkdev_issue_{discard,write_same} can go away
>> now that any driver that cares does the split. We have to ma
On Wed, 2015-10-21 at 09:39 -0400, Jeff Moyer wrote:
> Christoph Hellwig writes:
>
> > Jens, Ming:
> >
> > are you fine with the one liner change to get back to the old I/O
> > pattern? While it looks like the cards fault I'd like to avoid this
> > annoying regression.
>
> I'm not Jens or Ming,
On Wed, 2015-10-21 at 11:33 -0400, Mike Snitzer wrote:
> On Wed, Oct 21 2015 at 11:01am -0400,
> Ming Lin wrote:
>
> > On Wed, 2015-10-21 at 09:39 -0400, Jeff Moyer wrote:
> > > Christoph Hellwig writes:
> > >
> > > > Jens, Ming:
> > > &
On Wed, 2015-10-21 at 12:19 -0400, Mike Snitzer wrote:
> On Wed, Oct 21 2015 at 12:02pm -0400,
> Mike Snitzer wrote:
>
> > On Wed, Oct 14 2015 at 9:27am -0400,
> > Christoph Hellwig wrote:
> >
> > > On Tue, Oct 13, 2015 at 10:44:11AM -0700, Ming Lin wrote:
On Wed, 2015-10-21 at 14:18 -0400, Mike Snitzer wrote:
> On Wed, Oct 21 2015 at 1:33pm -0400,
> Ming Lin wrote:
>
> > On Wed, 2015-10-21 at 12:19 -0400, Mike Snitzer wrote:
> > > On Wed, Oct 21 2015 at 12:02pm -0400,
> > > Mike Snitzer wrote:
> > >
&g
From: Ming Lin
In commit b49a087("block: remove split code in
blkdev_issue_{discard,write_same}"), discard_granularity and alignment
checks were removed. Ideally, with bio late splitting, the upper layers
shouldn't need to depend on device's limits.
Christoph reported a d
On Wed, Sep 2, 2015 at 3:50 PM, Jens Axboe wrote:
> On 09/02/2015 04:41 PM, Jens Axboe wrote:
>>
>> On 09/02/2015 04:34 PM, Linus Torvalds wrote:
>>>
>>> Jens,
>>>
>>> On Wed, Sep 2, 2015 at 9:58 AM, Jens Axboe wrote:
This pull request contains a set of scatter-gather related chang
On Mon, Dec 8, 2014 at 3:48 AM, Dongsu Park
wrote:
> Thanks for the reply.
>
> On 05.12.2014 19:02, Kent Overstreet wrote:
>> On Thu, Dec 04, 2014 at 12:00:27PM +0100, Dongsu Park wrote:
>> > Playing a little with your block_stuff tree based on 3.15, however,
>> > I think there still seems to be a
> On Wed, Dec 10, 2014 at 02:42:14PM -0800, Ming Lin wrote:
>> On Mon, Dec 8, 2014 at 3:48 AM, Dongsu Park
>> wrote:
>> > Thanks for the reply.
>> >
>> > On 05.12.2014 19:02, Kent Overstreet wrote:
>> >> On Thu, Dec 04, 2014 at 12:00:27PM +
Hi Jens,
This RFC DRAFT patch is on top of your "[PATCH v2] Support for write stream IDs"
I throw it out early to get comments if it's the way to go.
Quote LWN(http://lwn.net/Articles/638722):
"There would be clear value in a closer association between stream IDs
and specific buffered-write oper
On Tue, Apr 21, 2015 at 10:12 AM, Jens Axboe wrote:
> On 04/21/2015 11:09 AM, Ming Lin wrote:
>>
>> Hi Jens,
>>
>> This RFC DRAFT patch is on top of your "[PATCH v2] Support for write
>> stream IDs"
>> I throw it out early to get comments if i
I'd like to continue on Dongsu's effort to push Kent's block-stuff upstream.
This is a preparation series for simplifying block layer based on immutable
biovecs, a spin off of the v2 of simplifying patchset. [1] The original
goal of simplifying block layer was actually making generic_make_request(
: Dongsu Park
Signed-off-by: Ming Lin
---
fs/buffer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/buffer.c b/fs/buffer.c
index c7a5602..c1c0e0d 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -3041,13 +3041,13 @@ int _submit_bh(int rw, struct buffer_head *bh, unsigned
l
only
when bio_chain is given.
Cc: Christoph Hellwig
Cc: linux...@vger.kernel.org
Acked-by: Rafael J. Wysocki
Signed-off-by: Kent Overstreet
[dpark: add more description in commit message]
Signed-off-by: Dongsu Park
Signed-off-by: Ming Lin
---
kernel/power/block_io.c | 23 ++---
changes.
Cc: Christoph Hellwig
Cc: Jens Axboe
Cc: "Hans J. Koch"
Cc: Greg Kroah-Hartman
Cc: Al Viro
Signed-off-by: Kent Overstreet
[dpark: add more description in commit message]
[mlin: move iov_count_pages to block/bio.c]
Signed-off-by: Dongsu Park
Signed-off-by: Ming Lin
---
block/
: Dongsu Park
Signed-off-by: Ming Lin
---
drivers/md/raid10.c | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index a7196c4..02e33f1 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -2097,18 +2097,11
On Sat, Apr 11, 2015 at 4:59 AM, Dave Chinner wrote:
> On Fri, Apr 10, 2015 at 04:50:05PM -0700, Ming Lin wrote:
>> On Wed, Mar 25, 2015 at 7:26 AM, Jens Axboe wrote:
>> > On 03/24/2015 08:43 PM, Dave Chinner wrote:
>> >>
>> >> On Tue, Mar 24,
Signed-off-by: Ming Lin
---
block/bio.c | 45 +++--
1 file changed, 7 insertions(+), 38 deletions(-)
diff --git a/block/bio.c b/block/bio.c
index 05c2864..c3a6468 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -1158,29 +1158,14 @@ struct bio
On Fri, Apr 24, 2015 at 9:17 AM, Christoph Hellwig wrote:
> On Thu, Apr 23, 2015 at 04:04:35PM -0700, Ming Lin wrote:
>> From: Kent Overstreet
>>
>> Make bio submission in kernel/power/block_io.c to properly submit
>> bios also when bio_chain is not available. In that
Dongsu sent v1 of this patchset.
https://lkml.org/lkml/2014/12/22/128
This is the second attempt of simplifying block layer based on immutable
biovecs. Immutable biovecs, implemented by Kent Overstreet, have been
available in mainline since v3.14. Its original goal was actually making
generic_make
Cc: Chris Mason
Cc: Josef Bacik
Cc: linux-bt...@vger.kernel.org
Signed-off-by: Kent Overstreet
Signed-off-by: Chris Mason
[dpark: add more description in commit message]
Signed-off-by: Dongsu Park
Signed-off-by: Ming Lin
---
fs/btrfs/volumes.c |
-by: Dongsu Park
Signed-off-by: Ming Lin
---
Documentation/block/biovecs.txt | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/Documentation/block/biovecs.txt b/Documentation/block/biovecs.txt
index 74a32ad..2568958 100644
--- a/Documentation/block/biovecs.txt
+++ b
lip Kelleher
Cc: Minchan Kim
Cc: Nitin Gupta
Cc: Oleg Drokin
Cc: Andreas Dilger
Signed-off-by: Kent Overstreet
[dpark: skip more mq-based drivers, resolve merge conflicts, etc.]
Signed-off-by: Dongsu Park
Signed-off-by: Ming Lin
---
block/blk-core.c| 1
Overstreet
[dpark: also remove ->merge_bvec_fn() in dm-thin as well as
dm-era-target, and resolve merge conflicts]
Signed-off-by: Dongsu Park
Signed-off-by: Ming Lin
---
block/blk-merge.c | 17 +-
block/blk-settings.c | 22
drivers/block/drbd/drbd_in
ption in commit message]
Signed-off-by: Dongsu Park
Signed-off-by: Ming Lin
---
drivers/md/raid5.c | 23 +--
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 77dfd72..7f4a717 100644
--- a/drivers/md/raid5.c
+++ b/dr
-fsde...@vger.kernel.org
Signed-off-by: Kent Overstreet
[dpark: add more description in commit message]
Signed-off-by: Dongsu Park
Signed-off-by: Ming Lin
---
fs/buffer.c | 7 ++-
fs/jfs/jfs_logmgr.c | 14 --
mm/page_io.c| 8 +++-
3 files changed, 9 inser
le of comments,
make bio_add_page() warn once upon a cloned bio.]
Signed-off-by: Dongsu Park
Signed-off-by: Ming Lin
---
block/bio.c | 135 +---
1 file changed, 55 insertions(+), 80 deletions(-)
diff --git a/block/bio.c b/block/bio.c
i
dpark: add more description in commit message]
Signed-off-by: Dongsu Park
Signed-off-by: Ming Lin
---
drivers/md/bcache/bcache.h| 18
drivers/md/bcache/io.c| 100 +-
drivers/md/bcache/journal.c | 4 +-
drivers/md/bcache/requ
: add more description in commit message]
Signed-off-by: Dongsu Park
Signed-off-by: Ming Lin
---
drivers/md/raid10.c | 18 --
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index a46c402..6ea6f5f 100644
--- a/drivers/md/raid10
_request().
Cc: Christoph Hellwig
Cc: Jens Axboe
Signed-off-by: Kent Overstreet
[dpark: add more description in commit message]
Signed-off-by: Dongsu Park
Signed-off-by: Ming Lin
---
block/bounce.c | 60 ++
1 file changed, 52 insertions(
On Wed, Mar 25, 2015 at 7:26 AM, Jens Axboe wrote:
> On 03/24/2015 08:43 PM, Dave Chinner wrote:
>>
>> On Tue, Mar 24, 2015 at 09:27:00AM -0600, Jens Axboe wrote:
>>>
>>> Get the streamid from the file, if any, and set it on the bio.
>>>
>>> Signed-off-by: Jens Axboe
>>> ---
>>> fs/direct-io.c
On Fri, Apr 10, 2015 at 4:50 PM, Ming Lin wrote:
> On Wed, Mar 25, 2015 at 7:26 AM, Jens Axboe wrote:
>> On 03/24/2015 08:43 PM, Dave Chinner wrote:
>>>
>>> On Tue, Mar 24, 2015 at 09:27:00AM -0600, Jens Axboe wrote:
>>>>
>>>> Get the st
On Tue, Apr 28, 2015 at 5:12 AM, Christoph Hellwig wrote:
> On Mon, Apr 27, 2015 at 11:48:29PM -0700, Ming Lin wrote:
>> Note that removing call to ->merge_bvec_fn() is fine for
>> bio_add_pc_page(), as SCSI devices usually don't even need that.
>> Few exceptional ca
On Tue, Apr 28, 2015 at 5:14 AM, Christoph Hellwig wrote:
> On Mon, Apr 27, 2015 at 11:48:31PM -0700, Ming Lin wrote:
>> From: Kent Overstreet
>>
>> There has been workarounds only in bcache, for splitting pool as well
>> as submitting bios. Since generic_make_
On Tue, Apr 28, 2015 at 10:31 AM, Alasdair G Kergon wrote:
> On Mon, Apr 27, 2015 at 11:48:34PM -0700, Ming Lin wrote:
>> As generic_make_request() is now able to handle arbitrarily sized bios,
>> it's no longer necessary for each individual block driver to define its
&g
On Tue, May 26, 2015 at 9:04 AM, Mike Snitzer wrote:
> On Tue, May 26 2015 at 11:02am -0400,
> Ming Lin wrote:
>
>> On Tue, May 26, 2015 at 7:36 AM, Mike Snitzer wrote:
>> > On Fri, May 22 2015 at 2:18pm -0400,
>> > Ming Lin wrote:
>> >
>> &
On Wed, May 27, 2015 at 5:36 PM, Alasdair G Kergon wrote:
> On Wed, May 27, 2015 at 04:42:44PM -0700, Ming Lin wrote:
>> Here are fio results of XFS on a DM stripped target with 2 SSDs + 1 HDD.
>> Does it make sense?
>
> To stripe across devices with different characteristics
On Mon, May 25, 2015 at 6:51 AM, Christoph Hellwig wrote:
> On Sun, May 24, 2015 at 12:37:32AM -0700, Ming Lin wrote:
>> > Except for that these changes looks good, and the previous version
>> > passed my tests fine, so with some benchmarks you'ĺl have my ACK.
>>
On Wed, May 27, 2015 at 5:36 PM, Alasdair G Kergon wrote:
> On Wed, May 27, 2015 at 04:42:44PM -0700, Ming Lin wrote:
>> Here are fio results of XFS on a DM stripped target with 2 SSDs + 1 HDD.
>> Does it make sense?
>
> To stripe across devices with different char
On Wed, 2015-06-10 at 15:06 -0700, Ming Lin wrote:
> On Wed, Jun 10, 2015 at 2:46 PM, Mike Snitzer wrote:
> > On Wed, Jun 10 2015 at 5:20pm -0400,
> > Ming Lin wrote:
> >
> >> On Mon, Jun 8, 2015 at 11:09 PM, Ming Lin wrote:
> >> > On Thu, 201
On Wed, Jun 10, 2015 at 2:46 PM, Mike Snitzer wrote:
> On Wed, Jun 10 2015 at 5:20pm -0400,
> Ming Lin wrote:
>
>> On Mon, Jun 8, 2015 at 11:09 PM, Ming Lin wrote:
>> > On Thu, 2015-06-04 at 17:06 -0400, Mike Snitzer wrote:
>> >> We need to test on large HW
On Thu, Jun 4, 2015 at 2:06 PM, Mike Snitzer wrote:
> On Tue, Jun 02 2015 at 4:59pm -0400,
> Ming Lin wrote:
>
>> On Sun, May 31, 2015 at 11:02 PM, Ming Lin wrote:
>> > On Thu, 2015-05-28 at 01:36 +0100, Alasdair G Kergon wrote:
>> >> On Wed, May 27, 2015
On Thu, Jun 4, 2015 at 5:06 PM, Mike Snitzer wrote:
> On Thu, Jun 04 2015 at 6:21pm -0400,
> Ming Lin wrote:
>
>> On Thu, Jun 4, 2015 at 2:06 PM, Mike Snitzer wrote:
>> >
>> > We need to test on large HW raid setups like a Netapp filer (or even
>> &g
On Thu, 2015-06-04 at 17:06 -0400, Mike Snitzer wrote:
> We need to test on large HW raid setups like a Netapp filer (or even
> local SAS drives connected via some SAS controller). Like a 8+2 drive
> RAID6 or 8+1 RAID5 setup. Testing with MD raid on JBOD setups with 8
> devices is also useful. I
On Sun, May 31, 2015 at 11:02 PM, Ming Lin wrote:
> On Thu, 2015-05-28 at 01:36 +0100, Alasdair G Kergon wrote:
>> On Wed, May 27, 2015 at 04:42:44PM -0700, Ming Lin wrote:
>> > Here are fio results of XFS on a DM stripped target with 2 SSDs + 1 HDD.
>> > Does it
On Wed, Jun 3, 2015 at 6:28 AM, Jeff Moyer wrote:
> Christoph Hellwig writes:
>
>> On Sun, May 31, 2015 at 11:15:09PM -0700, Ming Lin wrote:
>>> > Except for that these changes looks good, and the previous version
>>> > passed my tests fine, so wit
On Sun, May 31, 2015 at 6:46 PM, Huang Ying wrote:
> FYI, we noticed the below changes on
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mlin/linux.git block-generic-req
> commit fbccf1df06574add60bdb71103cc1662e477f02d ("block: make
> generic_make_request handle arbitrarily sized bios")
>
>
>
On Thu, 2015-06-04 at 08:49 +0800, huang ying wrote:
> Hi, Ming,
>
> Here it is.
>
> qemu-system-x86_64 -enable-kvm -cpu Haswell,+smep,+smap
> -kernel
> /pkg/linux/x86_64-lkp/gcc-4.9/fbccf1df06574add60bdb71103cc1662e477f02d/vmlinuz-4.1.0-rc4-1-gfbccf1d
> -append 'root=/dev/ram0 user=lkp
>
On Thu, 2015-05-28 at 01:36 +0100, Alasdair G Kergon wrote:
> On Wed, May 27, 2015 at 04:42:44PM -0700, Ming Lin wrote:
> > Here are fio results of XFS on a DM stripped target with 2 SSDs + 1 HDD.
> > Does it make sense?
>
> To stripe across devices with different chara
On Sat, May 23, 2015 at 7:15 AM, Christoph Hellwig wrote:
> On Fri, May 22, 2015 at 11:18:32AM -0700, Ming Lin wrote:
>> This will bring not only performance improvements, but also a great amount
>> of reduction in code complexity all over the block layer. Performance gain
>&g
On Mon, Jun 8, 2015 at 11:09 PM, Ming Lin wrote:
> On Thu, 2015-06-04 at 17:06 -0400, Mike Snitzer wrote:
>> We need to test on large HW raid setups like a Netapp filer (or even
>> local SAS drives connected via some SAS controller). Like a 8+2 drive
>> RAID6 or 8+1 RAID5 se
On Wed, Jun 10, 2015 at 2:46 PM, Mike Snitzer wrote:
> On Wed, Jun 10 2015 at 5:20pm -0400,
> Ming Lin wrote:
>
>> On Mon, Jun 8, 2015 at 11:09 PM, Ming Lin wrote:
>> > On Thu, 2015-06-04 at 17:06 -0400, Mike Snitzer wrote:
>> >> We need to test on large HW
On Mon, 2015-07-13 at 11:35 -0400, Mike Snitzer wrote:
> On Mon, Jul 13 2015 at 1:12am -0400,
> Ming Lin wrote:
>
> > On Mon, 2015-07-06 at 00:11 -0700, m...@kernel.org wrote:
> > > Hi Mike,
> > >
> > > On Wed, 2015-06-10 at 17:46 -0400, Mike Snitze
On Tue, Aug 4, 2015 at 3:44 AM, kernel test robot wrote:
> FYI, we noticed the below changes on
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mlin/linux.git block-generic-req
> commit 3b4809b871881433e502d6fe70ae556bcfc9b10d ("block: remove split code in
> blkdev_issue_discard")
This is the
On Tue, 2015-08-04 at 13:36 +0200, Christoph Hellwig wrote:
> On Sun, Aug 02, 2015 at 10:58:22PM -0700, Ming Lin wrote:
> > I think the important thing is the late splitting for regular bio.
> > For discard/write_same bio, how about just don't do late splitting?
>
>
ctors)
[8388607, 8388607] ---> same problem
2. Ensure bi_size not overflow and max discard size is of proper granularity
It works.
[start_sector, end_sector]
[0, 8388607]
[0, 8388479]
[8388480, 8388607]
So how about below patch?
commit 1ca2ad977255efb3c339f4ca16fb798ed5ec54f7
Author:
On Fri, Aug 7, 2015 at 5:30 PM, Kent Overstreet
wrote:
> On Fri, Aug 07, 2015 at 04:40:06PM -0700, Ming Lin wrote:
>>
>> On Fri, 2015-08-07 at 09:30 +0200, Christoph Hellwig wrote:
>> > I'm for solution 3:
>> >
>> > - keep blk_bio_{discard,write_s
#x27;s a reason I turned discard_zeroes_data off for UNMAP!
>
> Wrt. the range size I don't have a problem with capping at the 32-bit
> bi_size limit. We probably don't want to send commands much bigger than
> that anyway.
How about below?
commit b8ca440bd77653d4d2bac90b7fd159
On Sat, 2015-08-08 at 23:41 -0700, Christoph Hellwig wrote:
> On Sat, Aug 08, 2015 at 10:59:50PM -0700, Ming Lin wrote:
> > +/*
> > + * Ensure that max discard sectors doesn't overflow bi_size and hopefully
> > + * it is of the proper granularity as long as the granula
On Sun, 2015-08-09 at 00:01 -0700, Christoph Hellwig wrote:
> On Sat, Aug 08, 2015 at 11:55:47PM -0700, Ming Lin wrote:
> > Will change it to MAX_BIO_SECTORS.
> > May I add your ACK?
>
> Yes, please go ahead.
Thanks. I'll send a new version of the series once device-map
On Mon, 2015-07-27 at 13:50 -0400, Mike Snitzer wrote:
> On Thu, Jul 23 2015 at 2:21pm -0400,
> Ming Lin wrote:
>
> > On Mon, 2015-07-13 at 11:35 -0400, Mike Snitzer wrote:
> > > On Mon, Jul 13 2015 at 1:12am -0400,
> > > Ming Lin wrote:
> > >
&g
On Mon, Jul 27, 2015 at 3:11 PM, Ming Lin wrote:
> It's more interesting if we look at how many bios are allocated for each
> application IO request.
>
> e.g. 10+2 RAID6 with 128K chunk.
>
> Assume we only consider device max_segments limitation.
>
> # cat /sys/block
On Thu, 2015-08-13 at 10:51 -0600, Jens Axboe wrote:
> On 08/12/2015 01:07 AM, Ming Lin wrote:
> > Hi Jens,
> >
> > Neil/Mike/Martin have acked/reviewed PATCH 1.
> > Now it's ready. Could you please apply this series?
> >
> > https://git.kernel.org/cgit/
On Thu, 2015-08-13 at 11:07 -0600, Jens Axboe wrote:
> On 08/13/2015 11:03 AM, Ming Lin wrote:
> > On Thu, 2015-08-13 at 10:51 -0600, Jens Axboe wrote:
> >> On 08/12/2015 01:07 AM, Ming Lin wrote:
> >>> Hi Jens,
> >>>
> >>> Neil/Mike/Martin ha
On Mon, 2015-07-13 at 11:35 -0400, Mike Snitzer wrote:
> I will do additional review to answer 1 and 2 above. And Jeff Moyer
> told me he'd test the patchset on one of his testbeds.
Hi Jeff,
FYI, here is a fix for patch 1.
Or you can pull from my tree.
https://git.kernel.org/cgit/linux/kernel/gi
From: Ming Lin
blk_mq_init_queue() calls blk_mq_init_allocated_queue(), but q->mq_ops
was not cleared when blk_mq_init_allocated_queue() fails.
Then blk_cleanup_queue() calls blk_mq_free_queue() which will crash because:
- q->all_q_node is not added to all_q_list yet
- q->tag_set is NU
t;build
> the bios as large as possible and worry about splitting later".
>
> Regardless, this regression needs to be reported to Ming Lin
> , Jens Axboe and the others involved in
> maintaining the late bio splitting changes in block core.
I'm looking at it now.
--
On Fri, 2015-09-11 at 21:43 -0700, Ming Lin wrote:
> On Fri, Sep 11, 2015 at 2:43 PM, Mike Snitzer wrote:
> > Ming, Jens, others:
> >
> > Please see this BZ comment that speaks to a 4.3 regression due to the
> > late bio splitting changes:
> > https://bugzilla.r
On Sat, Sep 12, 2015 at 12:34 AM, Ming Lin wrote:
> On Fri, 2015-09-11 at 21:43 -0700, Ming Lin wrote:
>> On Fri, Sep 11, 2015 at 2:43 PM, Mike Snitzer wrote:
>> > Ming, Jens, others:
>> >
>> > Please see this BZ comment that speaks to a 4.3 regression due to
On Thu, Oct 22, 2015 at 10:03 AM, Mike Snitzer wrote:
> On Thu, Oct 22 2015 at 12:59pm -0400,
> Ming Lin wrote:
>
>> From: Ming Lin
>>
>> In commit b49a087("block: remove split code in
>> blkdev_issue_{discard,write_same}"), discard_granularity an
On Wed, May 20, 2015 at 5:48 AM, Christoph Hellwig wrote:
> Passes test fine for me so far. You might also want to throw in the
> following patch to make it more useful:
I'll add it to next version.
Thanks.
>
> ---
> From a30035d4ae040723a6c94143db90231941d0caf7 Mon Sep 17 00:00:00 2001
> From
On Wed, May 20, 2015 at 5:44 AM, Christoph Hellwig wrote:
> This needs the patch below for the blk-mq case with multiple queues.
Will add it.
>
> Also I wonder why we really want to push this below ->make_request.
> Moving it just outside ->make_request would make the callchain more
> obvious an
On Tue, May 19, 2015 at 1:44 AM, Christoph Hellwig wrote:
> On Wed, May 06, 2015 at 11:34:13PM -0700, Ming Lin wrote:
>> From: Kent Overstreet
>>
>> Allow __blk_queue_bounce() to handle bios with more than BIO_MAX_PAGES
>> segments. Doing that, it becomes possible
On Mon, May 18, 2015 at 9:52 AM, Jeff Moyer wrote:
> Ming Lin writes:
>
>> diff --git a/block/blk-core.c b/block/blk-core.c
>> index fd154b9..909f317 100644
>> --- a/block/blk-core.c
>> +++ b/block/blk-core.c
>> @@ -617,6 +617,10 @@ struct request_queue *blk
On Wed, May 20, 2015 at 11:58 AM, Jeff Moyer wrote:
> Ming Lin writes:
>
>> On Mon, May 18, 2015 at 9:52 AM, Jeff Moyer wrote:
>>> Ming Lin writes:
>>>
>>>> diff --git a/block/blk-core.c b/block/blk-core.c
>>>> index fd154b9..909f317 1
ut?
>
> The code in blk-lib.c can go away now that any driver that cares
> does the split.
How about below?
>From 23aec71f3e44a21aece46f7939715e022b7d3daa Mon Sep 17 00:00:00 2001
From: Ming Lin
Date: Fri, 22 May 2015 00:46:56 -0700
Subject: [PATCH] block: remove split code
On Mon, May 18, 2015 at 9:52 AM, Jeff Moyer wrote:
>
>> +static struct bio *blk_bio_segment_split(struct request_queue *q,
>> + struct bio *bio,
>> + struct bio_set *bs)
>> +{
>
> Funny name for a function that also merges s
_rdev()
block: kill merge_bvec_fn() completely
fs: use helper bio_add_page() instead of open coding on bi_io_vec
block: remove bio_get_nr_vecs()
Ming Lin (2):
block: remove split code in blkdev_issue_discard
md/raid5: split bio for chunk_aligned_read
Documentation/block/
Cc: Chris Mason
Cc: Josef Bacik
Cc: linux-bt...@vger.kernel.org
Signed-off-by: Kent Overstreet
Signed-off-by: Chris Mason
[dpark: add more description in commit message]
Signed-off-by: Dongsu Park
Signed-off-by: Ming Lin
---
fs/btrfs/volumes.c |
once upon a cloned bio.]
Signed-off-by: Dongsu Park
Signed-off-by: Ming Lin
---
block/bio.c | 135 +---
1 file changed, 55 insertions(+), 80 deletions(-)
diff --git a/block/bio.c b/block/bio.c
index f66a4ea..ae31cdb 100644
--- a/block/bio.
-by: Dongsu Park
Signed-off-by: Ming Lin
---
Documentation/block/biovecs.txt | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/Documentation/block/biovecs.txt b/Documentation/block/biovecs.txt
index 74a32ad..2568958 100644
--- a/Documentation/block/biovecs.txt
+++ b
From: Kent Overstreet
We can always fill up the bio now, no need to estimate the possible
size based on queue parameters.
Signed-off-by: Kent Overstreet
[hch: rebased and wrote a changelog]
Signed-off-by: Christoph Hellwig
Signed-off-by: Ming Lin
---
block/bio.c| 23
-fsde...@vger.kernel.org
Signed-off-by: Kent Overstreet
[dpark: add more description in commit message]
Signed-off-by: Dongsu Park
Signed-off-by: Ming Lin
---
fs/buffer.c | 7 ++-
fs/jfs/jfs_logmgr.c | 14 --
mm/page_io.c| 8 +++-
3 files changed, 9 inser
Overstreet
[dpark: also remove ->merge_bvec_fn() in dm-thin as well as
dm-era-target, and resolve merge conflicts]
Signed-off-by: Dongsu Park
Signed-off-by: Ming Lin
---
block/blk-merge.c | 17 +-
block/blk-settings.c | 22
drivers/block/drbd/drbd_in
ption in commit message]
Signed-off-by: Dongsu Park
Signed-off-by: Ming Lin
---
drivers/md/raid5.c | 23 +--
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 1ba97fd..b303ded 100644
--- a/drivers/md/raid5.c
+++ b/dr
more description in commit message]
Signed-off-by: Dongsu Park
Signed-off-by: Ming Lin
---
drivers/md/bcache/bcache.h| 18
drivers/md/bcache/io.c| 100 +-
drivers/md/bcache/journal.c | 4 +-
drivers/md/bcache/request.c | 16 +++
drive
lip Kelleher
Cc: Minchan Kim
Cc: Nitin Gupta
Cc: Oleg Drokin
Cc: Andreas Dilger
Signed-off-by: Kent Overstreet
[dpark: skip more mq-based drivers, resolve merge conflicts, etc.]
Signed-off-by: Dongsu Park
Signed-off-by: Ming Lin
---
block/blk-core.c| 1
The split code in blkdev_issue_discard() can go away now
that any driver that cares does the split.
Signed-off-by: Ming Lin
---
block/blk-lib.c | 73 +++--
1 file changed, 14 insertions(+), 59 deletions(-)
diff --git a/block/blk-lib.c b/block
: Neil Brown
Cc: linux-r...@vger.kernel.org
Acked-by: NeilBrown
Signed-off-by: Ming Lin
---
drivers/md/raid5.c | 37 -
1 file changed, 32 insertions(+), 5 deletions(-)
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index b303ded..b6c6ace 100644
--- a/drivers
On Sat, May 23, 2015 at 7:15 AM, Christoph Hellwig wrote:
> On Fri, May 22, 2015 at 11:18:32AM -0700, Ming Lin wrote:
>> This will bring not only performance improvements, but also a great amount
>> of reduction in code complexity all over the block layer. Performance gain
>&g
On Sun, May 24, 2015 at 10:48 PM, NeilBrown wrote:
> On Fri, 22 May 2015 11:18:38 -0700 Ming Lin wrote:
>
>> From: Kent Overstreet
>>
>> Remove bio_fits_rdev() completely, because ->merge_bvec_fn() has now
>> gone. There's no point in calling bio_fits_rd
On Mon, May 25, 2015 at 7:17 AM, Christoph Hellwig wrote:
> On Mon, May 25, 2015 at 05:54:14PM +1000, NeilBrown wrote:
>> Did I write that? I guess I did :-(
>> I meant *after*. Don't get rid of bio_fits_rdev until split_bio is in
>> chunk_aligned_read().
>
> I suspect the whole series could us
On Tue, May 26, 2015 at 7:36 AM, Mike Snitzer wrote:
> On Fri, May 22 2015 at 2:18pm -0400,
> Ming Lin wrote:
>
>> From: Kent Overstreet
>>
>> The way the block layer is currently written, it goes to great lengths
>> to avoid having to split bios; upper
On Tue, May 26, 2015 at 9:04 AM, Mike Snitzer wrote:
> On Tue, May 26 2015 at 11:02am -0400,
> Ming Lin wrote:
>
>> On Tue, May 26, 2015 at 7:36 AM, Mike Snitzer wrote:
>> > On Fri, May 22 2015 at 2:18pm -0400,
>> > Ming Lin wrote:
>> >
>> &
On Tue, May 26, 2015 at 7:33 AM, Ming Lin wrote:
> On Mon, May 25, 2015 at 7:17 AM, Christoph Hellwig wrote:
>> On Mon, May 25, 2015 at 05:54:14PM +1000, NeilBrown wrote:
>>> Did I write that? I guess I did :-(
>>> I meant *after*. Don't get rid of bio
On Tue, May 26, 2015 at 4:03 PM, NeilBrown wrote:
> On Tue, 26 May 2015 15:32:38 -0700 Ming Lin wrote:
>
>> On Tue, May 26, 2015 at 7:33 AM, Ming Lin wrote:
>> > On Mon, May 25, 2015 at 7:17 AM, Christoph Hellwig wrote:
>> >> On Mon, May 25, 2015 at
On Wed, May 6, 2015 at 12:26 AM, Christoph Hellwig wrote:
>> -static int chunk_aligned_read(struct mddev *mddev, struct bio * raid_bio)
>> +static int __chunk_aligned_read(struct mddev *mddev, struct bio *raid_bio)
>
> Call it raid5_read_one_chunk or something similar descriptive?
>
>> {
>>
e_bvec_fn() calls
md/raid5: get rid of bio_fits_rdev()
block: kill merge_bvec_fn() completely
fs: use helper bio_add_page() instead of open coding on bi_io_vec
md/raid10: make sync_request_write() call bio_copy_data()
Ming Lin (1):
md/raid5: split bio for chunk_ali
Cc: Chris Mason
Cc: Josef Bacik
Cc: linux-bt...@vger.kernel.org
Signed-off-by: Kent Overstreet
Signed-off-by: Chris Mason
[dpark: add more description in commit message]
Signed-off-by: Dongsu Park
Signed-off-by: Ming Lin
---
fs/btrfs/volumes.c |
: Neil Brown
Cc: linux-r...@vger.kernel.org
Signed-off-by: Ming Lin
---
drivers/md/raid5.c | 42 +-
1 file changed, 37 insertions(+), 5 deletions(-)
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 7f4a717..b18f548 100644
--- a/drivers/md/raid5.c
1 - 100 of 203 matches
Mail list logo
