Inotify fails to send IN_ATTRIB events

2007-11-20 Thread Morten Welinder
I am seeing missing inotify IN_ATTRIB events in the following situation: 1. touch foo 2. Make inotify watch foo 3. ln foo bar -- Link count changed so I should have gotten an IN_ATTRIB. 4. rm foo -- Link count changed so I should have gotten an IN_ATTRIB. (Or IN_DELETE_SELF; I don't

Re: Inotify fails to send IN_ATTRIB events

2007-11-22 Thread Morten Welinder
Wanna try the patch below? With this patch I am seeing a endless stream of IN_IGNORED events for a removed watch. I don't see a reason that user space should ever see any IN_IGNORED, but an endless steam is not good. Utterly unrelated, inotify does not work in /proc/. The list archives

Re: Inotify fails to send IN_ATTRIB events

2007-11-23 Thread Morten Welinder
This looks bad, though: include/linux/fsnotify.h:121: warning: passing argument 2 of 'audit_inode_child' from incompatible pointer type Missing -d_inode? M. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: Inotify fails to send IN_ATTRIB events

2007-11-23 Thread Morten Welinder
inotify can't handle a given virtual file. I'm not sure signed-off-by if appropriate for me, but at least... Acked-by: Morten Welinder [EMAIL PROTECTED] Morten - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: idio{,ma}tic typos (was Re: + fix-vm_can_nonlinear-check-in-sys_remap_file_pages.patch added to -mm tree)

2007-10-10 Thread Morten Welinder
While we're at it, below is somewhat ugly sparse patch for detecting 0x typos. Excellent idea, and there is something to be said about a low-footprint patch like that. However, if you really want to capture this kind of bugs, you would need to have some kind not a boolean or bitfield

Inotify fails to send IN_ATTRIB events

2007-11-20 Thread Morten Welinder
I am seeing missing inotify IN_ATTRIB events in the following situation: 1. "touch foo" 2. Make inotify watch "foo" 3. "ln foo bar" --> Link count changed so I should have gotten an IN_ATTRIB. 4. "rm foo" --> Link count changed so I should have gotten an IN_ATTRIB. (Or IN_DELETE_SELF;

Re: Inotify fails to send IN_ATTRIB events

2007-11-22 Thread Morten Welinder
> Wanna try the patch below? With this patch I am seeing a endless stream of IN_IGNORED events for a removed watch. I don't see a reason that user space should ever see any IN_IGNORED, but an endless steam is not good. Utterly unrelated, inotify does not work in /proc/. The list archives

Re: idio{,ma}tic typos (was Re: + fix-vm_can_nonlinear-check-in-sys_remap_file_pages.patch added to -mm tree)

2007-10-10 Thread Morten Welinder
> While we're at it, below is somewhat ugly sparse patch for detecting > "&& 0x" typos. Excellent idea, and there is something to be said about a low-footprint patch like that. However, if you really want to capture this kind of bugs, you would need to have some kind "not a boolean" or

Re: Inotify fails to send IN_ATTRIB events

2007-11-23 Thread Morten Welinder
This looks bad, though: include/linux/fsnotify.h:121: warning: passing argument 2 of 'audit_inode_child' from incompatible pointer type Missing "->d_inode"? M. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: Inotify fails to send IN_ATTRIB events

2007-11-23 Thread Morten Welinder
S when inotify can't handle a given virtual file. I'm not sure "signed-off-by" if appropriate for me, but at least... Acked-by: Morten Welinder <[EMAIL PROTECTED]> Morten - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m