[PATCH 1/3] Add BOOT_PARTITION_ENABLE definition to MMC EXT_CSD PART_CONFIG

2013-04-19 Thread Neil Armstrong
Add bit mask for the BOOT_PARTITION_ENABLE values. Signed-off-by: Neil Armstrong narmstr...@neotion.com --- include/linux/mmc/mmc.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/mmc/mmc.h b/include/linux/mmc/mmc.h index 50bcde3..eb5b361 100644

[PATCH 0/3] Add boot_enable attribute to eMMC device for boot mode operation selection

2013-04-19 Thread Neil Armstrong
eMMC conforming with eMMC 4.5 specifications. Neil Armstrong (3): Add BOOT_PARTITION_ENABLE definition to MMC EXT_CSD PART_CONFIG Add boot_enable sysfs attribute to select MMC boot operation partition Add Documentation for MMC boot_enable attribute Documentation/mmc/mmc-dev-parts.txt

[PATCH 2/3] Add boot_enable sysfs attribute to select MMC boot operation partition

2013-04-19 Thread Neil Armstrong
Add sysfs attribute to select the eMMC boot mode operation according to the eMMC 4.5 specifications. Valid values are : 0 for disabled, 1 for first boot partition, 2 for second boot partition, 7 for user area. Signed-off-by: Neil Armstrong narmstr...@neotion.com --- drivers/mmc/card/block.c

[PATCH 3/3] Add Documentation for MMC boot_enable attribute

2013-04-19 Thread Neil Armstrong
Add documentation on the enable_boot sysfs attribute. Signed-off-by: Neil Armstrong narmstr...@neotion.com --- Documentation/mmc/mmc-dev-parts.txt |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/Documentation/mmc/mmc-dev-parts.txt b/Documentation/mmc/mmc-dev

Re: [PATCH 0/3] Add boot_enable attribute to eMMC device for boot mode operation selection

2013-04-22 Thread Neil Armstrong
On 04/22/2013 06:55 AM, Namjae Jeon wrote: 2013/4/19, Neil Armstrong narmstr...@neotion.com: Since eMMC 4.3 a special boot mode operation was introduced to retrieve data from the eMMC device with a very simple procedure. Since the Linux kernel exports these device boot partitions, it may

[PATCH] Fix coding style issue in xlr_net.c

2014-03-28 Thread Neil Armstrong
checkpatch script returns the following warning: WARNING: line over 80 characters 310: FILE: drivers/staging/netlogic/xlr_net.c:310: + void *accel_priv, select_queue_fallback_t fallback) This patch fixes the coding style issue. Signed-off-by: Neil Armstrong superna9...@gmail.com

[PATCH] Staging: netlogic: long lines in xlr_net.c

2014-03-28 Thread Neil Armstrong
checkpatch script returns the following warning: WARNING: line over 80 characters 310: FILE: drivers/staging/netlogic/xlr_net.c:310: + void *accel_priv, select_queue_fallback_t fallback) This patch fixes the coding style issue. Signed-off-by: Neil Armstrong superna9...@gmail.com

[PATCH] staging: rts5139: fix bad symbol declaration

2014-04-11 Thread Neil Armstrong
With sparse, the following error appears : CHECK drivers/staging/rts5139/ms_mg.c drivers/staging/rts5139/ms_mg.c:82:5: warning: symbol 'mg_set_tpc_para_sub' was not declared. Should it be static? Rename function with correct prefix and move declaration to coherent internal header file.

[PATCH] staging: vt6656: fix bad symbol declaration

2014-04-11 Thread Neil Armstrong
With sparse, the following error appears : CHECK drivers/staging/vt6656/aes_ccmp.c drivers/staging/vt6656/aes_ccmp.c:221:6: warning: symbol 'AESbGenCCMP' was not declared. Should it be static? Add correct include header in order to have function declaration. Signed-off-by: Neil 'Superna'

[PATCH] staging: wlan-ng: fix bad symbol declaration

2014-04-11 Thread Neil Armstrong
With sparse, the following error appears : CHECK drivers/staging/wlan-ng/p80211netdev.c drivers/staging/wlan-ng/cfg80211.c:710:6: warning: symbol 'prism2_connect_result' was not declared. Should it be static? drivers/staging/wlan-ng/cfg80211.c:719:6: warning: symbol 'prism2_disconnected' was

[PATCH] Staging: silicom: fix dangerous if condition in bpctl_mod.c

2014-04-01 Thread Neil Armstrong
checkpatch script returns the following warning: ERROR: do not use assignment in if condition + if (((dev_num = get_dev_idx(dev-ifindex)) == -1) | This patch fixes the if condition by splitting it. Signed-off-by: Neil Armstrong superna9...@gmail.com --- drivers

[PATCH 0/2] net: macb: Handle RX errors

2014-07-18 Thread Neil Armstrong
to reuse the RX ring init. Neil Armstrong (2): net: macb: Separate rx and tx ring init function net: macb: Handle errors in RX path drivers/net/ethernet/cadence/macb.c | 88 +-- drivers/net/ethernet/cadence/macb.h |3 +- 2 files changed, 76 insertions

[PATCH 2/2] net: macb: Handle errors in RX path

2014-07-18 Thread Neil Armstrong
into poll method by using the same error management. Signed-off-by: Neil Armstrong narmstr...@neotion.com --- drivers/net/ethernet/cadence/macb.c | 55 +++--- 1 files changed, 50 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers

[PATCH 1/2] net: macb: Separate rx and tx ring init function

2014-07-18 Thread Neil Armstrong
A single method is called to initialize the TX and RX rings. Separate the methods into distinct ones for MACB and GEM context. Signed-off-by: Neil Armstrong narmstr...@neotion.com --- drivers/net/ethernet/cadence/macb.c | 33 - drivers/net/ethernet/cadence

Re: [PATCH 1/2] net: macb: Separate rx and tx ring init function

2014-07-18 Thread Neil Armstrong
Le 18/07/2014 12:10, Varka Bhadram a écrit : On 07/18/2014 03:22 PM, Neil Armstrong wrote: A single method is called to initialize the TX and RX rings. Separate the methods into distinct ones for MACB and GEM context. Signed-off-by: Neil Armstrong narmstr...@neotion.com --- drivers/net

[PATCH 2/2 v2] net: macb: Handle errors in RX path

2014-07-18 Thread Neil Armstrong
into poll method by using the same error management. Signed-off-by: Neil Armstrong narmstr...@neotion.com --- drivers/net/ethernet/cadence/macb.c | 54 +++--- 1 files changed, 49 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers

[PATCH v2 1/2] net: macb: Separate rx and tx ring init function

2014-07-18 Thread Neil Armstrong
A single method is called to initialize the TX and RX rings. Separate the methods into distinct ones for MACB and GEM contexts. Also remove the multiple assignments from the original code. Signed-off-by: Neil Armstrong narmstr...@neotion.com --- drivers/net/ethernet/cadence/macb.c | 36

[PATCH v2 2/2] net: macb: Handle errors in RX path

2014-07-18 Thread Neil Armstrong
into poll method by using the same error management. Signed-off-by: Neil Armstrong narmstr...@neotion.com --- drivers/net/ethernet/cadence/macb.c | 54 +++--- 1 files changed, 49 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers

[PATCH v2 0/2] net: macb: Handle RX errors

2014-07-18 Thread Neil Armstrong
to reuse the RX ring init. v2: fix multiple assignments in first patch, fix checkpatch errors in second patch. Neil Armstrong (2): net: macb: Separate rx and tx ring init function net: macb: Handle errors in RX path drivers/net/ethernet/cadence/macb.c | 90

[PATCH RFC] usb: gadget: dwc2: make driver run on a version 3.10a instance of DWC_OTG

2014-08-13 Thread Neil Armstrong
stuck with weird HW beheviours Signed-off-by: Neil Armstrong narmstr...@neotion.com --- drivers/usb/dwc2/core.h | 14 +++ drivers/usb/dwc2/gadget.c | 267 +++-- 2 files changed, 221 insertions(+), 60 deletions(-) This is mainly an RFC in order

[PATCH 1/3] net: phy: Add nested variants of mdiobus read/write

2015-10-22 Thread Neil Armstrong
Since nested variants of mdiobus_read/write are used in multiple drivers, add nested variants in the mdiobus core. Suggested-by: Andrew Lunn <and...@lunn.ch> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/net/phy/mdi

[PATCH 0/3] Refactor nested mdiobus read/write functions

2015-10-22 Thread Neil Armstrong
by mv88e6xxx and mv88e6060. In a next patch, mdio-mux should also use these variant calls. Neil Armstrong (3): net: phy: Add nested variants of mdiobus read/write net: dsa: Make mv88e6xxx use nested mdiobus read/write net: dsa: Make mv88e6060 use nested mdiobus read/write drivers/net/dsa

Re: [PATCH] net: dsa: mv88e6060: Fix false positive lockdep splat

2015-10-22 Thread Neil Armstrong
On 10/21/2015 06:14 PM, Andrew Lunn wrote: > On Wed, Oct 21, 2015 at 05:37:45PM +0200, Neil Armstrong wrote: >> Like the change made for mv88e6xxx, use mutex_lock_nested() to avoid >> lockdep to give false positives because of nested MDIO busses. > > Hi Neil > >

Re: [PATCH] net: dsa: mv88e6060: Fix false positive lockdep splat

2015-10-22 Thread Neil Armstrong
On 10/21/2015 06:14 PM, Andrew Lunn wrote: > On Wed, Oct 21, 2015 at 05:37:45PM +0200, Neil Armstrong wrote: >> Like the change made for mv88e6xxx, use mutex_lock_nested() to avoid >> lockdep to give false positives because of nested MDIO busses. > > Hi Neil > >

Re: [PATCH] net: dsa: mv88e6060: Fix false positive lockdep splat

2015-10-22 Thread Neil Armstrong
Hi Andrew, On 10/21/2015 06:14 PM, Andrew Lunn wrote: > On Wed, Oct 21, 2015 at 05:37:45PM +0200, Neil Armstrong wrote: >> Like the change made for mv88e6xxx, use mutex_lock_nested() to avoid >> lockdep to give false positives because of nested MDIO busses. > > Hi Neil &

[PATCH] net: dsa: mv88e6060: Fix false positive lockdep splat

2015-10-21 Thread Neil Armstrong
Like the change made for mv88e6xxx, use mutex_lock_nested() to avoid lockdep to give false positives because of nested MDIO busses. The false positive was observed using a mv88e6060 from a TI816X SoC. Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/net/dsa/mv88e6060.

[PATCH 3/3] net: dsa: Make mv88e6060 use nested mdiobus read/write

2015-10-22 Thread Neil Armstrong
Like mv88e6xxx and mdio-mux, to avoid lockdep give false positives because of nested MDIO busses, switch to previously introduced nested mdiobus_read/write variants. Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/net/dsa/mv88e6060.c | 4 ++-- 1 file changed, 2 inse

[PATCH 3/4] arm: dts: add dm816x pwm property to timers

2015-10-22 Thread Neil Armstrong
Adds ti,timer-pwm property to timers 4 to 7 to permit usage of their PWM output fonctionnality via the dmtimer driver. Cc: Brian Hutchinson <b.hutch...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- arch/arm/boot/dts/dm816x.dtsi | 4 1 file changed,

[PATCH 1/4] arm: omap2+: add missing HWMOD_NO_IDLEST in 81xx hwmod data

2015-10-22 Thread Neil Armstrong
Add missing HWMOD_NO_IDLEST hwmod flag for entries no having omap4 clkctrl values. Cc: Brian Hutchinson <b.hutch...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 3 +++ 1 file changed, 3 insertions(+) diff --gi

[PATCH 4/4] arm: omap2+: Add hwmod spinbox support for dm816x

2015-10-22 Thread Neil Armstrong
Add dm81xx hwmod data entries for dm816x spinbox support. Cc: Brian Hutchinson <b.hutch...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 35 ++ 1 file changed, 35 insertions(+) diff

[PATCH 2/4] clk: ti816x: Add missing dmtimer clkdev entries

2015-10-22 Thread Neil Armstrong
Add missing clkdev dmtimer related entries for dm816x. 32Khz and ext sources were missing. Cc: Brian Hutchinson <b.hutch...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/clk/ti/clk-816x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/driver

[PATCH 0/4] arm: dts: complete dm816x device tree

2015-10-22 Thread Neil Armstrong
In order to fix support for the dm816x platform, add missing bits in the dm816x dtsi. The last patch adds support for the omap4-hwspinlock. Neil Armstrong (4): arm: dts: add dm816x missing #mbox-cells arm: dts: add dm816x missing spi DT dma handles arm: dts: add dm816x pwm property

[PATCH 1/4] arm: dts: add dm816x missing #mbox-cells

2015-10-22 Thread Neil Armstrong
Add missing #mbox-cells for dm816x mbox DT node. Cc: Brian Hutchinson <b.hutch...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- arch/arm/boot/dts/dm816x.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/dm816x.dtsi b/arch/arm/boot/dts

[PATCH 2/4] arm: dts: add dm816x missing spi DT dma handles

2015-10-22 Thread Neil Armstrong
Add the missing SPI controller DMA handler in the dm816x DT node, only properties for the two channels on four were present. Cc: Brian Hutchinson <b.hutch...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- arch/arm/boot/dts/dm816x.dtsi | 7 +-- 1 fil

[PATCH 4/4] arm: dts: Add omap4-hwspinlock support in dm816x

2015-10-22 Thread Neil Armstrong
Add dm816x DT entries for omap4-hwspinlock support as hwmod spinbox. Cc: Brian Hutchinson <b.hutch...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- arch/arm/boot/dts/dm816x.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/d

[PATCH 0/4] arm: omap2+: complete dm816x hwmod and clkdev

2015-10-22 Thread Neil Armstrong
In order to fix support for the dm816x platform, add missing bits in the 81xx hwmod data. The clk related patch adds the missing clkdev entries to fix all source selection in the dmtimer driver. The last patch adds hwmod support of the spinbox module. Neil Armstrong (4): arm: omap2+: add

[PATCH 3/4] arm: plat-omap: add DT support for ti,dm816-timer

2015-10-22 Thread Neil Armstrong
Adds ti,dm816-timer to the dmtimer OF match table. Cc: Brian Hutchinson <b.hutch...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- arch/arm/plat-omap/dmtimer.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/a

Re: [PATCH v2 5/6] net: dsa: add missing calls in dsa_switch_destroy

2015-10-29 Thread Neil Armstrong
On 10/29/2015 03:00 PM, Andrew Lunn wrote: > On Thu, Oct 29, 2015 at 02:23:25PM +0100, Neil Armstrong wrote: >> >> +netif_carrier_off(ds->ports[port]); >> unregister_netdev(ds->ports[port]); >> +phy_disconnect(p->phy); >&g

[PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-29 Thread Neil Armstrong
[] (irq_exit+0xac/0x10c) (irq_exit) from [] (__handle_domain_irq+0x50/0xa8) Signed-off-by: Frode Isaksen <fisak...@baylibre.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- include/net/dsa.h | 3 +-- net/dsa/dsa.c | 28 2 files changed,

[PATCH v2 4/6] net: dsa: Add missing master netdev dev_put() calls

2015-10-29 Thread Neil Armstrong
Upon probe failure or unbinding, add missing dev_put() calls on master netdev. Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- net/dsa/dsa.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index b2f696c..597a462 100644 ---

[PATCH v2 6/6] net: dsa: move dsa slave destroy code to slave.c

2015-10-29 Thread Neil Armstrong
Move dsa slave dedicated code from dsa_switch_destroy to a new dsa_slave_destroy function in slave.c Signed-off-by: Frode Isaksen <fisak...@baylibre.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- net/dsa/dsa.c | 5 + net/dsa/dsa_priv.h | 1 + net/dsa/sla

[PATCH v2 5/6] net: dsa: add missing calls in dsa_switch_destroy

2015-10-29 Thread Neil Armstrong
Add missing netif_carrier_off and phy_disconnect calls to the dsa_switch_destroy function to make sure the netdev and phy ressources are clean before complete removal. Signed-off-by: Frode Isaksen <fisak...@baylibre.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- n

[PATCH v2 0/6] Further fix for dsa unbinding

2015-10-29 Thread Neil Armstrong
in dsa_switch_destroy then add dedicated dsa_slave_destroy Frode Isaksen (4): net: dsa: Use delayed work instead of timer+work for polling net: dsa: Do not reschedule polling if driver removed net: dsa: add missing calls in dsa_switch_destroy net: dsa: move dsa slave destroy code to slave.c Neil

Re: [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-29 Thread Neil Armstrong
On 10/29/2015 02:51 PM, Andrew Lunn wrote: > On Thu, Oct 29, 2015 at 02:22:41PM +0100, Neil Armstrong wrote: > Hi Neil, Frode > > I assume you have see: > > http://permalink.gmane.org/gmane.linux.network/380777 > > which is now in net-next. > > The only

[PATCH v2 2/6] net: dsa: Do not reschedule polling if driver removed

2015-10-29 Thread Neil Armstrong
... (run_timer_softirq) from [] (__do_softirq+0xcc/0x320) (__do_softirq) from [] (irq_exit+0xac/0x10c) (irq_exit) from [] (__handle_domain_irq+0x50/0xa8) Signed-off-by: Frode Isaksen <fisak...@baylibre.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- net/dsa/dsa.c | 4

[PATCH v2 3/6] net: dsa: cleanup resources upon module removal

2015-10-29 Thread Neil Armstrong
Make sure that we unassign the master_netdev dsa_ptr to make the packet processing go through the regulard Ethernet receive path. Suggested-by: Florian Fainelli <f.faine...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- net/dsa/dsa.c | 8 1 fil

[RFC PATCH v2 1/4] net: dsa: allow switch drivers to cleanup their resources

2015-10-28 Thread Neil Armstrong
Some switch drivers might request interrupts, remap register ranges, allow such drivers to implement a "remove" callback doing just that. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- include/net/dsa.

[RFC PATCH v2 2/4] net: dsa: bcm_sf2: cleanup resources in remove callback

2015-10-28 Thread Neil Armstrong
Implement a remove callback allowing the switch driver to cleanup resources it used: interrupts and remapped register ranges. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/net/dsa/bcm_sf2.c | 20 +++

[RFC PATCH v2 0/4] net: dsa: cleanup dsa driver

2015-10-28 Thread Neil Armstrong
Introduce a new remove callback to allow DSA drivers to cleanup their ressources. Then add a remove implementation for bcm_sf2 and mv88e6xxx. This patch was not tested due of a lack of hardware. v2: add remove callback patch to the serie Neil Armstrong (4): net: dsa: allow switch drivers

Re: [PATCH 6/6] net: phy: Stop 'phy-state-machine' and 'phy_change' work on remove

2015-10-28 Thread Neil Armstrong
> > void phy_disconnect(struct phy_device *phydev) > > { > > if (phydev->irq > 0) > > phy_stop_interrupts(phydev); > > > > phy_stop_machine(phydev); > > > > phydev->adjust_link = NULL; > > > >

Re: [RFC PATCH v2 3/4] net: dsa: mv88e6xxx: add common and ppu remove function

2015-10-28 Thread Neil Armstrong
Hi Andrew, On 10/28/2015 03:35 PM, Andrew Lunn wrote: > On Wed, Oct 28, 2015 at 03:13:16PM +0100, Neil Armstrong wrote: >> diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c >> index b1b14f5..6287096 100644 >> --- a/drivers/net/dsa/mv88e6xxx.c >

Re: [PATCH 2/6] net: dsa: allow switch drivers to cleanup their resources

2015-10-28 Thread Neil Armstrong
On 10/27/2015 05:59 PM, Vivien Didelot wrote: > On Oct. Tuesday 27 (44) 04:43 PM, Neil Armstrong wrote: >> >> Yes, I didn't know how to handle this since it was part of a larger patch. >> >> I forgot to add this into the cover-letter but I wanted to send an RFC serie

[RFC PATCH v2 3/4] net: dsa: mv88e6xxx: add common and ppu remove function

2015-10-28 Thread Neil Armstrong
With the previously introduced remove callback, add a mv88e6xxx common remove function to cleanup all resources. Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/net/dsa/mv88e6xxx.c | 18 ++ drivers/net/dsa/mv88e6xxx.h | 2 ++ 2 files changed, 20 inse

[RFC PATCH v2 4/4] net: dsa: make usage of mv88e6xxx common remove function

2015-10-28 Thread Neil Armstrong
Make usage of previously introduced mv88e6xxx common remove function in all mv88e6xxx drivers. Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/net/dsa/mv88e6123_61_65.c | 1 + drivers/net/dsa/mv88e6131.c | 8 drivers/net/dsa/mv88e6171.c | 1 + drive

[RFC PATCH v3 5/5] net: dsa: add mv88e6xxx ppu remove function for mv88e6131

2015-10-29 Thread Neil Armstrong
The mv88e6131 also need to call remove for the ppu part of mv88e6xxx. Add the ppu remove function and add a mv88e6131 specific remove callback calling the ppu remove function. Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/net/dsa/mv88e6131.c | 9 - drivers/n

[RFC PATCH v3 3/5] net: dsa: mv88e6xxx: add common remove function

2015-10-29 Thread Neil Armstrong
With the previously introduced remove callback, add a mv88e6xxx common remove function to cleanup all resources. Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/net/dsa/mv88e6xxx.c | 8 drivers/net/dsa/mv88e6xxx.h | 1 + 2 files changed, 9 insertions(+) diff

[RFC PATCH v3 4/5] net: dsa: make usage of mv88e6xxx common remove function

2015-10-29 Thread Neil Armstrong
Make usage of previously introduced mv88e6xxx common remove function in all mv88e6xxx drivers. Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/net/dsa/mv88e6123_61_65.c | 1 + drivers/net/dsa/mv88e6131.c | 1 + drivers/net/dsa/mv88e6171.c | 1 + drivers/n

[RFC PATCH v3 2/5] net: dsa: bcm_sf2: cleanup resources in remove callback

2015-10-29 Thread Neil Armstrong
Implement a remove callback allowing the switch driver to cleanup resources it used: interrupts and remapped register ranges. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/net/dsa/bcm_sf2.c | 20 +++

[RFC PATCH v3 1/5] net: dsa: allow switch drivers to cleanup their resources

2015-10-29 Thread Neil Armstrong
Some switch drivers might request interrupts, remap register ranges, allow such drivers to implement a "remove" callback doing just that. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- include/net/dsa.

[RFC PATCH v3 0/5] net: dsa: cleanup dsa driver

2015-10-29 Thread Neil Armstrong
atch Neil Armstrong (5): net: dsa: allow switch drivers to cleanup their resources net: dsa: bcm_sf2: cleanup resources in remove callback net: dsa: mv88e6xxx: add common remove function net: dsa: make usage of mv88e6xxx common remove function net: dsa: add mv88e6xxx ppu remove func

Re: [RFC PATCH v3 1/5] net: dsa: allow switch drivers to cleanup their resources

2015-10-29 Thread Neil Armstrong
On 10/29/2015 03:50 PM, Andrew Lunn wrote: > On Thu, Oct 29, 2015 at 03:45:24PM +0100, Neil Armstrong wrote: >> --- a/net/dsa/dsa.c >> +++ b/net/dsa/dsa.c >> @@ -459,6 +459,10 @@ static void dsa_switch_destroy(struct dsa_switch *ds) >> } >> >>

Re: [PATCH 1/4] arm: omap2+: add missing HWMOD_NO_IDLEST in 81xx hwmod data

2015-10-24 Thread Neil Armstrong
Hi, 2015-10-24 3:21 GMT+02:00 Tony Lindgren <t...@atomide.com>: > > Hi, > > * Neil Armstrong <narmstr...@baylibre.com> [151022 02:19]: > > Add missing HWMOD_NO_IDLEST hwmod flag for entries no > > having omap4 clkctrl values. > > Have you checked this

[PATCH 6/6] net: phy: Stop 'phy-state-machine' and 'phy_change' work on remove

2015-10-27 Thread Neil Armstrong
Avoids: Unable to handle kernel NULL pointer dereference at virtual address 0064 Workqueue: events_power_efficient phy_state_machine PC is at phy_state_machine+0x28/0x480 Signed-off-by: Frode Isaksen <fisak...@baylibre.com> Signed-off-by: Neil Armstrong <narmstr...@bay

[PATCH 3/6] net: dsa: cleanup resources upon module removal

2015-10-27 Thread Neil Armstrong
Make sure that we unassign the master_netdev dsa_ptr to make the packet processing go through the regular Ethernet receive path. Suggested-by: Florian Fainelli <f.faine...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- net/dsa/dsa.c | 8 1 fil

[PATCH 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-27 Thread Neil Armstrong
[] (irq_exit+0xac/0x10c) (irq_exit) from [] (__handle_domain_irq+0x50/0xa8) Signed-off-by: Frode Isaksen <fisak...@baylibre.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- include/net/dsa.h | 3 +-- net/dsa/dsa.c | 28 2 files changed,

[PATCH 2/6] net: dsa: allow switch drivers to cleanup their resources

2015-10-27 Thread Neil Armstrong
Some switch drivers might request interrupts, remap register ranges, allow such drivers to implement a "remove" callback doing just that. Suggested-by: Florian Fainelli <f.faine...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- include/net/dsa.

[PATCH 4/6] net: dsa: Add missing master netdev dev_put() calls

2015-10-27 Thread Neil Armstrong
Upon probe failure or unbinding, add missing dev_put() calls. Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- net/dsa/dsa.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index acbf854..9240a46 100644 --- a/net/dsa/dsa.c

Re: [PATCH 2/6] net: dsa: allow switch drivers to cleanup their resources

2015-10-27 Thread Neil Armstrong
Hi, On 10/27/2015 04:39 PM, Florian Fainelli wrote: > On 27/10/15 07:48, Neil Armstrong wrote: >> Some switch drivers might request interrupts, remap register ranges, >> allow such drivers to implement a "remove" callback doing just that. >> >> Suggested-by: F

[PATCH 5/6] net: dsa: Do not reschedule polling if driver removed

2015-10-27 Thread Neil Armstrong
... (run_timer_softirq) from [] (__do_softirq+0xcc/0x320) (__do_softirq) from [] (irq_exit+0xac/0x10c) (irq_exit) from [] (__handle_domain_irq+0x50/0xa8) Signed-off-by: Frode Isaksen <fisak...@baylibre.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- net/dsa/dsa.c | 4

[PATCH 0/6] Further fix for dsa unbinding

2015-10-27 Thread Neil Armstrong
of timer+work for polling net: dsa: Do not reschedule polling if driver removed net: phy: Stop 'phy-state-machine' and 'phy_change' work on remove Neil Armstrong (3): net: dsa: allow switch drivers to cleanup their resources net: dsa: cleanup resources upon module removal net: dsa: Add

[RFC PATCH 3/3] net: dsa: make usage of mv88e6xxx common remove function

2015-10-27 Thread Neil Armstrong
Make usage of previously introduced mv88e6xxx common remove function in all mv88e6xxx drivers. Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/net/dsa/mv88e6123_61_65.c | 1 + drivers/net/dsa/mv88e6131.c | 8 drivers/net/dsa/mv88e6171.c | 1 + drive

[RFC PATCH 1/3] net: dsa: bcm_sf2: cleanup resources in remove callback

2015-10-27 Thread Neil Armstrong
Implement a remove callback allowing the switch driver to cleanup resources it used: interrupts and remapped register ranges. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/net/dsa/bcm_sf2.c | 20 +++

[RFC PATCH 2/3] net: dsa: mv88e6xxx: add common and ppu remove function

2015-10-27 Thread Neil Armstrong
With the previously introduced remove callback, add a mv88e6xxx common remove function to cleanup all ressources. Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/net/dsa/mv88e6xxx.c | 18 ++ drivers/net/dsa/mv88e6xxx.h | 2 ++ 2 files changed, 20 inse

[RFC PATCH 0/3] net: dsa: cleanup dsa driver

2015-10-27 Thread Neil Armstrong
With the previously introduced remove callback for DSA driver in : http://marc.info/?i=562F8ED7.2000804%40baylibre.com Add remove callback for bcm_sf2 and mv88e6xxx drivers. This patch was not tested due of a lack of hardware. Neil Armstrong (3): net: dsa: bcm_sf2: cleanup resources in remove

[PATCH 2/3] net: dsa: Make mv88e6xxx use nested mdiobus read/write

2015-10-22 Thread Neil Armstrong
Make the mv88e6xxx driver use the previously introduced nested variants of mdiobus_read/write functions. Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/net/dsa/mv88e6xxx.c | 46 + 1 file changed, 9 insertions(+), 37 del

[PATCH v2 3/6] net: dsa: mv88e6060: use the correct MaxFrameSize bit

2015-11-10 Thread Neil Armstrong
According to the mv88e6060 datasheet, the MaxFrameSize bit position is 10 instead of 11 which is reserved. Use the bit correctly to setup max frame size to 1536. Acked-by: Andrew Lunn <and...@lunn.ch> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/net/dsa/mv8

[PATCH v2 6/6] net: dsa: mv88e6060: replace magic values with register defines

2015-11-10 Thread Neil Armstrong
To align with the mv88e6xxx code, use the register defines to access all the register addresses and bit fields. Acked-by: Andrew Lunn <and...@lunn.ch> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/net/dsa/mv88e6060.c | 64 ++--

[PATCH v2 5/6] net: dsa: mv88e6060: add register defines header file

2015-11-10 Thread Neil Armstrong
To align with the mv88e6xxx code, add a similar header file with all the register defines. The file is based on the mv88e6xxx header for coherency. Acked-by: Andrew Lunn <and...@lunn.ch> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/net/dsa/mv88e

[PATCH v2 0/6] net: dsa: mv88e6060: cleanup and fix setup

2015-11-10 Thread Neil Armstrong
. v2: cleanup InitReady patch, add missing Acked-by and fix header copyright notice Neil Armstrong (6): net: dsa: mv88e6060: remove poll_link callback net: dsa: mv88e6060: use the correct InitReady bit net: dsa: mv88e6060: use the correct MaxFrameSize bit net: dsa: mv88e6060: use

[PATCH v2 1/6] net: dsa: mv88e6060: remove poll_link callback

2015-11-10 Thread Neil Armstrong
As of mv88e6xxx remove the poll_link callback since the link state change polling is now handled by the phylib. Tested on a mv88e6060 B0 device with a TI DM816X SoC. Suggested-by: Andrew Lunn <and...@lunn.ch> Acked-by: Andrew Lunn <and...@lunn.ch> Signed-off-by: Neil Armstr

[PATCH v2 2/6] net: dsa: mv88e6060: use the correct InitReady bit

2015-11-10 Thread Neil Armstrong
According to the mv88e6060 datasheet, the InitReady bit position is 11 and the polarity is inverted. Use the bit correctly to detect the end of initialization. Acked-by: Andrew Lunn <and...@lunn.ch> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/net/dsa/mv88e6060

[PATCH v2 4/6] net: dsa: mv88e6060: use the correct bit shift for mac0

2015-11-10 Thread Neil Armstrong
.ch> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/net/dsa/mv88e6060.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6060.c b/drivers/net/dsa/mv88e6060.c index 10647ad..cd08079 100644 --- a/drivers/net/dsa/mv88e6060.c +++ b/dri

[RFC PATCH v3 1/2] base: dma-coherent: Add DT property for non exclusive shared-dma-pool

2015-11-10 Thread Neil Armstrong
In order to have the ability to declare a non exclusive shared-dma-pool, i.e. without the DMA_MEMORY_EXCLUSIVE flag, add the 'no-exclusive' DT optional parameter to initialize the coherent memory without the flag. Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/ba

[RFC PATCH v3 0/2] Expose DMA_MEMORY_EXCLUSIVE through shared-dma-pool

2015-11-10 Thread Neil Armstrong
The shared-dma-pool dt node only exposes exclusive memory, but in order to export non-exclusive coherent memory, add the no-exclusive property and document it. v3: use correct of_get_flat_dt_prop helper v2: simplify patch by looking for DT attribute in callback Neil Armstrong (2): base: dma

[RFC PATCH v3 2/2] devicetree: reserved-memory: document the optional no-exclusive parameter

2015-11-10 Thread Neil Armstrong
Document the 'no-exclusive' parameter used for the 'shared-dma-pool' compatible reserved-memory type. Acked-by: Rob Herring <r...@kernel.org> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt | 3 +++ 1

[PATCH v2 5/5] arm: dts: Add omap4-hwspinlock support in dm816x

2015-11-12 Thread Neil Armstrong
Add dm816x DT entries for omap4-hwspinlock support as hwmod spinbox. Cc: Brian Hutchinson <b.hutch...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- arch/arm/boot/dts/dm816x.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/d

[PATCH v2 3/5] arm: dts: add dm816x pwm property to timers

2015-11-12 Thread Neil Armstrong
Adds ti,timer-pwm property to timers 4 to 7 to permit usage of their PWM output fonctionnality via the dmtimer driver. Cc: Brian Hutchinson <b.hutch...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- arch/arm/boot/dts/dm816x.dtsi | 4 1 file changed,

[PATCH v2 2/5] arm: dts: add dm816x missing spi DT dma handles

2015-11-12 Thread Neil Armstrong
Add the missing SPI controller DMA handler in the dm816x DT node, only properties for the two channels on four were present. Cc: Brian Hutchinson <b.hutch...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- arch/arm/boot/dts/dm816x.dtsi | 7 +-- 1 fil

[PATCH v2 0/5] arm: dts: complete dm816x device tree

2015-11-12 Thread Neil Armstrong
In order to fix support for the dm816x platform, add missing bits in the dm816x dtsi and cleanup OCP. The last patch adds support for the omap4-hwspinlock. v2: add ocp hwmod cleanup Neil Armstrong (5): arm: dts: add dm816x missing #mbox-cells arm: dts: add dm816x missing spi DT dma handles

[PATCH v2 4/5] arm: dts: remove dm816x invalid DT l3_main hwmod

2015-11-12 Thread Neil Armstrong
Remove invalid l3_main hwmod entry from dm816x DT ocp node. Cc: Brian Hutchinson <b.hutch...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- arch/arm/boot/dts/dm816x.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/boot/dts/dm816x.dtsi b/arch/

Re: [PATCH v2 0/6] net: dsa: mv88e6060: cleanup and fix setup

2015-11-12 Thread Neil Armstrong
On 11/10/2015 05:14 PM, Andrew Lunn wrote: > On Tue, Nov 10, 2015 at 04:51:09PM +0100, Neil Armstrong wrote: >> This patchset introduces some fixes and a registers addressing cleanup for >> the mv88e6060 DSA driver. > > Hi Neil > > It is normal for netdev to put into t

[PATCH v2 1/5] arm: dts: add dm816x missing #mbox-cells

2015-11-12 Thread Neil Armstrong
Add missing #mbox-cells for dm816x mbox DT node. Cc: Brian Hutchinson <b.hutch...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- arch/arm/boot/dts/dm816x.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/dm816x.dtsi b/arch/arm/boot/dts

Re: [PATCH 1/4] arm: omap2+: add missing HWMOD_NO_IDLEST in 81xx hwmod data

2015-11-12 Thread Neil Armstrong
On 10/24/2015 12:09 PM, Neil Armstrong wrote: > Hi, > > 2015-10-24 3:21 GMT+02:00 Tony Lindgren <t...@atomide.com>: >> >> Hi, >> >> * Neil Armstrong <narmstr...@baylibre.com> [151022 02:19]: >>> Add missing HWMOD_NO_IDLEST hwmod flag for entr

Re: [PATCH v2 0/5] arm: dts: complete dm816x device tree

2015-11-13 Thread Neil Armstrong
On 11/12/2015 06:47 PM, Tony Lindgren wrote: > * Neil Armstrong <narmstr...@baylibre.com> [151112 06:08]: >> In order to fix support for the dm816x platform, add missing bits in >> the dm816x dtsi and cleanup OCP. > > Which ones are needed as fixes for the v4.4-rc kern

[PATCH v2 4/4] arm: omap2+: Add hwmod spinbox support for dm816x

2015-11-13 Thread Neil Armstrong
Add dm81xx hwmod data entries for dm816x spinbox support. Cc: Brian Hutchinson <b.hutch...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 35 ++ 1 file changed, 35 insertions(+) diff

[PATCH v2 1/4] arm: omap2+: add missing HWMOD_NO_IDLEST in 81xx hwmod data

2015-11-13 Thread Neil Armstrong
tch...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c index b1288f5..6256052 10064

[PATCH v2 3/4] arm: plat-omap: add DT support for ti,dm816-timer

2015-11-13 Thread Neil Armstrong
Adds ti,dm816-timer to the dmtimer OF match table. Cc: Brian Hutchinson <b.hutch...@gmail.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- arch/arm/plat-omap/dmtimer.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/a

[PATCH v2 0/4] arm: omap2+: complete dm816x hwmod and clkdev

2015-11-13 Thread Neil Armstrong
In order to fix support for the dm816x platform, add missing bits in the 81xx hwmod data. The clk related patch adds the missing clkdev entries to fix all source selection in the dmtimer driver. The last patch adds hwmod support of the spinbox module. v2: add error logs for first patch Neil

[PATCH v2 2/4] clk: ti816x: Add missing dmtimer clkdev entries

2015-11-13 Thread Neil Armstrong
Add missing clkdev dmtimer related entries for dm816x. 32Khz and ext sources were missing. Cc: Brian Hutchinson <b.hutch...@gmail.com> Acked-by: Tony Lindgren <t...@atomide.com> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/clk/ti/clk-816x.c | 2 ++

Re: [PATCH 1/4] arm: omap2+: add missing HWMOD_NO_IDLEST in 81xx hwmod data

2015-11-13 Thread Neil Armstrong
On 11/13/2015 03:41 PM, Tony Lindgren wrote: > * Neil Armstrong <narmstr...@baylibre.com> [151112 06:16]: >> On 10/24/2015 12:09 PM, Neil Armstrong wrote: >>> Hi, >>> >>> 2015-10-24 3:21 GMT+02:00 Tony Lindgren <t...@atomide.com>: >>>>

  1   2   3   4   5   6   7   8   9   10   >