[PATCH] target: Make spc_get_write_same_sectors return sector_t

2012-11-27 Thread Nicholas A. Bellinger
From: Nicholas Bellinger We already expect TFO->get_blocks() to return sector_t for zero value case when doing WRITE_SAME to the end of the backend device, so go ahead and return sector_t from spc_get_write_same_sectors() to handle this case properly. Also, update the single iblock_execute_write

Re: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-11-27 Thread Nicholas A. Bellinger
Hi Sebastian & Co, On Tue, 2012-11-27 at 16:20 +0100, Sebastian Andrzej Siewior wrote: > On 11/26/2012 06:54 PM, Michal Nazarewicz wrote: > > On Mon, Nov 26 2012, Sebastian Andrzej Siewior wrote: > >> Wouldn't say that. It may adds complexity on another level. The target > >> subsystem has the sam

[GIT PULL] target fixes for v3.7.0

2012-11-29 Thread Nicholas A. Bellinger
Hi Linus, So just a single target fix for v3.7.0 this time around from Roland to address a aborted command bug w/ tcm_qla2xxx fabric ports. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master Also, there is one outstanding IBLOCK + virtio

Re: [ 04/21] target/pscsi: Fix page increment

2013-03-18 Thread Nicholas A. Bellinger
On Mon, 2013-03-18 at 13:35 +0800, Asias He wrote: > On Sat, Mar 16, 2013 at 02:10:22AM +, Ben Hutchings wrote: > > On Tue, 2013-03-12 at 15:44 -0700, Greg Kroah-Hartman wrote: > > > 3.0-stable review patch. If anyone has any objections, please let me > > > know. > > > > > >

Re: [PULL] vhost: tcm_vhost fixes for 3.9

2013-03-18 Thread Nicholas A. Bellinger
On Mon, 2013-03-18 at 21:54 +0200, Michael S. Tsirkin wrote: > On Mon, Mar 18, 2013 at 01:01:36PM -0400, David Miller wrote: > > From: "Michael S. Tsirkin" > > Date: Mon, 18 Mar 2013 13:20:03 +0200 > > > > > The following changes since commit > > > 8c6216d7f118a128678270824b6a1286a63863ca: > > >

Re: [PULL] vhost: tcm_vhost fixes for 3.9

2013-03-18 Thread Nicholas A. Bellinger
On Mon, 2013-03-18 at 23:14 +0200, Michael S. Tsirkin wrote: > On Mon, Mar 18, 2013 at 02:10:03PM -0700, Nicholas A. Bellinger wrote: > > On Mon, 2013-03-18 at 21:54 +0200, Michael S. Tsirkin wrote: > > > On Mon, Mar 18, 2013 at 01:01:36PM -0400, David Miller wrote: > &

Re: [PATCH v3] target: close target_put_sess_cmd() vs. core_tmr_abort_task() race

2013-03-18 Thread Nicholas A. Bellinger
On Mon, 2013-03-18 at 19:34 -0400, Jörn Engel wrote: > And because I'm lame and stupid, here's v3. > > It is possible for one thread to to take se_sess->sess_cmd_lock in > core_tmr_abort_task() before taking a reference count on > se_cmd->cmd_kref, while another thread in target_put_sess_cmd() dro

Re: [PATCH v3] target: close target_put_sess_cmd() vs. core_tmr_abort_task() race

2013-03-18 Thread Nicholas A. Bellinger
On Mon, 2013-03-18 at 19:39 -0700, Greg Kroah-Hartman wrote: > On Mon, Mar 18, 2013 at 07:11:12PM -0700, Nicholas A. Bellinger wrote: > > On Mon, 2013-03-18 at 19:34 -0400, Jörn Engel wrote: > > > And because I'm lame and stupid, here's v3. > > > > >

Re: [ 04/21] target/pscsi: Fix page increment

2013-03-18 Thread Nicholas A. Bellinger
On Tue, 2013-03-19 at 01:18 +, Ben Hutchings wrote: > On Tue, 2013-03-19 at 08:56 +0800, Asias He wrote: > > On Mon, Mar 18, 2013 at 11:30:47PM +, Ben Hutchings wrote: > > > On Mon, 2013-03-18 at 14:00 -0700, Nicholas A. Bellinger wrote: > > > > On Mon, 2013-

[RFC-v3 5/9] iscsi-target: Add per transport iscsi_cmd alloc/free

2013-04-04 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch converts struct iscsi_cmd memory allocation + free to use ->iscsit_alloc_cmd() iscsit_transport API caller, and export iscsit_allocate_cmd() symbols Also add iscsi_cmd->release_cmd() to be used seperately from iscsit_transport for connection/session shutdown.

[RFC-v3 8/9] iscsi-target: Add iser network portal attribute

2013-04-04 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds a new network portal attribute for iser, that lives under existing iscsi-target configfs layout at: /sys/kernel/config/target/iscsi/$TARGETNAME/$TPGT/np/$PORTAL/iser When lio_target_np_store_iser() is enabled, iscsit_tpg_add_network_portal() will atte

[RFC-v3 7/9] iscsi-target: Refactor TX queue logic + export response PDU creation

2013-04-04 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch refactors TX immediate + response queue handling to use the new iscsit_transport API callers, and exports the necessary traditional iscsi PDU response creation functions for iser-target to utilize. This includes: - Add iscsit_build_datain_pdu() for DATAIN PDU

[RFC-v3 6/9] iscsi-target: Refactor RX PDU logic + export request PDU handling

2013-04-04 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch refactors existing traditional iscsi RX side PDU handling to use iscsit_transport, and exports the necessary logic for external transport modules. This includes: - Refactor iscsit_handle_scsi_cmd() into PDU setup / processing - Add updated iscsit_handle_scsi_

[RFC-v3 0/9] Add support for iSCSI Extensions for RDMA (ISER) target mode

2013-04-04 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This series is the third RFC for iSCSI Extensions for RDMA (ISER) target mode support planned for an future v3.10 merge. This series refactors existing traditional iscsi-target mode logic in order for external ib_isert.ko module code to function with areas common to trad

[RFC-v3 2/9] iscsi-target: Add iscsit_transport API template

2013-04-04 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Add basic struct iscsit_transport API template to allow iscsi-target for running with external transport modules using existing iscsi_target_core.h code. For all external modules, this calls try_module_get() and module_put() to obtain + release an external iscsit_transpo

[RFC-v3 4/9] iscsi-target: Add iser-target parameter keys + setup during login

2013-04-04 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds RDMAExtensions, InitiatorRecvDataSegmentLength and TargetRecvDataSegmentLength parameters keys necessary for iser-target login to occur. This includes setting the necessary parameters during login path code within iscsi_login_zero_tsih_s2(), and currently

[RFC-v3 3/9] iscsi-target: Initial traditional TCP conversion to iscsit_transport

2013-04-04 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch performs the initial conversion of existing traditional iscsi to use iscsit_transport API callers. This includes: - iscsi-np cleanups for iscsit_transport_type - Add iscsi-np transport calls w/ ->iscsit_setup_up() and ->iscsit_free_np() - Convert login thread

[RFC-v3 1/9] target: Add export of target_get_sess_cmd symbol

2013-04-04 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Export target_get_sess_cmd() symbol so that it can be used by iscsi-target. Signed-off-by: Nicholas Bellinger --- drivers/target/target_core_transport.c |4 ++-- include/target/target_core_fabric.h|2 +- 2 files changed, 3 insertions(+), 3 deletions(-) dif

Re: [RFC-v3 9/9] iser-target: Add iSCSI Extensions for RDMA (iSER) target driver

2013-04-04 Thread Nicholas A. Bellinger
On Thu, 2013-04-04 at 12:20 +0300, Or Gerlitz wrote: > On 04/04/2013 10:24, Nicholas A. Bellinger wrote: > > + > > +void isert_cq_tx_callback(struct ib_cq *, void *); > > +void isert_cq_rx_callback(struct ib_cq *, void *); > > +void isert_free_rx_descriptors(struct iser

Re: [RFC-v3 9/9] iser-target: Add iSCSI Extensions for RDMA (iSER) target driver

2013-04-04 Thread Nicholas A. Bellinger
On Thu, 2013-04-04 at 12:45 +0300, Or Gerlitz wrote: > On 04/04/2013 10:24, Nicholas A. Bellinger wrote: > > > +#define ISER_RECV_DATA_SEG_LEN 8192 > > +#define ISER_RX_PAYLOAD_SIZE(ISER_HEADERS_LEN + ISER_RECV_DATA_SEG_LEN) > > [...] > > +#de

Re: [RFC-v3 9/9] iser-target: Add iSCSI Extensions for RDMA (iSER) target driver

2013-04-04 Thread Nicholas A. Bellinger
On Thu, 2013-04-04 at 12:51 +0300, Or Gerlitz wrote: > On 04/04/2013 10:24, Nicholas A. Bellinger wrote: > > +static int > > +isert_put_response(struct iscsi_conn *conn, struct iscsi_cmd *cmd) > > +{ > > + struct isert_cmd *i

[GIT PULL] target fixes for v3.8-rc7

2013-02-01 Thread Nicholas A. Bellinger
Hi Linus, Here's the current set of v3.8-rc fixes in the target-pending.git queue. Apologies in advance for these missing the -rc6 release, and having to be destined for -rc7 code. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master The m

[GIT PULL] target updates for v3.9-rc1

2013-02-25 Thread Nicholas A. Bellinger
Hi Linus, Here are the target pending updates for v3.9-rc1 code. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next The highlights in this series include: - Improve sg_table lookup scalability in RAMDISK_MCP (martin) - Add device attr

Re: Read I/O starvation with writeback RAID controller

2013-02-20 Thread Nicholas A. Bellinger
Hi Martin, CC'ing linux-scsi here, as aacraid doesn't have an official maintainer atm. --nab On Wed, 2013-02-20 at 16:38 +0100, Martin Svec wrote: > Hello, > > I've noticed read I/O starvation problems of LIO iSCSI target when > used on top of writeback-enabled HW RAID controller (PERC H700 wit

Re: Read I/O starvation with writeback RAID controller

2013-02-21 Thread Nicholas A. Bellinger
(CC'ed) mentioned the currently out-of-tree ROW scheduler worked for him: https://lkml.org/lkml/2012/12/11/534 Perhaps this would be worth a shot..? --nab > Thanks, > > Martin > > Dne 20.2.2013 21:48, Nicholas A. Bellinger napsal(a): > > Hi Martin, > > > >

Re: [PATCH 5/5] virtio-scsi: introduce multiqueue support

2012-09-03 Thread Nicholas A. Bellinger
On Tue, 2012-08-28 at 13:54 +0200, Paolo Bonzini wrote: > This patch adds queue steering to virtio-scsi. When a target is sent > multiple requests, we always drive them to the same queue so that FIFO > processing order is kept. However, if a target was idle, we can choose > a queue arbitrarily.

Re: [PATCH 5/5] virtio-scsi: introduce multiqueue support

2012-09-04 Thread Nicholas A. Bellinger
On Tue, 2012-09-04 at 08:46 +0200, Paolo Bonzini wrote: > Il 04/09/2012 04:21, Nicholas A. Bellinger ha scritto: > >> @@ -112,6 +118,9 @@ static void virtscsi_complete_cmd(struct virtio_scsi > >> *vscsi, void *buf) > >>struct virtio_scsi_cmd *cmd = buf; > >

Re: Integration of SCST in the mainstream Linux kernel

2008-01-31 Thread Nicholas A. Bellinger
Greetings all, On Wed, 2008-01-30 at 19:56 +0900, FUJITA Tomonori wrote: > On Wed, 30 Jan 2008 09:38:04 +0100 > "Bart Van Assche" <[EMAIL PROTECTED]> wrote: > > > On Jan 30, 2008 12:32 AM, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > > > > > > iSER has parameters to limit the maximum size of RDMA

Re: Integration of SCST in the mainstream Linux kernel

2008-01-31 Thread Nicholas A. Bellinger
Hi Bart, On Thu, 2008-01-31 at 15:34 +0100, Bart Van Assche wrote: > On Jan 31, 2008 2:25 PM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: > > Since this particular code is located in a non-data path critical > > section, the kernel vs. user discussion is a wash. If we

Re: Integration of SCST in the mainstream Linux kernel

2008-01-31 Thread Nicholas A. Bellinger
On Thu, 2008-01-31 at 18:50 +0300, Vladislav Bolkhovitin wrote: > Bart Van Assche wrote: > > On Jan 31, 2008 2:25 PM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: > > > >>Since this particular code is located in a non-data path critical > >>section, t

Re: Integration of SCST in the mainstream Linux kernel

2008-01-31 Thread Nicholas A. Bellinger
On Thu, 2008-01-31 at 18:40 +0100, Bart Van Assche wrote: > On Jan 31, 2008 6:14 PM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: > > Also, with STGT being a pretty new design which has not undergone alot > > of optimization, perhaps profiling both pieces of code agai

Re: Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Nicholas A. Bellinger
On Fri, 2008-02-01 at 09:11 +0100, Bart Van Assche wrote: > On Jan 31, 2008 2:25 PM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: > > > > The PyX storage engine supports a scatterlist linked list algorithm that > > ... > > Which parts of the PyX source co

Re: Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Nicholas A. Bellinger
On Fri, 2008-02-01 at 12:04 +0100, Bart Van Assche wrote: > On Feb 1, 2008 11:39 AM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: > > > > On Fri, 2008-02-01 at 09:11 +0100, Bart Van Assche wrote: > > > On Jan 31, 2008 2:25 PM, Nicholas A. Belli

Re: Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Nicholas A. Bellinger
On Fri, 2008-02-01 at 14:25 +0100, Bart Van Assche wrote: > On Feb 1, 2008 1:05 PM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: > > > > All of the kernel and C userspace code is open source and available from > > linux-iscsi.org and licensed under the GPL. >

[Fwd: 2.6.24 kernel and LIO Target memory mapping]

2008-02-04 Thread Nicholas A. Bellinger
Sorry, resend.. --- Begin Message --- On Sat, 2008-02-02 at 05:26 -0800, Nicholas A. Bellinger wrote: > Hi Bart, > > Ok, I have 2.6.24 running on ppc64 doing iSCSI/HD on PS3-Linux. The > changes for struct scatterlist->page moving to struct > scatterlist->page_link where p

LIO Target iSCSI/SE PS3-Linux / FC8 builds

2008-02-04 Thread Nicholas A. Bellinger
Greetings all, I have updated the wiki at: http://linux-iscsi.org/index.php/Playstation3/iSCSI and posted the first LIO target builds on the LIO Cluster: http://linux-iscsi.org/builds/ps3-linux/ I will adding the documentation for both LIO SE on PS3-Linux, and the FC8 upgrade process, as the l

Re: [Cbe-oss-dev] LIO Target iSCSI/SE PS3-Linux / FC8 builds

2008-02-04 Thread Nicholas A. Bellinger
, let me know if you are missing any when you install iscsi-target-tools. Thanks, --nab On Mon, 2008-02-04 at 07:52 -0800, Nicholas A. Bellinger wrote: > Hi Marc, > > You can generate the kernel RPM with 'make kernel ARCH=powerpc'. > > Also, while module-assistant is s

Re: [Cbe-oss-dev] LIO Target iSCSI/SE PS3-Linux / FC8 builds

2008-02-04 Thread Nicholas A. Bellinger
s.h:357: warning: integer constant is too large > for ‘unsigned long’ type > include/asm/uaccess.h:358: warning: integer constant is too large > for ‘unsigned long’ type > include/asm/uaccess.h:358: warning: integer constant is too large > for ‘unsigned long’ type > include/as

2.6.24 kernel and LIO Target memory mapping

2008-02-04 Thread Nicholas A. Bellinger
On Sat, 2008-02-02 at 05:26 -0800, Nicholas A. Bellinger wrote: > Hi Bart, > > Ok, I have 2.6.24 running on ppc64 doing iSCSI/HD on PS3-Linux. The > changes for struct scatterlist->page moving to struct > scatterlist->page_link where pretty straightforward, considering the

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Nicholas A. Bellinger
On Mon, 2008-02-04 at 11:06 -0800, Nicholas A. Bellinger wrote: > On Mon, 2008-02-04 at 10:29 -0800, Linus Torvalds wrote: > > > > On Mon, 4 Feb 2008, James Bottomley wrote: > > > > > > The way a user space solution should work is to schedule mmapped I/O >

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Nicholas A. Bellinger
On Mon, 2008-02-04 at 11:44 -0800, Linus Torvalds wrote: > > On Mon, 4 Feb 2008, Nicholas A. Bellinger wrote: > > > > While this does not have anything to do directly with the kernel vs. > > user discussion for target mode storage engine, the scaling and latency > &g

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Nicholas A. Bellinger
On Mon, 2008-02-04 at 10:29 -0800, Linus Torvalds wrote: > > On Mon, 4 Feb 2008, James Bottomley wrote: > > > > The way a user space solution should work is to schedule mmapped I/O > > from the backing store and then send this mmapped region off for target > > I/O. > > mmap'ing may avoid the cop

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Nicholas A. Bellinger
On Mon, 2008-02-04 at 17:00 -0600, James Bottomley wrote: > On Mon, 2008-02-04 at 22:43 +, Alan Cox wrote: > > > better. So for example, I personally suspect that ATA-over-ethernet is > > > way > > > better than some crazy SCSI-over-TCP crap, but I'm biased for simple and > > > low-level, an

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Nicholas A. Bellinger
On Mon, 2008-02-04 at 13:24 -0800, Linus Torvalds wrote: > > On Mon, 4 Feb 2008, J. Bruce Fields wrote: > > > > I'd assumed the move was primarily because of the difficulty of getting > > correct semantics on a shared filesystem > > .. not even shared. It was hard to get correct semantics full s

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Nicholas A. Bellinger
On Mon, 2008-02-04 at 22:43 +, Alan Cox wrote: > > better. So for example, I personally suspect that ATA-over-ethernet is way > > better than some crazy SCSI-over-TCP crap, but I'm biased for simple and > > low-level, and against those crazy SCSI people to begin with. > > Current ATAoE isn't

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Nicholas A. Bellinger
On Mon, 2008-02-04 at 15:12 -0800, Nicholas A. Bellinger wrote: > On Mon, 2008-02-04 at 17:00 -0600, James Bottomley wrote: > > On Mon, 2008-02-04 at 22:43 +, Alan Cox wrote: > > > > better. So for example, I personally suspect that ATA-over-ethernet is > > > &

Re: [PATCH 1/6] target/file: Re-enable optional fd_buffered_io=1 operation

2012-10-02 Thread Nicholas A. Bellinger
On Mon, 2012-10-01 at 04:46 -0400, Christoph Hellwig wrote: > On Sun, Sep 30, 2012 at 05:58:11AM +0000, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch re-adds the ability to optionally run in buffered FILEIO mode > > (eg: w/o O_DSYNC) for

Re: [PATCH 0/2] PCI-Express Non-Transparent Bridge Support

2012-10-03 Thread Nicholas A. Bellinger
On Tue, 2012-10-02 at 14:26 -0700, Jon Mason wrote: > I am submitting version 4 of the PCI-Express Non-Transparent Bridge > patches for inclusion in 3.7. All outstanding issues from the RFC > process have been addressed. > > version 1 > http://thread.gmane.org/gmane.linux.kernel.pci/16443 > > Ve

Re: [PATCH 1/6] target/file: Re-enable optional fd_buffered_io=1 operation

2012-10-03 Thread Nicholas A. Bellinger
On Wed, 2012-10-03 at 07:47 -0400, Christoph Hellwig wrote: > On Tue, Oct 02, 2012 at 01:16:44PM -0700, Nicholas A. Bellinger wrote: > > * Optionally allow fd_buffered_io=1 to be enabled for people > > * who want use the fs buffer cache as an Write

Re: [qla2xxx] INFO: possible irq lock inversion dependency detected

2012-10-04 Thread Nicholas A. Bellinger
On Thu, 2012-10-04 at 21:11 +0530, Srivatsa S. Bhat wrote: > Hi Jiri, > > Thanks for taking a look! Hi Srivatsa & Jiri, > > > This seems to be real. You should be seeing that since 3.5-rc1 already > > though ... ? > > > > Does the patch below fix that? > > > > Yes, it does, thanks! But 3.6

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-12 Thread Nicholas A. Bellinger
Greetings all, On Tue, 2008-02-12 at 17:05 +0100, Bart Van Assche wrote: > On Feb 6, 2008 1:11 AM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: > > I have always observed the case with LIO SE/iSCSI target mode ... > > Hello Nicholas, > > Are you sure that the

Re: struct page vs page_link

2008-02-12 Thread Nicholas A. Bellinger
er > understanding of exactly what was going on and was able to > successfully patch what I needed to. > > http://www.tuttleresearch.com/80211patch.html > > Much appreciated, > Mark Tuttle > > On 2/9/08, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: >

CONFIG_SLUB and reproducable general protection faults on 2.6.2x

2008-02-12 Thread Nicholas A. Bellinger
On Tue, 2008-02-12 at 19:57 -0800, Nicholas A. Bellinger wrote: > Greetings all, > > On Tue, 2008-02-12 at 17:05 +0100, Bart Van Assche wrote: > > On Feb 6, 2008 1:11 AM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: > > > I have always observed the case

Re: CONFIG_SLUB and reproducable general protection faults on 2.6.2x

2008-02-13 Thread Nicholas A. Bellinger
On Tue, 2008-02-12 at 22:18 -0800, Nicholas A. Bellinger wrote: > On Tue, 2008-02-12 at 19:57 -0800, Nicholas A. Bellinger wrote: > > Greetings all, > > > > On Tue, 2008-02-12 at 17:05 +0100, Bart Van Assche wrote: > > > On Feb 6, 2008 1:11 AM, Nicholas A. Belli

[GIT PULL] target fixes for v3.7-rc4 (round 2)

2012-11-02 Thread Nicholas A. Bellinger
Hello Linus, This series is a second round of target fixes for v3.7-rc4 that have come into target-devel over the last days, and are important enough to be applied ASAP. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master All are being CC

Re: An Andre To Remember

2012-07-28 Thread Nicholas A. Bellinger
On Fri, 2012-07-27 at 13:56 -0400, Jeff Garzik wrote: > An Andre To Remember > July 2012 > > Linux lost a friend and advocate this month. Though never a household > name, Andre Hedrick had a positive impact on everyone today running > Linux, or using a website, with any form of IDE (A

[GIT PULL] tcm_vhost: Initial merge of vhost level target fabric driver

2012-07-30 Thread Nicholas A. Bellinger
Hi Linus, Here is the PULL request for the initial merge of tcm_vhost based on RFC-v5 code with MST's ACK appended to the initial merge commit. As promised, the commit is available from two different branches for you to consider merging as for-3.6 code. The 'for-next-merge' branch based on mainli

target-pending updated to v3.7-rc2

2012-10-26 Thread Nicholas A. Bellinger
Hi folks, This is a just friendly heads up that target-pending has been updated to latest v3.7-rc2 mainline code. As usual, the for-next* branches have been recreated from master and include in-flight target development patches destined for upstream during the v3.8 merge window. Also, a heads up

[GIT PULL] target fixes for v3.7-rc4

2012-10-30 Thread Nicholas A. Bellinger
Hello Linus! The following are the current target pending fixes headed for v3.7-rc4 code. This includes the following highlights: - Fix long-standing qla2xxx target bug where certain fc_port_t state transitions could cause the internal session b-tree list to become out-of-sync. (Roland) - Fix ta

Re: [GIT PULL] target fixes for v3.7-rc4

2012-10-30 Thread Nicholas A. Bellinger
On Tue, 2012-10-30 at 21:29 -0700, Nicholas A. Bellinger wrote: > Hello Linus! > > The following are the current target pending fixes headed for v3.7-rc4 > code. This includes the following highlights: > > - Fix long-standing qla2xxx target bug where certain fc_port_t state &

[GIT PULL] target fixes for v3.11-rc7

2013-08-24 Thread Nicholas A. Bellinger
Hi Linus, Here is the current set of target-pending fixes for v3.11-rc7. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master The first patch is to address a long standing issue where INQUIRY vendor + model response data was not correctly

Re: [PATCH-v2 06/12] target: Add memory allocation for bidirectional commands

2013-08-24 Thread Nicholas A. Bellinger
On Sat, 2013-08-24 at 08:18 -0700, Christoph Hellwig wrote: > > static int > > +transport_generic_get_mem_bidi(struct se_cmd *cmd) > > Except for the fields touched in struct se_cmd this is a duplication > of transport_generic_get_mem. I'd suggest to factor that one into > a new helper: > > sta

[PATCH-v3 03/13] target: Add TCM_MISCOMPARE_VERIFY sense handling

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds TCM_MISCOMPARE_VERIFY (ASC=0x1d, ASCQ=0x00) sense handling to transport_send_check_condition_and_sense(), which is required for a COMPARE_AND_WRITE comparision failure. Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Martin Petersen Cc: Chris Mason Cc:

[PATCH-v3 13/13] target: Release COMPARE_AND_WRITE mutex in generic failure path

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds a extra check for SCF_COMPARE_AND_WRITE within transport_generic_request_failure() to invoke the callback for compare_and_write_callback() or compare_and_write_done(), in order to release se_dev->caw_mutex from the generic failure path. It also adds to ch

[PATCH-v3 07/13] target: Do memory allocation for bidi commands using target_alloc_sgl

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch updates transport_generic_new_cmd() to call target_alloc_sgl() for SGL + page memory allocation for se_cmd->t_bidi_data_sg. It also adds the special case for SCF_COMPARE_AND_WRITE to calculate a different bidi_length based upon se_cmd->t_task_nolb. Reported-b

[PATCH-v3 10/13] target: Add MAXIMUM COMPARE AND WRITE LENGTH in Block Limits VPD

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds the MAXIMUM COMPARE AND WRITE LENGTH bit, currently hardcoded to a single logical block (NoLB=1) within the Block Limits VPD in spc_emulate_evpd_b0(). Also add emulate_caw device attribute in configfs (enabled by default) to allow the exposure of this bit

[PATCH-v3 12/13] target: Add compare_and_write_post() completion callback fall through

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch changes target_complete_ok_work() to fall through after calling the se_cmd->transport_complete_callback() -> compare_and_write_post() callback, by keying off the existance of SCF_COMPARE_AND_WRITE_POST. This is necessary because once SCF_COMPARE_AND_WRITE_POST

[PATCH-v3 09/13] target: Make __target_execute_cmd() available as extern

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Required by COMPARE_AND_WRITE for write instance user-data submission, in order to bypass target_execute_cmd() checks. Reported-by: Christoph Hellwig Cc: Roland Dreier Cc: Nicholas Bellinger Signed-off-by: Nicholas Bellinger --- drivers/target/target_core_transport.

[PATCH-v3 11/13] target: Add support for COMPARE_AND_WRITE emulation

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds support for COMPARE_AND_WRITE emulation on a per block basis. This logic is used as an atomic test and set primative currently used by VMWare ESX VAAI for performing array side locking of individual VMFS extent ownership. This includes the COMPARE_AND_WR

[PATCH-v3 08/13] target: Add transport_reset_sgl_orig() for COMPARE_AND_WRITE

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger After COMPARE_AND_WRITE completes it's comparision, the WRITE payload SGLs head expect to be updated to point from the verify instance of user data, to the write instance of user data. So for this special case, add transport_reset_sgl_orig() usage within transport_free_p

[PATCH-v3 01/13] scsi: Add CDB definition for COMPARE_AND_WRITE

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Reviewed-by: Christoph Hellwig Cc: Hannes Reinecke Cc: Martin Petersen Cc: Chris Mason Cc: James Bottomley Cc: Nicholas Bellinger Signed-off-by: Nicholas Bellinger --- include/scsi/scsi.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/inc

[PATCH-v3 02/13] target: Add return for se_cmd->transport_complete_callback

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds a sense_reason_t return to ->transport_complete_callback(), and updates target_complete_ok_work() to invoke the call if necessary to transport_send_check_condition_and_sense() during the failure case. Also update xdreadwrite_callback() to use this return

[PATCH-v3 04/13] target: Allow sbc_ops->execute_rw() to accept SGLs + data_direction

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger COMPARE_AND_WRITE expects to be able to send down a DMA_FROM_DEVICE to obtain the necessary READ payload for comparision against the first half of the WRITE payload containing the verify user data. Currently virtual backends expect to internally reference SGLs, SGL nents

[PATCH-v3 06/13] target: Refactor transport_generic_get_mem to target_alloc_sgl

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch refactors transport_generic_get_mem() to target_alloc_sgl() for accepting **sgl, *nents, length and zero_page as function parameters in order to be used for both se_cmd->t_data_sg + se_cmd->t_bidi_data_sg allocations. Reported-by: Christoph Hellwig Cc: Christ

[PATCH-v3 05/13] target: Convert se_cmd->t_bidi_data_sg checks to use SCF_BIDI

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Stop keying off se_cmd->t_bidi_data_sg within transport_complete_qf() + target_complete_ok_work(), and just use SCF_BIDI instead. Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Martin Petersen Cc: Chris Mason Cc: James Bottomley Cc: Nicholas Bellinger Signed-off-by:

[PATCH-v3 00/13] target: Add support for COMPARE_AND_WRITE (VAAI) emulation

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi folks, This series -v3 adds support to target-core for generic COMPARE_AND_WRITE emulation as defined by SBC-3 using virtual (IBLOCK, FILEIO, RAMDISK) backends. COMPARE_AND_WRITE is a VMWare ESX VAAI primitive that is currently used by VMFS to perform array side lock

[PATCH-v2 0/9] target: Add support for EXTENDED_COPY (VAAI) offload emulation

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi folks, This -v2 series adds support to target-core for generic EXTENDED_COPY offload emulation as defined by SPC-4 using virtual (IBLOCK, FILEIO, RAMDISK) backends. EXTENDED_COPY is a VMWare ESX VAAI primative that is used to perform copy offload, that allows a targe

[PATCH-v2 6/9] target: Add support for EXTENDED_COPY copy offload emulation

2013-08-26 Thread Nicholas A. Bellinger
082 @@ +/*** + * Filename: target_core_xcopy.c + * + * This file contains support for SPC-4 Extended-Copy offload with generic + * TCM backends. + * + * Copyright (c) 2011-2013 Datera, Inc. All rights reserved. + * + * Author: + * Nicholas A. Bellinger + * + * This program

[PATCH-v2 4/9] target: Add global device list for EXTENDED_COPY

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger EXTENDED_COPY needs to be able to search a global list of devices based on NAA WWN device identifiers, so add a simple g_device_list protected by g_device_mutex. Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Martin Petersen Cc: Chris Mason Cc: Roland Dreier Cc: Zach

[PATCH-v2 8/9] target: Add Third Party Copy (3PC) bit in INQUIRY response

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds the Third Party Copy (3PC) bit to signal support for EXTENDED_COPY within standard inquiry response data. Also add emulate_3pc device attribute in configfs (enabled by default) to allow the exposure of this bit to be disabled, if necessary. Cc: Christoph

[PATCH-v2 9/9] target: Enable global EXTENDED_COPY setup/release

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Add calls to target_xcopy_setup_pt() + target_xcopy_release_pt() to target_core_init_configfs() and target_core_exit_configfs() respectively. Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Martin Petersen Cc: Chris Mason Cc: Roland Dreier Cc: Zach Brown Cc: James Bo

[PATCH-v2 2/9] target: Make spc_parse_naa_6h_vendor_specific non static

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch makes spc_parse_naa_6h_vendor_specific() available to other target code, which is required by EXTENDED_COPY when comparing the received NAA WWN device identifer for locating the associated se_device backend. Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Mart

[PATCH-v2 3/9] target: Make helpers non static for EXTENDED_COPY command setup

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Both target_alloc_sgl() and transport_generic_map_mem_to_cmd() are required by EXTENDED_COPY logic when setting up internally dispatched command descriptors, so go ahead and make both of these non static. Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Martin Petersen C

[PATCH-v2 5/9] target: Avoid non-existent tg_pt_gp_mem in target_alua_state_check

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds an check for a non-existent port->sep_alua_tg_pt_gp_mem within target_alua_state_check(), which is not present for internally dispatched EXTENDED_COPY WRITE I/O to the destination target port. Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Martin Peterse

[PATCH-v2 7/9] target: Enable EXTENDED_COPY setup in spc_parse_cdb

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Setup up the se_cmd->execute_cmd() pointers for EXTENDED_COPY and RECEIVE_COPY_RESULTS handling within spc_parse_cdb() Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Martin Petersen Cc: Chris Mason Cc: Roland Dreier Cc: Zach Brown Cc: James Bottomley Cc: Nicholas B

[PATCH-v2 1/9] target: Make target_core_subsystem defined as non static

2013-08-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch makes the top-level target_core_subsystem array available to other target code, which is required by EXTENDED_COPY to pin the backend se_device using configfs_depend_item(), in order to ensure it can't be removed for the duration of a EXTENDED_COPY operation.

Re: [PATCH-v2 0/9] target: Add support for EXTENDED_COPY (VAAI) offload emulation

2013-08-26 Thread Nicholas A. Bellinger
On Mon, 2013-08-26 at 15:46 -0700, Zach Brown wrote: > On Mon, Aug 26, 2013 at 10:02:59PM +0000, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > Hi folks, > > > > This -v2 series adds support to target-core for generic EXTENDED_COPY > >

[PATCH-v4 1/6] idr: Percpu ida

2013-08-27 Thread Nicholas A. Bellinger
tees and it's absolutely not a correctness issue, so I don't think it's worth the extra code. v4 changes: - Fix tags.c reference in percpu_ida_init (akpm) Signed-off-by: Kent Overstreet Cc: Tejun Heo Cc: Oleg Nesterov Cc: Christoph Lameter Cc: Ingo Molnar Cc: Andi Kleen Cc: Jens Axbo

[PATCH-v4 3/6] vhost/scsi: Convert to per-cpu ida_alloc + ida_free command map

2013-08-27 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch changes vhost/scsi to use transport_init_session_tags() pre-allocation logic for per-cpu session tag pooling with internal ida_alloc() + ida_free() calls based upon the saved se_cmd->map_tag id. FIXME: Make transport_init_session_tags() number of tags setup co

[PATCH-v4 4/6] vhost/scsi: Add pre-allocation for tv_cmd SGL + upages memory

2013-08-27 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds support for pre-allocation of per tv_cmd descriptor scatterlist + user-space page pointer memory using se_sess->sess_cmd_map within tcm_vhost_make_nexus() code. This includes sanity checks within vhost_scsi_map_to_sgl() to reject I/O that exceeds these in

[PATCH-v4 0/6] target/vhost/iscsi: Add per-cpu ida tag pre-allocation for v3.12

2013-08-27 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi folks, This is an updated -v4 series for adding tag pre-allocation support of target fabric descriptor memory, utilizing Kent's latest per-cpu ida bits. The first patch is a standalone version of per-cpu-ida, seperate from the full idr rewrite from Kent that is still

[PATCH-v4 2/6] target: Add transport_init_session_tags using per-cpu ida

2013-08-27 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds lib/idr.c based transport_init_session_tags() logic that allows fabric drivers to setup a per-cpu se_sess->sess_tag_pool and associated se_sess->sess_cmd_map for basic tagged pre-allocation of fabric descriptor sized memory. v4: Add transport_alloc_sessio

[PATCH-v4 6/6] iscsi-target: Convert to per-cpu ida_alloc + ida_free command map

2013-08-27 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch changes iscsi-target to use transport_alloc_session_tags() pre-allocation logic for per-cpu session tag pooling with internal ida_alloc() + ida_free() calls based upon the saved se_cmd->map_tag id. This includes tag pool setup based upon per NodeACL queue_dept

[PATCH-v4 5/6] iscsi/iser-target: Convert to command priv_size usage

2013-08-27 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This command converts iscsi/isert-target to use allocations based on iscsit_transport->priv_size within iscsit_allocate_cmd(), instead of using an embedded isert_cmd->iscsi_cmd. This includes removing iscsit_transport->alloc_cmd() usage, along with updating isert-target

Re: [PATCH-v4 1/6] idr: Percpu ida

2013-08-27 Thread Nicholas A. Bellinger
On Tue, 2013-08-27 at 13:43 -0700, Andrew Morton wrote: > On Tue, 27 Aug 2013 20:11:41 +0000 "Nicholas A. Bellinger" > wrote: > > > Percpu frontend for allocating ids. With percpu allocation (that works), > > it's impossible to guarantee it will always be

Re: [PATCH] percpu_ida: Removing unused arguement from alloc_local_tag

2013-10-02 Thread Nicholas A. Bellinger
On Wed, 2013-10-02 at 17:55 -0700, Nick Swenson wrote: > Removing unused struct percpu_ida *pool from arguemnts of > alloc_local_tag, changed it's one use in idr.c > > Signed-Off-By: Nick Swenson > --- Nice patch, but the upstream version of percpu_ida lives in lib/percpu_ida.c, and not lib/idr.

Re: Drivers: scsi: FLUSH timeout

2013-10-03 Thread Nicholas A. Bellinger
On Wed, 2013-10-02 at 18:29 +, KY Srinivasan wrote: > > > -Original Message- > > From: geert.uytterhoe...@gmail.com [mailto:geert.uytterhoe...@gmail.com] > > On Behalf Of Geert Uytterhoeven > > Sent: Wednesday, September 25, 2013 1:40 AM > > To: KY Srinivasan > > Cc: Mike Christie; Jac

[GIT PULL] target fixes for v3.12-rc4

2013-10-06 Thread Nicholas A. Bellinger
Hello Linus! Here are the outstanding target fixes queued up for v3.12-rc4 code. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master The highlights include: - Make vhost/scsi tag percpu_ida_alloc() use GFP_ATOMIC - Allow sess_cmd_map

Re: linux-next: manual merge of the vhost tree with the target-updates tree

2013-07-08 Thread Nicholas A. Bellinger
On Mon, 2013-07-08 at 13:47 +1000, Stephen Rothwell wrote: > Hi Michael, > > Today's linux-next merge of the vhost tree got a conflict in > drivers/vhost/scsi.c between commit 084ed45b3846 ("vhost/scsi: Convert to > se_cmd->cmd_kref TARGET_SCF_ACK_KREF usage") from the target-updates tree > and co

Re: linux-next: manual merge of the vhost tree with the target-updates tree

2013-07-08 Thread Nicholas A. Bellinger
On Tue, 2013-07-09 at 13:27 +1000, Stephen Rothwell wrote: > Hi Nicholas, > > On Mon, 08 Jul 2013 18:13:26 -0700 "Nicholas A. Bellinger" > wrote: > > > > On Mon, 2013-07-08 at 13:47 +1000, Stephen Rothwell wrote: > > > > > > Today&#x

  1   2   3   4   5   6   7   8   9   >