Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

2018-02-16 Thread Nick Lowe
wrote: > On Tue, Feb 13, 2018 at 03:27:47PM +0000, Nick Lowe wrote: >> Hi Arjan and Greg, >> >> Sorry if I am not being clear enough. >> >> My point is that there is a check for X86_VENDOR_AMD now in two places. >> >> It is still hardcoded for the au

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

2018-02-16 Thread Nick Lowe
Hi, This should use boot_cpu_has_bug(X86_BUG_CPU_MELTDOWN)) - I am preparing patches. Best, Nick

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

2018-02-13 Thread Nick Lowe
Hi, This does not seem to have subsumed the AMD specific code in x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown Commit a8799fd14d9f7f385a5a5c86cde247caf4bb0320 https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?h=v4.9.81&id=a8799fd14d9f7f385a

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

2018-02-13 Thread Nick Lowe
Hi Arjan and Greg, Sorry if I am not being clear enough. My point is that there is a check for X86_VENDOR_AMD now in two places. It is still hardcoded for the auto boot option which I think should not be there. The patch on that basis looked incomplete to me. Put another way, there is no effect