ned-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index 28
When adding a new service validate the configuration parameters
provided, and remove unnecessary checks in vchi, now that we have
validated service's config.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_core.c | 15 +++
.../interface/vchi
Those are only used in the core vchiq code, while present in vchiq's
'public' API header. Move them into the right place.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq.h| 5 -
.../staging/vc04_services/interface/vchiq_a
We can't really merge it with vchiq_queue_message() as it has internal
users that will not benefit from the retry mechanism
vchiq_queue_kernel_message() uses. So, for the sake of getting rid of
vchi, move it into vchiq.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vc
Those functions don't actually exist, nor have any use, nor the macros.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_if.h | 17 -
1 file changed, 17 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if
To make the separation clear between vchiq's header files and vchiq.h,
which is to be used by services and is the 'public' API, move it into a
dedicated includes directory.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v1:
- Remove unwarranted include
drivers/stagin
The header file only provides other includes. Move the relevant includes
to their respective C files and delete it for good.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchiq_arm/vchiq.h | 1 -
.../interface/vchiq_arm/vchiq_2835_arm.c | 1 +
.../interface
From: Dave Stevenson
The timeout period for VPU communications is a useful thing
to extend when debugging.
Set it via a define, rather than a magic number buried in the code.
Signed-off-by: Dave Stevenson
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging
From: Naushir Patuck
No functional changes in this commit.
- Remove erroneous whitespace.
- Remove _t postfix label on structs and enums.
Signed-off-by: Naushir Patuck
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-camera/bcm2835-camera.c | 2
enum vchi_callback_reason maps 1:1 to enum vchiq_reason, in an effort to
simplify things, let's use the later, and get rid of the extra
indirection.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 5 +--
.../interface/vchi/vchi_com
s are already held in an array per VCHI
instance, so use the array index as the client_component handle
to avoid having to create a new IDR for this purpose.
Signed-off-by: Dave Stevenson
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/vchiq-mmal
This reverts commit c65822fef4adc0ba40c37a47337376ce75f7a7bc.
The initialization of Raspberry Pi 4's USB chip is now handled through a
reset controller. No need to directly call the firmware routine through a
PCI quirk.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fai
On Fri, 2020-06-26 at 12:43 +0200, Philipp Zabel wrote:
> On Wed, 2020-06-17 at 12:44 +0200, Nicolas Saenz Julienne wrote:
> > On Wed, 2020-06-17 at 12:02 +0200, Philipp Zabel wrote:
> > > Hi Nicolas,
> > >
> > > On Fri, 2020-06-12 at 19:13 +0200, Nicolas Sae
The chip is hardwired to the board's PCIe bus and needs to be properly
setup trough a firmware routine after a PCI fundamental reset. Pass the
reset controller phandle that takes care of triggering the
initialization to the relevant PCI device.
Signed-off-by: Nicolas Saenz Julienne
---
Ch
This reverts commit fbbc5ff3f7f9f4cad562e530ae2cf5d8964fe6d3.
The vl805 init routine has moved into drivers/reset/reset-raspberrypi.c
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
drivers/firmware/raspberrypi.c | 61 --
include/soc
This reverts commit 44331189f9082c7e659697bbac1747db3def73e7.
Now that the VL805 init routine is run through a reset controller driver
the device dependencies are being taken care of by the device core. No
need to do it manually here.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian
t controller so it's less USB centric
- Use correct reset controller API in xhci-pci
- Correct typos
Nicolas Saenz Julienne (9):
dt-bindings: reset: Add a binding for the RPi Firmware reset
controller
reset: Add Raspberry Pi 4 firmware reset controller
ARM: dts: bcm2711: Add firmware
Now that the reset driver exposing Raspberry Pi 4's firmware based USB
reset routine is available, let's add the device tree node exposing it.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
Changes since v1:
- Update cell nr to match new bindings
---
arc
ines.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
Reviewed-by: Philipp Zabel
---
Changes since v4:
- use np instead of fw_node, to explicitly mark this as OF centric
Changes since v2:
- Get ids from dt-binding
Changes since v1:
- Make the whole driver less USB cent
The firmware running on the RPi VideoCore can be used to reset and
initialize HW controlled by the firmware.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
Changes since v2:
- Add include file for reset IDs
Changes since v1:
- Correct cells binding as per Florian
The board doesn't need the quirks to be run, and takes care of its own
initialization through a reset controller device. So let's bypass them.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
Changes since v2:
- Correct reference counting on parent device nod
Some atypical users of xhci-pci might need to manually reset their xHCI
controller before starting the HCD setup. Check if a reset controller
device is available to the PCI bus and trigger a reset.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Mathias Nyman
Reviewed-by: Philipp Zabel
On Tue, 2020-06-16 at 07:43 -0600, Simon Glass wrote:
> Hi Nicolas,
>
> On Fri, 12 Jun 2020 at 10:47, Nicolas Saenz Julienne
> wrote:
> > There is no distinction in DT between the PCI controller device and the
> > root bridge, whereas such distinction exists from dm'
Hi,
On Wed, 2020-04-15 at 20:00 +0300, Andy Shevchenko wrote:
> Use %ptT instead of open coded variant to print content of
> time64_t type in human readable format.
>
> Signed-off-by: Andy Shevchenko
> ---
as originally reported by Stefan Wahren, this patch is likely to be the cause
for a regre
On Tue, 2020-06-16 at 19:13 +0300, Andy Shevchenko wrote:
> On Tue, Jun 16, 2020 at 05:53:23PM +0200, Nicolas Saenz Julienne wrote:
> > On Wed, 2020-04-15 at 20:00 +0300, Andy Shevchenko wrote:
> > > Use %ptT instead of open coded variant to print content of
> > > time
iable
> of time64_t type to correctly handle lesser types.
>
> Fixes: 4a60f58ee002 ("ARM: bcm2835: Switch to use %ptT")
> Reported-by: Stefan Wahren
> Reported-by: Nicolas Saenz Julienne
> Signed-off-by: Andy Shevchenko
> Cc: Petr Mladek
> Cc: Steven Rostedt
On Mon, 2020-06-08 at 12:58 -0700, Florian Fainelli wrote:
>
> On 6/8/2020 12:26 PM, Nicolas Saenz Julienne wrote:
> > The firmware running on the RPi VideoCore can be used to reset and
> > initialize the board's xHCI controller. The reset controller is passed
> > to
Hi Florian, thanks for the reviews!
On Mon, 2020-06-08 at 12:43 -0700, Florian Fainelli wrote:
>
> On 6/8/2020 12:26 PM, Nicolas Saenz Julienne wrote:
> > Some atypical users of xhci-pci might need to manually reset their xHCI
> > controller before starting the HCD setup
On Mon, 2020-06-08 at 22:44 +0300, Andy Shevchenko wrote:
>
>
> On Monday, June 8, 2020, Nicolas Saenz Julienne
> wrote:
> > Some atypical users of xhci-pci might need to manually reset their xHCI
> > controller before starting the HCD setup. Check if a reset controller
On Tue, 2020-06-09 at 13:59 +0200, Philipp Zabel wrote:
> Hi Nicolas,
>
>
>
> On Tue, 2020-06-09 at 13:18 +0200, Nicolas Saenz Julienne wrote:
>
> > Hi Florian, thanks for the reviews!
> > On Mon, 2020-06-08 at 12:43 -0700, Florian Fainelli wrote:
> > &
Some atypical users of xhci-pci might need to manually reset their xHCI
controller before starting the HCD setup. Check if a reset controller
device is available to the PCI bus and trigger a reset.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v1:
- Use proper reset API
- Make code
The board doesn't need the quirks to be run, and takes care of its own
initialization trough a reset controller device. So let's bypass them.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
Changes since v1:
- Correct typos
drivers/usb/host/pci-qui
The firmware running on the RPi VideoCore can be used to reset and
initialize HW controlled by the firmware.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v1:
- Correct cells binding as per Florian's comment
- Change compatible string to be more generic
.../arm/bcm/raspbe
This reverts commit 44331189f9082c7e659697bbac1747db3def73e7.
Now that the VL805 init routine is run through a reset controller driver
the device dependencies are being taken care of by the device core. No
need to do it manually here.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/pci
series.max...@cerno.tech/
---
Changes since v1:
- Rework reset controller so it's less USB centric.
- Use correct reset controller API in xhci-pci
- Correct typos
Nicolas Saenz Julienne (9):
dt-bindings: reset: Add a binding for the RPi Firmware reset
controller
reset: Add Raspberry Pi 4
This reverts commit fbbc5ff3f7f9f4cad562e530ae2cf5d8964fe6d3.
The vl805 init routine has moved into drivers/reset/reset-raspberrypi.c
Signed-off-by: Nicolas Saenz Julienne
---
drivers/firmware/raspberrypi.c | 61 --
include/soc/bcm2835/raspberrypi-firmware.h
This reverts commit c65822fef4adc0ba40c37a47337376ce75f7a7bc.
The initialization of Raspberry Pi 4's USB chip is now handled through a
reset controller. No need to directly call the firmware routine trough a
pci quirk.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/firmware/Kc
Now that the reset driver exposing Raspberry Pi 4's firmware based USB
reset routine is available, let's add the device tree node exposing it.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v1:
- Update cell nr to match new bindings
arch/arm/boot/dts/bcm2711-rpi-4
The chip is hardwired to the board's PCIe bus and needs to be properly
setup trough a firmware routine after a PCI fundamental reset. Pass the
reset controller phandle that takes care of triggering the
initialization to the relevant PCI device.
Signed-off-by: Nicolas Saenz Julienne
---
Ch
ines.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v1:
- Make the whole driver less USB centric as per Florian's comments
drivers/reset/Kconfig | 11 +++
drivers/reset/Makefile| 1 +
drivers/reset/reset-raspberrypi.c | 126 +++
: Add Broadcom STB PCIe host controller
driver")
Signed-off-by: Nicolas Saenz Julienne
---
drivers/pci/controller/pcie-brcmstb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/pcie-brcmstb.c
b/drivers/pci/controller/pcie-brcmstb.c
index 0b97b94c4a9a..795a03be4150 10
This is for service's callbacks to get their private data.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
b/dr
There is a series of structures and enums defined but never used. Get
rid of them.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchi/vchi_common.h | 65 ---
1 file changed, 65 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi
enum vchi_callback_reason maps 1:1 to enum vchiq_reason, in an effort to
simplify things, let's use the later, and get rid of the extra
indirection.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 5 +--
.../interface/vchi/vchi_com
vchi has a set of transfer flags which almost map 1:1 to vchiq's own
transfer modes. For the sake of simplicity let's use the later and
delete vchi's.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 2 +-
.../vc04_services/bcm2835-
All users are ignoring the flags argument. So for the sake of
simplicity delete it.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/bcm2835-audio/bcm2835-vchiq.c | 3 +--
drivers/staging/vc04_services/interface/vchi/vchi.h | 1 -
.../vc04_services/interface/vchiq_arm
_hold() instead.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 25 +++
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
b/drivers/staging/vc04_services/bcm2835-audio/bc
ned-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index 28
struct shim_service into struvt vchi_service, which is more consistent
with the rest of the exposed API.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 24 +++
.../vc04_services/interface/vchi/vchi.h | 27
.../interface/vchiq_arm
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 12
.../interface/vchiq_arm/vchiq_shim.c | 64 ---
.../interface/vchiq_arm/vchiq_util.c | 12
.../interface/vchiq_arm/vchiq_util.h | 1 -
4 files change
The idea behind this was to create an opaque handle to struct
vchiq_instance. This can be achieved without creating a new type by
means of a forward declaration of struct vchiq_instance.
This saves us from a lot of useless casting and overall simplifies code.
Signed-off-by: Nicolas Saenz
Nobody uses it. Get rid of it.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 7
.../interface/vchiq_arm/vchiq_shim.c | 39 ---
2 files changed, 46 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi
From: Dave Stevenson
Fixes up a checkpatch error "Avoid using bool structure members
because of possible alignment issues".
Signed-off-by: Dave Stevenson
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
From: Naushir Patuck
No functional changes in this commit.
- Remove erroneous whitespace.
- Remove _t postfix label on structs and enums.
Signed-off-by: Naushir Patuck
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-camera/bcm2835-camera.c | 2
ng: bcm2835: Break MMAL support out from camera
Naushir Patuck (1):
staging: mmal-vchiq: Fix formatting errors in mmal_parameters.h
Nicolas Saenz Julienne (39):
staging: vchi: Get rid of all useless callback reasons
staging: vchi: Get rid of vchi_msg_peek()
staging: vchi: Get rid of str
.
Signed-off-by: Dave Stevenson
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
b/drivers
struct,
and pass the appropriate members.
Signed-off-by: Dave Stevenson
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-camera/bcm2835-camera.c | 64 +++
.../vc04_services/vchiq-mmal/mmal-common.h| 5 ++
.../vc04_services/vchiq
-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
s are already held in an array per VCHI
instance, so use the array index as the client_component handle
to avoid having to create a new IDR for this purpose.
Signed-off-by: Dave Stevenson
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/vchiq-mmal
From: Dave Stevenson
The timeout period for VPU communications is a useful thing
to extend when debugging.
Set it via a define, rather than a magic number buried in the code.
Signed-off-by: Dave Stevenson
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging
On Tue, 2020-06-23 at 15:11 -0700, Joe Perches wrote:
> On Tue, 2020-06-23 at 18:41 +0200, Nicolas Saenz Julienne wrote:
> > From: Dave Stevenson
> >
> > Fixes up a checkpatch error "Avoid using bool structure members
> > because of possible alignment issues
a "decrement variable and wait" timeout scheme.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/usb/dwc3/gadget.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 8f8c215..d0c711f 100644
--- a/d
From: Nicolas Saenz Julienne
__dwc3_gadget_wakeup() is called while holding a spinlock, then depends on
jiffies in order to timeout while polling the USB core for a link state
update. In the case the wakeup failed, the timeout will never happen and
will also cause the cpu to stall until
a "decrement variable and wait" timeout scheme.
Signed-off-by: Nicolas Saenz Julienne
---
v2. removed udelay() from while loop
note: resubmitting since earlier patch had errata on e-mail address
drivers/usb/dwc3/gadget.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
di
1001 - 1064 of 1064 matches
Mail list logo