ebased, adapted to upstream changes ]
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> slot_id_bits and slot_gen_bits can be read directly from qxlrom instead.
> va_slot_mask is never used anywhere.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
flicts are rare enough by pure luck.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> dumb buffers are used as qxl surfaces, so allocate them as
> QXL_GEM_DOMAIN_SURFACE. Should usually be allocated in
> PRIV ttm domain then, so this reduces VRAM memory pressure.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
hich must be allocated there.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> The shadow bo is used as qxl surface, so allocate it as
> QXL_GEM_DOMAIN_SURFACE. Should usually be allocated in
> PRIV ttm domain then, so this reduces VRAM memory pressure.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
nother condition, but
the condition for applying the cursor is changed from bo_old->is_primary
to !bo->is_primary.
It probably makes sense to someone that knows the driver.
Acked-by: Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
n
> qxl_io_create_primary().
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
x27;t spot anything suspicious
looking.
Acked-by: Noralf Trønnes
t; - &user_bo->shadow);
> - user_bo->shadow->surf = user_bo->surf;
> + if (user_bo->shadow != qdev->dumb_shadow_bo) {
> + if (user_bo->shadow) {
> +
el doesn't need to dereference pointers each time it
> needs the value, and when reading the code you don't have to trace where
> and why qdev->monitors_config->max_allowed is set.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
unmap is balanced.
>
> Signed-off-by: Gerd Hoffmann
> ---
Just a note: You catch the one-to-many kmap type of unbalance, but not
the one-too-many kunmap situation.
Acked-by: Noralf Trønnes
> drivers/gpu/drm/qxl/qxl_drv.h| 1 +
> drivers/gpu/drm/qxl/qxl_object.c | 6 ++
&g
if (ret)
> goto modeset_cleanup;
>
> + drm_fb_helper_remove_conflicting_pci_framebuffers(pdev, 0, "qxl");
I couldn't find that this was part of old fbdev code, so it would be
nice to mention it in the commit message.
Acked-by: Noralf Trønnes
> + drm_fbdev_generic_setup(&qdev->ddev, 32);
> return 0;
>
> modeset_cleanup:
>
---
> drivers/gpu/drm/qxl/Makefile | 2 +-
> 4 files changed, 1 insertion(+), 554 deletions(-)
> delete mode 100644 drivers/gpu/drm/qxl/qxl_fb.c
>
Nice!
Acked-by: Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
will not be added to the mode list in the first place.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> Add a helper function to add custom video modes to a connector.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> Add all standard modes from the kernel's video mode data base.
> Keep a few non-standard modes in the qxl mode list.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
t; drivers/gpu/drm/qxl/qxl_draw.c | 232 ---
>>> drivers/gpu/drm/qxl/qxl_fb.c | 300
>>> -
>>> drivers/gpu/drm/qxl/Makefile | 2 +-
>>> 4 files changed, 1 insertion(+), 554 deletions(-)
>>> delete mode 100644 dri
probably replace the
> commit message with that.
>
This is actually my first review of a driver that I'm not familiar with.
I'm not quite sure how much in depth understanding that is required to
put my ack on it. Going further into the patchset I realised that
there's no way that I can verify the logic without being intimate with
the driver. So I have tried to verify things from a kms point of view.
I liked your expanded explanation better.
Noralf.
>> Acked-by: Noralf Trønnes
>
> thanks,
> Gerd
>
Den 28.01.2019 09.59, skrev Gerd Hoffmann:
> On Fri, Jan 25, 2019 at 06:25:27PM +0100, Noralf Trønnes wrote:
>>
>>
>> Den 18.01.2019 13.20, skrev Gerd Hoffmann:
>>> Switch qxl over to the new generic fbdev emulation.
>>>
>>> Signed-off-by:
L_FLAG_NO_EVICT so ttm knows. Doesn't change much for the moment
> as virtio-gpu supports TTM_PL_FLAG_TT only so there is no opportunity to
> move around objects. That'll probably change in the future though.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
then initialize the
> ttm object, and finally attach just created object to the fence for the
> command in case it didn't finish yet.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
; void virtgpu_gem_prime_unpin(struct drm_gem_object *obj)
> {
> - WARN_ONCE(1, "not implemented");
> + /* nothing */
> }
You can just remove these dummies the callbacks are optional. See
drm_gem_pin().
With that:
Reviewed-by: Noralf Trønnes
>
> void *virtgpu_gem_prime_vmap(struct drm_gem_object *obj)
>
Den 27.02.2019 15.44, skrev Gerd Hoffmann:
> Sync gem vm_node.start with ttm vm_node.start,
> then we can just call drm_gem_prime_mmap().
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
nevertheless.
>
> Signed-off-by: Gerd Hoffmann
Acked-by: Noralf Trønnes
;
> Signed-off-by: Oleksandr Andrushchenko
> ---
Acked-by: Noralf Trønnes
Den 31.07.2020 14.51, skrev Oleksandr Andrushchenko:
> From: Oleksandr Andrushchenko
>
> Add YUYV to supported formats, so the frontend can work with the
> formats used by cameras and other HW.
>
> Signed-off-by: Oleksandr Andrushchenko
> ---
Acked-by: Noralf Trønnes
Den 18.06.2015 04:26, skrev Stephen Warren:
On 06/12/2015 11:26 AM, Noralf Trønnes wrote:
Add a duplicate irq range with an offset on the hwirq's so the
driver can detect that enable_fiq() is used.
Tested with downstream dwc_otg USB controller driver.
This basically looks OK, but
.height = 160,
+ .init_seq = st7735r_init,
+ .init_seq_sz = ARRAY_SIZE(st7735r_init),
+ },
+ {
Can this be put on one line? }, {
With the struct moved:
Acked-by: Noralf Trønnes
--
To unsubscribe from this list: send the line "unsubscribe linux-kerne
Den 15.07.2015 04:14, skrev Greg KH:
On Tue, Jun 30, 2015 at 08:43:13AM +0200, Fabio Falzoi wrote:
Use a helper function to choose which set_addr_win implementation to
use, based on the value of the setaddrwin module parameter.
Signed-off-by: Fabio Falzoi
---
drivers/staging/fbtft/flexfb.c
Den 15.07.2015 11:36, skrev Paul Bolle:
On di, 2015-07-14 at 14:59 +0200, Henri Chain wrote:
--- /dev/null
+++ b/drivers/staging/fbtft/fb_uc1611.c
+#define DRVNAME"fb_uc1611"
+MODULE_ALIAS("spi:" DRVNAME);
+MODULE_ALIAS("platform:" DRVNAME);
+MODULE_ALIAS("spi:uc1611");
+MODULE_
Den 14.07.2015 14:59, skrev Henri Chain:
This is a driver chip for 240x160 4-bit greyscale LCDs.
It is capable of 4-wire (8 bit) or 3-wire (9 bit) SPI that have both been
tested. (It also has a 6800 or 8080-style parallel interface, but I have
not included support for it.)
Signed-off-by: Henri
Den 25.08.2015 19:34, skrev Stefan Wahren:
Noralf Trønnes hat am 25. August 2015 um 00:00
geschrieben:
Den 24.08.2015 20:33, skrev Stefan Wahren:
Since bits_per_word isn't usually checked during SPI setup the 9-bit
support must be checked manually.
Signed-off-by: Stefan W
ahren
---
drivers/staging/fbtft/fbtft-core.c | 10 +++---
drivers/staging/fbtft/flexfb.c | 11 ---
2 files changed, 7 insertions(+), 14 deletions(-)
Thanks Stefan.
Both patches:
Acked-by: Noralf Trønnes
--
To unsubscribe from this list: send the line "unsubsc
to freed memory.
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/fbtft-core.c | 12 +---
drivers/staging/fbtft/fbtft.h | 5 +++--
drivers/staging/fbtft/flexfb.c | 2 +-
3 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c
Use the fbdev deferred io support in drm_fb_helper which mirrors the
one qxl has had.
This patch has only been compile tested.
Signed-off-by: Noralf Trønnes
Reviewed-by: Daniel Vetter
---
Changes since v2:
- The drm_clip_rect_{width/height} functions are dropped, so open code it
Changes since
rectly.
Signed-off-by: Noralf Trønnes
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/qxl/qxl_fb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c
index bb7ce07..3f7c543 100644
--- a/drivers/gpu/drm/qxl/qxl_fb.c
rectly.
Signed-off-by: Noralf Trønnes
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/udl/udl_fb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c
index fd1eb9d..a52de2f 100644
--- a/drivers/gpu/drm/udl/udl_fb.c
ook to set a driver provided
(struct drm_framebuffer_funcs *)->dirty() function.
Cc: laurent.pinch...@ideasonboard.com
Signed-off-by: Noralf Trønnes
---
Changes since v2:
- FB_DEFERRED_IO is now always selected by DRM_KMS_FB_HELPER, ifdef removed
drivers/gpu/drm/drm_fb_cma_helpe
Use the fbdev deferred io support in drm_fb_helper.
The (struct fb_ops *)->fb_{fillrect,copyarea,imageblit} functions will
now schedule a worker instead of being flushed directly like it was
previously (recorded when in atomic).
This patch has only been compile tested.
Signed-off-by: Nor
from atomic context (spin_lock_irqsave)
- Export fb_deferred_io_mmap()
- Add some more documentation
- Add qxl and udl patches
Noralf Trønnes (7):
drm/udl: Change drm_fb_helper_sys_*() calls to sys_*()
drm/qxl: Change drm_fb_helper_sys_*() calls to sys_*()
drm/fb-helper: Add fb_deferred_io suppo
This adds deferred io support to drm_fb_helper.
The fbdev framebuffer changes are flushed using the callback
(struct drm_framebuffer *)->funcs->dirty() by a dedicated worker
ensuring that it always runs in process context.
Signed-off-by: Noralf Trønnes
Reviewed-by: Daniel Vetter
---
C
ot to nocache for instance, so I think the safest bet is
to do this in the driver and not in the fbdev core. And we can't call
fb_pgprotect() from fb_deferred_io_mmap() either because we don't have
access to the file pointer that powerpc needs.
Signed-off-by: Noralf Trønnes
---
Change
Den 29.04.2016 14:50, skrev Tomi Valkeinen:
Hi,
On 28/04/16 18:18, Noralf Trønnes wrote:
This adds deferred io support to drm_fb_helper.
The fbdev framebuffer changes are flushed using the callback
(struct drm_framebuffer *)->funcs->dirty() by a dedicated worker
ensuring that it alway
Provides helper functions for drivers that have a simple display
pipeline. Plane, crtc and encoder are collapsed into one entity.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/Kconfig | 7 ++
drivers/gpu/drm/Makefile| 1 +
drivers/gpu/drm
.
- drm_panel_connector_create()
Create a simple connector for a panel.
Noralf Trønnes (4):
drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs()
drm: Make drm_encoder_helper_funcs optional
drm: Add helper for simple display pipeline
drm/panel: Add helper for simple panel connector
Make drm_encoder_helper_funcs and it's functions optional to avoid
having dummy functions.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/drm_atomic_helper.c | 11 --
drivers/gpu/drm/drm_crtc_helper.c | 41 +
2 files changed, 42 insertions(+
Add drm_fb_cma_create_with_funcs() for drivers that need to set the
dirty() callback.
Cc: laurent.pinch...@ideasonboard.com
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/drm_fb_cma_helper.c | 29 +++--
include/drm/drm_fb_cma_helper.h | 3 +++
2 files changed, 26
Add function to create a simple connector for a panel.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/Makefile | 1 +
drivers/gpu/drm/drm_panel_helper.c | 117 +
drivers/gpu/drm/panel/Kconfig | 7 +++
include/drm/drm_panel_helper.h
Den 05.05.2016 18:27, skrev Daniel Vetter:
On Thu, May 05, 2016 at 03:24:31PM +0200, Noralf Trønnes wrote:
Add drm_fb_cma_create_with_funcs() for drivers that need to set the
dirty() callback.
Cc: laurent.pinch...@ideasonboard.com
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm
Den 05.05.2016 19:03, skrev Daniel Vetter:
On Thu, May 05, 2016 at 03:24:34PM +0200, Noralf Trønnes wrote:
Add function to create a simple connector for a panel.
Signed-off-by: Noralf Trønnes
Like in the previous patch please also add a new section for the panel
helpers to gpu.tmpl. I don&#
Den 06.05.2016 16:15, skrev Thierry Reding:
On Fri, May 06, 2016 at 04:08:16PM +0200, Daniel Vetter wrote:
On Fri, May 06, 2016 at 04:03:47PM +0200, Thierry Reding wrote:
On Thu, May 05, 2016 at 03:24:34PM +0200, Noralf Trønnes wrote:
Add function to create a simple connector for a panel
Den 06.05.2016 16:43, skrev Thierry Reding:
On Fri, May 06, 2016 at 04:34:08PM +0200, Noralf Trønnes wrote:
Den 06.05.2016 16:15, skrev Thierry Reding:
On Fri, May 06, 2016 at 04:08:16PM +0200, Daniel Vetter wrote:
On Fri, May 06, 2016 at 04:03:47PM +0200, Thierry Reding wrote:
On Thu, May
Den 07.05.2016 11:59, skrev Daniel Vetter:
On Fri, May 6, 2016 at 9:45 PM, Noralf Trønnes wrote:
In the discussion following the "no more fbdev drivers" call, someone
pointed me to drm_panel. It had function hooks that I needed, so I built
tinydrm around it. If this is misusing drm
Den 09.05.2016 16:46, skrev Daniel Vetter:
On Thu, May 05, 2016 at 03:24:33PM +0200, Noralf Trønnes wrote:
Provides helper functions for drivers that have a simple display
pipeline. Plane, crtc and encoder are collapsed into one entity.
Signed-off-by: Noralf Trønnes
+static int
Den 05.05.2016 18:23, skrev Daniel Vetter:
On Thu, May 05, 2016 at 03:24:32PM +0200, Noralf Trønnes wrote:
Make drm_encoder_helper_funcs and it's functions optional to avoid
having dummy functions.
Signed-off-by: Noralf Trønnes
Please also update the kerneldoc and mention there tha
Don't skip drm_bridge_*() calls if encoder->helper_private is NULL.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/drm_atomic_helper.c | 39 -
1 file changed, 17 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c
b
Provides helper functions for drivers that have a simple display
pipeline. Plane, crtc and encoder are collapsed into one entity.
Signed-off-by: Noralf Trønnes
---
Changes since v1:
- Add DOC header and add to gpu.tmpl
- Fix docs: @funcs is optional, "negative error code",
&qu
This was forgotten to fixup in the latest version of the deferred_io
patch which made FB_DEFERRED_IO mandatory.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/drm_fb_helper.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c
Add (struct drm_connector_helper_funcs *)->best_encoder callback helper
for connectors that support exactly 1 encoder, statically determined at
driver init time.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/drm_atomic_helper.c | 17 +
include/drm/drm_atomic_helpe
Hook up fb_cma_helper to DocBook. Remove mention of
CONFIG_FB_DEFERRED_IO in the docs, which was forgotten in the latest
version of the deferred_io patch.
Use & when referencing drm_mode_config_funcs in docs.
Signed-off-by: Noralf Trønnes
---
Documentation/DocBook/gpu.tmpl
Fix docs: @funcs is optional, "negative error code",
"This hook is optional."
- Add checks to drm_simple_kms_plane_atomic_check()
Noralf Trønnes (6):
drm/fb-helper: Remove mention of CONFIG_FB_DEFERRED_IO in docs
drm/fb-cma-helper: Hook up to DocBook and fix some docs
drm
Add drm_fb_cma_create_with_funcs() for drivers that need to set the
dirty() callback.
Cc: laurent.pinch...@ideasonboard.com
Signed-off-by: Noralf Trønnes
---
Changes since v1:
- Expand docs
drivers/gpu/drm/drm_fb_cma_helper.c | 31 +--
include/drm
Den 11.05.2016 19:09, skrev Daniel Vetter:
On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote:
Provides helper functions for drivers that have a simple display
pipeline. Plane, crtc and encoder are collapsed into one entity.
Signed-off-by: Noralf Trønnes
Looks really nice, just a
Den 11.05.2016 21:10, skrev Paul Bolle:
On wo, 2016-05-11 at 19:09 +0200, Daniel Vetter wrote:
On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote:
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
+config DRM_SIMPLE_KMS_HELPER
+ tristate
+ depends on DRM
Den 12.05.2016 10:11, skrev Daniel Vetter:
On Wed, May 11, 2016 at 07:09:10PM +0200, Daniel Vetter wrote:
On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote:
+/**
+ * drm_simple_display_pipe_init - Initialize a simple display pipeline
+ * @dev: DRM device
+ * @pipe: simple display
Add drm_fb_cma_create_with_funcs() for drivers that need to set the
dirty() callback.
Cc: laurent.pinch...@ideasonboard.com
Signed-off-by: Noralf Trønnes
---
Changes since v1:
- Expand docs
drivers/gpu/drm/drm_fb_cma_helper.c | 31 +--
include/drm
Provides helper functions for drivers that have a simple display
pipeline. Plane, crtc and encoder are collapsed into one entity.
Cc: jsa...@ti.com
Signed-off-by: Noralf Trønnes
---
Changes since v2:
- Drop Kconfig knob DRM_KMS_HELPER
- Expand documentation
Changes since v1:
- Add DOC header
r and add to gpu.tmpl
- Fix docs: @funcs is optional, "negative error code",
"This hook is optional."
- Add checks to drm_simple_kms_plane_atomic_check()
Noralf Trønnes (2):
drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs()
drm: Add helper fo
Den 17.05.2016 09:59, skrev Daniel Vetter:
On Tue, May 17, 2016 at 10:46:51AM +0300, Ville Syrjälä wrote:
On Tue, May 17, 2016 at 09:05:01AM +0200, Daniel Vetter wrote:
On Thu, May 12, 2016 at 09:36:14PM +0300, Ville Syrjälä wrote:
On Thu, May 12, 2016 at 08:25:23PM +0200, Noralf Trønnes
Den 17.05.2016 14:12, skrev Ville Syrjälä:
On Tue, May 17, 2016 at 02:00:45PM +0200, Noralf Trønnes wrote:
Den 17.05.2016 09:59, skrev Daniel Vetter:
On Tue, May 17, 2016 at 10:46:51AM +0300, Ville Syrjälä wrote:
On Tue, May 17, 2016 at 09:05:01AM +0200, Daniel Vetter wrote:
On Thu, May 12
Den 12.05.2016 20:25, skrev Noralf Trønnes:
Provides helper functions for drivers that have a simple display
pipeline. Plane, crtc and encoder are collapsed into one entity.
Cc: jsa...@ti.com
Signed-off-by: Noralf Trønnes
---
[...]
diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c
b
each time I'm confronted with it.)
You have even taken care of the special txbuflen == -1 value I see,
so I guess this is as good as it gets without any major refactoring, so:
Acked-by: Noralf Trønnes
And there's no point in doing any refactoring since I'm working on a DR
Den 26.04.2016 19:19, skrev Daniel Vetter:
On Tue, Apr 26, 2016 at 06:24:54PM +0200, Noralf Trønnes wrote:
Den 25.04.2016 11:09, skrev Daniel Vetter:
On Sun, Apr 24, 2016 at 10:48:58PM +0200, Noralf Trønnes wrote:
This adds deferred io support if CONFIG_FB_DEFERRED_IO is enabled.
The fbdev
ook to set a driver provided
(struct drm_framebuffer_funcs *)->dirty() function.
Signed-off-by: Noralf Trønnes
---
Changes since v2:
- FB_DEFERRED_IO is now always selected by DRM_KMS_FB_HELPER, ifdef removed
drivers/gpu/drm/drm_fb_cma_helper.c | 178 +---
in
Use the fbdev deferred io support in drm_fb_helper.
The (struct fb_ops *)->fb_{fillrect,copyarea,imageblit} functions will
now schedule a worker instead of being flushed directly like it was
previously (recorded when in atomic).
This patch has only been compile tested.
Signed-off-by: Nor
rectly.
Signed-off-by: Noralf Trønnes
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/udl/udl_fb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c
index fd1eb9d..a52de2f 100644
--- a/drivers/gpu/drm/udl/udl_fb.c
rectly.
Signed-off-by: Noralf Trønnes
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/qxl/qxl_fb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c
index bb7ce07..3f7c543 100644
--- a/drivers/gpu/drm/qxl/qxl_fb.c
This adds deferred io support to drm_fb_helper.
The fbdev framebuffer changes are flushed using the callback
(struct drm_framebuffer *)->funcs->dirty() by a dedicated worker
ensuring that it always runs in process context.
Signed-off-by: Noralf Trønnes
---
Changes since v2:
- FB_DEFERRED
ot to nocache for instance, so I think the safest bet is
to do this in the driver and not in the fbdev core. And we can't call
fb_pgprotect() from fb_deferred_io_mmap() either because we don't have
access to the file pointer that powerpc needs.
Signed-off-by: Noralf Trønnes
---
Change
rm_clip_rect functions in drm_rect.{h,c}
- Take into account that (struct fb_ops *)->fb_{write,...}() can be called
from atomic context (spin_lock_irqsave)
- Export fb_deferred_io_mmap()
- Add some more documentation
- Add qxl and udl patches
Noralf Trønnes (7):
drm/udl: Change drm_fb_helper_sys_*(
Use the fbdev deferred io support in drm_fb_helper which mirrors the
one qxl has had.
This patch has only been compile tested.
Signed-off-by: Noralf Trønnes
---
Changes since v2:
- The drm_clip_rect_{width/height} functions are dropped, so open code it
Changes since v1:
- Add FIXME about
Den 27.04.2016 21:20, skrev Daniel Vetter:
On Wed, Apr 27, 2016 at 08:16:32PM +0200, Noralf Trønnes wrote:
This adds deferred io support to drm_fb_helper.
The fbdev framebuffer changes are flushed using the callback
(struct drm_framebuffer *)->funcs->dirty() by a dedicated worker
ensurin
Den 27.04.2016 21:24, skrev Daniel Vetter:
On Wed, Apr 27, 2016 at 08:16:29PM +0200, Noralf Trønnes wrote:
This patchset adds fbdev deferred io support to drm_fb_helper and
drm_fb_cma_helper.
It channels fbdev mmap and fb_{write,fillrect,copyarea,imageblit} damage
through the (struct
Den 12.05.2016 15:47, skrev Laurent Pinchart:
Hi Noralf,
Thank you for the patch.
On Thursday 12 May 2016 14:53:25 Noralf Trønnes wrote:
Add drm_fb_cma_create_with_funcs() for drivers that need to set the
dirty() callback.
Cc: laurent.pinch...@ideasonboard.com
Signed-off-by: Noralf Trønnes
drm_framebuffer_init() uses const for the drm_framebuffer_funcs
argument so use that on drm_fb_cma_alloc() and
drm_fbdev_cma_create_with_funcs() as well.
Cc: laurent.pinch...@ideasonboard.com
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/drm_fb_cma_helper.c | 4 ++--
include/drm
uot;negative error code",
"This hook is optional."
- Add checks to drm_simple_kms_plane_atomic_check()
Noralf Trønnes (3):
drm/fb-cma-helper: Use const for drm_framebuffer_funcs argument
drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs()
drm: Add helper for s
Add drm_fb_cma_create_with_funcs() for drivers that need to set the
dirty() callback.
Signed-off-by: Noralf Trønnes
Acked-by: Laurent Pinchart
---
Changes since v3:
- funcs argument should be const
Changes since v1:
- Expand docs
drivers/gpu/drm/drm_fb_cma_helper.c | 31
Provides helper functions for drivers that have a simple display
pipeline. Plane, crtc and encoder are collapsed into one entity.
Cc: jsa...@ti.com
Signed-off-by: Noralf Trønnes
---
Changes since v3:
- (struct drm_simple_display_pipe *)->funcs should be const
Changes since v2:
- Drop Kcon
Den 09.09.2015 03:48, skrev Eric Anholt:
ker...@martin.sperl.org writes:
From: Martin Sperl
The BCM2835 contains 3 auxiliar devices:
* spi1
* spi2
* uart1
All of those 3 devices are enabled/disabled via a shared register,
which is set by default to be disabled.
Access to this register need
10.09.2015 06:54, skrev Sudip Mukherjee:
On Wed, Sep 09, 2015 at 11:20:08PM +0200, Noralf Trønnes wrote:
Den 09.09.2015 20:35, skrev Greg Kroah-Hartman:
On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote:
Instead of defining DRVNAME and using it in all calls to pr_* family of
Den 22.07.2015 23:32, skrev Eric Anholt:
Noralf Trønnes writes:
Add a duplicate irq range with an offset on the hwirq's so the
driver can detect that enable_fiq() is used.
Tested with downstream dwc_otg USB controller driver.
Signed-off-by: Noralf Trønnes
---
arch/arm/mach-bcm/Kc
Den 18.06.2015 05:58, skrev Guenter Roeck:
On 06/17/2015 07:04 AM, Noralf Trønnes wrote:
Currently poweroff/halt results in a reboot on the Raspberry Pi.
The firmware uses the RSTS register to know which partiton to
boot from. The partiton value is spread into bits
0, 2, 4, 6, 8, 10. Partiton
Den 17.12.2015 00:55, skrev Eric Anholt:
This should be a complete port of bcm2835 functionality to bcm2836
(Raspberry Pi 2).
Signed-off-by: Eric Anholt
---
v2: Implement Arnd's feedback to not split to ARCH_BCM2836, and
instead use more conditionals in ARCH_BCM2835. Also reduce diff
Den 13.05.2015 21:00, skrev Eric Anholt:
This driver will provide support for calls into the firmware that will
be used by other drivers like cpufreq and vc4.
Signed-off-by: Eric Anholt
---
v2: Improve commit message, point to mailbox.txt for how mboxes work.
.../devicetree/bindings/arm/bc
Den 13.05.2015 21:00, skrev Eric Anholt:
This gives us a function for making mailbox property channel requests
of the firmware, which is most notable in that it will let us get and
set clock rates.
Signed-off-by: Eric Anholt
---
v2: Drop power-domains stuff for now since we don't have the dri
Den 13.05.2015 21:00, skrev Eric Anholt:
This gives us a function for making mailbox property channel requests
of the firmware, which is most notable in that it will let us get and
set clock rates.
Signed-off-by: Eric Anholt
---
[...]
+/*
+ * Submits a single tag to the VPU firmware throug
Den 01.05.2015 23:07, skrev Martin Sperl:
Tests with the initial (and incomplete) version of the spi-bcm2835 driver
with DMA transfer support show that the dma-engine works as expected with
this patch.
There is one one observation:
On 18.04.2015, at 13:06, Noralf Trønnes wrote:
+static
101 - 200 of 435 matches
Mail list logo
