Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-02 Thread Noralf Trønnes
Den 02.08.2017 00.26, skrev David Lechner: On 08/01/2017 01:08 PM, Noralf Trønnes wrote: (cc: Daniel Vetter) Den 01.08.2017 18.51, skrev David Lechner: On 07/30/2017 12:14 PM, Noralf Trønnes wrote: Den 29.07.2017 21.40, skrev David Lechner: On 07/29/2017 02:17 PM, David Lechner wrote

Re: [PATCH v2 2/4] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

2017-08-02 Thread Noralf Trønnes
Den 02.08.2017 00.11, skrev David Lechner: LEGO MINDSTORMS EV3 has an LCD with a ST7586 controller. This adds a new module for the ST7586 controller with parameters for the EV3 LCD display. Signed-off-by: David Lechner --- .../devicetree/bindings/display/st7586.txt | 26 +

Re: [PATCH v2 2/4] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

2017-08-02 Thread Noralf Trønnes
Den 02.08.2017 00.11, skrev David Lechner: LEGO MINDSTORMS EV3 has an LCD with a ST7586 controller. This adds a new module for the ST7586 controller with parameters for the EV3 LCD display. Signed-off-by: David Lechner --- .../devicetree/bindings/display/st7586.txt | 26 + I

Re: [PATCH v2 2/4] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

2017-08-02 Thread Noralf Trønnes
Den 02.08.2017 18.24, skrev David Lechner: On 08/02/2017 08:03 AM, Noralf Trønnes wrote: Please use tinydrm_xrgb_to_gray8(). I considered this, but is seems excessive to loop through the entire fb twice just to make a 4x6 cursor blink. Yes, you're right about that. Can you change

Re: [PATCH] drm/tinydrm: mipi-dbi: Fix unbalanced DMA access

2017-08-02 Thread Noralf Trønnes
Den 01.08.2017 22.14, skrev David Lechner: If we return here and import_attach is true, then dma_buf_end_cpu_access() will not be called balance dma_buf_begin_cpu_access(). Fix by setting ret instead of returning. Signed-off-by: David Lechner --- Reviewed-by: Noralf Trønnes drivers

Re: [PATCH v2 1/4] drm/tinydrm: remove call to mipi_dbi_init() from mipi_dbi_spi_init()

2017-08-02 Thread Noralf Trønnes
Den 02.08.2017 00.11, skrev David Lechner: This removes the call to mipi_dbi_init() from mipi_dbi_spi_init() so that drivers can have a driver-specific implementation if needed. Also fixed order of @dc parameter in the doc comment. Suggested-by: Noralf Trønnes Signed-off-by: David Lechner

Re: [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown.

2017-08-02 Thread Noralf Trønnes
ache_destroy(dev); } I don't have a display connected, but there's no crashing anymore. Tested-by: Noralf Trønnes Acked-by: Noralf Trønnes

Re: [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI.

2017-08-03 Thread Noralf Trønnes
Den 02.08.2017 22.32, skrev Eric Anholt: drm_bridge_remove() is for unregistering a bridge driver, not for detaching a bridge from its consumer. Fixes: 656fa22f9cea ("drm/vc4: Switch DSI to the panel-bridge layer, and support bridges.") Signed-off-by: Eric Anholt --- Acked-

Re: [PATCH 2/3] drm/vc4: Don't disable DSI clocks on component unload.

2017-08-03 Thread Noralf Trønnes
Den 02.08.2017 22.32, skrev Eric Anholt: The clocks are enabled/disabled at encoder enable/disable time, not at component load. Fixes a WARN_ON at boot if V3D fails to probe. Fixes: 4078f5757144 ("drm/vc4: Add DSI driver") Signed-off-by: Eric Anholt --- Acked-by: Nora

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-03 Thread Noralf Trønnes
Den 02.08.2017 00.26, skrev David Lechner: On 08/01/2017 01:08 PM, Noralf Trønnes wrote: (cc: Daniel Vetter) Den 01.08.2017 18.51, skrev David Lechner: On 07/30/2017 12:14 PM, Noralf Trønnes wrote: Den 29.07.2017 21.40, skrev David Lechner: On 07/29/2017 02:17 PM, David Lechner wrote

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Noralf Trønnes
Den 04.04.2018 00.42, skrev Rob Clark: Add an atomic helper to implement dirtyfb support. This is needed to support DSI command-mode panels with x11 userspace (ie. when we can't rely on pageflips to trigger a flush to the panel). To signal to the driver that the async atomic update needs to

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Noralf Trønnes
Den 04.04.2018 19.56, skrev Daniel Vetter: On Wed, Apr 4, 2018 at 7:41 PM, Noralf Trønnes wrote: Den 04.04.2018 00.42, skrev Rob Clark: Add an atomic helper to implement dirtyfb support. This is needed to support DSI command-mode panels with x11 userspace (ie. when we can't rely

Re: [PATCH] drm/tinydrm: Allocate dummy SPI RX buffer if needed

2018-02-27 Thread Noralf Trønnes
these functions are re-used where possible (e.g. in mipi_dbi_init()). Cc: Noralf Trønnes Suggested-by: Noralf Trønnes Signed-off-by: David Lechner --- This is a follow up from the mail thread "tinydrm: page allocation failure" [1]. I actually got an allocation failure a few times even when

Re: [PATCH v3 3/3] drm/tinydrm: add driver for ST7735R panels

2017-12-31 Thread Noralf Trønnes
_crtc_state *crtc_state) This is confusing, you name the mode after the panel, but not the enable function which has an initialization sequence that is also panel specific. With .enable function named after the panel (and *_pipe_funcs): Reviewed-by: Noralf Trønnes +{ + struct tinydrm_d

Re: [PATCH v3 3/3] drm/tinydrm: add driver for ST7735R panels

2017-12-31 Thread Noralf Trønnes
Den 21.12.2017 20.35, skrev David Lechner: On 12/21/2017 01:23 PM, David Lechner wrote: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner --- +    mipi_dbi_command(mipi, ST7735R_GAMCTRP1, 0x0f, 0x1a,

Re: [PATCH 0/3] update compatible string for ILI9225

2018-01-03 Thread Noralf Trønnes
Den 21.12.2017 19.33, skrev David Lechner: This updates the device tree compatible string for an ILI9225 display. Detailed explanation is in the patches. David Lechner (3): dt-bindings: Add "vot" vendor prefix dt-bindings: update compatible string for ILI9225 drm/tinydrm: Update

Re: [PATCH v4 3/3] drm/tinydrm: add driver for ST7735R panels

2018-01-03 Thread Noralf Trønnes
Den 02.01.2018 10.42, skrev Linus Walleij: On Mon, Jan 1, 2018 at 8:02 PM, David Lechner wrote: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner Reviewed-by: Noralf Trønnes Reviewed-by:

Re: [PATCH v2 3/4] drm/tinydrm: export mipi_dbi_buf_copy and mipi_dbi_spi_cmd_max_speed

2017-11-22 Thread Noralf Trønnes
Den 19.11.2017 21.12, skrev David Lechner: This exports the mipi_dbi_buf_copy() and mipi_dbi_spi_cmd_max_speed() functions so that they can be shared with other drivers. Signed-off-by: David Lechner --- Reviewed-by: Noralf Trønnes v2 changes: * new patch in v2 drivers/gpu/drm/tinydrm

Re: [PATCH v2 4/4] drm/tinydrm: add driver for ILI9225 panels

2017-11-22 Thread Noralf Trønnes
echner --- Reviewed-by: Noralf Trønnes v2 changes: * use exported mipi_dbi_* functions from patch 3/4 * new ili9225_command function MAINTAINERS | 6 + drivers/gpu/drm/tinydrm/Kconfig | 10 + drivers/gpu/drm/tinydrm/Makefile | 1 + drivers/gpu/drm/tinydrm/i

Re: [PATCH v1 2/2] drm/tinydrm: add driver for ST7735R panels

2017-12-06 Thread Noralf Trønnes
Den 29.11.2017 04.01, skrev David Lechner: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner --- MAINTAINERS | 6 + drivers/gpu/drm/tinydrm/Kconfig | 10 ++

Re: [PATCH v2 0/4] DRM driver for ILI9225 display panels

2017-12-01 Thread Noralf Trønnes
Den 19.11.2017 21.12, skrev David Lechner: This is a new driver for ILI9225 based display panels. Thanks, applied to drm-misc. Noralf. v2 changes: * New patch for ilitek vendor prefix. * Use "ilitek" instead of "generic" in dt-bindings * New patch to export 2 mipi_dbi_* functions * Clean

Re: [PATCH v1 2/2] drm/tinydrm: add driver for ILI9225 panels

2017-12-01 Thread Noralf Trønnes
(cc: Thierry) Den 01.12.2017 15.03, skrev Linus Walleij: On Wed, Nov 8, 2017 at 4:52 AM, David Lechner wrote: This adds a new driver for display panels based on the Ilitek ILI9225 controller. This was developed for a no-name panel with a red PCB that is commonly marketed for Arduino. See

Re: [PATCH v1 2/2] drm/tinydrm: add driver for ST7735R panels

2017-12-08 Thread Noralf Trønnes
Den 06.12.2017 19.27, skrev Noralf Trønnes: Den 29.11.2017 04.01, skrev David Lechner: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner --- diff --git a/drivers/gpu/drm/tinydrm/st7735r.c b/dr

Re: [PATCH v1 1/2] dt-bindings: Add binding for Sitronix ST7735R display panels

2017-12-08 Thread Noralf Trønnes
Den 29.11.2017 04.01, skrev David Lechner: This adds a new device tree binding for Sitronix ST7735R display panels, such as the Adafruit 1.8" TFT. Signed-off-by: David Lechner --- .../bindings/display/sitronix,st7735r.txt | 35 ++ 1 file changed, 35

Re: [PATCH v1 2/2] drm/tinydrm: add driver for ST7735R panels

2017-12-09 Thread Noralf Trønnes
Den 29.11.2017 04.01, skrev David Lechner: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner --- diff --git a/drivers/gpu/drm/tinydrm/st7735r.c b/drivers/gpu/drm/tinydrm/st7735r.c +static struct

Re: [PATCH v2 1/2] dt-bindings: Add binding for Sitronix ST7735R display panels

2017-12-11 Thread Noralf Trønnes
Den 10.12.2017 23.10, skrev David Lechner: This adds a new device tree binding for Sitronix ST7735R display panels, such as the Adafruit 1.8" TFT. Signed-off-by: David Lechner Acked-by: Rob Herring --- v2: changes: * None, but... I'm wondering about my choice of compatible here. I chose

Re: [PATCH v2 2/2] drm/tinydrm: add driver for ST7735R panels

2017-12-11 Thread Noralf Trønnes
Den 10.12.2017 23.10, skrev David Lechner: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner --- +static void st7735r_pipe_enable(struct drm_simple_display_pipe *pipe, +

Re: UDL's fbdev doesn't work for user-space apps

2017-12-12 Thread Noralf Trønnes
Den 04.12.2017 12.32, skrev Alexey Brodkin: Hello, I'm trying to use DisplayLink USB2.0-to-HDMI adapter as the one and only video output and I want to get Xserver working on top of that. I'm not very familiar with all the parts of Linux GPU/video stack (especially its user-space counterpart)

Re: [PATCH 5/6] drm/xen-front: Pass dumb buffer data offset to the backend

2020-08-07 Thread Noralf Trønnes
> > Signed-off-by: Oleksandr Andrushchenko > --- Acked-by: Noralf Trønnes

Re: [PATCH 3/6] drm/xen-front: Add YUYV to supported formats

2020-08-07 Thread Noralf Trønnes
Den 31.07.2020 14.51, skrev Oleksandr Andrushchenko: > From: Oleksandr Andrushchenko > > Add YUYV to supported formats, so the frontend can work with the > formats used by cameras and other HW. > > Signed-off-by: Oleksandr Andrushchenko > --- Acked-by: Noralf Trønnes

Re: [PATCH v5 6/8] drm/panel: Add ilitek ili9341 panel driver

2020-05-26 Thread Noralf Trønnes
Den 26.05.2020 11.08, skrev dillon min: > Hi Andy, > > Thanks for input. > > On Tue, May 26, 2020 at 3:46 PM Andy Shevchenko > wrote: >> >> On Mon, May 25, 2020 at 6:46 AM wrote: >>> >>> From: dillon min >>> >>> This driver combine tiny/ili9341.c mipi_dbi_interface driver >>> with

Re: [PATCH v18 07/10] drm/panel: Use backlight_enable/disable helpers

2018-01-23 Thread Noralf Trønnes
Den 22.01.2018 15.54, skrev Meghana Madhyastha: Use backlight_enable/disable helpers instead of changing the property and calling backlight_update_status for cleaner and simpler code and also to avoid repetitions. Signed-off-by: Meghana Madhyastha --- Reviewed-by: Noralf Trønnes

Re: [PATCH v18 08/10] drm/omapdrm: Use backlight_enable/disable helpers

2018-01-23 Thread Noralf Trønnes
Den 22.01.2018 15.54, skrev Meghana Madhyastha: Use backlight_enable/disable helpers instead of changing the property and calling backlight_update_status for cleaner and simpler code and also to avoid repetitions. Signed-off-by: Meghana Madhyastha --- Reviewed-by: Noralf Trønnes

Re: [PATCH v18 09/10] drm/panel: Use of_find_backlight helper

2018-01-23 Thread Noralf Trønnes
Den 22.01.2018 15.55, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off-by: Meghana Madhyastha --- Reviewed-by: Noralf Trønnes Changes in v18: -Fixed warnings resulting from passing

Re: [PATCH v18 10/10] drm/omapdrm: Use of_find_backlight helper

2018-01-23 Thread Noralf Trønnes
Den 22.01.2018 15.56, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off-by: Meghana Madhyastha --- Changes in v18: -Fixed warnings resulting from passing device_node* to

Re: [PATCH v18 01/10] video: backlight: Add helpers to enable and disable backlight

2018-01-23 Thread Noralf Trønnes
to avoid repetition of code and also to enforce a uniform and consistent way to enable/disable a backlight device. Signed-off-by: Meghana Madhyastha --- Acked-by: Daniel Thompson Reviewed-by: Noralf Trønnes Reviewed-by: Sean Paul Just in case there's another spin... the additional tags are normally

Re: [PATCH v18 10/10] drm/omapdrm: Use of_find_backlight helper

2018-01-23 Thread Noralf Trønnes
Den 23.01.2018 17.55, skrev Meghana Madhyastha: On Tue, Jan 23, 2018 at 03:37:38PM +0100, Noralf Trønnes wrote: Den 22.01.2018 15.56, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off

Re: [PATCH v18 10/10] drm/omapdrm: Use of_find_backlight helper

2018-01-23 Thread Noralf Trønnes
Den 23.01.2018 18.41, skrev Noralf Trønnes: Den 23.01.2018 17.55, skrev Meghana Madhyastha: On Tue, Jan 23, 2018 at 03:37:38PM +0100, Noralf Trønnes wrote: Den 22.01.2018 15.56, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight

Re: [PATCH v19 10/10] drm/omapdrm: Use of_find_backlight helper

2018-01-24 Thread Noralf Trønnes
Den 24.01.2018 17.41, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off-by: Meghana Madhyastha --- Reviewed-by: Noralf Trønnes Changes in v19: -Changed to devm version

Re: [PATCH] drm/tinydrm: Replace dev_error with DRM_DEV_ERROR

2017-09-25 Thread Noralf Trønnes
: drivers/gpu/drm/tinydrm/repaper.c:995: +   DRM_DEV_ERROR(dev, "Failed to get thermal zone: %s\n",     thermal_zone); With that changed you can add to your next version: Reviewed-by: Noralf Trønnes return; } @@ -62

Re: [Outreachy kernel] [PATCH] drm/tinydrm: Replace list_for_each with list_for_each_entry

2017-10-21 Thread Noralf Trønnes
Den 16.10.2017 21.19, skrev Sean Paul: On Sun, Oct 15, 2017 at 01:58:23AM +0530, Harsha Sharma wrote: Replace use of list_for_each with list_for_each_entry to simplify the code and remove variables that are used only in list_for_each. Done with following coccinelle patch: @r@ identifier

Re: [PATCH v2] drm: gem_cma_helper.c: Allow importing of contiguous scatterlists with nents > 1

2017-11-15 Thread Noralf Trønnes
Den 15.11.2017 14.04, skrev Liviu Dudau: Hi, On Sat, Nov 11, 2017 at 02:47:35PM +0200, Laurent Pinchart wrote: Hi Liviu, Thank you for the patch. On Friday, 10 November 2017 15:33:10 EET Liviu Dudau wrote: drm_gem_cma_prime_import_sg_table() will fail if the number of entries in the

Re: [PATCH v16 01/10] video: backlight: Add helpers to enable and disable backlight

2018-01-17 Thread Noralf Trønnes
Den 17.01.2018 18.00, skrev Daniel Thompson: On 16/01/18 10:31, Meghana Madhyastha wrote: Add helper functions backlight_enable and backlight_disable to enable/disable a backlight device. These helper functions can then be used by different drm and tinydrm drivers to avoid repetition of code

Re: [PATCH v16 09/10] drm/panel: Use of_find_backlight helper

2018-01-18 Thread Noralf Trønnes
Den 18.01.2018 13.07, skrev Meghana Madhyastha: On Tue, Jan 16, 2018 at 06:08:53PM +0100, Noralf Trønnes wrote: Den 16.01.2018 11.36, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off

Re: [PATCH v17 03/10] video: backlight: Add of_find_backlight helper in backlight.c

2018-01-21 Thread Noralf Trønnes
Den 19.01.2018 12.05, skrev Daniel Thompson: On Fri, Jan 19, 2018 at 10:42:15AM +, Meghana Madhyastha wrote: Add of_find_backlight, a helper function which is a generic version of tinydrm_of_find_backlight that can be used by other drivers to avoid repetition of code and simplify things.

Re: [PATCH v17 09/10] drm/panel: Use of_find_backlight helper

2018-01-21 Thread Noralf Trønnes
Den 19.01.2018 11.47, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off-by: Meghana Madhyastha --- changes in v17: -remove put_device() to avoid double put as we are using the devm

Re: [PATCH v17 06/10] drm/tinydrm: Call devres version of of_find_backlight

2018-01-21 Thread Noralf Trønnes
Den 19.01.2018 11.46, skrev Meghana Madhyastha: Call devm_of_find_backlight (the devres version) instead of of_find_backlight. Signed-off-by: Meghana Madhyastha --- I already put my r-b on this one in the previous version, but now also: Tested-by: Noralf Trønnes I did also test

Re: [PATCH v17 03/10] video: backlight: Add of_find_backlight helper in backlight.c

2018-01-21 Thread Noralf Trønnes
Den 19.01.2018 11.42, skrev Meghana Madhyastha: Add of_find_backlight, a helper function which is a generic version of tinydrm_of_find_backlight that can be used by other drivers to avoid repetition of code and simplify things. Signed-off-by: Meghana Madhyastha --- Reviewed-by: Noralf

Re: [PATCH v16 01/10] video: backlight: Add helpers to enable and disable backlight

2018-01-16 Thread Noralf Trønnes
way to enable/disable a backlight device. Signed-off-by: Meghana Madhyastha checkpatch complains: -:23: WARNING: Block comments should align the * on each line -:45: ERROR: trailing whitespace With that fixed: Reviewed-by: Noralf Trønnes --- include/linux/backlight.h | 30

Re: [PATCH v16 02/10] drm/tinydrm: Convert tinydrm_enable/disable_backlight to backlight_enable/disable

2018-01-16 Thread Noralf Trønnes
Den 16.01.2018 11.32, skrev Meghana Madhyastha: Remove tinydrm_enable/disable_backlight and let the callers call the more generic backlight_enable/disable helpers Signed-off-by: Meghana Madhyastha This patch needs to be rebased on some recent changes to mipi-dbi. Reviewed-by: Noralf

Re: [PATCH v16 03/10] video: backlight: Add of_find_backlight helper in backlight.c

2018-01-16 Thread Noralf Trønnes
Den 16.01.2018 11.33, skrev Meghana Madhyastha: Add of_find_backlight, a helper function which is a generic version of tinydrm_of_find_backlight that can be used by other drivers to avoid repetition of code and simplify things. Signed-off-by: Meghana Madhyastha --- Changes in v16: -Add

Re: [PATCH v16 04/10] drm/tinydrm: Replace tinydrm_of_find_backlight with of_find_backlight

2018-01-16 Thread Noralf Trønnes
rebasing, changes to mi0283qt. You've missed st7735r. I'd appreciate if you could also remove these from tinydrm/Kconfig:     select BACKLIGHT_LCD_SUPPORT     select BACKLIGHT_CLASS_DEVICE It's an ugly hack that we don't need anymore thanks to your work! With that fixed: Reviewed-by: Noralf

Re: [PATCH v16 05/10] video: backlight: Add devres versions of of_find_backlight

2018-01-16 Thread Noralf Trønnes
should align the * on each line This one is text so might as well fix it: -:29: WARNING: line over 80 characters With that fixed: Reviewed-by: Noralf Trønnes --- drivers/video/backlight/backlight.c | 29 + include/linux/backlight.h | 7 +++ 2 files

Re: [PATCH v16 06/10] drm/tinydrm: Call devres version of of_find_backlight

2018-01-16 Thread Noralf Trønnes
urn PTR_ERR(mipi->regulator); - mipi->backlight = of_find_backlight(dev); + mipi->backlight = devm_of_find_backlight(dev); if (IS_ERR(mipi->backlight)) return PTR_ERR(mipi->backlight); You've missed st7735r. With that fixed: Reviewed-by: Noralf Trønnes

Re: [PATCH v16 09/10] drm/panel: Use of_find_backlight helper

2018-01-16 Thread Noralf Trønnes
Den 16.01.2018 11.36, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off-by: Meghana Madhyastha --- drivers/gpu/drm/panel/panel-innolux-p079zca.c | 10 +++---

Re: [PATCH v16 07/10] drm/panel: Use backlight_enable/disable helpers

2018-01-16 Thread Noralf Trønnes
Den 16.01.2018 11.35, skrev Meghana Madhyastha: Use backlight_enable/disable helpers instead of changing the property and calling backlight_update_status for cleaner and simpler code and also to avoid repetitions. Signed-off-by: Meghana Madhyastha ---

Re: [PATCH] drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER

2019-10-10 Thread Noralf Trønnes
Den 01.10.2019 12.58, skrev Noralf Trønnes: > > > Den 27.09.2019 19.42, skrev Ulf Magnusson: >> Commit 554b3529fe01 ("thermal/drivers/core: Remove the module Kconfig's >> option") changed the type of THERMAL from tristate to bool, so >> THERMA

Re: 5.2-rc1 on droid4: spi crash

2019-05-27 Thread Noralf Trønnes
Den 2019-05-27 07:53, skrev Tony Lindgren: Hi, * Sebastian Reichel [190523 09:33]: Hi, On Thu, May 23, 2019 at 11:09:26AM +0200, Pavel Machek wrote: > This was greeting me overnight... I don't yet know how reproducible it > is, it happened once so far. Please pipe the stacktrace into

Re: [PATCH v3 10/23] drm/qxl: move qxl_primary_apply_cursor to correct place

2019-01-28 Thread Noralf Trønnes
e the > commit message with that. > This is actually my first review of a driver that I'm not familiar with. I'm not quite sure how much in depth understanding that is required to put my ack on it. Going further into the patchset I realised that there's no way that I can verify the logic without being intimate with the driver. So I have tried to verify things from a kms point of view. I liked your expanded explanation better. Noralf. >> Acked-by: Noralf Trønnes > > thanks, > Gerd >

Re: [PATCH v3 17/23] drm/qxl: use generic fbdev emulation

2019-01-28 Thread Noralf Trønnes
Den 28.01.2019 09.59, skrev Gerd Hoffmann: > On Fri, Jan 25, 2019 at 06:25:27PM +0100, Noralf Trønnes wrote: >> >> >> Den 18.01.2019 13.20, skrev Gerd Hoffmann: >>> Switch qxl over to the new generic fbdev emulation. >>> >>> Signed-off-by:

Re: [PATCH v2] drm/qxl: use ttm_tt

2019-01-29 Thread Noralf Trønnes
Den 29.01.2019 09.25, skrev Gerd Hoffmann: > qxl device will not dma, so we don't need ttm_dma_tt. Go use ttm_tt > instead, to avoid wasting resources (swiotlb bounce buffers for > example). > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v2 1/6] drm/virtio: move virtio_gpu_object_{attach, detach} calls.

2019-01-31 Thread Noralf Trønnes
e calls from the > move_notify() callback. > > With that in place the move and move_notify callbacks are not > needed any more, so drop them. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v2 2/6] drm/virtio: use struct to pass params to virtio_gpu_object_create()

2019-01-31 Thread Noralf Trønnes
params = { 0 }; > int ret; > uint32_t pitch; > uint32_t format; > @@ -96,7 +97,9 @@ int virtio_gpu_mode_dumb_create(struct drm_file *file_priv, > args->size = pitch * args->height; > args->size = ALIGN(args->size, PAGE_SIZE)

Re: [PATCH v2 3/6] drm/virtio: params struct for virtio_gpu_cmd_create_resource()

2019-01-31 Thread Noralf Trønnes
Den 30.01.2019 10.43, skrev Gerd Hoffmann: > Add format, width and height fields to the virtio_gpu_object_params > struct. With that in place we can use the parameter struct for > virtio_gpu_cmd_create_resource() calls too. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v2 4/6] drm/virtio: params struct for virtio_gpu_cmd_create_resource_3d()

2019-01-31 Thread Noralf Trønnes
Den 30.01.2019 10.43, skrev Gerd Hoffmann: > Add 3d resource parameters to virtio_gpu_object_params struct. With > that in place we can use it for virtio_gpu_cmd_resource_create_3d() > calls. > > Signed-off-by: Gerd Hoffmann > --- You don't remove the struct virtio_gpu_resource_create_3d

Re: [PATCH v2 5/6] drm/virtio: drop fencing in virtio_gpu_resource_create_ioctl

2019-01-31 Thread Noralf Trønnes
re is no need to wait for completion too. Which > btw is different from resource destroy, where we have to make sure the > host has seen the destroy and thus doesn't use it any more before > releasing the pages backing the resource. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v2 6/6] drm/virtio: move virtio_gpu_cmd_create_resource call into virtio_gpu_object_create

2019-01-31 Thread Noralf Trønnes
With that in place virtio_gpu_object_attach() will never be called with > an object which is not yet created, so the extra > virtio_gpu_object_attach() calls done after > virtio_gpu_cmd_create_resource() is not needed any more. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v3 01/23] drm/qxl: drop ttm_mem_reg arg from qxl_hw_surface_alloc()

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.19, skrev Gerd Hoffmann: > Not used, is always NULL. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v3 02/23] drm/qxl: drop unused qxl_fb_virtual_address

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.19, skrev Gerd Hoffmann: > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v3 03/23] drm/qxl: simplify slot management

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Drop pointless indirection, remove the mem_slots array and index > variables, drop dynamic allocation. Store memslots in qxl_device > instead. > > Signed-off-by: Gerd Hoffmann > --- Looks sane: Acked-by: Noralf Trønnes

Re: [PATCH v3 04/23] drm/qxl: change the way slot is detected

2019-01-25 Thread Noralf Trønnes
ebased, adapted to upstream changes ] > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v3 05/23] drm/qxl: drop unused fields from struct qxl_device

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > slot_id_bits and slot_gen_bits can be read directly from qxlrom instead. > va_slot_mask is never used anywhere. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v3 06/23] drm/qxl: use separate offset spaces for the two slots / ttm memory types.

2019-01-25 Thread Noralf Trønnes
s are rare enough by pure luck. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v3 09/23] drm/qxl: use QXL_GEM_DOMAIN_SURFACE for dumb gem objects

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > dumb buffers are used as qxl surfaces, so allocate them as > QXL_GEM_DOMAIN_SURFACE. Should usually be allocated in > PRIV ttm domain then, so this reduces VRAM memory pressure. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v3 07/23] drm/qxl: allow both PRIV and VRAM placement for QXL_GEM_DOMAIN_SURFACE

2019-01-25 Thread Noralf Trønnes
s which must be allocated there. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v3 08/23] drm/qxl: use QXL_GEM_DOMAIN_SURFACE for shadow bo.

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > The shadow bo is used as qxl surface, so allocate it as > QXL_GEM_DOMAIN_SURFACE. Should usually be allocated in > PRIV ttm domain then, so this reduces VRAM memory pressure. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v3 10/23] drm/qxl: move qxl_primary_apply_cursor to correct place

2019-01-25 Thread Noralf Trønnes
condition, but the condition for applying the cursor is changed from bo_old->is_primary to !bo->is_primary. It probably makes sense to someone that knows the driver. Acked-by: Noralf Trønnes

Re: [PATCH v3 11/23] drm/qxl: drop unused offset parameter from qxl_io_create_primary()

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v3 12/23] drm/qxl: track primary bo

2019-01-25 Thread Noralf Trønnes
_io_create_primary(). > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v3 13/23] drm/qxl: use shadow bo directly

2019-01-25 Thread Noralf Trønnes
pot anything suspicious looking. Acked-by: Noralf Trønnes

Re: [PATCH v3 14/23] drm/qxl: cover all crtcs in shadow bo.

2019-01-25 Thread Noralf Trønnes
user_bo->shadow->surf = user_bo->surf; > + if (user_bo->shadow != qdev->dumb_shadow_bo) { > + if (user_bo->shadow) { > + drm_gem_object_put_unlocked > + (_bo->shadow

Re: [PATCH v3 15/23] drm/qxl: use qxl_num_crtc directly

2019-01-25 Thread Noralf Trønnes
ernel doesn't need to dereference pointers each time it > needs the value, and when reading the code you don't have to trace where > and why qdev->monitors_config->max_allowed is set. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v3 16/23] drm/qxl: implement prime kmap/kunmap

2019-01-25 Thread Noralf Trønnes
is balanced. > > Signed-off-by: Gerd Hoffmann > --- Just a note: You catch the one-to-many kmap type of unbalance, but not the one-too-many kunmap situation. Acked-by: Noralf Trønnes > drivers/gpu/drm/qxl/qxl_drv.h| 1 + > drivers/gpu/drm/qxl/qxl_object.c | 6 ++ > d

Re: [PATCH v3 17/23] drm/qxl: use generic fbdev emulation

2019-01-25 Thread Noralf Trønnes
goto modeset_cleanup; > > + drm_fb_helper_remove_conflicting_pci_framebuffers(pdev, 0, "qxl"); I couldn't find that this was part of old fbdev code, so it would be nice to mention it in the commit message. Acked-by: Noralf Trønnes > + drm_fbdev_generic_setup(>ddev, 32); > return 0; > > modeset_cleanup: >

Re: [PATCH v3 18/23] drm/qxl: remove dead qxl fbdev emulation code

2019-01-25 Thread Noralf Trønnes
--- > drivers/gpu/drm/qxl/Makefile | 2 +- > 4 files changed, 1 insertion(+), 554 deletions(-) > delete mode 100644 drivers/gpu/drm/qxl/qxl_fb.c > Nice! Acked-by: Noralf Trønnes

Re: [PATCH v3 19/23] drm/qxl: implement qxl_gem_prime_(un)pin

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v3 20/23] drm/qxl: add mode/framebuffer check functions

2019-01-25 Thread Noralf Trønnes
are too big will not be added to the mode list in the first place. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v3 21/23] drm/qxl: add qxl_add_mode helper function

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Add a helper function to add custom video modes to a connector. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v3 22/23] drm/qxl: use kernel mode db

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Add all standard modes from the kernel's video mode data base. > Keep a few non-standard modes in the qxl mode list. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v3 18/23] drm/qxl: remove dead qxl fbdev emulation code

2019-01-25 Thread Noralf Trønnes
t; drivers/gpu/drm/qxl/qxl_draw.c | 232 --- >>> drivers/gpu/drm/qxl/qxl_fb.c | 300 >>> - >>> drivers/gpu/drm/qxl/Makefile | 2 +- >>> 4 files changed, 1 insertion(+), 554 deletions(-) >>> delete mode 100644

Re: [Xen-devel][PATCH v2 2/3] drm/xen-front: Use Xen common shared buffer implementation

2018-12-18 Thread Noralf Trønnes
-by: Oleksandr Andrushchenko --- Reviewed-by: Noralf Trønnes

Re: [PATCH] drm/xen-front: Make shmem backed display buffer coherent

2018-12-18 Thread Noralf Trønnes
Den 27.11.2018 11.32, skrev Oleksandr Andrushchenko: From: Oleksandr Andrushchenko When GEM backing storage is allocated with drm_gem_get_pages the backing pages may be cached, thus making it possible that the backend sees only partial content of the buffer which may lead to screen

Re: [PATCH] drm/xen-front: Make shmem backed display buffer coherent

2018-12-19 Thread Noralf Trønnes
Den 19.12.2018 09.18, skrev Oleksandr Andrushchenko: On 12/18/18 9:20 PM, Noralf Trønnes wrote: Den 27.11.2018 11.32, skrev Oleksandr Andrushchenko: From: Oleksandr Andrushchenko When GEM backing storage is allocated with drm_gem_get_pages the backing pages may be cached, thus making

Re: [PATCH v1 5/5] tinydrm: add winstar wg160160 driver

2018-08-08 Thread Noralf Trønnes
Den 08.08.2018 10.32, skrev Sam Ravnborg: Hi Noralf. On Tue, Aug 07, 2018 at 07:35:30PM +0200, Noralf Trønnes wrote: Den 02.08.2018 21.45, skrev Sam Ravnborg: Add driver for the winstar wg160160 display. The driver utilises pardata-dbi that again utilise the pardata subsystem. Signed-off

Re: [drm/i915/fbdev] 09ded8af57: dmesg.RIP:drm_setup_crtcs[drm_kms_helper]

2019-04-28 Thread Noralf Trønnes
Den 28.04.2019 11.51, skrev kernel test robot: > FYI, we noticed the following commit (built with gcc-7): > > commit: 09ded8af57bcef7287b8242087d3e7556380de62 ("drm/i915/fbdev: Move > intel_fb_initial_config() to fbdev helper") >

Re: [PATCH v3 2/5] drm/virtio: use struct to pass params to virtio_gpu_object_create()

2019-03-27 Thread Noralf Trønnes
M_PL_FLAG_NO_EVICT so ttm knows. Doesn't change much for the moment > as virtio-gpu supports TTM_PL_FLAG_TT only so there is no opportunity to > move around objects. That'll probably change in the future though. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v3 5/5] drm/virtio: rework resource creation workflow.

2019-03-27 Thread Noralf Trønnes
then initialize the > ttm object, and finally attach just created object to the fence for the > command in case it didn't finish yet. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH 2/3] drm/virtio: implement prime pin/unpin

2019-02-27 Thread Noralf Trønnes
; void virtgpu_gem_prime_unpin(struct drm_gem_object *obj) > { > - WARN_ONCE(1, "not implemented"); > + /* nothing */ > } You can just remove these dummies the callbacks are optional. See drm_gem_pin(). With that: Reviewed-by: Noralf Trønnes > > void *virtgpu_gem_prime_vmap(struct drm_gem_object *obj) >

Re: [PATCH 1/3] drm/virtio: implement prime mmap

2019-02-27 Thread Noralf Trønnes
Den 27.02.2019 15.44, skrev Gerd Hoffmann: > Sync gem vm_node.start with ttm vm_node.start, > then we can just call drm_gem_prime_mmap(). > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH 3/3] drm/virtio: implement prime export

2019-02-27 Thread Noralf Trønnes
nevertheless. > > Signed-off-by: Gerd Hoffmann Acked-by: Noralf Trønnes

<    1   2   3   4   5   6   7   8   9   >