Re: HVMLite / PVHv2 - using x86 EFI boot entry

2016-04-13 Thread Roger Pau Monné
On Tue, Apr 12, 2016 at 02:02:52PM -0700, Andy Lutomirski wrote: > On Sun, Apr 10, 2016 at 10:12 PM, Juergen Gross wrote: > > On 08/04/16 22:40, Luis R. Rodriguez wrote: > >> On Wed, Apr 06, 2016 at 10:40:08AM +0100, David Vrabel wrote: > >>> On 06/04/16 03:40, Luis R. Rodriguez wrote: > > >>

Re: [Xen-devel] HVMLite / PVHv2 - using x86 EFI boot entry

2016-04-13 Thread Roger Pau Monné
On Fri, Apr 08, 2016 at 11:58:54PM +0200, Luis R. Rodriguez wrote: > On Fri, Apr 08, 2016 at 03:16:14PM +0100, George Dunlap wrote: > > On 07/04/16 19:51, Luis R. Rodriguez wrote: > > > While Andrew's position is right in that perhaps only Xen tools have to > > > deal > > > with the HVMLite specif

Re: [Xen-devel] HVMLite / PVHv2 - using x86 EFI boot entry

2016-04-13 Thread Roger Pau Monné
On Wed, Apr 06, 2016 at 04:02:40PM +0100, Matt Fleming wrote: [...] > One place that struck me as suitable for this "hypercall in an EFI > service stub" approach is the trouble with doing ACPI reboot as > documented here, > > http://lists.xen.org/archives/html/xen-devel/2016-02/msg01609.html >

Re: [Xen-devel] HVMLite / PVHv2 - using x86 EFI boot entry

2016-04-13 Thread Roger Pau Monné
On Wed, Apr 13, 2016 at 12:12:25AM +0200, Luis R. Rodriguez wrote: [...] > Also, x86 does have a history of short DT use. Just pointing that its there as > an option as well. I'll Cc you on some thread about that. I don't see how this is relevant to the conversation that's going on: How many x86

Re: HVMLite / PVHv2 - using x86 EFI boot entry

2016-04-13 Thread Roger Pau Monné
On Wed, Apr 13, 2016 at 11:15:15AM +0100, Matt Fleming wrote: > On Wed, 13 Apr, at 11:02:02AM, Roger Pau Monné wrote: > > > > With my FreeBSD committer hat: > > > > The FreeBSD kernel doesn't contain an EFI entry point, it just contains one > > single e

Re: [PATCH v4 00/20] xen/arm64: Add support for 64KB page in Linux

2015-09-14 Thread Roger Pau Monné
El 14/09/15 a les 13.21, Julien Grall ha escrit: > On 14/09/15 12:04, Roger Pau Monné wrote: >> Hello, >> >> El 14/09/15 a les 12.40, Julien Grall ha escrit: >>> Hi Roger, >>> >>> On 14/09/15 09:56, Roger Pau Monné wrote: >>>> E

Re: [PATCH v4 00/20] xen/arm64: Add support for 64KB page in Linux

2015-09-14 Thread Roger Pau Monné
Hello, El 14/09/15 a les 14.47, Julien Grall ha escrit: > On 14/09/15 13:08, Roger Pau Monné wrote: >>> I'd like to see a basic support of 64KB page granularity upstream before >>> starting to think about performance improvement. And there is still a >>>

Re: [PATCH v4 00/20] xen/arm64: Add support for 64KB page in Linux

2015-09-14 Thread Roger Pau Monné
El 14/09/15 a les 16.54, Stefano Stabellini ha escrit: > On Mon, 14 Sep 2015, Roger Pau Monné wrote: >> IMHO this splitting is just a workaround for the fact that we don't have >> a 64KB PV block protocol, and this is the real problem that should be >> solved. > >

Re: [Xen-devel] xen/evtchn and forced threaded irq

2019-02-21 Thread Roger Pau Monné
On Wed, Feb 20, 2019 at 10:03:57PM +, Julien Grall wrote: > Hi Boris, > > On 2/20/19 9:46 PM, Boris Ostrovsky wrote: > > On 2/20/19 3:46 PM, Julien Grall wrote: > > > (+ Andrew and Jan for feedback on the event channel interrupt) > > > > > > Hi Boris, > > > > > > Thank you for the your feedb

Re: [Xen-devel] xen/evtchn and forced threaded irq

2019-02-21 Thread Roger Pau Monné
On Thu, Feb 21, 2019 at 08:38:39AM +, Julien Grall wrote: > Hi Roger, > > On Thu, 21 Feb 2019, 08:08 Roger Pau Monné, wrote: > > > FWIW, you can also mask the interrupt while waiting for the thread to > > execute the interrupt handler. Ie: > > > > Th

Re: [PATCH 1/1] xen-blkback: do not wake up shutdown_wq after xen_blkif_schedule() is stopped

2019-01-16 Thread Roger Pau Monné
On Wed, Jan 16, 2019 at 09:47:41PM +0800, Dongli Zhang wrote: > There is no need to wake up xen_blkif_schedule() as kthread_stop() is able > to already wake up the kernel thread. > > Signed-off-by: Dongli Zhang Reviewed-by: Roger Pau Monné kthread_stop waits for the thread to exit

Re: [PATCH 1/1] xen-blkback: do not wake up shutdown_wq after xen_blkif_schedule() is stopped

2019-01-16 Thread Roger Pau Monné
On Wed, Jan 16, 2019 at 09:47:41PM +0800, Dongli Zhang wrote: > There is no need to wake up xen_blkif_schedule() as kthread_stop() is able > to already wake up the kernel thread. > > Signed-off-by: Dongli Zhang > --- > drivers/block/xen-blkback/xenbus.c | 4 +--- > 1 file changed, 1 insertion(+)

Re: [Xen-devel] [PATCH 1/1] xen-blkback: do not wake up shutdown_wq after xen_blkif_schedule() is stopped

2019-01-17 Thread Roger Pau Monné
On Thu, Jan 17, 2019 at 10:10:00AM +0800, Dongli Zhang wrote: > Hi Roger, > > On 2019/1/16 下午10:52, Roger Pau Monné wrote: > > On Wed, Jan 16, 2019 at 09:47:41PM +0800, Dongli Zhang wrote: > >> There is no need to wake up xen_blkif_schedule() as kthread_stop() is able >

Re: [Xen-devel] [PATCH v6 2/2] xen/blkback: rework connect_ring() to avoid inconsistent xenstore 'ring-page-order' set by malicious blkfront

2019-01-15 Thread Roger Pau Monné
_pages));" in > xen_blkif_disconnect() when frontend is destroyed. > > This patch reworks connect_ring() to read xenstore 'ring-page-order' only > once. > > Signed-off-by: Dongli Zhang LGTM: Reviewed-by: Roger Pau Monné Thanks!

Re: [Xen-devel] [PATCH v4 2/2] xen/blkback: rework connect_ring() to avoid inconsistent xenstore 'ring-page-order' set by malicious blkfront

2019-01-11 Thread Roger Pau Monné
On Tue, Jan 8, 2019 at 10:53 AM Dongli Zhang wrote: > > Hi Roger, > > On 01/07/2019 11:27 PM, Roger Pau Monné wrote: > > On Mon, Jan 07, 2019 at 10:07:34PM +0800, Dongli Zhang wrote: > >> > >> > >> On 01/07/2019 10:05 PM, Dongli Zhang wrote: > &

Re: [Xen-devel] [PATCH] drivers/block/xen-blkback/common.h: use DIV_ROUND_UP instead of reimplementing its function

2018-09-12 Thread Roger Pau Monné
Adding Julien how did the work to support XEN_PAGE_SIZE != PAGE_SIZE. On Wed, Sep 12, 2018 at 02:14:26AM -0600, Jan Beulich wrote: > >>> On 12.09.18 at 07:45, wrote: > > --- a/drivers/block/xen-blkback/common.h > > +++ b/drivers/block/xen-blkback/common.h > > @@ -65,7 +65,7 @@ > > (XEN_PAGES_

[PATCH 0/3] xen/pvh: Dom0 support

2018-05-03 Thread Roger Pau Monne
aging should be used. Compile a Linux kernel with this patches and PVH support and add dom0=pvh to the Xen command line. The following message will be displayed during boot by the Linux kernel if PVH mode is used: "Booting paravirtualized kernel on Xen PVH" Thanks, Roger. Roger Pau Monne

[PATCH 1/3] xen/pvh: enable and set default MTRR type

2018-05-03 Thread Roger Pau Monne
s, so Xen was using WB as the default memory type instead of UC. Fix this by enabling MTRR and setting the default type to WB. Linux will use PAT to set the actual memory cache attributes. Signed-off-by: Boris Ostrovsky Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen Gros

[PATCH 3/3] xen: share start flags between PV and PVH

2018-05-03 Thread Roger Pau Monne
Use a global variable to store the start flags for both PV and PVH. This allows the xen_initial_domain macro to work properly on PVH. Signed-off-by: Boris Ostrovsky Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: xen-de...@lists.xenproject.org --- arch/x86/xen

[PATCH 2/3] xen/store: do not store local values in xen_start_info

2018-05-03 Thread Roger Pau Monne
There's no need to store the xenstore page or event channel in xen_start_info if they are locally initialized. This also fixes PVH local xenstore initialization due to the lack of xen_start_info in that case. Signed-off-by: Boris Ostrovsky Signed-off-by: Roger Pau Monné --- Cc: Boris Ostr

[PATCH v2 3/3] xen: share start flags between PV and PVH

2018-05-09 Thread Roger Pau Monne
Use a global variable to store the start flags for both PV and PVH. This allows the xen_initial_domain macro to work properly on PVH. Note that ARM is also switched to use the new variable. Signed-off-by: Boris Ostrovsky Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen Gross

[PATCH v2 2/3] xen/store: do not store local values in xen_start_info

2018-05-09 Thread Roger Pau Monne
There's no need to store the xenstore page or event channel in xen_start_info if they are locally initialized. This also fixes PVH local xenstore initialization due to the lack of xen_start_info in that case. Signed-off-by: Boris Ostrovsky Signed-off-by: Roger Pau Monné --- Cc: Boris Ostr

[PATCH v2 0/3] xen/pvh: Dom0 support

2018-05-09 Thread Roger Pau Monne
aging should be used. Compile a Linux kernel with this patches and PVH support and add dom0=pvh to the Xen command line. The following message will be displayed during Dom0 boot by the Linux kernel if PVH mode is used: "Booting paravirtualized kernel on Xen PVH" Thanks, Roger. Roger Pau Monne

[PATCH v2 1/3] xen/pvh: enable and set default MTRR type

2018-05-09 Thread Roger Pau Monne
s, so Xen was using WB as the default memory type instead of UC. Fix this by enabling MTRR and setting the default type to WB. Linux will use PAT to set the actual memory cache attributes. Signed-off-by: Boris Ostrovsky Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen Gros

Re: [Xen-devel] [PATCH v2 1/3] xen/pvh: enable and set default MTRR type

2018-05-09 Thread Roger Pau Monné
On Wed, May 09, 2018 at 11:56:40AM +0100, Andrew Cooper wrote: > On 09/05/18 11:21, Roger Pau Monne wrote: > > On PVH MTRR is not initialized by the firmware (because there's no > > firmware), so the kernel is started with MTRR disabled which means all > > memory acces

Re: [Xen-devel] [PATCH v2 1/3] xen/pvh: enable and set default MTRR type

2018-05-09 Thread Roger Pau Monné
On Wed, May 09, 2018 at 12:30:16PM +0100, Roger Pau Monné wrote: > On Wed, May 09, 2018 at 11:56:40AM +0100, Andrew Cooper wrote: > > On 09/05/18 11:21, Roger Pau Monne wrote: > > I'm not sure that setting the default MTRR type is going to be a > > clever idea in hinds

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-18 Thread Roger Pau Monné
On Wed, Apr 18, 2018 at 09:38:39AM +0300, Oleksandr Andrushchenko wrote: > On 04/17/2018 11:57 PM, Dongwon Kim wrote: > > On Tue, Apr 17, 2018 at 09:59:28AM +0200, Daniel Vetter wrote: > > > On Mon, Apr 16, 2018 at 12:29:05PM -0700, Dongwon Kim wrote: > 3.2 Backend exports dma-buf to xen-front > >

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-18 Thread Roger Pau Monné
On Wed, Apr 18, 2018 at 11:01:12AM +0300, Oleksandr Andrushchenko wrote: > On 04/18/2018 10:35 AM, Roger Pau Monné wrote: > > On Wed, Apr 18, 2018 at 09:38:39AM +0300, Oleksandr Andrushchenko wrote: > > > On 04/17/2018 11:57 PM, Dongwon Kim wrote: > > > > On Tue, Ap

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-18 Thread Roger Pau Monné
On Wed, Apr 18, 2018 at 01:39:35PM +0300, Oleksandr Andrushchenko wrote: > On 04/18/2018 01:18 PM, Paul Durrant wrote: > > > -Original Message- > > > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > > > Of Roger Pau Monné > >

Re: [PATCH 2/3] xen: modify xenstore watch event interface

2017-01-06 Thread Roger Pau Monné
rad.w...@oracle.com > Cc: roger@citrix.com > Cc: wei.l...@citrix.com > Cc: paul.durr...@citrix.com > Cc: net...@vger.kernel.org > > Signed-off-by: Juergen Gross blkback changes: Reviewed-by: Roger Pau Monné Thanks, Roger.

Re: [PATCH] xen-blkback: really don't leak mode property

2016-07-07 Thread Roger Pau Monne
On Thu, Jul 07, 2016 at 01:38:13AM -0600, Jan Beulich wrote: > Commit 9d092603cc ("xen-blkback: do not leak mode property") left one > path unfixed; correct this. > > Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné

Re: [PATCH] xen-blkfront: avoid NULL de-reference in CDROM ioctl handling

2016-07-07 Thread Roger Pau Monne
On Thu, Jul 07, 2016 at 01:40:54AM -0600, Jan Beulich wrote: > The ioctl can be called prior to full device setup having completed. > > Signed-off-by: Jan Beulich > --- > drivers/block/xen-blkfront.c |6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > --- 4.7-rc6-xen.orig/drive

Re: [PATCH] xen-blkback: prefer xenbus_scanf() over xenbus_gather()

2016-07-07 Thread Roger Pau Monne
Acked-by: Roger Pau Monné

Re: [PATCH] xen-blkfront: prefer xenbus_scanf() over xenbus_gather()

2016-07-07 Thread Roger Pau Monne
Acked-by: Roger Pau Monné > --- > drivers/block/xen-blkfront.c | 43 > +++ > 1 file changed, 19 insertions(+), 24 deletions(-) > > --- 4.7-rc6-prefer-xenbus_scanf.orig/drivers/block/xen-blkfront.c > +++ 4.7-rc6-prefer-xenbu

Re: [PATCH] xen-blkback: prefer xenbus_write() over xenbus_printf() where possible

2016-07-07 Thread Roger Pau Monne
On Thu, Jul 07, 2016 at 02:06:12AM -0600, Jan Beulich wrote: > ... as being the simpler variant. > > Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné

Re: [PATCH] xen-blkfront: prefer xenbus_write() over xenbus_printf() where possible

2016-07-07 Thread Roger Pau Monne
On Thu, Jul 07, 2016 at 02:06:33AM -0600, Jan Beulich wrote: > ... as being the simpler variant. > > Signed-off-by: Jan Beulich > --- > drivers/block/xen-blkfront.c |7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > --- 4.7-rc6-prefer-xenbus_write.orig/drivers/block/xen-blkfr

Re: [PATCH] xen-blkback: constify instance of "struct attribute_group"

2016-07-07 Thread Roger Pau Monne
On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote: > The functions such get passed to have been taking pointers to const > since at least 2.6.16. > > Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné Although the wording in the commit message looks weird to me, b

Re: [PATCH] xen-blkfront: avoid NULL de-reference in CDROM ioctl handling

2016-07-07 Thread Roger Pau Monne
On Thu, Jul 07, 2016 at 03:42:02AM -0600, Jan Beulich wrote: > >>> On 07.07.16 at 11:32, wrote: > > On Thu, Jul 07, 2016 at 01:40:54AM -0600, Jan Beulich wrote: > >> The ioctl can be called prior to full device setup having completed. > >> > >> Signed-off-by: Jan Beulich > >> --- > >> drivers/b

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Roger Pau Monné
On Sat, Jul 23, 2016 at 06:18:23AM +0800, Bob Liu wrote: > > On 07/22/2016 07:45 PM, Roger Pau Monné wrote: > > On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: > >> > >> On 07/22/2016 05:34 PM, Roger Pau Monné wrote: > >>> On Fri, Jul 2

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Roger Pau Monné
On Mon, Jul 25, 2016 at 06:29:22PM +0800, Bob Liu wrote: > > On 07/25/2016 05:20 PM, Roger Pau Monné wrote: > > On Sat, Jul 23, 2016 at 06:18:23AM +0800, Bob Liu wrote: > >> > >> On 07/22/2016 07:45 PM, Roger Pau Monné wrote: > >>> On Fri, Jul 2

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Roger Pau Monné
On Mon, Jul 25, 2016 at 07:08:36PM +0800, Bob Liu wrote: > > On 07/25/2016 06:53 PM, Roger Pau Monné wrote: > ..[snip..] > >>>> * We get the device lock and blk_mq_freeze_queue() in > >>>> dynamic_reconfig_device(), > >>>>and then h

Re: [PATCH v2 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-26 Thread Roger Pau Monné
On Tue, Jul 26, 2016 at 01:19:37PM +0800, Bob Liu wrote: > The current VBD layer reserves buffer space for each attached device based on > three statically configured settings which are read at boot time. > * max_indirect_segs: Maximum amount of segments. > * max_ring_page_order: Maximum order of

Re: [PATCH v2 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-26 Thread Roger Pau Monné
On Tue, Jul 26, 2016 at 04:58:10PM +0800, Bob Liu wrote: > > On 07/26/2016 04:44 PM, Roger Pau Monné wrote: > > On Tue, Jul 26, 2016 at 01:19:37PM +0800, Bob Liu wrote: > >> The current VBD layer reserves buffer space for each attached device based > >> on &g

Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-27 Thread Roger Pau Monné
Hello, Thanks for the fixes. On Wed, Jul 27, 2016 at 11:21:25AM +0800, Bob Liu wrote: > The current VBD layer reserves buffer space for each attached device based on > three statically configured settings which are read at boot time. > * max_indirect_segs: Maximum amount of segments. > * max_ri

Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-27 Thread Roger Pau Monné
On Wed, Jul 27, 2016 at 05:12:22PM +0800, Bob Liu wrote: > > On 07/27/2016 04:07 PM, Roger Pau Monné wrote: > ..[snip].. > >> @@ -2443,6 +2674,22 @@ static void blkfront_connect(struct blkfront_info > >> *info) > >>return; > >>}

Re: [PATCH v2 2/3] xen-blkfront: introduce blkif_set_queue_limits()

2016-07-27 Thread Roger Pau Monné
On Tue, Jul 26, 2016 at 01:19:36PM +0800, Bob Liu wrote: > blk_mq_update_nr_hw_queues() reset all queue limits to default which it's not > as xen-blkfront expected, introducing blkif_set_queue_limits() to reset limits > with initial correct values. > > Signed-off-by: Bob Liu

Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-27 Thread Roger Pau Monné
On Wed, Jul 27, 2016 at 11:21:25AM +0800, Bob Liu wrote: [...] > +static ssize_t dynamic_reconfig_device(struct blkfront_info *info, ssize_t > count) > +{ > + /* > + * Prevent new requests even to software request queue. > + */ > + blk_mq_freeze_queue(info->rq); > + > + /* >

Re: [PATCH] xen/blkback: use rb_entry()

2016-12-20 Thread Roger Pau Monné
On Tue, Dec 20, 2016 at 11:47:03AM -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 20, 2016 at 10:02:19PM +0800, Geliang Tang wrote: > > To make the code clearer, use rb_entry() instead of container_of() to > > deal with rbtree. > > That is OK but I think 'container_of' is more clear. > > Roger

Re: [PATCH 5/8] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

2016-10-26 Thread Roger Pau Monné
On Fri, Oct 14, 2016 at 02:05:15PM -0400, Boris Ostrovsky wrote: > Make sure they don't use these devices since they are not emulated > for unprivileged PVH guest. > > Also don't initialize hypercall page for them in init_hvm_pv_info() > since this has already been done. > > Signed-off-by: Boris

Re: [PATCH 5/8] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

2016-10-26 Thread Roger Pau Monné
On Wed, Oct 26, 2016 at 10:50:21AM -0400, Boris Ostrovsky wrote: > On 10/26/2016 06:42 AM, Roger Pau Monné wrote: > > On Fri, Oct 14, 2016 at 02:05:15PM -0400, Boris Ostrovsky wrote: > >> Make sure they don't use these devices since they are not emulated > >

Re: [Xen-devel] [PATCH 0/7] Xen transport for 9pfs frontend driver

2017-03-07 Thread Roger Pau Monné
On Mon, Mar 06, 2017 at 12:00:41PM -0800, Stefano Stabellini wrote: > Hi all, > > This patch series implements a new transport for 9pfs, aimed at Xen > systems. > > The transport is based on a traditional Xen frontend and backend drivers > pair. This patch series implements the frontend, which ty

Re: [Xen-devel] [PATCH 0/7] Xen transport for 9pfs frontend driver

2017-03-08 Thread Roger Pau Monné
On Tue, Mar 07, 2017 at 10:27:05AM -0800, Stefano Stabellini wrote: > On Tue, 7 Mar 2017, Roger Pau Monné wrote: > > On Mon, Mar 06, 2017 at 12:00:41PM -0800, Stefano Stabellini wrote: > > > Hi all, > > > > > > This patch series implements a new transport

Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51

2017-02-21 Thread Pau Espin Pedrol
10, 2017 at 7:48 PM, Pau Espin Pedrol > wrote: >> Otherwise those are printed several times when (un)plugging the AC >> connector. > > If we have a user space tool that supports them better not to ignore. > > -- > With Best Regards, > Andy Shevchenko > >

Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51

2017-02-24 Thread Pau Espin Pedrol
>> Dmitry, do we have special events for AC (un)plug? What is the best >> approach in your opinion? > > Not route them through input as they not input events would be the best. > Is my patch good enough for this or would you recommend doing it another way? > I'd look into hooking up power_supply c

[PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51

2017-02-10 Thread Pau Espin Pedrol
Otherwise those are printed several times when (un)plugging the AC connector. Signed-off-by: Pau Espin Pedrol --- drivers/platform/x86/eeepc-laptop.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c index

Re: [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

2017-02-02 Thread Roger Pau Monné
On Thu, Jan 26, 2017 at 02:41:28PM -0500, Boris Ostrovsky wrote: > Make sure they don't use these devices since they are not emulated > for unprivileged PVH guest. This description seems weird for what it's actually done. AFAICT you are not really preventing the guest from using the PIC or the IO

Re: [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

2017-02-02 Thread Roger Pau Monné
On Thu, Feb 02, 2017 at 11:30:19AM -0500, Boris Ostrovsky wrote: > On 02/02/2017 10:35 AM, Roger Pau Monné wrote: > > On Thu, Jan 26, 2017 at 02:41:28PM -0500, Boris Ostrovsky wrote: > >> Make sure they don't use these devices since they are not emulated > >> for

Re: [PATCH 0096/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Roger Pau Monné
onding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni Acked-by: Roger Pau Monné

Re: [PATCH] xen/blback: Fit the important information of the thread in 17 characters

2016-02-19 Thread Roger Pau Monné
n dropping the "blback" part. > > This will make it possible to have the .-: > > [1.xvda-0] > [1.xvda-1] > > And we enough space to make it go up to: > > [32100.xvdfg9-5] > > Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Roger Pau Monné According to: http://lists.xenproject.org/archives/html/xen-devel/2015-05/msg03505.html Should this have a: Reported-by: Jan Beulich Thanks!

Re: [PATCH v1 06/12] xen/hvmlite: Initialize PCI

2016-01-25 Thread Roger Pau Monné
El 22/01/16 a les 22.35, Boris Ostrovsky ha escrit: > HVMlite guests need PCI frontend and always have PV devices We still haven't discussed how to perform pci-passthrough for HVMlite guests. I admit there's a big chance that we are going to use the PV pcifront driver but there's no guarantee abou

Re: [Xen-devel] [PATCH v1 04/12] xen/hvmlite: Bootstrap HVMlite guest

2016-01-25 Thread Roger Pau Monné
El 23/01/16 a les 17.12, Konrad Rzeszutek Wilk ha escrit: > On January 23, 2016 11:01:06 AM EST, "H. Peter Anvin" wrote: >> On January 23, 2016 7:34:33 AM PST, Konrad Rzeszutek Wilk >> wrote: >>> However, this stub belongs in Linux, not in the Xen toolstack. That way, when the Linux bo

Re: [Xen-devel] [PATCH v2 08/11] xen/hvmlite: Extend APIC operations for HVMlite guests

2016-02-04 Thread Roger Pau Monné
El 4/2/16 a les 11:04, David Vrabel ha escrit: > On 01/02/16 15:38, Boris Ostrovsky wrote: >> HVMlite guests need to be viewed as having APIC, otherwise smpboot code, >> for example, will complain. > > I think we should consider always giving HVMlite guests an emulated > APIC. I think this elimin

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation]

2020-06-30 Thread Roger Pau Monné
On Mon, Jun 29, 2020 at 07:20:35PM +, Anchal Agarwal wrote: > On Fri, Jun 26, 2020 at 11:12:39AM +0200, Roger Pau Monné wrote: > > So the frontend should do: > > > > - Switch to Closed state (and cleanup everything required). > > - Wait for backend to switch to

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation]

2020-06-26 Thread Roger Pau Monné
On Thu, Jun 25, 2020 at 06:36:59PM +, Anchal Agarwal wrote: > On Tue, Jun 23, 2020 at 10:19:03AM +0200, Roger Pau Monné wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender an

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation]

2020-06-23 Thread Roger Pau Monné
On Tue, Jun 23, 2020 at 12:43:14AM +, Anchal Agarwal wrote: > On Mon, Jun 22, 2020 at 10:38:46AM +0200, Roger Pau Monné wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender an

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2020-05-28 Thread Roger Pau Monné
On Tue, May 19, 2020 at 11:27:50PM +, Anchal Agarwal wrote: > From: Munehisa Kamata > > S4 power transition states are much different than xen > suspend/resume. Former is visible to the guest and frontend drivers should > be aware of the state transitions and should be able to take appropriat

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation]

2020-06-04 Thread Roger Pau Monné
Hello, On Wed, Jun 03, 2020 at 11:33:52PM +, Agarwal, Anchal wrote: > CAUTION: This email originated from outside of the organization. Do not > click links or open attachments unless you can confirm the sender and know > the content is safe. > > > > On Tue, May 19, 2020 at 11:27:50PM

Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

2020-09-03 Thread Roger Pau Monné
On Thu, Sep 03, 2020 at 05:30:07PM +0200, Jürgen Groß wrote: > On 01.09.20 10:33, Roger Pau Monne wrote: > > To be used in order to create foreign mappings. This is based on the > > ZONE_DEVICE facility which is used by persistent memory devices in > > order to create st

Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

2020-09-04 Thread Roger Pau Monné
On Fri, Sep 04, 2020 at 09:00:18AM +0200, Jürgen Groß wrote: > On 03.09.20 18:38, Roger Pau Monné wrote: > > On Thu, Sep 03, 2020 at 05:30:07PM +0200, Jürgen Groß wrote: > > > On 01.09.20 10:33, Roger Pau Monne wrote: > > > > To be used in order to create foreign

Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

2020-09-01 Thread Roger Pau Monné
On Tue, Sep 01, 2020 at 10:33:26AM +0200, Roger Pau Monne wrote: > +static int fill_list(unsigned int nr_pages) > +{ > + struct dev_pagemap *pgmap; > + void *vaddr; > + unsigned int i, alloc_pages = round_up(nr_pages, PAGES_PER_SECTION); > + int nid, ret;

Re: [PATCH] efi: discover ESRT table on Xen PV too

2020-08-17 Thread Roger Pau Monné
On Sun, Aug 16, 2020 at 02:19:49AM +0200, Marek Marczykowski-Górecki wrote: > In case of Xen PV dom0, Xen passes along info about system tables (see > arch/x86/xen/efi.c), but not the memory map from EFI. I think that's because the memory map returned by XENMEM_machine_memory_map is in e820 form,

Re: [PATCH v4 1/2] memremap: rename MEMORY_DEVICE_DEVDAX to MEMORY_DEVICE_GENERIC

2020-08-31 Thread Roger Pau Monné
On Thu, Aug 20, 2020 at 01:37:41PM +0200, Roger Pau Monné wrote: > On Tue, Aug 11, 2020 at 11:07:36PM +0200, David Hildenbrand wrote: > > On 11.08.20 11:44, Roger Pau Monne wrote: > > > This is in preparation for the logic behind MEMORY_DEVICE_DEVDAX also > > > be

[PATCH v5 1/3] xen/balloon: add header guard

2020-09-01 Thread Roger Pau Monne
In order to protect against the header being included multiple times on the same compilation unit. Signed-off-by: Roger Pau Monné Reviewed-by: Boris Ostrovsky --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-de...@lists.xenproject.org --- This is required as a pre

[PATCH v5 0/3] xen/balloon: fixes for memory hotplug

2020-09-01 Thread Roger Pau Monne
due to Arm using an identity map for dom0 p2m and thus needing special handling. Thanks, Roger. Roger Pau Monne (3): xen/balloon: add header guard memremap: rename MEMORY_DEVICE_DEVDAX to MEMORY_DEVICE_GENERIC xen: add helpers to allocate unpopulated memory drivers/dax/device.c

[PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

2020-09-01 Thread Roger Pau Monne
on some platforms. Signed-off-by: Roger Pau Monné --- Cc: Oleksandr Andrushchenko Cc: David Airlie Cc: Daniel Vetter Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Dan Carpenter Cc: Roger Pau Monne Cc: Wei Liu Cc: Yan Yankovskyi Cc: dri-de...@lists.freedesktop.org Cc

[PATCH v5 2/3] memremap: rename MEMORY_DEVICE_DEVDAX to MEMORY_DEVICE_GENERIC

2020-09-01 Thread Roger Pau Monne
This is in preparation for the logic behind MEMORY_DEVICE_DEVDAX also being used by non DAX devices. No functional change intended. Signed-off-by: Roger Pau Monné Reviewed-by: Ira Weiny Acked-by: Andrew Morton --- Cc: Dan Williams Cc: Vishal Verma Cc: Dave Jiang Cc: Andrew Morton Cc

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-13 Thread Roger Pau Monné
On Thu, Aug 13, 2020 at 08:33:37AM +0100, Christoph Hellwig wrote: > On Tue, Aug 11, 2020 at 11:44:47AM +0200, Roger Pau Monne wrote: > > If enabled (because ZONE_DEVICE is supported) the usage of the new > > functionality untangles Xen balloon and RAM hotplug from the usage of

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-13 Thread Roger Pau Monné
t 11:49:46AM +0200, Daniel Vetter wrote: > On Thu, Aug 13, 2020 at 09:54:20AM +0200, Roger Pau Monné wrote: > > On Thu, Aug 13, 2020 at 08:33:37AM +0100, Christoph Hellwig wrote: > > > On Tue, Aug 11, 2020 at 11:44:47AM +0200, Roger Pau Monne wrote: > > > > If enabled (b

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-14 Thread Roger Pau Monné
On Fri, Aug 14, 2020 at 08:29:20AM +0100, Christoph Hellwig wrote: > On Thu, Aug 13, 2020 at 09:54:20AM +0200, Roger Pau Monn?? wrote: > > On Thu, Aug 13, 2020 at 08:33:37AM +0100, Christoph Hellwig wrote: > > > On Tue, Aug 11, 2020 at 11:44:47AM +0200, Roger Pau Monne wrote:

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-14 Thread Roger Pau Monné
On Fri, Aug 14, 2020 at 12:27:32PM +0200, Jürgen Groß wrote: > On 14.08.20 11:56, Roger Pau Monné wrote: > > On Fri, Aug 14, 2020 at 08:29:20AM +0100, Christoph Hellwig wrote: > > > On Thu, Aug 13, 2020 at 09:54:20AM +0200, Roger Pau Monn?? wrote: > > > > On Thu, Au

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-14 Thread Roger Pau Monné
On Fri, Aug 14, 2020 at 02:54:38PM +0200, Jürgen Groß wrote: > On 14.08.20 14:47, Roger Pau Monné wrote: > > On Fri, Aug 14, 2020 at 12:27:32PM +0200, Jürgen Groß wrote: > > > On 14.08.20 11:56, Roger Pau Monné wrote: > > > > On Fri, Aug 14, 2020 at 08:29:20AM

[PATCH 0/2] xen/blkback: add LRU purge parameters

2020-10-15 Thread Roger Pau Monne
Add the LRU parameters as tunables. Roger Pau Monne (2): xen/blkback: turn the cache purge LRU interval into a parameter xen/blkback: turn the cache purge percent into a parameter .../ABI/testing/sysfs-driver-xen-blkback | 19 +++ drivers/block/xen-blkback/blkback.c

[PATCH 1/2] xen/blkback: turn the cache purge LRU interval into a parameter

2020-10-15 Thread Roger Pau Monne
Assume that reads and writes to the variable will be atomic. The worse that could happen is that one of the LRU intervals is not calculated properly if a partially written value is read, but that would only be a transient issue. Signed-off-by: Roger Pau Monné --- Cc: Konrad Rzeszutek Wilk Cc

[PATCH 2/2] xen/blkback: turn the cache purge percent into a parameter

2020-10-15 Thread Roger Pau Monne
Assume that reads and writes to the variable will be atomic. The worse that could happen is that one of the purges removes a partially written percentage of grants, but the cache itself will recover. Signed-off-by: Roger Pau Monné --- Cc: Konrad Rzeszutek Wilk Cc: Jens Axboe Cc: Boris

Re: [PATCH 2/2] xen/blkback: turn the cache purge percent into a parameter

2020-10-15 Thread Roger Pau Monné
On Thu, Oct 15, 2020 at 04:37:52PM +0200, Jürgen Groß wrote: > On 15.10.20 16:24, Roger Pau Monne wrote: > > Assume that reads and writes to the variable will be atomic. The worse > > that could happen is that one of the purges removes a partially > > written percentage of

Re: [PATCH 1/2] xen: Remove Xen PVH/PVHVM dependency on PCI

2020-10-15 Thread Roger Pau Monné
On Thu, Oct 15, 2020 at 05:02:21PM +0200, Jan Beulich wrote: > On 15.10.2020 16:59, Jason Andryuk wrote: > > On Thu, Oct 15, 2020 at 4:10 AM Jan Beulich wrote: > >> > >> On 14.10.2020 19:53, Jason Andryuk wrote: > >>> @@ -76,7 +80,9 @@ config XEN_DEBUG_FS > >>> Enabling this option may inc

Re: [PATCH v2 4/4] xen: add helpers to allocate unpopulated memory

2020-07-27 Thread Roger Pau Monné
On Fri, Jul 24, 2020 at 12:36:33PM -0400, Boris Ostrovsky wrote: > On 7/24/20 10:34 AM, David Hildenbrand wrote: > > CCing Dan > > > > On 24.07.20 14:42, Roger Pau Monne wrote: > >> + > >> +#include > >> +#include > >>

[PATCH v3 0/4] xen/balloon: fixes for memory hotplug

2020-07-27 Thread Roger Pau Monne
backported to stable branches, third patch is a revert of a workaround applied to the balloon driver and last patch introduces an interface based on ZONE_DEVICE in order to manage regions to use for foreign mappings. Thanks, Roger. Roger Pau Monne (4): xen/balloon: fix accounting in

[PATCH v3 1/4] xen/balloon: fix accounting in alloc_xenballooned_pages error path

2020-07-27 Thread Roger Pau Monne
target_unpopulated is incremented with nr_pages at the start of the function, but the call to free_xenballooned_pages will only subtract pgno number of pages, and thus the rest need to be subtracted before returning or else accounting will be skewed. Signed-off-by: Roger Pau Monné Reviewed-by

[PATCH v3 2/4] xen/balloon: make the balloon wait interruptible

2020-07-27 Thread Roger Pau Monne
So it can be killed, or else processes can get hung indefinitely waiting for balloon pages. Signed-off-by: Roger Pau Monné Reviewed-by: Juergen Gross Cc: sta...@vger.kernel.org --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-de...@lists.xenproject.org --- drivers

[PATCH v3 3/4] Revert "xen/balloon: Fix crash when ballooning on x86 32 bit PAE"

2020-07-27 Thread Roger Pau Monne
checked the start address of the resource, but it should instead test the end address to assert the whole resource falls below MAX_PHYSMEM_BITS. Signed-off-by: Roger Pau Monné Reviewed-by: Juergen Gross --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-de

[PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-27 Thread Roger Pau Monne
hotplug from the usage of unpopulated physical memory ranges to map foreign pages, which is the correct thing to do in order to avoid mappings of foreign pages depend on memory hotplug. Signed-off-by: Roger Pau Monné --- I've not added a new memory_type type and just used MEMORY_DEVICE_DEVDAX

Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode

2020-07-21 Thread Roger Pau Monné
Marek: I'm adding you in case you could be able to give this a try and make sure it doesn't break suspend for dom0. On Tue, Jul 21, 2020 at 12:17:36AM +, Anchal Agarwal wrote: > On Mon, Jul 20, 2020 at 11:37:05AM +0200, Roger Pau Monné wrote: > > CAUTION: This email origina

Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode

2020-07-20 Thread Roger Pau Monné
On Sat, Jul 18, 2020 at 09:47:04PM -0400, Boris Ostrovsky wrote: > (Roger, question for you at the very end) > > On 7/17/20 3:10 PM, Anchal Agarwal wrote: > > On Wed, Jul 15, 2020 at 05:18:08PM -0400, Boris Ostrovsky wrote: > >> CAUTION: This email originated from outside of the organization. Do n

[PATCH] xen/balloon: add header guard

2020-07-28 Thread Roger Pau Monne
In order to protect against the header being included multiple times on the same compilation unit. Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-de...@lists.xenproject.org --- This is required as a pre-patch to use ZONE_DEVICE, or else

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-28 Thread Roger Pau Monné
On Tue, Jul 28, 2020 at 05:48:23PM +0100, Julien Grall wrote: > Hi, > > On 27/07/2020 10:13, Roger Pau Monne wrote: > > To be used in order to create foreign mappings. This is based on the > > ZONE_DEVICE facility which is used by persistent memory devices in > > order

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-28 Thread Roger Pau Monné
On Tue, Jul 28, 2020 at 06:06:25PM +0100, Andrew Cooper wrote: > On 28/07/2020 17:59, Roger Pau Monné wrote: > > On Tue, Jul 28, 2020 at 05:48:23PM +0100, Julien Grall wrote: > >> Hi, > >> > >> On 27/07/2020 10:13, Roger Pau Monne wrote: > >>> To b

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-28 Thread Roger Pau Monné
On Tue, Jul 28, 2020 at 06:12:46PM +0100, Julien Grall wrote: > Hi Roger, > > On 28/07/2020 17:59, Roger Pau Monné wrote: > > On Tue, Jul 28, 2020 at 05:48:23PM +0100, Julien Grall wrote: > > > Hi, > > > > > > On 27/07/2020 10:13, Roger Pau Monne wr

Re: [PATCH 3/3] memory: introduce an option to force onlining of hotplug memory

2020-07-23 Thread Roger Pau Monné
On Thu, Jul 23, 2020 at 01:37:03PM +0200, David Hildenbrand wrote: > On 23.07.20 10:45, Roger Pau Monne wrote: > > Add an extra option to add_memory_resource that overrides the memory > > hotplug online behavior in order to force onlining of memory from > > add_memory_res

Re: [PATCH 3/3] memory: introduce an option to force onlining of hotplug memory

2020-07-23 Thread Roger Pau Monné
On Thu, Jul 23, 2020 at 02:28:13PM +0200, Jürgen Groß wrote: > On 23.07.20 14:23, Roger Pau Monné wrote: > > On Thu, Jul 23, 2020 at 01:37:03PM +0200, David Hildenbrand wrote: > > > On 23.07.20 10:45, Roger Pau Monne wrote: > > > > Add an extra option to add_memo

<    1   2   3   4   5   6   >