On Tue, Aug 20, 2019 at 03:50:55PM +0200, Peter Zijlstra wrote:
> On Fri, Aug 16, 2019 at 10:12:02PM +0800, Peng Liu wrote:
> > Since sched_slice() is used in high frequency,
> > small change should also make sense.
>
> An actual Changelog would also make sense; but alas.
Since sched_slice() is used in high frequency,
small change should also make sense.
Signed-off-by: Peng Liu
---
kernel/sched/fair.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 1054d2cf6aaa..6ae2a507aac0 100644
afe to remove the extra lines in
rebalance_domains() which are originally intended for this_cpu. And
finally the updating only happen in _nohz_idle_balance().
Signed-off-by: Peng Liu
Cc: Ingo Molnar
Cc: Peter Zijlstra
Cc: Juri Lelli
Cc: Vincent Guittot
Cc: Dietmar Eggemann
Cc: Steven Ros
On Mon, Oct 05, 2020 at 11:11:00AM +0200, Juri Lelli wrote:
...
> > /*
> > * Here we want to check the bandwidth not being set to some
> > * value smaller than the currently allocated bandwidth in
> > * any of the root_domains.
> > -*
> > -* FIXME: Cycling on all the CP
:
- replace cpumask_weight(cpu_rq(cpu)->rd->span) with dl_bw_cpus(cpu),
suggested by Juri;
Peng Liu (2):
sched/deadline: optimize sched_dl_global_validate()
sched/deadline: Fix sched_dl_global_validate()
kernel/sched/deadline.c | 46 +--
Under CONFIG_SMP, dl_bw is per root domain, but not per CPU.
When checking or updating dl_bw, currently iterating every CPU is
overdoing, just need iterate each root domain once.
Suggested-by: Peter Zijlstra
Signed-off-by: Peng Liu
---
kernel/sched/deadline.c | 43
each CPU;
* - dl_total_bw array contains, in the i-eth element, the currently
*allocated bandwidth on the i-eth CPU.
[1]: https://lore.kernel.org/lkml/1267385230.13676.101.camel@Palantir/
Fixes: 332ac17ef5bf ("sched/deadline: Add bandwidth management for
SCHED_DEADLINE tasks")
Si
On Wed, Oct 07, 2020 at 06:55:33PM +0200, Peter Zijlstra wrote:
> On Wed, Oct 07, 2020 at 11:12:29PM +0800, Peng Liu wrote:
> > +/* Used for dl_bw check and update. */
> > +static u32 dl_generation;
>
> > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.
build error for !CONFIG_SMP, reported by kernel test robot;
v2 <-- v1:
- replace cpumask_weight(cpu_rq(cpu)->rd->span) with dl_bw_cpus(cpu),
suggested by Juri;
Peng Liu (2):
sched/deadline: Optimize sched_dl_global_validate()
sched/deadline: Fix sched_dl_global_valid
Under CONFIG_SMP, dl_bw is per root domain, but not per CPU.
When checking or updating dl_bw, currently iterating every CPU is
overdoing, just need iterate each root domain once.
Suggested-by: Peter Zijlstra
Signed-off-by: Peng Liu
---
kernel/sched/deadline.c | 39
each CPU;
* - dl_total_bw array contains, in the i-eth element, the currently
*allocated bandwidth on the i-eth CPU.
[1]: https://lore.kernel.org/lkml/1267385230.13676.101.camel@Palantir/
Fixes: 332ac17ef5bf ("sched/deadline: Add bandwidth management for
SCHED_DEADLINE tasks")
Si
ns, in the i-eth element, the currently
*allocated bandwidth on the i-eth CPU.
[1]: https://lore.kernel.org/lkml/1267385230.13676.101.camel@Palantir/
Fixes: 332ac17ef5bf ("sched/deadline: Add bandwidth management for
SCHED_DEADLINE tasks")
Suggested-by: Peter Zijlstra
Signed-off-
On Mon, May 04, 2020 at 01:10:46AM +0100, Valentin Schneider wrote:
>
> Hi,
>
> On 03/05/20 09:34, Peng Liu wrote:
> > commit c5afb6a87f23 ("sched/fair: Fix nohz.next_balance update")
>
> I got confused because this has the same topic as your patch, but that&
On Mon, May 04, 2020 at 05:17:11PM +0200, Vincent Guittot wrote:
> On Sun, 3 May 2020 at 10:34, Peng Liu wrote:
> >
> > commit c5afb6a87f23 ("sched/fair: Fix nohz.next_balance update")
> > During idle load balance, this_cpu(ilb) do load balance for the other
On Tue, May 05, 2020 at 04:27:11PM +0200, Vincent Guittot wrote:
> Le mardi 05 mai 2020 à 21:40:56 (+0800), Peng Liu a écrit :
> > On Mon, May 04, 2020 at 05:17:11PM +0200, Vincent Guittot wrote:
> > > On Sun, 3 May 2020 at 10:34, Peng Liu wrote:
> > > >
[...
On Tue, May 05, 2020 at 05:43:04PM +0200, Vincent Guittot wrote:
> On Tue, 5 May 2020 at 17:16, Peng Liu wrote:
> >
> > On Tue, May 05, 2020 at 04:27:11PM +0200, Vincent Guittot wrote:
> > > Le mardi 05 mai 2020 à 21:40:56 (+0800), Peng Liu a écrit :
> > > >
On Fri, Jul 24, 2020 at 09:14:26AM +0200, Juri Lelli wrote:
> Hi,
>
> On 07/07/20 00:04, Peng Liu wrote:
> > 'commit 840d719604b0 ("sched/deadline: Update rq_clock of later_rq when
> > pushing a task")'
> > introduced the update_rq_clock() to fix
l")'
took away the bug source(add_running_bw()).
We no longer need to update rq_clock in advance, let activate_task()
worry about that.
Signed-off-by: Peng Liu
---
kernel/sched/deadline.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/kernel/sched/d
Hi Peter,
Thanks for looking at this.
On Thu, Sep 24, 2020 at 12:57:14PM +0200, Peter Zijlstra wrote:
> On Sat, Sep 19, 2020 at 09:42:49AM +0800, Peng Liu wrote:
> > When user changes sched_rt_{runtime, period}_us, then
> >
> > sched_rt_handler()
> > -->
https://lkml.org/lkml/2010/2/28/119
[!CONFIG_SMP build error]
Reported-by: kernel test robot
Signed-off-by: Peng Liu
---
v3 <-- v2:
Fix build error for !CONFIG_SMP, reported by kernel test robot.
v2 <-- v1:
Replace cpumask_weight(cpu_rq(cpu)->rd->span) with dl_bw_cpus(cpu),
sugg
On Wed, Sep 16, 2020 at 11:42:03AM +0200, Juri Lelli wrote:
> Hi,
>
> On 15/09/20 23:20, Peng Liu wrote:
> > When user changes sched_rt_{runtime, period}_us, then
> >
> > sched_rt_handler()
> > --> sched_dl_bandwidth_validate()
> > {
https://lkml.org/lkml/2010/2/28/119
Signed-off-by: Peng Liu
---
v2 <-- v1:
Replace cpumask_weight(cpu_rq(cpu)->rd->span) with dl_bw_cpus(cpu),
suggested by Juri.
kernel/sched/deadline.c | 45 +
kernel/sched/sched.h| 17 +---
https://lkml.org/lkml/2010/2/28/119
Signed-off-by: Peng Liu
---
In fact, I'm not 100% sure that's a bug, since it's too 'obvious' and
not newly introduced code.
Also, the introduced #ifdef...#endif pairs look ugly, I have no idea
how to eliminate them. Ideas and comment
On Wed, May 06, 2020 at 05:02:56PM +0100, Valentin Schneider wrote:
>
> On 06/05/20 14:45, Vincent Guittot wrote:
> >> But then we may skip an update if we goto abort, no? Imagine we have just
> >> NOHZ_STATS_KICK, so we don't call any rebalance_domains(), and then as we
> >> go through the last N
Signed-off-by: Peng Liu
---
kernel/sched/topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index ba81187bb7af..9079d865a935 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -1328,7 +1328,7 @@ s
On Tue, May 05, 2020 at 04:27:11PM +0200, Vincent Guittot wrote:
> Le mardi 05 mai 2020 à 21:40:56 (+0800), Peng Liu a écrit :
>
[...]
>
> Your proposal below looks quite complex. IMO, one solution would be to move
> the
> update of nohz.next_balance before calling rebalan
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 26762423a2664692de2b9de684a5ac105e23
Gitweb:
https://git.kernel.org/tip/26762423a2664692de2b9de684a5ac105e23
Author:Peng Liu
AuthorDate:Thu, 08 Oct 2020 23:48:46 +08:00
Committer
The following commit has been merged into the sched/core branch of tip:
Commit-ID: a57415f5d1e43c3a5c5d412cd85e2792d7ed9b11
Gitweb:
https://git.kernel.org/tip/a57415f5d1e43c3a5c5d412cd85e2792d7ed9b11
Author:Peng Liu
AuthorDate:Thu, 08 Oct 2020 23:49:42 +08:00
Committer
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 9b1b234bb86bcdcdb142e900d39b599185465dbb
Gitweb:
https://git.kernel.org/tip/9b1b234bb86bcdcdb142e900d39b599185465dbb
Author:Peng Liu
AuthorDate:Tue, 09 Jun 2020 23:09:36 +08:00
Committer
29 matches
Mail list logo
