* be expected to be non-zero
*/
ret = vendor_mac_passthru_addr_read(tp, &sa);
if (ret < 0)
Tested-by : Perry Yuan
Hi Pierre:
thanks for the review effort.
On 2021/1/13 3:00, Pierre-Louis Bossart wrote:
On 1/12/21 11:17 AM, Perry Yuan wrote:
From: Perry Yuan
add support for dell privacy driver for the dell units equipped
hardware privacy design, which protect users privacy of audio and
camera from
Hi Hans:
On 2021/1/13 2:37, Hans de Goede wrote:
Hi,
I know there already is a v3 out and I will try to get around to reviewing
that soon, still 1 remark about the discussion surrounding v2:
On 1/11/21 2:42 PM, Perry Yuan wrote:
*The flow is like this:
1) User presses key. HW does stuff
Hi Mark:
Thanks for your review.
On 2021/1/13 1:54, Mark Brown wrote:
On Wed, Jan 13, 2021 at 01:18:14AM +0800, Perry Yuan wrote:
Some new Dell system is going to support audio internal micphone
privacy setting from hardware level with micmute led state changing
When micmute hotkey pressed by
Hi Mark:
Thanks for your review.
On 2021/1/13 1:54, Mark Brown wrote:
On Wed, Jan 13, 2021 at 01:18:14AM +0800, Perry Yuan wrote:
Some new Dell system is going to support audio internal micphone
privacy setting from hardware level with micmute led state changing
When micmute hotkey pressed by
Hi Randy.
On 2021/1/13 1:39, Randy Dunlap wrote:
On 1/12/21 9:17 AM, Perry Yuan wrote:
+config DELL_PRIVACY
+ tristate "Dell Hardware Privacy Support"
+ depends on ACPI
+ depends on ACPI_WMI
+ depends on INPUT
+ depends on DELL_LAPTOP
+
...@kernel.org; alsa-de...@alsa-project.org;
linux-kernel@vger.kernel.org; platform-driver-...@vger.kernel.org; Yuan,
Perry; Limonciello, Mario
Subject: [PATCH v3 2/3] x86/platform/dell-privacy-wmi: add document for dell
privacy driver
From: Perry Yuan
Describe the Dell Privacy feature
Hi Pierre:
On 2021/2/16 22:56, Pierre-Louis Bossart wrote:
+static const struct acpi_device_id privacy_acpi_device_ids[] = {
+ {"PNP0C09", 0},
+ { },
+};
+MODULE_DEVICE_TABLE(acpi, privacy_acpi_device_ids);
+
+static struct platform_driver dell_privacy_platform_drv = {
+ .driver = {
+
On 2021/2/1 4:59, Hans de Goede wrote:
Hi,
On 1/31/21 3:04 PM, Limonciello, Mario wrote:
-Original Message-
From: Hans de Goede
Sent: Saturday, January 30, 2021 15:44
To: Limonciello, Mario; Mark Gross
Cc: LKML; platform-driver-...@vger.kernel.org
Subject: Re: [PATCH] platform/x86:
From: Perry Yuan
Hi All,
This patch set is a new driver for dell mobile platform ,which has the
hardware privacy feature.
For micmute led control, the hotkey is Fn + F4, it is a hardware based
mute state, and new privacy will prevent micphone void input from
hardware layer, any application
From: Perry Yuan
add support for dell privacy driver for the dell units equipped
hardware privacy design, which protect users privacy of audio and
camera from hardware level. once the audio or camera privacy mode
enabled, any applications will not get any audio or video stream
when user pressed
From: Perry Yuan
Describe the Dell Privacy feature capabilities and devices
state class exposed by BIOS
Signed-off-by: Perry Yuan
---
.../testing/sysfs-platform-dell-privacy-wmi | 31 +++
1 file changed, 31 insertions(+)
create mode 100644 Documentation/ABI/testing/sysfs
From: Perry Yuan
Some new Dell system is going to support audio internal micphone
privacy setting from hardware level with micmute led state changing
When micmute hotkey pressed by user, soft mute will need to be enabled
firstly in case of pop noise, and codec driver need to react to mic
mute
Hi Barnabás,
On 2021/1/12 0:07, Barnabás Pőcze wrote:
Hi
2021. január 11., hétfő 14:42 keltezéssel, Perry Yuan írta:
[...]
+#define PRIVACY_PLATFORM_NAME "dell-privacy-acpi"
+#define DELL_PRIVACY_GUID "6932965F-1671-4CEB-B988-D3AB0A901919"
+
+struct privacy_acpi_p
On 2021/1/13 2:37, Hans de Goede wrote:
Hi,
I know there already is a v3 out and I will try to get around to reviewing
that soon, still 1 remark about the discussion surrounding v2:
On 1/11/21 2:42 PM, Perry Yuan wrote:
*The flow is like this:
1) User presses key. HW does stuff with this
From: Perry Yuan
add support for dell privacy driver for the dell units equipped
hardware privacy design, which protect users privacy
of audio and camera from hardware level. once the audio or camera
privacy mode enabled, any applications will not get any audio or
video stream.
when user pressed
From: Perry Yuan
add support for dell privacy driver for the dell units equipped
hardware privacy design, which protect users privacy
of audio and camera from hardware level. once the audio or camera
privacy mode enabled, any applications will not get any audio or
video stream.
when user pressed
From: Perry Yuan
Some new Dell system is going to support audio internal micphone
privacy setting from hardware level with micmute led state changing
When micmute hotkey pressed by user, soft mute will need to be enabled
firstly in case of pop noise, and codec driver need to react to mic
mute
Hi Pierre:
Thanks for your review!
On 2021/3/8 23:59, Pierre-Louis Bossart wrote:
module_param(force_rfkill, bool, 0444);
MODULE_PARM_DESC(force_rfkill, "enable rfkill on non whitelisted
models");
+
spurious line change
I just want to make them separate with more space .
If it cause
From: Perry Yuan
Hi All,
This patch set is a new driver for Dell mobile platform that has the
hardware privacy feature including micmute,camera mute.
For micmute led control, the hotkey is Fn + F4, it is a hardware based
mute state, and new privacy will prevent micphone void input from
hardware
From: Perry Yuan
add support for Dell privacy driver for the Dell units equipped
hardware privacy design, which protect users privacy of audio and
camera from hardware level. Once the audio or camera privacy mode
activated, any applications will not get any audio or video stream
when user
From: Perry Yuan
Some new Dell system is going to support audio internal micphone
privacy setting from hardware level with micmute led state changing
When micmute hotkey pressed by user, soft mute will need to be enabled
firstly in case of pop noise, and codec driver need to react to mic
mute
Hi Pierre
Thanks for your review .
I changed the patch and explain the review comments as below
(Maybe the mail format has problem, sent from one new system thunderbird :)
On 3/23/21 2:57 PM, Pierre-Louis Bossart wrote:
Minor comments below.
On 3/22/21 4:38 AM, Perry Yuan wrote:
From
Hi Hans.
Thanks for your suggestion helping to improve the patch.
On 3/24/21 7:39 AM, Hans de Goede wrote:
Hi,
On 3/24/21 12:19 PM, Hans de Goede wrote:
Hi,
On 3/22/21 10:38 AM, Perry Yuan wrote:
From: Perry Yuan
add support for Dell privacy driver for the Dell units equipped
hardware
From: Perry Yuan
Hi All,
This patch set is a new driver for Dell mobile platform that has the
hardware privacy feature including micmute,camera mute.
For micmute led control, the hotkey is Fn + F4, it is a hardware based
mute state, and new privacy will prevent micphone void input from
hardware
From: Perry Yuan
add support for Dell privacy driver for the Dell units equipped
hardware privacy design, which protect users privacy of audio and
camera from hardware level. Once the audio or camera privacy mode
activated, any applications will not get any audio or video stream
when user
From: Perry Yuan
Some new Dell system is going to support audio internal micphone
privacy setting from hardware level with micmute led state changing
When micmute hotkey pressed by user, soft mute will need to be enabled
firstly in case of pop noise, and codec driver need to react to mic
mute
From: Perry Yuan
Hi All,
This patch set is a new driver for Dell mobile platform that has the
hardware privacy feature including micmute,camera mute.
For micmute led control, the hotkey is Fn + F4, it is a hardware based
mute state, and new privacy will prevent micphone void input from
hardware
From: Perry Yuan
add support for Dell privacy driver for the Dell units equipped
hardware privacy design, which protect users privacy of audio and
camera from hardware level. Once the audio or camera privacy mode
activated, any applications will not get any audio or video stream
when user
From: Perry Yuan
Some new Dell system is going to support audio internal micphone
privacy setting from hardware level with micmute led state changing
When micmute hotkey pressed by user, soft mute will need to be enabled
firstly in case of pop noise, and codec driver need to react to mic
mute
From: Perry Yuan
Hi All,
This patch set is a new driver for dell mobile platform ,which has the
hardware privacy feature.
For micmute led control, the hotkey is Fn + F4, it is a hardware based
mute state, and new privacy will prevent micphone void input from
hardware layer, any application
From: Perry Yuan
Some new Dell system is going to support audio internal micphone
privacy setting from hardware level with micmute led state changing
When micmute hotkey pressed by user, soft mute will need to be enabled
firstly in case of pop noise, and codec driver need to react to mic
mute
From: Perry Yuan
add support for Dell privacy driver for the Dell units equipped
hardware privacy design, which protect users privacy of audio and
camera from hardware level. Once the audio or camera privacy mode
activated, any applications will not get any audio or video stream
when user
On 2021/1/13 1:39, Randy Dunlap wrote:
On 1/12/21 9:17 AM, Perry Yuan wrote:
+config DELL_PRIVACY
+ tristate "Dell Hardware Privacy Support"
+ depends on ACPI
+ depends on ACPI_WMI
+ depends on INPUT
+ depends on DELL_LAPTOP
+ depends on LEDS_TRI
Hi Mark,
Thanks for your review feedback.
On 2021/1/13 1:54, Mark Brown wrote:
On Wed, Jan 13, 2021 at 01:18:14AM +0800, Perry Yuan wrote:
Some new Dell system is going to support audio internal micphone
privacy setting from hardware level with micmute led state changing
When micmute hotkey
-project.org;
linux-kernel@vger.kernel.org; platform-driver-...@vger.kernel.org; Yuan,
Perry; Limonciello, Mario
Subject: [PATCH v3 3/3] ASoC: rt715:add micmute led state control supports
From: Perry Yuan
Some new Dell system is going to support audio internal micphone
privacy setting from hardware
...@kernel.org; alsa-de...@alsa-project.org;
linux-kernel@vger.kernel.org; platform-driver-...@vger.kernel.org; Yuan,
Perry; Limonciello, Mario
Subject: [PATCH v3 2/3] x86/platform/dell-privacy-wmi: add document for dell
privacy driver
From: Perry Yuan
Describe the Dell Privacy feature
pressed ctrl+F4 hotkey, audio privacy mode will be enabled
and camera mute hotkey is ctrl+F9.
Signed-off-by: Perry Yuan
Signed-off-by: Limonciello Mario
---
drivers/platform/x86/Kconfig | 12 ++
drivers/platform/x86/Makefile| 4 +-
drivers/platform/x86/dell-laptop.c
From: perry_yuan
Some new Dell system is going to support audio internal micphone
privacy setting from hardware level with micmute led state changing
This patch allow to change micmute led state through this micphone
led control interface like hda_generic provided.
Signed-off-by: Perry Yuan
must be at least (START + 5).
The patch also add the battery charging modes switch support.User can switch
the battery charging mode through the new sysfs entry.
Primary battery charging modes valid choices are:
['primarily_ac', 'adaptive', 'custom', 'standard'
40 matches
Mail list logo
