Re: [PATCH] media: v4l2-ctrl: add a helper fucntion to modify the menu

2012-09-10 Thread Prabhakar Lad
On Monday 10 September 2012 06:06 PM, Manjunath Hadli wrote: Hi Hans, Thanks for the review. On Monday 10 September 2012 05:43 PM, Hans Verkuil wrote: On Mon September 10 2012 13:57:36 Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Lad, Prabhakar prabhakar

[PATCH v3 0/2] ARM: davinci: da850/omap-l138: add support for VPIF driver

2012-09-11 Thread Prabhakar Lad
This patch series adds support for VPIF capture and display driver on da850/omap-l138. Enables SD capture and display. This patch series is dependent on the following patch: https://patchwork.kernel.org/patch/1332311/ Changes for v3: 1: Clubbed the code for DA850_UI_SD_VIDEO_PORT config as

[PATCH v3 1/2] ARM: da850/omap-l138: Add SoC related definitions for VPIF

2012-09-11 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com Add clock, pin mux definitions and registration function for VPIF capture and display driver on DA850/OMAP-L138 SoC. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com Cc: Sekhar Nori

[PATCH v3 2/2] ARM: da850/omap-l138: Add EVM specific code for VPIF to work

2012-09-11 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com Include the expander settings to select VPIF peripheral on UI card and add registration call in EVM init. Also add platform data to configure display and capture devices. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad,

[PATCH v2] media: v4l2-ctrl: add a helper function to modify the menu

2012-09-11 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com Add a helper function to modify the menu, max and default value to set. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Cc: Hans Verkuil hans.verk...@cisco.com Cc: Sakari Ailus sakari.ai...@iki.fi

Re: [PATCH v2] media: v4l2-ctrl: add a helper function to modify the menu

2012-09-11 Thread Prabhakar Lad
Hi Hans, Thanks for the review. On Tue, Sep 11, 2012 at 1:25 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Pradhakar, Looks good, but I have a number of style/grammar issues which I've corrected below. On Tue 11 September 2012 09:39:02 Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar

[PATCH v3] media: v4l2-ctrl: add a helper function to modify the menu

2012-09-11 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com Add a helper function to modify the menu, max and default value to set. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Cc: Hans Verkuil hans.verk...@cisco.com Cc: Sakari Ailus sakari.ai...@iki.fi

Re: [PATCH] vpif: replace preset with the timings API.

2012-09-17 Thread Prabhakar Lad
Hi Mauro, On Wed, Aug 8, 2012 at 5:39 PM, Prabhakar Lad prabhakar@ti.com wrote: From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com

Re: [PATCH 0/2] Replace the obsolete preset API by timings API

2012-09-17 Thread Prabhakar Lad
Hi Mauro/Sekhar On Wed, Aug 8, 2012 at 6:00 PM, Prabhakar Lad prabhakar@ti.com wrote: This first patch replaces the obsolete preset API by timings API for davinci VPBE, appropriate chnages in machine file for dm644x in which VPBE is enabled. And the second patch adds support for timings

Re: [PATCH v4] media: v4l2-ctrls: add control for dpcm predictor

2012-09-18 Thread Prabhakar Lad
predictor is preferred for 10-8-10 conversion, and the advanced predictor for 10-7-10 and 10-6-10 conversion. What do you suggest ? Regards, --Prabhakar Lad The main difference between the simple and the advanced predictors is image quality, with advanced predictor supposed to produce better

Re: [PATCH] arch/arm/mach-davinci/board-dm646x-evm.c: Remove unecessary

2012-09-18 Thread Prabhakar Lad
Hi Peter, Thanks for the patch. On Tue, Sep 18, 2012 at 10:06 PM, Peter Senna Tschudin peter.se...@gmail.com wrote: Found by http://coccinelle.lip6.fr/ The commit message 'Remove unecessary' doesn't explain what are you trying to do. Thanks, --Prabhakar Signed-off-by: Peter Senna Tschudin

[PATCH v4] media: v4l2-ctrl: add a helper function to add standard control with driver specific menu

2012-09-18 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com Add helper function v4l2_ctrl_new_std_menu_items(), which adds a standard menu control, with driver specific menu. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Cc: Hans Verkuil

Re: [PATCH v4] media: v4l2-ctrl: add a helper function to add standard control with driver specific menu

2012-09-19 Thread Prabhakar Lad
Hi Hans, Thanks for the review. On Wed, Sep 19, 2012 at 1:23 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Prabhakar, I found some grammar issues, but also some (small) things that should be changed. On Tue 18 September 2012 20:54:38 Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar

Re: [PATCH 01/14] davinci: vpfe: add dm3xx IPIPEIF hardware support module

2012-09-21 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Thu, Sep 20, 2012 at 3:31 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Prabhakar, Thanks for the patch. On Friday 14 September 2012 18:16:31 Prabhakar Lad wrote: From: Manjunath Hadli manjunath.ha...@ti.com add support for dm3xx

Re: [PATCH v3] media: v4l2-ctrl: add a helper function to modify the menu

2012-09-13 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Thursday 13 September 2012 06:45 AM, Laurent Pinchart wrote: Hi Prabhakar, Thanks for the patch. On Tuesday 11 September 2012 19:53:38 Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com Add a helper function to modify the menu, max

[PATCH] v4l: change path of video drivers

2012-09-14 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com due to structure change for video drivers, change the description with correct path. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Hans Verkuil

[PATCH 00/14] Media Controller capture driver for DM365

2012-09-14 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com This patch set adds media controller based capture driver for DM365. This driver bases its design on Laurent Pinchart's Media Controller Design whose patches for Media Controller and subdev enhancements form the base. The driver also takes copious

[PATCH 01/14] davinci: vpfe: add dm3xx IPIPEIF hardware support module

2012-09-14 Thread Prabhakar Lad
+ * + * Contributors: + * Manjunath Hadli manjunath.ha...@ti.com + * Prabhakar Lad prabhakar@ti.com + */ + +#include linux/io.h +#include linux/module.h +#include linux/kernel.h +#include linux/uaccess.h +#include linux/v4l2-mediabus.h +#include linux/platform_device.h + +#include

[PATCH 02/14] davinci: vpfe: add IPIPE hardware layer support

2012-09-14 Thread Prabhakar Lad
: + * Manjunath Hadli manjunath.ha...@ti.com + * Prabhakar Lad prabhakar@ti.com + */ + +#include linux/errno.h +#include linux/delay.h +#include linux/device.h +#include linux/v4l2-mediabus.h + +#include dm365_ipipe.h +#include dm3xx_ipipeif.h +#include dm365_ipipe_hw.h + +static void

[PATCH 06/14] davinci: vpfe: add v4l2 video driver support

2012-09-14 Thread Prabhakar Lad
+ * + * Contributors: + * Manjunath Hadli manjunath.ha...@ti.com + * Prabhakar Lad prabhakar@ti.com + */ + +#include linux/slab.h +#include linux/module.h +#include linux/platform_device.h + +#include media/v4l2-common.h +#include media/v4l2-mediabus.h +#include media/media-entity.h

[PATCH 07/14] davinci: vpfe: v4l2 capture driver with media interface

2012-09-14 Thread Prabhakar Lad
have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Contributors: + * Manjunath Hadli manjunath.ha...@ti.com + * Prabhakar Lad prabhakar

[PATCH 08/14] davinci: vpfe: previewer driver based on v4l2 media controller framework

2012-09-14 Thread Prabhakar Lad
+ * + * Contributors: + * Manjunath Hadli manjunath.ha...@ti.com + * Prabhakar Lad prabhakar@ti.com + */ + +#include linux/slab.h +#include linux/videodev2.h +#include linux/v4l2-mediabus.h +#include linux/platform_device.h +#include linux/davinci_vpfe.h + +#include media/v4l2-device.h +#include

[PATCH 09/14] davinci: vpfe: resizer driver based on media framework

2012-09-14 Thread Prabhakar Lad
., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Contributors: + * Manjunath Hadli manjunath.ha...@ti.com + * Prabhakar Lad prabhakar@ti.com + */ + +#include linux/slab.h +#include linux/videodev2.h +#include linux/platform_device.h +#include linux/v4l2-mediabus.h

[PATCH 11/14] dm365: vpss: set vpss clk ctrl

2012-09-14 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com request_mem_region for VPSS_CLK_CTRL register and ioremap. and enable clocks appropriately. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com --- drivers/media/platform/davinci/vpss.c | 11

[PATCH 10/14] dm365: vpss: setup ISP registers

2012-09-14 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com enable PPCR, enbale ISIF out on BCR and disable all events. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com --- drivers/media/platform/davinci/vpss.c | 13 + 1 files changed, 13

[PATCH 12/14] dm365: vpss: add vpss helper functions to be used in the main driver for setting hardware parameters

2012-09-14 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com add function to set sync polarity , interrupt completion and pageframe size in vpss to be used by the main driver. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com ---

[PATCH 13/14] davinci: vpfe: build infrastructure for dm365

2012-09-14 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com add build infrastructure for dm365 specific modules such as IPIPE, AEW, AF. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com --- drivers/media/platform/davinci/Kconfig | 40

[PATCH 05/14] davinci: vpfe: add ccdc driver with media controller interface

2012-09-14 Thread Prabhakar Lad
Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Contributors: + * Manjunath Hadli manjunath.ha...@ti.com + * Prabhakar Lad prabhakar@ti.com + */ + +#include linux/videodev2

[PATCH 14/14] [media] davinci: vpfe: Add documentation

2012-09-14 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com Add documentation on the Davinci VPFE driver. Document the subdevs, and private IOTCLs the driver implements Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com Cc: Rob Landley r...@landley.net Cc:

[PATCH] davinci: vpif: capture/display: fix race condition

2012-09-14 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com channel_first_int[][] variable is used as a flag for the ISR, This flag was being set after enabling the interrupts, There where suitaions when the isr ocuurend even before the flag was set dues to which it was causing the applicaiotn hang. This patch

[PATCH] davinci: vpif: remove unwanted header file inclusion

2012-09-14 Thread Prabhakar Lad
From: Hans Verkuil hans.verk...@cisco.com Remove old videobuf-core.h includes. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com --- drivers/media/platform/davinci/vpif_capture.h |1 - drivers/media/platform/davinci/vpif_display.h |1 -

[PATCH v2] davinci: vpif: capture/display: fix race condition

2012-09-14 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com channel_first_int[][] variable is used as a flag for the ISR, This flag was being set after enabling the interrupts, There where situations when the isr occurred even before the flag was set due to which it was causing the application hang. This patch

[PATCH] media: v4l2-ctrls: add control for dpcm predictor

2012-08-29 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com add V4L2_CID_DPCM_PREDICTOR control of type menu, which determines the dpcm predictor. The predictor can be either simple or advanced. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Cc: Sakari

Re: [PATCH] media: v4l2-ctrls: add control for dpcm predictor

2012-08-29 Thread Prabhakar Lad
Hi Sylwester, On Wednesday 29 August 2012 06:13 PM, Sylwester Nawrocki wrote: Hi Prabhakar, On 08/29/2012 02:31 PM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com add V4L2_CID_DPCM_PREDICTOR control of type menu, which determines the dpcm predictor. The predictor can

Re: [PATCH] media: v4l2-ctrls: add control for dpcm predictor

2012-08-29 Thread Prabhakar Lad
Hi Sakari, Thanks for the review. On Wed, Aug 29, 2012 at 7:51 PM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Prabhakar, Thanks for the patch. On Wed, Aug 29, 2012 at 06:01:07PM +0530, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com add V4L2_CID_DPCM_PREDICTOR control

[PATCH v2] media: v4l2-ctrls: add control for dpcm predictor

2012-08-30 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com add V4L2_CID_DPCM_PREDICTOR control of type menu, which determines the dpcm predictor. The predictor can be either simple or advanced. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Cc: Sakari

[PATCH v3] media: v4l2-ctrls: add control for dpcm predictor

2012-09-03 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com add V4L2_CID_DPCM_PREDICTOR control of type menu, which determines the dpcm predictor. The predictor can be either simple or advanced. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Cc: Sakari

[PATCH] media: v4l2-ctrls: add control for test pattern

2012-09-03 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com add V4L2_CID_TEST_PATTERN of type menu, which determines the internal test pattern selected by the device. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Cc: Sakari Ailus sakari.ai...@iki.fi Cc:

Re: [PATCH v3] media: v4l2-ctrls: add control for dpcm predictor

2012-09-03 Thread Prabhakar Lad
Hi Sylwester, Thanks for the review. On Monday 03 September 2012 02:51 PM, Sylwester Nawrocki wrote: On 09/03/2012 09:20 AM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com add V4L2_CID_DPCM_PREDICTOR control of type menu, which determines the dpcm predictor. The predictor

Re: [PATCH] media: v4l2-ctrls: add control for test pattern

2012-09-03 Thread Prabhakar Lad
Hi Hans, Thanks for the review. On Monday 03 September 2012 02:52 PM, Hans Verkuil wrote: On Mon September 3 2012 11:16:17 Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com add V4L2_CID_TEST_PATTERN of type menu, which determines the internal test pattern selected by the device

Re: [PATCH] media: v4l2-ctrls: add control for test pattern

2012-09-03 Thread Prabhakar Lad
Hi Sylwester, Thanks for the review. On Monday 03 September 2012 02:55 PM, Sylwester Nawrocki wrote: On 09/03/2012 11:16 AM, Prabhakar Lad wrote: diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index 2d7bc15..ae709d1 100644 --- a/drivers/media/v4l2

Re: [PATCH] media: v4l2-ctrls: add control for test pattern

2012-09-03 Thread Prabhakar Lad
Hi Sakari, Thanks for the review. On Tuesday 04 September 2012 01:09 AM, Sakari Ailus wrote: Hi Prabhakar, Thanks for the patch. On Mon, Sep 03, 2012 at 02:46:17PM +0530, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com add V4L2_CID_TEST_PATTERN of type menu, which

[PATCH v4] media: v4l2-ctrls: add control for dpcm predictor

2012-09-03 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com add V4L2_CID_DPCM_PREDICTOR control of type menu, which determines the dpcm predictor. The predictor can be either simple or advanced. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Acked-by: Hans

Re: [PATCH v4] media: v4l2-ctrls: add control for dpcm predictor

2012-09-04 Thread Prabhakar Lad
Hi Sakari, Thanks for the review. On Wednesday 05 September 2012 12:42 AM, Sakari Ailus wrote: Hi Prabhakar, Thanks for the patch. I've got a few comments below. On Tue, Sep 04, 2012 at 11:07:52AM +0530, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com add

[PATCH] davinci: fix build warning when CONFIG_DEBUG_SECTION_MISMATCH is enabled

2012-08-13 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- drivers/media/video/davinci/dm355_ccdc.c |2 +- drivers/media/video/davinci/dm644x_ccdc.c |2 +- drivers/media/video/davinci/isif.c

Re: [PATCH] davinci: fix build warning when CONFIG_DEBUG_SECTION_MISMATCH is enabled

2012-08-13 Thread Prabhakar Lad
Hi Mauro, Please drop this patch which is queued for 3.7, the actual fix should be to annotate probe with __devinit. I'll be sending V2 with the correct fix. Thx, --Prabhakar On Monday 13 August 2012 03:02 PM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Lad

[PATCH v2] media: davinci: fix section mismatch warnings

2012-08-13 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com This patch fixes section mismatch warnings for davinci video drivers. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- Changes for v2: 1: Annotate probe with __devinit. 2: Fixed the commit

Re: [PATCH] [media] davinci: vpfe: Add documentation

2012-08-16 Thread Prabhakar Lad
Hi Rob, On Thursday 16 August 2012 06:40 PM, Rob Landley wrote: On 07/11/2012 10:39 AM, Manjunath Hadli wrote: Add documentation on the Davinci VPFE driver. Document the subdevs, and private IOTCLs the driver implements Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by:

[PATCH] media: davinci: vpif: add check for NULL handler

2012-08-16 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Cc: Hans Verkuil hans.verk...@cisco.com --- drivers/media/video/davinci/vpif_capture.c | 12 +++-

[PATCH] vpif: replace preset with the timings API.

2012-08-08 Thread Prabhakar Lad
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- drivers/media/video/davinci/vpif.c | 16 ++-- drivers/media/video/davinci/vpif.h

[PATCH 0/2] Replace the obsolete preset API by timings API

2012-08-08 Thread Prabhakar Lad
This first patch replaces the obsolete preset API by timings API for davinci VPBE, appropriate chnages in machine file for dm644x in which VPBE is enabled. And the second patch adds support for timings API for ths7303 driver. Sending them as s series since VPBE uses the ths7303 driver. Hans

[PATCH 1/2] dm644x: replace the obsolete preset API by the timings API.

2012-08-08 Thread Prabhakar Lad
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- arch/arm/mach-davinci/board-dm644x-evm.c | 15 ++-- arch/arm/mach-davinci/dm644x.c

[PATCH 2/2] ths7303: enable THS7303 for HD modes

2012-08-08 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com add filter settings for high def modes like 1080i, 1080p,720p and others and implementing dv_timings. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com --- drivers/media/video/ths7303.c | 107

[PATCH v4 0/2] ARM: davinci: add support for dm365 vpbe display

2012-08-08 Thread Prabhakar Lad
This patch series enables VPBE display driver on DM365. This patch series is dependent on this patches posted http://www.spinics.net/lists/arm-kernel/msg188234.html Changes for v4: 1: Replaced the obsolete preset API by timings API. Changes for v3: 1: Removed VPSS clock alias for master and

[PATCH v4 2/2] ARM: davinci: dm365 EVM: add support for VPBE display

2012-08-08 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com add support for V4L2 video display to DM365 EVM. Support for SD and ED modes is provided, along with Composite and Component outputs. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com ---

[PATCH v4 1/2] ARM: davinci: dm365: add support for v4l2 video display

2012-08-08 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com Create platform devices for various video modules like venc,osd, vpbe and v4l2 driver for dm365. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com --- arch/arm/mach-davinci/board-dm365-evm.c |

[PATCH v3 0/2] ARM: davinci: add support for dm355 vpbe display

2012-08-08 Thread Prabhakar Lad
This patch series enables VPBE display driver on DM355. This patch series is dependent on this patches posted http://www.spinics.net/lists/arm-kernel/msg188234.html Changes for v3: 1: Replaced obsolete preset API by timings API. Changes for v2: 1: Removed VPSS clock alias for master and

[PATCH v3 1/2] ARM: davinci: dm355: add support for v4l2 video display

2012-08-08 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com Create platform devices for various video modules like venc,osd, vpbe and v4l2 driver for dm355. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com --- arch/arm/mach-davinci/board-dm355-evm.c |

[PATCH v3 2/2] ARM: davinci: dm355 EVM: add support for VPBE display

2012-08-08 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com add support for V4L2 video display to DM355 EVM. Support for SD modes is provided, along with Composite output Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com ---

Re: [PATCH] media: davinci: vpif: add check for NULL handler

2012-08-16 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Thursday 16 August 2012 08:43 PM, Laurent Pinchart wrote: Hi Prabhakar, Thanks for the patch. On Thursday 16 August 2012 19:32:00 Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com

Re: [PATCH] media: davinci: vpif: add check for NULL handler

2012-08-17 Thread Prabhakar Lad
Hi Sekhar, On Friday 17 August 2012 11:07 AM, Sekhar Nori wrote: On 8/17/2012 10:51 AM, Prabhakar Lad wrote: Hi Laurent, Thanks for the review. On Thursday 16 August 2012 08:43 PM, Laurent Pinchart wrote: Hi Prabhakar, Thanks for the patch. On Thursday 16 August 2012 19:32:00 Prabhakar

[PATCH v2 0/2] ARM: davinci: da850/omap-l138: add support for VPIF driver

2012-08-20 Thread Prabhakar Lad
This patch series adds support for VPIF capture and display driver on da850/omap-l138. Enables SD capture and display. This patch series is dependent on the following patch: https://patchwork.kernel.org/patch/1332311/ Changes for v2: 1: Avoid breaking of print messages. 2: Removed the handlers

[PATCH v2 1/2] ARM: da850/omap-l138: Add SoC related definitions for VPIF

2012-08-20 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com Add clock, pin mux definitions and registration function for VPIF capture and display driver on DA850/OMAP-L138 SoC. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com Cc: Sekhar Nori

[PATCH v2 2/2] ARM: da850/omap-l138: Add EVM specific code for VPIF to work

2012-08-20 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com Include the expander settings to select VPIF peripheral on UI card and add registration call in EVM init. Also add platform data to configure display and capture devices. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad,

Re: [PATCH RFC v2] media: v4l2-ctrl: Add gain controls

2012-12-05 Thread Prabhakar Lad
Hi Hans, On Wed, Dec 5, 2012 at 5:38 PM, Hans Verkuil hverk...@xs4all.nl wrote: (resend without HTML formatting) On Wed 5 December 2012 12:49:29 Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com add support for per color component digital/analog gain controls and also

Re: [PATCH RFC v2] media: v4l2-ctrl: Add gain controls

2012-12-11 Thread Prabhakar Lad
Hi Hans, On Tue, Dec 11, 2012 at 2:26 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Thu 6 December 2012 10:54:32 Sakari Ailus wrote: Hi Prabhakar and Hans, On Thu, Dec 06, 2012 at 10:24:18AM +0530, Prabhakar Lad wrote: Hi Hans, On Wed, Dec 5, 2012 at 5:38 PM, Hans Verkuil hverk

Re: [PATCH] davinci: vpbe: pass different platform names to handle different ip's

2012-11-20 Thread Prabhakar Lad
Sekhar, Thanks for the review. On Tue, Nov 20, 2012 at 2:40 PM, Sekhar Nori nsek...@ti.com wrote: On 11/19/2012 6:48 PM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com The vpbe driver can handle different platforms DM644X, DM36X and DM355. To differentiate between

[PATCH v2] davinci: vpbe: pass different platform names to handle different ip's

2012-11-20 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com The vpbe driver can handle different platforms DM644X, DM36X and DM355. To differentiate between this platforms venc_type/vpbe_type was passed as part of platform data which was incorrect. The correct way to differentiate to handle this case is by passing

[GIT PULL FOR v3.8] Davinci VPIF trivial fixes

2012-11-21 Thread Prabhakar Lad
Hi Mauro, Can you please pull the following patches for vpif, which fixes some trivial issues. Thanks and Regards, --Prabhakar Lad The following changes since commit 2c4e11b7c15af70580625657a154ea7ea70b8c76: [media] siano: fix RC compilation (2012-11-07 11:09:08 +0100) are available

Re: [PATCH v2 00/12] Media Controller capture driver for DM365

2012-11-23 Thread Prabhakar Lad
Hi Sakari, On Fri, Nov 23, 2012 at 6:43 PM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Prabhakar and others, (Just resending; Laurent's e-mail address corrected, cc Hans, too.) On Fri, Nov 16, 2012 at 08:15:02PM +0530, Prabhakar Lad wrote: From: Manjunath Hadli manjunath.ha...@ti.com

Re: [PATCH v2 00/12] Media Controller capture driver for DM365

2012-11-25 Thread Prabhakar Lad
Hi, On Fri, Nov 23, 2012 at 7:31 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Fri November 23 2012 14:57:53 Sakari Ailus wrote: Hi Prabhakar, On Fri, Nov 23, 2012 at 06:51:28PM +0530, Prabhakar Lad wrote: Hi Sakari, On Fri, Nov 23, 2012 at 6:43 PM, Sakari Ailus sakari.ai...@iki.fi

Re: [PATCH v2 00/12] Media Controller capture driver for DM365

2012-11-25 Thread Prabhakar Lad
HI Sakari, On Mon, Nov 26, 2012 at 5:58 AM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Prabhakar, On Sun, Nov 25, 2012 at 09:57:23PM +0530, Prabhakar Lad wrote: On Fri, Nov 23, 2012 at 7:31 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Fri November 23 2012 14:57:53 Sakari Ailus wrote

[PATCH] media: fix a typo CONFIG_HAVE_GENERIC_DMA_COHERENT in videobuf2-dma-contig.c

2012-11-26 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com from commit 93049b9368a2e257ace66252ab2cc066f3399cad, which adds a check HAVE_GENERIC_DMA_COHERENT for dma ops, the check was wrongly made it should have been HAVE_GENERIC_DMA_COHERENT but it was CONFIG_HAVE_GENERIC_DMA_COHERENT. This patch fixes the

Re: [PATCH] media: fix a typo CONFIG_HAVE_GENERIC_DMA_COHERENT in videobuf2-dma-contig.c

2012-11-26 Thread Prabhakar Lad
*/ /*/ -#ifdef HAVE_GENERIC_DMA_COHERENT +#ifdef CONFIG_HAVE_GENERIC_DMA_COHERENT struct vb2_dc_attachment { struct sg_table sgt; Regards, --Prabhakar Thank you, Kyungmin Park On 11/27/12, Prabhakar Lad prabhakar.cse...@gmail.com wrote: From: Lad, Prabhakar prabhakar@ti.com from

Re: [PATCH] media: fix a typo CONFIG_HAVE_GENERIC_DMA_COHERENT in videobuf2-dma-contig.c

2012-11-26 Thread Prabhakar Lad
Hi Marek, On Tue, Nov 27, 2012 at 12:53 PM, Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On 11/27/2012 6:59 AM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com from commit 93049b9368a2e257ace66252ab2cc066f3399cad, which adds a check HAVE_GENERIC_DMA_COHERENT

Re: [PATCH] media: fix a typo CONFIG_HAVE_GENERIC_DMA_COHERENT in videobuf2-dma-contig.c

2012-11-27 Thread Prabhakar Lad
Hi, On Tue, Nov 27, 2012 at 1:21 PM, Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On 11/27/2012 8:39 AM, Prabhakar Lad wrote: Hi Marek, On Tue, Nov 27, 2012 at 12:53 PM, Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On 11/27/2012 6:59 AM, Prabhakar Lad wrote

[PATCH v3 0/9] Media Controller capture driver for DM365

2012-11-28 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com Mauro/Greg, The below series of patches have gone through good amount of reviews, and agreed by Laurent, Hans and Sakari to be part of the staging tree. I am combining the patchs with the pull request so we can get them into the 3.8 kernel. Please

[PATCH v3 2/9] davinci: vpfe: add v4l2 video driver support

2012-11-28 Thread Prabhakar Lad
Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Contributors: + * Manjunath Hadli manjunath.ha...@ti.com + * Prabhakar Lad prabhakar@ti.com + */ + +#include linux/module.h +#include linux/slab.h + +#include media/v4l2-ioctl.h + +#include vpfe.h

[PATCH v3 3/9] davinci: vpfe: dm365: add IPIPEIF driver based on media framework

2012-11-28 Thread Prabhakar Lad
02111-1307 USA + * + * Contributors: + * Manjunath Hadli manjunath.ha...@ti.com + * Prabhakar Lad prabhakar@ti.com + */ + +#include dm365_ipipeif.h +#include vpfe_mc_capture.h + +static const unsigned int ipipeif_input_fmts[] = { + V4L2_MBUS_FMT_UYVY8_2X8

[PATCH v3 6/9] davinci: vpfe: dm365: add IPIPE hardware layer support

2012-11-28 Thread Prabhakar Lad
manjunath.ha...@ti.com + * Prabhakar Lad prabhakar@ti.com + */ + +#include dm365_ipipe_hw.h + +#define IPIPE_MODE_CONTINUOUS 0 +#define IPIPE_MODE_SINGLE_SHOT 1 + +static void ipipe_clock_enable(void *__iomem base_addr) +{ + /* enable IPIPE MMR for register write

[PATCH v3 8/9] davinci: vpfe: dm365: add build infrastructure for capture driver

2012-11-28 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com add build infrastructure for dm365 specific modules for VPFE capture driver. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com --- drivers/staging/media/Kconfig |2 ++

[PATCH v3 9/9] davinci: vpfe: Add documentation and TODO

2012-11-28 Thread Prabhakar Lad
@@ +Davinci Video processing Front End (VPFE) driver + +Copyright (C) 2012 Texas Instruments Inc + +Contacts: Manjunath Hadli manjunath.ha...@ti.com + Prabhakar Lad prabhakar@ti.com + + +Introduction + + +This file documents the Texas Instruments Davinci Video processing Front

[PATCH v3 0/3] Davinci VPSS helper functions for VPFE

2012-11-28 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com Hi Mauro, This patchset, was part of the DM365 capture driver series, I have split them up and made as separate series as the capture patches will now be going under staging and made as version V3. This patches have undergone several reviews along

[PATCH v3 1/3] davinci: vpss: dm365: enable ISP registers

2012-11-28 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com enable PPCR, enbale ISIF out on BCR and disable all events to get the correct operation from ISIF. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com --- drivers/media/platform/davinci/vpss.c |

[PATCH v3 3/3] davinci: vpss: dm365: add vpss helper functions to be used in the main driver for setting hardware parameters

2012-11-28 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com add interface functions to set sync polarity, interrupt completion and pageframe size in vpss to be used by the main driver. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com ---

[PATCH v3 2/3] davinci: vpss: dm365: set vpss clk ctrl

2012-11-28 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com request_mem_region for VPSS_CLK_CTRL register and ioremap. and enable clocks appropriately. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com --- drivers/media/platform/davinci/vpss.c | 14

[PATCH] media: davinci: vpbe: enable building of vpbe driver for DM355 and DM365

2012-11-28 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com This patch allows enabling building of VPBE display driver for DM365 and DM355. This also removes unnecessary entry VIDEO_DM644X_VPBE in Kconfig, which could have been done with single entry, and appropriate changes in Makefile for building.

Re: [PATCH v3 2/3] davinci: vpss: dm365: set vpss clk ctrl

2012-11-28 Thread Prabhakar Lad
Hi Sakari, Thanks for the quick review. On Thu, Nov 29, 2012 at 1:48 AM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Prabhakar, On Wed, Nov 28, 2012 at 04:25:33PM +0530, Prabhakar Lad wrote: From: Manjunath Hadli manjunath.ha...@ti.com request_mem_region for VPSS_CLK_CTRL register

Re: [PATCH v3 1/3] davinci: vpss: dm365: enable ISP registers

2012-11-28 Thread Prabhakar Lad
Hi Sakari, Thanks for the quick review. On Thu, Nov 29, 2012 at 1:38 AM, Sakari Ailus sakari.ai...@iki.fi wrote: On Wed, Nov 28, 2012 at 04:25:32PM +0530, Prabhakar Lad wrote: From: Manjunath Hadli manjunath.ha...@ti.com enable PPCR, enbale ISIF out on BCR and disable all events to get

Re: [PATCH v3 9/9] davinci: vpfe: Add documentation and TODO

2012-11-28 Thread Prabhakar Lad
wrote: Hi Prabhakar, Em Wed, 28 Nov 2012 16:12:09 +0530 Prabhakar Lad prabhakar.cse...@gmail.com escreveu: +Introduction + + + This file documents the Texas Instruments Davinci Video processing Front + End (VPFE) driver located under drivers/media/platform

Re: [PATCH v5 1/2] ARM: davinci: dm365: add support for v4l2 video display

2012-12-18 Thread Prabhakar Lad
Sekhar, Thanks for the review. On Tue, Dec 4, 2012 at 6:44 PM, Sekhar Nori nsek...@ti.com wrote: On 12/3/2012 1:51 PM, Prabhakar Lad wrote: From: Manjunath Hadli manjunath.ha...@ti.com Create platform devices for various video modules like venc,osd, vpbe and v4l2 driver for dm365. Signed

[GIT PULL FOR v3.9] Davinci VPSS Updates

2012-12-20 Thread Prabhakar Lad
Hi Mauro, Please pull the following patches for DaVinci VPSS driver. These patches have undergone under enormous reviews and are ready to be queued. Thanks and Regards, --Prabhakar Lad The following changes since commit 4bb891ebf60eb43ebd04e09bbcad24013067873f: [media] ivtv: ivtv-driver

[GIT PULL FOR v3.9] Davinci VPFE Media Controller capture driver for DM365

2012-12-21 Thread Prabhakar Lad
Hi Mauro, Please pull the following patches for DaVinci VPFE driver for DM365. The patches have gone through good amount of reviews, and Acked by Laurent, Hans and Sakari and is agreed to be part of the staging. Regards, --Prabhakar The following changes since commit

[GIT PULL FOR v3.9] Davinci VPBE Trivial Fixes

2012-12-21 Thread Prabhakar Lad
Hi Mauro, Please pull the following patches for DaVinci VPBE driver. One of the patch has ARM changes and is Acked-by the ARM maintainer. Thanks and Regards, --Prabhakar Lad The following changes since commit 4bb891ebf60eb43ebd04e09bbcad24013067873f: [media] ivtv: ivtv-driver: Replace

Re: [PATCH] tvp7002: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Prabhakar Lad
Hi Laurent, Thanks for the quick review! On Thu, Jan 3, 2013 at 7:02 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: On Thursday 03 January 2013 14:31:20 Laurent Pinchart wrote: On Thursday 03 January 2013 18:52:42 Lad, Prabhakar wrote: I2C drivers can use devm_kzalloc() too in

Re: [PATCH 2/5] media: davinci: fix return value check in vpbe_display_reqbufs().

2012-12-11 Thread Prabhakar Lad
/patch/1830231/ Regards, --Prabhakar Lad Signed-off-by: Cyril Roelandt tipec...@gmail.com --- drivers/media/platform/davinci/vpbe_display.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/davinci/vpbe_display.c b/drivers/media/platform/davinci

[PATCH v2 00/12] Media Controller capture driver for DM365

2012-11-16 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com This patch set adds media controller based capture driver for DM365. This driver bases its design on Laurent Pinchart's Media Controller Design whose patches for Media Controller and subdev enhancements form the base. The driver also takes copious

[PATCH v2 02/12] davinci: vpfe: add v4l2 video driver support

2012-11-16 Thread Prabhakar Lad
., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Contributors: + * Manjunath Hadli manjunath.ha...@ti.com + * Prabhakar Lad prabhakar@ti.com + */ + +#include linux/module.h +#include linux/slab.h + +#include media/davinci/vpfe.h +#include media/v4l2-ioctl.h + +#include

[PATCH v2 03/12] davinci: vpfe: dm365: add IPIPEIF driver based on media framework

2012-11-16 Thread Prabhakar Lad
, Boston, MA 02111-1307 USA + * + * Contributors: + * Manjunath Hadli manjunath.ha...@ti.com + * Prabhakar Lad prabhakar@ti.com + */ + +#include dm365_ipipeif.h +#include vpfe_mc_capture.h + +static const unsigned int ipipeif_input_fmts[] = { + V4L2_MBUS_FMT_UYVY8_2X8

[PATCH v2 06/12] davinci: vpfe: dm365: add IPIPE hardware layer support

2012-11-16 Thread Prabhakar Lad
+ * Prabhakar Lad prabhakar@ti.com + */ + +#include dm365_ipipe_hw.h + +#define IPIPE_MODE_CONTINUOUS 0 +#define IPIPE_MODE_SINGLE_SHOT 1 + +static void ipipe_clock_enable(void *__iomem base_addr) +{ + /* enable IPIPE MMR for register write access */ + regw_ip

<    1   2   3   4   5   6   7   8   9   10   >