Re: [PATCH] media: i2c: Kconfig: create dependency to MEDIA_CONTROLLER for adv7*

2014-02-06 Thread Prabhakar Lad
on VIDEO_V4L2_SUBDEV_API config and if you see VIDEO_V4L2_SUBDEV_API depends on MEDIA_CONTROLLER config so there is no point in adding this dependency. Thanks, --Prabhakar Lad Signed-off-by: Marcus Folkesson marcus.folkes...@gmail.com --- drivers/media/i2c/Kconfig |6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH 1/2] [media] v4l2: Add settings for Horizontal and Vertical MV Search Range

2014-02-06 Thread Prabhakar Lad
...@samsung.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Regards, --Prabhakar Lad --- Documentation/DocBook/media/v4l/controls.xml | 20 drivers/media/v4l2-core/v4l2-ctrls.c |6 ++ include/uapi/linux/v4l2-controls.h |2 ++ 3 files changed

Re: [PATCH v2 1/2] net: davinci_mdio: reuse for keystone2 arch

2014-07-16 Thread Prabhakar Lad
grygorii.stras...@ti.com Reviewed-by: Lad, Prabhakar prabhakar.cse...@gmail.com Thanks, --Prabhakar Lad --- .../devicetree/bindings/net/davinci-mdio.txt |8 drivers/net/ethernet/ti/Kconfig|4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff

Re: [PATCH v2 2/2] net: davinci_mdio: allow to create phys from dt

2014-07-16 Thread Prabhakar Lad
Thanks, --Prabhakar Lad --- Hi Santosh, I haven't changed style for long-comments, because Networking subsystem requires first line of comment not to be empty: WARNING:NETWORKING_BLOCK_COMMENT_STYLE: networking block comments don't use an empty /* line, use /* Comment... drivers/net

[GIT PULL FOR v3.17] Davinci Media

2014-07-16 Thread Prabhakar Lad
Hi Mauro, Please pull the following patches for davinci media which include trivial cleanups. Thanks, --Prabhakar Lad The following changes since commit 3c0d394ea7022bb9666d9df97a5776c4bcc3045c: [media] dib8000: improve the message that reports per-layer locks (2014-07-07 09:59:01 -0300

Re: [PATCH 10/15] media: davinci: vpbe: add support for VIDIOC_CREATE_BUFS

2014-10-22 Thread Prabhakar Lad
for this one and I'll pick it up later. I fixed it and posted the patch. To avoid conflicts I have rebased the patch on for-v3.19a branch of your tree. Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH 3/3] [media] vpif: Fix compilation with allmodconfig

2014-09-09 Thread Prabhakar Lad
! That's because vpif_lock symbol is not exported. Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Regards, --Prabhakar Lad Reported-by: Stephen Rothwell s...@canb.auug.org.au Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com diff --git a/drivers/media/platform/davinci/vpif.c b

Re: [PATCH] media: exynos-gsc: fix build warning

2014-11-25 Thread Prabhakar Lad
reach here! may be you can remove the complete else part outside ? with that change, Reported-by: Lad, Prabhakar prabhakar.cse...@gmail.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Thanks, --Prabhakar Lad } void gsc_set_prefbuf(struct gsc_dev *gsc, struct gsc_frame *frm

Re: [PATCH] media: exynos-gsc: fix build warning

2014-11-25 Thread Prabhakar Lad
Hi, On Tue, Nov 25, 2014 at 3:18 PM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: Hi Mauro, On Tue, Nov 25, 2014 at 3:04 PM, Mauro Carvalho Chehab mche...@osg.samsung.com wrote: Em Tue, 18 Nov 2014 10:57:48 + [Snip] -static u32 get_plane_info(struct gsc_frame *frm, u32 addr, u32

Re: [PATCH v2 11/11] media: usb: uvc: use vb2_ops_wait_prepare/finish helper

2014-11-26 Thread Prabhakar Lad
by the uvcvideo driver, so you can't use vb2_ops_wait_prepare|finish(). Oops not sure what happened here I just took the patch from [1] and added commit message. anyway will post a single patch v3. [1] https://patchwork.kernel.org/patch/5327451/ Thanks, --Prabhakar Lad Signed-off-by: Lad, Prabhakar

Re: [PATCH] media: davinci: vpbe: missing clk_put

2014-11-07 Thread Prabhakar Lad
Hi, Thanks for the patch! On Thu, Nov 6, 2014 at 1:04 PM, Sudip Mukherjee sudipm.mukher...@gmail.com wrote: we are getting struct clk using clk_get before calling clk_prepare_enable. but if clk_prepare_enable fails, then we are jumping to fail_mutex_unlock where we are just unlocking the

Re: [PATCH v3 08/10] staging: media: Make use of MEDIA_BUS_FMT_ definitions

2014-11-08 Thread Prabhakar Lad
Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Thanks, --Prabhakar Lad drivers/staging/media/omap4iss/iss_csi2.c | 62 ++--- drivers/staging/media/omap4iss/iss_ipipe.c | 16 ++-- drivers/staging/media/omap4iss/iss_ipipeif.c | 28 +++--- drivers/staging

Re: [PATCH v3 06/10] [media] platform: Make use of media_bus_format enum

2014-11-08 Thread Prabhakar Lad
] include/media/davinci/vpbe.h | 2 +- include/media/davinci/vpbe_venc.h | 5 +- For all the above. Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH v3 04/10] [media] i2c: Make use of media_bus_format enum

2014-11-08 Thread Prabhakar Lad
| 10 ++--- For all the above, Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Thanks, --Prabhakar Lad drivers/media/i2c/vs6624.c| 18 46 files changed, 382 insertions(+), 382 deletions(-) diff --git a/drivers/media/i2c/adv7170.c b/drivers/media/i2c/adv7170.c

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-17 Thread Prabhakar Lad
v4l2_subdev_fh, vfh) -#if defined(CONFIG_VIDEO_V4L2_SUBDEV_API) Wouldn't you need to drop these from struct v4l2_subdev_fh as well? The code won't compile if the fields aren't there. Ah missed it, thanks for the catch! Thanks, --Prabhakar Lad #define __V4L2_SUBDEV_MK_GET_TRY(rtype

Re: [PATCH 06/12] media: marvell-ccic: use vb2_ops_wait_prepare/finish helper

2014-11-18 Thread Prabhakar Lad
to see a real changelog on the patch, though. Sorry there is no movement of code to other file. And I dont see any reason why anybody reading will go haywire its a standard v4l2 thing. The subject explains it all, If you still want me to elaborate I can post a v2. Thanks, --Prabhakar Lad

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-18 Thread Prabhakar Lad
you won't find the function definitions if you grep on the function name. But any functional changes here need to be Acked by Laurent first. Yes, ill probably wait until Laurent is back from his holidays. Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH] media: platform: add VPFE capture driver support for AM437X

2014-12-01 Thread Prabhakar Lad
Hi Hans, Thanks for the review. On Mon, Dec 1, 2014 at 10:11 AM, Hans Verkuil hverk...@xs4all.nl wrote: Hi all, Thanks for the patch, review comments are below. For the next version I would appreciate if someone can test this driver with the latest v4l2-compliance from the v4l-utils git

Re: [PATCH] media: platform: add VPFE capture driver support for AM437X

2014-12-01 Thread Prabhakar Lad
series dm6467/dm6467t/omapl138/am1808) vpfe - under davinci is common for (Davinci series dm36x/dm6446/dm355) I am falling short of names for renaming this common drivers :) Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH] media: platform: add VPFE capture driver support for AM437X

2014-12-01 Thread Prabhakar Lad
Hi Hans, On Tue, Dec 2, 2014 at 7:26 AM, Hans Verkuil hverk...@xs4all.nl wrote: On 12/01/2014 11:17 PM, Prabhakar Lad wrote: Hi Hans, Thanks for the review. On Mon, Dec 1, 2014 at 10:11 AM, Hans Verkuil hverk...@xs4all.nl wrote: Hi all, Thanks for the patch, review comments are below

Re: [PATCH] media: platform: add VPFE capture driver support for AM437X

2014-12-01 Thread Prabhakar Lad
Hi Hans, On Tue, Dec 2, 2014 at 7:32 AM, Hans Verkuil hverk...@xs4all.nl wrote: On 12/01/2014 11:27 PM, Prabhakar Lad wrote: Hi Hans, On Mon, Dec 1, 2014 at 11:00 AM, Hans Verkuil hverk...@xs4all.nl wrote: On 12/01/2014 11:11 AM, Hans Verkuil wrote: Hi all, Thanks for the patch, review

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-12-01 Thread Prabhakar Lad
Hi Hans, On Mon, Dec 1, 2014 at 11:26 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Prabhakar, On Sunday 30 November 2014 21:30:35 Prabhakar Lad wrote: On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart wrote: On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote

Re: [PATCH v1] lib/genalloc.c: Export devm_gen_pool_create for modules

2014-12-02 Thread Prabhakar Lad
/genalloc.c | 1 + 1 file changed, 1 insertion(+) don’t you need to add an entry in include/linux/genalloc.h ? Thanks, --Prabhakar Lad diff --git a/lib/genalloc.c b/lib/genalloc.c index cce4dd68c40d..2e65d206b01c 100644 --- a/lib/genalloc.c +++ b/lib/genalloc.c @@ -598,6 +598,7 @@ struct

Re: [PATCH v1] lib/genalloc.c: Export devm_gen_pool_create for modules

2014-12-02 Thread Prabhakar Lad
Hi Michal, On Tue, Dec 2, 2014 at 9:36 AM, Michal Simek michal.si...@xilinx.com wrote: On 12/02/2014 10:31 AM, Prabhakar Lad wrote: Hi Michal, Thanks for the patch. On Mon, Dec 1, 2014 at 1:00 PM, Michal Simek michal.si...@xilinx.com wrote: Modules can use this function for creating pool

Re: [PATCH v2] media: platform: add VPFE capture driver support for AM437X

2014-12-02 Thread Prabhakar Lad
Sequence: 119 Field: None Timestamp: 76.711771s test MMAP: OK test USERPTR: OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device Total: 42, Succeeded: 42, Failed: 0, Warnings: 0 Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line

Re: [PATCH v8 08/50] virtio: memory access APIs

2014-12-02 Thread Prabhakar Lad
? Apart from that patch looks good. Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 1/3] video: fbdev: vt8623fb: suppress build warning

2014-12-03 Thread Prabhakar Lad
of a pointer? Yes looks ugly, I am not sure what you meant from 'where does this warning come from' its in the commit message. Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] media: ti-vpe: Use mem-to-mem ioctl helpers

2014-12-19 Thread Prabhakar Lad
to utilize my holidays in proper way :D Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH v3] media: usb: uvc: use vb2_ops_wait_prepare/finish helper

2014-11-28 Thread Prabhakar Lad
not aware of. Thanks, --Prabhakar Lad ret = vb2_queue_init(queue-queue); if (ret) return ret; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v3] media: usb: uvc: use vb2_ops_wait_prepare/finish helper

2014-11-29 Thread Prabhakar Lad
Hi Laurent, On Sat, Nov 29, 2014 at 6:11 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Prabhakar, On Friday 28 November 2014 17:06:52 Prabhakar Lad wrote: On Thu, Nov 27, 2014 at 9:32 PM, Laurent Pinchart wrote: Hi Prabhakar, [Snip] + queue-queue.lock = queue

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-29 Thread Prabhakar Lad
back then AFAIR. But any functional changes here need to be Acked by Laurent first. How do you want me to proceed on this ? Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-30 Thread Prabhakar Lad
subdev API would use the configuration store from the file handle. are planning to work/post any time soon ? Or are you OK with suggestion from Hans ? Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-30 Thread Prabhakar Lad
Hi Laurent, On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote: On Sat, Nov 29, 2014 at 7:12 PM, Laurent Pinchart wrote: Hi Prabhakar, [Snip] Sure. That's a better choice than removing

Re: [PATCH v7 44/46] virtio_scsi: export to userspace

2014-11-30 Thread Prabhakar Lad
, Prabhakar prabhakar.cse...@gmail.com Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH] misc: suppress build warning

2014-12-04 Thread Prabhakar Lad
are sure that there isn't, and why you picked '0' as the initialization value. Its a false positive, to suppress the warning '0' was picked. Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH v3] media: platform: add VPFE capture driver support for AM437X

2014-12-05 Thread Prabhakar Lad
accepted for 3.19. OK will post a v4 tonight fixing all the below issues. FYI: Looking at the response of Mauro on 'soc-camera: 1st set for 3.19' he wont accept it! Thanks, --Prabhakar Lad On 12/04/2014 12:12 AM, Lad, Prabhakar wrote: From: Benoit Parrot bpar...@ti.com This patch adds Video

Re: [PATCH] misc: ioc4: fix variable may be used uninitialized warning

2014-12-08 Thread Prabhakar Lad
, but for the sanity of gcc output explicitly initialize it. Same goes for the 'end' variable. Prabhakar Lad also sent a patch for this already, which was lacking a good patch description. Your patch does this slightly better but still fails to explain how you concluded it was safe and you don't really explain

Re: [PATCH 2/2] fbdev: ssd1307fb: check return value while setting offset

2015-01-13 Thread Prabhakar Lad
then and there ? Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/2] fbdev: ssd1307fb: check return value while setting offset

2015-01-13 Thread Prabhakar Lad
On Tue, Jan 13, 2015 at 1:39 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: On Tue, Jan 13, 2015 at 11:53:01AM +, Prabhakar Lad wrote: On Tue, Jan 13, 2015 at 11:43 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On 08/01/15 10:17, Lad, Prabhakar wrote: this patch checks

[PATCH] fbdev: goldfishfb: use devres api

2015-02-20 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch does the following: a uses devm_kzalloc() instead of kzalloc and cleanup the error path b uses devm_ioremap() instead of ioremap and cleanup the error path c uses devm_request_irq() instead of request_irq and cleanup the error path

Re: [PATCH v2] davinci: vpif: add pm_runtime support

2013-04-02 Thread Prabhakar Lad
Hi Hans, On Tue, Apr 2, 2013 at 2:17 PM, Hans Verkuil wrote: > On Mon 1 April 2013 08:36:50 Prabhakar lad wrote: >> From: Lad, Prabhakar >> >> Add pm_runtime support to the TI Davinci VPIF driver. >> >> Signed-off-by: Lad, Prabhakar >> Cc: Mauro Carv

[PATCH v2 1/3] media: davinci: vpss: enable vpss clocks

2013-04-02 Thread Prabhakar lad
From: Lad, Prabhakar By default the VPSS clocks were enabled in capture driver for davinci family which creates duplicates for dm355/dm365/dm644x. This patch adds support to enable the VPSS clocks in VPSS driver, which avoids duplication of code and also adding clock aliases. This patch uses PM

[PATCH v2 2/3] media: davinci: vpbe: venc: move the enabling of vpss clocks to driver

2013-04-02 Thread Prabhakar lad
From: Lad, Prabhakar The vpss clocks were enabled by calling a exported function from a driver in a machine code. calling driver code from platform code is incorrect way. This patch fixes this issue and calls the function from driver code itself. Signed-off-by: Lad, Prabhakar ---

[PATCH v2 0/3] davinci: vpss: clock cleanup

2013-04-02 Thread Prabhakar lad
From: Lad, Prabhakar This patch series cleanup's the VPSS clock enabling. The first patch removes vpss clock enabling from the capture drivers and moves it to the VPSS driver itself. The second patch moves the venc_enable_vpss_clock() to the driver which was being done in platform code. Changes

[PATCH v2 3/3] davinic: vpss: trivial cleanup

2013-04-02 Thread Prabhakar lad
From: Lad, Prabhakar this patch removes unnecessary header file inclusions and fixes the typo's. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpss.c | 11 +++ 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/davinci/vpss.c

[PATCH v8 0/2] ARM: davinci: add support for dm365 vpbe display

2013-04-02 Thread Prabhakar lad
From: Lad, Prabhakar This patch series enables VPBE display driver on DM365. Changes for v8: 1: Fixed nits pointed by Sekhar. Changes for v7: 1: Fixed nits pointed by Sekhar. Changes for v6: 1: Fixed review comments pointed by Sekhar. Changes for v5: 1: pass different platform names to

[PATCH v8 1/2] ARM: davinci: dm365: add support for v4l2 video display

2013-04-02 Thread Prabhakar lad
From: Lad, Prabhakar Create platform devices for various video modules like venc,osd, vpbe and v4l2 driver for dm365. Signed-off-by: Lad, Prabhakar --- arch/arm/mach-davinci/board-dm365-evm.c |4 +- arch/arm/mach-davinci/davinci.h |7 +- arch/arm/mach-davinci/dm365.c

[PATCH v8 2/2] ARM: davinci: dm365 EVM: add support for VPBE display

2013-04-02 Thread Prabhakar lad
From: Lad, Prabhakar add support for V4L2 video display to DM365 EVM. Support for SD and ED modes is provided, along with Composite and Component outputs. Signed-off-by: Lad, Prabhakar --- arch/arm/mach-davinci/board-dm365-evm.c | 164 ++- 1 files changed, 163

Re: [BUG] mod/file2alias: build error in devicetable-offsets.c [was: asm/types.h Header file wont get generated while building uImage ?]

2013-04-02 Thread Prabhakar Lad
Hi Andreas, On Sun, Mar 31, 2013 at 1:16 AM, Andreas Schwab wrote: > "Jon Medhurst (Tixy)" writes: > >> For builds which succeed I see this order: >> >> WRAParch/arm/include/generated/asm/types.h >> [...] >> GEN include/generated/asm-offsets.h >> >> and for those which fail: >> >>

[PATCH v7 0/2] ARM: davinci: dm355: add support for vpbe display

2013-04-02 Thread Prabhakar lad
From: Lad, Prabhakar This patch series enables VPBE display driver on DM355. This patch series is dependent on VPSS clock cleanup patches (http://www.mail-archive.com/davinci-linux-open-source@linux.davincidsp.com/msg25613.html) posted. Changes for v7: 1: Fixed nits pointed by Sekhar for DM365

[PATCH v7 1/2] ARM: davinci: dm355: add support for v4l2 video display

2013-04-02 Thread Prabhakar lad
From: Lad, Prabhakar Create platform devices for various video modules like venc,osd, vpbe and v4l2 driver for dm355. Signed-off-by: Lad, Prabhakar --- arch/arm/mach-davinci/board-dm355-evm.c |4 +- arch/arm/mach-davinci/davinci.h |3 +- arch/arm/mach-davinci/dm355.c

[PATCH v7 2/2] ARM: davinci: dm355 EVM: add support for VPBE display

2013-04-02 Thread Prabhakar lad
From: Lad, Prabhakar add support for V4L2 video display to DM355 EVM. Support for SD modes is provided, along with Composite output Signed-off-by: Lad, Prabhakar --- arch/arm/mach-davinci/board-dm355-evm.c | 69 ++- 1 files changed, 68 insertions(+), 1

[PATCH v3] davinci: vpif: add pm_runtime support

2013-04-02 Thread Prabhakar lad
From: Lad, Prabhakar Add pm_runtime support to the TI Davinci VPIF driver. Signed-off-by: Lad, Prabhakar Cc: Mauro Carvalho Chehab Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Sakari Ailus Cc: Sekhar Nori --- Changes for v3: 1: Removed pm_runtime_resume() from probe as pm_runtime_get()

Re: [PATCH v8 1/2] ARM: davinci: dm365: add support for v4l2 video display

2013-04-07 Thread Prabhakar Lad
Sekhar, On Thu, Apr 4, 2013 at 3:03 PM, Sekhar Nori wrote: > On 4/2/2013 5:24 PM, Prabhakar lad wrote: >> From: Lad, Prabhakar >> >> Create platform devices for various video modules like venc,osd, >> vpbe and v4l2 driver for dm365. >> >> Signed-off-b

[PATCH v9 0/2] ARM: davinci: add support for dm365 vpbe display

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar This patch series enables VPBE display driver on DM365. Changes for v9: 1: Removed extra line after break's and defines as pointed by Sekhar. 2: Included Ack's from Sekhar. Changes for v8: 1: Fixed nits pointed by Sekhar. Changes for v7: 1: Fixed nits pointed by

[PATCH v9 1/2] ARM: davinci: dm365: add support for v4l2 video display

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar Create platform devices for various video modules like venc,osd, vpbe and v4l2 driver for dm365. Signed-off-by: Lad, Prabhakar Acked-by: Sekhar Nori --- arch/arm/mach-davinci/board-dm365-evm.c |4 +- arch/arm/mach-davinci/davinci.h |7 +-

[PATCH v9 2/2] ARM: davinci: dm365 EVM: add support for VPBE display

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar add support for V4L2 video display to DM365 EVM. Support for SD and ED modes is provided, along with Composite and Component outputs. Signed-off-by: Lad, Prabhakar Acked-by: Sekhar Nori --- arch/arm/mach-davinci/board-dm365-evm.c | 164 ++- 1

[PATCH v8 0/2] ARM: davinci: dm355: add support for vpbe display

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar This patch series enables VPBE display driver on DM355. This patch series is dependent on VPSS clock cleanup patches (http://www.mail-archive.com/davinci-linux-open-source@linux.davincidsp.com/msg25613.html) posted. Changes for v8: 1: Removed extra line after break's and

[PATCH v8 1/2] ARM: davinci: dm355: add support for v4l2 video display

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar Create platform devices for various video modules like venc,osd, vpbe and v4l2 driver for dm355. Signed-off-by: Lad, Prabhakar --- arch/arm/mach-davinci/board-dm355-evm.c |4 +- arch/arm/mach-davinci/davinci.h |3 +- arch/arm/mach-davinci/dm355.c

[PATCH v8 2/2] ARM: davinci: dm355 EVM: add support for VPBE display

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar add support for V4L2 video display to DM355 EVM. Support for SD modes is provided, along with Composite output Signed-off-by: Lad, Prabhakar Acked-by: Sekhar Nori --- arch/arm/mach-davinci/board-dm355-evm.c | 69 ++- 1 files changed, 68

Re: [PATCH v2 1/3] media: davinci: vpss: enable vpss clocks

2013-04-08 Thread Prabhakar Lad
Sekhar, On Mon, Apr 8, 2013 at 3:56 PM, Sekhar Nori wrote: > On 4/2/2013 5:14 PM, Prabhakar lad wrote: >> From: Lad, Prabhakar >> >> By default the VPSS clocks were enabled in capture driver >> for davinci family which creates duplicates for dm355/dm365/dm644x.

[PATCH v3 0/3] davinci: vpss: clock cleanup

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar This patch series cleanup's the VPSS clock enabling. The first patch removes vpss clock enabling from the capture drivers and moves it to the VPSS driver itself. The second patch moves the venc_enable_vpss_clock() to the driver which was being done in platform code. Changes

[PATCH v3 1/3] media: davinci: vpss: enable vpss clocks

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar By default the VPSS clocks were enabled in capture driver for davinci family which creates duplicates for dm355/dm365/dm644x. This patch adds support to enable the VPSS clocks in VPSS driver, which avoids duplication of code and also adding clock aliases. This patch uses PM

[PATCH v3 2/3] media: davinci: vpbe: venc: move the enabling of vpss clocks to driver

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar The vpss clocks were enabled by calling a exported function from a driver in a machine code. calling driver code from platform code is incorrect way. This patch fixes this issue and calls the function from driver code itself. Signed-off-by: Lad, Prabhakar ---

[PATCH v3 3/3] davinic: vpss: trivial cleanup

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar this patch removes unnecessary header file inclusions and fixes the typo's. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpss.c | 11 +++ 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/davinci/vpss.c

Re: [PATCH v3 2/3] media: davinci: vpbe: venc: move the enabling of vpss clocks to driver

2013-04-09 Thread Prabhakar Lad
On Tue, Apr 9, 2013 at 3:27 PM, Sekhar Nori wrote: > > > On 4/8/2013 5:49 PM, Prabhakar lad wrote: >> From: Lad, Prabhakar >> >> The vpss clocks were enabled by calling a exported function from a driver >> in a machine code. calling driver code fr

Re: [PATCH v9 1/2] ARM: davinci: dm365: add support for v4l2 video display

2013-04-09 Thread Prabhakar Lad
Sekhar, On Tue, Apr 9, 2013 at 5:18 PM, Sekhar Nori wrote: > On 4/8/2013 2:47 PM, Prabhakar lad wrote: >> From: Lad, Prabhakar >> >> Create platform devices for various video modules like venc,osd, >> vpbe and v4l2 driver for dm365. >> >> Signed-off-by: L

Re: [BUG] mod/file2alias: build error in devicetable-offsets.c [was: asm/types.h Header file wont get generated while building uImage ?]

2013-04-09 Thread Prabhakar Lad
Hi Andreas On Sun, Mar 31, 2013 at 1:16 AM, Andreas Schwab wrote: > "Jon Medhurst (Tixy)" writes: > >> For builds which succeed I see this order: >> >> WRAParch/arm/include/generated/asm/types.h >> [...] >> GEN include/generated/asm-offsets.h >> >> and for those which fail: >> >>

Re: [PATCH] kbuild: generate generic headers before recursing into scripts

2013-04-09 Thread Prabhakar Lad
d, Prabhakar Regards, --Prabhakar > --- > Prabhakar Lad writes: > >> Whats the status of it ? > > I think it has sufficiently been tested by now. > > Andreas. > --- > Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Make

[PATCH] pinctrl: pinctrl-single: add missing double quote

2013-04-10 Thread Prabhakar lad
From: Lad, Prabhakar add a missing double quote for compatible property for pmx_wkup. Signed-off-by: Lad, Prabhakar Cc: Grant Likely Cc: Rob Herring Cc: Rob Landley Cc: Tony Lindgren Cc: Linus Walleij Cc: Peter Ujfalusi Cc: devicetree-disc...@lists.ozlabs.org Cc:

[PATCH 0/5] Davinci VPBE use devres and some cleanup

2013-07-13 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch series replaces existing resource handling in the driver with managed device resource. Lad, Prabhakar (5): media: davinci: vpbe_venc: convert to devm_* api media: davinci: vpbe_osd: convert to devm_* api media: davinci: vpbe_display: convert to devm* api

[PATCH 2/5] media: davinci: vpbe_osd: convert to devm_* api

2013-07-13 Thread Prabhakar Lad
From: "Lad, Prabhakar" Replace existing resource handling in the driver with managed device resource, this ensures more consistent error values and simplifies error paths. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpbe_osd.c | 45 +++-- 1 file

[PATCH 1/5] media: davinci: vpbe_venc: convert to devm_* api

2013-07-13 Thread Prabhakar Lad
From: "Lad, Prabhakar" Replace existing resource handling in the driver with managed device resource, this ensures more consistent error values and simplifies error paths. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpbe_venc.c | 97 ++-- 1 file

[PATCH 3/5] media: davinci: vpbe_display: convert to devm* api

2013-07-13 Thread Prabhakar Lad
From: "Lad, Prabhakar" Replace existing resource handling in the driver with managed device resource, this ensures more consistent error values and simplifies error paths. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpbe_display.c | 23 +++ 1 file

[PATCH 4/5] media: davinci: vpss: convert to devm* api

2013-07-13 Thread Prabhakar Lad
From: "Lad, Prabhakar" Replace existing resource handling in the driver with managed device resource, this ensures more consistent error values and simplifies error paths. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpss.c | 62 +++-- 1 file

[PATCH 5/5] media: davinci: vpbe: Replace printk with dev_*

2013-07-13 Thread Prabhakar Lad
From: "Lad, Prabhakar" Use the dev_* message logging API instead of raw printk. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpbe.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/davinci/vpbe.c

[PATCH v2] media: i2c: adv7343: add OF support

2013-07-13 Thread Prabhakar Lad
From: "Lad, Prabhakar" add OF support for the adv7343 driver. Signed-off-by: Lad, Prabhakar --- Changes for v2: 1: Fixed naming of properties. .../devicetree/bindings/media/i2c/adv7343.txt | 54 drivers/media/i2c/adv7343.c| 65

Re: [PATCH v2] media: i2c: adv7343: add OF support

2013-07-15 Thread Prabhakar Lad
Hi Sylwester, Thanks for the review. On Mon, Jul 15, 2013 at 2:03 AM, Sylwester Nawrocki wrote: > Hi Prabhakar, > > > On 07/13/2013 01:12 PM, Prabhakar Lad wrote: >> >> From: "Lad, Prabhakar" >> >> add OF support for the adv7343 driver. >>

Re: [PATCH v2 2/2] media: i2c: tvp7002: add OF support

2013-07-15 Thread Prabhakar Lad
e it in v4l2_of_parse_parallel_bus() and add it as part of flags. and define the following flags in mediabus.h V4L2_MBUS_VIDEO_SOG_ACTIVE_{HIGH,LOW}. Hope you are OK with it. -- Regards, Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

[PATCH RFC v4] media: OF: add "sync-on-green-active" property

2013-07-16 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch adds 'sync-on-green-active' property as part of endpoint property. Signed-off-by: Lad, Prabhakar --- Changes for v4: 1: Fixed review comments pointed by Sylwester. Changes for v3: 1: Fixed review comments pointed by Laurent and Sylwester. RFC v2

Re: [PATCH RFC v4] media: OF: add "sync-on-green-active" property

2013-07-17 Thread Prabhakar Lad
; + or inverted operation. > > > Would you mind adding this entry after pclk-sample property description ? OK. > And how about describing it a bit more precisely and similarly to > VSYNC/HSYNC, > e.g. > > - sync-on-green-active: active state of Sync-on-green (SoG) signal, > 0

[PATCH RFC FINAL v5] media: OF: add "sync-on-green-active" property

2013-07-17 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch adds 'sync-on-green-active' property as part of endpoint property. Signed-off-by: Lad, Prabhakar --- Changes for v5: 1: Changed description for sync-on-green-active property in documentation file as suggested by Sylwester. Changes for v4: 1:

[PATCH v3] media: i2c: tvp7002: add OF support

2013-07-17 Thread Prabhakar Lad
From: "Lad, Prabhakar" add OF support for the tvp7002 driver. Signed-off-by: Lad, Prabhakar --- This patch depends on https://patchwork.kernel.org/patch/2828800/ Changes for v3: 1: Fixed review comments pointed by Sylwester. .../devicetree/bindings/media/i2c/tvp7002.txt | 43

Re: [PATCH RFC FINAL v5] media: OF: add "sync-on-green-active" property

2013-07-17 Thread Prabhakar Lad
Hi Sylwester, On Wed, Jul 17, 2013 at 9:50 PM, Sylwester Nawrocki wrote: > On 07/17/2013 05:47 PM, Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> This patch adds 'sync-on-green-active' property as part >> of endpoint property. >> >> Si

Re: [PATCH 0/5] Davinci VPBE use devres and some cleanup

2013-07-17 Thread Prabhakar Lad
Hi Laurent, On Wed, Jul 17, 2013 at 5:51 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > On Saturday 13 July 2013 14:20:26 Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> This patch series replaces existing resource handling in the >> driver

Re: [PATCH v3] media: i2c: tvp7002: add OF support

2013-07-17 Thread Prabhakar Lad
Hi Sylwester, Thanks for the quick review. On Wed, Jul 17, 2013 at 10:09 PM, Sylwester Nawrocki wrote: > On 07/17/2013 06:20 PM, Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> add OF support for the tvp7002 driver. >> >> Signed-off-by: La

Re: [PATCH v4 4/5] ARM: davinci: da850: add DT node for eth0.

2013-08-15 Thread Prabhakar Lad
}; >> + eth0: emac@1e2 { > > >According to the ePAPR spec[1] section 2.2.2, the node should be named > "ethernet". > Thanks for pointing it, I'll fix and repost it. Regards, --Prabhakar Lad > [1] http://www.power.org/resources/downloads/Powe

Re: [PATCH v4 5/5] ARM: davinci: da850: add OF_DEV_AUXDATA entry for eth0.

2013-08-15 Thread Prabhakar Lad
250.2", NULL), >> OF_DEV_AUXDATA("ti,davinci_mdio", 0x01e24000, "davinci_mdio.0", >> NULL), >> + OF_DEV_AUXDATA("ti,davinci-dm6467-emac", 0x01e2, >> "davinci_emac.1", >> + NULL), >> + >

Re: [PATCH v3 7/7] net: davinci_mdio: use platform_{get,set}_drvdata()

2013-08-16 Thread Prabhakar Lad
en Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH V3 1/2] tps6507x-ts: Add DT support

2013-08-20 Thread Prabhakar Lad
goto error_ret; > + > + err = of_property_read_u16(node, "ti,vendor", > + _dev->id.vendor); > + if (err < 0) > + goto error_ret; > + > +

Re: [PATCH v2 0/4] GPIO DT support for da850

2013-08-11 Thread Prabhakar Lad
; > This patch series has dependency on [PATCH v2 0/7] Convert GPIO Davinci to > platform driver > > https://lkml.org/lkml/2013/6/14/120 > What is the status of this patch series is any one taking care of it or else I can take care of review comments and repost them. Regards, --Prabhakar

Re: [PATCH v5] media: i2c: tvp7002: add OF support

2013-08-12 Thread Prabhakar Lad
uld keep it as is, let me know if you still want me to change. >> + >> +- field-even-active: Active-high Field ID output polarity control of the >> bus. >> + Under normal operation, the field ID output is set to logic 1 for an odd >> field >> + (field 1)

Re: [PATCH v3 2/2] media: i2c: adv7343: add OF support

2013-08-27 Thread Prabhakar Lad
Hi Mark, On Tue, Aug 27, 2013 at 8:54 PM, Mark Rutland wrote: > [fixing up devicetree list address] > Thanks! > On Mon, Aug 26, 2013 at 03:41:45AM +0100, Prabhakar Lad wrote: >> Hi Sylwester, >> >> On Fri, Aug 23, 2013 at 11:33 PM, Sylwester Nawrocki >> wrote

Re: [PATCH v3 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac

2013-08-08 Thread Prabhakar Lad
Hi Sekhar, Sorry for the delayed response I was on leave and now back again up and running. On Wed, Jul 31, 2013 at 11:17 AM, Sekhar Nori wrote: > On Sunday 23 June 2013 08:30 PM, Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> This patch makes a common

Re: [PATCH v3 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac

2013-08-08 Thread Prabhakar Lad
On Thu, Aug 8, 2013 at 9:35 PM, Sekhar Nori wrote: > On Thursday 08 August 2013 04:02 PM, Prabhakar Lad wrote: >> Hi Sekhar, >> >> Sorry for the delayed response I was on leave and now back again up >> and running. >> >> On Wed, Jul 31, 2013 at 11:17 AM, Se

Re: [PATCH v4] media: i2c: tvp7002: add OF support

2013-07-26 Thread Prabhakar Lad
ive state of Sync-on-green signal property of the >> + endpoint. >> + 0 = Normal Operation (Default) > > I would extend this a little bit: > > 0 = Normal Operation (Active Low, Default) > Ok. >> + 1 = Inverted operation >> + >> +- field-even-active: Acti

Re: [PATCH RFC FINAL v5] media: OF: add "sync-on-green-active" property

2013-07-26 Thread Prabhakar Lad
Hi Hans, Thanks for the review. On Fri, Jul 26, 2013 at 3:27 PM, Hans Verkuil wrote: > Hi Prabhakar, > > On 07/17/2013 05:47 PM, Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> This patch adds 'sync-on-green-active' property as part >> of

[PATCH 0/2] media: i2c: ths8200: Feature enhancement

2013-06-22 Thread Prabhakar Lad
From: "Lad, Prabhakar" The first patch of the series adds supports for asynchronous subdev registration for ths8200 driver, and the second patch of the series adds OF support the driver. Lad, Prabhakar (2): media: i2c: ths8200: support asynchronous probing media: i2c: ths8200: add OF

[PATCH 1/2] media: i2c: ths8200: support asynchronous probing

2013-06-22 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch supports both synchronous and asynchronous ths8200 subdevice probing. Signed-off-by: Lad, Prabhakar --- drivers/media/i2c/ths8200.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ths8200.c

[PATCH 2/2] media: i2c: ths8200: add OF support

2013-06-22 Thread Prabhakar Lad
From: "Lad, Prabhakar" add OF support for the ths8200 driver. Signed-off-by: Lad, Prabhakar --- .../devicetree/bindings/media/i2c/ths8200.txt | 19 +++ drivers/media/i2c/ths8200.c|9 + 2 files changed, 28 insertions(+) create mode

<    2   3   4   5   6   7   8   9   10   11   >