[PATCH v2 08/10] ARM: dts: add dtsi for AXP813 PMIC

2017-09-26 Thread Quentin Schulz
From: Maxime Ripard The AXP813 PMIC is used with some Allwinner SoCs. Create a dtsi to include in each board embedding it. Signed-off-by: Quentin Schulz --- arch/arm/boot/dts/axp813.dtsi | 58 - 1 file changed, 58 insertions(+) create mode 100644 arch/arm

[PATCH v2 05/10] pinctrl: axp209: add programmable gpio_status_offset

2017-09-26 Thread Quentin Schulz
To prepare for patches that will add support for a new PMIC that has a different GPIO input status register, add a gpio_status_offset within axp20x_pctl structure and use it. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> --- drivers/pinctrl/pinctrl-axp209.c | 4 +++-

[PATCH v2 05/10] pinctrl: axp209: add programmable gpio_status_offset

2017-09-26 Thread Quentin Schulz
To prepare for patches that will add support for a new PMIC that has a different GPIO input status register, add a gpio_status_offset within axp20x_pctl structure and use it. Signed-off-by: Quentin Schulz --- drivers/pinctrl/pinctrl-axp209.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

[PATCH v2 09/10] ARM: dts: sun8i: a711: include axp813 dtsi

2017-09-26 Thread Quentin Schulz
This board has an AXP813 PMIC so let's include its dtsi. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> --- arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8

[PATCH v2 09/10] ARM: dts: sun8i: a711: include axp813 dtsi

2017-09-26 Thread Quentin Schulz
This board has an AXP813 PMIC so let's include its dtsi. Signed-off-by: Quentin Schulz --- arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts index 723641f

[PATCH v2 07/10] mfd: axp20x: add pinctrl cell for AXP813

2017-09-26 Thread Quentin Schulz
As pinctrl and GPIO driver now supports AXP813, add a cell for it. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> --- drivers/mfd/axp20x.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c index 336de66..a457528

[PATCH v2 07/10] mfd: axp20x: add pinctrl cell for AXP813

2017-09-26 Thread Quentin Schulz
As pinctrl and GPIO driver now supports AXP813, add a cell for it. Signed-off-by: Quentin Schulz --- drivers/mfd/axp20x.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c index 336de66..a457528 100644 --- a/drivers/mfd/axp20x.c +++ b/drivers/mfd

[PATCH v2 06/10] pinctrl: axp209: add support for AXP813 GPIOs

2017-09-26 Thread Quentin Schulz
The AXP813 has only two GPIOs. GPIO0 can either be used as a GPIO, an LDO regulator or an ADC. GPIO1 can be used either as a GPIO or an LDO regulator. Moreover, the status bit of the GPIOs when in input mode is not offset by 4 unlike the AXP209. Signed-off-by: Quentin Schulz <quentin.sch...@f

[PATCH v2 06/10] pinctrl: axp209: add support for AXP813 GPIOs

2017-09-26 Thread Quentin Schulz
The AXP813 has only two GPIOs. GPIO0 can either be used as a GPIO, an LDO regulator or an ADC. GPIO1 can be used either as a GPIO or an LDO regulator. Moreover, the status bit of the GPIOs when in input mode is not offset by 4 unlike the AXP209. Signed-off-by: Quentin Schulz --- Documentation

[PATCH v2 01/10] pinctrl: move gpio-axp209 to pinctrl

2017-09-26 Thread Quentin Schulz
To prepare the driver for the upcoming pinctrl features, move the GPIO driver AXP209 from GPIO to pinctrl subsystem. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> --- Documentation/devicetree/bindings/gpio/gpio-axp209.txt | 30 +- Documentation/devicetree/bi

[PATCH v2 01/10] pinctrl: move gpio-axp209 to pinctrl

2017-09-26 Thread Quentin Schulz
To prepare the driver for the upcoming pinctrl features, move the GPIO driver AXP209 from GPIO to pinctrl subsystem. Signed-off-by: Quentin Schulz --- Documentation/devicetree/bindings/gpio/gpio-axp209.txt | 30 +- Documentation/devicetree/bindings/pinctrl/pinctrl-axp209.txt | 30

Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI

2017-09-25 Thread Quentin Schulz
Hi Icenowy, On 25/09/2017 11:14, Icenowy Zheng wrote: > > > 于 2017年9月25日 GMT+08:00 下午5:11:57, Quentin Schulz > <quentin.sch...@free-electrons.com> 写到: >> Hi Icenowy, >> >> On 20/09/2017 17:18, Icenowy Zheng wrote: >>> AXP803 PMIC features AC/USB/B

Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI

2017-09-25 Thread Quentin Schulz
Hi Icenowy, On 25/09/2017 11:14, Icenowy Zheng wrote: > > > 于 2017年9月25日 GMT+08:00 下午5:11:57, Quentin Schulz > 写到: >> Hi Icenowy, >> >> On 20/09/2017 17:18, Icenowy Zheng wrote: >>> AXP803 PMIC features AC/USB/Battery power supplies. >>> >

Re: [RFC PATCH 0/7] AXP803 AC/Battery support

2017-09-25 Thread Quentin Schulz
| 11 ++ >>>> drivers/power/supply/axp20x_battery.c | 88 >>> ++-- >>>> 7 files changed, 226 insertions(+), 12 deletions(-) >>>> >>> >>> >>> ___ >>> linux-arm-kernel mailing list >>> linux-arm-ker...@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > ___ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

Re: [RFC PATCH 0/7] AXP803 AC/Battery support

2017-09-25 Thread Quentin Schulz
+-- >>>> 7 files changed, 226 insertions(+), 12 deletions(-) >>>> >>> >>> >>> ___ >>> linux-arm-kernel mailing list >>> linux-arm-ker...@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > ___ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

Re: [RFC PATCH 1/7] dt-bindings: add compatibles for AXP803 Battery/USB power supplies

2017-09-25 Thread Quentin Schulz
"x-powers,axp223-usb-power-supply" > + "x-powers,axp803-usb-power-supply" No. You are adding support for AC and battery power supply in this patchset, not for USB. Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

Re: [RFC PATCH 1/7] dt-bindings: add compatibles for AXP803 Battery/USB power supplies

2017-09-25 Thread Quentin Schulz
er-supply" > + "x-powers,axp803-usb-power-supply" No. You are adding support for AC and battery power supply in this patchset, not for USB. Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI

2017-09-25 Thread Quentin Schulz
t; + compatible = "x-powers,axp803-usb-power-supply"; > + status = "disabled"; > + }; No. You have added support for the AC and battery power supply drivers in this patchset, not for USB. Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI

2017-09-25 Thread Quentin Schulz
ible = "x-powers,axp803-usb-power-supply"; > + status = "disabled"; > + }; No. You have added support for the AC and battery power supply drivers in this patchset, not for USB. Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

Re: [RFC PATCH 4/7] power: supply: axp20x-battery: support AXP803

2017-09-25 Thread Quentin Schulz
case AXP221_ID: > + case AXP803_ID: > + if (!(reg & AXP22X_FG_VALID)) > + return -EINVAL; > + break; > + }; Looks weird to me. if (axp20x_batt->axp_id != AXP209_ID && !(reg & AXP22X_FG_VALID)) would be a better match? [...] Thanks, Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

Re: [RFC PATCH 4/7] power: supply: axp20x-battery: support AXP803

2017-09-25 Thread Quentin Schulz
> + case AXP803_ID: > + if (!(reg & AXP22X_FG_VALID)) > + return -EINVAL; > + break; > + }; Looks weird to me. if (axp20x_batt->axp_id != AXP209_ID && !(reg & AXP22X_FG_VALID)) would be a better match? [...] Thanks, Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

Re: [RFC PATCH 3/7] iio: adc: axp20x-adc: add support for AXP803

2017-09-25 Thread Quentin Schulz
t; > +static const struct axp_data axp803_data = { > + .iio_info = _adc_iio_info, > + .num_channels = ARRAY_SIZE(axp803_adc_channels), > + .channels = axp803_adc_channels, > + .adc_en1_mask = AXP803_ADC_EN1_MASK, > + .adc_en2 = false, Not required I guess, by default

Re: [RFC PATCH 3/7] iio: adc: axp20x-adc: add support for AXP803

2017-09-25 Thread Quentin Schulz
axp_data axp803_data = { > + .iio_info = _adc_iio_info, > + .num_channels = ARRAY_SIZE(axp803_adc_channels), > + .channels = axp803_adc_channels, > + .adc_en1_mask = AXP803_ADC_EN1_MASK, > + .adc_en2 = false, Not required I guess, by default it is false. Than

Re: [RFC PATCH 2/7] iio: adc: axp20x-adc: allow to skip ADC rate setup now

2017-09-25 Thread Quentin Schulz
; -info->data->adc_rate(100)); > + if (info->data->adc_rate) > + regmap_update_bits(info->regmap, AXP20X_ADC_RATE, > +AXP20X_ADC_RATE_MASK, > +info->data->adc_rate(100)); &g

Re: [RFC PATCH 2/7] iio: adc: axp20x-adc: allow to skip ADC rate setup now

2017-09-25 Thread Quentin Schulz
info->data->adc_rate(100)); > + if (info->data->adc_rate) > + regmap_update_bits(info->regmap, AXP20X_ADC_RATE, > +AXP20X_ADC_RATE_MASK, > +info->data->adc_rate(100)); > > ret = iio_map_a

Re: [PATCH v4 4/6] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor

2017-09-16 Thread Quentin Schulz
Hi Icenowy, On 16/09/2017 12:14, icen...@aosc.io wrote: > 在 2017-09-16 17:45,Quentin Schulz 写道: >> Hi Icenowy, >> >> On 14/09/2017 16:52, Icenowy Zheng wrote: >>> This adds support for the Allwinner H3 thermal sensor. >>> >>> Allwinner H3 has a

Re: [PATCH v4 4/6] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor

2017-09-16 Thread Quentin Schulz
Hi Icenowy, On 16/09/2017 12:14, icen...@aosc.io wrote: > 在 2017-09-16 17:45,Quentin Schulz 写道: >> Hi Icenowy, >> >> On 14/09/2017 16:52, Icenowy Zheng wrote: >>> This adds support for the Allwinner H3 thermal sensor. >>> >>> Allwinner H3 has a

Re: [PATCH v4 6/6] ARM: sun8i: h3: add partial CPU thermal zone

2017-09-16 Thread Quentin Schulz
polling-delay-passive = <250>; > + polling-delay = <1000>; > + thermal-sensors = <>; > + }; > + }; > + > timer { > compatible = "arm,armv7-timer"; >

Re: [PATCH v4 6/6] ARM: sun8i: h3: add partial CPU thermal zone

2017-09-16 Thread Quentin Schulz
olling-delay-passive = <250>; > + polling-delay = <1000>; > + thermal-sensors = <>; > + }; > + }; > + > timer { > compatible = "arm,armv7-timer"; > interrupts = IRQ_TYPE_LEVEL_LOW)>, > -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

Re: [PATCH v4 4/6] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor

2017-09-16 Thread Quentin Schulz
utdown your board? The H3 apparently supports IRQs, why do you not support them for the temperature? They might be broken as it is on A33 but then it might be a good idea to write it down in a comment in the driver (and not adding the unused registers in the header file) or at least in the commit log. 3) Now that you have support for clocks, wouldn't it be a good idea to disable them during suspend? Thanks, Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

Re: [PATCH v4 4/6] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor

2017-09-16 Thread Quentin Schulz
apparently supports IRQs, why do you not support them for the temperature? They might be broken as it is on A33 but then it might be a good idea to write it down in a comment in the driver (and not adding the unused registers in the header file) or at least in the commit log. 3) Now that you have support for clocks, wouldn't it be a good idea to disable them during suspend? Thanks, Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

[PATCH v5 4/7] clk: at91: clk-generated: create function to find best_diff

2017-08-10 Thread Quentin Schulz
The way to find the best_diff and do the appropriate process afterwards can be re-used. This patch prepares the driver for an upcoming patch that will allow clk_generated to determine the rate of the audio_pll. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> Acked-by:

[PATCH v5 4/7] clk: at91: clk-generated: create function to find best_diff

2017-08-10 Thread Quentin Schulz
The way to find the best_diff and do the appropriate process afterwards can be re-used. This patch prepares the driver for an upcoming patch that will allow clk_generated to determine the rate of the audio_pll. Signed-off-by: Quentin Schulz Acked-by: Boris Brezillon Acked-by: Nicolas Ferre

[PATCH v5 7/7] ASoC: atmel-classd: remove aclk clock

2017-08-10 Thread Quentin Schulz
-by: Quentin Schulz <quentin.sch...@free-electrons.com> Acked-by: Mark Brown <broo...@kernel.org> Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com> --- sound/soc/atmel/atmel-classd.c | 47 ++- 1 file changed, 14 insertions(+), 33 deletions(-) diff

[PATCH v5 7/7] ASoC: atmel-classd: remove aclk clock

2017-08-10 Thread Quentin Schulz
-by: Quentin Schulz Acked-by: Mark Brown Acked-by: Nicolas Ferre --- sound/soc/atmel/atmel-classd.c | 47 ++- 1 file changed, 14 insertions(+), 33 deletions(-) diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/atmel-classd.c index b7ef8c5..be6b775 100644

[PATCH v5 3/7] clk: at91: add audio pll clock drivers

2017-08-10 Thread Quentin Schulz
ed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> Acked-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- arch/arm/mach-at91/Kconfig | 4 +- drivers/clk/at91/Makefile| 1 +- drivers/clk/at91/clk-audio-pll.c | 536 -

[PATCH v5 3/7] clk: at91: add audio pll clock drivers

2017-08-10 Thread Quentin Schulz
have different enable bits and different dividers and divider formulas, they are handled by two different drivers. Each of them could modify the rate of the main audio pll parent. The main audio pll clock can output 620MHz to 700MHz. Signed-off-by: Nicolas Ferre Signed-off-by: Quentin Schulz Acked

[PATCH v5 5/7] clk: at91: clk-generated: make gclk determine audio_pll rate

2017-08-10 Thread Quentin Schulz
of the clock. Since audio IPs are most likely to request the same rate, we enforce that the only clks able to modify gck rate are those of audio IPs. To remain consistent, we deny other clocks to be children of audio_pll. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com>

[PATCH v5 5/7] clk: at91: clk-generated: make gclk determine audio_pll rate

2017-08-10 Thread Quentin Schulz
of the clock. Since audio IPs are most likely to request the same rate, we enforce that the only clks able to modify gck rate are those of audio IPs. To remain consistent, we deny other clocks to be children of audio_pll. Signed-off-by: Quentin Schulz Acked-by: Boris Brezillon Acked-by: Nicolas

[PATCH v5 0/7] add support for Sama5d2 audio PLLs and enable ClassD

2017-08-10 Thread Quentin Schulz
/msg436120.html [5] http://www.spinics.net/lists/linux-clk/msg17927.html Quentin Schulz (7): clk: at91: clk-generated: remove useless divisor loop dt-bindings: clk: at91: add audio plls to the compatible list clk: at91: add audio pll clock drivers clk: at91: clk-generated: create function to find

[PATCH v5 6/7] ASoC: atmel-classd: remove aclk clock from DT binding

2017-08-10 Thread Quentin Schulz
Since gclk (generated-clk) is now able to determine the rate of the audio_pll, there is no need for classd to have a direct phandle to the audio_pll while already having a phandle to gclk. This binding is used by no board in mainline so it is safe to be modified. Signed-off-by: Quentin Schulz

[PATCH v5 1/7] clk: at91: clk-generated: remove useless divisor loop

2017-08-10 Thread Quentin Schulz
(passed along req argument of the function) and the parent clock rate, thus we know the closest rounded divisor, we don't need to iterate over the available divisors to find the best one for a given clock. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> Acked-by: Boris Bre

[PATCH v5 0/7] add support for Sama5d2 audio PLLs and enable ClassD

2017-08-10 Thread Quentin Schulz
/msg436120.html [5] http://www.spinics.net/lists/linux-clk/msg17927.html Quentin Schulz (7): clk: at91: clk-generated: remove useless divisor loop dt-bindings: clk: at91: add audio plls to the compatible list clk: at91: add audio pll clock drivers clk: at91: clk-generated: create function to find

[PATCH v5 6/7] ASoC: atmel-classd: remove aclk clock from DT binding

2017-08-10 Thread Quentin Schulz
Since gclk (generated-clk) is now able to determine the rate of the audio_pll, there is no need for classd to have a direct phandle to the audio_pll while already having a phandle to gclk. This binding is used by no board in mainline so it is safe to be modified. Signed-off-by: Quentin Schulz

[PATCH v5 1/7] clk: at91: clk-generated: remove useless divisor loop

2017-08-10 Thread Quentin Schulz
(passed along req argument of the function) and the parent clock rate, thus we know the closest rounded divisor, we don't need to iterate over the available divisors to find the best one for a given clock. Signed-off-by: Quentin Schulz Acked-by: Boris Brezillon Acked-by: Nicolas Ferre --- drivers

[PATCH v5 2/7] dt-bindings: clk: at91: add audio plls to the compatible list

2017-08-10 Thread Quentin Schulz
have different enable bits and different dividers and divider formulas, they are handled by two different drivers. This adds the audio plls (frac, pad and pmc) to the compatible list of at91 clocks in DT binding. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> Acked-by: Rob H

[PATCH v5 2/7] dt-bindings: clk: at91: add audio plls to the compatible list

2017-08-10 Thread Quentin Schulz
have different enable bits and different dividers and divider formulas, they are handled by two different drivers. This adds the audio plls (frac, pad and pmc) to the compatible list of at91 clocks in DT binding. Signed-off-by: Quentin Schulz Acked-by: Rob Herring Acked-by: Boris Brezillon Acked

[PATCH v3 0/2] add support for AXP22X/AXP288/AXP8XX PEK

2017-08-09 Thread Quentin Schulz
and their respective masks, - separate in different patches, - removed mfd patch to correct mfd cell name since Chen-Yu will take care of it in another patch series, Thanks, Quentin Quentin Schulz (2): Input: axp20x-pek: use driver_data of platform_device_id instead of extended attributes

[PATCH v3 0/2] add support for AXP22X/AXP288/AXP8XX PEK

2017-08-09 Thread Quentin Schulz
and their respective masks, - separate in different patches, - removed mfd patch to correct mfd cell name since Chen-Yu will take care of it in another patch series, Thanks, Quentin Quentin Schulz (2): Input: axp20x-pek: use driver_data of platform_device_id instead of extended attributes

[PATCH v3 1/2] Input: axp20x-pek: use driver_data of platform_device_id instead of extended attributes

2017-08-09 Thread Quentin Schulz
can be easily supported by just filling correctly its ax20x_info structure and adding a platform_device_id. Moreover, since we get rid of extended attributes, rename axp20x_store_ext_attr to axp20x_store_attr and axp20x_show_ext_attr to axp20x_show_attr. Signed-off-by: Quentin Schulz <quentin.

[PATCH v3 1/2] Input: axp20x-pek: use driver_data of platform_device_id instead of extended attributes

2017-08-09 Thread Quentin Schulz
can be easily supported by just filling correctly its ax20x_info structure and adding a platform_device_id. Moreover, since we get rid of extended attributes, rename axp20x_store_ext_attr to axp20x_store_attr and axp20x_show_ext_attr to axp20x_show_attr. Signed-off-by: Quentin Schulz --- drivers

[PATCH v3 2/2] Input: axp20x-pek: add support for AXP221 PEK

2017-08-09 Thread Quentin Schulz
The AXP221 has different values for startup time bits from the AXP20X. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> Reviewed-by: Chen-Yu Tsai <w...@csie.org> --- drivers/input/misc/axp20x-pek.c | 17 + 1 file changed, 17 insertions(+) diff --g

[PATCH v3 2/2] Input: axp20x-pek: add support for AXP221 PEK

2017-08-09 Thread Quentin Schulz
The AXP221 has different values for startup time bits from the AXP20X. Signed-off-by: Quentin Schulz Reviewed-by: Chen-Yu Tsai --- drivers/input/misc/axp20x-pek.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/input/misc/axp20x-pek.c b/drivers/input/misc/axp20x

Re: [PATCH v4 0/9] add support for Sama5d2 audio PLLs and enable ClassD

2017-07-26 Thread Quentin Schulz
Hi Alexandre, On 26/07/2017 08:57, Alexandre Belloni wrote: > On 25/07/2017 at 17:44:19 +0200, Nicolas Ferre wrote: >> On 25/07/2017 at 09:37, Quentin Schulz wrote: >>> This patch series adds support for the audio PLLs and enables ClassD that >>> can be

Re: [PATCH v4 0/9] add support for Sama5d2 audio PLLs and enable ClassD

2017-07-26 Thread Quentin Schulz
Hi Alexandre, On 26/07/2017 08:57, Alexandre Belloni wrote: > On 25/07/2017 at 17:44:19 +0200, Nicolas Ferre wrote: >> On 25/07/2017 at 09:37, Quentin Schulz wrote: >>> This patch series adds support for the audio PLLs and enables ClassD that >>> can be

Re: [PATCH v3 3/9] clk: at91: add audio pll clock drivers

2017-07-25 Thread Quentin Schulz
Hi Stephen, I forgot to answer one of your questions: On 22/07/2017 00:20, Stephen Boyd wrote: > On 07/13, Quentin Schulz wrote: >> diff --git a/drivers/clk/at91/clk-audio-pll-pad.c >> b/drivers/clk/at91/clk-audio-pll-pad.c >> new file mode 100644 >> index 000

Re: [PATCH v3 3/9] clk: at91: add audio pll clock drivers

2017-07-25 Thread Quentin Schulz
Hi Stephen, I forgot to answer one of your questions: On 22/07/2017 00:20, Stephen Boyd wrote: > On 07/13, Quentin Schulz wrote: >> diff --git a/drivers/clk/at91/clk-audio-pll-pad.c >> b/drivers/clk/at91/clk-audio-pll-pad.c >> new file mode 100644 >> index 000

[PATCH v4 0/9] add support for Sama5d2 audio PLLs and enable ClassD

2017-07-25 Thread Quentin Schulz
://patchwork.kernel.org/patch/9462349/ [4] https://www.spinics.net/lists/arm-kernel/msg436120.html [5] http://www.spinics.net/lists/linux-clk/msg17927.html Cyrille Pitchen (2): ARM: dts: at91: sama5d2: add classd nodes ARM: dts: at91: sama5d2_xplained: add pin muxing and enable classd Quentin Schulz (7): clk

[PATCH v4 0/9] add support for Sama5d2 audio PLLs and enable ClassD

2017-07-25 Thread Quentin Schulz
://patchwork.kernel.org/patch/9462349/ [4] https://www.spinics.net/lists/arm-kernel/msg436120.html [5] http://www.spinics.net/lists/linux-clk/msg17927.html Cyrille Pitchen (2): ARM: dts: at91: sama5d2: add classd nodes ARM: dts: at91: sama5d2_xplained: add pin muxing and enable classd Quentin Schulz (7): clk

[PATCH v4 2/9] dt-bindings: clk: at91: add audio plls to the compatible list

2017-07-25 Thread Quentin Schulz
have different enable bits and different dividers and divider formulas, they are handled by two different drivers. This adds the audio plls (frac, pad and pmc) to the compatible list of at91 clocks in DT binding. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> Acked-by: Rob H

[PATCH v4 2/9] dt-bindings: clk: at91: add audio plls to the compatible list

2017-07-25 Thread Quentin Schulz
have different enable bits and different dividers and divider formulas, they are handled by two different drivers. This adds the audio plls (frac, pad and pmc) to the compatible list of at91 clocks in DT binding. Signed-off-by: Quentin Schulz Acked-by: Rob Herring Acked-by: Boris Brezillon

[PATCH v4 4/9] ARM: dts: at91: sama5d2: add classd nodes

2017-07-25 Thread Quentin Schulz
From: Cyrille Pitchen <cyrille.pitc...@atmel.com> This patch adds nodes for the classd device and its generated clock. Signed-off-by: Cyrille Pitchen <cyrille.pitc...@atmel.com> Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> Signed-off-by: Quentin Schulz &l

[PATCH v4 1/9] clk: at91: clk-generated: remove useless divisor loop

2017-07-25 Thread Quentin Schulz
(passed along req argument of the function) and the parent clock rate, thus we know the closest rounded divisor, we don't need to iterate over the available divisors to find the best one for a given clock. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> Acked-by: Boris Bre

[PATCH v4 4/9] ARM: dts: at91: sama5d2: add classd nodes

2017-07-25 Thread Quentin Schulz
From: Cyrille Pitchen This patch adds nodes for the classd device and its generated clock. Signed-off-by: Cyrille Pitchen Signed-off-by: Nicolas Ferre Signed-off-by: Quentin Schulz --- arch/arm/boot/dts/sama5d2.dtsi | 39 ++- 1 file changed, 38 insertions

[PATCH v4 1/9] clk: at91: clk-generated: remove useless divisor loop

2017-07-25 Thread Quentin Schulz
(passed along req argument of the function) and the parent clock rate, thus we know the closest rounded divisor, we don't need to iterate over the available divisors to find the best one for a given clock. Signed-off-by: Quentin Schulz Acked-by: Boris Brezillon --- drivers/clk/at91/clk-generated.c

[PATCH v4 6/9] clk: at91: clk-generated: make gclk determine audio_pll rate

2017-07-25 Thread Quentin Schulz
of the clock. Since audio IPs are most likely to request the same rate, we enforce that the only clks able to modify gck rate are those of audio IPs. To remain consistent, we deny other clocks to be children of audio_pll. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com>

[PATCH v4 6/9] clk: at91: clk-generated: make gclk determine audio_pll rate

2017-07-25 Thread Quentin Schulz
of the clock. Since audio IPs are most likely to request the same rate, we enforce that the only clks able to modify gck rate are those of audio IPs. To remain consistent, we deny other clocks to be children of audio_pll. Signed-off-by: Quentin Schulz Acked-by: Boris Brezillon --- drivers/clk

[PATCH v4 7/9] ASoC: atmel-classd: remove aclk clock from DT binding

2017-07-25 Thread Quentin Schulz
Since gclk (generated-clk) is now able to determine the rate of the audio_pll, there is no need for classd to have a direct phandle to the audio_pll while already having a phandle to gclk. This binding is used by no board in mainline so it is safe to be modified. Signed-off-by: Quentin Schulz

[PATCH v4 7/9] ASoC: atmel-classd: remove aclk clock from DT binding

2017-07-25 Thread Quentin Schulz
Since gclk (generated-clk) is now able to determine the rate of the audio_pll, there is no need for classd to have a direct phandle to the audio_pll while already having a phandle to gclk. This binding is used by no board in mainline so it is safe to be modified. Signed-off-by: Quentin Schulz

[PATCH v4 8/9] ASoC: atmel-classd: remove aclk clock

2017-07-25 Thread Quentin Schulz
-by: Quentin Schulz <quentin.sch...@free-electrons.com> Acked-by: Mark Brown <broo...@kernel.org> --- sound/soc/atmel/atmel-classd.c | 47 ++- 1 file changed, 14 insertions(+), 33 deletions(-) diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/at

[PATCH v4 8/9] ASoC: atmel-classd: remove aclk clock

2017-07-25 Thread Quentin Schulz
-by: Quentin Schulz Acked-by: Mark Brown --- sound/soc/atmel/atmel-classd.c | 47 ++- 1 file changed, 14 insertions(+), 33 deletions(-) diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/atmel-classd.c index b7ef8c5..be6b775 100644 --- a/sound/soc/atmel/atmel

[PATCH v4 5/9] clk: at91: clk-generated: create function to find best_diff

2017-07-25 Thread Quentin Schulz
The way to find the best_diff and do the appropriate process afterwards can be re-used. This patch prepares the driver for an upcoming patch that will allow clk_generated to determine the rate of the audio_pll. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> Acked-by:

[PATCH v4 5/9] clk: at91: clk-generated: create function to find best_diff

2017-07-25 Thread Quentin Schulz
The way to find the best_diff and do the appropriate process afterwards can be re-used. This patch prepares the driver for an upcoming patch that will allow clk_generated to determine the rate of the audio_pll. Signed-off-by: Quentin Schulz Acked-by: Boris Brezillon --- drivers/clk/at91/clk

[PATCH v4 3/9] clk: at91: add audio pll clock drivers

2017-07-25 Thread Quentin Schulz
ed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> Acked-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- arch/arm/mach-at91/Kconfig | 4 +- drivers/clk/at91/Makefile| 1 +- drivers/clk/at91/clk-audio-pll.c | 531 -

[PATCH v4 3/9] clk: at91: add audio pll clock drivers

2017-07-25 Thread Quentin Schulz
have different enable bits and different dividers and divider formulas, they are handled by two different drivers. Each of them could modify the rate of the main audio pll parent. The main audio pll clock can output 620MHz to 700MHz. Signed-off-by: Nicolas Ferre Signed-off-by: Quentin Schulz Acked

[PATCH v4 9/9] ARM: dts: at91: sama5d2_xplained: add pin muxing and enable classd

2017-07-25 Thread Quentin Schulz
From: Cyrille Pitchen <cyrille.pitc...@atmel.com> This patch adds the pin muxing for classd and enables it. Signed-off-by: Cyrille Pitchen <cyrille.pitc...@atmel.com> Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> Signed-off-by: Quentin Schulz <quentin.sch.

[PATCH v4 9/9] ARM: dts: at91: sama5d2_xplained: add pin muxing and enable classd

2017-07-25 Thread Quentin Schulz
From: Cyrille Pitchen This patch adds the pin muxing for classd and enables it. Signed-off-by: Cyrille Pitchen Signed-off-by: Nicolas Ferre Signed-off-by: Quentin Schulz --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 16 1 file changed, 16 insertions(+) diff --git

Re: [PATCH v3 3/9] clk: at91: add audio pll clock drivers

2017-07-24 Thread Quentin Schulz
Hi Stephen, On 22/07/2017 00:20, Stephen Boyd wrote: > On 07/13, Quentin Schulz wrote: >> diff --git a/drivers/clk/at91/clk-audio-pll-pad.c >> b/drivers/clk/at91/clk-audio-pll-pad.c >> new file mode 100644 >> index ..10dd6d625696 >> --- /dev/null &g

Re: [PATCH v3 3/9] clk: at91: add audio pll clock drivers

2017-07-24 Thread Quentin Schulz
Hi Stephen, On 22/07/2017 00:20, Stephen Boyd wrote: > On 07/13, Quentin Schulz wrote: >> diff --git a/drivers/clk/at91/clk-audio-pll-pad.c >> b/drivers/clk/at91/clk-audio-pll-pad.c >> new file mode 100644 >> index ..10dd6d625696 >> --- /dev/null &g

Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver

2017-07-21 Thread Quentin Schulz
an eMMC SDIO device. >>>> >>>> The code was taken from an out-of-tree repository and has seen a first >>>> pass in the cleanup process. >>>> >>>> At the moment, there is no publicly available datasheet for this chip. >>>

Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver

2017-07-21 Thread Quentin Schulz
an eMMC SDIO device. >>>> >>>> The code was taken from an out-of-tree repository and has seen a first >>>> pass in the cleanup process. >>>> >>>> At the moment, there is no publicly available datasheet for this chip. >>>>

Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver

2017-07-21 Thread Quentin Schulz
Hi Greg, On 21/07/2017 17:01, Greg KH wrote: > On Fri, Jul 21, 2017 at 04:35:01PM +0200, Quentin Schulz wrote: >> The Espressif ESP8089 WiFi chips can be often found in cheap tablets. >> There is one in A23 Polaroid tablets for example. >> >> The chip is often embe

Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver

2017-07-21 Thread Quentin Schulz
Hi Greg, On 21/07/2017 17:01, Greg KH wrote: > On Fri, Jul 21, 2017 at 04:35:01PM +0200, Quentin Schulz wrote: >> The Espressif ESP8089 WiFi chips can be often found in cheap tablets. >> There is one in A23 Polaroid tablets for example. >> >> The chip is often embe

[PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

2017-07-21 Thread Quentin Schulz
From: Hans de Goede Some sdio devices have a multiple stage bring-up process. Specifically the esp8089 (for which an out of tree driver is available) loads firmware on the first call to its sdio-drivers' probe function and then resets the device causing it to reboot from its

[PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

2017-07-21 Thread Quentin Schulz
From: Hans de Goede Some sdio devices have a multiple stage bring-up process. Specifically the esp8089 (for which an out of tree driver is available) loads firmware on the first call to its sdio-drivers' probe function and then resets the device causing it to reboot from its RAM with the new

[PATCH 0/2] add ESP8089 WiFi chip driver

2017-07-21 Thread Quentin Schulz
/ _end functions Quentin Schulz (1): staging: net: wireless: add ESP8089 WiFi driver drivers/mmc/core/core.c | 47 +- drivers/staging/Kconfig |2 + drivers/staging/Makefile|1 + drivers/staging/esp8089/Kconfig

[PATCH 0/2] add ESP8089 WiFi chip driver

2017-07-21 Thread Quentin Schulz
/ _end functions Quentin Schulz (1): staging: net: wireless: add ESP8089 WiFi driver drivers/mmc/core/core.c | 47 +- drivers/staging/Kconfig |2 + drivers/staging/Makefile|1 + drivers/staging/esp8089/Kconfig

[PATCH v2 3/3] Input: axp20x-pek: add support for AXP221 PEK

2017-07-19 Thread Quentin Schulz
The AXP221 has different values for startup time bits from the AXP20X. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> --- drivers/input/misc/axp20x-pek.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/input/misc/axp20x-pek.c b/drivers/inpu

[PATCH v2 3/3] Input: axp20x-pek: add support for AXP221 PEK

2017-07-19 Thread Quentin Schulz
The AXP221 has different values for startup time bits from the AXP20X. Signed-off-by: Quentin Schulz --- drivers/input/misc/axp20x-pek.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/input/misc/axp20x-pek.c b/drivers/input/misc/axp20x-pek.c index fa49f45c0f0e

[PATCH v2 1/3] Input: axp20x-pek: use driver_data of platform_device_id instead of extended attributes

2017-07-19 Thread Quentin Schulz
can be easily supported by just filling correctly its ax20x_info structure and adding a platform_device_id. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> --- drivers/input/misc/axp20x-pek.c | 131 +++- 1 file changed, 88 insertions(

[PATCH v2 0/3] add support for AXP22X/AXP288/AXP8XX PEK

2017-07-19 Thread Quentin Schulz
, - separate in different patches, - removed mfd patch to correct mfd cell name since Chen-Yu will take care of it in another patch series, Thanks, Quentin Quentin Schulz (3): Input: axp20x-pek: use driver_data of platform_device_id instead of extended attributes Input: axp20x-pek: remove

[PATCH v2 1/3] Input: axp20x-pek: use driver_data of platform_device_id instead of extended attributes

2017-07-19 Thread Quentin Schulz
can be easily supported by just filling correctly its ax20x_info structure and adding a platform_device_id. Signed-off-by: Quentin Schulz --- drivers/input/misc/axp20x-pek.c | 131 +++- 1 file changed, 88 insertions(+), 43 deletions(-) diff --git a/drivers/input

[PATCH v2 0/3] add support for AXP22X/AXP288/AXP8XX PEK

2017-07-19 Thread Quentin Schulz
, - separate in different patches, - removed mfd patch to correct mfd cell name since Chen-Yu will take care of it in another patch series, Thanks, Quentin Quentin Schulz (3): Input: axp20x-pek: use driver_data of platform_device_id instead of extended attributes Input: axp20x-pek: remove

[PATCH v2 2/3] Input: axp20x-pek: remove mention to extended attributes

2017-07-19 Thread Quentin Schulz
Now that extended attributes aren't used anymore, remove all the mentions to extended attributes. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> --- drivers/input/misc/axp20x-pek.c | 60 - 1 file changed, 29 insertions(+), 31 del

[PATCH v2 2/3] Input: axp20x-pek: remove mention to extended attributes

2017-07-19 Thread Quentin Schulz
Now that extended attributes aren't used anymore, remove all the mentions to extended attributes. Signed-off-by: Quentin Schulz --- drivers/input/misc/axp20x-pek.c | 60 - 1 file changed, 29 insertions(+), 31 deletions(-) diff --git a/drivers/input/misc

Re: [PATCH v3 0/9] add support for Sama5d2 audio PLLs and enable ClassD

2017-07-19 Thread Quentin Schulz
Hi all, It's been almost a week with no comments on this patch set, so kindly pinging. Thanks, Quentin On 13/07/2017 09:49, Quentin Schulz wrote: > This patch series adds support for the audio PLLs and enables ClassD that > can be found in ATMEL Sama5d2 SoC. > > There are two aud

Re: [PATCH v3 0/9] add support for Sama5d2 audio PLLs and enable ClassD

2017-07-19 Thread Quentin Schulz
Hi all, It's been almost a week with no comments on this patch set, so kindly pinging. Thanks, Quentin On 13/07/2017 09:49, Quentin Schulz wrote: > This patch series adds support for the audio PLLs and enables ClassD that > can be found in ATMEL Sama5d2 SoC. > > There are two aud

Re: [PATCH v3] phy: allwinner: phy-sun4i-usb: Add log when probing

2017-07-19 Thread Quentin Schulz
Hi all, Kindly pinging since the merge window is now closed and I haven;t received any update in the last two weeks, Thanks, Quentin On 04/07/2017 14:37, Quentin Schulz wrote: > When phy-sun4i-usb's probing fails, it does not print the reason in > kernel log, forcing the developer t

Re: [PATCH v3] phy: allwinner: phy-sun4i-usb: Add log when probing

2017-07-19 Thread Quentin Schulz
Hi all, Kindly pinging since the merge window is now closed and I haven;t received any update in the last two weeks, Thanks, Quentin On 04/07/2017 14:37, Quentin Schulz wrote: > When phy-sun4i-usb's probing fails, it does not print the reason in > kernel log, forcing the developer t

Re: [PATCH 2/2] mfd: axp20x: use correct platform device id for many PEK

2017-07-18 Thread Quentin Schulz
Hi Lee, On 18/07/2017 11:49, Lee Jones wrote: > On Tue, 18 Jul 2017, Quentin Schulz wrote: > >> Hi Lee, >> >> On 18/07/2017 09:19, Lee Jones wrote: >>> On Mon, 17 Jul 2017, Quentin Schulz wrote: >>> >>>> According to their datasheets, the

<    1   2   3   4   5   6   7   8   9   10   >