Re: [PATCH 3/3] ARM: pxa: em-x270: use the new pxa_camera platform_data

Robert Jarzmik <robert.jarz...@free.fr> writes: > pxa_camera has transitioned from a soc_camera driver to a standalone > v4l2 driver. Amend the device declaration accordingly. > > Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Queued to pxa/for-next. -- Robert

Re: [PATCH v2] ARM: pxa: remove duplicated include from spitz.c

Robert Jarzmik <robert.jarz...@free.fr> writes: > From: Wei Yongjun <weiyj...@gmail.com> > > This partially reverts commit 12beb346710b ("Merge tag 'pxa-fixes-v4.8' > of https://github.com/rjarzmik/linux into randconfig-4.8"). > > This former patch

Re: [PATCH v3 3/4] ARM: dts: pxa: add pxa27x cpu operating points

Robert Jarzmik <robert.jarz...@free.fr> writes: > Add the relevant data taken from the PXA27x Electrical, Mechanical, and > Thermal Specfication. This will be input data for cpufreq-dt driver. > > Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> > --- > Si

Re: [PATCH v3 2/4] ARM: dts: pxa: add pxa25x cpu operating points

Robert Jarzmik <robert.jarz...@free.fr> writes: > Add the relevant data taken from the PXA 25x Electrical, Mechanical, and > Thermal Specfication. This will be input data for cpufreq-dt driver. > > Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> > --- > Si

Re: [PATCH v2 5/5] clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq

Stephen Boyd <sb...@codeaurora.org> writes: > On 10/23, Robert Jarzmik wrote: >> diff --git a/drivers/clk/pxa/clk-pxa.c b/drivers/clk/pxa/clk-pxa.c >> index 29cee9e8d4d9..7184819b7415 100644 >> --- a/drivers/clk/pxa/clk-pxa.c >> +++ b/drivers/clk/pxa/clk-pxa.c &

Re: [PATCH 6/6] cpufreq: pxa: convert to clock API

Viresh Kumar <viresh.ku...@linaro.org> writes: > On 10-10-16, 22:09, Robert Jarzmik wrote: >> As the clock settings have been introduced into the clock pxa drivers, >> which are now available to change the CPU clock by themselves, remove >> the clock handling from t

Re: [PATCH 6/6] cpufreq: pxa: convert to clock API

Viresh Kumar <viresh.ku...@linaro.org> writes: > On 12-10-16, 08:22, Robert Jarzmik wrote: >> Viresh Kumar <viresh.ku...@linaro.org> writes: >> >> > On 10-10-16, 22:09, Robert Jarzmik wrote: >> >> As the clock settings have been introduced

Re: [PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround

David Miller <da...@davemloft.net> writes: > From: Robert Jarzmik <robert.jarz...@free.fr> > Date: Sun, 9 Oct 2016 22:33:45 +0200 > >> Writes to u16 has a special handling on 3 PXA platforms, where the >> hardware wiring forces these writes to be u32 al

[PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround

uild types. This patch was tested on 2 PXA platforms : mainstone, which relies on the workaround, and lubbock, which doesn't. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/net/ethernet/smsc/smc91x.c | 6 ++- drivers/net/ethernet/smsc/smc91x.h | 80 ++---

[PATCH v2 3/3] net: smsc91x: add u16 workaround for pxa platforms

Add a workaround for mainstone, idp and stargate2 boards, for u16 writes which must be aligned on 32 bits addresses. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Cc: Jeremy Linton <jeremy.lin...@arm.com> --- Since v1: rename dt property to pxa-u16-align4 change

[PATCH v2 2/3] net: smc91x: take into account half-word workaround

For device-tree builds, platforms such as mainstone, idp and stargate2 must have their u16 writes all aligned on 32 bit boundaries. This is already enabled in platform data builds, and this patch adds it to device-tree builds. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Si

Re: [PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround

Andy Shevchenko writes: >> +#define SMC_outw(lp, v, a, r) \ >> + _SMC_outw_align4((v), (a), (r), \ >> +IS_BUILTIN(CONFIG_ARCH_PXA) && ((r) & 2) &&\ >> +

Re: [PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround

Sorry David, I just noticed you weren't in the "To:" of this serie, but I won't forget you for the v3 I need to release anyway (https://lkml.org/lkml/2016/10/15/104). Robert Jarzmik <robert.jarz...@free.fr> writes: > + lp->half_word_align4 = > +

[PATCH v2 3/4] ARM: dts: pxa: add pxa27x cpu operating points

Add the relevant data taken from the PXA27x Electrical, Mechanical, and Thermal Specfication. This will be input data for cpufreq-dt driver. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- arch/arm/boot/dts/pxa27x.dtsi | 40 1 file chang

[PATCH v2 4/4] cpufreq: pxa: convert to clock API

As the clock settings have been introduced into the clock pxa drivers, which are now available to change the CPU clock by themselves, remove the clock handling from this driver, and rely on pxa clock drivers. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: added !OF K

Re: [PATCH v2 0/4] PXA cpufreq conversion to clock API

Russell King - ARM Linux <li...@armlinux.org.uk> writes: > On Sat, Oct 15, 2016 at 09:57:26PM +0200, Robert Jarzmik wrote: >> Hi, >> >> This serie is a preparation to shift the cpufreq of pxa2xx platforms to >> clocks >> API. >> >>

Re: [PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround

Robert Jarzmik <robert.jarz...@free.fr> writes: > diff --git a/drivers/net/ethernet/smsc/smc91x.h > b/drivers/net/ethernet/smsc/smc91x.h > index ea8465467469..dff165ed106d 100644 > --- a/drivers/net/ethernet/smsc/smc91x.h > +++ b/drivers/net/ethernet/smsc/smc91x.h And there

Re: [PATCH 6/6] cpufreq: pxa: convert to clock API

Viresh Kumar writes: >> >> PXA architecture have both legacy platform_data based configurations and >> >> new >> >> devicetree based ones. >> > >> > I don't see any platform data specific code in this driver. What am I >> > missing ? >> >> In a legacy platform, ie.

[PATCH] tags: honor COMPILED_SOURCE with apart output directory

for object files both in source tree and potential destination tree. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- scripts/tags.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/tags.sh b/scripts/tags.sh index b3775a9604ea..c0220fa05617 100755 --- a

[PATCH v3 0/4] support smc91x on mainstone and devicetree

n a device-tree build, exaclty as it's been working for years with the legacy arch/arm/mach-pxa/mainstone.c definition. As a sum up, this extends an existing mechanism to device-tree based pxa platforms. Cheers. -- Robert Robert Jarzmik (4): ARM: pxa: enhance smc91x platform data net: smc91x: i

[PATCH v3 1/4] ARM: pxa: enhance smc91x platform data

Instead of having the smc91x driver relying on machine_is_*() calls, provide this data through platform data, ie. idp, mainstone and stargate. This way, the driver doesn't need anymore machine_is_*() calls, which wouldn't work anymore with a device-tree build. Signed-off-by: Robert Jarzmik

[PATCH v3 3/4] net: smc91x: take into account half-word workaround

For device-tree builds, platforms such as mainstone, idp and stargate2 must have their u16 writes all aligned on 32 bit boundaries. This is already enabled in platform data builds, and this patch adds it to device-tree builds. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Si

[PATCH v3 4/4] net: smsc91x: add u16 workaround for pxa platforms

Add a workaround for mainstone, idp and stargate2 boards, for u16 writes which must be aligned on 32 bits addresses. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Cc: Jeremy Linton <jeremy.lin...@arm.com> --- Since v1: rename dt property to pxa-u16-align4 change

[PATCH v3 2/4] net: smc91x: isolate u16 writes alignment workaround

uild types. This patch was tested on 2 PXA platforms : mainstone, which relies on the workaround, and lubbock, which doesn't. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> -- Since v2: fixed arch/mn10300 case removed machine_is_*() calls --- arch/mn10300/unit-asb2303/include

Re: [PATCH 6/6] cpufreq: pxa: convert to clock API

Robert Jarzmik <robert.jarz...@free.fr> writes: >> In that case, what about making this driver depends_on !CONFIG_OF ? So >> that the DT users don't use it anymore. > Good idea, let me try it. > I'll see if it actually works before make another iteration of this patch.

[PATCH v2 2/3] net: smc91x: take into account half-word workaround

For device-tree builds, platforms such as mainstone, idp and stargate2 must have their u16 writes all aligned on 32 bit boundaries. This is already enabled in platform data builds, and this patch adds it to device-tree builds. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Si

[PATCH v2 3/3] net: smsc91x: add u16 workaround for pxa platforms

Add a workaround for mainstone, idp and stargate2 boards, for u16 writes which must be aligned on 32 bits addresses. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Cc: Jeremy Linton <jeremy.lin...@arm.com> --- Since v1: rename dt property to pxa-u16-align4 change

[PATCH v2 1/4] cpufreq: pxa: use generic platdev driver for device-tree

For device-tree based pxa25x and pxa27x platforms, cpufreq-dt driver is doing the job as well as pxa2xx-cpufreq, so add these platforms to the compatibility list. This won't work for legacy non device-tree platforms where pxa2xx-cpufreq is still required. Signed-off-by: Robert Jarzmik

[PATCH v2 2/4] ARM: dts: pxa: add pxa25x cpu operating points

Add the relevant data taken from the PXA 25x Electrical, Mechanical, and Thermal Specfication. This will be input data for cpufreq-dt driver. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- arch/arm/boot/dts/pxa25x.dtsi | 25 + 1 file changed, 25 inse

[PATCH v2 0/4] PXA cpufreq conversion to clock API

in first as a prequisite Robert Jarzmik (4): cpufreq: pxa: use generic platdev driver for device-tree ARM: dts: pxa: add pxa25x cpu operating points ARM: dts: pxa: add pxa27x cpu operating points cpufreq: pxa: convert to clock API arch/arm/boot/dts/pxa25x.dtsi| 25 + arch

[PATCH v2 0/3] support smc91x on mainstone and devicetree

n a device-tree build, exaclty as it's been working for years with the legacy arch/arm/mach-pxa/mainstone.c definition. Cheers. -- Robert Robert Jarzmik (3): net: smc91x: isolate u16 writes alignment workaround net: smc91x: take into account half-word workaround net: smsc91x: add u16 workarou

[PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround

uild types. This patch was tested on 2 PXA platforms : mainstone, which relies on the workaround, and lubbock, which doesn't. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/net/ethernet/smsc/smc91x.c | 6 ++- drivers/net/ethernet/smsc/smc91x.h | 78 +

Re: [RFC PATCH 15/23] arm: use kconfig fragments for ARCH_PXA defconfigs (part 1)

> > and comparing resulting defconfig files (before/after the patch). > > Cc: Daniel Mack <dan...@zonque.org> > Cc: Haojian Zhuang <haojian.zhu...@gmail.com> > Cc: Robert Jarzmik <robert.jarz...@free.fr> > Cc: Cyril Bur <cyril...@gmail.com> > Signed-o

Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions

Arvind Yadav writes: Hi Arvind, > In functions pxa2xx_build_functions, the memory allocated for > 'functions' is live within the function only. After the > allocation it is immediately freed with devm_kfree. There is > no need to allocate memory for 'functions' with

[PATCH v2] tags: honor COMPILED_SOURCE with apart output directory

the simple expression to compute "k" as the built object. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: amended k expression, Marek's comments --- scripts/tags.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/tags.sh b/scripts/

Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory

Michal Marek <mma...@suse.com> writes: > Dne 6.12.2016 v 12:54 Robert Jarzmik napsal(a): >> Robert Jarzmik <robert.jarz...@free.fr> writes: >> >>> When the kernel is compiled with an "O=" argument, the object files are >>> not necessaril

Re: [V2] mtd: devices: docg3:- Handle return value of devm_ioremap.

arvind Yadav writes: > There is problem, if you will use devm_ioremap_resource instead of > devm_ioremap, > than devm_ioremap_resource will call request_mem_region(). > request_mem_region() allows to tell the kernel that this driver is going to > use > this range of

Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory

Robert Jarzmik <robert.jarz...@free.fr> writes: > When the kernel is compiled with an "O=" argument, the object files are > not necessarily in the source tree, and more probably in another tree. > > In this situation, the current used check doesn't work, and >

Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions

> allocation it is immediately freed with devm_kfree. There is >> no need to allocate memory for 'functions' with devm function >> so replace devm_kcalloc with kcalloc and devm_kfree with kfree. >> >> Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> > &g

Re: [PATCH V5 4/7] ARM: pxa: Use - instead of @ for DT OPP entries

will never have a > "reg" property. > > Reported-by: Krzysztof Kozlowski <k...@kernel.org> > Reported-by: Masahiro Yamada <yamada.masah...@socionext.com> > Suggested-by: Mark Rutland <mark.rutl...@arm.com> > Signed-off-by: Viresh Kumar <viresh.ku...@linar

Re: [PATCH V5 4/7] ARM: pxa: Use - instead of @ for DT OPP entries

Robert Jarzmik <robert.jarz...@free.fr> writes: > Viresh Kumar <viresh.ku...@linaro.org> writes: > >> On 20-04-17, 22:14, Robert Jarzmik wrote: >>> Viresh Kumar <viresh.ku...@linaro.org> writes: >>> >>> > Compiling the D

Re: [PATCH V5 4/7] ARM: pxa: Use - instead of @ for DT OPP entries

Viresh Kumar <viresh.ku...@linaro.org> writes: > On 20-04-17, 22:14, Robert Jarzmik wrote: >> Viresh Kumar <viresh.ku...@linaro.org> writes: >> >> > Compiling the DT file with W=1, DTC warns like follows: >> > >> > Warning (unit_address_vs

Re: [PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings

Philippe Reynes writes: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. I have the hardware. Do you want anything specific to

Re: [PATCH 07/12] gpio: pxa: use devm_irq_alloc_descs()

Bartosz Golaszewski <bgolaszew...@baylibre.com> writes: > This driver never frees the interrupt descriptors it allocates. Fix > it by using the resource managed version of irq_alloc_descs(). > > Signed-off-by: Bartosz Golaszewski <bgolaszew...@baylibre.com> Acked-by: Rob

Re: [PATCH v2] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings

x full autoneg on ethtool eth0 => see the changes ping -f x.x.x.x This both with your patch and without, it works in both cases, and the former as a smaller throughput, which makes me believe the patch is fine. Tested-by: Robert Jarzmik <robert.jarz...@free.fr> Cheers. -- Robert

Re: [PATCH 10/11] ASoC: pxa: Handle return value of clk_prepare_enable.

Arvind Yadav <arvind.yadav...@gmail.com> writes: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Acked-by: Robert Jarzmik <robert.jarz...@free.fr> Cheers. -- Robert

Re: [PATCH 11/11] ASoC: pxa-ssp: Handle return value of clk_prepare_enable.

Arvind Yadav <arvind.yadav...@gmail.com> writes: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Acked-by: Robert Jarzmik <robert.jarz...@free.fr> Cheers. -- Robert

Re: [PATCH v5 06/12] mfd: wm97xx-core: core support for wm97xx Codec

Lee Jones <lee.jo...@linaro.org> writes: > On Sun, 06 Aug 2017, Robert Jarzmik wrote: Hi Lee, I basically agree with all your comments, so I will only answer to your questions. >> +#include > > Why separate this? No point, for v6. >> + * This program is free sof

Re: [PATCH] ASoC: pxa: SND_PXA2XX_SOC should depend on HAS_DMA

t; [sound/arm/snd-pxa2xx-lib.ko] undefined! > > Add a dependency on HAS_DMA to fix this. > > Fixes: 73d7ee2e831f106c ("ASoC: pxa: add COMPILE_TEST on SND_PXA2XX_SOC") > Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> Acked-by: Robert Jarzmik <robert.jarz...@free.fr> Cheers. -- Robert

Re: [PATCH v3 00/12] AC97 device/driver model revamp

Mark Brown <broo...@kernel.org> writes: > On Fri, Jun 30, 2017 at 09:43:56PM +0200, Robert Jarzmik wrote: >> Hi Lars, Mark, Charles, Lee, >> >> This is a resend of the v2, with patch 1 added (forgotten in v2). Patch 12 >> was >> slightly modified after

Re: [PATCH v2] ARM: sa1100/pxa: fix MTD_XIP build

lt;a...@arndb.de> > Cc: Russell King <li...@arm.linux.org.uk> > Cc: Robert Jarzmik <robert.jarz...@free.fr> > --- > > v2: add back outer () as Robert suggested For mach-pxa : Acked-by: Robert Jarzmik <robert.jarz...@free.fr> Cheers. -- Robert

Re: [PATCH 04/12] ARM: sa1100/pxa: fix MTD_XIP build

Arnd Bergmann writes: Hi Arnd, > -#define xip_irqpending() (ICIP & ICMR) > +/* restored July 2017, this did not build since 2011! */ > + > +#define ICIP io_p2v(0x40d0) > +#define ICMR io_p2v(0x40d4) Okay, I suppose the IO mapping is

[PATCH v4 06/12] mfd: wm97xx-core: core support for wm97xx Codec

will not withstand the new AC97 bus model, where codecs are discovered on runtime. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v3: - added a "depends on AC97_BUS_NEW" Kconfig statement - added default values for wm9705, wm9712 per Charles's comment --- drivers/mfd/Kcon

[PATCH v4 00/12] AC97 device/driver model revamp

extracted the diff from the v3 of sound/ac97 which is in [1] for easier spotting of what has globally changed. I would still need a review from you, Lee, for the mfd patch (patch 6/12). Happy review. -- Robert Robert Jarzmik (12): ALSA: ac97: split out the generic ac97 registers ALSA: ac97: add

[PATCH v4 04/12] ASoC: arm: make pxa2xx-ac97-lib ac97 codec agnostic

All pxa library functions don't use the input parameters for nothing but slot number. This simplifies their prototypes, and makes them usable by both the legacy ac97 bus and the new ac97 bus. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- include/sound/pxa2xx-lib.h

[PATCH v4 12/12] ASoC: pxa: switch to new ac97 bus support

Switch to the new ac97 bus support in sound/ac97 instead of the legacy snd_ac97 one. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: split into 2 patches, the former being XXX ac97 codec agnostic Since v2: fix driver unregistration Since v3: added platform drive

[PATCH v4 01/12] ALSA: ac97: split out the generic ac97 registers

tion which would come with ac97_codec.h by "chance". - don't have to have snd_a97_*() functions, as they rely on struct snd_ac97. - don't want the struct snd_ac97_bus_ops, there is a new one Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: improve commit

[PATCH v4 03/12] ASoC: add new ac97 bus support

Add the new ac97 bus support, with ac97 bus automatic probing. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com> --- sound/Kconfig | 2 ++ sound/Makefile | 1 + 2 files changed, 3 insertions(+) diff --git a/sou

[PATCH v4 11/12] ASoC: wm9705: add ac97 new bus support

Add support for the new ac97 bus model, where devices are automatically discovered on AC-Links. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com> --- sound/soc/codecs/Kconfig | 3 ++- sound/soc/codecs/w

[PATCH v4 02/12] ALSA: ac97: add an ac97 bus

d/ac97/codec.h new file mode 100644 index ..ec04be9ab119 --- /dev/null +++ b/include/sound/ac97/codec.h @@ -0,0 +1,118 @@ +/* + * Copyright (C) 2016 Robert Jarzmik <robert.jarz...@free.fr> + * + * This program is free software; you can redistribute it and/or modify + * it und

[PATCH v4 05/12] Input: wm97xx: split out touchscreen registering

specific from the remaining part. This is only code shuffling, there is no functional change. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Dmitry Torokhov <dmitry.torok...@gmail.com> Acked-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com> --- Since v1: -

[PATCH v4 10/12] ASoC: wm9705: add private structure

Add a private data structure. This is a preparation for a codec which would need an another data on top of snd_ac97, which will be the case when an MFD wm97xx device will probe wm9705. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Charles Keepax

[PATCH v4 08/12] ASoC: wm9713: add ac97 new bus support

Add support for the new ac97 bus model, where devices are automatically discovered on AC-Links. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- sound/soc/codecs/Kconfig | 3 ++- sound/soc/codecs/wm9713.c | 39 +++ 2 files changed, 29 inse

[PATCH v4 09/12] ASoC: wm9712: add ac97 new bus support

Add support for the new ac97 bus model, where devices are automatically discovered on AC-Links. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- sound/soc/codecs/Kconfig | 3 ++- sound/soc/codecs/wm9712.c | 37 - 2 files changed, 26 inse

[PATCH v4 07/12] Input: wm97xx: add new AC97 bus support

;cell" as the touchscreen driver. This was tested on the pxa architecture with a pxa270 + wm9713 + the mioa701 touchscreen. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com> Acked-by: Dmitry Torokhov <dmitry.torok..

Re: [PATCH v4 02/12] ALSA: ac97: add an ac97 bus

Takashi Iwai <ti...@suse.de> writes: > On Mon, 24 Jul 2017 22:49:18 +0200, > Robert Jarzmik wrote: ...zip... >> +#ifndef AC97_COMPAT_H >> +#define AC97_COMPAT_H >> + >> +#include >> +#include > > Is this inclusion needed? The code here doesn

Re: [PATCH v3 06/12] mfd: wm97xx-core: core support for wm97xx Codec

Charles Keepax <ckee...@opensource.cirrus.com> writes: > On Fri, Jun 30, 2017 at 09:44:02PM +0200, Robert Jarzmik wrote: >> The WM9705, WM9712 and WM9713 are highly integrated codecs, with an >> audio codec, DAC and ADC, GPIO unit and a touchscreen interface. ... &g

Re: [alsa-devel] [PATCH v2 12/12] ASoC: Fix use-after-free at card unregistration

Mark Brown <broo...@kernel.org> writes: > On Mon, Jun 19, 2017 at 01:57:20PM +0200, Robert Jarzmik wrote: > >> My serie shifted by one, so the very first of the serie is therefore missing, >> formerly "ALSA: ac97: split out the generic ac97 registers" in >

Re: [alsa-devel] [PATCH v2 12/12] ASoC: Fix use-after-free at card unregistration

Mark Brown <broo...@kernel.org> writes: > On Thu, Jun 29, 2017 at 12:03:58AM +0200, Robert Jarzmik wrote: >> Mark Brown <broo...@kernel.org> writes: > >> > Based on the missing first patch I was expecting the series to get >> > reposted? > >>

[PATCH v3 12/12] ASoC: pxa: switch to new ac97 bus support

Switch to the new ac97 bus support in sound/ac97 instead of the legacy snd_ac97 one. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: split into 2 patches, the former being XXX ac97 codec agnostic Since v2: fix driver unregistration --- sound/arm/Kconfig

[PATCH v3 08/12] ASoC: wm9713: add ac97 new bus support

Add support for the new ac97 bus model, where devices are automatically discovered on AC-Links. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- sound/soc/codecs/Kconfig | 3 ++- sound/soc/codecs/wm9713.c | 39 +++ 2 files changed, 29 inse

[PATCH v3 11/12] ASoC: wm9705: add ac97 new bus support

Add support for the new ac97 bus model, where devices are automatically discovered on AC-Links. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- sound/soc/codecs/Kconfig | 3 ++- sound/soc/codecs/wm9705.c | 35 +++ 2 files changed, 25 insertions(

[PATCH v3 09/12] ASoC: wm9712: add ac97 new bus support

Add support for the new ac97 bus model, where devices are automatically discovered on AC-Links. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- sound/soc/codecs/Kconfig | 3 ++- sound/soc/codecs/wm9712.c | 37 - 2 files changed, 26 inse

[PATCH v3 05/12] Input: wm97xx: split out touchscreen registering

specific from the remaining part. This is only code shuffling, there is no functional change. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- Since v1: - took into account Charles's comment --- drivers/input/touchscreen/w

[PATCH v3 00/12] AC97 device/driver model revamp

is way simpler with a table, and the data structure very compact. - Input: wm97xx: split out touchscreen registering => Charles's comment taken into account => history: http://https://patchwork.kernel.org/patch/9398223/ Have a happy review. -- Robert Robert Jarzmik (12):

[PATCH v3 06/12] mfd: wm97xx-core: core support for wm97xx Codec

will not withstand the new AC97 bus model, where codecs are discovered on runtime. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/mfd/Kconfig| 14 +++ drivers/mfd/Makefile | 1 + drivers/mfd/wm97xx-core.c | 282 + include/lin

[PATCH v3 07/12] Input: wm97xx: add new AC97 bus support

;cell" as the touchscreen driver. This was tested on the pxa architecture with a pxa270 + wm9713 + the mioa701 touchscreen. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com> Acked-by: Dmitry Torokhov <dmitry.torok..

[PATCH v3 02/12] ALSA: ac97: add an ac97 bus

+++ b/include/sound/ac97/codec.h @@ -0,0 +1,118 @@ +/* + * Copyright (C) 2016 Robert Jarzmik <robert.jarz...@free.fr> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Softwar

[PATCH v3 01/12] ALSA: ac97: split out the generic ac97 registers

tion which would come with ac97_codec.h by "chance". - don't have to have snd_a97_*() functions, as they rely on struct snd_ac97. - don't want the struct snd_ac97_bus_ops, there is a new one Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: improve commit

[PATCH v3 04/12] ASoC: arm: make pxa2xx-ac97-lib ac97 codec agnostic

All pxa library functions don't use the input parameters for nothing but slot number. This simplifies their prototypes, and makes them usable by both the legacy ac97 bus and the new ac97 bus. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- include/sound/pxa2xx-lib.h

[PATCH v3 03/12] ASoC: add new ac97 bus support

Add the new ac97 bus support, with ac97 bus automatic probing. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com> --- sound/Kconfig | 2 ++ sound/Makefile| 1 + sound/soc/Kconfig | 4 3 files changed,

[PATCH v3 10/12] ASoC: wm9705: add private structure

Add a private data structure. This is a preparation for a codec which would need an another data on top of snd_ac97, which will be the case when an MFD wm97xx device will probe wm9705. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- sound/soc/codecs/wm9705.

Re: [PATCH v3 02/12] ALSA: ac97: add an ac97 bus

Takashi Iwai <ti...@suse.de> writes: > On Fri, 30 Jun 2017 21:43:58 +0200, > Robert Jarzmik wrote: >> +static struct bus_type ac97_bus_type = { >> +.name = "ac97", > > Name-conflict with the old ac97 bus? Yeah, fair point. So what shoul

Re: [PATCH v3 02/12] ALSA: ac97: add an ac97 bus

Takashi Iwai <ti...@suse.de> writes: > On Tue, 04 Jul 2017 21:37:48 +0200, > Robert Jarzmik wrote: >> >> Takashi Iwai <ti...@suse.de> writes: >> >> > On Fri, 30 Jun 2017 21:43:58 +0200, >> > Robert Jarzmik wrote: >> >> +static

Re: [PATCH v2] tags: honor COMPILED_SOURCE with apart output directory

Masahiro Yamada writes: > Hi Robert, >> diff --git a/scripts/tags.sh b/scripts/tags.sh >> index a2ff3388e5ea..35cb64d5211c 100755 >> --- a/scripts/tags.sh >> +++ b/scripts/tags.sh >> @@ -106,7 +106,8 @@ all_compiled_sources() >> case "$i" in >>

Re: [PATCH v4 09/12] ASoC: wm9712: add ac97 new bus support

Charles Keepax <ckee...@opensource.cirrus.com> writes: > On Mon, Jul 24, 2017 at 10:49:25PM +0200, Robert Jarzmik wrote: >> Add support for the new ac97 bus model, where devices are automatically >> discovered on AC-Links. >> >> Signed-off-by: Rober

Re: [RFC/RFT PATCH 2/3] gpio: pxa: remove gpio_to_irq() from hw irq handlers

Linus Walleij writes: > On Sun, Jul 9, 2017 at 12:44 AM, Grygorii Strashko > wrote: > >> gpio_to_irq() API expected to be used by GPIO consumers and >> not drivers and there are no guarantee that its gpiolib implementation >> is irq safe. >>

[PATCH v5 07/12] Input: wm97xx: add new AC97 bus support

;cell" as the touchscreen driver. This was tested on the pxa architecture with a pxa270 + wm9713 + the mioa701 touchscreen. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com> Acked-by: Dmitry Torokhov <dmitry.torok..

[PATCH v5 01/12] ALSA: ac97: split out the generic ac97 registers

tion which would come with ac97_codec.h by "chance". - don't have to have snd_a97_*() functions, as they rely on struct snd_ac97. - don't want the struct snd_ac97_bus_ops, there is a new one Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: improve commit

[PATCH v5 04/12] ASoC: arm: make pxa2xx-ac97-lib ac97 codec agnostic

All pxa library functions don't use the input parameters for nothing but slot number. This simplifies their prototypes, and makes them usable by both the legacy ac97 bus and the new ac97 bus. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- include/sound/pxa2xx-lib.h

[PATCH v5 11/12] ASoC: wm9705: add ac97 new bus support

Add support for the new ac97 bus model, where devices are automatically discovered on AC-Links. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com> --- Since v4: - added #ifdef spotted by Charles - tentatively kept C

[PATCH v5 05/12] Input: wm97xx: split out touchscreen registering

specific from the remaining part. This is only code shuffling, there is no functional change. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Dmitry Torokhov <dmitry.torok...@gmail.com> Acked-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com> --- Since v1: -

[PATCH v5 09/12] ASoC: wm9712: add ac97 new bus support

Add support for the new ac97 bus model, where devices are automatically discovered on AC-Links. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v4: - added #ifdef spotted by Charles --- sound/soc/codecs/Kconfig | 3 ++- sound/soc/codecs/wm9712.

[PATCH v5 12/12] ASoC: pxa: switch to new ac97 bus support

Switch to the new ac97 bus support in sound/ac97 instead of the legacy snd_ac97 one. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: split into 2 patches, the former being XXX ac97 codec agnostic Since v2: fix driver unregistration Since v3: added platform drive

[PATCH v5 10/12] ASoC: wm9705: add private structure

Add a private data structure. This is a preparation for a codec which would need an another data on top of snd_ac97, which will be the case when an MFD wm97xx device will probe wm9705. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Charles Keepax

[PATCH v5 02/12] ALSA: ac97: add an ac97 bus

odec.c create mode 100644 sound/ac97/snd_ac97_compat.c diff --git a/include/sound/ac97/codec.h b/include/sound/ac97/codec.h new file mode 100644 index ..ec04be9ab119 --- /dev/null +++ b/include/sound/ac97/codec.h @@ -0,0 +1,118 @@ +/* + * Copyright (C) 2016 Robert Jarzmik <robert.jarz..

[PATCH v5 00/12] AC97 device/driver model revamp

(there is an #ifdef added). I would still need a review from you, Lee, for the mfd patch (patch 6/12). Happy review. -- Robert Robert Jarzmik (12): ALSA: ac97: split out the generic ac97 registers ALSA: ac97: add an ac97 bus ASoC: add new ac97 bus support ASoC: arm: make pxa2xx-ac97-lib

[PATCH v5 03/12] ASoC: add new ac97 bus support

Add the new ac97 bus support, with ac97 bus automatic probing. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com> --- sound/Kconfig | 2 ++ sound/Makefile | 1 + 2 files changed, 3 insertions(+) diff --git a/sou

[PATCH v5 08/12] ASoC: wm9713: add ac97 new bus support

Add support for the new ac97 bus model, where devices are automatically discovered on AC-Links. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com> --- sound/soc/codecs/Kconfig | 3 ++- sound/soc/codecs/w

[PATCH v5 06/12] mfd: wm97xx-core: core support for wm97xx Codec

will not withstand the new AC97 bus model, where codecs are discovered on runtime. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com> --- Since v3: - added a "depends on AC97_BUS_NEW" Kconfig statement - added default val

<    6   7   8   9   10   11   12   13   14   15   >