Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-04 Thread Robert Jarzmik
Charles Keepax <ckee...@opensource.wolfsonmicro.com> writes: > On Wed, Nov 04, 2015 at 06:12:44PM +0100, Robert Jarzmik wrote: >> The Wolfson WM9713 provides 8 GPIOs. If the gpiolib is compiled in the >> kernel, declare a gpio chip. >> >> Signed-off-by: Rober

[PATCH] mmc: pxamci: fix read-only gpio detection polarity

2015-11-05 Thread Robert Jarzmik
The commit converting pxamci to slot-gpio API inverted the logic of the read-only gpio. Fix it by inverting the logic again. Fixes: fd546ee6a7dc ("mmc: pxamci: fix card detect with slot-gpio API") Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Cc: sta...@vger.kernel.org

[PATCH] ASoC: wm9713: add gpio chip

2015-11-04 Thread Robert Jarzmik
The Wolfson WM9713 provides 8 GPIOs. If the gpiolib is compiled in the kernel, declare a gpio chip. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- sound/soc/codecs/wm9713.c | 123 ++ sound/soc/codecs/wm9713.h | 1 + 2 files change

Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-06 Thread Robert Jarzmik
Lee Jones <lee.jo...@linaro.org> writes: > On Fri, 06 Nov 2015, Charles Keepax wrote: > >> On Fri, Nov 06, 2015 at 09:29:13AM +, Lee Jones wrote: >> > On Wed, 04 Nov 2015, Robert Jarzmik wrote: >> > >> > > Charles Keepax <ckee...@opensourc

Re: [PATCH] ARM: pxa: fix pxa3xx DFI lockup hack

2015-10-14 Thread Robert Jarzmik
Arnd Bergmann <a...@arndb.de> writes: > On Monday 12 October 2015 19:03:44 Robert Jarzmik wrote: >> Arnd Bergmann <a...@arndb.de> writes: >> >> > Some recently added code to avoid a bug introduced a build error >> > when CONFIG_PM is disabled and a

Re: [PATCH v4 19/26] ARM: pxa: magician: Add support for Omnivision OV9640 camera

2015-10-07 Thread Robert Jarzmik
Philipp Zabel writes: > Am Montag, den 28.09.2015, 23:38 +0200 schrieb Petr Cvek: >> This patch adds support for an OV9640 camera to the HTC Magician >> machine. >> >> Signed-off-by: Petr Cvek > > Still untested, but looks good to me. I'm still

Re: [PATCH v2] video: fbdev: add Marvell PXA framebuffer binding

2015-10-08 Thread Robert Jarzmik
Rob Herring writes: >> The pxafb driver acts today on the subset of registers which are the same >> across >> all pxaXXX variants. This is what made me think only one compatible property >> was >> required. >> >> If I'm wrong, I could add "marvell,pxa3xx-lcdc", is that what

Re: [PATCH v4 11/26] ARM: pxa: magician: Optimize EGPIO initial values

2015-10-07 Thread Robert Jarzmik
Philipp Zabel writes: > Am Montag, den 28.09.2015, 23:32 +0200 schrieb Petr Cvek: >> This patch optimizes initial values of the EGPIO chip driver. >> >> GSM and sound should be powered off during boot. A weak accumulator >> and >> a powered GSM sometimes cause a system

Re: [PATCH v3 0/4] mtd: pxa3xx_nand: rework the timing setup

2015-10-20 Thread Robert Jarzmik
Antoine Tenart writes: > Hi Ezequiel, > > On Thu, Oct 15, 2015 at 03:30:50PM -0300, Ezequiel Garcia wrote: >> Ccing Robert as he can provide valuable test on PXA boards. > > Sorry for this, I tried to cc Robert but forgot when sending my > series... Maybe for

Re: [PATCH v4 00/26] ARM: pxa: magician: Rework HTC Magician support

2015-10-11 Thread Robert Jarzmik
Petr Cvek writes: >> Thanks (a pozdrav :-), >> >> Pavel Hi Petr, I'll start applying part of this serie today evening (my evening). All Philipp's acked patches for a start. For the minor changes required by Philipp

Re: [PATCH v4 00/26] ARM: pxa: magician: Rework HTC Magician support

2015-10-11 Thread Robert Jarzmik
Robert Jarzmik <robert.jarz...@free.fr> writes: > Petr Cvek <petr.c...@tul.cz> writes: > >>> Thanks (a pozdrav :-), >>> >>> Pavel > Hi Petr, > > I'll start applying part of this s

[PATCH v3] video: fbdev: add Marvell PXA LCD controller binding

2015-10-12 Thread Robert Jarzmik
Add documentation for the PXA LCD controller devicetree binding. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: Philipp's review on the whole binding Since v2: moved to display/, Philipp's and Rob's review dropped panel description, should be a simple

Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode

2015-10-12 Thread Robert Jarzmik
Arnd Bergmann writes: > The z2 machine calls pxa27x_set_pwrmode() in order to power off > the machine, but this function gets discarded early at boot because > it is marked __init, as pointed out by kbuild: > > WARNING: vmlinux.o(.text+0x145c4): Section mismatch in reference from

Re: [PATCH] ARM: pxa: fix pxa3xx DFI lockup hack

2015-10-12 Thread Robert Jarzmik
ot;ARM: pxa: fix DFI bus lockups on startup") > --- > We merged the patch that introduced this as a fix for 4.3, so we should > probably add this one too. Oh yes, didn't see that ifdef, and all my non-regression defconfigs have CONFIG_PM ... Acked-by: Robert Jarzmik <robert.jarz...@fre

Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode

2015-10-12 Thread Robert Jarzmik
Robert Jarzmik <robert.jarz...@free.fr> writes: > Arnd Bergmann <a...@arndb.de> writes: > >> The z2 machine calls pxa27x_set_pwrmode() in order to power off >> the machine, but this function gets discarded early at boot because >> it is marked __init, as

Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode

2015-10-12 Thread Robert Jarzmik
Arnd Bergmann writes: >> It looks to me the powermode should be initialized once and for all in the >> machine init code. So unless I've overseen something, I'll keep Thierry's >> patch. > > Ah, sorry. I should have looked at the link you sent. > > Thierry's patch indeed looks

Re: [PATCH v2] video: fbdev: add Marvell PXA framebuffer binding

2015-10-06 Thread Robert Jarzmik
Philipp Zabel <philipp.za...@gmail.com> writes: > On Sun, Oct 4, 2015 at 12:31 PM, Robert Jarzmik <robert.jarz...@free.fr> > wrote: >> + lcd-controller@4050 { >> + compatible = "marvell,pxa2xx-lcdc"; >

Re: [PATCH v2] video: fbdev: add Marvell PXA framebuffer binding

2015-10-06 Thread Robert Jarzmik
Rob Herring <r...@kernel.org> writes: > On Sun, Oct 4, 2015 at 5:31 AM, Robert Jarzmik <robert.jarz...@free.fr> wrote: >> Add documentation for the PXA frambuffer devicetree binding. > > Strictly speaking this is a binding for PXA display controller, not a > L

Re: [PATCH v4 07/26] ARM: pxa: magician: Fix HTC Magician pin mux definitions

2015-10-13 Thread Robert Jarzmik
Petr Cvek writes: > Dne 3.10.2015 v 14:30 Philipp Zabel napsal(a): >> Am Montag, den 28.09.2015, 23:15 +0200 schrieb Petr Cvek: >>> This patch fixes a pin mux for the HTC Magician machine. Wrong and >>> missing >>> definitions caused a bad LCD operation and an unavailability of

Re: [PATCH v4 22/26] ARM: pxa: magician: Remove pdata for pasic3-leds

2015-10-13 Thread Robert Jarzmik
Philipp Zabel writes: > Am Montag, den 28.09.2015, 23:39 +0200 schrieb Petr Cvek: >> The pasic3-leds driver was never in vanilla kernel. Actual >> configuration >> data for a hypothetical driver does not describe hardware completely, >> so >> remove them. >> >> This

[PATCH v2 2/2] video: fbdev: pxafb: initial devicetree conversion

2015-10-13 Thread Robert Jarzmik
configurations with different bits per pixel, only the LCD hardware bus width is used. The patch was tested on both pxa25x, pxa27x and pxa3xx platform (namely lubbock, mainstone and zylonite). Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: Philipp's review: of_graph

[PATCH v2 1/2] video: fbdev: pxafb: loosen the platform data bond

2015-10-13 Thread Robert Jarzmik
In order to prepare the transition to a mixed platform data and device-tree initialization, remove all the platform data references all over the driver. Copy the platform data into the internal structure of the pxafb, and only use this afterward. Signed-off-by: Robert Jarzmik <robert.j

[PATCH v2 2/3] dmaengine: enable DMA_CTRL_REUSE

2015-10-13 Thread Robert Jarzmik
: Add DMA_CTRL_REUSE") Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/dma/dmaengine.c | 1 + include/linux/dmaengine.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c index 09479d4be4db..0d64dc8627a8 100644 --- a/drivers

[PATCH v2 1/3] dmaengine: virt-dma: don't always free descriptor upon completion

2015-10-13 Thread Robert Jarzmik
is set in the transfer. This patch is a respin of the former DMA_CTRL_ACK approach, which was reverted due to a regression in audio drivers. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: added doxygen commit to vchan_tx_desc_free --- drivers/dma/vir

[PATCH v2 3/3] dmaengine: pxa_dma: declare transfer are reusable

2015-10-13 Thread Robert Jarzmik
As this driver provides a mechanism to reuse transfers, declare it in its probe function. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/dma/pxa_dma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c index fc4156

Re: [PATCH v4 02/26] ARM: pxa: magician: Change comments to be more informative

2015-10-13 Thread Robert Jarzmik
Philipp Zabel writes: > Am Montag, den 28.09.2015, 23:10 +0200 schrieb Petr Cvek: >> This patch changes the comments in the HTC Magician machine source >> code >> to better describe used devices and interfaces. >> >> Signed-off-by: Petr Cvek Queued to

Re: [PATCH v4 21/26] ARM: pxa: magician: Add support for PXA27x UDC

2015-10-13 Thread Robert Jarzmik
Philipp Zabel writes: > Acked-by: Philipp Zabel Comments used and pushed into pxa/for-next, thanks. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH v4 20/26] ARM: pxa: magician: Add support for MAX1587A Vcore regulator

2015-10-13 Thread Robert Jarzmik
Philipp Zabel writes: >> +static struct regulator_init_data magician_max1587a_v3_info = { >> +.constraints = { >> +.name = "vcc_core range", >> +.min_uV = 70, >> +.max_uV = 150, > > Wouldn't that

Re: [PATCH 28/37] usb: gadget: pxa27x_udc: add ep capabilities support

2015-07-08 Thread Robert Jarzmik
Robert Baldyga r.bald...@samsung.com writes: Convert endpoint configuration to new capabilities model. The commit message is very short to judge the patch's correctness. I'll side up with Felipe's opinion. If it's fine by him, so it is by me. Cheers. -- Robert -- To unsubscribe from this

[PATCH] ARM: pxa: fix dm9000 platform data regression

2015-07-11 Thread Robert Jarzmik
() function. This was discovered and tested on the cm-x300 board. Fixes: 7994fe55a4a2 (dm9000: Add regulator and reset support to dm9000) Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- arch/arm/mach-pxa/capc7117.c | 3 +++ arch/arm/mach-pxa/cm-x2xx.c| 3 +++ arch/arm/mach

Re: [PATCH v2 3/4] media: pxa_camera: trivial move of dma irq functions

2015-07-12 Thread Robert Jarzmik
Guennadi Liakhovetski g.liakhovet...@gmx.de writes: diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b/drivers/media/platform/soc_camera/pxa_camera.c index c0c0f0f..1ab4f9d 100644 --- a/drivers/media/platform/soc_camera/pxa_camera.c +++

Re: [PATCH v2 1/4] media: pxa_camera: fix the buffer free path

2015-07-12 Thread Robert Jarzmik
Guennadi Liakhovetski g.liakhovet...@gmx.de writes: Hi Robert, On Sun, 5 Jul 2015, Robert Jarzmik wrote: From: Robert Jarzmik robert.jarz...@intel.com Fix the error path where the video buffer wasn't allocated nor mapped. In this case, in the driver free path don't try to unmap memory

Re: [PATCH v2 4/4] media: pxa_camera: conversion to dmaengine

2015-07-12 Thread Robert Jarzmik
Guennadi Liakhovetski g.liakhovet...@gmx.de writes: /* init DMA for Y channel */ How about taking the loop over the sg list out of pxa_init_dma_channel() to avoid having to iterate it from the beginning each time? Then you would be able to split it into channels inside that

[PATCH v5 1/2] video: fbdev: pxafb: loosen the platform data bond

2015-11-17 Thread Robert Jarzmik
In order to prepare the transition to a mixed platform data and device-tree initialization, remove all the platform data references all over the driver. Copy the platform data into the internal structure of the pxafb, and only use this afterward. Signed-off-by: Robert Jarzmik <robert.j

[PATCH v5 2/2] video: fbdev: pxafb: initial devicetree conversion

2015-11-17 Thread Robert Jarzmik
configurations with different bits per pixel, only the LCD hardware bus width is used. The patch was tested on both pxa25x, pxa27x and pxa3xx platform (namely lubbock, mainstone and zylonite). Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: Philipp's review: of_graph

Re: [PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal

2015-08-29 Thread Robert Jarzmik
Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes: Robert, On 24 August 2015 at 15:24, Robert Jarzmik robert.jarz...@free.fr wrote: Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes: Should we worry about having two definitions for the same bit? Would it be too ugly to mix the two

Re: [PATCH] mtd: nand: pxa3xx-nand: switch to dmaengine

2015-08-29 Thread Robert Jarzmik
Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes: Robert, On 24 Aug 08:41 PM, Robert Jarzmik wrote: Now pxa architecture has a dmaengine driver, remove the access to direct dma registers in favor of the more generic dmaengine code. This should be also applicable for mmp and orion

[PATCH v4 2/4] media: pxa_camera: move interrupt to tasklet

2015-08-30 Thread Robert Jarzmik
From: Robert Jarzmik robert.jarz...@intel.com In preparation for dmaengine conversion, move the camera interrupt handling into a tasklet. This won't change the global flow, as this interrupt is only used to detect the end of frame and activate DMA fifos handling. Signed-off-by: Robert Jarzmik

Re: [PATCH v3 3/4] media: pxa_camera: trivial move of dma irq functions

2015-08-30 Thread Robert Jarzmik
Guennadi Liakhovetski g.liakhovet...@gmx.de writes: This still seems to break compilation to me. Could you compile-test after each your patch, please? Ah yes. Ill timing, I had sent the v4 before having these comments, so I'll have to fix it in v5. Cheers. -- Robert -- To unsubscribe from

[PATCH] mtd: nand: pxa3xx: add optional dma for pxa architecture

2015-08-30 Thread Robert Jarzmik
The PXA architecture provides a DMA to pump data from the nand controller to memory and the other way around. Add it to the binding description. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- Documentation/devicetree/bindings/mtd/pxa3xx-nand.txt | 3 +++ 1 file changed, 3 insertions

[PATCH v4 4/4] media: pxa_camera: conversion to dmaengine

2015-08-30 Thread Robert Jarzmik
planes captures (Y, U, V). Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- Since v1: Guennadi's fixes dma tasklet functions prototypes change (trivial move) Since v2: sglist cut revamped with Guennadi's comments Since v3: sglist split removed after Andrew's merge in -mm tree in lib

[PATCH v4 0/4] media: pxa_camera: conversion to dmaengine

2015-08-30 Thread Robert Jarzmik
Hi Guennadi, This is the forth round. This time sg_split() was a consequence of (a) and (b), ie. sg_split() move into kernel's lib/ directory, and following dmaengine reuse flag introduction, change pxa_camera accordingly. Happy review. Cheers. Robert Jarzmik (4): media: pxa_camera: fix

[PATCH v2] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal

2015-08-30 Thread Robert Jarzmik
. This effectively prevents a lockup on zylonite when removing pxa3xx-nand module, and using ethernet afterwards. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- Since v1: add comment, switch to NFCV1/NCFV2 registers naming --- drivers/mtd/nand/pxa3xx_nand.c | 17 +++-- 1 file

[PATCH v4 1/4] media: pxa_camera: fix the buffer free path

2015-08-30 Thread Robert Jarzmik
From: Robert Jarzmik robert.jarz...@intel.com Fix the error path where the video buffer wasn't allocated nor mapped. In this case, in the driver free path don't try to unmap memory which was not mapped in the first place. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/media

[PATCH v4 3/4] media: pxa_camera: trivial move of dma irq functions

2015-08-30 Thread Robert Jarzmik
From: Robert Jarzmik robert.jarz...@intel.com This moves the dma irq handling functions up in the source file, so that they are available before DMA preparation functions. It prepares the conversion to DMA engine, where the descriptors are populated with these functions as callbacks. Signed-off

Re: [PATCH v3 4/4] media: pxa_camera: conversion to dmaengine

2015-08-30 Thread Robert Jarzmik
Guennadi Liakhovetski g.liakhovet...@gmx.de writes: +last_buf = list_entry(pcdev-capture.prev, + struct pxa_buffer, vb.queue); You can use list_last_entry() Ok. +last_status = dma_async_is_tx_complete(pcdev-dma_chans[chan], +

[PATCH] ARM: fix alignement of __bug_table section entries

2015-09-02 Thread Robert Jarzmik
in __bug_table are all aligned to at least of multiple of 4. This transforms a module section __bug_table as : - [12] __bug_table PROGBITS 002232 18 00 A 0 0 1 + [12] __bug_table PROGBITS 002232 18 00 A 0 0 4 Signed-off-by: Robert

Re: [PATCH] ARM: fix alignement of __bug_table section entries

2015-09-06 Thread Robert Jarzmik
Russell King - ARM Linux writes: >> [1] Approach 1 : translation table sync >> === ... > The important place is in arch/arm/include/asm/domain.h, which is where > we manipulate the DACR within probe_kernel_address(). Gah, silly me. But

Re: [PATCH] ARM: fix alignement of __bug_table section entries

2015-09-05 Thread Robert Jarzmik
Dave Martin <dave.mar...@arm.com> writes: > On Wed, Sep 02, 2015 at 08:23:29AM +0200, Robert Jarzmik wrote: >> On old ARM chips, unaligned accesses to memory are not trapped and >> fixed. On module load, symbols are relocated, and the relocation of >> __bug_table sym

Re: [PATCH] ARM: fix alignement of __bug_table section entries

2015-09-05 Thread Robert Jarzmik
Russell King - ARM Linux writes: >> Moreover, this is consistent with the fact that this commit is in linux-next >> but >> not in v4.1 : >> a5e090acbf54 ("ARM: software-based priviledged-no-access support") >> >> So the issue is around this SW_DOMAIN_PAN, at least

Re: [PATCH] ARM: fix alignement of __bug_table section entries

2015-09-08 Thread Robert Jarzmik
Russell King - ARM Linux writes: > What should happen is: Thanks very much for the explanation, hopefully I have enough material to fly on my own now. > Now, when you get the fault inside arm_copy_from_user(), you can > print the DACR value saved at the time the fault

[PATCH 0/3] net: irda: pxaficp_ir: dmaengine conversion

2015-09-03 Thread Robert Jarzmik
-- Robert Robert Jarzmik (3): net: irda: pxaficp_ir: use sched_clock() for time management net: irda: pxaficp_ir: convert to readl and writel net: irda: pxaficp_ir: dmaengine conversion drivers/net/irda/pxaficp_ir.c | 366 +++--- 1 file changed, 233 insertions

[PATCH 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-03 Thread Robert Jarzmik
Instead of using directly the OS timer through direct register access, use the standard sched_clock(), which will end up in OSCR reading anyway. This is a first step for direct access register removal and machine specific code removal from this driver. Signed-off-by: Robert Jarzmik <robert.j

[PATCH 3/3] net: irda: pxaficp_ir: dmaengine conversion

2015-09-03 Thread Robert Jarzmik
Convert pxaficp_ir to dmaengine. As pxa architecture is shifting from raw DMA registers access to pxa_dma dmaengine driver, convert this driver to dmaengine. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/net/irda/pxaficp_ir.c

[PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-03 Thread Robert Jarzmik
Convert the pxa IRDA driver to readl and writel primitives, and remove another set of direct registers access. This leaves only the DMA registers access, which will be dealt with dmaengine conversion. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/net/irda/pxaficp_ir.c

Re: [PATCH] ARM: fix alignement of __bug_table section entries

2015-09-05 Thread Robert Jarzmik
Russell King - ARM Linux <li...@arm.linux.org.uk> writes: > On Sat, Sep 05, 2015 at 03:48:38PM +0200, Robert Jarzmik wrote: >> This time I took my JTAG to have a look at the flow, in >> arch/arm/mm/alignment.c, >> where I added the small chunk in [2], which gave in my

Re: [PATCH] mtd: nand: pxa3xx-nand: switch to dmaengine

2015-09-05 Thread Robert Jarzmik
Ezequiel Garcia writes: > Robert, > > Just a couple of minor comments. >> +dma_unmap_sg(info->dma_chan->device->dev, >> + >sg, 1, info->dma_dir); > > Unneeded line breaking. Indeed, for v2. >> +r = platform_get_resource(pdev,

[PATCH v2] mtd: nand: pxa3xx-nand: switch to dmaengine

2015-09-06 Thread Robert Jarzmik
to make the driver work in a devicetree environment. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Reviewed-by: Ezequiel Garcia <ezequ...@vanguardiasur.com.ar> Tested-by: Ezequiel Garcia <ezequ...@vanguardiasur.com.ar> --- Since v1: dma_unmap_sg() line break fix ---

[PATCH v5 4/4] media: pxa_camera: conversion to dmaengine

2015-09-06 Thread Robert Jarzmik
planes captures (Y, U, V). Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: Guennadi's fixes dma tasklet functions prototypes change (trivial move) Since v2: sglist cut revamped with Guennadi's comments Since v3: sglist split removed after Andrew's merge in -mm tree

[PATCH v5 2/4] media: pxa_camera: move interrupt to tasklet

2015-09-06 Thread Robert Jarzmik
In preparation for dmaengine conversion, move the camera interrupt handling into a tasklet. This won't change the global flow, as this interrupt is only used to detect the end of frame and activate DMA fifos handling. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers

[PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2015-09-06 Thread Robert Jarzmik
Fix the error path where the video buffer wasn't allocated nor mapped. In this case, in the driver free path don't try to unmap memory which was not mapped in the first place. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v3: take into account the 2 paths possibi

[PATCH v5 3/4] media: pxa_camera: trivial move of dma irq functions

2015-09-06 Thread Robert Jarzmik
This moves the dma irq handling functions up in the source file, so that they are available before DMA preparation functions. It prepares the conversion to DMA engine, where the descriptors are populated with these functions as callbacks. Signed-off-by: Robert Jarzmik <robert.jarz...@free

[PATCH 3/3] dmaengine: pxa_dma: declare transfer are reusable

2015-09-06 Thread Robert Jarzmik
As this driver provides a mechanism to reuse transfers, declare it in its probe function. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/dma/pxa_dma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c index ddcbbf

[PATCH 1/3] dmaengine: virt-dma: don't always free descriptor upon completion

2015-09-06 Thread Robert Jarzmik
is set in the transfer. This patch is a respin of the former DMA_CTRL_ACK approach, which was reverted due to a regression in audio drivers. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/dma/virt-dma.c | 36 ++-- drivers/dma/vir

[PATCH 2/3] dmaengine: enable DMA_CTRL_REUSE

2015-09-06 Thread Robert Jarzmik
: Add DMA_CTRL_REUSE") Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/dma/dmaengine.c | 1 + include/linux/dmaengine.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c index 3ff284c8e3d5..bb33e2ff5a42 100644 --- a/drivers

Re: [PATCH] ARM: fix alignement of __bug_table section entries

2015-09-06 Thread Robert Jarzmik
Russell King - ARM Linux <li...@arm.linux.org.uk> writes: > On Sat, Sep 05, 2015 at 07:10:49PM +0200, Robert Jarzmik wrote: >> Russell King - ARM Linux <li...@arm.linux.org.uk> writes: >> So the issue is around this SW_DOMAIN_PAN, at least on PXA. > > If so, you m

Re: [PATCH] ARM: fix alignement of __bug_table section entries

2015-09-08 Thread Robert Jarzmik
Russell King - ARM Linux writes: >> Gah, silly me. But even with [1], I still get an error [2]. I have a >> confirmation that I have a "Page Permission" fault on the >> probe_kernel_address(). > > Hmm, that's not right. If it's the DACR, then it should be a page domain >

Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-09 Thread Robert Jarzmik
robably can be used for normal UART). That's because you have to remove from magician.c: pxa_set_stuart_info(NULL); Cheers. -- Robert [1] >From ea242c5b1c4dcdf2a99ea604ee542ded5e6384b9 Mon Sep 17 00:00:00 2001 From: Robert Jarzmik <robert.jarz...@free.fr> Date: Sat, 29 Aug 2015 00:37:5

Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-10 Thread Robert Jarzmik
Petr Cvek <petr.c...@tul.cz> writes: > Dne 9.9.2015 v 08:25 Robert Jarzmik napsal(a): >> Petr Cvek <petr.c...@tul.cz> writes: >> >>> Dne 8.9.2015 v 22:24 Petr Cvek napsal(a): >>>> >>>> Did you defined resources somewhere? Actual res

[PATCH 1/2] dma: pxa_dma: fix the no-requestor case

2015-09-10 Thread Robert Jarzmik
A very small number of devices don't use the flow control offered by requestor lines. In these specific cases, the pxa dma driver should be aware of that and not try to use a requestor line. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/dma/pxa_dma.

[PATCH 2/2] dma: pxa_dma: fix residue corner case

2015-09-10 Thread Robert Jarzmik
_tx_status() } while (residue > 0 || status != DMA_ERROR) Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/dma/pxa_dma.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c index 5647c1579c44..bf064277518e 10064

Re: [PATCH] ARM: fix alignement of __bug_table section entries

2015-09-09 Thread Robert Jarzmik
Russell King - ARM Linux <li...@arm.linux.org.uk> writes: > On Tue, Sep 08, 2015 at 07:01:00PM +0200, Robert Jarzmik wrote: >> Russell King - ARM Linux <li...@arm.linux.org.uk> writes: > At the point we call into this code, the DACR should be 0x75, which > should allow

Re: [BUG] Kernel error when first driver unbind with empty MMC slot

2015-09-13 Thread Robert Jarzmik
Petr Cvek writes: > During testing of these patches > > [PATCH] mmc: pxamci: fix card detect threaded interrupt > [PATCH 1/3] dmaengine: virt-dma: don't always free descriptor upon > completion > > I have found unrelated error. > > How to reproduce: > > 1) Remove

Re: [PATCH] mmc: pxamci: fix card detect threaded interrupt

2015-09-16 Thread Robert Jarzmik
Ulf Hansson <ulf.hans...@linaro.org> writes: > On 12 September 2015 at 11:03, Robert Jarzmik <robert.jarz...@free.fr> wrote: >> Change the interrupt flavor of the card detection, from a hard interrupt >> to a threaded interrupt. There is no strong requirem

Re: [PATCH] net: smc91x: convert pxa dma to dmaengine

2015-09-16 Thread Robert Jarzmik
David Miller <da...@davemloft.net> writes: > From: Robert Jarzmik <robert.jarz...@free.fr> > Date: Thu, 10 Sep 2015 21:26:04 +0200 > >> Convert the dma transfers to be dmaengine based, now pxa has a dmaengine >> slave driver. This makes this driver a bit mor

Re: [PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-16 Thread Robert Jarzmik
David Miller <da...@davemloft.net> writes: > From: Robert Jarzmik <robert.jarz...@free.fr> > Date: Sat, 12 Sep 2015 13:45:22 +0200 > >> Instead of using directly the OS timer through direct register access, >> use the standard sched_clock(), which will

Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-11 Thread Robert Jarzmik
Petr Cvek writes: >> Should have been posted to linux arm kernel mailing list, unless my mailer >> failed ... >> > Searching for: > > "ARM: pxa: add resources to pxaficp_ir" > > did not found anything, same was for "ficp" in the > linux-arm-kernel/netdev/linux-kernel >

Re: [PATCH] ata: pata_pxa: dmaengine conversion

2015-09-11 Thread Robert Jarzmik
Tejun Heo <t...@kernel.org> writes: > On Thu, Sep 10, 2015 at 09:07:49PM +0200, Robert Jarzmik wrote: >> The PXA architecture was offered a slave dmaengine support. As a >> consequence the direct DMA registers are progressively replaced by >> dmaengine support. >

[PATCH] mmc: pxamci: fix card detect threaded interrupt

2015-09-12 Thread Robert Jarzmik
interrupt is called from a threaded interrupt. The request_irq() fails, because a hard irq cannot be a nested interrupt from a threaded interrupt (set __setup_irq()). This was tested on zylonite and mioa701 boards. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Cc: Petr Cvek <petr.c.

Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-12 Thread Robert Jarzmik
Petr Cvek writes: And it is true I have not tested the rootfs special case, where drivers are not yet initialized (and more specifically gpio and interrupt chip). Your backtrace should tell me if you fall into this category of issues ... but I

[PATCH] ASoC: fix broken pxa SoC support

2015-09-15 Thread Robert Jarzmik
xa2xx-ac97 compilation. Fixes: 846172dfe33c ("ASoC: fix SND_PXA2XX_LIB Kconfig warning") Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- sound/arm/Kconfig | 15 --- sound/soc/pxa/Kconfig | 2 -- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a

[PATCH v2] mmc: pxamci: fix card detect with slot-gpio API

2015-09-16 Thread Robert Jarzmik
cannot be a nested interrupt from a threaded interrupt (set __setup_irq()). This was tested on zylonite and mioa701 boards. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Cc: Petr Cvek <petr.c...@tul.cz> --- Since v1: trade threaded interrupt for slot-gpio API --- drivers/mmc/h

Re: [PATCH 1/3] dmaengine: virt-dma: don't always free descriptor upon completion

2015-09-16 Thread Robert Jarzmik
Robert Jarzmik <robert.jarz...@free.fr> writes: > Robert Jarzmik <robert.jarz...@free.fr> writes: > Hi Jun, Lars-Peter and Vinod, > > The revert of the former patch of this type, 8c8fe97b2b8a ("Revert "dmaengine: > virt-dma: don't always free descriptor upon

[PATCH] ARM: pxa: add wm9713 codec

2015-09-16 Thread Robert Jarzmik
The mioa701 is using the wm9713 for audio, battery and touchscreen. Add the missing audio part, which disappeared. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- arch/arm/mach-pxa/mioa701.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-pxa/mioa701.c b/ar

Re: [PATCH v2] mmc: pxamci: fix card detect with slot-gpio API

2015-09-17 Thread Robert Jarzmik
Ulf Hansson writes: >> + if (gpio_is_valid(gpio_ro)) >> + ret = mmc_gpio_request_ro(mmc, gpio_ro); > > Would it be possible for you to use the mmc_gpiod_request_ro() instead? I don't think so. Most of pxamci users are old platform data based machine

[PATCH] ata: pata_pxa: dmaengine conversion

2015-09-10 Thread Robert Jarzmik
-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/ata/pata_pxa.c | 171 + 1 file changed, 59 insertions(+), 112 deletions(-) diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c index c36b3e6531d8..f6c46e9a4dc0 100644 --- a/drive

[PATCH] net: smc91x: convert pxa dma to dmaengine

2015-09-10 Thread Robert Jarzmik
Convert the dma transfers to be dmaengine based, now pxa has a dmaengine slave driver. This makes this driver a bit more PXA agnostic. The driver was tested on pxa27x (mainstone) and pxa310 (zylonite), ie. only pxa platforms. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Cc: R

Re: [PATCH] ARM: fix alignement of __bug_table section entries

2015-09-10 Thread Robert Jarzmik
Robert Jarzmik <robert.jarz...@free.fr> writes: > Russell King - ARM Linux <li...@arm.linux.org.uk> writes: > >> On Tue, Sep 08, 2015 at 07:01:00PM +0200, Robert Jarzmik wrote: >>> Russell King - ARM Linux <li...@arm.linux.org.uk> writes: >> At the

Re: [PATCH 2/2] ARM: domains: add memory dependencies to get_domain/set_domain

2015-09-11 Thread Robert Jarzmik
n() should therefore cause the compiler to > re-load this. The other advantage of using this is we should have its > address in the register set already, or very soon after at most call > sites. > > Signed-off-by: Russell King <rmk+ker...@arm.linux.org.uk> Tested-by: Robert J

Re: [PATCH] ARM: fix alignement of __bug_table section entries

2015-09-10 Thread Robert Jarzmik
Russell King - ARM Linux writes: > I've been wondering whether we can teach GCC that set_domain modifies > the value that get_domain returns, rather than throwing a volatile > onto the asm in get_domain. The issue with a volatile there is that > even if the result is

Re: [PATCH 2/2] ARM: domains: add memory dependencies to get_domain/set_domain

2015-09-11 Thread Robert Jarzmik
Russell King - ARM Linux writes: > If you want to put the bug alignment patch in the patch system, I'll get > that off to Linus this weekend too. Sure, that will be done before tomorrow evening. Cheers. -- Robert -- To unsubscribe from this list: send the line

[PATCH] ARM: pxa: add resources to pxaficp_ir

2015-09-12 Thread Robert Jarzmik
Add io memory and dma requestor lines to the irda pxa device. This is part of the conversion of pxaficp_ir to dmaengine, and to shrink its adherence to 'mach' includes. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Cc: Petr Cvek <petr.c...@tul.cz> --- arch/arm/mach-pxa/de

[PATCH v2 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-12 Thread Robert Jarzmik
Convert the pxa IRDA driver to readl and writel primitives, and remove another set of direct registers access. This leaves only the DMA registers access, which will be dealt with dmaengine conversion. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: modified __REG

[PATCH v2 3/3] net: irda: pxaficp_ir: dmaengine conversion

2015-09-12 Thread Robert Jarzmik
Convert pxaficp_ir to dmaengine. As pxa architecture is shifting from raw DMA registers access to pxa_dma dmaengine driver, convert this driver to dmaengine. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: removed mach/dma.h include, which is the goal --- drivers/ne

[PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-12 Thread Robert Jarzmik
Instead of using directly the OS timer through direct register access, use the standard sched_clock(), which will end up in OSCR reading anyway. This is a first step for direct access register removal and machine specific code removal from this driver. Signed-off-by: Robert Jarzmik <robert.j

Re: [PATCH 1/3] dmaengine: virt-dma: don't always free descriptor upon completion

2015-09-12 Thread Robert Jarzmik
Robert Jarzmik <robert.jarz...@free.fr> writes: > This patch attempts to enhance the case of a transfer submitted multiple > times, and where the cost of creating the descriptors chain is not > negligible. > > This happens with big video buffers (several megabytes, ie

Re: [PATCH] ARM: pxa: fix DFI bus lockups on startup

2015-09-12 Thread Robert Jarzmik
Robert Jarzmik <robert.jarz...@free.fr> writes: > After the conversion of pxa architecture to common clock framework, the > NAND clock can be disabled on startup if no nand driver claims it. > > In this case, it happens that if the bootloader used the NAND and set > th

[PATCH v2 REBASED] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal

2015-09-28 Thread Robert Jarzmik
. This effectively prevents a lockup on zylonite when removing pxa3xx-nand module, and using ethernet afterwards. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: add comment, switch to NFCV1/NCFV2 registers naming Since v2: rebase on top of Brian's tree --- drivers/mt

Re: [PATCH 1/2] dma: pxa_dma: fix the no-requestor case

2015-09-30 Thread Robert Jarzmik
Vinod Koul <vinod.k...@intel.com> writes: > On Thu, Sep 10, 2015 at 07:17:45PM +0200, Robert Jarzmik wrote: >> A very small number of devices don't use the flow control offered by >> requestor lines. In these specific cases, the pxa dma driver should be >> aware

[PATCH v2 1/2] dma: pxa_dma: fix the no-requestor case

2015-09-30 Thread Robert Jarzmik
A very small number of devices don't use the flow control offered by requestor lines. In these specific cases, the pxa dma driver should be aware of that and not try to use a requestor line. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: rebase on v4.3-rc3 --- drive

<    1   2   3   4   5   6   7   8   9   10   >