[PATCH] ASoC: Fix UBSAN warning at snd_soc_get/put_volsw_sx()

2018-09-10 Thread Rohit kumar
bsan.c:195 [] __ubsan_handle_sub_overflow+0x34/0x44 lib/ubsan.c:211 [] snd_soc_get_volsw_sx+0x1a8/0x1f8 sound/soc/soc-ops.c:382 Typecast the operation to unsigned int to fix the issue. Signed-off-by: Rohit kumar --- sound/soc/soc-ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc

Re: [PATCH v3 1/2] dt-binding: remoteproc: Add QTI ADSP PIL bindings

2018-09-10 Thread Rohit Kumar
Thanks Rob for reviewing. On 9/11/2018 1:31 AM, Rob Herring wrote: On Mon, Sep 03, 2018 at 05:22:39PM +0530, Rohit kumar wrote: Add devicetree bindings documentation file for Qualcomm Technolgies Inc ADSP Peripheral Image Loader. Signed-off-by: Rohit kumar --- .../bindings/remoteproc/qcom

Re: [PATCH v3 2/2] remoteproc: qcom: Introduce Non-PAS ADSP PIL driver

2018-09-10 Thread Rohit Kumar
Thanks Bjorn for reviewing. On 9/11/2018 12:01 AM, Bjorn Andersson wrote: On Mon 03 Sep 04:52 PDT 2018, Rohit kumar wrote: This adds Non PAS ADSP PIL driver for Qualcomm Technologies Inc SoCs. Added initial support for SDM845 with ADSP bootup and shutdown operation handled from Application

[PATCH v4] dt-binding: remoteproc: Add QTI ADSP PIL bindings

2018-09-10 Thread Rohit kumar
Add devicetree bindings documentation file for Qualcomm Technolgies Inc ADSP Peripheral Image Loader. Signed-off-by: Rohit kumar --- Changes since v3: Addressed comments given by Rob .../bindings/remoteproc/qcom,adsp-pil.txt | 126 + 1 file changed, 126 insertions

Re: [alsa-devel] [PATCH] ASoC: Fix UBSAN warning at snd_soc_get/put_volsw_sx()

2018-09-11 Thread Rohit Kumar
Thanks Takashi for reviewing. On 9/10/2018 11:56 PM, Takashi Iwai wrote: On Mon, 10 Sep 2018 19:33:56 +0200, Rohit kumar wrote: In functions snd_soc_get_volsw_sx() or snd_soc_put_volsw_sx(), if the result of (min + max) is negative, then fls() returns signed integer with value as 32. This

[PATCH v2] ASoC: Fix UBSAN warning at snd_soc_get/put_volsw_sx()

2018-09-11 Thread Rohit kumar
bsan.c:195 [] __ubsan_handle_sub_overflow+0x34/0x44 lib/ubsan.c:211 [] snd_soc_get_volsw_sx+0x1a8/0x1f8 sound/soc/soc-ops.c:382 Typecast the operation to unsigned int to fix the issue. Signed-off-by: Rohit kumar --- Changes since v1: Addressed comments given by Takashi. sound/soc/soc-ops.c | 4 ++-- 1 file

[PATCH v3 0/2] Add ADSP PIL driver for SDM845

2018-09-03 Thread Rohit kumar
renaming of Hexagon v5 PAS driver https://lkml.org/lkml/2018/8/28/129 . Rohit kumar (2): dt-binding: remoteproc: Add QTI ADSP PIL bindings remoteproc: qcom: Introduce Non-PAS ADSP PIL driver .../bindings/remoteproc/qcom,adsp-pil.txt | 123 + drivers/remoteproc/Kconfig

[PATCH v3 2/2] remoteproc: qcom: Introduce Non-PAS ADSP PIL driver

2018-09-03 Thread Rohit kumar
This adds Non PAS ADSP PIL driver for Qualcomm Technologies Inc SoCs. Added initial support for SDM845 with ADSP bootup and shutdown operation handled from Application Processor SubSystem(APSS). Signed-off-by: Rohit kumar --- drivers/remoteproc/Kconfig | 14 ++ drivers/remoteproc

[PATCH v3 1/2] dt-binding: remoteproc: Add QTI ADSP PIL bindings

2018-09-03 Thread Rohit kumar
Add devicetree bindings documentation file for Qualcomm Technolgies Inc ADSP Peripheral Image Loader. Signed-off-by: Rohit kumar --- .../bindings/remoteproc/qcom,adsp-pil.txt | 123 + 1 file changed, 123 insertions(+) create mode 100644 Documentation/devicetree

Re: [alsa-devel] [PATCH v7 16/24] ASoC: qdsp6: q6asm: Add support to audio stream apis

2018-05-04 Thread Rohit Kumar
On 5/1/2018 5:38 PM, Srinivas Kandagatla wrote: +static int __q6asm_run(struct audio_client *ac, uint32_t flags, + uint32_t msw_ts, uint32_t lsw_ts, bool wait) +{ + struct asm_session_cmd_run_v2 *run; + struct apr_pkt *pkt; + int pkt_size, rc; + void *p; + +

[PATCHv2 1/1] staging/ion: Add support to get ion handle from dma buf

2016-01-05 Thread Rohit kumar
a_buf. This patch exposes api to retrieve the ion handle from dma_buf for similar use cases. With this patch, we can integrate ION within DRM-GEM for buffer management and dma_buf sharing. Signed-off-by: Rohit kumar --- v2: Updated commit message with use case explanation, as suggested by

[PATCH v3 0/8] ASoC: qcom: Add support for SC7180 lpass variant

2020-07-07 Thread Rohit kumar
: Replace card->dev with component->dev ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio dt-bindings: sound: lpass-cpu: Move to yaml format Rohit kumar (3): ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function ASoC: qcom: lpass: Use regmap_field for i2sc

[PATCH v3 3/8] ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers

2020-07-07 Thread Rohit kumar
I2SCTL and DMACTL registers has different bits alignment for newer LPASS variants of SC7180 soc. Use REG_FIELD_ID() to define the reg_fields in platform specific file and removed shifts and mask macros for such registers from header file. Signed-off-by: Rohit kumar --- sound/soc/qcom/lpass

[PATCH v3 1/8] ASoC: qcom: Add common array to initialize soc based core clocks

2020-07-07 Thread Rohit kumar
-off-by: Ajit Pandey Signed-off-by: Rohit kumar --- sound/soc/qcom/lpass-apq8016.c | 39 +++ sound/soc/qcom/lpass.h | 10 +++--- 2 files changed, 26 insertions(+), 23 deletions(-) diff --git a/sound/soc/qcom/lpass-apq8016.c b/sound/soc/qcom/lpass

[PATCH v3 5/8] ASoC: qcom: lpass-platform: Replace card->dev with component->dev

2020-07-07 Thread Rohit kumar
From: Ajit Pandey We are allocating dma memory for component->dev but trying to mmap such memory for substream->pcm->card->dev. Replace device argument in mmap with component->dev to fix this. Signed-off-by: Ajit Pandey --- sound/soc/qcom/lpass-platform.c | 5 ++--- 1 file changed, 2 insertion

[PATCH v3 2/8] ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function

2020-07-07 Thread Rohit kumar
Ahbix clock is optional clock and not needed for all platforms. Move it to lpass-apq8016/ipq806x as it is not needed for sc7180. Signed-off-by: Rohit kumar --- sound/soc/qcom/lpass-apq8016.c | 27 ++ sound/soc/qcom/lpass-cpu.c | 40

[PATCH v3 4/8] include: dt-bindings: sound: Add sc7180-lpass bindings header

2020-07-07 Thread Rohit kumar
From: Ajit Pandey Add header defining dai-id and mclk id for SC7180 lpass soc. Signed-off-by: Ajit Pandey --- include/dt-bindings/sound/sc7180-lpass.h | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 include/dt-bindings/sound/sc7180-lpass.h diff --git a/include/dt-binding

[PATCH v3 7/8] ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio

2020-07-07 Thread Rohit kumar
From: Ajit Pandey Add platform driver for configuring sc7180 lpass core I2S and DMA configuration to support playback & capture to external codecs connected over primary & secondary MI2S interfaces. Signed-off-by: Ajit Pandey Signed-off-by: Rohit kumar --- sound/soc/qcom/Kconfig

[PATCH v3 6/8] dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node

2020-07-07 Thread Rohit kumar
Add dt-bindings to support "qcom,lpass-cpu-sc7180" node. Signed-off-by: Rohit kumar --- Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt b/Doc

[PATCH v3 8/8] dt-bindings: sound: lpass-cpu: Move to yaml format

2020-07-07 Thread Rohit kumar
From: Ajit Pandey Update lpass-cpu binding with yaml formats. Signed-off-by: Ajit Pandey Signed-off-by: Rohit kumar --- .../devicetree/bindings/sound/qcom,lpass-cpu.txt | 80 --- .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 154 + 2 files changed, 154

[RESEND][PATCH v3 7/8] ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio

2020-07-07 Thread Rohit kumar
From: Ajit Pandey Add platform driver for configuring sc7180 lpass core I2S and DMA configuration to support playback & capture to external codecs connected over primary & secondary MI2S interfaces. Signed-off-by: Ajit Pandey Signed-off-by: Rohit kumar --- Resending to update Signed-

Re: [RESEND][PATCH v3 7/8] ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio

2020-07-08 Thread Rohit Kumar
On 7/8/2020 4:03 PM, Mark Brown wrote: On Wed, Jul 08, 2020 at 10:44:46AM +0530, Rohit kumar wrote: From: Ajit Pandey Add platform driver for configuring sc7180 lpass core I2S and DMA configuration to support playback & capture to external codecs connected over primary & second

[PATCH v5 03/12] ASoC: qcom: lpass-platform: Replace card->dev with component->dev

2020-08-04 Thread Rohit kumar
From: Ajit Pandey We are allocating dma memory for component->dev but trying to mmap such memory for substream->pcm->card->dev. Replace device argument in mmap with component->dev to fix this. Signed-off-by: Ajit Pandey Signed-off-by: Rohit kumar Reviewed-by: Srinivas Kandaga

[PATCH v5 01/12] ASoC: qcom: Add common array to initialize soc based core clocks

2020-08-04 Thread Rohit kumar
-off-by: Ajit Pandey Signed-off-by: Rohit kumar Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/lpass-apq8016.c | 39 +++ sound/soc/qcom/lpass.h | 10 +++--- 2 files changed, 26 insertions(+), 23 deletions(-) diff --git a/sound/soc/qcom/lpass

[PATCH v5 02/12] ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function

2020-08-04 Thread Rohit kumar
Ahbix clock is optional clock and not needed for all platforms. Move it to lpass-apq8016/ipq806x as it is not needed for sc7180. Signed-off-by: Rohit kumar Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/lpass-apq8016.c | 27 ++ sound/soc/qcom/lpass-cpu.c | 40

[PATCH v5 00/12] ASoC: qcom: Add support for SC7180 lpass variant

2020-08-04 Thread Rohit kumar
sc7180-lpass bindings header ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio Rohit kumar (8): ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function ASoC: qcom: lpass-platform: fix memory leak ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers

[PATCH v5 07/12] dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node

2020-08-04 Thread Rohit kumar
Add dt-bindings to support "qcom,lpass-cpu-sc7180" node. Signed-off-by: Rohit kumar --- .../devicetree/bindings/sound/qcom,lpass-cpu.txt | 55 +- 1 file changed, 53 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-

[PATCH v5 04/12] ASoC: qcom: lpass-platform: fix memory leak

2020-08-04 Thread Rohit kumar
lpass_pcm_data is never freed. Free it in close ops to avoid memory leak. Fixes: 022d00ee0b55 ("ASoC: lpass-platform: Fix broken pcm data usage") Signed-off-by: Rohit kumar Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/lpass-platform.c | 3 ++- 1 file changed, 2 insertions(+),

[PATCH v5 05/12] ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers

2020-08-04 Thread Rohit kumar
I2SCTL and DMACTL registers has different bits alignment for newer LPASS variants of SC7180 soc. Use REG_FIELD_ID() to define the reg_fields in platform specific file and removed shifts and mask macros for such registers from header file. Signed-off-by: Rohit kumar --- sound/soc/qcom/lpass

[PATCH v5 12/12] dt-bindings: sound: lpass-cpu: Move to yaml format

2020-08-04 Thread Rohit kumar
Update lpass-cpu binding with yaml formats. Signed-off-by: Rohit kumar --- .../devicetree/bindings/sound/qcom,lpass-cpu.txt | 130 --- .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 179 + 2 files changed, 179 insertions(+), 130 deletions(-) delete mode

[PATCH v5 06/12] ASoC: qcom: lpass-cpu: fix concurrency issue

2020-08-04 Thread Rohit kumar
river") Signed-off-by: Rohit kumar Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/lpass-cpu.c | 16 1 file changed, 16 deletions(-) diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index 6b86f16..5d84f63 100644 --- a/sound/soc/qcom/lpass-cpu.c +++ b

[PATCH v5 11/12] ASoC: qcom: lpass-platform: Use platform_get_irq

2020-08-04 Thread Rohit kumar
platform_get_irq_byname() is used when there is list of interrupts in the device node. As lpass-platform has only one interrupt entry, use platform_get_irq() instead. Signed-off-by: Rohit kumar --- sound/soc/qcom/lpass-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v5 10/12] ASoC: qcom: lpass-cpu: Use platform_get_resource

2020-08-04 Thread Rohit kumar
platform_get_resource_byname() is used when there is list of reg entries. As lpass-cpu node has only one reg entry, use platform_get_resource() instead. Signed-off-by: Rohit kumar Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/lpass-cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v5 09/12] ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio

2020-08-04 Thread Rohit kumar
From: Ajit Pandey Add platform driver for configuring sc7180 lpass core I2S and DMA configuration to support playback & capture to external codecs connected over primary & secondary MI2S interfaces. Signed-off-by: Ajit Pandey Signed-off-by: Rohit kumar Reviewed-by: Srinivas Ka

[PATCH v5 08/12] include: dt-bindings: sound: Add sc7180-lpass bindings header

2020-08-04 Thread Rohit kumar
From: Ajit Pandey Add header defining dai-id and mclk id for SC7180 lpass soc. Signed-off-by: Ajit Pandey Signed-off-by: Rohit kumar Acked-by: Rob Herring --- include/dt-bindings/sound/sc7180-lpass.h | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 include/dt-bindings

Re: [PATCH v4 12/12] dt-bindings: sound: lpass-cpu: Move to yaml format

2020-08-04 Thread Rohit Kumar
On 8/3/2020 11:52 PM, Rob Herring wrote: On Mon, Aug 3, 2020 at 2:28 AM Rohit Kumar wrote: Thanks Rob for reviewing On 7/23/2020 10:46 PM, Rob Herring wrote: On Wed, Jul 22, 2020 at 04:01:55PM +0530, Rohit kumar wrote: Update lpass-cpu binding with yaml formats. Signed-off-by: Rohit

[PATCH v6 01/12] ASoC: qcom: Add common array to initialize soc based core clocks

2020-08-14 Thread Rohit kumar
-off-by: Ajit Pandey Signed-off-by: Rohit kumar Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/lpass-apq8016.c | 39 +++ sound/soc/qcom/lpass.h | 10 +++--- 2 files changed, 26 insertions(+), 23 deletions(-) diff --git a/sound/soc/qcom/lpass

[PATCH v6 00/12] ASoC: qcom: Add support for SC7180 lpass variant

2020-08-14 Thread Rohit kumar
ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio Rohit kumar (8): ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function ASoC: qcom: lpass-platform: fix memory leak ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers ASoC: qcom: lpass-cpu: fix concu

[PATCH v6 05/12] ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers

2020-08-14 Thread Rohit kumar
I2SCTL and DMACTL registers has different bits alignment for newer LPASS variants of SC7180 soc. Use REG_FIELD_ID() to define the reg_fields in platform specific file and removed shifts and mask macros for such registers from header file. Signed-off-by: Rohit kumar --- sound/soc/qcom/lpass

[PATCH v6 04/12] ASoC: qcom: lpass-platform: fix memory leak

2020-08-14 Thread Rohit kumar
lpass_pcm_data is never freed. Free it in close ops to avoid memory leak. Fixes: 022d00ee0b55 ("ASoC: lpass-platform: Fix broken pcm data usage") Signed-off-by: Rohit kumar Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/lpass-platform.c | 3 ++- 1 file changed, 2 insertions(+),

[PATCH v6 08/12] include: dt-bindings: sound: Add sc7180-lpass bindings header

2020-08-14 Thread Rohit kumar
From: Ajit Pandey Add header defining dai-id and mclk id for SC7180 lpass soc. Signed-off-by: Ajit Pandey Signed-off-by: Rohit kumar Acked-by: Rob Herring --- include/dt-bindings/sound/sc7180-lpass.h | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 include/dt-bindings

[PATCH v6 07/12] dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node

2020-08-14 Thread Rohit kumar
Add dt-bindings to support "qcom,lpass-cpu-sc7180" node. Signed-off-by: Rohit kumar --- .../devicetree/bindings/sound/qcom,lpass-cpu.txt | 55 +- 1 file changed, 53 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-

[PATCH v6 02/12] ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function

2020-08-14 Thread Rohit kumar
Ahbix clock is optional clock and not needed for all platforms. Move it to lpass-apq8016/ipq806x as it is not needed for sc7180. Signed-off-by: Rohit kumar Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/lpass-apq8016.c | 27 ++ sound/soc/qcom/lpass-cpu.c | 40

[PATCH v6 09/12] ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio

2020-08-14 Thread Rohit kumar
From: Ajit Pandey Add platform driver for configuring sc7180 lpass core I2S and DMA configuration to support playback & capture to external codecs connected over primary & secondary MI2S interfaces. Signed-off-by: Ajit Pandey Signed-off-by: Rohit kumar Reviewed-by: Srinivas Ka

[PATCH v6 06/12] ASoC: qcom: lpass-cpu: fix concurrency issue

2020-08-14 Thread Rohit kumar
river") Signed-off-by: Rohit kumar Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/lpass-cpu.c | 16 1 file changed, 16 deletions(-) diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index 6b86f16..5d84f63 100644 --- a/sound/soc/qcom/lpass-cpu.c +++ b

[PATCH v6 03/12] ASoC: qcom: lpass-platform: Replace card->dev with component->dev

2020-08-14 Thread Rohit kumar
From: Ajit Pandey We are allocating dma memory for component->dev but trying to mmap such memory for substream->pcm->card->dev. Replace device argument in mmap with component->dev to fix this. Signed-off-by: Ajit Pandey Signed-off-by: Rohit kumar Reviewed-by: Srinivas Kandaga

[PATCH v6 12/12] dt-bindings: sound: lpass-cpu: Move to yaml format

2020-08-14 Thread Rohit kumar
Update lpass-cpu binding with yaml formats. Signed-off-by: Rohit kumar --- .../devicetree/bindings/sound/qcom,lpass-cpu.txt | 130 -- .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 189 + 2 files changed, 189 insertions(+), 130 deletions(-) delete mode

[PATCH v6 11/12] ASoC: qcom: lpass-platform: Use platform_get_irq

2020-08-14 Thread Rohit kumar
platform_get_irq_byname() is used when there is list of interrupts in the device node. As lpass-platform has only one interrupt entry, use platform_get_irq() instead. Signed-off-by: Rohit kumar --- sound/soc/qcom/lpass-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v6 10/12] ASoC: qcom: lpass-cpu: Use platform_get_resource

2020-08-14 Thread Rohit kumar
platform_get_resource_byname() is used when there is list of reg entries. As lpass-cpu node has only one reg entry, use platform_get_resource() instead. Signed-off-by: Rohit kumar Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/lpass-cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH v3 5/8] ASoC: qcom: lpass-platform: Replace card->dev with component->dev

2020-07-08 Thread Rohit Kumar
On 7/8/2020 10:20 PM, Mark Brown wrote: On Wed, Jul 08, 2020 at 10:38:13AM +0530, Rohit kumar wrote: From: Ajit Pandey We are allocating dma memory for component->dev but trying to mmap such memory for substream->pcm->card->dev. Replace device argument in mmap with component

Re: [PATCH v3 3/8] ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers

2020-07-09 Thread Rohit Kumar
Thanks Srini for reviewing. On 7/9/2020 2:56 PM, Srinivas Kandagatla wrote: On 08/07/2020 06:08, Rohit kumar wrote: I2SCTL and DMACTL registers has different bits alignment for newer LPASS variants of SC7180 soc. Use REG_FIELD_ID() to define the reg_fields in platform specific file and

Re: [PATCH v3 6/8] dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node

2020-07-09 Thread Rohit Kumar
On 7/9/2020 2:57 PM, Srinivas Kandagatla wrote: On 08/07/2020 06:08, Rohit kumar wrote: Add dt-bindings to support "qcom,lpass-cpu-sc7180" node. Signed-off-by: Rohit kumar ---   Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt | 3 ++-   1 file changed, 2 insert

Re: [PATCH v3 4/8] include: dt-bindings: sound: Add sc7180-lpass bindings header

2020-07-09 Thread Rohit Kumar
On 7/8/2020 8:15 PM, Mark Brown wrote: On Wed, Jul 08, 2020 at 10:38:12AM +0530, Rohit kumar wrote: From: Ajit Pandey Add header defining dai-id and mclk id for SC7180 lpass soc. Signed-off-by: Ajit Pandey --- This one is missing a signoff as well, and I can't seem to see any refe

Re: [PATCH v3 6/8] dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node

2020-07-09 Thread Rohit Kumar
On 7/9/2020 3:38 PM, Srinivas Kandagatla wrote: On 09/07/2020 11:01, Rohit Kumar wrote: On 7/9/2020 2:57 PM, Srinivas Kandagatla wrote: On 08/07/2020 06:08, Rohit kumar wrote: Add dt-bindings to support "qcom,lpass-cpu-sc7180" node. Signed-off-by: Rohit kumar ---   Doc

Re: [PATCH v3 3/8] ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers

2020-07-09 Thread Rohit Kumar
On 7/9/2020 3:36 PM, Srinivas Kandagatla wrote: On 09/07/2020 10:57, Rohit Kumar wrote: Thanks Srini for reviewing. On 7/9/2020 2:56 PM, Srinivas Kandagatla wrote: On 08/07/2020 06:08, Rohit kumar wrote: I2SCTL and DMACTL registers has different bits alignment for newer LPASS variants

Re: [PATCH v4 00/12] ASoC: qcom: Add support for SC7180 lpass variant

2020-07-27 Thread Rohit Kumar
On 7/24/2020 4:52 PM, Srinivas Kandagatla wrote: On 22/07/2020 11:31, Rohit kumar wrote: This patch chain add audio support for SC7180 soc by doing the required modification in existing common lpass-cpu/lpass-platform driver. This also fixes some concurrency issue. Changes since v3

Re: [PATCH v4 00/12] ASoC: qcom: Add support for SC7180 lpass variant

2020-07-28 Thread Rohit Kumar
On 7/27/2020 3:20 PM, Rohit Kumar wrote: On 7/24/2020 4:52 PM, Srinivas Kandagatla wrote: On 22/07/2020 11:31, Rohit kumar wrote: This patch chain add audio support for SC7180 soc by doing the required modification in existing common lpass-cpu/lpass-platform driver. This also fixes some

Re: [PATCH v2 1/7] Documentation: device-tree: sound: Update lpass-cpu driver binding

2020-07-06 Thread Rohit Kumar
On 5/16/2020 11:07 PM, Ajit Pandey wrote: On 5/14/2020 10:14 PM, Mark Brown wrote: On Thu, May 14, 2020 at 10:08:12PM +0530, Ajit Pandey wrote: Done the required cleanups to update lpass-cpu binding with newer yaml formats. Please do YAML conversions as the last thing in any patch series, th

[PATCH v4 02/12] ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function

2020-07-22 Thread Rohit kumar
Ahbix clock is optional clock and not needed for all platforms. Move it to lpass-apq8016/ipq806x as it is not needed for sc7180. Signed-off-by: Rohit kumar Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/lpass-apq8016.c | 27 ++ sound/soc/qcom/lpass-cpu.c | 40

[PATCH v4 00/12] ASoC: qcom: Add support for SC7180 lpass variant

2020-07-22 Thread Rohit kumar
de: dt-bindings: sound: Add sc7180-lpass bindings header ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio Rohit kumar (8): ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function ASoC: qcom: lpass-platform: fix memory leak ASoC: qcom: lpass: Use regmap_field for i2sc

[PATCH v4 01/12] ASoC: qcom: Add common array to initialize soc based core clocks

2020-07-22 Thread Rohit kumar
-off-by: Ajit Pandey Signed-off-by: Rohit kumar Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/lpass-apq8016.c | 39 +++ sound/soc/qcom/lpass.h | 10 +++--- 2 files changed, 26 insertions(+), 23 deletions(-) diff --git a/sound/soc/qcom/lpass

[PATCH v4 04/12] ASoC: qcom: lpass-platform: fix memory leak

2020-07-22 Thread Rohit kumar
lpass_pcm_data is never freed. Free it in close ops to avoid memory leak. Fixes: 022d00ee0b55 ("ASoC: lpass-platform: Fix broken pcm data usage") Signed-off-by: Rohit kumar --- sound/soc/qcom/lpass-platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/soun

[PATCH v4 09/12] ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio

2020-07-22 Thread Rohit kumar
From: Ajit Pandey Add platform driver for configuring sc7180 lpass core I2S and DMA configuration to support playback & capture to external codecs connected over primary & secondary MI2S interfaces. Signed-off-by: Ajit Pandey Signed-off-by: Rohit kumar Reviewed-by: Srinivas Ka

[PATCH v4 05/12] ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers

2020-07-22 Thread Rohit kumar
I2SCTL and DMACTL registers has different bits alignment for newer LPASS variants of SC7180 soc. Use REG_FIELD_ID() to define the reg_fields in platform specific file and removed shifts and mask macros for such registers from header file. Signed-off-by: Rohit kumar --- sound/soc/qcom/lpass

[PATCH v4 07/12] dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node

2020-07-22 Thread Rohit kumar
Add dt-bindings to support "qcom,lpass-cpu-sc7180" node. Signed-off-by: Rohit kumar --- .../devicetree/bindings/sound/qcom,lpass-cpu.txt | 55 +- 1 file changed, 53 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-

[PATCH v4 08/12] include: dt-bindings: sound: Add sc7180-lpass bindings header

2020-07-22 Thread Rohit kumar
From: Ajit Pandey Add header defining dai-id and mclk id for SC7180 lpass soc. Signed-off-by: Ajit Pandey Signed-off-by: Rohit kumar --- include/dt-bindings/sound/sc7180-lpass.h | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 include/dt-bindings/sound/sc7180-lpass.h

[PATCH v4 06/12] ASoC: qcom: lpass-cpu: fix concurrency issue

2020-07-22 Thread Rohit kumar
river") Signed-off-by: Rohit kumar --- sound/soc/qcom/lpass-cpu.c | 16 1 file changed, 16 deletions(-) diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index 6b86f16..5d84f63 100644 --- a/sound/soc/qcom/lpass-cpu.c +++ b/sound/soc/qcom/lpass-cpu.c @@ -266

[PATCH v4 03/12] ASoC: qcom: lpass-platform: Replace card->dev with component->dev

2020-07-22 Thread Rohit kumar
From: Ajit Pandey We are allocating dma memory for component->dev but trying to mmap such memory for substream->pcm->card->dev. Replace device argument in mmap with component->dev to fix this. Signed-off-by: Ajit Pandey Signed-off-by: Rohit kumar Reviewed-by: Srinivas Kandaga

[PATCH v4 11/12] ASoC: qcom: lpass-platform: Use platform_get_irq

2020-07-22 Thread Rohit kumar
platform_get_irq_byname() is used when there is list of interrupts in the device node. As lpass-platform has only one interrupt entry, use platform_get_irq() instead. Signed-off-by: Rohit kumar --- sound/soc/qcom/lpass-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v4 10/12] ASoC: qcom: lpass-cpu: Use platform_get_resource

2020-07-22 Thread Rohit kumar
platform_get_resource_byname() is used when there is list of reg entries. As lpass-cpu node has only one reg entry, use platform_get_resource() instead. Signed-off-by: Rohit kumar --- sound/soc/qcom/lpass-cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/qcom

[PATCH v4 12/12] dt-bindings: sound: lpass-cpu: Move to yaml format

2020-07-22 Thread Rohit kumar
Update lpass-cpu binding with yaml formats. Signed-off-by: Rohit kumar --- .../devicetree/bindings/sound/qcom,lpass-cpu.txt | 130 --- .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 185 + 2 files changed, 185 insertions(+), 130 deletions(-) delete mode

Re: [PATCH v3 8/8] dt-bindings: sound: lpass-cpu: Move to yaml format

2020-07-22 Thread Rohit Kumar
Thanks Rob for the review. Posted v4 with fixes. On 7/14/2020 4:23 AM, Rob Herring wrote: On Wed, Jul 08, 2020 at 10:38:16AM +0530, Rohit kumar wrote: From: Ajit Pandey Update lpass-cpu binding with yaml formats. Signed-off-by: Ajit Pandey Signed-off-by: Rohit kumar --- .../devicetree

Re: [PATCH v6 3/5] Asoc:qcom:lpass-cpu:Update dts property read API

2020-09-22 Thread Rohit Kumar
On 9/22/2020 5:13 PM, Mark Brown wrote: On Tue, Sep 22, 2020 at 12:22:38PM +0100, Srinivas Kandagatla wrote: On 22/09/2020 12:08, Mark Brown wrote: I agree with you on this and I see the point, but Rob had a very different opinion about the reg-names bindings to start with. This topic been dis

[PATCH] asoc: Update supported rate and format for dummy dai

2020-06-27 Thread Rohit kumar
Add support for 384KHz sample rate and S24_3LE bitwidth for dummy dai. Signed-off-by: Rohit kumar --- sound/soc/soc-utils.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/soc-utils.c b/sound/soc/soc-utils.c index 922eac9..364b248 100644 --- a/sound/soc/soc

Re: [PATCH v2 4/7] ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers

2020-06-27 Thread Rohit Kumar
Thanks Srini for reviewing the change. On 5/18/2020 3:19 PM, Srinivas Kandagatla wrote: On 14/05/2020 17:38, Ajit Pandey wrote: I2SCTL and DMACTL registers has different bits alignment for newer LPASS variants of SC7180 soc. Instead of adding extra overhead for calculating masks and shifts f

Re: [alsa-devel] [PATCH v3 15/25] ASoC: qcom: qdsp6: Add support to q6asm dai driver

2018-02-21 Thread Rohit Kumar
On 2/13/2018 10:28 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to q6asm dai driver which configures Q6ASM streams to pass pcm data. Signed-off-by: Srinivas Kandagatla [..] diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/

Re: [alsa-devel] [PATCH v3 24/25] ASoC: qcom: apq8096: Add db820c machine driver

2018-02-22 Thread Rohit Kumar
On 2/13/2018 10:28 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to DB820c machine driver. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/Kconfig | 8 +++ sound/soc/qcom/apq8096.c | 173 +

Re: [alsa-devel] [PATCH v3 05/25] ASoC: qcom: qdsp6: Add support to Q6AFE

2018-02-19 Thread Rohit Kumar
On 2/13/2018 10:28 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to Q6AFE (Audio Front End) module on Q6DSP. AFE module sits right at the other end of cpu where the codec/audio devices are connected. AFE provides abstraced interfaces to both hard

Re: [alsa-devel] [PATCH v3 14/25] ASoC: qcom: qdsp6: Add support to q6afe dai driver

2018-02-19 Thread Rohit Kumar
On 2/13/2018 10:28 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to q6afe backend dais driver. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/Makefile| 2 +- sound/soc/qcom/qdsp6/q6afe-dai.c | 280 ++

Re: [alsa-devel] [PATCH v3 12/25] ASoC: qcom: qdsp6: Add support to Q6CORE

2018-02-19 Thread Rohit Kumar
On 2/13/2018 10:28 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to core apr service, which is used to query status of other static and dynamic services on the dsp. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/Kconfig| 5 +

Re: [alsa-devel] [RESEND PATCH v2 11/15] ASoC: qcom: qdsp6: Add support to q6afe dai driver

2018-02-07 Thread Rohit Kumar
On 12/14/2017 11:03 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to q6afe backend dais driver. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/Kconfig | 5 + sound/soc/qcom/qdsp6/Makefile| 1 + sound/soc/qcom/qdsp6/q

Re: [alsa-devel] [RESEND PATCH v2 09/15] ASoC: qcom: qdsp6: Add support to Q6CORE

2018-02-07 Thread Rohit Kumar
On 12/14/2017 11:03 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to core apr service, which is used to query status of other static and dynamic services on the dsp. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/Kconfig| 5 +

<    1   2