Re: [PATCH] staging: greybus: spilib: fix use-after-free after deregistration

e. > > Fixes: ba3e67001b42 ("greybus: SPI: convert to a gpbridge driver") > Cc: stable # 4.9 > Cc: Greg Kroah-Hartman > Signed-off-by: Johan Hovold Reviewed-by: Rui Miguel Silva --- Cheers, Rui > --- > drivers/staging/greybus/spilib.c | 8 +--- >

Re: [PATCH] staging: greybus: power_supply: replace kzalloc by kcalloc

Hi JB, Great! thanks for the patch, On Thu, May 11, 2017 at 10:58:56PM +0200, JB Van Puyvelde wrote: According to checkpatch.pl, kcalloc should be preferred to kzalloc with multiply. Signed-off-by: JB Van Puyvelde Reviewed-by: Rui Miguel Silva Cheers, Rui --- drivers/staging/greybus

Re: [RESEND PATCH 3/6] ARM: dts: imx7s: add CAAM device node

Hi, Thanks for the report. On Sat 27 Jan 2018 at 15:49, kbuild test robot wrote: > Hi Rui, > > I love your patch! Yet something to improve: > > [auto build test ERROR on crypto/master] > [also build test ERROR on v4.15-rc9 next-20180126] > [cannot apply to cryptodev/master] > [if your patch is appl

Re: [PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

Hi Sakari, On Sat 24 Mar 2018 at 10:57, Sakari Ailus wrote: Hi Rui, I wanted to go through the code the last time and I'd have a few review comments below... Thanks for the review. On Tue, Mar 13, 2018 at 11:33:11AM +0000, Rui Miguel Silva wrote: ... +static int ov2680_gain_set(s

Re: [PATCH v2 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

Hi Sakari, Thanks for the review... On Fri 09 Mar 2018 at 09:21, Sakari Ailus wrote: Hi Miguel, Thanks for the update. On Wed, Feb 28, 2018 at 03:27:23PM +, Rui Miguel Silva wrote: This patch adds V4L2 sub-device driver for OV2680 image sensor. The OV2680 is a 1/5" CMOS color s

[PATCH v3 0/2] media: Introduce Omnivision OV2680 driver

Cheers, Rui Rui Miguel Silva (2): media: ov2680: dt: Add bindings for OV2680 media: ov2680: Add Omnivision OV2680 sensor driver .../devicetree/bindings/media/i2c/ov2680.txt | 40 + drivers/media/i2c/Kconfig | 12 + drivers/media/i2c/Makefile

[PATCH v3 1/2] media: ov2680: dt: Add bindings for OV2680

Add device tree binding documentation for the OV2680 camera sensor. Reviewed-by: Rob Herring CC: devicet...@vger.kernel.org Signed-off-by: Rui Miguel Silva --- .../devicetree/bindings/media/i2c/ov2680.txt | 40 ++ 1 file changed, 40 insertions(+) create mode 100644

[PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

auto/manual gain, - gain, - horizontal/vertical flip, - test pattern menu. Supported resolution are only: QUXGA, 720P, UXGA. Signed-off-by: Rui Miguel Silva --- drivers/media/i2c/Kconfig | 12 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov2680.c |

Re: [PATCH] media: imx: imx7-mipi-csis: Fix runtime PM imbalance in mipi_csis_s_stream

Hi Liu, Thanks for your patch. On Thu, Apr 08, 2021 at 05:08:27PM +0800, Dinghao Liu wrote: > When v4l2_subdev_call() fails, a pairing PM usage counter > decrement is needed to keep the counter balanced. It's the > same for the following error paths in case 'enable' is on. > > Signed-off-by: Ding

Re: [PATCH] [v2] media: imx: imx7-mipi-csis: Fix runtime PM imbalance in mipi_csis_s_stream

s on. > > Signed-off-by: Dinghao Liu LGTM Reviewed-by: Rui Miguel Silva -- Cheers, Rui > --- > > Changelog: > > v2: - Use pm_runtime_put() to balance the refcount. > --- > drivers/staging/media/imx/imx7-mipi-csis.c | 5 +++-- > 1 file changed, 3 i

[PATCH v2 0/2] media: Introduce Omnivision OV2680 driver

ame_interval equal to g_frame_interval - use closest match from: v4l: common: Add a function to obtain best size from a list - check v4l2_ctrl_new_std return in _init - fix gain manual value in auto_cluster Cheers, Rui Rui Miguel Silva (2): media: ov2680: dt: Add binding

[PATCH v2 1/2] media: ov2680: dt: Add bindings for OV2680

Add device tree binding documentation for the OV2680 camera sensor. CC: devicet...@vger.kernel.org Signed-off-by: Rui Miguel Silva --- .../devicetree/bindings/media/i2c/ov2680.txt | 40 ++ 1 file changed, 40 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v2 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

auto/manual gain, - gain, - horizontal/vertical flip, - test pattern menu. Supported resolution are only: QUXGA, 720P, UXGA. Signed-off-by: Rui Miguel Silva --- drivers/media/i2c/Kconfig | 12 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov2680.c |

[PATCH v4 0/2] media: Introduce Omnivision OV2680 driver

ased on ctrl value - s_frame_interval equal to g_frame_interval - use closest match from: v4l: common: Add a function to obtain best size from a list - check v4l2_ctrl_new_std return in _init - fix gain manual value in auto_cluster Cheers, Rui Rui Miguel Silva (2): media: ov2680: dt

[PATCH v4 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

auto/manual gain, - gain, - horizontal/vertical flip, - test pattern menu. Supported resolution are only: QUXGA, 720P, UXGA. Signed-off-by: Rui Miguel Silva --- drivers/media/i2c/Kconfig | 12 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov2680.c |

[PATCH v4 1/2] media: ov2680: dt: Add bindings for OV2680

Add device tree binding documentation for the OV2680 camera sensor. Reviewed-by: Rob Herring CC: devicet...@vger.kernel.org Signed-off-by: Rui Miguel Silva --- .../devicetree/bindings/media/i2c/ov2680.txt | 40 ++ 1 file changed, 40 insertions(+) create mode 100644

Re: [PATCH v2] staging: greybus: power_supply: use struct_size() helper

, replace code of the following form: sizeof(*resp) + props_count * sizeof(struct gb_power_supply_props_desc) with: struct_size(resp, props, props_count) This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva Reviewed-by: Rui Miguel Silva --- Cheers

Re: [PATCH v2 -next] staging: greybus: light: Use kzalloc for allocating only one thing

> - kcalloc(1, > + kzalloc( > ...) > // > > Signed-off-by: Zheng Yongjun Like Alex said, LGTM also. Reviewed-by: Rui Miguel Silva -- Cheers, Rui > --- > drivers/staging/greybus/light.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > di

Re: [PATCH 23/32] MAINTAINERS: update ovti,ov2680.yaml reference

cross-reference accordingly. > > Fixes: 57226cd8c8bf ("media: dt-bindings: ov2680: convert bindings to yaml") > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rui Miguel Silva -- Cheers, Rui > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH 06/10] staging: greybus: spilib: use 'spi_delay_to_ns' for getting xfer delay

>speed_hz); > > gb_xfer->len = cpu_to_le32(xfer_len); > > - gb_xfer->delay_usecs = cpu_to_le16(xfer->delay_usecs); > > + xfer_delay = spi_delay_to_ns(&xfer->delay, xfer) / 1000; > > + xfer_delay = clamp_t(u16, xfer_delay, 0, U16_MAX); > > + gb_xfer->delay_usecs = cpu_to_le16(xfer_delay); > > gb_xfer->cs_change = xfer->cs_change; > > gb_xfer->bits_per_word = xfer->bits_per_word; > > Acked-by: Viresh Kumar Acked-by: Rui Miguel Silva -- Cheers, Rui

Re: [PATCH] media: imx7-mipi-csis: make array 'registers' static const, makes object smaller

mipi-csis.o > > (gcc version 9.2.1, amd64) > > Signed-off-by: Colin Ian King Looks very good to me. Reviewed-by: Rui Miguel Silva Cheers, Rui > --- > drivers/staging/media/imx/imx7-mipi-csis.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

Re: [PATCH] staging: greybus: light: fix a couple double frees

ot;) > Signed-off-by: Dan Carpenter > Thanks so much for this, I was looking for some time at this and was half way to a much less elegant fix then yours. Acked-by: Rui Miguel Silva Cheers, Rui > --- > drivers/staging/greybus/light.c | 12 ++-- > 1 file changed, 6

Re: [PATCH 14/22] media: imx7-mipi-csis: Create media links in bound notifier

Hi Steve, Just to let you know that this series no longer apply clean after your other series: media: imx: Fix subdev unregister/register issues And since you will need to send a new one, some notes... On Tue 06 Aug 2019 at 00:34, Steve Longerbeam wrote: > Implement a notifier bound op to registe

Re: [PATCH 15/22] media: imx7-media-csi: Create media links in bound notifier

Hi Steve, On Tue 06 Aug 2019 at 00:34, Steve Longerbeam wrote: > Implement a notifier bound op to register media links from the remote > sub-device's source pad(s) to the CSI sink pad. > > Signed-off-by: Steve Longerbeam > --- > drivers/staging/media/imx/imx7-media-csi.c | 24

Re: [PATCH] staging: media: imx: make use devm_platform_ioremap_resource

Hi Hariprasad, Thanks for the patch On Tue 08 Oct 2019 at 07:17, nobody wrote: > From: Hariprasad Kelam > Something went wrong formating the patch email, no To: nor From: > > fix below issue reported by coccicheck > drivers/staging//media/imx/imx7-mipi-csis.c:973:1-12: WARNING: Use > devm_platfo

Re: [PATCH] staging: media: imx: Use devm_platform_ioremap_resource().

helper which wraps platform_get_resource() > and devm_ioremap_resource() together. > > Signed-off-by: Jeeeun Evans > Thanks for the patch. LGTM. Reviewed-by: Rui Miguel Silva --- Cheers, Rui > drivers/staging/media/imx/imx7-mipi-csis.c | 4 +--- > 1 file changed, 1 insertion(+), 3 d

Re: [PATCH v8 5/5] media: imx: Try colorimetry at both sink and source pads

Hi Laurent, On Tue 22 Oct 2019 at 02:44, Laurent Pinchart wrote: > Hi Steve, > > On Tue, May 21, 2019 at 06:03:17PM -0700, Steve Longerbeam wrote: >> Retask imx_media_fill_default_mbus_fields() to try colorimetry parameters, >> renaming it to to imx_media_try_colorimetry(), and call it at both sink

Re: [PATCH v8 5/5] media: imx: Try colorimetry at both sink and source pads

e case for imx7 > it > should also support converting ALTERNATE to INTERLACED at its output. > Yeah, that makes sense to me, I already saw yours csi_try_field that does something in this lines. I will try to handle that in imx7 also. Thanks for your inputs here. Cheers, Rui > >

Re: [PATCH] media: imx7-mipi-csis: Add a check for devm_regulator_get

Hi Chuhong, Thanks for the patch. On Mon 14 Oct 2019 at 03:08, Chuhong Yuan wrote: > devm_regulator_get may return an error but mipi_csis_phy_init misses > a check for it. > This may lead to problems when regulator_set_voltage uses the unchecked > pointer. > This patch adds a check for devm_regula

Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get

Hi Marco, On Wed 16 Oct 2019 at 10:06, Marco Felsch wrote: > Hi Chuhong, > > On 19-10-15 21:59, Chuhong Yuan wrote: >> devm_regulator_get may return an error but mipi_csis_phy_init misses >> a check for it. >> This may lead to problems when regulator_set_voltage uses the unchecked >> pointer. >> Th

Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get

Hi Marco, On Thu 17 Oct 2019 at 09:10, Marco Felsch wrote: > Hi Rui, > > On 19-10-16 14:43, Rui Miguel Silva wrote: >> Hi Marco, >> On Wed 16 Oct 2019 at 10:06, Marco Felsch wrote: >> > Hi Chuhong, >> > >> > On 19-10-15 21:59, Chuhong Yuan wrote:

Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get

dds a check for devm_regulator_get to avoid potential risk. > > Signed-off-by: Chuhong Yuan Reviewed-by: Rui Miguel Silva --- Cheers, Rui > --- > Changes in v2: > - Add a check in mipi_csis_probe for the modified mipi_csis_phy_init. > > drivers/staging/media/imx/imx

Re: [PATCH] staging: greybus: power_supply: fix prop-descriptor request size

operation. Fortunately, the pointer size is always larger than this one-byte request, but this could still cause trouble on the remote end due to the unexpected message size. Fixes: 9d15134d067e ("greybus: power_supply: rework get descriptors") Cc: stable # 4.9 Cc: Rui Miguel Silva

Re: [PATCH] staging: greybus: power_supply: Use struct_size() helper

Hi Gustavo, Thanks a lot for the patch. On Wed 03 Apr 2019 at 21:58, Gustavo A. R. Silva wrote: Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes, in particular in the context in which this code is being used. So, replace code

Re: [PATCH 1/2] ARM: dts: imx6ul: Add csi node

Oi Fabio, On Thu 02 May 2019 at 16:28, Fabio Estevam wrote: > [Adding Rui] > > On Tue, Apr 30, 2019 at 4:47 AM Sébastien Szymanski > wrote: >> >> Add csi node for i.MX6UL SoC. >> >> Signed-off-by: Sébastien Szymanski >> --- >> arch/arm/boot/dts/imx6ul.dtsi | 11 +++ >> 1 file changed, 11

Re: [PATCH] media: ov2680: fix a typo in a function name

27;ov2680_parse_dt()' (6 and 8) > > Signed-off-by: Christophe JAILLET > Reviewed-by: Rui Miguel Silva --- Cheers, Rui > --- > drivers/media/i2c/ov2680.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c

Re: [PATCH v2 2/3] media: imx7-media-csi: add i.MX6UL support

Hi Sebastien, Thanks for the patch. On Thu 06 Jun 2019 at 16:38, Sébastien Szymanski wrote: > i.MX7 and i.MX6UL/L have the same CSI controller. So add i.MX6UL/L support > to imx7-media-csi driver. > > Signed-off-by: Sébastien Szymanski > --- > > Changes for v2: > - rebase on top of linuxtv/maste

Re: [PATCH v2 2/3] media: imx7-media-csi: add i.MX6UL support

Hi Sebastien, On Tue 11 Jun 2019 at 09:16, Sébastien Szymanski wrote: > Hi Rui, > > thanks for the review! > > On 6/10/19 12:28 PM, Rui Miguel Silva wrote: >> Hi Sebastien, >> Thanks for the patch. >> >> On Thu 06 Jun 2019 at 16:38, Sébastien Szymanski wrote

Re: [PATCH v2 2/3] media: imx7-media-csi: add i.MX6UL support

Hi Sebastien, On Tue 11 Jun 2019 at 11:03, Sébastien Szymanski wrote: > On 6/11/19 11:40 AM, Rui Miguel Silva wrote: >> Hi Sebastien, >> On Tue 11 Jun 2019 at 09:16, Sébastien Szymanski wrote: >>> Hi Rui, >>> >>> thanks for the review! >>> >&

Re: [PATCH] media: imx7-media-csi: Remove unneeded break after return

Hi Chinmaya, Thanks for your patch. On Sun 30 Jun 2019 at 04:49, Chinmaya Krishnan Mahesh wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: break is not useful after a goto or return but this is already fixed in the media subsystem tree, by a patch from Fabio: 964fcacddf media: i

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

Hi Fabio, Thanks for the review. On Mon 23 Apr 2018 at 14:11, Fabio Estevam wrote: Hi Rui, On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva wrote: +Optional Properties: +- powerdown-gpios: reference to the GPIO connected to the powerdown pin, +if any. This is an

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

Hi Fabio, On Tue 24 Apr 2018 at 15:53, Fabio Estevam wrote: Hi Rui, On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva wrote: Add device tree binding documentation for the OV2680 camera sensor. Reviewed-by: Rob Herring CC: devicet...@vger.kernel.org Signed-off-by: Rui Miguel Silva

Re: [PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

Hi Sakari, On Fri 16 Mar 2018 at 16:10, Sakari Ailus wrote: On Thu, Mar 15, 2018 at 09:29:33AM +, Rui Miguel Silva wrote: Hi, On Wed 14 Mar 2018 at 19:39, kbuild test robot wrote: > Hi Rui, > > I love your patch! Yet something to improve: > > [auto build test ERR

Re: [PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

://github.com/0day-ci/linux/commits/Rui-Miguel-Silva/media-Introduce-Omnivision-OV2680-driver/20180315-020617 config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master

[PATCH v5 0/2] media: Introduce Omnivision OV2680 driver

w_std return in _init - fix gain manual value in auto_cluster Cheers, Rui Rui Miguel Silva (2): media: ov2680: dt: Add bindings for OV2680 media: ov2680: Add Omnivision OV2680 sensor driver .../devicetree/bindings/media/i2c/ov2680.txt | 40 + drivers/media/i2c/Kconfig

[PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

Add device tree binding documentation for the OV2680 camera sensor. Reviewed-by: Rob Herring CC: devicet...@vger.kernel.org Signed-off-by: Rui Miguel Silva --- .../devicetree/bindings/media/i2c/ov2680.txt | 40 +++ 1 file changed, 40 insertions(+) create mode 100644

[PATCH v5 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

auto/manual gain, - gain, - horizontal/vertical flip, - test pattern menu. Supported resolution are only: QUXGA, 720P, UXGA. Signed-off-by: Rui Miguel Silva --- drivers/media/i2c/Kconfig | 12 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov2680.c |

Re: [PATCH v2] RFC: staging: greybus: shape up greybus GPIO

: Rui Miguel Silva Cc: Greg Kroah-Hartman Signed-off-by: Linus Walleij This was a necessary change for recent kernels. Looks good to me. Thanks. Reviewed-by: Rui Miguel Silva --- ChangeLog v1->v2: - Add the hunk adding select GPIOLIB_IRQCHIP to Kconfig, sorry for sending patches too late

Re: [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev

Hi Viresh, On Wed, Oct 12, 2016 at 08:02:21AM +0530, Viresh Kumar wrote: Some of the print messages are using the incorrect device pointer, fix them. Signed-off-by: Viresh Kumar Reviewed-by: Rui Miguel Silva Thanks, Rui --- drivers/staging/greybus/gpio.c | 6 ++ 1 file changed, 2

Re: [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block

Hi Rahul, Thanks for the patch. Now looks great. On Fri, Nov 18, 2016 at 08:45:25PM +0530, Rahul Krishnan wrote: This patch fixes the following checkpath.pl warning WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Rahul Krishnan Reviewed-by: Rui Miguel Silva

[PATCH] optee: add writeback to valid memory type

: cdbcf83d29c1 ("tee: optee: check type of registered shared memory") Signed-off-by: Rui Miguel Silva --- drivers/tee/optee/call.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tee/optee/call.c b/drivers/tee/optee/call.c index 20b6fd7383c5..c981757ba0d4 10

Re: [PATCH 18/30] iio: gyro: fxas21002c: Move 'fxas21002c_reg_fields' to the only file its used

; defined but not used [-Wunused-const-variable=] > 79 | static const struct reg_field fxas21002c_reg_fields[] = { > | ^ > > Cc: Rui Miguel Silva > Thanks for this, not going in time for the official tagging, since gregkh already picked this up for staging, but fwiw: Acked

[PATCH 0/2] media: Introduce Omnivision OV2680 driver

Add driver and bindings for the OV2680 2 megapixel CMOS 1/5" sensor, which has a single MIPI lane interface and output format of 10-bit Raw RGB. Features supported are described in PATCH 2/2. Cheers, Rui Rui Miguel Silva (2): media: ov2680: dt: Add bindings for OV2680 media: ov2680

[PATCH 1/2] media: ov2680: dt: Add bindings for OV2680

Add device tree binding documentation for the OV5640 camera sensor. CC: devicet...@vger.kernel.org Signed-off-by: Rui Miguel Silva --- .../devicetree/bindings/media/i2c/ov2680.txt | 34 ++ 1 file changed, 34 insertions(+) create mode 100644 Documentation/devicetree

[PATCH 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

auto/manual gain, - gain, - horizontal/vertical flip, - test pattern menu. Supported resolution are only: QUXGA, 720P, UXGA. Signed-off-by: Rui Miguel Silva --- drivers/media/i2c/Kconfig | 13 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov2680.c |

[PATCH v4 0/4] Enable CAAM on i.MX7s fix TrustZone issues

e we aren't enabling for the i.MX7Dual since we don't have hardware to test that out but it should be a 1:1 mapping for others to enable when appropriate. Cheers, Rui Rui Miguel Silva (4): crypto: caam - Fix null dereference at error path crypto: caam - do not use mem and emi_slo

[PATCH v4 4/4] ARM: dts: imx7s: add CAAM device node

Add CAAM device node to the i.MX7s device tree. Cc: Shawn Guo Cc: Sascha Hauer Cc: devicet...@vger.kernel.org Cc: "Horia Geantă" Cc: Aymen Sghaier Cc: Fabio Estevam Cc: Peng Fan Cc: "David S. Miller" Cc: Lukas Auer Signed-off-by: Rui Miguel Silva --- arch/arm/boot

[PATCH v4 3/4] clk: imx7d: add CAAM clock

uot; Cc: Lukas Auer Reviewed-by: Fabio Estevam Signed-off-by: Rui Miguel Silva --- drivers/clk/imx/clk-imx7d.c | 1 + include/dt-bindings/clock/imx7d-clock.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.

[PATCH v4 1/4] crypto: caam - Fix null dereference at error path

Cc: "Horia Geantă" Cc: Aymen Sghaier Cc: Fabio Estevam Cc: Peng Fan Cc: "David S. Miller" Cc: Lukas Auer Cc: # 4.12+ Reviewed-by: Horia Geantă Signed-off-by: Rui Miguel Silva --- drivers/crypto/caam/ctrl.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/driver

[PATCH v4 2/4] crypto: caam - do not use mem and emi_slow clock for imx7x

Signed-off-by: Rui Miguel Silva --- drivers/crypto/caam/ctrl.c | 39 --- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c index 361e750f9cba..e4cc636e1104 100644 --- a/drivers/crypto/caam/

Re: [PATCH 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

Hi Sakari, Thanks for your review. On Fri 23 Feb 2018 at 07:50, Sakari Ailus wrote: Hi Rui, On Thu, Feb 22, 2018 at 10:23:38AM +, Rui Miguel Silva wrote: This patch adds V4L2 sub-device driver for OV2680 image sensor. The OV2680 is a 1/5" CMOS color sensor from Omnivision. Sup

Re: [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680

Hi Sakari, Thanks for the review. On Thu 22 Feb 2018 at 10:59, Sakari Ailus wrote: Hi Rui, Thanks for the patchset. Could you use "dt: bindings: " prefix in the subject? Sure, no problem. On Thu, Feb 22, 2018 at 10:23:37AM +, Rui Miguel Silva wrote: Add device tr

Re: [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680

Hi Fabio, On Thu 22 Feb 2018 at 11:31, Fabio Estevam wrote: On Thu, Feb 22, 2018 at 7:23 AM, Rui Miguel Silva wrote: Add device tree binding documentation for the OV5640 camera sensor. s/OV5640/OV2680 Thanks for notice this ;). --- Cheers, Rui

Re: [PATCH] drivers/staging/greybus: fix max dup length for kstrndup

Hi Ma, Thanks for your patch. Please make sure you use scripts/get_maintainer.pl so that your patches goes to the right lists and people. I CC's them now. ;) On Tue 12 Dec 2017 at 09:25, Ma Shimiao wrote: > If source string longer than max, kstrndup will alloc max+1 space. > So, we should make s

Re: [PATCH] Staging: greybus: Prefer kcalloc over kzalloc

kcalloc. Signed-off-by: Karthik Tummala Can you send a v2 with a subject similar to the other commits in the file. i.e, starting with staging: greybus: light: ... And you have a typo in the change log s/arugment/argument/. If this two are fixed, you can add my: Reviewed-by: Rui Miguel Silva

Re: [PATCH v3] staging: greybus: light: Release memory obtained by kasprintf

Hi, On Sat, Sep 23, 2017 at 01:25:30PM +0530, Arvind Yadav wrote: > Free memory region, if gb_lights_channel_config is not successful. > > Signed-off-by: Arvind Yadav Thanks for the patch, looks good to me. Reviewed-by: Rui Miguel Silva --- Cheers, Rui > --- >

Re: [PATCH] staging: greybus: light: remove unnecessary error check

Hi, On Sat, Sep 23, 2017 at 01:39:15PM +0530, Arvind Yadav wrote: > It is not necessary to check return value of gb_lights_channel_flash_config. > gb_lights_channel_config returns both successful and error value. > > Signed-off-by: Arvind Yadav Thanks for the patch. Reviewed-by

Re: [PATCH] media: staging: greybus: Release memory obtained by kasprintf

Hi, On Thu, Sep 21, 2017 at 03:59:18PM +0300, Dan Carpenter wrote: > On Thu, Sep 21, 2017 at 05:05:27PM +0530, Arvind Yadav wrote: > > Free memory region, if gb_lights_channel_config is not successful. Arvind, thanks for patch and good catch. But please look at the subject of other patches applied