Re: linux-next: manual merge of the signal tree with the modules tree

2013-03-17 Thread Rusty Russell
Sedat Dilek writes: > On Fri, Mar 15, 2013 at 5:41 AM, Rusty Russell wrote: >> Stephen Rothwell writes: >>> Hi Al, >>> >>> Today's linux-next merge of the signal tree got a conflict in >>> include/asm-generic/unistd.h between commit 837718bfd

Re: [PATCH] hw_random: free rng_buffer at module exit

2013-03-17 Thread Rusty Russell
Ben Hutchings writes: > On Fri, 2013-03-15 at 15:35 +1030, Rusty Russell wrote: >> Satoru Takeuchi writes: >> > At Thu, 14 Mar 2013 17:11:21 +1030, >> > Rusty Russell wrote: >> >> >> >> Satoru Takeuchi writes: >> >> > Hi Rusty

Re: [RFC PATCH] Allow optional module parameters

2013-03-17 Thread Rusty Russell
Andy Lutomirski writes: > On Thu, Mar 14, 2013 at 10:03 PM, Rusty Russell wrote: >> Andy Lutomirski writes: >>> Current parameter behavior is odd. Boot parameters that have values >>> and don't match anything become environment variables, with no >>>

Re: [RFC PATCH] Allow optional module parameters

2013-03-18 Thread Rusty Russell
Andy Lutomirski writes: > On Sun, Mar 17, 2013 at 7:24 PM, Rusty Russell wrote: >> Andy Lutomirski writes: >>> On Thu, Mar 14, 2013 at 10:03 PM, Rusty Russell >>> wrote: >>>> Err, yes. Don't remove module parameters, they're part of the API.

Re: [RFC PATCH] Allow optional module parameters

2013-03-19 Thread Rusty Russell
Ben Hutchings writes: > This should also go to stable, so the downgrading issue doesn't continue > to bite people. Andy was complaining about experimental params going away: I haven't heard a single complaint about the downgrading issue. I think it's a nice to have, which is why I mentioned it.

Re: make[2]: execvp: /bin/bash: Argument list too long

2013-03-19 Thread Rusty Russell
Fengguang Wu writes: > On Tue, Mar 19, 2013 at 09:10:25AM -0400, Konrad Rzeszutek Wilk wrote: >> On Mon, Mar 18, 2013 at 11:50:58PM -0700, Andrew Morton wrote: >> > On Tue, 19 Mar 2013 14:31:40 +0800 kbuild test robot >> > wrote: >> > >> > > tree: git://git.kernel.org/pub/scm/linux/kernel/git

Re: [RFC PATCH] Allow optional module parameters

2013-03-19 Thread Rusty Russell
Lucas De Marchi writes: > Hi Rusty, > > On Mon, Mar 18, 2013 at 11:32 PM, Rusty Russell wrote: >> Andy Lutomirski writes: >>> On Sun, Mar 17, 2013 at 7:24 PM, Rusty Russell >>> wrote: >>>> Andy Lutomirski writes: >>>>> On Thu, Mar 1

Re: make[2]: execvp: /bin/bash: Argument list too long

2013-03-20 Thread Rusty Russell
Andrew Morton writes: > On Wed, 20 Mar 2013 13:41:07 +1030 Rusty Russell > wrote: > >> Fengguang Wu writes: >> > On Tue, Mar 19, 2013 at 09:10:25AM -0400, Konrad Rzeszutek Wilk wrote: >> >> On Mon, Mar 18, 2013 at 11:50:58PM -0700, Andrew Morton wrote:

Re: [PATCH] MODSIGN: flag modules that use cryptoapi and only panic if those are unsigned

2013-02-03 Thread Rusty Russell
Stephan Mueller writes: > On 25.01.2013 00:36:01, +0100, Rusty Russell wrote: >> "the module signature" here being the signature of any crypto module, >> I'm guessing from Kyle's awful patch. Any crypto module, or just some? >> Presumably any modul

Re: No sysfs directory for openvswitch module when built-in

2013-02-03 Thread Rusty Russell
Cong Wang writes: > Hello, Rusty, Jesse, > > I met an interesting problem when I compile openvswitch module as a > built-in (actually I compile ALL kernel modules as built-in), there is > no /sys/module/openvswitch/ directory created by the kernel in this > case. ... > What's worse, the user-space

Re: No sysfs directory for openvswitch module when built-in

2013-02-06 Thread Rusty Russell
Ben Hutchings writes: > On Mon, 2013-02-04 at 16:29 +1030, Rusty Russell wrote: >> Cong Wang writes: >> > Hello, Rusty, Jesse, >> > >> > I met an interesting problem when I compile openvswitch module as a >> > built-in (actually I compile ALL kerne

[PULL] virtio fix

2013-02-06 Thread Rusty Russell
The following changes since commit 9a9284153d965a57edc7162a8e57c14c97f3a935: Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux (2013-01-20 20:55:49 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git tags/fixes

Re: [PATCH v5 00/45] CPU hotplug: stop_machine()-free CPU hotplug

2013-02-06 Thread Rusty Russell
"Srivatsa S. Bhat" writes: > On 01/22/2013 01:03 PM, Srivatsa S. Bhat wrote: > Avg. latency of 1 CPU offline (ms) [stop-cpu/stop-m/c > latency] > > # online CPUsMainline (with stop-m/c) This patchset (no stop-m/c) > > 8 17.04

Re: [patch 00/40] CPU hotplug rework - episode I

2013-02-06 Thread Rusty Russell
Thomas Gleixner writes: > On Fri, 1 Feb 2013, Linus Torvalds wrote: >> So for me it's the "expose these states" that I get worried about.. A >> random driver should not necessarily even be able to *see* this, and >> decide to be clever and take advantage of the ordering. >> >> So I'd hope there w

Re: [PATCH 8/8] drivers:net:misc: Remove unnecessary alloc/OOM messages

2013-02-06 Thread Rusty Russell
Joe Perches writes: > alloc failures already get standardized OOM > messages and a dump_stack. > > Signed-off-by: Joe Perches Why not, less code is always good. Acked-by: Rusty Russell (virtio_net) Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe

Re: linux-next build conflict between modules and metag trees (LOCKDEP_NOW_UNRELIABLE)

2013-02-07 Thread Rusty Russell
James Hogan writes: > Hi Rusty, > > The metag architecture tree adds an add_taint(TAINT_DIE) like other > architectures do, and the modules-next tree adds the > LOCKDEP_NOW_UNRELIABLE flag to all uses of add_taint (but obviously > misses arch/metag since it doesn't exist yet), causing a compile er

Re: [RFC PATCH 0/8] virtio: new API for addition of buffers, scatterlist changes

2013-02-07 Thread Rusty Russell
Paolo Bonzini writes: > The virtqueue_add_buf function has two limitations: > > 1) it requires the caller to provide all the buffers in a single call; > > 2) it does not support chained scatterlists: the buffers must be > provided as an array of struct scatterlist. > > Because of these limitations

RFC: mincore: add a bit to indicate a page is dirty.

2013-02-10 Thread Rusty Russell
I am writing an app which really wants to know if a file is on the disk or not (ie. do I need to sync?). mincore() bits other than 0 are undefined (as documented in the man page); in fact my Ubuntu 12.10 i386 system seems to write 129 in some bytes, so it really shouldn't break anyone. Is PG_dirt

Re: [PATCH vringh 2/2] caif_virtio: Introduce caif over virtio

2013-02-10 Thread Rusty Russell
sjur.brandel...@stericsson.com writes: > From: Vikram ARV > > Add the the Virtio shared memory driver for STE Modems. > caif_virtio is implemented utilizing the virtio framework > for data transport and is managed with the remoteproc frameworks. > > The Virtio queue is used for transmitting data t

Re: RFC: mincore: add a bit to indicate a page is dirty.

2013-02-11 Thread Rusty Russell
Johannes Weiner writes: > On Mon, Feb 11, 2013 at 01:43:03PM +1030, Rusty Russell wrote: >> I am writing an app which really wants to know if a file is on the >> disk or not (ie. do I need to sync?). > > When the page is under writeback, it's not necessarily on disk

Re: RFC: mincore: add a bit to indicate a page is dirty.

2013-02-11 Thread Rusty Russell
Andrew Morton writes: > On Mon, 11 Feb 2013 11:27:01 -0500 > Johannes Weiner wrote: > >> > Is PG_dirty the right choice? Is that right for huge pages? Should I >> > assume is_migration_entry(entry) means it's not dirty, or is there some >> > other check here? >> >> If your only consequence of

Re: NULL pointer at kset_find_obj

2013-04-02 Thread Rusty Russell
David Howells writes: > CAI Qian wrote: > >> Just booted the latest mainline, >> >> [ 35.217698] Request for unknown module key 'Magrathea: Glacier signing >> key: 8b7774b08bc4ee9637073434c10f0823f6fbe523' err -11 > > Can you check back earlier in the dmesg to see whether the kernel tried to >

Re: NULL pointer at kset_find_obj

2013-04-03 Thread Rusty Russell
David Howells writes: > Btw, one thing I've noticed is that sysfs appears to be able to execute code > in the module by way of parameter alterations before the module is completely > set up. It's preceeded by the module parameter parsing, which can do the same thing, so I don't think it's an issu

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-03 Thread Rusty Russell
Sebastian Wankerl writes: > Add non-zero module sections to sysfs on architectures unequal to PARISC. > KGDB needs all module sections for proper module debugging. Therefore, commit > 35dead4235e2b67da7275b4122fed37099c2f462 is revoked except for PARISC > architecture. #ifdef CONFIG_PARISC in th

Re: make[2]: execvp: /bin/bash: Argument list too long

2013-04-04 Thread Rusty Russell
Rusty Russell writes: > If this passes review, I'll split properly into three patches. > > Thanks, > Rusty. Noone commented, so split into 3 and into modules-next it goes... Cheers, Rusty. > modpost: handle huge numbers of modules. > > (FIXME: Split into multiple

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-04 Thread Rusty Russell
Sebastian Wankerl writes: > On 04/04/13 03:00, Rusty Russell wrote: >> Sebastian Wankerl writes: >>> Add non-zero module sections to sysfs on architectures unequal to PARISC. >>> KGDB needs all module sections for proper module debugg

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-05 Thread Rusty Russell
James Bottomley writes: > On Fri, 2013-04-05 at 14:30 +1030, Rusty Russell wrote: >> Sebastian Wankerl writes: >> > On 04/04/13 03:00, Rusty Russell wrote: >> >> Sebastian Wankerl writes: >> >>> Add non-zero module sections to sysfs on architect

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-05 Thread Rusty Russell
Sebastian Wankerl writes: > On 04/05/13 06:00, Rusty Russell wrote: >> Sebastian Wankerl writes: >>> On 04/04/13 03:00, Rusty Russell wrote: >>>> Sebastian Wankerl writes: >>>>> Add non-zero module sections to sysfs on architectures unequal to PAR

Re: [PATCH] MODSIGN: flag modules that use cryptoapi and only panic if those are unsigned

2013-01-24 Thread Rusty Russell
Kyle McMartin writes: > After thinking about it a while, this seems like the best way to solve > the problem, although it does still kind of offend my delicate > sensibilities... You're far too polite. This patch was horrible, partial and ugly. Stephan Mueller wrote: > FIPS requires the module

Re: [PATCH v2 3/4] MODSIGN: Add -s option to sign-file

2013-01-24 Thread Rusty Russell
David Howells writes: > Feel free to add: > > Acked-by: David Howells > > to your patches. Thanks, done and applied. Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vge

Re: [PATCH 23/32] Generic dynamic per cpu refcounting

2013-01-24 Thread Rusty Russell
Tejun Heo writes: >> It also implements two stage shutdown, as we need it to tear down the >> percpu counts. Before dropping the initial refcount, you must call >> percpu_ref_kill(); this puts the refcount in "shutting down mode" and >> switches back to a single atomic refcount with the appropriat

Re: [PATCH] virtio-blk: emit udev event when device is resized

2013-02-25 Thread Rusty Russell
Milos Vyletel writes: > When virtio-blk device is resized from host (using block_resize from QEMU) > emit > KOBJ_CHANGE uevent to notify guest about such change. This allows user to have > custom udev rules which would take whatever action if such event occurs. As a > proof of concept I've creat

Re: [PATCH v6 00/46] CPU hotplug: stop_machine()-free CPU hotplug

2013-02-25 Thread Rusty Russell
"Srivatsa S. Bhat" writes: > Hi, > > This patchset removes CPU hotplug's dependence on stop_machine() from the CPU > offline path and provides an alternative (set of APIs) to preempt_disable() to > prevent CPUs from going offline, which can be invoked from atomic context. > The motivation behind t

Re: [PATCH 08/16] virtio_ring: virtqueue_add_outbuf / virtqueue_add_inbuf.

2013-02-25 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Tue, Feb 19, 2013 at 06:26:26PM +1030, Rusty Russell wrote: >> These are specialized versions of virtqueue_add_buf(), which cover >> over 50% of cases and are far clearer. >> >> In particular, the scatterlists passed to thes

Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings)

2013-02-25 Thread Rusty Russell
Ohad Ben-Cohen writes: > On Thu, Feb 21, 2013 at 8:37 AM, Rusty Russell wrote: >> Hmm... I clearly jumped the gun, assuming consensus was already reached. >> I have put these patches *back* into pending-rebases, and they will not >> be merged this merge window. > > Th

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-25 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Tue, Feb 19, 2013 at 06:26:20PM +1030, Rusty Russell wrote: >> virtio_scsi can really use this, to avoid the current hack of copying >> the whole sg array. Some other things get slightly neater, too. >> >> Signed-off-b

[PULL] virtio

2013-02-25 Thread Rusty Russell
nks to the stuff which didn't quite make it time. Cheers, Rusty. -------- Rusty Russell (1): virtio: use module_virtio_driver. Ryota Ozaki (1): virtio-mmio: fix wrong comment about register offset Sjur Brændeland (4):

Re: [PATCH] virtio-blk: emit udev event when device is resized

2013-02-26 Thread Rusty Russell
Milos Vyletel writes: > On Feb 25, 2013, at 5:12 PM, Greg KH wrote: > >> On Fri, Feb 22, 2013 at 10:14:49AM +1030, Rusty Russell wrote: >>> Milos Vyletel writes: >>> >>>> When virtio-blk device is resized from host (using block_resize from QEMU) &

Re: [PATCH] virtio-blk: emit udev event when device is resized

2013-02-26 Thread Rusty Russell
ENV{ID_FS_TYPE}=="ext[3-4]", \ RUN+="/sbin/resize2fs /dev/%k" ACTION=="change", KERNEL=="vd*", \ ENV{RESIZE}=="1", \ ENV{ID_FS_TYPE}=="LVM2_member", \ RUN+="/sbin/pvresize /dev/%k" Signed-off-by: Mil

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-26 Thread Rusty Russell
Paolo Bonzini writes: > Il 24/02/2013 23:12, Michael S. Tsirkin ha scritto: >> On Tue, Feb 19, 2013 at 06:26:20PM +1030, Rusty Russell wrote: >>> virtio_scsi can really use this, to avoid the current hack of copying >>> the whole sg array. Some other thin

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-27 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Wed, Feb 27, 2013 at 05:58:37PM +1030, Rusty Russell wrote: >> Paolo Bonzini writes: >> > Il 24/02/2013 23:12, Michael S. Tsirkin ha scritto: >> >> On Tue, Feb 19, 2013 at 06:26:20PM +1030, Rusty Russell wrote: >>

Re: [PATCH 08/16] virtio_ring: virtqueue_add_outbuf / virtqueue_add_inbuf.

2013-02-27 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Fri, Feb 22, 2013 at 10:32:46AM +1030, Rusty Russell wrote: >> "Michael S. Tsirkin" writes: >> > On Tue, Feb 19, 2013 at 06:26:26PM +1030, Rusty Russell wrote: >> >> These are specialized versions of virtqueue_

Re: [PATCHv2 vringh 3/3] caif_virtio: Introduce caif over virtio

2013-02-19 Thread Rusty Russell
sjur.brandel...@stericsson.com writes: > From: Vikram ARV > > Add the the Virtio shared memory driver for STE Modems. > caif_virtio is implemented utilizing the virtio framework > for data transport and is managed with the remoteproc frameworks. > > The Virtio queue is used for transmitting data t

Re: [PATCH vringh 2/2] caif_virtio: Introduce caif over virtio

2013-02-19 Thread Rusty Russell
Sjur Brændeland writes: >> Sjur Brændeland writes: >>> How about supporting struct vringh_kiov and struct kvec as well? >>> I currently get the following complaints with my V2 patch-set: >>> >>> drivers/net/caif/caif_virtio.c:486:2: warning: passing argument 1 of >>> ‘vringh_iov_init’ from incom

[PATCH 16/16] 9p/trans_virtio.c: use virtio_add_sgs[]

2013-02-19 Thread Rusty Russell
virtio_add_buf() is going away, replaced with virtio_add_sgs() which takes multiple terminated scatterlists. Signed-off-by: Rusty Russell --- net/9p/trans_virtio.c | 48 +++- 1 file changed, 39 insertions(+), 9 deletions(-) diff --git a/net/9p

[PATCH 15/16] virtio_balloon: use simplified virtqueue accessors.

2013-02-19 Thread Rusty Russell
We never add buffers with input and output parts, so use the new accessors. Signed-off-by: Rusty Russell --- drivers/virtio/virtio_balloon.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index

[PATCH 10/16] virtio_net: use virtqueue_add_sgs[] for command buffers.

2013-02-19 Thread Rusty Russell
It's a bit cleaner to hand multiple sgs, rather than one big one. Signed-off-by: Rusty Russell --- drivers/net/virtio_net.c | 50 ++ 1 file changed, 24 insertions(+), 26 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_

[PATCH 12/16] virtio_console: use simplified virtqueue accessors.

2013-02-19 Thread Rusty Russell
We never add buffers with input and output parts, so use the new accessors. Signed-off-by: Rusty Russell --- drivers/char/virtio_console.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index e905d5f

[PATCH 11/16] virtio_rng: use simplified virtqueue accessors.

2013-02-19 Thread Rusty Russell
We never add buffers with input and output parts, so use the new accessors. Signed-off-by: Rusty Russell --- drivers/char/hw_random/virtio-rng.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/hw_random/virtio-rng.c b/drivers/char/hw_random/virtio-rng.c

Re: [PATCH 0/9] virtio: new API for addition of buffers, scatterlist changes

2013-02-19 Thread Rusty Russell
Paolo Bonzini writes: >> virtio_ring: virtqueue_add_sgs, to add multiple sgs. >> >> virtio_scsi and virtio_blk can really use these, to avoid their current >> hack of copying the whole sg array. >> >> Signed-off-by: Ruty Russell > > It's much better than the other prototype you had posted, but

[PATCH 14/16] virtio_rpmsg_bus: use simplified virtqueue accessors.

2013-02-19 Thread Rusty Russell
We never add buffers with input and output parts, so use the new accessors. Signed-off-by: Rusty Russell --- drivers/rpmsg/virtio_rpmsg_bus.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c index

[PATCH 13/16] caif_virtio: use simplified virtqueue accessors.

2013-02-19 Thread Rusty Russell
We never add buffers with input and output parts, so use the new accessors. Signed-off-by: Rusty Russell --- drivers/net/caif/caif_virtio.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/caif/caif_virtio.c b/drivers/net/caif/caif_virtio.c index df832e7

[PATCH 09/16] virtio_net: use simplified virtqueue accessors.

2013-02-19 Thread Rusty Russell
We never add buffers with input and output parts, so use the new accessors. Signed-off-by: Rusty Russell --- drivers/net/virtio_net.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index dbd5cd1..8ca69c0

[PATCH 07/16] virtio_ring: don't count elements twice for add_buf path.

2013-02-19 Thread Rusty Russell
Extract the post-counting code into virtqueue_add(), make both callers use it. Signed-off-by: Rusty Russell --- drivers/virtio/virtio_ring.c | 147 +++--- 1 file changed, 80 insertions(+), 67 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers

[PATCH 08/16] virtio_ring: virtqueue_add_outbuf / virtqueue_add_inbuf.

2013-02-19 Thread Rusty Russell
itious one which conditionally ignored end markers in the iterator, but it was ugly and I suspect this is just as fast. Maybe we should just fix all the drivers? Signed-off-by: Rusty Russell --- drivers/virtio/virtio_ring.c | 58 ++ include/linu

[PATCH 06/16] virtio_blk: remove nents member.

2013-02-19 Thread Rusty Russell
It's simply a flag as to whether we have data now, so make it an explicit function parameter rather than a member of struct virtblk_req. Signed-off-by: Rusty Russell --- drivers/block/virtio_blk.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --

[PATCH 05/16] virtio-blk: use virtqueue_add_sgs on req path

2013-02-19 Thread Rusty Russell
#x27;t use vbr->sg, however, we need to add a couple of arguments to __virtblk_add_req. We also need to teach __virtblk_add_req how to build SCSI command requests. Signed-off-by: Paolo Bonzini Signed-off-by: Rusty Russell --- drivers/block/virtio

Re: [PATCH] param, charp: Cache val length

2013-02-19 Thread Rusty Russell
Borislav Petkov writes: > From: Borislav Petkov > > ... instead of doing strlen twice. I'm delighted with your enthusiasm for making trivial changes, but I have trouble sharing in it. In this case, it's so marginal that I'll leave the status quo. Thanks, Rusty. -- To unsubscribe from this list

[PATCH 04/16] virtio-blk: use virtqueue_start_buf on bio path

2013-02-19 Thread Rusty Russell
ly using virtqueue_add_sgs(). With this change, virtio-blk (with use_bio) is not relying anymore on the virtio functions ignoring the end markers in a scatterlist. The next patch will do the same for the other path. Signed-off-by: Paolo Bonzini Signed-off-by: Rusty Russell --- drivers/block/virtio_blk.

[PATCH 03/16] virtio-blk: reorganize virtblk_add_req

2013-02-19 Thread Rusty Russell
Bonzini Reviewed-by: Asias He Signed-off-by: Rusty Russell --- drivers/block/virtio_blk.c | 55 1 file changed, 20 insertions(+), 35 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 8ad21a2..fd8a689 100644 --- a

[PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-19 Thread Rusty Russell
virtio_scsi can really use this, to avoid the current hack of copying the whole sg array. Some other things get slightly neater, too. Signed-off-by: Rusty Russell --- drivers/virtio/virtio_ring.c | 144 ++ include/linux/virtio.h |7 ++ 2 files

[PATCH 5/5] tools/virtio: add vring_test.

2013-02-19 Thread Rusty Russell
, pinged 3172148 Time: R=17.659 U=6.640 S=6.640 ./vringh_test --eventidx --parallel: Using CPUS 0 and 3 Guest: notified 156357, pinged 156251 Host: notified 156251, pinged 78179 Time: R=4.518 U=3.536 S=3.536 Signed-off-by: Rusty Russell --- tools/virtio

[PATCH 01/16] scatterlist: introduce sg_unmark_end

2013-02-19 Thread Rusty Russell
From: Paolo Bonzini This is useful in places that recycle the same scatterlist multiple times, and do not want to incur the cost of sg_init_table every time in hot paths. Acked-by: Jens Axboe Signed-off-by: Paolo Bonzini Signed-off-by: Rusty Russell --- block/blk-integrity.c |2

[PATCH 00/16] virtio ring rework.

2013-02-19 Thread Rusty Russell
sgs on req path Rusty Russell (13): virtio_ring: virtqueue_add_sgs, to add multiple sgs. virtio-blk: use virtqueue_start_buf on bio path virtio_blk: remove nents member. virtio_ring: don't count elements twice for add_buf path. virtio_ring: virtqueue_add_outbuf / virtqueue_add_inbuf.

[PATCH 4/5] tools/virtio: separate headers more.

2013-02-19 Thread Rusty Russell
This makes them a bit more like the kernel headers, so we can include more real kernel headers in our tests. Signed-off-by: Rusty Russell --- tools/virtio/asm/barrier.h | 14 +++ tools/virtio/linux/bug.h| 10 ++ tools/virtio/linux/err.h| 26

[PATCH 2/5] vringh: host-side implementation of virtio rings.

2013-02-19 Thread Rusty Russell
inlines correctly. There are patches pending to make vhost use this interface, but it's being merged now for the CAIF virtio patches, which want it immediately. Signed-off-by: Rusty Russell --- drivers/Makefile |2 +- drivers/vhost/Kconfig |8 + drivers/vhost/Kconfig.tcm |

[PATCH 1/5] virtio_ring: expose virtio barriers for use in vringh.

2013-02-19 Thread Rusty Russell
The host side of ring needs this logic too. Signed-off-by: Rusty Russell --- drivers/virtio/virtio_ring.c | 33 +--- include/linux/virtio_ring.h | 57 ++ 2 files changed, 63 insertions(+), 27 deletions(-) diff --git a/drivers

[PATCH 3/5] tools/virtio: fix compile.

2013-02-19 Thread Rusty Russell
Didn't test that it actually works, mind you! Signed-off-by: Rusty Russell --- tools/virtio/linux/virtio.h |9 - tools/virtio/virtio_test.c |6 +++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/tools/virtio/linux/virtio.h b/tools/virtio/linux/virtio.h

[PATCH 0/5] vringh

2013-02-19 Thread Rusty Russell
This introduces vringh, which are generic accessors for virtio rings (host side). There's a host-side implementation in vhost, but it assumes that the rings are in userspace, and is tied to the vhost implementation. I have patches to adapt it to use vringh, but I'm pushing this in the next merge

Re: [PATCH 0/5] vringh

2013-02-19 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Tue, Feb 19, 2013 at 08:59:27AM +1030, Rusty Russell wrote: >> This introduces vringh, which are generic accessors for virtio rings (host >> side). >> There's a host-side implementation in vhost, but it assumes that the r

[PULL] modules-next

2013-02-19 Thread Rusty Russell
le command line MODSIGN: Add -s option to sign-file MODSIGN: Add option to not sign modules during modules_install Rusty Russell (3): module: printk message when module signature fail taints kernel. taint: add explicit flag to show whether lock dep is still OK. m

Re: [PATCH v2] X.509: Support parse long form of length octets in Authority Key Identifier

2013-02-20 Thread Rusty Russell
joeyli writes: > 於 三,2013-02-20 於 12:49 +,David Howells 提到: >> Acked-by: David Howells >> > > Thanks for David's review and confirm. Should this be CC stable? Thanks, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vge

Re: [PATCH 00/16] virtio ring rework.

2013-02-20 Thread Rusty Russell
Paolo Bonzini writes: > Il 19/02/2013 08:56, Rusty Russell ha scritto: >> OK, this is (ab)uses some of Paolo's patches. The first 7 are >> candidates for this merge window (maybe), the rest I'm not so sure >> about. > > Cool, thanks. > >

Re: [PATCH 10/16] virtio_net: use virtqueue_add_sgs[] for command buffers.

2013-02-20 Thread Rusty Russell
Wanlong Gao writes: > On 02/19/2013 03:56 PM, Rusty Russell wrote: >> It's a bit cleaner to hand multiple sgs, rather than one big one. >> >> Signed-off-by: Rusty Russell ... >> +BUG_ON(!virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ)); >> >

Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings)

2013-02-20 Thread Rusty Russell
Ohad Ben-Cohen writes: > Hi Sjur, > > On Tue, Feb 12, 2013 at 1:49 PM, wrote: >> From: Sjur Brændeland >> >> Add functions for creating, deleting and kicking host-side virtio rings. >> >> The host ring is not integrated with virtiqueues and cannot be managed >> through virtio-config. > > Is tha

Re: [PATCH 17/16 V2] virtio-scsi: use virtqueue_add_sgs for command buffers

2013-02-20 Thread Rusty Russell
Asias He writes: > On 02/20/2013 05:47 PM, Wanlong Gao wrote: >> Using the new virtqueue_add_sgs function lets us simplify the queueing >> path. In particular, all data protected by the tgt_lock is just gone >> (multiqueue will find a new use for the lock). >> >> Signed-off-by: Paolo Bonzini >>

Re: [PATCH 04/16] virtio-blk: use virtqueue_start_buf on bio path

2013-02-20 Thread Rusty Russell
Asias He writes: > On 02/19/2013 03:56 PM, Rusty Russell wrote: >> (This is a respin of Paolo Bonzini's patch, but it calls >> virtqueue_add_sgs() instead of his multi-part API). ... > (This subject needs to be changed to reflect using of virtqueue_add_sgs) Thanks, done.

Re: [RFC -next] linux/linkage.h: fix symbol prefix handling

2013-03-12 Thread Rusty Russell
Stephen Rothwell writes: > Hi Rusty, > > On Mon, 11 Mar 2013 17:05:17 +1030 Rusty Russell > wrote: >> >> diff --git a/arch/blackfin/Kconfig b/arch/blackfin/Kconfig >> index 600494c..cd0f7c7 100644 >> --- a/arch/blackfin/Kconfig >> +++ b/arch/blac

Re: [RFC -next] linux/linkage.h: fix symbol prefix handling

2013-03-12 Thread Rusty Russell
o that we have a non-string version for pasting. (arch/h8300/include/asm/linkage.h defines SYMBOL_NAME(), too). Let's solve this properly: 1) No more generic prefix, just CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX. 2) Make linux/export.h usable from asm. 3) Define VMLINUX_SYMBOL, VMLINUX_SYMBOL_ST

[PULL] virtio rng fix

2013-03-12 Thread Rusty Russell
The following changes since commit f7f154f1246ccc5a0a7e9ce50932627d60a0c878: hw_random: make buffer usable in scatterlist. (2013-03-05 10:11:41 +1030) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git tags/fixes-for-linus for you to fetch

Re: [PATCH 1/1] module: fix symbol versioning with symbol prefixes

2013-03-13 Thread Rusty Russell
names). The check_modstruct_version() function is also fixed as it checks the version of the unprefixed "module_layout" symbol which would no longer work. Signed-off-by: James Hogan Cc: Michal Marek Cc: Sam Ravnborg Cc: Greg Kroah-Hartman Cc: Jonathan Kliegman Signed-off-by: Ru

Re: [ 12/40] hw_random: make buffer usable in scatterlist.

2013-03-13 Thread Rusty Russell
Satoru Takeuchi writes: > Hi Rusty, > > At Tue, 12 Mar 2013 15:43:33 -0700, > Greg Kroah-Hartman wrote: >> @@ -307,6 +312,14 @@ int hwrng_register(struct hwrng *rng) >> >> mutex_lock(&rng_mutex); >> >> +/* kmalloc makes this safe for virt_to_page() in virtio_rng.c */ >> +err = -EN

Re: [RFC -next] linux/linkage.h: fix symbol prefix handling

2013-03-13 Thread Rusty Russell
imal). Note: James, your patch hunk now looks like this: - buf_printf(b, "\t{ %#8x, \"%s\" },\n", s->crc, s->name); + buf_printf(b, "\t{ %#8x, VMLINUX_SYMBOL_STR(%s) },\n", +s->crc, s->name); Here'

Re: [PATCH] export.h: clarify comment in relation to avoiding includes

2013-03-14 Thread Rusty Russell
Paul Gortmaker writes: > The existing comment indicated what was desired, but it didn't > necessarily convey the reasoning behind it in an effective way. > > Cc: Rusty Russell > Signed-off-by: Paul Gortmaker > --- > include/linux/export.h | 5 +++-- > 1 fil

Re: linux-next: manual merge of the signal tree with the modules tree

2013-03-14 Thread Rusty Russell
Stephen Rothwell writes: > Hi Al, > > Today's linux-next merge of the signal tree got a conflict in > include/asm-generic/unistd.h between commit 837718bfd28b > ("CONFIG_SYMBOL_PREFIX: cleanup") from the modules tree and commit > e1b5bb6d1236 ("consolidate cond_syscall and SYSCALL_ALIAS declaratio

Re: [RFC PATCH] Allow optional module parameters

2013-03-14 Thread Rusty Russell
Andy Lutomirski writes: > Current parameter behavior is odd. Boot parameters that have values > and don't match anything become environment variables, with no > warning. Boot parameters without values that don't match anything > go into argv_init. Everything goes into /proc/cmdline. > > The ini

Re: [RFC -next] linux/linkage.h: fix symbol prefix handling

2013-03-14 Thread Rusty Russell
James Hogan writes: > On 14/03/13 04:00, Rusty Russell wrote: >> From: Rusty Russell >> Subject: CONFIG_SYMBOL_PREFIX: cleanup. ... > Reviewed-by: James Hogan > Tested-by: James Hogan (metag) Thanks. > The only other special case of symbol prefixing I'm awar

Re: [PATCH] hw_random: free rng_buffer at module exit

2013-03-14 Thread Rusty Russell
Satoru Takeuchi writes: > At Thu, 14 Mar 2013 17:11:21 +1030, > Rusty Russell wrote: >> >> Satoru Takeuchi writes: >> > Hi Rusty, >> > >> > At Tue, 12 Mar 2013 15:43:33 -0700, >> > Greg Kroah-Hartman wrote: >>

Re: [PATCH] Remove CONFIG_EXPERIMENTAL

2012-08-28 Thread Rusty Russell
Kees Cook writes: > This config item has not carried much meaning for a while now and is > almost always enabled by default. Remove it and adjust various config > logic and documentation. Acked-by: Rusty Russell (lguest part) Cheers, Rusty. -- To unsubscribe from this list: send

Re: [PATCH 0/4 V2] Use get_online_cpus to avoid races involving CPU hotplug

2012-09-01 Thread Rusty Russell
Silas Boyd-Wickizer writes: > Hello, > > This is the second version of the patches to fix races described in: > > https://groups.google.com/forum/?fromgroups#!topic/linux.kernel/iSUDr94Qehc > > The changes in this version are: > > * fix commit log typo; > * prevent a race in via_cputemp_exi

Re: [RFC v2 4/7] modsig: add integrity_module_check hook

2012-09-03 Thread Rusty Russell
Dmitry Kasatkin writes: > +#else > +static inline int integrity_module_check(const void *buf, unsigned long len) > +{ > + return 0; > +} > +#endif ... > + err = integrity_module_check(hdr, len); > + if (err < 0) > + goto free_hdr; > + > + /* cut signature tail */ > +

[RFC] module: signature infrastructure

2012-09-03 Thread Rusty Russell
OK, I took a look at the module.c parts of David and Dmitry's patchsets, and didn't really like either, but I stole parts of David's to make this. So, here's the module.c part of module signing. I hope you two got time to discuss the signature format details? Mimi suggested a scheme where the pr

Re: [RFC 1/2] virtio_console: Add support for DMA memory allocation

2012-09-04 Thread Rusty Russell
"Michael S. Tsirkin" writes: > Also let's add a wrapper at top of file so ifdefs > do not litter the code like this. For example: > > #ifdef CONFIG_HAS_DMA > #define VIRTIO_CONSOLE_HAS_DMA (1) > #else > #define VIRTIO_CONSOLE_HAS_DMA (0) > #endif > > Now use if instead of ifdef. The driver certai

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-04 Thread Rusty Russell
Kent Overstreet writes: > CONFIG_VIRTIO isn't exposed, everything else is supposed to select it > instead. This is a slight mis-understanding. It's supposed to be selected by the particular driver, probably virtio_pci in your case. Cheers, Rusty. -- To unsubscribe from this list: send the line

Re: [PATCH] tools: Fix pthread flag for Makefile of trace-agent used by virtio-trace

2012-09-04 Thread Rusty Russell
Yoshihiro YUNOMAE writes: > pthread flag should not be -lpthread but -pthread using gcc. The -lpthread > links the external multithread library. On the other hand, the -pthread > manages > both the gcc's preprocessor and linker to be able to compile with pthread. > > Signed-off-by: Yoshihiro YUN

Re: [RFC] module: signature infrastructure

2012-09-05 Thread Rusty Russell
"Kasatkin, Dmitry" writes: > Hi, > > Please read bellow... > > On Tue, Sep 4, 2012 at 8:55 AM, Rusty Russell wrote: >> OK, I took a look at the module.c parts of David and Dmitry's patchsets, >> and didn't really like either, but I stole parts o

Re: [RFC] module: signature infrastructure

2012-09-05 Thread Rusty Russell
Lucas De Marchi writes: > Hi Rusty, > > On Tue, Sep 4, 2012 at 2:55 AM, Rusty Russell wrote: >> @@ -2399,7 +2437,50 @@ static inline void kmemleak_load_module(const struct >> module *mod, >> } >> #endif >> >> -/* Sets info->hdr and info->

Re: [PATCH] virtio-balloon spec: provide a version of the "silent deflate" feature that works

2012-09-11 Thread Rusty Russell
"Michael S. Tsirkin" writes: > We have several options: > 1. No memory overcommit feature. This is always the case ATM! > 2. Do not hot-plug assigned device. > 3. Hot-unplug assigned device. > 4. Some assigned devices can be able to handle memory errors >e.g. using ATS. Limit hotplug to these.

Re: [PATCH v2 2/2] virtio-ring: Allocate indirect buffers from cache when possible

2012-09-11 Thread Rusty Russell
Thomas Lendacky writes: > I ran some TCP_RR and TCP_STREAM sessions, both host-to-guest and > guest-to-host, with a form of the histogram patch applied against a > RHEL6.3 kernel. The histogram values were reset after each test. Hey, thanks! This is exactly what I wanted to see... > 60 session

Re: [RFC 1/2] virtio_console: Add support for DMA memory allocation

2012-09-11 Thread Rusty Russell
"Michael S. Tsirkin" writes: >> virtio: don't crash when device is buggy >> >> Because of a sanity check in virtio_dev_remove, a buggy device can crash >> kernel. And in case of rproc it's userspace so it's not a good idea. >> We are unloading a driver so how bad can it be? >> Be less aggressive

  1   2   3   4   5   6   7   8   9   10   >