[PATCH 1/4] HID: logitech-dj: Delete an error message for a failed memory allocation in two functions

From: Markus Elfring Date: Mon, 5 Feb 2018 21:36:18 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/4] HID: logitech-dj: Delete an error message for a failed memory allocation in two functions

From: Markus Elfring Date: Mon, 5 Feb 2018 21:36:18 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-logitech-dj.c | 12 +++- 1 file changed, 3

[PATCH 0/4] HID: logitech-dj: Adjustments for some function implementations

From: Markus Elfring Date: Mon, 5 Feb 2018 22:22:11 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Delete an error message for a failed memory allocation in two functions Improve a size

[PATCH 0/4] HID: logitech-dj: Adjustments for some function implementations

From: Markus Elfring Date: Mon, 5 Feb 2018 22:22:11 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Delete an error message for a failed memory allocation in two functions Improve a size determination in four functions Combine

Re: hid-sensor-accel-3d: Delete an error message for a failed memory allocation in hid_accel_3d_probe()

> If making changes like this I would suggest only sending one until > you have have a response from the relevant maintainer. The corresponding feedback can become more positive for such a transformation pattern after a while, can't it? > It would save you time as often these sorts of changes

Re: hid-sensor-accel-3d: Delete an error message for a failed memory allocation in hid_accel_3d_probe()

> If making changes like this I would suggest only sending one until > you have have a response from the relevant maintainer. The corresponding feedback can become more positive for such a transformation pattern after a while, can't it? > It would save you time as often these sorts of changes

[PATCH] HID: magicmouse: Delete an error message for a failed memory allocation in magicmouse_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 22:15:05 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] HID: magicmouse: Delete an error message for a failed memory allocation in magicmouse_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 22:15:05 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-magicmouse.c | 4 +--- 1 file changed, 1 insertion(+),

[PATCH 2/2] HID: ntrig: Improve a size determination in ntrig_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 21:48:39 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/2] HID: ntrig: Improve a size determination in ntrig_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 21:48:39 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/2] HID: ntrig: Delete an error message for a failed memory allocation in ntrig_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 21:46:20 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] HID: ntrig: Delete an error message for a failed memory allocation in ntrig_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 21:46:20 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-ntrig.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH 0/2] HID: N-Trig: Adjustments for ntrig_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 21:54:32 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination

[PATCH 0/2] HID: N-Trig: Adjustments for ntrig_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 21:54:32 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/hid/hid-ntrig.c | 6 ++ 1 file

[PATCH 2/2] HID: picoLCD: Improve a size determination in picolcd_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 21:05:55 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/2] HID: picoLCD: Improve a size determination in picolcd_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 21:05:55 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/2] HID: picoLCD: Delete an error message for a failed memory allocation in three functions

From: Markus Elfring Date: Sat, 3 Feb 2018 21:00:37 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] HID: picoLCD: Delete an error message for a failed memory allocation in three functions

From: Markus Elfring Date: Sat, 3 Feb 2018 21:00:37 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-picolcd_core.c | 1 - drivers/hid/hid-picolcd_fb.c

[PATCH 0/2] HID-picoLCD: Adjustments for three function implementations

From: Markus Elfring Date: Sat, 3 Feb 2018 21:12:24 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in three functions Improve a size

[PATCH 0/2] HID-picoLCD: Adjustments for three function implementations

From: Markus Elfring Date: Sat, 3 Feb 2018 21:12:24 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in three functions Improve a size determination in picolcd_probe()

[PATCH 6/6] hid-prodikeys: Rename a jump label in pcmidi_send_note()

From: Markus Elfring Date: Sat, 3 Feb 2018 18:10:00 +0100 An other label fits better to the jump target. Thus rename it. Signed-off-by: Markus Elfring --- drivers/hid/hid-prodikeys.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 6/6] hid-prodikeys: Rename a jump label in pcmidi_send_note()

From: Markus Elfring Date: Sat, 3 Feb 2018 18:10:00 +0100 An other label fits better to the jump target. Thus rename it. Signed-off-by: Markus Elfring --- drivers/hid/hid-prodikeys.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-prodikeys.c

[PATCH 5/6] hid-prodikeys: Combine two condition checks into one statement in pcmidi_send_note()

From: Markus Elfring Date: Sat, 3 Feb 2018 18:00:06 +0100 The same label was used by goto statements after two condition checks. Thus use a single statement instead. Signed-off-by: Markus Elfring --- drivers/hid/hid-prodikeys.c | 5

[PATCH 5/6] hid-prodikeys: Combine two condition checks into one statement in pcmidi_send_note()

From: Markus Elfring Date: Sat, 3 Feb 2018 18:00:06 +0100 The same label was used by goto statements after two condition checks. Thus use a single statement instead. Signed-off-by: Markus Elfring --- drivers/hid/hid-prodikeys.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

[PATCH 4/6] hid-prodikeys: Delete an unnecessary return statement in pcmidi_send_note()

From: Markus Elfring Date: Sat, 3 Feb 2018 17:33:40 +0100 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a statement in the affected function.

[PATCH 4/6] hid-prodikeys: Delete an unnecessary return statement in pcmidi_send_note()

From: Markus Elfring Date: Sat, 3 Feb 2018 17:33:40 +0100 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a statement in the affected function. Signed-off-by: Markus Elfring ---

[PATCH 3/6] hid-prodikeys: Move an assignment in pk_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 17:20:01 +0100 Move one assignment for a data structure member in one local variable so that its setting will only be performed after a corresponding memory allocation succeeded by this function. Signed-off-by: Markus

[PATCH 3/6] hid-prodikeys: Move an assignment in pk_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 17:20:01 +0100 Move one assignment for a data structure member in one local variable so that its setting will only be performed after a corresponding memory allocation succeeded by this function. Signed-off-by: Markus Elfring ---

[PATCH 2/6] hid-prodikeys: Delete an unnecessary variable initialisation in pk_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 14:45:24 +0100 The local variable "pm" will eventually be set to an appropriate pointer a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring

[PATCH 2/6] hid-prodikeys: Delete an unnecessary variable initialisation in pk_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 14:45:24 +0100 The local variable "pm" will eventually be set to an appropriate pointer a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/hid/hid-prodikeys.c | 2 +- 1 file changed, 1

[PATCH 1/6] hid-prodikeys: Delete two error messages for a failed memory allocation in pk_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 14:36:20 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/6] hid-prodikeys: Delete two error messages for a failed memory allocation in pk_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 14:36:20 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-prodikeys.c | 5 + 1 file changed, 1 insertion(+), 4

[PATCH 0/6] HID-Prodikeys: Adjustments for two function implementations

From: Markus Elfring Date: Sat, 3 Feb 2018 18:21:23 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (6): Delete two error messages for a failed memory allocation in pk_probe() Delete an unnecessary

[PATCH 0/6] HID-Prodikeys: Adjustments for two function implementations

From: Markus Elfring Date: Sat, 3 Feb 2018 18:21:23 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (6): Delete two error messages for a failed memory allocation in pk_probe() Delete an unnecessary variable initialisation in pk_probe()

[PATCH] hid-rmi: Delete an error message for a failed memory allocation in rmi_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 13:42:08 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] hid-rmi: Delete an error message for a failed memory allocation in rmi_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 13:42:08 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-rmi.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH] HID: Roccat: Delete an error message for a failed memory allocation in nine functions

From: Markus Elfring Date: Sat, 3 Feb 2018 11:45:15 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] HID: Roccat: Delete an error message for a failed memory allocation in nine functions

From: Markus Elfring Date: Sat, 3 Feb 2018 11:45:15 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-roccat-arvo.c | 5 ++---

[PATCH] hid-saitek: Delete an error message for a failed memory allocation in saitek_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 09:12:24 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] hid-saitek: Delete an error message for a failed memory allocation in saitek_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 09:12:24 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-saitek.c | 4 +--- 1 file changed, 1 insertion(+), 3

Re: Coccinelle: zalloc-simple: Checking consistency for SmPL rules

>> * Do we agree that a proper size determination is essential for every >> condition in the discussed SmPL rules together with forwarding >> this information? > > No. I don't mind a few false positives. Do you care to split SmPL rules by their confidence category in such an use case?

Re: Coccinelle: zalloc-simple: Checking consistency for SmPL rules

>> * Do we agree that a proper size determination is essential for every >> condition in the discussed SmPL rules together with forwarding >> this information? > > No. I don't mind a few false positives. Do you care to split SmPL rules by their confidence category in such an use case?

[PATCH] hid-sony: Delete an error message for a failed memory allocation in two functions

From: Markus Elfring Date: Fri, 2 Feb 2018 22:08:31 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] hid-sony: Delete an error message for a failed memory allocation in two functions

From: Markus Elfring Date: Fri, 2 Feb 2018 22:08:31 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-sony.c | 5 + 1 file changed, 1 insertion(+), 4

[PATCH] hid-zydacron: Delete an error message for a failed memory allocation in zc_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 21:41:37 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] hid-zydacron: Delete an error message for a failed memory allocation in zc_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 21:41:37 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-zydacron.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH] hsi_char: Delete an error message for a failed memory allocation in hsc_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 21:21:12 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] hsi_char: Delete an error message for a failed memory allocation in hsc_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 21:21:12 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hsi/clients/hsi_char.c | 5 ++--- 1 file changed, 2

[PATCH 0/2] HSI: ssi_protocol: Adjustments for two function implementations

From: Markus Elfring Date: Fri, 2 Feb 2018 21:03:45 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in ssi_protocol_probe() Fix a typo in two

[PATCH 0/2] HSI: ssi_protocol: Adjustments for two function implementations

From: Markus Elfring Date: Fri, 2 Feb 2018 21:03:45 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in ssi_protocol_probe() Fix a typo in two comment lines

[PATCH 2/2] HSI: ssi_protocol: Fix a typo in two comment lines

From: Markus Elfring Date: Fri, 2 Feb 2018 20:57:23 +0100 Adjust two words in this description. Signed-off-by: Markus Elfring --- drivers/hsi/clients/ssi_protocol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 2/2] HSI: ssi_protocol: Fix a typo in two comment lines

From: Markus Elfring Date: Fri, 2 Feb 2018 20:57:23 +0100 Adjust two words in this description. Signed-off-by: Markus Elfring --- drivers/hsi/clients/ssi_protocol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hsi/clients/ssi_protocol.c

[PATCH 1/2] HSI: ssi_protocol: Delete an error message for a failed memory allocation in ssi_protocol_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 20:02:17 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] HSI: ssi_protocol: Delete an error message for a failed memory allocation in ssi_protocol_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 20:02:17 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hsi/clients/ssi_protocol.c | 4 +--- 1 file changed, 1

[PATCH 2/2] i2c-bfin-twi: Improve a size determination in i2c_bfin_twi_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 19:01:14 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/2] i2c-bfin-twi: Improve a size determination in i2c_bfin_twi_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 19:01:14 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/2] i2c-bfin-twi: Delete an error message for a failed memory allocation in i2c_bfin_twi_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 18:55:04 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] i2c-bfin-twi: Delete an error message for a failed memory allocation in i2c_bfin_twi_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 18:55:04 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/i2c/busses/i2c-bfin-twi.c | 4 +--- 1 file changed, 1

[PATCH 0/2] I2C-Blackfin TWI: Adjustments for i2c_bfin_twi_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 19:09:08 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination

[PATCH 0/2] I2C-Blackfin TWI: Adjustments for i2c_bfin_twi_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 19:09:08 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/i2c/busses/i2c-bfin-twi.c | 7 ++-

[PATCH 1/2] i2c-davinci: Delete an error message for a failed memory allocation in davinci_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 18:00:20 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] i2c-davinci: Delete an error message for a failed memory allocation in davinci_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 18:00:20 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/i2c/busses/i2c-davinci.c | 4 +--- 1 file changed, 1

[PATCH 2/2] i2c-davinci: Improve a size determination in davinci_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 18:02:49 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/2] i2c-davinci: Improve a size determination in davinci_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 18:02:49 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 0/2] I2C-DaVinci: Adjustments for davinci_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 18:16:14 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination

[PATCH 0/2] I2C-DaVinci: Adjustments for davinci_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 18:16:14 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/i2c/busses/i2c-davinci.c | 7 ++-

[PATCH] i2c-ibm_iic: Delete an error message for a failed memory allocation in iic_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 17:24:57 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] i2c-ibm_iic: Delete an error message for a failed memory allocation in iic_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 17:24:57 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/i2c/busses/i2c-ibm_iic.c | 4 +--- 1 file changed, 1

[PATCH 2/2] i2c-nomadik: Improve a size determination in nmk_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 16:28:20 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/2] i2c-nomadik: Improve a size determination in nmk_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 16:28:20 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/2] i2c-nomadik: Delete an error message for a failed memory allocation in nmk_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 16:25:14 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] i2c-nomadik: Delete an error message for a failed memory allocation in nmk_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 16:25:14 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/i2c/busses/i2c-nomadik.c | 1 - 1 file changed, 1 deletion(-)

[PATCH 0/2] I2C-Nomadik: Adjustments for nmk_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 16:34:56 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination

[PATCH 0/2] I2C-Nomadik: Adjustments for nmk_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 16:34:56 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/i2c/busses/i2c-nomadik.c | 3 +-- 1

[PATCH 2/2] i2c-puv3: Improve a size determination in puv3_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 15:43:21 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/2] i2c-puv3: Improve a size determination in puv3_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 15:43:21 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/2] i2c-puv3: Delete an error message for a failed memory allocation in puv3_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 15:41:26 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] i2c-puv3: Delete an error message for a failed memory allocation in puv3_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 15:41:26 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/i2c/busses/i2c-puv3.c | 1 - 1 file changed, 1 deletion(-)

[PATCH 0/2] i2c-puv3: Adjustments for puv3_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 15:54:32 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination

[PATCH 0/2] i2c-puv3: Adjustments for puv3_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 15:54:32 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/i2c/busses/i2c-puv3.c | 3 +-- 1 file

[PATCH 2/2] i2c-sh7760: Improve a size determination in sh7760_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 14:50:09 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/2] i2c-sh7760: Improve a size determination in sh7760_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 14:50:09 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/2] i2c-sh7760: Delete an error message for a failed memory allocation in sh7760_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 11:46:02 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] i2c-sh7760: Delete an error message for a failed memory allocation in sh7760_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 11:46:02 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/i2c/busses/i2c-sh7760.c | 1 - 1 file changed, 1 deletion(-)

[PATCH 0/2] i2c-sh7760: Adjustments for sh7760_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 15:18:29 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination

[PATCH 0/2] i2c-sh7760: Adjustments for sh7760_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 15:18:29 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/i2c/busses/i2c-sh7760.c | 3 +-- 1

Re: Adjustments for a lot of function implementations

> One last time: either post per-driver patches with all the cleanups for a > driver > in a single patch, I preferred to offer source code adjustments according to specific transformation patterns mostly for each software module separately (also in small patch series). > or a per-directory

Re: Adjustments for a lot of function implementations

> One last time: either post per-driver patches with all the cleanups for a > driver > in a single patch, I preferred to offer source code adjustments according to specific transformation patterns mostly for each software module separately (also in small patch series). > or a per-directory

Re: Adjustments for a lot of function implementations

> ??? I did that: either one patch per directory with the same type of change, > or one patch per driver combining all the changes for that driver. Do any contributors get into the mood to take another look at software updates from my selection of change possibilities in a more constructive way?

Re: Adjustments for a lot of function implementations

> ??? I did that: either one patch per directory with the same type of change, > or one patch per driver combining all the changes for that driver. Do any contributors get into the mood to take another look at software updates from my selection of change possibilities in a more constructive way?

[PATCH 2/2] i2c-tiny-usb: Return an error code only as a constant in i2c_tiny_usb_probe()

From: Markus Elfring Date: Thu, 1 Feb 2018 17:45:21 +0100 * Return an error code without storing it in an intermediate variable. * Delete the label "error" and local variable "retval" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring

[PATCH 2/2] i2c-tiny-usb: Return an error code only as a constant in i2c_tiny_usb_probe()

From: Markus Elfring Date: Thu, 1 Feb 2018 17:45:21 +0100 * Return an error code without storing it in an intermediate variable. * Delete the label "error" and local variable "retval" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring ---

[PATCH 1/2] i2c-tiny-usb: Delete an error message for a failed memory allocation in i2c_tiny_usb_probe()

From: Markus Elfring Date: Thu, 1 Feb 2018 17:36:50 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] i2c-tiny-usb: Delete an error message for a failed memory allocation in i2c_tiny_usb_probe()

From: Markus Elfring Date: Thu, 1 Feb 2018 17:36:50 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/i2c/busses/i2c-tiny-usb.c | 4 +--- 1 file changed, 1

[PATCH 0/2] i2c-tiny-usb: Adjustments for i2c_tiny_usb_probe()

From: Markus Elfring Date: Thu, 1 Feb 2018 17:51:23 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Return an error code only as a constant

[PATCH 0/2] i2c-tiny-usb: Adjustments for i2c_tiny_usb_probe()

From: Markus Elfring Date: Thu, 1 Feb 2018 17:51:23 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Return an error code only as a constant drivers/i2c/busses/i2c-tiny-usb.c |

[PATCH] i2c-mux-reg: Delete an error message for a failed memory allocation in i2c_mux_reg_probe_dt()

From: Markus Elfring Date: Thu, 1 Feb 2018 17:17:19 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] i2c-mux-reg: Delete an error message for a failed memory allocation in i2c_mux_reg_probe_dt()

From: Markus Elfring Date: Thu, 1 Feb 2018 17:17:19 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/i2c/muxes/i2c-mux-reg.c | 4 +--- 1 file changed, 1

Re: Coccinelle: reduce false positives

> +@safe depends on context || org || report exists@ > +expression x; > +position p; > +@@ > + > +( > + x = kmalloc(...) > +| > + x = kvasprintf(...) … * How do you think about to reduce also a bit of duplicate SmPL code? * Can it help to work with nested SmPL disjunctions here? Regards, Markus

Re: Coccinelle: reduce false positives

> +@safe depends on context || org || report exists@ > +expression x; > +position p; > +@@ > + > +( > + x = kmalloc(...) > +| > + x = kvasprintf(...) … * How do you think about to reduce also a bit of duplicate SmPL code? * Can it help to work with nested SmPL disjunctions here? Regards, Markus

<    1   2   3   4   5   6   7   8   9   10   >