[PATCH] mfd/viperboard: Delete an error message for a failed memory allocation in vprbrd_probe()

From: Markus Elfring Date: Tue, 16 Jan 2018 17:30:23 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] mfd/viperboard: Delete an error message for a failed memory allocation in vprbrd_probe()

From: Markus Elfring Date: Tue, 16 Jan 2018 17:30:23 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mfd/viperboard.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH] mfd/twl6030-irq: Delete an error message for a failed memory allocation in twl6030_init_irq()

From: Markus Elfring Date: Tue, 16 Jan 2018 17:06:51 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] mfd/twl6030-irq: Delete an error message for a failed memory allocation in twl6030_init_irq()

From: Markus Elfring Date: Tue, 16 Jan 2018 17:06:51 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mfd/twl6030-irq.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH] mfd/tps80031: Delete an error message for a failed memory allocation in tps80031_probe()

From: Markus Elfring Date: Tue, 16 Jan 2018 13:43:03 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] mfd/tps80031: Delete an error message for a failed memory allocation in tps80031_probe()

From: Markus Elfring Date: Tue, 16 Jan 2018 13:43:03 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mfd/tps80031.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH 4/4] mfd/tps65910: Move an assignment in tps65910_sleepinit()

From: Markus Elfring Date: Tue, 16 Jan 2018 12:22:28 +0100 Move the assignment for the local variable "dev" so that its setting will be performed after a configuration check by this function. Signed-off-by: Markus Elfring ---

[PATCH 4/4] mfd/tps65910: Move an assignment in tps65910_sleepinit()

From: Markus Elfring Date: Tue, 16 Jan 2018 12:22:28 +0100 Move the assignment for the local variable "dev" so that its setting will be performed after a configuration check by this function. Signed-off-by: Markus Elfring --- drivers/mfd/tps65910.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 3/4] mfd/tps65910: Delete an unnecessary variable initialisation in tps65910_sleepinit()

From: Markus Elfring Date: Tue, 16 Jan 2018 12:10:49 +0100 The local variable "dev" will be reassigned by a following statement. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring ---

[PATCH 3/4] mfd/tps65910: Delete an unnecessary variable initialisation in tps65910_sleepinit()

From: Markus Elfring Date: Tue, 16 Jan 2018 12:10:49 +0100 The local variable "dev" will be reassigned by a following statement. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/mfd/tps65910.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 2/4] mfd/tps65910: Delete an unnecessary variable initialisation in four functions

From: Markus Elfring Date: Tue, 16 Jan 2018 11:40:28 +0100 The local variable "ret" will be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring ---

[PATCH 2/4] mfd/tps65910: Delete an unnecessary variable initialisation in four functions

From: Markus Elfring Date: Tue, 16 Jan 2018 11:40:28 +0100 The local variable "ret" will be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/mfd/tps65910.c | 8 1 file changed, 4 insertions(+),

[PATCH 1/4] mfd/tps65910: Delete an error message for a failed memory allocation in tps65910_parse_dt()

From: Markus Elfring Date: Tue, 16 Jan 2018 11:14:40 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/4] mfd/tps65910: Delete an error message for a failed memory allocation in tps65910_parse_dt()

From: Markus Elfring Date: Tue, 16 Jan 2018 11:14:40 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mfd/tps65910.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH 0/4] mfd/tps65910: Adjustments for four function implementations

From: Markus Elfring Date: Tue, 16 Jan 2018 12:54:32 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Delete an error message for a failed memory allocation in tps65910_parse_dt() Delete an

[PATCH 0/4] mfd/tps65910: Adjustments for four function implementations

From: Markus Elfring Date: Tue, 16 Jan 2018 12:54:32 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Delete an error message for a failed memory allocation in tps65910_parse_dt() Delete an unnecessary variable initialisation in

[PATCH] mfd/tps6586x: Delete an error message for a failed memory allocation in tps6586x_parse_dt()

From: Markus Elfring Date: Tue, 16 Jan 2018 11:02:56 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] mfd/tps6586x: Delete an error message for a failed memory allocation in tps6586x_parse_dt()

From: Markus Elfring Date: Tue, 16 Jan 2018 11:02:56 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mfd/tps6586x.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH] mfd/tps65090: Delete an error message for a failed memory allocation in tps65090_i2c_probe()

From: Markus Elfring Date: Tue, 16 Jan 2018 10:37:33 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] mfd/tps65090: Delete an error message for a failed memory allocation in tps65090_i2c_probe()

From: Markus Elfring Date: Tue, 16 Jan 2018 10:37:33 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mfd/tps65090.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH] mfd/ti_am335x_tscadc: Delete an error message for a failed memory allocation in ti_tscadc_probe()

From: Markus Elfring Date: Tue, 16 Jan 2018 10:07:43 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] mfd/ti_am335x_tscadc: Delete an error message for a failed memory allocation in ti_tscadc_probe()

From: Markus Elfring Date: Tue, 16 Jan 2018 10:07:43 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mfd/ti_am335x_tscadc.c | 5 ++--- 1 file changed, 2

[PATCH 2/2] mfd: smsc-ece1099: Improve a size determination in smsc_i2c_probe()

From: Markus Elfring Date: Tue, 16 Jan 2018 08:58:26 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/2] mfd: smsc-ece1099: Improve a size determination in smsc_i2c_probe()

From: Markus Elfring Date: Tue, 16 Jan 2018 08:58:26 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/2] mfd: smsc-ece1099: Delete an error message for a failed memory allocation in smsc_i2c_probe()

From: Markus Elfring Date: Tue, 16 Jan 2018 08:52:27 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] mfd: smsc-ece1099: Delete an error message for a failed memory allocation in smsc_i2c_probe()

From: Markus Elfring Date: Tue, 16 Jan 2018 08:52:27 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mfd/smsc-ece1099.c | 4 +--- 1 file changed, 1 insertion(+),

[PATCH 0/2] mfd: smsc-ece1099: Adjustments for smsc_i2c_probe()

From: Markus Elfring Date: Tue, 16 Jan 2018 09:14:56 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination

[PATCH 0/2] mfd: smsc-ece1099: Adjustments for smsc_i2c_probe()

From: Markus Elfring Date: Tue, 16 Jan 2018 09:14:56 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/mfd/smsc-ece1099.c | 8 ++-- 1

Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()

>> * Would you like to add a tag “link”? > > Are you okay with this one? > https://lkml.org/lkml/2018/1/15/411 Yes. > - resend as v2 I was unsure about your patch handling from the previous replies. > Also, patch contains all your changes, so you should be credited > somehow - hence the

Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()

>> * Would you like to add a tag “link”? > > Are you okay with this one? > https://lkml.org/lkml/2018/1/15/411 Yes. > - resend as v2 I was unsure about your patch handling from the previous replies. > Also, patch contains all your changes, so you should be credited > somehow - hence the

Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()

> dev_dbg(dev, >"USB TLL Rev : 0x%x not recognized, assuming %d channels\n", > - ver, tll->nch); > + ver, nch); > break; Does this format string need an other indentation when you touch this statement? Regards,

Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()

> dev_dbg(dev, >"USB TLL Rev : 0x%x not recognized, assuming %d channels\n", > - ver, tll->nch); > + ver, nch); > break; Does this format string need an other indentation when you touch this statement? Regards,

Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()

>> So I hope that your solution approach will be also fine. >> Will it supersede my proposal? > > Who knows, perhaps it would be the best if you could judge yourself... I am also curious on how other contributors will respond to your following update suggestion. > 8< > > Subject:

Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()

>> So I hope that your solution approach will be also fine. >> Will it supersede my proposal? > > Who knows, perhaps it would be the best if you could judge yourself... I am also curious on how other contributors will respond to your following update suggestion. > 8< > > Subject:

Re: [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe()

> That said, you might end having only fragment of log in only one of thousands > And saying technician he needs to use another kernel (upgrade all machines) > and wait another several weeks for bug to trigger is no way. This was not really my intention here. > So until evolution reaches ARM

Re: [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe()

> That said, you might end having only fragment of log in only one of thousands > And saying technician he needs to use another kernel (upgrade all machines) > and wait another several weeks for bug to trigger is no way. This was not really my intention here. > So until evolution reaches ARM

Re: [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe()

>>> Now, if probe function calls devm_kzalloc two times and one of them fails, >>> you cannot easily say which one without looking at assembly listing. >> >> Will this situation change with any other implementation for such backtraces? > > How much that situation changes depends mainly on that

Re: [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe()

>>> Now, if probe function calls devm_kzalloc two times and one of them fails, >>> you cannot easily say which one without looking at assembly listing. >> >> Will this situation change with any other implementation for such backtraces? > > How much that situation changes depends mainly on that

Re: [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe()

@@ -258,7 +256,6 @@ static int usbtll_omap_probe(struct platform_device *pdev) GFP_KERNEL); if (!tll->ch_clk) { ret = -ENOMEM; - dev_err(dev, "Couldn't allocate memory for channel clocks\n"); >>> >>>

Re: [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe()

@@ -258,7 +256,6 @@ static int usbtll_omap_probe(struct platform_device *pdev) GFP_KERNEL); if (!tll->ch_clk) { ret = -ENOMEM; - dev_err(dev, "Couldn't allocate memory for channel clocks\n"); >>> >>>

Re: [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe()

>> @@ -258,7 +256,6 @@ static int usbtll_omap_probe(struct platform_device >> *pdev) >> GFP_KERNEL); >> if (!tll->ch_clk) { >> ret = -ENOMEM; >> -dev_err(dev, "Couldn't allocate memory for channel clocks\n"); > > I'd

Re: [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe()

>> @@ -258,7 +256,6 @@ static int usbtll_omap_probe(struct platform_device >> *pdev) >> GFP_KERNEL); >> if (!tll->ch_clk) { >> ret = -ENOMEM; >> -dev_err(dev, "Couldn't allocate memory for channel clocks\n"); > > I'd

[PATCH 3/3] mfd/sm501: Adjust 12 checks for null pointers

From: Markus Elfring Date: Mon, 15 Jan 2018 16:00:22 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus

[PATCH 3/3] mfd/sm501: Adjust 12 checks for null pointers

From: Markus Elfring Date: Mon, 15 Jan 2018 16:00:22 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code

[PATCH 2/3] mfd/sm501: Improve a size determination in two functions

From: Markus Elfring Date: Mon, 15 Jan 2018 15:47:03 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/3] mfd/sm501: Improve a size determination in two functions

From: Markus Elfring Date: Mon, 15 Jan 2018 15:47:03 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/3] mfd/sm501: Delete an error message for a failed memory allocation in two functions

From: Markus Elfring Date: Mon, 15 Jan 2018 15:40:46 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/3] mfd/sm501: Delete an error message for a failed memory allocation in two functions

From: Markus Elfring Date: Mon, 15 Jan 2018 15:40:46 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mfd/sm501.c | 2 -- 1 file changed, 2 deletions(-) diff

[PATCH 0/3] mfd/sm501: Adjustments for five function implementations

From: Markus Elfring Date: Mon, 15 Jan 2018 16:11:22 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation in two functions Improve a size determination

[PATCH 0/3] mfd/sm501: Adjustments for five function implementations

From: Markus Elfring Date: Mon, 15 Jan 2018 16:11:22 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation in two functions Improve a size determination in two functions Adjust 12

[PATCH] mfd/si476x-i2c: Delete an error message for a failed memory allocation in si476x_core_probe()

From: Markus Elfring Date: Mon, 15 Jan 2018 15:10:33 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] mfd/si476x-i2c: Delete an error message for a failed memory allocation in si476x_core_probe()

From: Markus Elfring Date: Mon, 15 Jan 2018 15:10:33 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mfd/si476x-i2c.c | 6 ++ 1 file changed, 2 insertions(+),

[PATCH 2/2] mfd/rc5t583: Improve a size determination in rc5t583_i2c_probe()

From: Markus Elfring Date: Mon, 15 Jan 2018 14:50:25 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/2] mfd/rc5t583: Improve a size determination in rc5t583_i2c_probe()

From: Markus Elfring Date: Mon, 15 Jan 2018 14:50:25 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/2] mfd/rc5t583: Delete an error message for a failed memory allocation in rc5t583_i2c_probe()

From: Markus Elfring Date: Mon, 15 Jan 2018 14:48:57 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] mfd/rc5t583: Delete an error message for a failed memory allocation in rc5t583_i2c_probe()

From: Markus Elfring Date: Mon, 15 Jan 2018 14:48:57 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mfd/rc5t583.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH 0/2] mfd/rc5t583: Adjustments for rc5t583_i2c_probe()

From: Markus Elfring Date: Mon, 15 Jan 2018 14:57:28 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination

[PATCH 0/2] mfd/rc5t583: Adjustments for rc5t583_i2c_probe()

From: Markus Elfring Date: Mon, 15 Jan 2018 14:57:28 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/mfd/rc5t583.c | 6 ++ 1 file

[PATCH 3/3] mfd/omap-usb-tll: Return an error code only as a constant in usbtll_omap_probe()

From: Markus Elfring Date: Mon, 15 Jan 2018 14:00:45 +0100 * Return an error code without storing it in an intermediate variable. * Delete the label "err_clk_alloc" and local variable "ret" which became unnecessary with this refactoring. Signed-off-by: Markus

[PATCH 3/3] mfd/omap-usb-tll: Return an error code only as a constant in usbtll_omap_probe()

From: Markus Elfring Date: Mon, 15 Jan 2018 14:00:45 +0100 * Return an error code without storing it in an intermediate variable. * Delete the label "err_clk_alloc" and local variable "ret" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring ---

[PATCH 2/3] mfd/omap-usb-tll: Improve a size determination in usbtll_omap_probe()

From: Markus Elfring Date: Mon, 15 Jan 2018 13:43:53 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/3] mfd/omap-usb-tll: Improve a size determination in usbtll_omap_probe()

From: Markus Elfring Date: Mon, 15 Jan 2018 13:43:53 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe()

From: Markus Elfring Date: Mon, 15 Jan 2018 13:39:25 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe()

From: Markus Elfring Date: Mon, 15 Jan 2018 13:39:25 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mfd/omap-usb-tll.c | 5 + 1 file changed, 1 insertion(+), 4

[PATCH 0/3] mfd/omap-usb-tll: Adjustments for usbtll_omap_probe()

From: Markus Elfring Date: Mon, 15 Jan 2018 14:09:28 +0100 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete two error messages for a failed memory allocation Improve a size determination Return an

[PATCH 0/3] mfd/omap-usb-tll: Adjustments for usbtll_omap_probe()

From: Markus Elfring Date: Mon, 15 Jan 2018 14:09:28 +0100 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete two error messages for a failed memory allocation Improve a size determination Return an error code only as a constant

Re: hyperv/netvsc: Delete two error messages for a failed memory allocation in netvsc_init_buf()

> These messages are not displayed anywhere else: > "unable to allocate receive buffer of size %u\n" > "unable to allocate send buffer of size %u\n", > > After set ret = -ENOMEM; and cleanup, we won't know which buffer allocation > failed without the error message. How do you think about to

Re: hyperv/netvsc: Delete two error messages for a failed memory allocation in netvsc_init_buf()

> These messages are not displayed anywhere else: > "unable to allocate receive buffer of size %u\n" > "unable to allocate send buffer of size %u\n", > > After set ret = -ENOMEM; and cleanup, we won't know which buffer allocation > failed without the error message. How do you think about to

[PATCH] mfd/max8997: Delete an error message for a failed memory allocation in max8997_i2c_parse_dt_pdata()

From: Markus Elfring Date: Mon, 15 Jan 2018 09:35:17 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] mfd/max8997: Delete an error message for a failed memory allocation in max8997_i2c_parse_dt_pdata()

From: Markus Elfring Date: Mon, 15 Jan 2018 09:35:17 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mfd/max8997.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH] mfd/jz4740-adc: Delete an error message for a failed memory allocation in jz4740_adc_probe()

From: Markus Elfring Date: Sun, 14 Jan 2018 22:26:21 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] mfd/jz4740-adc: Delete an error message for a failed memory allocation in jz4740_adc_probe()

From: Markus Elfring Date: Sun, 14 Jan 2018 22:26:21 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mfd/jz4740-adc.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH] mfd/janz-cmodio: Delete an error message for a failed memory allocation in cmodio_pci_probe()

From: Markus Elfring Date: Sun, 14 Jan 2018 22:15:09 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] mfd/janz-cmodio: Delete an error message for a failed memory allocation in cmodio_pci_probe()

From: Markus Elfring Date: Sun, 14 Jan 2018 22:15:09 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mfd/janz-cmodio.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH] mfd/htc-i2cpld: Delete an error message for a failed memory allocation in htcpld_setup_chips()

From: Markus Elfring Date: Sun, 14 Jan 2018 22:02:16 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] mfd/htc-i2cpld: Delete an error message for a failed memory allocation in htcpld_setup_chips()

From: Markus Elfring Date: Sun, 14 Jan 2018 22:02:16 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mfd/htc-i2cpld.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH 3/3] mfd/abx500-core: Adjust 14 checks for null pointers

From: Markus Elfring Date: Sun, 14 Jan 2018 21:31:50 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus

[PATCH 3/3] mfd/abx500-core: Adjust 14 checks for null pointers

From: Markus Elfring Date: Sun, 14 Jan 2018 21:31:50 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code

[PATCH 2/3] mfd/abx500-core: Improve two size determinations in abx500_register_ops()

From: Markus Elfring Date: Sun, 14 Jan 2018 21:19:10 +0100 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding

[PATCH 2/3] mfd/abx500-core: Improve two size determinations in abx500_register_ops()

From: Markus Elfring Date: Sun, 14 Jan 2018 21:19:10 +0100 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/3] mfd/abx500-core: Delete an error message for a failed memory allocation in abx500_register_ops()

From: Markus Elfring Date: Sun, 14 Jan 2018 21:08:27 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/3] mfd/abx500-core: Delete an error message for a failed memory allocation in abx500_register_ops()

From: Markus Elfring Date: Sun, 14 Jan 2018 21:08:27 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mfd/abx500-core.c | 5 ++--- 1 file changed, 2 insertions(+),

[PATCH 0/3] mfd/abx500-core: Adjustments for eight function implementations

From: Markus Elfring Date: Sun, 14 Jan 2018 21:38:42 +0100 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation in abx500_register_ops() Improve two

[PATCH 0/3] mfd/abx500-core: Adjustments for eight function implementations

From: Markus Elfring Date: Sun, 14 Jan 2018 21:38:42 +0100 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation in abx500_register_ops() Improve two size determinations in

Re: pci/setup-bus: Delete an error message for a failed memory allocation in add_to_list()

> Your commit message says "omit an extra message", which suggests that > there are currently two messages about the memory allocation failure, > and that your patch removes one of them. Yes. - There is a general transformation pattern applied. > If that's the case, it would be nice to know

Re: pci/setup-bus: Delete an error message for a failed memory allocation in add_to_list()

> Your commit message says "omit an extra message", which suggests that > there are currently two messages about the memory allocation failure, > and that your patch removes one of them. Yes. - There is a general transformation pattern applied. > If that's the case, it would be nice to know

[PATCH] sunrpc: Use seq_putc() in unix_gid_show()

From: Markus Elfring Date: Sat, 13 Jan 2018 20:33:05 +0100 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH] sunrpc: Use seq_putc() in unix_gid_show()

From: Markus Elfring Date: Sat, 13 Jan 2018 20:33:05 +0100 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/sunrpc/svcauth_unix.c | 2

[PATCH] l2tp: Use seq_putc() in l2tp_dfs_seq_session_show()

From: Markus Elfring Date: Sat, 13 Jan 2018 20:11:01 +0100 Two single characters (line breaks) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH] l2tp: Use seq_putc() in l2tp_dfs_seq_session_show()

From: Markus Elfring Date: Sat, 13 Jan 2018 20:11:01 +0100 Two single characters (line breaks) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/l2tp/l2tp_debugfs.c |

[PATCH] fs/proc: Use seq_putc() in show_console_dev()

From: Markus Elfring Date: Sat, 13 Jan 2018 17:17:59 +0100 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH] fs/proc: Use seq_putc() in show_console_dev()

From: Markus Elfring Date: Sat, 13 Jan 2018 17:17:59 +0100 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/proc/consoles.c | 3 +-- 1

[PATCH] ocfs2: Combine two seq_printf() calls into one call in ocfs2_dlm_seq_show()

From: Markus Elfring Date: Sat, 13 Jan 2018 16:36:51 +0100 Some data were printed into a sequence by two separate function calls. Print almost the same data by a single function call instead. (Omit a tab character at the line end within a format string.) This

[PATCH] ocfs2: Combine two seq_printf() calls into one call in ocfs2_dlm_seq_show()

From: Markus Elfring Date: Sat, 13 Jan 2018 16:36:51 +0100 Some data were printed into a sequence by two separate function calls. Print almost the same data by a single function call instead. (Omit a tab character at the line end within a format string.) This issue was detected by using the

[PATCH 2/2] nfsd: Adjust four function calls together with a variable assignment

From: Markus Elfring Date: Sat, 13 Jan 2018 14:40:44 +0100 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code places. Signed-off-by: Markus Elfring

[PATCH 2/2] nfsd: Adjust four function calls together with a variable assignment

From: Markus Elfring Date: Sat, 13 Jan 2018 14:40:44 +0100 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code places. Signed-off-by: Markus Elfring --- fs/nfsd/export.c | 13 + 1

[PATCH 1/2] nfsd: Use seq_putc() in four functions

From: Markus Elfring Date: Sat, 13 Jan 2018 14:20:27 +0100 Five single characters should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 1/2] nfsd: Use seq_putc() in four functions

From: Markus Elfring Date: Sat, 13 Jan 2018 14:20:27 +0100 Five single characters should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/nfsd/export.c| 6 +++---

[PATCH 0/2] NFSD: Adjustments for six function implementations

From: Markus Elfring Date: Sat, 13 Jan 2018 15:00:15 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use seq_putc() in four functions Adjust four function calls together with a variable assignment

[PATCH 0/2] NFSD: Adjustments for six function implementations

From: Markus Elfring Date: Sat, 13 Jan 2018 15:00:15 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use seq_putc() in four functions Adjust four function calls together with a variable assignment fs/nfsd/export.c| 19

<    4   5   6   7   8   9   10   11   12   13   >