m64: use -mno-implicit-float instead of -mgeneral-regs-only
Sami Tolvanen (2):
kbuild: add clang-version.sh
kbuild: add cc-if-name-version and compiler-specific variants
arch/arm64/Makefile | 5 -
scripts/Kbuild.include | 31 +++
scripts/clang-version
This change adds macros for testing both compiler name and
version. Current cc-version, cc-ifversion etc. macros that test
gcc version are left unchanged to prevent compatibility issues
with existing tests.
Signed-off-by: Sami Tolvanen
---
scripts/Kbuild.include | 31
Based on gcc-version.sh, clang-version.sh prints out the correct
version of clang.
Signed-off-by: Sami Tolvanen
---
scripts/clang-version.sh | 33 +
1 file changed, 33 insertions(+)
create mode 100755 scripts/clang-version.sh
diff --git a/scripts/clang
e the workaround only for clang <6.0]
Signed-off-by: Sami Tolvanen
---
arch/arm64/Makefile | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index b35788c909f1..d2efb5a0212f 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/
Based on gcc-version.sh, clang-version.sh prints out the correct
version of clang.
Signed-off-by: Sami Tolvanen
Tested-by: Nick Desaulniers
---
scripts/clang-version.sh | 33 +
1 file changed, 33 insertions(+)
create mode 100755 scripts/clang-version.sh
diff
This change adds macros for testing both compiler name and
version. Current cc-version, cc-ifversion etc. macros that test
gcc version are left unchanged to prevent compatibility issues
with existing tests.
Signed-off-by: Sami Tolvanen
---
scripts/Kbuild.include | 41
Don't remove .head.text or .exitcall.exit when linking with --gc-sections,
and include .init.text.* in .init.text and .init.rodata.* in .init.rodata.
Signed-off-by: Sami Tolvanen
Reviewed-by: Nicholas Piggin
---
include/asm-generic/vmlinux.lds.h | 8
1 file changed, 4 insertions(
GNU gold may require different flags than GNU ld. Add a macro for
detecting the linker.
Signed-off-by: Sami Tolvanen
Reviewed-by: Nick Desaulniers
---
scripts/Kbuild.include | 4
1 file changed, 4 insertions(+)
diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
index
e the erratum
fix is not used even if the linker is configured to enable it by
default.
This change also adds a warning if the erratum fix is enabled and
gold version <1.14 is used.
Signed-off-by: Sami Tolvanen
---
arch/arm64/Makefile | 9 +
1 file changed, 9 insertions(+)
diff --git a/ar
This patch set adds macros for checking clang version.
Changes from v1:
- fixed a comment in clang-version.sh
- renamed macros to __cc-ifversion and __cc-if-fullversion
- fixed a bug with non-bash shells
- dropped the arm64 patch as unnecessary
Sami Tolvanen (2):
kbuild: add clang
Add macros for testing both linker name and version.
Signed-off-by: Sami Tolvanen
---
scripts/Kbuild.include | 12
1 file changed, 12 insertions(+)
diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
index 899863e4cd05..2991b463b4ce 100644
--- a/scripts/Kbuild.include
GNU gold supports different emulations than bfd. Use aarch64_elf64_*_vec
instead of aarch64linux.
Signed-off-by: Sami Tolvanen
Acked-by: Yury Norov
---
arch/arm64/Makefile | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index b35788c909f1
All current versions of GNU gold crash when linking kernel modules
with ARM64_MODULE_PLTS due to a known bug:
https://sourceware.org/bugzilla/show_bug.cgi?id=14592
To work around the problem, this change removes NOLOAD from .plt
and .init.plt.
Signed-off-by: Sami Tolvanen
Acked-by: Ard
Make sure the linker doesn't remove .altinstructions or
.altinstr_replacement when CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is
enabled.
Signed-off-by: Sami Tolvanen
---
arch/arm64/kernel/vmlinux.lds.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/k
-name-version to __ld-ifversion for consistency
- cleaned up the erratum changes in arch/arm64/Makefile
Sami Tolvanen (7):
kbuild: fix LD_DEAD_CODE_DATA_ELIMINATION
arm64: keep .altinstructions and .altinstr_replacement
kbuild: add ld-name macro
kbuild: add __ld-ifversion and linker
which is part of the 5.0
release, but not in the latest Android clang prebuilts. Before this
change, no branches were generated in __init_stage2_translation.
Using -mllvm -jump-threading-threshold=0 also appears to solve this
problem.
Sami
seems to be happy with it.
> It has solved many problems you also try to solve, and some patches
> are looking very similar.
I haven't had a closer look at the gcc LTO patches yet, but I am definitely
all for using common code where possible.
Sami
problem by reusing vmlinux.o for
kallsyms instead of linking all bitcode again in each step. I'm not sure
if this is feasible with gcc.
Sami
On Thu, Nov 09, 2017 at 07:48:06AM +0300, Maxim Kuvyrkov wrote:
> Regarding CONFIG_* options, I would expect most of the configuration
> changes to be equally valid for both GCC's and Clang's LTO support.
> Sami, I don't think it's fair to ask you to support both Cla
s awkward as well.
I agree. Unless someone objects, I'll replace this in v2 with a patch that
leaves the relocations in module.c even when the erratum is selected.
Sami
rop this patch in v3 as passing code model to LLVMgold
fixes the issue with LTO.
Sami
x27;t know how to deal with an archive of LLVM IR
files, but I can certainly use thin archives as an index and extract
the path names for linking. I'll look into it.
Sami
about older versions
of gold.
Sami
;aese
v0.16b, v1.16b ;umov w12, v0.4s[0] ;
^
LLVM ERROR: Error parsing inline asm
Sami
our compat issue.
Sure, that would also work.
Sami
Absolutely. I'll split the patches into more sensible sets.
Sami
ugh.
Sami
d changing the config option prefix to LTO_GCC, for
example? It looks like there are a few places where gcc LTO needs
to be disabled, but clang LTO works fine, and vice versa.
My earlier clang LTO patches also had a solution for MODVERSIONS,
which might work with gcc as well.
Sami
v3 for review once I receive some feedback for the clang/gold patches we
need first.
Sami
These patches add macros for detecting the linker name and version,
and apply fixes and workarounds needed to link the arm64 kernel with
GNU gold.
Sami Tolvanen (7):
kbuild: add ld-name macro and support for GNU gold
kbuild: add ld-if-name-version and linker-specific macros
kbuild: fix
Add macros for testing both linker name and version.
Signed-off-by: Sami Tolvanen
---
scripts/Kbuild.include | 12
1 file changed, 12 insertions(+)
diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
index a7c7843c2cf1..5d286d69e8dc 100644
--- a/scripts/Kbuild.include
All current versions of GNU gold crash when linking kernel modules
with ARM64_MODULE_PLTS due to a known bug:
https://sourceware.org/bugzilla/show_bug.cgi?id=14592
To work around the problem, this change removes NOLOAD from .plt
and .init.plt.
Signed-off-by: Sami Tolvanen
---
arch/arm64
e the erratum
fix is not used even if the linker is configured to enable it by
default.
This change also adds a warning if the erratum fix is enabled and
gold version <1.14 is used.
Signed-off-by: Sami Tolvanen
---
arch/arm64/Makefile | 9 +
1 file changed, 9 insertions(+)
diff --git a/ar
Make sure the linker doesn't remove .altinstructions or
.altinstr_replacement when CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is
enabled.
Signed-off-by: Sami Tolvanen
---
arch/arm64/kernel/vmlinux.lds.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/k
Don't remove .head.text or .exitcall.exit when linking with --gc-sections,
and include .init.text.* in .init.text and .init.rodata.* in .init.rodata.
Signed-off-by: Sami Tolvanen
---
include/asm-generic/vmlinux.lds.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --
GNU gold supports different emulations than bfd. Use aarch64_elf64_*_vec
instead of aarch64linux.
Signed-off-by: Sami Tolvanen
Acked-by: Yury Norov
---
arch/arm64/Makefile | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index b35788c909f1
GNU gold may require different flags than GNU ld. Add a macro for
detecting the linker and conditionally add gold specific flags from
LDFLAGS_GOLD.
Signed-off-by: Sami Tolvanen
Reviewed-by: Nick Desaulniers
---
Makefile | 5 +
scripts/Kbuild.include | 4
2 files changed
lversion for consistency?
> I think you can do like follows to avoid code duplication.
>
> # backward compatibility
> cc-ifversion = $(gcc-ifversion)
> cc-if-fullversion = $(gcc-if-fullversion)
Sure, both changes sound good to me. I'll fix these in v2.
Sami
ving
it in v2.
Sami
ossibly then you could also do a 3rd patch to allow arm64 to
> select it if it's working with gcc?
These patches only fix the issues I ran into with clang and gold
when testing on a single device. I feel like more testing would
be needed before enabling this by default for arm64.
Sami
else
> ...
>
> ?
Sure. I'll clean this up in v2.
Sami
To avoid duplication between host programs, move the crc32 code to a
shared header file.
Suggested-by: Petr Pavlu
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
scripts/genksyms/genksyms.c | 77 +-
scripts/include/crc32.h | 93
Add a basic DWARF parser, which uses libdw to traverse the debugging
information in an object file and looks for functions and variables.
In follow-up patches, this will be expanded to produce symbol versions
for CONFIG_MODVERSIONS from DWARF.
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
m/samitolvanen/linux/commits/gendwarfksyms-v4
If you also want to test the series with Rust modules, this branch
adds Matt's latest modversion_info series and a small patch to enable
Rust modversions:
https://github.com/samitolvanen/linux/commits/rustmodversions-v4
Sami
[1] https://lore.kern
Basic types in DWARF repeat frequently and traversing the DIEs using
libdw is relatively slow. Add a simple hashtable based cache for the
processed DIEs.
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
scripts/gendwarfksyms/Makefile| 1 +
scripts/gendwarfksyms/die.c
variable base_type unsigned long byte_size(8) encoding(7)
...
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
Reviewed-by: Petr Pavlu
---
scripts/gendwarfksyms/dwarf.c | 159 ++
1 file changed, 159 insertions(+)
diff --git a/scripts/gendwarfksyms/dwarf.c
-off-by: Sami Tolvanen
Acked-by: Neal Gompa
Reviewed-by: Petr Pavlu
---
scripts/gendwarfksyms/die.c | 12 +
scripts/gendwarfksyms/dwarf.c | 67 +++
scripts/gendwarfksyms/gendwarfksyms.h | 5 ++
3 files changed, 84 insertions(+)
diff --git a/scripts
d-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
scripts/gendwarfksyms/gendwarfksyms.c | 2 +
scripts/gendwarfksyms/gendwarfksyms.h | 13 +++
scripts/gendwarfksyms/symbols.c | 148 ++
3 files changed, 163 insertions(+)
diff --git a/scripts/gendwarf
type {
base_type u8 byte_size(1) encoding(7)
} data_ptr data_member_location(0) ,
member base_type usize byte_size(8) encoding(7) length
data_member_location(8)
} byte_size(16) alignment(8) msg
)
-> base_type void
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
)
}
}
)
-> base_type unsigned long byte_size(8) encoding(7)
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
Reviewed-by: Petr Pavlu
---
scripts/gendwarfksyms/dwarf.c | 84 ++-
scripts/gendwarfksyms/gendwarfksyms.h | 4 ++
2 files changed, 85 insertions(+)
Hi Luis,
On Fri, Oct 11, 2024 at 4:42 PM Luis Chamberlain wrote:
>
> On Tue, Oct 08, 2024 at 06:38:24PM +, Sami Tolvanen wrote:
> > Hi,
> >
> > Here's v4 of the DWARF modversions series. The main motivation is
> > modversions support for Rust, which is i
tory.
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
scripts/gendwarfksyms/Makefile | 1 +
scripts/gendwarfksyms/dwarf.c | 19 +-
scripts/gendwarfksyms/examples/kabi.h | 61 ++
scripts/gendwarfksyms/examples/kabi_rules.c | 56 +
s
references are
wrapped in single quotes. E.g.:
s#'core::result::Result'
2. The actual type definition is the simple parsed DWARF format we
output with --dump-dies, not the preprocessed C-style format
genksyms produces.
Signed-off-by: Sami Tolvanen
Acked-by:
Calculate symbol versions from the fully expanded type strings in
type_map, and output the versions in a genksyms-compatible format.
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
scripts/gendwarfksyms/dwarf.c | 25 +-
scripts/gendwarfksyms/gendwarfksyms.c | 11
type. This should be plenty for detecting ABI
differences, but it stops us from pulling in half the kernel for
types that contain pointers to large kernel data structures, like
task_struct, for example.
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
scripts/gendwarfksyms/Makefile
Debugging the DWARF processing can be somewhat challenging, so add
more detailed debugging output for die_map operations. Add the
--dump-die-map flag, which adds color coded tags to the output for
die_map changes.
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
scripts/gendwarfksyms
(8)
}
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
Reviewed-by: Petr Pavlu
---
scripts/gendwarfksyms/dwarf.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/scripts/gendwarfksyms/dwarf.c b/scripts/gendwarfksyms/dwarf.c
index 7e6b477d7c12..ade9b3b7b119
truct {
int b;
int v;
};
};
Here gendwarfksyms --stable replaces the union with the type of the
placeholder field when calculating versions.
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
scripts/gendwarfksyms/dwarf.c | 202 +-
sc
Add documentation for gendwarfksyms changes, and the kABI stability
features that can be useful for distributions even though they're not
used in mainline kernels.
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
Documentation/kbuild/gendwarfksyms.rst
xternal_symbol);
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
scripts/gendwarfksyms/dwarf.c | 55 +-
scripts/gendwarfksyms/examples/symbolptr.c | 33 +
scripts/gendwarfksyms/gendwarfksyms.h | 7 +++
scripts/gendwarfksyms/symbols.c
When MODVERSIONS is enabled, allow selecting gendwarfksyms as the
implementation, but default to genksyms.
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
kernel/module/Kconfig | 25 -
scripts/Makefile | 2 +-
scripts/Makefile.build | 39
igned-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
include/linux/export.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/include/linux/export.h b/include/linux/export.h
index 0bbd02fd351d..cf71d3202e5b 100644
--- a/include/linux/export.h
+++ b/include/linux/export.h
@@
quired modules with
> scripts/sign-file"
> choice
> prompt "Hash algorithm to sign modules"
> depends on MODULE_SIG || IMA_APPRAISE_MODSIG
> + default MODULE_SIG_SHA512
> help
> This determines which sort of hashing algorithm will be used during
> signature generation. This algorithm _must_ be built into the
> kernel
This looks good to me. Thank you for the patch!
Reviewed-by: Sami Tolvanen
Sami
nel/module/main.c | 569 +--
> 2 files changed, 428 insertions(+), 148 deletions(-)
Looks like these patches are unchanged from the pre-split version[1].
For the series:
Reviewed-by: Sami Tolvanen
[1]
https://lore.kernel.org/linux-modules/20240925233854.90072-1-mmau...@google.com/
Sami
TENDED_MODVERSIONS
in scripts/Makefile.modpost instead.
[1] https://github.com/samitolvanen/linux/commits/rustmodversions
Sami
essed the section attribute,
> leading to a regex mismatch. Update it to match modpost.c
>
> [1]:
> https://lore.kernel.org/all/20190909113423.2289-2-yamada.masah...@socionext.com/
If this script has been broken for half a decade and nobody noticed,
does anyone actually use it? If this is dead code, I would prefer to
just delete it.
Sami
Hi Petr,
On Wed, Oct 16, 2024 at 2:16 PM Petr Pavlu wrote:
>
> On 10/8/24 20:38, Sami Tolvanen wrote:
> > /*
> > - * These can be emitted for stand-elone assembly code, which means we
> > + * These can be emitted for stand-alone assembly code, which mea
unds like a better
> solution. Will likely give it a try, unless someone brings up unwanted
> side effects this might cause.
Yes, that would be a much better way to change the default. Overall,
moving away from SHA-1 seems like a good idea and SHA-512 feels like a
reasonable choice. Luis, do you see any issues with changing the
default here?
Sami
Drop patches to fix export_report.pl
Unless Luis prefers to deal with this separately, perhaps you can
just include a patch to delete export_report.pl in this series?
Sami
of it because it is clearly unused.
>
> Signed-off-by: Matthew Maurer
Thanks for the patch! Applying this separately without waiting for the
rest of the extended modversions series to land makes sense to me.
Reviewed-by: Sami Tolvanen
Sami
talled" >&2
> + exit $ksft_skip
> + fi
Is there a reason to test for kmod? I don't see it called directly in
this script.
Also, shouldn't you add the module directory to TARGETS in
tools/testing/selftests/Makefile? Otherwise the script won't be
installed with the rest of kselftests.
Sami
Add a basic DWARF parser, which uses libdw to traverse the debugging
information in an object file and looks for functions and variables.
In follow-up patches, this will be expanded to produce symbol versions
for CONFIG_MODVERSIONS from DWARF.
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
Debugging the DWARF processing can be somewhat challenging, so add
more detailed debugging output for die_map operations. Add the
--dump-die-map flag, which adds color coded tags to the output for
die_map changes.
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
Reviewed-by: Petr Pavlu
type {
base_type u8 byte_size(1) encoding(7)
} data_ptr data_member_location(0) ,
member base_type usize byte_size(8) encoding(7) length
data_member_location(8)
} byte_size(16) alignment(8) msg
)
-> base_type void
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
Reviewed-b
To avoid duplication between host programs, move the crc32 code to a
shared header file.
Suggested-by: Petr Pavlu
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
scripts/genksyms/genksyms.c | 77 +-
scripts/include/crc32.h | 93
d-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
scripts/gendwarfksyms/gendwarfksyms.c | 2 +
scripts/gendwarfksyms/gendwarfksyms.h | 13 +++
scripts/gendwarfksyms/symbols.c | 161 ++
3 files changed, 176 insertions(+)
diff --git a/scripts/gendwarf
-off-by: Sami Tolvanen
Acked-by: Neal Gompa
Reviewed-by: Petr Pavlu
---
scripts/gendwarfksyms/die.c | 12 +
scripts/gendwarfksyms/dwarf.c | 67 +++
scripts/gendwarfksyms/gendwarfksyms.h | 5 ++
3 files changed, 84 insertions(+)
diff --git a/scripts
variable base_type unsigned long byte_size(8) encoding(7)
...
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
Reviewed-by: Petr Pavlu
---
scripts/gendwarfksyms/dwarf.c | 159 ++
1 file changed, 159 insertions(+)
diff --git a/scripts/gendwarfksyms/dwarf.c
)
}
}
)
-> base_type unsigned long byte_size(8) encoding(7)
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
Reviewed-by: Petr Pavlu
---
scripts/gendwarfksyms/dwarf.c | 84 ++-
scripts/gendwarfksyms/gendwarfksyms.h | 4 ++
2 files changed, 85 insertions(+)
(8)
}
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
Reviewed-by: Petr Pavlu
---
scripts/gendwarfksyms/dwarf.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/scripts/gendwarfksyms/dwarf.c b/scripts/gendwarfksyms/dwarf.c
index 7e6b477d7c12..ade9b3b7b119
tory.
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
scripts/gendwarfksyms/Makefile | 1 +
scripts/gendwarfksyms/dwarf.c | 19 +-
scripts/gendwarfksyms/examples/kabi.h | 61 +
scripts/gendwarfksyms/examples/kabi_rules.c | 56 +
s
references are
wrapped in single quotes. E.g.:
s#'core::result::Result'
2. The actual type definition is the simple parsed DWARF format we
output with --dump-dies, not the preprocessed C-style format
genksyms produces.
Signed-off-by: Sami Tolvanen
Acked-by:
type. This should be plenty for detecting ABI
differences, but it stops us from pulling in half the kernel for
types that contain pointers to large kernel data structures, like
task_struct, for example.
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
scripts/gendwarfksyms/Makefile
Calculate symbol versions from the fully expanded type strings in
type_map, and output the versions in a genksyms-compatible format.
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
scripts/gendwarfksyms/dwarf.c | 25 +-
scripts/gendwarfksyms/gendwarfksyms.c | 10
truct {
int b;
int v;
};
};
Here gendwarfksyms --stable replaces the union with the type of the
placeholder field when calculating versions.
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
Reviewed-by: Petr Pavlu
---
scripts/gendwarfksyms/dwarf.c
xternal_symbol);
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
Reviewed-by: Petr Pavlu
---
scripts/gendwarfksyms/dwarf.c | 55 +-
scripts/gendwarfksyms/examples/symbolptr.c | 33 +
scripts/gendwarfksyms/gendwarfksyms.h | 7 +++
scripts/gendwarfk
Add documentation for gendwarfksyms changes, and the kABI stability
features that can be useful for distributions even though they're not
used in mainline kernels.
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
Documentation/kbuild/gendwarfksyms.rst
Basic types in DWARF repeat frequently and traversing the DIEs using
libdw is relatively slow. Add a simple hashtable based cache for the
processed DIEs.
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
Reviewed-by: Petr Pavlu
---
scripts/gendwarfksyms/Makefile| 1 +
scripts
igned-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
include/linux/export.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/include/linux/export.h b/include/linux/export.h
index 0bbd02fd351d..cf71d3202e5b 100644
--- a/include/linux/export.h
+++ b/include/linux/export.h
@@
When MODVERSIONS is enabled, allow selecting gendwarfksyms as the
implementation, but default to genksyms.
Signed-off-by: Sami Tolvanen
Acked-by: Neal Gompa
---
kernel/module/Kconfig | 25 -
scripts/Makefile | 2 +-
scripts/Makefile.build | 41
m/samitolvanen/linux/commits/rustmodversions-v5
Sami
[1] https://lore.kernel.org/lkml/znizetkkqweig...@bombadil.infradead.org/
[2] https://lore.kernel.org/lkml/20240925233854.90072-1-mmau...@google.com/
---
v5:
- Rebased on v6.12-rc5.
- Fixed an issue with limiting structure expansion, and appli
Hi Sedat,
On Wed, Oct 30, 2024 at 2:00 PM Sedat Dilek wrote:
>
> Hi Sami,
>
> perfect timing: Nathan uploaded SLIM LLVM toolchain v19.1.3
>
> KBUILD_GENDWARFKSYMS_STABLE is to be set manually?
> What value is recommended?
The usage is similar to KBUILD_SYMTY
we reproduce
> the munging for the new format. Other architectures do not appear to
> have architecture-specific usage of this information.
>
> Signed-off-by: Matthew Maurer
Reviewed-by: Sami Tolvanen
Sami
Hi,
On Tue, Oct 22, 2024 at 7:39 AM Petr Pavlu wrote:
>
> On 10/8/24 20:38, Sami Tolvanen wrote:
> > +/*
> > + * KABI_USE_ARRAY(fqn)
> > + * Treat the struct fqn as a declaration, i.e. even if a definition
> > + * is available, don't expand
This does
require a cast when freeing the string, which isn't ideal, but I feel
it's overall not a terrible trade-off.
Sami
gt; Signed-off-by: Matthew Maurer
Thanks for fixing this, LGTM.
Reviewed-by: Sami Tolvanen
Sami
Hi,
On Wed, Oct 23, 2024 at 2:59 PM Petr Pavlu wrote:
>
> On 10/8/24 20:38, Sami Tolvanen wrote:
> > +gendwarfksyms := scripts/gendwarfksyms/gendwarfksyms
> > +getexportsymbols = $(NM) $(1) | sed -n 's/.* __export_symbol_\(.*\)/$(2)/p'
> > +
> &g
On Wed, Oct 23, 2024 at 2:53 PM Petr Pavlu wrote:
>
> I've noted some nits above which you might want to trivially address.
These all looked reasonable to me, I'll address them in the next version.
> Otherwise this looks ok to me, feel free to add:
>
> Reviewed-by: Petr Pavlu
Thanks!
Sami
Hi Masahiro,
On Mon, Nov 11, 2024 at 8:09 PM Masahiro Yamada wrote:
>
> On Thu, Oct 31, 2024 at 2:01 AM Sami Tolvanen wrote:
> >
> > # These mirror gensymtypes_c and co above, keep them in synch.
>
Hi,
On Mon, Nov 11, 2024 at 8:06 PM Masahiro Yamada wrote:
>
> On Thu, Oct 31, 2024 at 2:01 AM Sami Tolvanen wrote:
> >
> > To avoid duplication between host programs, move the crc32 code to a
> > shared header file.
>
>
> Only the motivation to use this lo
901 - 1000 of 1151 matches
Mail list logo
