Re: [PATCH net-next 3/3] net: ethernet: mediatek: add the dts property to set if TRGMII supported on GMAC0

2016-09-21 Thread Sean Wang
Date: Wed, 21 Sep 2016 16:17:20 +0200, Andrew Lunn wrote: >On Wed, Sep 21, 2016 at 02:16:30PM +0800, Sean Wang wrote: >> Date: Tue, 20 Sep 2016 21:37:58 +0200, Andrew Lunn wrote: >> >On Tue, Sep 20, 2016 at 03:59:20PM +0800, sean.w...@mediatek.com wrote: >> >> Fr

Re: [PATCH net-next v2 3/3] net: ethernet: mediatek: add the dts property to set if TRGMII supported on GMAC0

2016-09-22 Thread Sean Wang
Date: Thu, 22 Sep 2016 14:28:36 +0300, Sergei Shtylyov wrote: >Hello. > >On 9/22/2016 5:33 AM, sean.w...@mediatek.com wrote: > >> From: Sean Wang >> >> Add the dts property for the capability if TRGMII supported on GAMC0 >> >> Signed-off-by: Sean

Re: [PATCH net-next] Documentation: devicetree: revise ethernet device-tree binding about TRGMII

2016-09-22 Thread Sean Wang
Date: Thu, 22 Sep 2016 19:48:47 +0300, Sergei Shtylyov wrote: >On 09/22/2016 07:16 PM, sean.w...@mediatek.com wrote: > >> From: Sean Wang >> >> fix typo in mediatek-net.txt and add phy-mode "trgmii" to ethernet.txt > >These changes are unrelated to e

Re: [PATCH net-next v2 1/3] net: ethernet: mediatek: add extension of phy-mode for TRGMII

2016-09-22 Thread Sean Wang
Date: Thu, 22 Sep 2016 14:30:53 +0300, Sergei Shtylyov wrote: >>Hello. > >On 9/22/2016 5:33 AM, sean.w...@mediatek.com wrote: > >> From: Sean Wang >> >> adds PHY-mode "trgmii" as an extension for the operation mode of the >> PHY int

Re: [PATCH v3 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding

2017-08-15 Thread Sean Wang
On Tue, 2017-08-15 at 21:08 +0800, Jun Gao wrote: > From: Jun Gao > > Add MT7622 i2c binding to binding file and change the compatible > information formats of all SoCs to the same. > > Signed-off-by: Jun Gao > --- > Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++- > 1 file

Re: [PATCH v3 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622

2017-08-15 Thread Sean Wang
On Tue, 2017-08-15 at 21:08 +0800, Jun Gao wrote: > From: Jun Gao > > Add i2c compatible for MT7622. Compare to MT8173 i2c controller, > MT7622 limits message numbers to 255, and does not support 4GB > DMA mode. > > Signed-off-by: Jun Gao you seemed missing a Reviewed-by tag from Joe.C http:/

Re: [PATCH v2 0/3] add support of hardware random generator on MediaTek MT7622

2017-06-20 Thread Sean Wang
1:56:53PM +0800, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > Changes since v1: > > - update the bindings with the specific "mediatek,mt7622-rng" > > instead of the generic one as "mediatek,generic-rng" > > > > The ser

Re: [PATCH v2 0/3] add support of hardware random generator on MediaTek MT7622

2017-06-20 Thread Sean Wang
On Tue, 2017-06-20 at 16:59 +0200, Torsten Duwe wrote: > On Tue, Jun 20, 2017 at 10:21:17PM +0800, Sean Wang wrote: > > Hi Herbert, > > > > thanks for effort reviewing on those patches. > > > > By the way, also loop in Torsten > > > > Could you

Re: [PATCH v4 4/7] soc: mediatek: pwrap: update pwrap_init without slave programming

2017-10-15 Thread Sean Wang
On Fri, 2017-10-13 at 16:07 +0200, Matthias Brugger wrote: > > On 10/13/2017 11:41 AM, Sean Wang wrote: > > On Tue, 2017-10-10 at 20:00 +0200, Matthias Brugger wrote: > >> > >> On 09/21/2017 10:26 AM, sean.w...@mediatek.com wrote: > >>> From: Sean Wang

Re: [PATCH v2] soc: mediatek: place Kconfig for all SoC drivers under menu

2017-10-16 Thread Sean Wang
On Thu, 2017-10-05 at 10:52 +0200, Jean Delvare wrote: > Hi Sean, > > On Thu, 5 Oct 2017 11:17:49 +0800, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > Add cleanup for placing all Kconfig for all MediaTek SoC drivers under > > the independent menu

Re: [PATCH 2/4] rtc: mediatek: add driver for RTC on MT7622 SoC

2017-10-16 Thread Sean Wang
Hi Alexandre, Thanks for your valuable suggestions on the driver. I added comments inline and will have following-ups in the next version Sean On Thu, 2017-10-12 at 23:20 +0200, Alexandre Belloni wrote: > Hi, > > On 22/09/2017 at 11:33:15 +0800, sean.w...@mediatek.com wrote: > > diff -

Re: [PATCH 2/4] rtc: mediatek: add driver for RTC on MT7622 SoC

2017-10-16 Thread Sean Wang
On Mon, 2017-10-16 at 16:17 +0800, Sean Wang wrote: > Hi Alexandre, > > Thanks for your valuable suggestions on the driver. > > I added comments inline and will have following-ups in the next version > > Sean > > On Thu, 2017-10-12 at 23:20 +0200, Alex

Re: [PATCH v5 6/7] soc: mediatek: pwrap: add support for MT7622 SoC

2017-10-17 Thread Sean Wang
> > > Signed-off-by: Chenglin Xu > > Signed-off-by: Chen Zhong > > Signed-off-by: Sean Wang > > --- > > drivers/soc/mediatek/mtk-pmic-wrap.c | 180 > > +++ > > 1 file changed, 180 insertions(+) > > > > dif

Re: [PATCH v2 4/4] arm64: dts: mt7622: group clock DT nodes into separate DT file

2017-05-29 Thread Sean Wang
On Mon, 2017-05-29 at 17:09 +0200, Matthias Brugger wrote: > > On 29/05/17 14:56, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > For more readability and maintenance, all the clock related DT > > nodes for mt7622 SoC are grouped into a separate DT

Re: [PATCH v2 2/4] rtc: mediatek: add driver for RTC on MT7622 SoC

2017-10-18 Thread Sean Wang
On Wed, 2017-10-18 at 17:52 +0800, Yingjoe Chen wrote: > On Tue, 2017-10-17 at 17:40 +0800, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > This patch introduces the driver for the RTC on MT7622 SoC. > > > > Signed-off-by: Sean Wang > >

Re: [PATCH v2 2/4] rtc: mediatek: add driver for RTC on MT7622 SoC

2017-10-18 Thread Sean Wang
Hi, both On Wed, 2017-10-18 at 14:57 +0200, Alexandre Belloni wrote: > On 18/10/2017 at 19:12:06 +0800, Yingjoe Chen wrote: > > On Tue, 2017-10-17 at 17:40 +0800, sean.w...@mediatek.com wrote: > > > From: Sean Wang > > > > > > This patch introduces

Re: [PATCH v2 1/4] dt-bindings: rtc: mediatek: add bindings for MediaTek SoC based RTC

2017-10-18 Thread Sean Wang
On Wed, 2017-10-18 at 21:32 +0800, Yingjoe Chen wrote: > On Tue, 2017-10-17 at 17:40 +0800, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > Add device-tree binding for MediaTek SoC based RTC > > > > Cc: devicet...@vger.kernel.org > > Signed-off-b

Re: [PATCH v2 2/4] rtc: mediatek: add driver for RTC on MT7622 SoC

2017-10-19 Thread Sean Wang
On Thu, 2017-10-19 at 11:02 +0200, Alexandre Belloni wrote: > On 19/10/2017 at 10:55:49 +0800, Sean Wang wrote: > > Hi, both > > > > On Wed, 2017-10-18 at 14:57 +0200, Alexandre Belloni wrote: > > > On 18/10/2017 at 19:12:06 +0800, Yingjoe Chen wrote: > > &

Re: [PATCH v7 2/3] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-08-03 Thread Sean Wang
On Fri, 2018-08-03 at 14:51 +0200, Marcel Holtmann wrote: > Hi Sean, > > >>> + > >>> +static int mtk_hci_wmt_sync(struct hci_dev *hdev, u8 op, u8 flag, > >>> u16 plen, > >>> + const void *param) > >>> +{ > >>> + struct mtk_hci_wmt_cmd wc; >

Re: [PATCH v7 2/3] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-08-03 Thread Sean Wang
On Fri, 2018-08-03 at 19:19 +0200, Marcel Holtmann wrote: > Hi Sean, > > > + > > +static int mtk_hci_wmt_sync(struct hci_dev *hdev, u8 op, u8 flag, > > u16 plen, > > + const void *param) > > +{ > > + struct mtk_hci_wmt_cmd wc

Re: [PATCH v7 2/3] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-08-07 Thread Sean Wang
On Mon, 2018-08-06 at 17:39 +0200, Marcel Holtmann wrote: > Hi Sean, > > >>> + [ ... ] > >> this is even more hackish since the __hci_cmd_sync_ev command is really > >> meant to get a cmd status first before waiting for that event. > >> > > > > Understood. > > > > I've stopped the ha

Re: [PATCH] soc: mediatek: pwrap: use true and false for boolean values

2018-08-08 Thread Sean Wang
ers/soc/mediatek/mtk-pmic-wrap.c > @@ -1096,7 +1096,7 @@ static bool pwrap_is_pmic_cipher_ready(struct > pmic_wrapper *wrp) > ret = pwrap_read(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_RDY], >&rdata); > if (ret) > -

Re: [PATCH] pinctrl: Convert to using %pOFn instead of device_node.name

2018-08-28 Thread Sean Wang
; Cc: Stefan Agner > Cc: Pengutronix Kernel Team > Cc: Sean Wang > Cc: Matthias Brugger > Cc: Carlo Caione > Cc: Kevin Hilman > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Gregory Clement > Cc: Sebastian Hesselbarth > Cc: Jean-Christophe Plagniol-Villard > Cc: Nic

Re: [PATCH v7 2/3] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-08-08 Thread Sean Wang
On Tue, 2018-08-07 at 17:54 +0200, Marcel Holtmann wrote: > Hi Sean, > > this is even more hackish since the __hci_cmd_sync_ev command is really > meant to get a cmd status first before waiting for that event. > > >>> > >>> Understood. > >>> > >>> I've stopped the hack in v8. co

Re: [PATCH v1 1/2] Bluetooth: mediatek: Add protocol support for MediaTek MT7668U USB devices

2018-08-13 Thread Sean Wang
ansport type such > > as UART, USB and SDIO. > > Include /sys/kernel/debug/usb/device portion in the commit message. > okay, I will have an inclusion for this. > > > > Signed-off-by: Sean Wang > > --- > > drivers/bluetooth/Kconfig | 16 +++ > > dr

Re: [PATCH v1 1/2] Bluetooth: mediatek: Add protocol support for MediaTek MT7668U USB devices

2018-08-13 Thread Sean Wang
On Mon, 2018-08-13 at 18:20 +0800, Sean Wang wrote: > On Mon, 2018-08-13 at 10:00 +0200, Marcel Holtmann wrote: > > Hi Sean, > > > > > This adds the support of enabling MT7668U Bluetooth function running > > > on the top of btusb driver. The patch also adds a newl

Re: [PATCH v2 1/2] Bluetooth: mediatek: Add protocol support for MediaTek MT7668U USB devices

2018-08-21 Thread Sean Wang
Atr=01(Isoc) MxPS= 33 Ivl=1ms > > I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > > E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms > > E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms > > I: If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01

Re: [PATCH v6 3/4] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-07-30 Thread Sean Wang
lt-in > > Bluetooth device inside MT7622 SoC. > > > > Signed-off-by: Sean Wang > > --- > > drivers/bluetooth/Kconfig | 11 + > > drivers/bluetooth/Makefile| 2 + > > drivers/bluetooth/btmtkuart.c | 552 > >

Re: [PATCH v5 09/11] clk: mediatek: add new clkmux register API

2018-07-18 Thread Sean Wang
On Tue, 2018-07-17 at 16:52 +0800, Mars Cheng wrote: > From: Owen Chen > > MT6765 add "set/clr" register for each clkmux setting, and > one update register to trigger value change. It is designed > to prevent read-modify-write racing issue. The sw design > need to add a new API to handle this hw

Re: [PATCH v6 3/4] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-07-31 Thread Sean Wang
On Mon, 2018-07-30 at 20:06 +0200, Marcel Holtmann wrote: > Hi Sean, > > > All suggestions seem reasonable for me in order to make code style aligned > > with the other drivers and code better to read, > > and it looks like no any big problem, so I'll start to work on the next > > version immedi

Re: [PATCH v6 3/4] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-07-31 Thread Sean Wang
On Tue, 2018-07-31 at 12:32 +0200, Marcel Holtmann wrote: > Hi Sean, > > >>> All suggestions seem reasonable for me in order to make code style > >>> aligned with the other drivers and code better to read, > >>> and it looks like no any big problem, so I'll start to work on the next > >>> versio

Re: [PATCH v7 2/3] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-08-01 Thread Sean Wang
TP packet format. */ > > + shdr = skb_push(skb, sizeof(*shdr)); > > + p = (u8 *)shdr; > > + shdr->prefix = 0x80; > > + shdr->dlen1 = (dlen & 0xf00) >> 8; > > + shdr->type = 0; > > + shdr->dlen2 = dlen & 0xff; > > + shdr->cs =

Re: [PATCH v7 2/3] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-08-02 Thread Sean Wang
On Thu, 2018-08-02 at 09:38 +0200, Marcel Holtmann wrote: > Hi Sean, > [ ... ] > >>> + > >>> +static int mtk_hci_wmt_sync(struct hci_dev *hdev, u8 op, u8 flag, u16 > >>> plen, > >>> + const void *param) > >>> +{ > >>> + struct mtk_hci_wmt_cmd wc; > >>> + struct mtk_wmt_hdr *

Re: [PATCH v7 2/3] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-08-02 Thread Sean Wang
On Thu, 2018-08-02 at 11:45 +0200, Marcel Holtmann wrote: > Hi Sean, > > > + > > +static int mtk_hci_wmt_sync(struct hci_dev *hdev, u8 op, u8 flag, u16 > > plen, > > + const void *param) > > +{ > > + struct mtk_hci_wmt_cmd wc; > > +

Re: [PATCH v5 1/7] dt-bindings: net: bluetooth: Add mediatek-bluetooth

2018-07-14 Thread Sean Wang
On Sat, 2018-07-14 at 18:26 +0200, Marcel Holtmann wrote: > Hi Sean, > > > Add binding document for a SoC built-in device using MediaTek protocol. > > Which could be found on MT7622 SoC or other similar MediaTek SoCs. > > > > Signed-off-by: Sean Wang

Re: [PATCH v5 6/7] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-07-14 Thread Sean Wang
On Sat, 2018-07-14 at 18:32 +0200, Marcel Holtmann wrote: > Hi Sean, > > > This adds a driver to run on the top of btuart driver for the MediaTek > > serial protocol based on running H:4, which can enable the built-in > > Bluetooth device inside MT7622 SoC. > >

Re: [PATCH v5 5/7] Bluetooth: Extend btuart driver for join more vendor devices

2018-07-15 Thread Sean Wang
initializing vendor data, .shtudown, > > .recv and .send supporting SoC specific framing for that btuart can > > simply adapt to various Bluetooth uart-based devices. > > > > Signed-off-by: Sean Wang > > --- > > drivers/bluetooth/btuart.c | 73 > >

Re: [PATCH] cpufreq: mediatek: Add mediatek related projects into blacklist

2018-01-23 Thread Sean Wang
On Tue, 2018-01-23 at 09:46 +0100, Greg KH wrote: > On Tue, Jan 23, 2018 at 04:31:11PM +0800, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > commit 6066998cbd2b1012a8d5bc9a2957cfd0ad53150e upstream. > > > > commit edeec420de24 ("cpufreq: dt

Re: [PATCH] cpufreq: mediatek: Add mediatek related projects into blacklist

2018-01-23 Thread Sean Wang
On Tue, 2018-01-23 at 10:42 +0100, Greg KH wrote: > On Tue, Jan 23, 2018 at 05:38:34PM +0800, Sean Wang wrote: > > On Tue, 2018-01-23 at 09:46 +0100, Greg KH wrote: > > > On Tue, Jan 23, 2018 at 04:31:11PM +0800, sean.w...@mediatek.com wrote: > > > > From: Sean

Re: [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes

2018-01-23 Thread Sean Wang
is research. > > On Fri, Jan 12, 2018 at 4:33 AM, Sean Wang wrote: > > Currently, I'm really confused about what usage STYLE of SPDX license > > identifier I should use for each type of file. > > > > could you point me where I can find the related document d

Re: [PATCH v3 3/9] dt-bindings: arm: mediatek: update for MT7623n SoC and relevant boards

2017-05-15 Thread Sean Wang
Hi Matthias, Appreciate your help on reviewing. Add my comments inline On Mon, 2017-05-15 at 09:53 +0200, Matthias Brugger wrote: > > On 12/05/17 09:56, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > Because there are two versions of MT7623 SoC tha

Re: [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes

2018-01-11 Thread Sean Wang
no issue, Makefile, or Kconfig, definitely applied with "# " at head Sean On Fri, 2018-01-05 at 09:21 +0100, Philippe Ombredanne wrote: > Sean, > > On Fri, Jan 5, 2018 at 4:42 AM, Sean Wang wrote: > > On Thu, 2018-01-04 at 11:27 +0100, Philippe Ombredan

Re: [PATCH 2/2] soc: mediatek: add SCPSYS power domain driver for MediaTek MT7623A SoC

2018-02-01 Thread Sean Wang
On Thu, 2018-02-01 at 16:19 +0100, Matthias Brugger wrote: > > On 02/01/2018 11:12 AM, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > Add SCPSYS power domain driver for MT7623A SoC. The MT7623A's power > > domains are the subset of MT7623

Re: [PATCH v1 2/4] cpufreq: mediatek: Add mediatek related projects into blacklist

2018-01-22 Thread Sean Wang
Hi, Rafael and Viresh Can you kindly guide me how to let the patch also be applied to 4.14 and 4.15 tree? Do I need to submit another patches for them? These trees really need them. Otherwise, multi_v7_defconfig setup will cause an occasional hang or unexpected behaviors on related boards as [1]

Re: [PATCH 1/3] dt-bindings: pwrap: mediatek: add MT6351 PMIC support for MT6797

2018-01-22 Thread Sean Wang
On Tue, 2018-01-23 at 11:36 +0800, argus@mediatek.com wrote: > From: Argus Lin > > We add MT6351 PMIC support for MT6797 SoCs. > > Change-Id: I362b2305f674813ffb03ce6f54f7fc4c378b8fd2 should remove change-id, also in the other patches > Signed-off-by: Argus Lin > --- > Documentation/devi

Re: [PATCH] arm: dts: mt7623: enable all four available UARTs on bananapi-r2

2018-01-23 Thread Sean Wang
On Sat, 2017-12-23 at 23:35 +0800, Sean Wang wrote: > On Sat, 2017-12-23 at 08:52 +0100, Matthias Brugger wrote: > > > > On 12/22/2017 07:06 AM, sean.w...@mediatek.com wrote: > > > From: Sean Wang > > > > > > On bpi-r2 board, totally there're fo

Re: [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes

2018-01-04 Thread Sean Wang
On Thu, 2018-01-04 at 11:27 +0100, Philippe Ombredanne wrote: > Sean, > > On Thu, Jan 4, 2018 at 10:40 AM, wrote: > > From: Sean Wang > > > > Enable pwrap and MT6380 on mt7622-rfb1 board. Also add all mt6380 > > regulator nodes in an alone file to allow simila

Re: [RFC PATCH] drivers: soc: xilinx: Add ZynqMP PM driver

2018-01-08 Thread Sean Wang
On Mon, 2018-01-08 at 14:10 -0800, Jolly Shah wrote: > Add ZynqMP PM driver. PM driver provides power management > support for ZynqMP. > > Signed-off-by: Jolly Shah > Signed-off-by: Rajan Vaja > --- > .../bindings/soc/xilinx/xlnx,zynqmp-pm.txt | 15 ++ The patch should be split into t

Re: [PATCH] pwm: mediatek: fix up PWM4 and PWM5 malfunction on MT7623

2018-01-09 Thread Sean Wang
On Tue, 2018-01-09 at 16:32 +0100, Matthias Brugger wrote: > > On 12/25/2017 03:59 PM, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > Since the offset for both registers, PWMDWIDTH and PWMTHRES, used to > > control PWM4 or PWM5 are distinct fr

Re: [PATCH v1 05/19] arm: dts: mt7623: add BTIF, HSDMA and SPI-NOR device nodes

2018-03-12 Thread Sean Wang
On Mon, 2018-03-12 at 10:40 +0100, Matthias Brugger wrote: > > On 02/23/2018 11:16 AM, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > add BTIF, HSDMA and SPI-NOR device nodes and enable it on relevant boards > > AFAIK hsdma controller is not upstream

Re: [PATCH v1 18/19] arm: dts: mt7623: add MT7623A reference boards

2018-03-05 Thread Sean Wang
On Mon, 2018-03-05 at 08:10 -0600, Rob Herring wrote: > On Fri, Mar 2, 2018 at 8:15 PM, Sean Wang wrote: > > On Fri, 2018-03-02 at 09:45 -0600, Rob Herring wrote: > >> On Fri, Feb 23, 2018 at 06:16:38PM +0800, sean.w...@mediatek.com wrote: > >> > From: Sean W

Re: [PATCH v1 16/19] arm: dts: mt7623: fixup available memory size on bananapi-r2

2018-03-05 Thread Sean Wang
On Mon, 2018-03-05 at 08:16 -0600, Rob Herring wrote: > On Fri, Mar 2, 2018 at 5:27 PM, Sean Wang wrote: > > On Fri, 2018-03-02 at 09:42 -0600, Rob Herring wrote: > >> On Fri, Feb 23, 2018 at 06:16:36PM +0800, sean.w...@mediatek.com wrote: > >> > From: Sean Wang &

Re: [PATCH v2 1/2] dt-bindings: thermal: add binding for MT7622 SoC

2018-03-07 Thread Sean Wang
Hi, Rui just a gentle ping to the both patches Sean On Sat, 2018-02-17 at 16:49 +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > Add devicetree bindings for MediaTek MT7622 thermal controller > > Changes v1 -> v2: add tag from Rob > > Signed-off-by:

Re: [PATCH v2 1/4] dt-bindings: soc: add SCPSYS binding for MT7623 and MT7623A SoC

2018-03-07 Thread Sean Wang
Hi, Matthias just a gentle ping to the four related patches Sean On Wed, 2018-02-07 at 18:22 +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > document the binding for enabling SCPSYS on MediaTek MT7623 and MT7623A > SoC. Where MT7623 SoC has the same definition

Re: [PATCH] soc: mediatek: fix the mistaken pointer accessed when subdomains are added

2018-03-07 Thread Sean Wang
Hi, Matthis also a gentle ping for the patch Sean On Fri, 2018-02-09 at 02:07 +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > Fix the pointer to struct scp_subdomian not being moved forward > when each sub-domain is expected to be iteratively a

Re: [PATCH v4 3/5] pinctrl: add mt2712 pinctrl driver

2018-03-23 Thread Sean Wang
Hi, Zhiyong I got a warning when I applied the patch. Applying: pinctrl: add mt2712 pinctrl driver .git/rebase-apply/patch:679: new blank line at EOF. + warning: 1 line adds whitespace errors. It should probably happen at the last line in pinctrl-2712.c Apart from that Reviewed-by: Sean Wang

Re: [PATCH v1 05/16] rtc: mediatek: add MT6323 support to RTC driver

2018-03-24 Thread Sean Wang
..@mediatek.com wrote: > > From: Sean Wang > > > > Just to add MT6323 support to the existent RTC driver. > > > > Signed-off-by: Sean Wang > > --- > > drivers/rtc/rtc-mt6397.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --

Re: [PATCH v1 06/16] rtc: mediatek: remove unnecessary parentheses

2018-03-24 Thread Sean Wang
On Fri, 2018-03-23 at 11:21 +0100, Alexandre Belloni wrote: > On 23/03/2018 at 17:15:03 +0800, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > Remove unnecessary parentheses due to explicit C operator precedence. > > > > Signed-off-by: Sean Wang >

Re: [PATCH v1 11/16] rtc: mediatek: move the declaration into a globally visible header file

2018-03-24 Thread Sean Wang
On Fri, 2018-03-23 at 10:57 +0100, Alexandre Belloni wrote: > On 23/03/2018 at 17:15:08 +0800, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > This is in preparation for allowing other drivers can share the > > declaration, so move the declaration into a g

Re: [PATCH v1 06/16] rtc: mediatek: remove unnecessary parentheses

2018-03-24 Thread Sean Wang
On Sat, 2018-03-24 at 19:53 +0100, Alexandre Belloni wrote: > On 24/03/2018 at 15:14:12 +0800, Sean Wang wrote: > > On Fri, 2018-03-23 at 11:21 +0100, Alexandre Belloni wrote: > > > On 23/03/2018 at 17:15:03 +0800, sean.w...@mediatek.com wrote: > > > > From: Sean

Re: [PATCH v1 02/16] dt-bindings: rtc: mediatek: add bindings for PMIC RTC

2018-03-24 Thread Sean Wang
On Fri, 2018-03-23 at 11:15 +0100, Alexandre Belloni wrote: > On 23/03/2018 at 10:41:18 +0100, Alexandre Belloni wrote: > > Hi, > > > > On 23/03/2018 at 17:14:59 +0800, sean.w...@mediatek.com wrote: > > > From: Sean Wang > > > > > > Add

Re: [PATCH v1 11/16] rtc: mediatek: move the declaration into a globally visible header file

2018-03-24 Thread Sean Wang
On Sat, 2018-03-24 at 17:00 -0300, Fabio Estevam wrote: > On Fri, Mar 23, 2018 at 6:15 AM, wrote: > > > --- /dev/null > > +++ b/include/linux/rtc/mt6397.h > > @@ -0,0 +1,72 @@ > > + > > +// SPDX-License-Identifier: GPL-2.0 > > According to Documentation/process/license-rules.rst the SPDX notati

Re: [PATCH v1 08/16] rtc: mediatek: remove unnecessary irq_dispose_mapping

2018-03-25 Thread Sean Wang
On Fri, 2018-03-23 at 11:38 +0100, Alexandre Belloni wrote: > On 23/03/2018 at 17:15:05 +0800, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > It's unnecessary doing irq_dispose_mapping as a reverse operation for > > platform_get_irq. > > >

Re: [PATCH v1 09/16] rtc: mediatek: convert to use device managed functions

2018-03-25 Thread Sean Wang
On Fri, 2018-03-23 at 11:50 +0100, Alexandre Belloni wrote: > On 23/03/2018 at 17:15:06 +0800, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > Use device managed operation to simplify error handling, reduce source > > code size, and reduce the likelyhood of b

Re: [PATCH v1 01/16] dt-bindings: power: reset: mediatek: add bindings for power device

2018-03-26 Thread Sean Wang
On Mon, 2018-03-26 at 17:24 -0500, Rob Herring wrote: > On Fri, Mar 23, 2018 at 05:14:58PM +0800, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > Add device-tree binding for the power device responsible for shutdown a > > remote SoC, which is a tiny circui

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

2018-03-21 Thread Sean Wang
e. but for homekey it cannot be found on the board and thus I cannot have more tests more about it. Tested-by: Sean Wang Sean On Thu, 2018-03-22 at 10:03 +0800, Sean Wang (王志亘) wrote: > > > -Original Message- > > From: Linux-mediatek [mailto:linux-mediatek-boun..

Re: [PATCH v4 4/5] pintcrl: support bias-disable of generic and special pins simultaneously

2018-03-23 Thread Sean Wang
, > + * the parameter should be "MTK_PUPD_SET_R1R0_00". > + */ > + r1r0 = enable ? arg : MTK_PUPD_SET_R1R0_00; > ret = pctl->devdata->spec_pull_set(mtk_get_regmap(pctl, pin), > - pin, pctl->devdata->port_align, isup, arg); > + pin, pctl->devdata->port_align, isup, r1r0); > if (!ret) > return 0; > } Reviewed-by: Sean Wang

Re: [PATCH v3 0/4] PINCTRL: Mediatek pinctrl driver for mt2712

2018-03-07 Thread Sean Wang
Hi, Zhiyong you should checkpatch every patch before sending them out because I saw tons of check messages like below result for scanning v3 3/4 CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #152: FILE: drivers/pinctrl/mediatek/pinctrl-mt2712.c:85: +static int mt2712_spec_

Re: [PATCH] pinctrl: mediatek: mark dummy helpers as 'static inline'

2018-09-26 Thread Sean Wang
trl can fit") > Signed-off-by: Arnd Bergmann Thank for the fixes for that I miss to mark the two functions as 'static inline'. The other functions in the same header file seem fine. Acked-by: Sean Wang > --- > drivers/pinctrl/mediatek/mtk-eint.h | 4 ++-- > 1

Re: [PATCH 2/2] mmc: mediatek: add bus_clk control

2018-09-28 Thread Sean Wang
Hi, On Fri, 2018-09-28 at 19:40 +0800, Chaotian Jing wrote: > when gate MSDC0_HCLK, access register will hang, even the MSDC driver > will never accessing register after HCLK was gated, but for safety, need > gate the bus_clk(which used to access register) too. > > Signed-off-by: Chaotian Jing >

Re: [PATCH 1/2] mmc: dt-bindings: add "bus-clk" for MT2712

2018-09-28 Thread Sean Wang
On Fri, 2018-09-28 at 19:40 +0800, Chaotian Jing wrote: > On MT2712 MSDC0/3, HCLK/bus-clk need gate/ungate together, > or will hang when access MSDC register. > > Signed-off-by: Chaotian Jing > --- > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 1 + > 1 file changed, 1 insertion(+) > > di

Re: [v5, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

2018-11-22 Thread Sean Wang
< ... > > > > + /* select phy interface in top control domain */ > > > + switch (plat->phy_mode) { > > > + case PHY_INTERFACE_MODE_MII: > > > + intf_val |= PHY_INTF_MII_GMII; > > > + break; > > > + case PHY_INTERFACE_MODE_RMII: > > > +

Re: [PATCH 1/2] gpio: mt7621: report failure of devm_kasprintf()

2018-11-26 Thread Sean Wang
case should be fine here. > > Signed-off-by: Nicholas Mc Guire Acked-by: Sean Wang > Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621") > --- > > V2: The dev_err() for the unlikely case of the devm_kasprintf() > failing was removed on request from

Re: [PATCH 2/2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack

2018-11-26 Thread Sean Wang
Nicholas Mc Guire 於 2018年11月21日 週三 上午10:13寫道: > > The error cases of mediatek_gpio_bank_probe() would go unnoticed (except > for the dev_err() messages). The probe function should return an error > if one of the banks failed to initialize properly. > > Signed-off-by: Nicholas Mc Guire > Fixes: 4b

Re: [PATCH 2/2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack

2018-11-27 Thread Sean Wang
> > On Mon, Nov 26, 2018 at 11:49:26PM -0800, Sean Wang wrote: > > Nicholas Mc Guire ??? 2018???11???21??? ?? > > ??10:13? > > > > > > The error cases of mediatek_gpio_bank_probe() would go unnoticed (except > > > for the dev_err() m

Re: [PATCH v2 01/11] clk: mediatek: add new clkmux register API

2018-11-27 Thread Sean Wang
> > From: Owen Chen > > On both MT8183 & MT6765, there add "set/clr" register for > each clkmux setting, and one update register to trigger value change. > It is designed to prevent read-modify-write racing issue. > The sw design need to add a new API to handle this hw change with > a new mtk_clk

Re: [PATCH v2 02/11] clk: mediatek: add new member to mtk_pll_data

2018-11-27 Thread Sean Wang
rm-dependent. The patch title seems much general. It should be more specific to reflect the content, such as add configurable parameters pcwibits and fmin to mtk_pll. Apart from that: Acked-by: Sean Wang > > Signed-off-by: Owen Chen > Signed-off-by: Weiyi Lu > --- > drivers/cl

Re: [PATCH v2 03/11] clk: mediatek: Disable tuner_en before change PLL rate

2018-11-27 Thread Sean Wang
Weiyi Lu 於 2018年11月26日 週一 下午7:45寫道: > > From: Owen Chen > > PLLs with tuner_en bit, such as APLL1, need to disable > tuner_en before apply new frequency settings, or the new frequency > settings (pcw) will not be applied. > The tuner_en bit will be disabled during changing PLL rate > and be resto

Re: [PATCH V2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack

2018-11-27 Thread Sean Wang
> > Signed-off-by: Nicholas Mc Guire Acked-by: Sean Wang > Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621") > --- > > V2: A logic error spoted by Sean Wang the > success case is 0 and thus returning early should be on on > ret!=0 and not

Re: [PATCH] pinctrl: mediatek: Convert to using %pOFn instead of device_node.name

2018-11-19 Thread Sean Wang
On Mon, Nov 19, 2018 at 11:07 AM Rob Herring wrote: > > On Fri, Nov 16, 2018 at 5:46 PM Sean Wang wrote: > > > > On Fri, Nov 16, 2018 at 2:06 PM Rob Herring wrote: > > > > > > In preparation to remove the node name pointer from struct device_node, > &g

Re: [PATCH v2 03/11] clk: mediatek: Disable tuner_en before change PLL rate

2018-11-27 Thread Sean Wang
> > On Wed, Nov 28, 2018 at 4:37 AM Sean Wang wrote: > > > > Weiyi Lu 於 2018年11月26日 週一 下午7:45寫道: > > > > > > From: Owen Chen > > > > > > PLLs with tuner_en bit, such as APLL1, need to disable > > > tuner_en before apply new frequen

Re: [PATCH v1 1/2] pinctrl: mediatek: add pinctrl support for MT7629 SoC

2018-11-15 Thread Sean Wang
nces between each new hardware at once. Acked-by: Sean Wang > --- > Changes since v1: > -add a new function for wifi. > -drop useless 'ext' groups and its groups. > --- > drivers/pinctrl/mediatek/Kconfig | 6 + > drivers/pinctrl/mediatek/Makefile

Re: [PATCH v1 2/2] dt-bindings: pinctrl: update bindings for MT7629 SoC

2018-11-15 Thread Sean Wang
On Sun, Nov 11, 2018 at 5:45 PM Ryder Lee wrote: > > This updates bindings for MT7629 pinctrl driver. > > Signed-off-by: Ryder Lee Reviewed-by: Sean Wang > --- > Changes since v1: > -add new function for wifi. > -add more descriptions. > --- > .../devicetree/b

Re: [resend PATCH 2/3] pwm: mediatek: add pwm support for MT7629 SoC

2018-11-15 Thread Sean Wang
On Mon, Nov 12, 2018 at 6:09 PM Ryder Lee wrote: > > This adds pwm controller support for MT7629 SoC. > > Signed-off-by: Ryder Lee > --- > drivers/pwm/pwm-mediatek.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c > index 9400

Re: [PATCH] pinctrl: mediatek: Convert to using %pOFn instead of device_node.name

2018-11-16 Thread Sean Wang
On Fri, Nov 16, 2018 at 2:06 PM Rob Herring wrote: > > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Sean Wang > Cc: Linus Walleij > Cc: Matthias Brugger > Cc: linux-media...@

Re: [PATCH 1/5] dt-bindings: i2c: Add Mediatek MT7629 i2c binding

2018-12-04 Thread Sean Wang
於 2018年12月3日 週一 上午5:34寫道: > > From: qii wang > > Add MT7629 i2c binding to i2c-mt2712.txt and there is no need to where's i2c-mt2712.txt mentioned here? > modify i2c driver. suggest not to mention driver in any dt-binding, dt-binding self should be os-agnostic > > Signed-off-by: qii wang > -

Re: [PATCH 2/5] i2c: mediatek: remove useless code and replace definitions

2018-12-04 Thread Sean Wang
於 2018年12月3日 週一 上午5:40寫道: > > From: qii wang > > Completion_done is useless when we don't use its return value, > so we remove it. Different speeds have been defined by macros, > so we use macros definitions. > > Signed-off-by: qii wang Reviewed-by: Sean Wang &g

Re: [PATCH 3/5] i2c: mediatek: Add offsets array for new i2c registers

2018-12-04 Thread Sean Wang
於 2018年12月3日 週一 上午5:35寫道: > > From: qii wang > > New i2c registers would have different offsets, so we use different > offsets array to distinguish different i2c registers version. > > Signed-off-by: qii wang They are almost 1 to 1 function translation being taken here,

Re: [PATCH 4/5] dt-bindings: i2c: Add Mediatek MT8183 i2c binding

2018-12-04 Thread Sean Wang
On Mon, Dec 3, 2018 at 5:34 AM wrote: > > From: qii wang > > Add MT8183 i2c binding to binding file. Compare to 2712 i2c > controller, MT8183 has different registers, offsets, clock, > and multi-user function. > > Signed-off-by: qii wang > --- > Documentation/devicetree/bindings/i2c/i2c-mtk.txt

Re: [PATCH v2 2/4] dmaengine: mtk_uart_dma: add Mediatek uart DMA support

2018-12-05 Thread Sean Wang
. On Wed, Dec 5, 2018 at 1:31 AM Long Cheng wrote: > > In DMA engine framework, add 8250 mtk dma to support it. > > Signed-off-by: Long Cheng > --- > drivers/dma/mediatek/8250_mtk_dma.c | 894 > +++ > drivers/dma/mediatek/Kconfig| 11 + > drivers/dma/m

Re: [PATCH v2 2/4] dmaengine: mtk_uart_dma: add Mediatek uart DMA support

2018-12-06 Thread Sean Wang
On Thu, Dec 6, 2018 at 1:55 AM Long Cheng wrote: > > On Wed, 2018-12-05 at 13:07 -0800, Sean Wang wrote: > > . > > On Wed, Dec 5, 2018 at 1:31 AM Long Cheng wrote: > > > > > > In DMA engine framework, add 8250 mtk dma to support it. > > > > > &g

Re: [PATCH v3 1/4] dt-bindings: pinctrl: Add devicetree bindings for MT6797 SoC Pinctrl

2018-12-07 Thread Sean Wang
Hi Olof, I'm a guy from MediaTek. Thanks for your input and we will get these bad things to be better. On Fri, Dec 7, 2018 at 10:42 AM Olof Johansson wrote: > > On Wed, Dec 5, 2018 at 4:01 AM Linus Walleij wrote: > > > > On Mon, Dec 3, 2018 at 2:08 AM Matthias Brugger > > wrote: > > > On 15/1

Re: [PATCH 5/5] i2c: mediatek: Add i2c compatible for MediaTek MT8183

2018-12-03 Thread Sean Wang
於 2018年12月3日 週一 上午5:34寫道: > > From: qii wang > > Add i2c compatible for MT8183. Compare to 2712 i2c controller, MT8183 has > different registers, offsets, clock, and multi-user function. > > Signed-off-by: qii wang > --- > drivers/i2c/busses/i2c-mt65xx.c | 136 > ++

Re: [PATCH 1/2] arm: dts: mt7623: cleanup MT7623N NAND dts file

2018-07-09 Thread Sean Wang
dingly. > Acked-by: Sean Wang > Cc: John Crispin > Cc: Sean Wang > Signed-off-by: Ryder Lee > --- > arch/arm/boot/dts/Makefile | 1 - > arch/arm/boot/dts/mt7623n-rfb-nand.dts | 73 - > arch/arm/boot/dts/mt7623n-rfb.dtsi | 8

Re: [PATCH 2/2] dt-bindings: arm: mediatek: cleanup MT7623N reference boards

2018-07-09 Thread Sean Wang
On Tue, 2018-07-10 at 13:09 +0800, Ryder Lee wrote: > Cleanup binding document to get rid of unsupported reference boards > for MT7623N. > > Cc: John Crispin > Cc: Sean Wang > Signed-off-by: Ryder Lee > --- > Documentation/devicetree/bindings/arm/mediatek.txt | 3

Re: [PATCH v2 1/6] dt-bindings: gpu: mali-utgard: add mediatek,mt7623-mali compatible

2018-06-27 Thread Sean Wang
On Mon, 2018-06-25 at 17:14 +0200, Matthias Brugger wrote: > > On 27/04/18 10:14, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > The MediaTek MT7623 SoC contains a Mali-450, so add a compatible for it > > and define its own vendor-specific propert

Re: [PATCH v4 6/7] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-06-27 Thread Sean Wang
On Wed, 2018-06-27 at 19:59 +0300, Andy Shevchenko wrote: > On Wed, Jun 27, 2018 at 8:43 AM, wrote: > > From: Sean Wang > > > > > +config BT_HCIBTUART_MTK > > + tristate "MediaTek HCI UART driver" > > + depends on BT_HCIBTUART > &g

Re: [PATCH v4 6/7] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-06-27 Thread Sean Wang
On Wed, 2018-06-27 at 20:04 +0300, Andy Shevchenko wrote: > On Wed, Jun 27, 2018 at 7:59 PM, Andy Shevchenko > wrote: > > On Wed, Jun 27, 2018 at 8:43 AM, wrote: > >> From: Sean Wang > >> > > > >> +config BT_HCIBTUART_MTK > >> + trist

Re: [PATCH v4 6/7] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-06-29 Thread Sean Wang
On Thu, 2018-06-28 at 07:19 +0200, Johan Hovold wrote: > On Thu, Jun 28, 2018 at 11:06:13AM +0800, Sean Wang wrote: > > On Wed, 2018-06-27 at 20:04 +0300, Andy Shevchenko wrote: > > > On Wed, Jun 27, 2018 at 7:59 PM, Andy Shevchenko > > > wrote: > > > > O

Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

2018-05-24 Thread Sean Wang
On Thu, 2018-05-24 at 09:47 +0200, Marcel Holtmann wrote: > Hi Sean, > > > [ ... ] [ ... ] > > I post it as plain text as below > > > > > > Bluetooth monitor ver 5.37 > > = Note: Linux version 4.16.0-rc1+ (aarch64) > > 0.641494 > > = Note: Bluetooth subs

  1   2   3   4   >