{bus,self}-max-{power,curret} dts properties
- Replace legacy GPIO API usage with descriptor-based one
Changelog v2:
- Split first patch into smaller ones
- Fix invalid BOOST_14 register definition
- Combine copyrights adding patch into the last one
Serge Semin (9):
usb: usb251xb: Add USB2517i
be checked whether
it doesn't get out of available ports.
Signed-off-by: Serge Semin
---
drivers/usb/misc/usb251xb.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
index 96a8c20ac..5cb0e5570
USB2517 supports two LED modes: USB mode (default) and speed indication
mode. The last one can be switched on by corresponding dts property.
Since USB251xb hubs doesn't support LEDs settings, we need to ignore
this setting.
Signed-off-by: Serge Semin
---
Documentation/devicetree/bindings/usb
This parameters may be varied in accordance with hardware specifics.
So lets add the corresponding settings to the usb251x driver dts
specification.
Signed-off-by: Serge Semin
---
Documentation/devicetree/bindings/usb/usb251xb.txt | 6 ++
drivers/usb/misc/usb251xb.c
The methods like of_property_read_u32 utilizing the specified
pointer permit only the pointer to a preallocated u32 storage as the
third argument. As a result the driver crashes on NULL pointer
dereference in case if "oc-delay-us" or "power-on-time-ms" declared
in dts file.
including the logical value inversion. Secondly,
by requesting the reset GPIO descriptor the driver prevent the other
applications from changing its value. And last but not least the
legacy GPIO interface should be avoided in the new code due to it
obsolescence.
Signed-off-by: Serge Semin
in the driver, but still can be helpful
in future, when necessity of corresponding dts setting arises.
Signed-off-by: Serge Semin
---
drivers/usb/misc/usb251xb.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
index 44fa7d084
-by: Serge Semin
---
drivers/usb/misc/usb251xb.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
index 3de0de93b..44fa7d084 100644
--- a/drivers/usb/misc/usb251xb.c
+++ b/drivers/usb/misc/usb251xb.c
@@ -94,8
on i2c-bus.
Signed-off-by: Serge Semin
---
Documentation/devicetree/bindings/usb/usb251xb.txt | 3 ++-
drivers/usb/misc/usb251xb.c | 21 -
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb
USB2517 got three additionl downstream ports, which can
as well be mapped to another logical ports. USB2551xb driver
currently doesn't fully support such setting configuration
from dts file. This patch doesn't change this, but adds
usb2517 spcific ports default liner mapping.
Signed-off-by: Serge
to be changed in the further patches.
Signed-off-by: Serge Semin
---
arch/mips/include/asm/bootinfo.h | 1 +
arch/mips/kernel/prom.c | 8 ++--
arch/mips/kernel/setup.c | 8
3 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/arch/mips/include/asm/bootinfo.h b/arch
d replace
%pK with %px there (requested by Matt Redfearn)
- Drop relocatable fixup from reservation_init (patch from Matt Redfearn)
- Move __maybe_unused change from patch 7 to patch 8 (requested by Marcin
Nowakowski)
- Add tested platforms to the cover letter
Signed-off-by: Serge Semin
Tested-b
regions initialization the only thing
left is to set the upper allocation limit to be up to the max low
memory PFN, so the memblock API can be fully used from now.
Signed-off-by: Serge Semin
---
arch/mips/kernel/setup.c | 86 +++-
1 file changed, 11
The current MIPS code makes sure the kernel code/data/init
sections are in the maps, but BSS should also be there.
Signed-off-by: Serge Semin
---
arch/mips/kernel/setup.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
index
There is no reserve_bootmem() method in the nobootmem interface,
so we need to replace it with memblock-specific one.
Signed-off-by: Serge Semin
---
arch/mips/kernel/setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
since I couldn't find a place where prom_meminit() called
and kernel memory isn't reserved. It must have been untested since the
time the arch/mips/mips-boards/generic code was in the kernel.
Signed-off-by: Serge Semin
---
arch/mips/sgi-ip27/ip27-memory.c | 9 ++---
1 file changed, 2
Memblock allocator can be successfully used from now for early
memory management
Signed-off-by: Serge Semin
---
arch/mips/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 350a990fc719..434f756e03e9 100644
--- a/arch/mips
-by: Serge Semin
---
arch/mips/loongson64/loongson-3/numa.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/arch/mips/loongson64/loongson-3/numa.c
b/arch/mips/loongson64/loongson-3/numa.c
index f17ef520799a..2f1ebf496c17 100644
--- a/arch/mips/loongson64
From: Matt Redfearn
A recent change ("MIPS: memblock: Discard bootmem initialization")
removed the reservation of all memory below the kernel's _end symbol in
bootmem. This makes the call to free_bootmem unnecessary, since the
memory region is no longer marked reserved.
Additionally, ("MIPS:
Low memory can be tested at this point, since all the
reservations have just been finished without much of
additional allocations.
Signed-off-by: Serge Semin
---
arch/mips/kernel/setup.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
It is useful to have the kernel virtual memory layout printed
at boot time so to have the full information about the booted
kernel. In some cases it might be unsafe to have virtual
addresses freely visible in logs, so the %pK format is used if
one want to hide them.
Signed-off-by: Serge Semin
When all the main reservations are done the memblock regions
can be dynamically resized. Additionally it would be useful to have
memblock regions dumped on debug at this point.
Signed-off-by: Serge Semin
---
arch/mips/kernel/setup.c | 4
1 file changed, 4 insertions(+)
diff --git a/arch
CMA reserves it areas in the memblock allocator. Since we aren't
using bootmem anymore, the reservations copying should be discarded.
Signed-off-by: Serge Semin
---
arch/mips/kernel/setup.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/arch/mips/kernel/setup.c b/arch
If sparsemem is activated all sections with present pages must
be accordingly marked after memblock is fully initialized.
Signed-off-by: Serge Semin
---
arch/mips/kernel/setup.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
index
the function description/code).
Signed-off-by: Serge Semin
---
arch/mips/kernel/setup.c | 96 +++-
1 file changed, 54 insertions(+), 42 deletions(-)
diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
index cf3674977170..72853e94c2c7 100644
Kdump/crashkernel memory regions should be reserved in the
memblock allocator so they wouldn't be occupied by any further
allocations.
Signed-off-by: Serge Semin
---
arch/mips/kernel/setup.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/arch/mips/kernel/setup.c b
-off-by: Serge Semin
---
Changelog v1:
- Add Multi-port API support
- Ping-pong now works like cyclic ping around all the peers
Changelog v2:
- Remove driver Author/Description/Version macros
drivers/ntb/test/ntb_pingpong.c | 450 +---
1 file changed, 286
If some of the variables like LOC/REM or LOCAL_*/REMOTE_* got
whitespaces, the script may fail with syntax error.
Signed-off-by: Serge Semin
Acked-by: Logan Gunthorpe
Fixes: a9c59ef77458 ("ntb_test: Add a selftest script for the NTB subsystem")
---
tools/testing/selftests/ntb/ntb_te
in "linux/bitops.h" to perform
the bit-set-shift operations, so it's recommended to have them used
for proper bit setting.
Signed-off-by: Serge Semin
Reviewed-by: Logan Gunthorpe
---
include/linux/ntb.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/nt
ntb_perf driver has been also updated so to have the multi-port
interface support. User now must specify what peer port is going
to be used to perform the test.
Signed-off-by: Serge Semin
---
tools/testing/selftests/ntb/ntb_test.sh | 13 +++--
1 file changed, 7 insertions(+), 6
the link state. Such behaviour
should be reflected in the test code.
Signed-off-by: Serge Semin
---
tools/testing/selftests/ntb/ntb_test.sh | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/tools/testing/selftests/ntb/ntb_test.sh
b/tools/testing
DB interface of ntb_tool driver hasn't been changed much, but
db_valid_mask DebugFS file has still been added to new ntb_tool
driver. In this case it's much better to test all valid DB bits
instead of using the predefined mask, which may be incorrect in
general.
Signed-off-by: Serge Semin
previous Intel/AMD and new IDT-like devices.
Signed-off-by: Serge Semin
---
tools/testing/selftests/ntb/ntb_test.sh | 89 +
1 file changed, 68 insertions(+), 21 deletions(-)
diff --git a/tools/testing/selftests/ntb/ntb_test.sh
b/tools/testing/selftests/ntb/ntb_test.sh
Since Switchtec patch there has been a new topology added to
the NTB API. It's called NTB_TOPO_SWITCH and dedicated for
in general multi-port PCIe switch chips. Even though topo field
isn't used within the IDT driver much, lets set it for the sake
of unification.
Signed-off-by: Serge Semin
Scratchpad NTB API has been changed so has the ntb_tool driver.
Outbound Scratchpad DebugFS files have been moved to peer specific
directories. Each scratchpad is now available via separate file.
The test code has been accordingly altered.
Signed-off-by: Serge Semin
---
tools/testing/selftests
Messages NTB API is now available. ntb_tool driver has been altered
to perform messages send and receive operations. The test of messages
read/write to/from peer device has been added to the script.
Signed-off-by: Serge Semin
---
tools/testing/selftests/ntb/ntb_test.sh | 37
.
Signed-off-by: Serge Semin
---
Changelog v1:
- Alter interface in compliance with multi-port API
- Create Scratchpads and Message compliant NTB link init process
- Simplify memcpy and DMA-based tests process
- Limit DebugFS access methods to prevent the driver failure
Changelog v2:
- Remove driver
to that ntb_device_register() method shouldn't clear
the passed ntb_dev structure, since it dma_mask is initialized
by hardware drivers.
Signed-off-by: Serge Semin
---
drivers/ntb/hw/amd/ntb_hw_amd.c | 4
drivers/ntb/hw/idt/ntb_hw_idt.c | 8 +++-
drivers/ntb/hw/intel/ntb_hw_intel.c | 4
to determine the local and peer ports
as well as their indexes.
Signed-off-by: Serge Semin
---
tools/testing/selftests/ntb/ntb_test.sh | 52 +
1 file changed, 52 insertions(+)
diff --git a/tools/testing/selftests/ntb/ntb_test.sh
b/tools/testing/selftests/ntb
. This patchset is intended to fix the
issue, by amending the NTB test drivers and script so they would be
fully compatible with multi-port NTB API.
Additionally I found a few NTB subsystem issues while developing the
submitted patches. So they are also fixed in this patchset.
Serge Semin (15):
NTB
-by: Serge Semin
---
Changelog v1:
- Alter interface in compliance with multi-port API
- Move Message/MW/Port/Link settings to a specific directory
Changelog v2:
- Remove driver Author/Description/License macros
- Return error if ntb_mw_get_align called while link is down
- Add db_valid_mask
so the developers won't
be able to compile their code without being informed by the compiler.
Signed-off-by: Serge Semin
---
drivers/ntb/hw/idt/ntb_hw_idt.c | 27 ---
include/linux/ntb.h | 34 --
2 files changed, 28 insertions
On Sun, Dec 03, 2017 at 09:54:58PM -0700, Logan Gunthorpe
wrote:
>
>
> On 03/12/17 12:17 PM, Serge Semin wrote:
> > The multi-port NTB API was introduced in kernel 4.13 as well as the
> > first driver for the true multi-port devices of IDT PCIe-switches
> > series.
There is a common methods signature form used over all the NTB API
like functions naming scheme, arguments names and order, etc.
Recently added NTB messaging API IO callbacks were named a bit
different so should be renamed to be in compliance with the rest
of the API.
Signed-off-by: Serge Semin
-off-by: Serge Semin
---
Changelog v1:
- Add Multi-port API support
- Ping-pong now works like cyclic ping around all the peers
Changelog v2:
- Remove driver Author/Description/Version macros
drivers/ntb/test/ntb_pingpong.c | 450 +---
1 file changed, 286
-by: Serge Semin
---
Changelog v1:
- Alter interface in compliance with multi-port API
- Move Message/MW/Port/Link settings to a specific directory
Changelog v2:
- Remove driver Author/Description/License macros
- Return error if ntb_mw_get_align called while link is down
- Add db_valid_mask
.
Signed-off-by: Serge Semin
---
Changelog v1:
- Alter interface in compliance with multi-port API
- Create Scratchpads and Message compliant NTB link init process
- Simplify memcpy and DMA-based tests process
- Limit DebugFS access methods to prevent the driver failure
Changelog v2:
- Remove driver
in "linux/bitops.h" to perform
the bit-set-shift operations, so it's recommended to have them used
for proper bit setting.
Signed-off-by: Serge Semin
---
include/linux/ntb.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/ntb.h b/include/linux/ntb.h
to that ntb_device_register() method shouldn't clear
the passed ntb_dev structure, since it dma_mask is initialized
by hardware drivers.
Signed-off-by: Serge Semin
---
drivers/ntb/hw/amd/ntb_hw_amd.c | 4
drivers/ntb/hw/idt/ntb_hw_idt.c | 8 +++-
drivers/ntb/hw/intel/ntb_hw_intel.c | 4
drivers
Since Switchtec patch there has been a new topology added to
the NTB API. It's called NTB_TOPO_SWITCH and dedicated for
PCIe switch chips. Even though topo field isn't used within the
IDT driver much, lets set it for the sake of unification.
Signed-off-by: Serge Semin
Acked-by: Serge Semin
the local and peer ports as well as their indexes.
Signed-off-by: Serge Semin
---
tools/testing/selftests/ntb/ntb_test.sh | 52 +
1 file changed, 52 insertions(+)
diff --git a/tools/testing/selftests/ntb/ntb_test.sh
b/tools/testing/selftests/ntb/ntb_test.sh
index
DB interface of ntb_tool driver hasn't been changed much, but
db_valid_mask DebugFS file has still been added. In this case
it's much better to test all valid DB bits instead of using
the predefined mask, which may be incorrect in general.
Signed-off-by: Serge Semin
---
tools/testing/selftests
Messages NTB API is now available. ntb_tool driver has been altered
to perform messages send and receive operation. The test of messages
read/write to/from peer device has been added to the script.
Signed-off-by: Serge Semin
---
tools/testing/selftests/ntb/ntb_test.sh | 37
ntb_perf driver has been also updated so to have the multi-port
interface support. User now must specify what peer port is going
to be used to perform the test.
Signed-off-by: Serge Semin
---
tools/testing/selftests/ntb/ntb_test.sh | 13 +++--
1 file changed, 7 insertions(+), 6
previous Intel/AMD and new IDT-like devices.
Signed-off-by: Serge Semin
---
tools/testing/selftests/ntb/ntb_test.sh | 89 +
1 file changed, 68 insertions(+), 21 deletions(-)
diff --git a/tools/testing/selftests/ntb/ntb_test.sh
b/tools/testing/selftests/ntb/ntb_test.sh
Scratchpad NTB API has changed so has the ntb_tool driver. Outbound
Scratchpad DebugFS files have been moved to peer specific directories.
Each scratchpad is now available via separate file. The test code
has been accordingly altered.
Signed-off-by: Serge Semin
---
tools/testing/selftests/ntb
the link state. Such behaviour
should be reflected in the test code.
Signed-off-by: Serge Semin
---
tools/testing/selftests/ntb/ntb_test.sh | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/tools/testing/selftests/ntb/ntb_test.sh
b/tools/testing
If some of variables like LOC/REM or LOCAL_*/REMOTE_* got
whitespaces, the script may fail with syntax error.
Signed-off-by: Serge Semin
---
tools/testing/selftests/ntb/ntb_test.sh | 62 -
1 file changed, 31 insertions(+), 31 deletions(-)
diff --git a/tools
re maintainers. Sorry for not mentioning it in the
cover letter.
-Sergey
>
> On 30/11/17 02:42 PM, Serge Semin wrote:
> >If some of variables like LOC/REM or LOCAL_*/REMOTE_* got
> >whitespaces, the script may fail with syntax error.
> >
> >Signed-off-by: Serge Semin
>
On Thu, Nov 30, 2017 at 03:06:15PM -0700, Logan Gunthorpe
wrote:
>
>
> On 30/11/17 02:41 PM, Serge Semin wrote:
> >Since Switchtec patch there has been a new topology added to
> >the NTB API. It's called NTB_TOPO_SWITCH and dedicated for
> >PCIe switch chips. Even t
> >
> > > On 2020/12/7 2:50, Marc Zyngier wrote:
> > > > On 2020-12-06 15:02, Linus Walleij wrote:
> > > >> On Sat, Dec 5, 2020 at 11:15 PM Serge Semin
> > > >> wrote:
> > > >>
> > > >>> Hmm, that sound
On Fri, Oct 02, 2020 at 01:19:29PM +0300, Andy Shevchenko wrote:
> On Fri, Oct 02, 2020 at 01:28:10AM +0300, Serge Semin wrote:
> > Currently DWC SSI core is supported by means of setting up the
> > core-specific update_cr0() callback. It isn't suitable for multiple
> >
On Fri, Oct 02, 2020 at 01:22:46PM +0300, Andy Shevchenko wrote:
> On Fri, Oct 02, 2020 at 01:28:11AM +0300, Serge Semin wrote:
> > Indeed there is no point in detecting the SPI peripheral device parameters
> > and initializing the CR0 register fields each time an SPI transfer
On Fri, Oct 02, 2020 at 09:26:07PM +0300, Andy Shevchenko wrote:
> On Fri, Oct 2, 2020 at 8:18 PM Serge Semin
> wrote:
> >
> > On Fri, Oct 02, 2020 at 01:19:29PM +0300, Andy Shevchenko wrote:
> > > On Fri, Oct 02, 2020 at 01:28:10AM +0300, Serge Semin wrote:
>
On Fri, Oct 02, 2020 at 09:24:55PM +0300, Andy Shevchenko wrote:
> On Fri, Oct 2, 2020 at 8:47 PM Serge Semin
> wrote:
> > On Fri, Oct 02, 2020 at 01:22:46PM +0300, Andy Shevchenko wrote:
> > > On Fri, Oct 02, 2020 at 01:28:11AM +0300, Serge Semin wrote:
>
> > &g
On Fri, Oct 02, 2020 at 10:46:09PM +0300, Serge Semin wrote:
> On Fri, Oct 02, 2020 at 09:26:07PM +0300, Andy Shevchenko wrote:
> > On Fri, Oct 2, 2020 at 8:18 PM Serge Semin
> > wrote:
> > >
> > > On Fri, Oct 02, 2020 at 01:19:29PM +0300, Andy Shevchenko wrote:
&
On Fri, Oct 02, 2020 at 11:08:29PM +0300, Serge Semin wrote:
> On Fri, Oct 02, 2020 at 10:46:09PM +0300, Serge Semin wrote:
> > On Fri, Oct 02, 2020 at 09:26:07PM +0300, Andy Shevchenko wrote:
> > > On Fri, Oct 2, 2020 at 8:18 PM Serge Semin
> > > wrote:
> > >
Add myself as a maintainer of the Synopsis DesignWare APB SSI driver.
Suggested-by: Andy Shevchenko
Signed-off-by: Serge Semin
Link:
https://lore.kernel.org/linux-spi/20201001222829.15977-1-sergey.se...@baikalelectronics.ru/
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff
Hello,
On Sun, Sep 27, 2020 at 05:01:52PM +0200, Hans de Goede wrote:
> Hi,
>
> On 9/23/20 6:19 PM, Serge Semin wrote:
> > Hans has discovered that there is a potential deadlock between the ref
> > clock change notifier and the port suspension procedures {see the l
Thomas,
Any comment on the series? The changes aren't that comprehensive, so it would
be great to merge it in before the 5.10 merge window is opened.
-Sergey
On Sun, Sep 20, 2020 at 02:00:08PM +0300, Serge Semin wrote:
> It has been discovered that on our MIPS P5600-based CPU the IO access
On Tue, Sep 29, 2020 at 02:11:53PM +0100, Mark Brown wrote:
> On Sun, Sep 20, 2020 at 02:28:46PM +0300, Serge Semin wrote:
> > Simplify the dw_spi_add_host() method a bit by replacing the set_cs
> > callback overwrite procedure with direct setting the callback if a custom
>
On Tue, Sep 29, 2020 at 02:12:25PM +0100, Mark Brown wrote:
> On Sun, Sep 20, 2020 at 02:28:47PM +0300, Serge Semin wrote:
> > Since n_bytes field of the DW SPI private data is also utilized by the
> > IRQ handler, we need to make sure it' initialization is done before the
>
On Tue, Sep 29, 2020 at 02:28:11PM +0100, Mark Brown wrote:
> On Sun, Sep 20, 2020 at 02:28:48PM +0300, Serge Semin wrote:
> > There is no point in having the commit 19b61392c5a8 ("spi: spi-dw: Add
> > lock protect dw_spi rx/tx to prevent concurrent calls") applied. T
On Tue, Sep 29, 2020 at 02:52:33PM +0100, Mark Brown wrote:
> On Sun, Sep 20, 2020 at 02:28:55PM +0300, Serge Semin wrote:
>
> > - /*
> > -* SPI mode (SCPOL|SCPH)
> > -* CTRLR0[ 8] Serial Clock Phase
> > -* CTRLR0[ 9] Serial Clock Polarity
> >
Hi Mark
On Tue, Sep 29, 2020 at 03:43:51PM +0100, Mark Brown wrote:
> On Sun, Sep 20, 2020 at 02:28:44PM +0300, Serge Semin wrote:
>
> > First two patches are just cleanups to simplify the DW APB SSI device
> > initialization a bit. We suggest to discard the IRQ threshold m
On Wed, Sep 30, 2020 at 12:04:04PM +0100, Mark Brown wrote:
> On Wed, Sep 30, 2020 at 01:43:03AM +0300, Serge Semin wrote:
> > On Tue, Sep 29, 2020 at 03:43:51PM +0100, Mark Brown wrote:
>
> > > This is a *huge* patch series which is a bit unweildy to review
> > >
On Wed, Sep 30, 2020 at 12:15:32PM +0200, Thomas Bogendoerfer wrote:
> On Wed, Sep 30, 2020 at 12:12:32AM +0300, Serge Semin wrote:
> > Thomas,
> > Any comment on the series? The changes aren't that comprehensive, so it
> > would
> > be great to merge it in before the
Mark,
A concrete question is below the main text.)
On Wed, Sep 30, 2020 at 12:55:55AM +0300, Serge Semin wrote:
> On Tue, Sep 29, 2020 at 02:11:53PM +0100, Mark Brown wrote:
> > On Sun, Sep 20, 2020 at 02:28:46PM +0300, Serge Semin wrote:
> > > Simplify the dw_spi_add_h
Mark,
A concrete question is below of my previous comment.
On Wed, Sep 30, 2020 at 01:17:37AM +0300, Serge Semin wrote:
> On Tue, Sep 29, 2020 at 02:52:33PM +0100, Mark Brown wrote:
> > On Sun, Sep 20, 2020 at 02:28:55PM +0300, Serge Semin wrote:
> >
> > > - /*
> &g
On Wed, Sep 30, 2020 at 04:01:17PM +0100, Mark Brown wrote:
> On Wed, Sep 30, 2020 at 05:57:59PM +0300, Serge Semin wrote:
> > On Wed, Sep 30, 2020 at 12:55:55AM +0300, Serge Semin wrote:
>
> > > + if (dws->set_cs)
> > > + master->set_cs = dws->set_
On Wed, Sep 30, 2020 at 04:41:49PM +0100, Mark Brown wrote:
> On Wed, Sep 30, 2020 at 06:03:12PM +0300, Serge Semin wrote:
> > On Wed, Sep 30, 2020 at 01:17:37AM +0300, Serge Semin wrote:
>
> > > > > - /*
> > > > > - * SPI mode (SCPOL|SCPH)
driver, but by the glue layer drivers too. This will be required
in a coming further commit.
Signed-off-by: Serge Semin
---
drivers/spi/spi-dw-core.c | 29 +
drivers/spi/spi-dw.h | 10 ++
2 files changed, 27 insertions(+), 12 deletions(-)
diff --git
and there in
the tx_max(), rx_max(), dw_writer() and dw_reader() methods. Such
modification will not only give us the more optimized IO procedures, but
will make the data IO methods much more readable than before.
Signed-off-by: Serge Semin
---
drivers/spi/spi-dw-core.c | 37
to have a generic function name not related to CR0.
Leave the too long line with the chip->clk_div setting as is for now,
since it's going to be changed later anyway.
Signed-off-by: Serge Semin
---
drivers/spi/spi-dw-core.c | 28 ++--
1 file changed, 14 insertions(+),
controller with fixed automatic CS toggle functionality.
Co-developed-by: Ramil Zaripov
Signed-off-by: Ramil Zaripov
Signed-off-by: Serge Semin
---
drivers/spi/Kconfig | 1 +
drivers/spi/spi-dw-core.c | 300 ++
drivers/spi/spi-dw.h | 13 ++
3 files
-off-by: Serge Semin
Reviewed-by: Rob Herring
---
.../bindings/spi/snps,dw-apb-ssi.yaml | 33 +--
1 file changed, 31 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
b/Documentation/devicetree/bindings/spi/snps,dw-apb
st in case...
Signed-off-by: Serge Semin
---
drivers/spi/spi-dw-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c
index db3fec4195f7..58a7c7465c61 100644
--- a/drivers/spi/spi-dw-core.c
+++ b/drivers/spi/spi
controller setup to make the dw_spi_update_cr0() method looking coherent.
Signed-off-by: Serge Semin
---
drivers/spi/spi-dw-core.c | 80 ++-
drivers/spi/spi-dw-mmio.c | 20 +-
drivers/spi/spi-dw.h | 9 +
3 files changed, 40 insertions(+), 69
Rx sample delay can be SPI device specific, and should be synchronously
initialized with the rest of the communication and peripheral device
related controller setups. So let's move the Rx-sample delay setup into
the DW APB SSI configuration update method.
Signed-off-by: Serge Semin
---
drivers
returned from the dma_setup
callback to be erroneous as it's supposed to be in the kernel.
Signed-off-by: Serge Semin
---
drivers/spi/spi-dw-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c
index 58a7c7465c61
ATCH 00/04] spi: dw: Clear IRQ status on DW SPI controller reset
[PATCH 00/03] spi: dw: Initialize n_bytes before the memory barrier
[PATCH 00/01] spi: dw: Discard IRQ threshold macro
Signed-off-by: Serge Semin
Cc: Alexey Malahov
Cc: Ramil Zaripov
Cc: Pavel Parkhomenko
Cc: Andy Shevchenko
of the DW SPI core module.
Co-developed-by: Ramil Zaripov
Signed-off-by: Ramil Zaripov
Signed-off-by: Serge Semin
---
drivers/spi/Kconfig | 28
drivers/spi/Makefile | 1 +
drivers/spi/spi-dw-bt1.c | 339 +++
3 files changed, 368 insertions
Simplify the dw_spi_add_host() method a bit by replacing the currently
implemented default set_cs callback setting up and later having it
overwritten by a custom function with direct if-else-based callback
assignment.
Signed-off-by: Serge Semin
---
Changelog v2:
- Replace the ternary operator
The parameter will be needed for another wait-done method being added in
the framework of the SPI memory operation modification in a further
commit.
Signed-off-by: Serge Semin
---
drivers/spi/spi-dw-dma.c | 5 ++---
drivers/spi/spi-dw.h | 2 ++
2 files changed, 4 insertions(+), 3 deletions
that. We'll also need a way to explicitly set and clear the
corresponding CS bit at a certain moment of the operation. Let's alter
the set_cs function then to also de-activate the CS, when it's required.
Signed-off-by: Serge Semin
---
drivers/spi/spi-dw-core.c | 2 +-
1 file changed, 1 insertion
one.
Signed-off-by: Serge Semin
---
drivers/spi/spi-dw-core.c | 41 ++-
1 file changed, 23 insertions(+), 18 deletions(-)
diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c
index 74e8f0da2883..db3fec4195f7 100644
--- a/drivers/spi/spi-dw-core.c
t iteration. Finally the errors
status is checked on each iteration.
Signed-off-by: Serge Semin
---
drivers/spi/spi-dw-core.c | 40 ++-
1 file changed, 39 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c
index cc217b
applicable for the memory
operations, since the standard SPI core interface is implemented with an
assumption that there is no problem with the automatic CS toggling.
Signed-off-by: Serge Semin
---
drivers/spi/spi-dw-core.c | 4 +++-
drivers/spi/spi-dw.h | 1 +
2 files changed, 4 insertions(+), 1
of the new method to detect the errors in the IRQ- and DMA-based SPI
transfer execution procedures.
Signed-off-by: Serge Semin
---
drivers/spi/spi-dw-core.c | 43 +++
drivers/spi/spi-dw-dma.c | 11 ++
drivers/spi/spi-dw.h | 1 +
3 files changed, 37
of setting it up.
By doing so we'll finally make the SPI device chip_data serving as it's
supposed to - to preserve the SPI device specific DW SPI configuration.
See spi-fsl-dspi.c, spi-pl022.c, spi-pxa2xx.c drivers for example of the
way the chip data is utilized.
Signed-off-by: Serge Semin
401 - 500 of 2111 matches
Mail list logo
