_pcie_bus_priv *priv)
>
> static int qtnf_pcie_init_memory(struct qtnf_pcie_bus_priv *priv)
> {
> - int ret;
> + int ret = -ENOMEM;
>
> priv->sysctl_bar = qtnf_map_bar(priv, QTN_SYSCTL_BAR);
> if (IS_ERR_OR_NULL(priv->sysctl_bar)) {
>
> Not related to your patch but qtnf_map_bar() should be changed not to
> return NULL. When functions return both NULL and error pointers the
> NULL is supposed to be a special type of success return. Here it is
> just a fail return where we forgot to set the error code to
> ERR_PTR(-ENOMEM).
Th
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly.
>
> Cc: Igor Mitsyanko
> Cc: Avinash Patil
> Cc: Sergey Matyukevich
&
Hello Gregory,
MacchiatoBin board fails to boot v4.20-rc1 kernel built using arm64
defconfig. According to quick bisection of the board dts file, the
root cause is in dts patch enabling CPU deep idle states:
see 8ed46368776b3bc. Is there any pending fix other than reverting
deep idle state support
On Fri, Nov 09, 2018 at 03:11:12PM +0300, Sergey Matyukevich wrote:
> Hello Gregory,
>
> MacchiatoBin board fails to boot v4.20-rc1 kernel built using arm64
> defconfig. According to quick bisection of the board dts file, the
> root cause is in dts patch enabling CPU deep idl
Hi Cody,
> drivers/net/wireless/Kconfig | 7 +
> drivers/net/wireless/Makefile| 2 +
> drivers/net/wireless/virt_wifi.c | 618 +++
> 3 files changed, 627 insertions(+)
> create mode 100644 drivers/net/wireless/virt_wifi.c
I did a quick check of your patch
> > Hi Cody,
> >
> >> drivers/net/wireless/Kconfig | 7 +
> >> drivers/net/wireless/Makefile| 2 +
> >> drivers/net/wireless/virt_wifi.c | 618 +++
> >> 3 files changed, 627 insertions(+)
> >> create mode 100644 drivers/net/wireless/virt_wifi.c
> >
> > I di
gt; Signed-off-by: Gustavo A. R. Silva
> ---
> drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 4
> 1 file changed, 4 insertions(+)
Thanks for the patch!
Reviewed-by: Sergey Matyukevich
Regards,
Sergey
+static netdev_tx_t
> qtnf_netdev_hard_start_xmit(struct sk_buff *skb, struct net_device *ndev)
> {
> struct qtnf_vif *vif;
Previous ACK from Igor slipped through the cracks due to
outlook/exchange issues. So here is another one.
Reviewed-by: Sergey Matyukevich
Thanks for the fix !
Regards,
Sergey
, 21 deletions(-)
Thanks for the patch.
Reviewed-by: Sergey Matyukevich
Regards,
Sergey
pdev);
> - if (!wiphy)
> + if (!wiphy) {
> + if (pdev)
> + platform_device_unregister(pdev);
> return ERR_PTR(-ENOMEM);
> + }
>
> mac = wiphy_priv(wiphy);
Reviewed-by: Sergey Matyukevich
Thanks,
Sergey
On Tue, Apr 28, 2020 at 09:01:30AM +0200, Johannes Berg wrote:
> On Tue, 2020-04-28 at 12:29 +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the mac80211-next tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > Caused by commit
> >
> > 6cd536fe62
On Tue, Apr 28, 2020 at 09:24:16AM +0200, Johannes Berg wrote:
> On Tue, 2020-04-28 at 10:25 +0300, Sergey Matyukevich wrote:
> > On Tue, Apr 28, 2020 at 09:01:30AM +0200, Johannes Berg wrote:
> > > On Tue, 2020-04-28 at 12:29 +1000, Stephen Rothwell wrote:
> > > >
> > Looks good. But I have a couple of questions:
> >
> > - why cleanup vif->mgmt_frame_reg in wilc_mac_open ?
>
> Otherwise wilc_update_mgmt_frame_registrations() will think there are no
> changes whatsoever, and do nothing.
>
> > - previously wilc_wfi_p2p_rx was called only for PROBE_REQ and A
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Igor Mitsyanko
> Cc: Avinash Patil
> Cc: Sergey Matyukevich
> Cc: Kalle
we can
> now use the new struct_size() helper:
>
> instance = kzalloc(struct_size(instance, reg_rules, count), GFP_KERNEL);
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva
Hi Gustavo,
Thanks for the patch !
Reviewed-by: Sergey Matyukevich
Regards,
Sergey
;rd = kzalloc(struct_size(hwinfo->rd, reg_rules,
> +resp->n_reg_rules), GFP_KERNEL);
>
> if (!hwinfo->rd)
> return -ENOMEM;
Thanks!
Reviewed-by: Sergey Matyukevich
Regards,
Sergey
...
> Signed-off-by: Gustavo A. R. Silva
> ---
> drivers/net/wireless/quantenna/qtnfmac/bus.h |2
> drivers/net/wireless/quantenna/qtnfmac/qlink.h | 54
> -
> 2 files changed, 28 insertions(+), 28 deletions(-)
Reviewed-by: Sergey Matyukevich
Regards,
Sergey
v.wiphy);
> + struct qtnf_wmac *mac = wiphy_priv(vif->wdev.wiphy);
Thanks !
Acked-by: Sergey Matyukevich
{
> +static const struct pci_device_id qtnf_pcie_devid_table[] = {
> {
> PCIE_VENDOR_ID_QUANTENNA, PCIE_DEVICE_ID_QTN_PEARL,
> PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> --
> 2.7.4
Thanks !
Reviewed-by: Sergey Matyukevich
form anyway.
> In fact, the whole qtnf_pcie_init_dma_mask() function is nothing more
> than a rather long-winded implementation of dma_set_mask_and_coherent(),
> so let's just use that directly.
>
> Signed-off-by: Robin Murphy
Nice, thanks you !
Acked-by: Sergey Matyukevich
21 matches
Mail list logo
