Re: [3.9-rc1] Bug in bootup code or debug code?

2013-03-20 Thread Shaun Ruffell
On Tue, Mar 19, 2013 at 10:12:39PM +, Yu, Fenghua wrote: > > From: Tetsuo Handa [mailto:penguin-ker...@i-love.sakura.ne.jp] > > H. Peter Anvin wrote: > > > This is a CONFIG_DEBUG_VIRTUAL configuration, isn't it? > > > > Yes. CONFIG_MICROCODE_INTEL_EARLY=y && CONFIG_64BIT=n && > > CONFIG_DEBUG_

Re: [3.9-rc1] Bug in bootup code or debug code?

2013-03-20 Thread Shaun Ruffell
On Wed, Mar 20, 2013 at 04:32:14PM +, Yu, Fenghua wrote: > > From: Shaun Ruffell [mailto:sruff...@digium.com] > > On Tue, Mar 19, 2013 at 10:12:39PM +, Yu, Fenghua wrote: > > > > From: Tetsuo Handa [mailto:penguin-ker...@i-love.sakura.ne.jp] > > > > H. P

[PATCH v2 1/3] edac_mc: fix kfree calls in the error path

2012-09-14 Thread Shaun Ruffell
From: Fengguang Wu From: Fengguang Wu We need to free up memory in this order: free csrows[i]->channels[j] free csrows[i]->channels free csrows[i] free csrows Signed-off-by: Fengguang Wu --- drivers/edac/edac_mc.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) d

[PATCH v2 2/3] edac: edac_mc_free() cannot assume mem_ctl_info is registered in sysfs.

2012-09-14 Thread Shaun Ruffell
reporting device not found:vendor 8086 device 0x2541 (broken BIOS?) EDAC DEBUG: edac_mc_free: Floppy drive(s): fd0 is 1.44M EDAC DEBUG: edac_unregister_sysfs: Unregistering device (null) Signed-off-by: Shaun Ruffell --- drivers/edac/edac_mc.c | 59

[PATCH v2 0/3] Fix edac_mc crash in e7xxx_edac error path.

2012-09-14 Thread Shaun Ruffell
free+0x29/0x2f [edac_core] [ 36.703479] [] e7xxx_probe1+0x268/0x311 [e7xxx_edac] [ 36.703479] [] ? __pci_enable_device_flags+0x8f/0xd3 [ 36.703479] [] e7xxx_init_one+0x56/0x61 [e7xxx_edac] [ 36.703479] [] local_pci_probe+0x13/0x15 ... Fengguang Wu (1): edac_mc: fix kfree calls in t

[PATCH v2 3/3] edac: edac_mc no longer deals with kobjects directly.

2012-09-14 Thread Shaun Ruffell
There are no more embedded kobjects in struct mem_ctl_info. Remove a header and a comment that does not reflect the code anymore. Signed-off-by: Shaun Ruffell --- drivers/edac/edac_mc.c | 7 --- include/linux/edac.h | 1 - 2 files changed, 8 deletions(-) diff --git a/drivers/edac

Re: [PATCH v2 1/3] edac_mc: fix kfree calls in the error path

2012-09-14 Thread Shaun Ruffell
On Fri, Sep 14, 2012 at 12:58:16PM -0500, Shaun Ruffell wrote: > From: Fengguang Wu > > From: Fengguang Wu Darn it. If you push this through, mind fixing the above? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord

Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-14 Thread Shaun Ruffell
On Thu, Sep 13, 2012 at 06:55:29PM +0800, Shaohui Xie wrote: > Error handle in case of DDR ECC off is wrong, sysfs entries have not been > created, so edac_mc_free which frees a mci instance should not be called. > Also, free mci's memory in this case. Jus FYI: I ran into the same error in edac_mc

Re: Linux 3.6-rc6

2012-09-21 Thread Shaun Ruffell
On Sun, Sep 16, 2012 at 03:59:09PM -0700, Linus Torvalds wrote: > > Please do test things out, I'd really like to be able to do the final > 3.6 soonish.. Linus, Just a heads up in case you are about to tag v3.6. v3.6-rc6 still has a regression with edac_mc_alloc()/edac_mc_free() introduced in c

[PATCH] edac_mc: edac_mc_free() cannot assume mem_ctl_info is registered in sysfs.

2012-09-22 Thread Shaun Ruffell
local_pci_probe+0x13/0x15 ... Cc: Mauro Carvalho Chehab Cc: Shaohui Xie Signed-off-by: Shaun Ruffell --- Hi Linus, I did not bother to resend the third patch [1] since it's not really *necessary* to boot my system. Fengguang's and this is sufficient. [1] http://marc.info/?l=linux-ker

Re: [PATCH 0/3] Fix edac_mc crash in e7xxx_edac error path.

2012-09-08 Thread Shaun Ruffell
Just a friendly reminder that I'm still seeing this NULL pointer dereference on boot with 3.6-rc4. On Sat, Aug 18, 2012 at 11:11:21PM -0500, Shaun Ruffell wrote: > With kernel version 3.6-rc2 on a Dell Poweredge 2600 I experienced a NULL > pointer dereference that did not occur wit

Re: [PATCH] x86/perf_events: build fix

2012-12-27 Thread Shaun Ruffell
[forgot to copy lkml] Hi Jan, On Fri, Nov 23, 2012 at 04:28:32PM +, Jan Beulich wrote: > At least some older gcc versions dislike mixing constant and non-const > data in the same section ("... causes a section type confict"). Newer > gcc simply emits the section as writable (which isn't what

Re: Minimum toolchain requirements?

2012-12-27 Thread Shaun Ruffell
Hi Rob, On Fri, Dec 14, 2012 at 04:25:10PM -0600, Rob Landley wrote: > Although the README and Documentation/Changes both say the kernel > builds with gcc 3.2, this is no loner the case. In reality the new > 3.7 kernel no longer builds under unpatched gcc 4.2.1 (the last > GPLv2 release). > > Bui

Re: Incorrect accounting of irq into the running task

2013-01-05 Thread Shaun Ruffell
On Fri, Jan 04, 2013 at 10:22:12AM -0800, Sadasivan Shaiju wrote: > Hi Venkatesh, > > I have applied the following patches for the incorrect accounting > of irq into the running task . > > > [PATCH] x86: Add IRQ_TIME_ACCOUNTING > [e82b8e4ea4f3dffe6e7939f90e78da675fcc450e] > [PATCH] sched: Add I

Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-18 Thread Shaun Ruffell
On Mon, Sep 17, 2012 at 10:32:59AM +, Xie Shaohui-B21989 wrote: > > -Original Message- > > From: Shaun Ruffell [mailto:sruff...@digium.com] > > Sent: Saturday, September 15, 2012 2:22 AM > > To: Xie Shaohui-B21989 > > Cc: linux-e...@vger.kernel.org; linuxp

Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-18 Thread Shaun Ruffell
On Wed, Sep 19, 2012 at 03:43:35AM +, Xie Shaohui-B21989 wrote: > > On Mon, Sep 17, 2012 at 10:32:59AM +, Xie Shaohui-B21989 wrote: > > > > > > BTW: seems you are using a different kernel tree with mine. > > > > On the chance that I missing something important: Why do you say > > I was run

Re: BUG: unable to handle kernel paging request at 00010016

2012-08-18 Thread Shaun Ruffell
Adding linux-net to the CC list. On Fri, Aug 17, 2012 at 11:57:56PM +0100, Dave Haywood wrote: > [1.] One line summary of the problem: > BUG: unable to handle kernel paging request at 00010016 > > System boots then crashes a 5-10 or so seconds after getting to the > login prompt > Bo

[PATCH 1/3] edac_mc: fix kfree calls in the error path

2012-08-18 Thread Shaun Ruffell
From: Fengguang Wu We need to free up memory in this order: free csrows[i]->channels[j] free csrows[i]->channels free csrows[i] free csrows Signed-off-by: Fengguang Wu --- drivers/edac/edac_mc.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/e

[PATCH 2/3] edac: edac_mc_free() cannot assume mem_ctl_info is registered in sysfs.

2012-08-18 Thread Shaun Ruffell
reporting device not found:vendor 8086 device 0x2541 (broken BIOS?) EDAC DEBUG: edac_mc_free: Floppy drive(s): fd0 is 1.44M EDAC DEBUG: edac_unregister_sysfs: Unregistering device (null) Signed-off-by: Shaun Ruffell --- drivers/edac/edac_mc.c | 59

[PATCH 0/3] Fix edac_mc crash in e7xxx_edac error path.

2012-08-18 Thread Shaun Ruffell
ght I would send along what I had if only to motivate any discussion. I also have resent Fengguang Wu's patch in this series since I found that it was required as well. Shaun Ruffell (2): edac: Remove invalid kfree in error path of edac_mc_allocate(). edac: edac_mc_free() cannot assume mem_c

[PATCH 3/3] edac: edac_mc no longer deals with kobjects directly.

2012-08-18 Thread Shaun Ruffell
There are no more embedded kobjects in struct mem_ctl_info. Remove a header and a comment that does not reflect the code anymore. Signed-off-by: Shaun Ruffell --- drivers/edac/edac_mc.c | 7 --- include/linux/edac.h | 1 - 2 files changed, 8 deletions(-) diff --git a/drivers/edac

Re: BUG: unable to handle kernel paging request at 00010016

2012-08-19 Thread Shaun Ruffell
[ Fixing netdev cc to use proper dadress... ] On Sun, Aug 19, 2012 at 12:21:17PM +0400, Artem Savkov wrote: > On Sat, Aug 18, 2012 at 11:25:43PM -0500, Shaun Ruffell wrote: > > Adding linux-net to the CC list. > > > > On Fri, Aug 17, 2012 at 11:57:56PM +0100, Dave Haywood

Re: [PATCH] x86/perf_events: Fix "section type conflict" build error.

2013-01-20 Thread Shaun Ruffell
Bump. Still an issue with v3.8-rc4. Am I mistaken in thinking this patch is trivial and obviously correct? Thanks, Shaun On Wed, Jan 09, 2013 at 03:59:42PM -0600, Shaun Ruffell wrote: > From: Jan Beulich > > This patch fixes a build regression first introduced in 3.7 with > (e09df

[PATCH] x86/perf_events: Fix "section type conflict" build error.

2013-01-09 Thread Shaun Ruffell
o the commit message.] Signed-off-by: Shaun Ruffell --- Hans, Thomas, Any chance of picking this up for 3.8? This doesn't seem too controversial since it only makes sure that data in the __initconst section is const. Rob Landley also reported this to the list here: https://lkml.org/lkml

[PATCH] x86/perf_events: Fix "section type conflict" build error.

2013-01-09 Thread Shaun Ruffell
etails to the commit message.] Signed-off-by: Shaun Ruffell --- [I had the wrong stable email address when I previously sent this. Sorry about the extra noise.] Hans, Thomas, Any chance of picking this up for 3.8? This doesn't seem too controversial since it only makes sure that data in t

Regression in 3.14: BUG in get_next_timer_interrupt()

2014-04-04 Thread Shaun Ruffell
I just updated one of my development machines to 3.14 from 3.12.5 and hit a BUG in get_next_timer_interrupt(). In order to get to this point, I had to apply commit (30f2555 "ipv6: some ipv6 statistic counters failed to disable bh") from the current master on top of 3.14 to get around a lockdep spl

Re: [PATCH 11/15] purgatory: Core purgatory functionality

2014-08-11 Thread Shaun Ruffell
FYI, it looks like the following patch (committed in 8fc5b4d4121c95482b2583) adds a new requirement to use at least gcc 4.4 to build the kernel? On Thu, Jun 26, 2014 at 04:33:40PM -0400, Vivek Goyal wrote: > Create a stand alone relocatable object purgatory which runs between two > kernels. This n

Re: [PATCH 1/2] kexec: Create a new config option CONFIG_KEXEC_FILE for new syscall

2014-08-14 Thread Shaun Ruffell
On Wed, Aug 13, 2014 at 10:42:59AM -0400, Vivek Goyal wrote: > Currently new system call kexec_file_load() and all the associated code > compiles if CONFIG_KEXEC=y. But new syscall also compiles purgatory code > which currently uses gcc option -mcmodel=large. This option seems to be > available onl

Re: [igb] AER timeout - resend.

2015-07-01 Thread Shaun Ruffell
On Mon, Feb 23, 2015 at 03:56:56PM +0100, Ian Kumlien wrote: > Sending this to both netdev and kernel since i don't know if it's the > driver or the pcie AER that does something odd - the machine was > stable before 3.19 and PCIE AER. > > Everything started out like i first sent to linux nics () i

Re: [igb] AER timeout - resend.

2015-07-01 Thread Shaun Ruffell
On Wed, Jul 01, 2015 at 11:18:36PM +0200, Ian Kumlien wrote: > It was actually fixed with a bios upgrade from Super Micro (in this case) > so I'd investigate that first... =) Hmm...interesting. Thanks for the reply! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH v2 2/6] modpost: fix broken sym->namespace for external module builds

2019-10-03 Thread Shaun Ruffell
> basename = mod->name; > > - if (exp->namespace) { > + if (exp->namespace && exp->namespace[0]) { > add_namespace(&mod->required_namespaces, > exp->namespace); > This looks good to me and is better than what I had originally proposed. I confirmed that I can still build an external module without any warnings. (But I did have to convince myself that it was OK to store empty namespace strings in the symbol structure and that check_exports() would cover it sufficiently) If you would like, feel free to add my Reviewed-by: Shaun Ruffell or Tested-by: Shaun Ruffell

Re: [PATCH] modpost: Copy namespace string into 'struct symbol'

2019-09-30 Thread Shaun Ruffell
On Fri, Sep 27, 2019 at 09:03:46AM +0100, Matthias Maennich wrote: > On Thu, Sep 26, 2019 at 05:24:46PM -0500, Shaun Ruffell wrote: > > When building an out-of-tree module I was receiving many warnings from > > modpost like: > > > > WARNING: module dahdi_vpmadt032_l

Re: [PATCH] modpost: Copy namespace string into 'struct symbol'

2019-10-01 Thread Shaun Ruffell
On Tue, Oct 01, 2019 at 05:19:23PM +0100, Matthias Maennich wrote: > On Mon, Sep 30, 2019 at 04:20:46PM -0500, Shaun Ruffell wrote: > > On Fri, Sep 27, 2019 at 09:03:46AM +0100, Matthias Maennich wrote: > > > On Thu, Sep 26, 2019 at 05:24:46PM -0500, Shaun Ruffell wrote: > &

[PATCH] modpost: Copy namespace string into 'struct symbol'

2019-09-26 Thread Shaun Ruffell
ijn Coenen Cc: Joel Fernandes (Google) Cc: Greg Kroah-Hartman Cc: Matthias Maennich Cc: Jessica Yu Signed-off-by: Shaun Ruffell --- Hi, I didn't test that this change works with the namespaces, or investigate why read_dump() is only called first while building out-of-tree modules, but it do