Re: [PATCH v2] regulator: pfuze100: add pfuze100 regulator driver

2013-07-14 Thread Shawn Guo
The patch looks good. Comments below are mostly random coding style nitpicks. On Fri, Jul 12, 2013 at 12:54:15PM +0800, Robin Gong wrote: Add pfuze100 regulator driver. Signed-off-by: Robin Gong b38...@freescale.com --- .../devicetree/bindings/regulator/pfuze100.txt | 113 +

Re: [PATCH v2] regulator: pfuze100: add pfuze100 regulator driver

2013-07-15 Thread Shawn Guo
On Mon, Jul 15, 2013 at 02:40:39PM +0800, Robin Gong wrote: +static const struct of_device_id pfuze_dt_ids[] = { + { .compatible = fsl,pfuze100, .data = (void *)PFUZE_ID_PFUZE100}, You do not use .data in the driver at all, and can just drop it. good catch. .driver_data of

Re: [RFC PATCH 07/11] cpufreq: cpufreq-cpu0: remove device tree parsing for cpu nodes

2013-07-15 Thread Shawn Guo
all DT parsing and uses cpu-of_node instead. Signed-off-by: Sudeep KarkadaNagesha sudeep.karkadanage...@arm.com Acked-by: Shawn Guo shawn@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 1/5] ARM: dts: imx23-evk: enable USB PHY and controller

2013-07-15 Thread Shawn Guo
and controller need to be enabled for it to be usable. Signed-off-by: Otavio Salvador ota...@ossystems.com.br --- You should have Cc'd Shawn Guo on this series. Oh; thanks for fix my mistake. I am new to kernel development :-) I'm on copy of patches 1, 3 and 4. 2 and 5 are missing

Re: [RFC PATCH 06/11] cpufreq: imx6q-cpufreq: remove device tree parsing for cpu nodes

2013-07-15 Thread Shawn Guo
all DT parsing and uses cpu-of_node instead. Signed-off-by: Sudeep KarkadaNagesha sudeep.karkadanage...@arm.com Acked-by: Shawn Guo shawn@linaro.org --- arch/arm/mach-imx/mach-imx6q.c | 3 +-- drivers/cpufreq/imx6q-cpufreq.c | 4 +--- 2 files changed, 2 insertions(+), 5 deletions

Re: [PATCH 07/13] cpufreq: imx6q: call CPUFREQ_POSTCHANGE notfier in error cases

2013-06-19 Thread Shawn Guo
= freqs.old to guarantee that sequence of calling notifiers is complete. This patch fixes it. This also moves PRECHANGE notifier down so that we call it just before starting frequency transition. Cc: Shawn Guo shawn@linaro.org Acked-by: Shawn Guo shawn@linaro.org Signed-off

Re: [PATCH] ASoC: imx-sgtl5000: fix error return code in imx_sgtl5000_probe()

2013-07-16 Thread Shawn Guo
-by: Shawn Guo shawn@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 1/4] ARM: dts: imx23-evk: enable USB PHY and controller

2013-07-16 Thread Shawn Guo
On Tue, Jul 16, 2013 at 09:56:12AM -0300, Otavio Salvador wrote: The i.MX23EVK board provides a USB port so the USB PHY and controller need to be enabled for it to be usable. Signed-off-by: Otavio Salvador ota...@ossystems.com.br There is a typo i.XM23 in commit log of patch #2 and #3. I

Re: [PATCH v4 12/19] cpufreq: cpufreq-cpu0: remove device tree parsing for cpu nodes

2013-09-09 Thread Shawn Guo
Hi Sudeep, On Mon, Sep 09, 2013 at 10:24:39AM +0100, Sudeep KarkadaNagesha wrote: Hi Shawn, Can you please clarify ? The fix would be as below but I would like to know if setting cpu_dev to get_cpu_device(0) instead of pdev-dev has any impact on other parts of code using cpu_dev ? I'm

Re: [PATCH v4 12/19] cpufreq: cpufreq-cpu0: remove device tree parsing for cpu nodes

2013-09-09 Thread Shawn Guo
On Mon, Sep 09, 2013 at 04:24:18PM +0100, Sudeep KarkadaNagesha wrote: Hi Shawn, Ok. But I am bit suspicious about devm_clk_get(cpu_dev, NULL). I don't understand completely as how the clock are registered(whether with dev_id or with connection_id). As the connection_id of devm_clk_get()

Re: [PATCH][RESEND] ARM: imx: remove IRQF_DISABLED

2013-09-10 Thread Shawn Guo
On Tue, Sep 10, 2013 at 08:58:38AM +0200, Sascha Hauer wrote: On Wed, Sep 04, 2013 at 07:04:39AM +0200, Michael Opdenacker wrote: This flag is a NOOP since 2.6.35 and can be removed. This is an update for 3.11 of a patch already sent for 3.10 Signed-off-by: Michael Opdenacker

Re: [PATCH v4 12/19] cpufreq: cpufreq-cpu0: remove device tree parsing for cpu nodes

2013-09-10 Thread Shawn Guo
On Tue, Sep 10, 2013 at 11:56:17AM +0100, Sudeep KarkadaNagesha wrote: So we only need to change all clkdev registration to use cpu0 as dev_id intstead of cpufreq-cpu0.0, something like below. And for imx, it should work even without the changes, because we have device tree lookup ready

Re: [PATCH] dts: wandboard: Add support for SDIO bcm4329

2013-07-30 Thread Shawn Guo
On Sun, Jul 28, 2013 at 12:00:20PM +1200, Tony Prisk wrote: The wandboard has a Broadcom 4329 WiFi connected via SDIO. This patch sets the required pins to enable the wifi module. Signed-off-by: Tony Prisk li...@prisktech.co.nz Applied, thanks. -- To unsubscribe from this list: send the

Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-05 Thread Shawn Guo
On Tue, Nov 05, 2013 at 10:08:06AM +0530, Viresh Kumar wrote: Adding shawn in cc list.. On 5 November 2013 08:40, rjying rjy...@gmail.com wrote: From: Rongjun Ying rongjun.y...@csr.com Sometime the regulator can't supply appropriate voltages for requestion of cpu. All voltage

Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-05 Thread Shawn Guo
On Wed, Nov 06, 2013 at 02:15:07AM +, Rongjun Ying wrote: If omit voltage-tolerance, sometimes also can't get appropriate voltages. For example: If the regulator IC only can supply min voltage is 1.000V and max voltage is 1.200V, and cpu work max voltage is 1.200V. But the cpu just need

Re: [PATCH -next] ARM i.MX53: remove duplicated include from clk-imx51-imx53.c

2013-11-06 Thread Shawn Guo
On Wed, Oct 30, 2013 at 01:38:34PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Remove duplicated include. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the

Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-06 Thread Shawn Guo
On Thu, Nov 07, 2013 at 01:55:21AM +, Rongjun Ying wrote: For given board, what voltages could be provided is known. So you can just define OPP table in board.dts and specify the voltage as the value that the regulator IC can supply, e.g. 1.200V in above example. This is not nice,

Re: [PATCH] usb: phy: phy-mxs-usb: set the correct platform drvdata

2013-11-06 Thread Shawn Guo
-by: Shawn Guo shawn@linaro.org Change-Id should be dropped though. Shawn --- drivers/usb/phy/phy-mxs-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c index fdd33b4..545844b 100644 --- a/drivers/usb/phy

Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-06 Thread Shawn Guo
On Thu, Nov 07, 2013 at 03:32:09AM +, Rongjun Ying wrote: I think my patch is better. Well, unfortunately your patch is plainly wrong, because there are in-tree users of voltage-tolerance right now. How can you simply remove it from driver with ignoring these users? $ git grep

Re: [PATCH] ARM: imx: Include linux/err.h

2013-10-04 Thread Shawn Guo
On Mon, Sep 30, 2013 at 02:04:51PM +0200, Thierry Reding wrote: The IS_ERR() macro is defined in the linux/err.h header file, so include it explicitly. Hmm, I can not find IS_ERR() in arch/arm/mach-imx/cpu.c Shawn Signed-off-by: Thierry Reding tred...@nvidia.com ---

Re: [PATCH] ARM: imx: Include linux/err.h

2013-10-04 Thread Shawn Guo
On Sat, Oct 05, 2013 at 10:24:23AM +0800, Shawn Guo wrote: On Mon, Sep 30, 2013 at 02:04:51PM +0200, Thierry Reding wrote: The IS_ERR() macro is defined in the linux/err.h header file, so include it explicitly. Hmm, I can not find IS_ERR() in arch/arm/mach-imx/cpu.c Sorry, I did not look

Re: [PATCH 1/3] ARM: dts: imx53-qsb: SDHC3 is connected in 8-bit mode

2013-10-06 Thread Shawn Guo
On Fri, Oct 04, 2013 at 01:15:26PM -0300, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com SDHC3 is 8 bit-wide, so pass the bus-width property to reflect that. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Applied all 3, thanks. -- To unsubscribe from this

Re: [PATCH v7 0/4] Add dual-fifo mode support of i.MX ssi

2013-11-24 Thread Shawn Guo
On Sat, Nov 23, 2013 at 12:31:32AM +0800, Nicolin Chen wrote: Hi all, I'm sorry to push this. But this series has been an orphan for a while. Could any one please receive and foster it? Vinod, I expect you will pick up the series. But otherwise, I can apply it via IMX tree with your

Re: [PATCH 02/11] regulator: anatop: Fix checkpatch issue

2013-10-14 Thread Shawn Guo
On Mon, Oct 14, 2013 at 05:45:51PM +0900, Jingoo Han wrote: Fix the following checkpatch warning. WARNING: quoted string split across lines Signed-off-by: Jingoo Han jg1@samsung.com Acked-by: Shawn Guo shawn@linaro.org --- drivers/regulator/anatop-regulator.c |4 ++-- 1

Re: [PATCHv7 1/3] ARM: imx: Add DMAMUX clock for Vybrid vf610 SoC

2013-11-10 Thread Shawn Guo
On Fri, Nov 08, 2013 at 06:01:53PM +0800, Jingchang Lu wrote: Signed-off-by: Jingchang Lu b35...@freescale.com Applied this one. Shawn --- changes in v7: fix dmamux2 and dmamux3 register number. no changes in v2 ~ v6. arch/arm/mach-imx/clk-vf610.c | 5 +

Re: [PATCH 0/2] Add monaural audio support for fsl_ssi.c

2013-11-14 Thread Shawn Guo
On Thu, Nov 14, 2013 at 07:07:08PM +0800, Nicolin Chen wrote: This series of patches need to be applied into one single tree because the second patch depends on the first one. Without it, SSI would playback constant noise to the right channel when playback monaural audio files on i.MX6 Series

Re: [PATCH 0/2] Add monaural audio support for fsl_ssi.c

2013-11-14 Thread Shawn Guo
On Fri, Nov 15, 2013 at 10:59:57AM +0800, Nicolin Chen wrote: Hi Shawn, On Fri, Nov 15, 2013 at 11:02:49AM +0800, Shawn Guo wrote: On Thu, Nov 14, 2013 at 07:07:08PM +0800, Nicolin Chen wrote: This series of patches need to be applied into one single tree because the second patch

Re: [PATCH 1/2] ARM: dts: imx: specify the value of audmux pinctrl instead of 0x80000000

2013-11-14 Thread Shawn Guo
On Thu, Nov 14, 2013 at 07:07:09PM +0800, Nicolin Chen wrote: We must specify the value of audmux pinctrl if we want to use pinctrl_pm(). Thus change bypass value 0x8000 to what we exactly need. This patch also seperately unset PUE bit for TXD so that IOMUX won't pull up/down the pin

Re: [PATCH] cpufreq: cpufreq-cpu0: Use a sane boot frequency when booting with a mismatched bootloader configuration

2013-11-16 Thread Shawn Guo
On Fri, Nov 15, 2013 at 08:22:15PM -0600, Nishanth Menon wrote: On many development platforms, at boot, the bootloader configured frequency maynot match the valid frequencies that are stated to be supported in OPP table. This may occur due to various reasons: a) older or default bootloader in

Re: [PATCH] cpufreq: cpufreq-cpu0: Use a sane boot frequency when booting with a mismatched bootloader configuration

2013-11-18 Thread Shawn Guo
On Mon, Nov 18, 2013 at 08:45:12AM -0600, Nishanth Menon wrote: snip I do not agree about this stance - device tree describes hardware capabilities to kernel - I agree with that statement. Kernel should not care if that is provided by bootloader/firmware/fused into flash/ROM etc. Yea, ideally

Re: [PATCH] cpufreq: cpufreq-cpu0: Use a sane boot frequency when booting with a mismatched bootloader configuration

2013-11-18 Thread Shawn Guo
On Mon, Nov 18, 2013 at 10:41:36AM -0600, Nishanth Menon wrote: In the case of mismatch, to consider that device tree may be wrong in driver is also to assume that hardware was always configured correctly and we assume description is the flawed data. No, I did not say that. IMO, when

Re: [patch 08/26] arm: Replace various irq_desc accesses

2014-02-23 Thread Shawn Guo
On Sun, Feb 23, 2014 at 09:40:12PM -, Thomas Gleixner wrote: Use the proper functions. There is no need to fiddle with irq_desc. Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Shawn Guo shawn@linaro.org ... arch/arm/mach-imx/pm-imx6q.c|7 +++ Acked-by: Shawn

Re: [PATCH 2/3] ARM: dts: vf610: i2c: Add eDMA support

2014-02-27 Thread Shawn Guo
On Thu, Feb 27, 2014 at 02:06:19PM +0800, Yuan Yao wrote: Add i2c dts node properties for eDMA support, them depend on the eDMA driver. Signed-off-by: Yuan Yao yao.y...@freescale.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-27 Thread Shawn Guo
On Thu, Feb 27, 2014 at 02:05:14PM +0800, Yuan Yao wrote: Add dma support for i2c. This function depend on DMA driver. You can turn on it by write both the dmas and dma-name properties in dts node. And you should set .has_dma_support as true for dma support in imx_i2c_hwdata struct.

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-27 Thread Shawn Guo
On Thu, Feb 27, 2014 at 08:55:45PM +0800, Shawn Guo wrote: On Thu, Feb 27, 2014 at 02:05:14PM +0800, Yuan Yao wrote: Add dma support for i2c. This function depend on DMA driver. You can turn on it by write both the dmas and dma-name properties in dts node. And you should set

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-27 Thread Shawn Guo
On Thu, Feb 27, 2014 at 09:39:35PM +0100, Marek Vasut wrote: @@ -193,6 +216,7 @@ static const struct imx_i2c_hwdata imx1_i2c_hwdata = { .ndivs = ARRAY_SIZE(imx_i2c_clk_div), .i2sr_clr_opcode= I2SR_CLR_OPCODE_W0C, .i2cr_ien_opcode=

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-27 Thread Shawn Guo
On Fri, Feb 28, 2014 at 10:13:02AM +0800, Shawn Guo wrote: On Thu, Feb 27, 2014 at 09:39:35PM +0100, Marek Vasut wrote: @@ -193,6 +216,7 @@ static const struct imx_i2c_hwdata imx1_i2c_hwdata = { .ndivs = ARRAY_SIZE(imx_i2c_clk_div), .i2sr_clr_opcode

Re: [PATCH 1/4] w1: Remove excess dependencies on W1 for masters and slaves

2014-03-04 Thread Shawn Guo
the others :) Others look good to me. So, Acked-by: Shawn Guo shawn@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH] ARM: vf610: add UART choice for low-level debug

2014-03-04 Thread Shawn Guo
On Tue, Mar 04, 2014 at 12:27:09AM +0100, Stefan Agner wrote: Add choice for low-level debug UART. Similar to i.MX6, there is a numeric configuration, valid choices are 0 to 3. Not that the kernel assumes that the boot loader initialized clock properly. Signed-off-by: Stefan Agner

Re: [PATCH] ARM: dts: imx6qdl-sabresd.dtsi: Add heartbeat led

2014-03-04 Thread Shawn Guo
vincent.ste...@freescale.com Cc: Shawn Guo shawn@linaro.org Cc: Sascha Hauer ker...@pengutronix.de --- Hi, This has been tested on Sabre SD i.MX6 Quad board, with linux v3.14-rc5+ and imx_v6_v7_defconfig. As a side note, checkpatch.pl complains about gpio-leds being undocumented

Re: [PATCH v2] ARM: dts: imx6qdl-sabresd.dtsi: Add red led

2014-03-05 Thread Shawn Guo
: Shawn Guo shawn@linaro.org Cc: Sascha Hauer ker...@pengutronix.de --- Hi Shawn, Thanks for your feedback. If you don't want to make the led a heartbeat by default, here is v2 of the patch, which only makes the led available to the user. One is then free to use it as a heartbeat

Re: [PATCH] clocksource: vf_pit_timer: use complement for sched_clock reading

2014-03-05 Thread Shawn Guo
starts at 0 since we load the register with the maximum value at start. Signed-off-by: Stefan Agner ste...@agner.ch Looks correct to me, so Acked-by: Shawn Guo shawn@linaro.org But I also copied the driver author Jingchang to see if he has any comment. Shawn --- drivers/clocksource

Re: [PATCH v2] ARM: vf610: add UART choice for low-level debug

2014-03-05 Thread Shawn Guo
On Wed, Mar 05, 2014 at 11:07:48PM +0100, Stefan Agner wrote: Add choice for low-level debug UART. Similar to i.MX6, there is a numeric configuration, valid choices are 0 to 3. Note that the kernel assumes that the boot loader initialized clock properly. Signed-off-by: Stefan Agner

Re: [PATCH v2] ARM: dts: imx6qdl-sabresd.dtsi: Add red led

2014-03-05 Thread Shawn Guo
On Wed, Mar 05, 2014 at 07:39:26PM +, Russell King - ARM Linux wrote: On Wed, Mar 05, 2014 at 07:42:28PM +0800, Shawn Guo wrote: It's not a hog pin, so shouldn't be added here. (Right, most of the existing pins shouldn't be here from the beginning) On the subject of that kind of thing

Re: [PATCH v3] ARM: dts: imx6qdl-sabresd.dtsi: Add red led

2014-03-05 Thread Shawn Guo
On Wed, Mar 05, 2014 at 07:58:39PM +0100, Vincent Stehlé wrote: Make the red gpio led available to the user. This can be toggled with the sysfs for example, or used as a heartbeat or mmc activity light by changing the trigger. Signed-off-by: Vincent Stehlé vincent.ste...@freescale.com

Re: [PATCH v2 1/2] i2c: add DMA support for freescale i2c driver

2014-03-09 Thread Shawn Guo
On Thu, Mar 06, 2014 at 12:57:42PM +0100, Marek Vasut wrote: On Thursday, March 06, 2014 at 06:02:03 AM, Yao Yuan wrote: On Thu, March 06, 2014 at 12:44:14 PM, Marek Vasut wrote: On Thursday, March 06, 2014 at 05:36:14 AM, Yao Yuan wrote: On Thu, March 06, 2014 at 11:23:50 AM, Marek

[PATCH] genalloc: spinlock_t needs spinlock_types.h

2014-01-09 Thread Shawn Guo
Compiling a C file which includes genalloc.h but without spinlock_types.h being included before, we will see the compile error below. include/linux/genalloc.h:54:2: error: unknown type name ‘spinlock_t’ Include spinlock_types.h from genalloc.h to fix the problem. Signed-off-by: Shawn Guo shawn

Re: [PATCH v4 1/2] ARM: imx: add select on ARCH_MXC for cpufreq support

2014-01-12 Thread Shawn Guo
On Thu, Jan 09, 2014 at 06:39:51PM -0800, John Tobias wrote: Moved ARCH_HAS_CPUFREQ, HAVE_IMX_ANATOP and PM_OPP on ARCH_MXC so that the user can enable the cpufreq support for iMX6Q and/or iMX6SL. All I was asking is to move the following: select ARCH_HAS_CPUFREQ select

Re: [PATCH v4 2/2] cpufreq: imx6q-cpufreq driver depends on SOC_IMX6Q/SOC_IMX6SL

2014-01-12 Thread Shawn Guo
On Thu, Jan 09, 2014 at 06:39:52PM -0800, John Tobias wrote: The ARCH_HAS_CPUFREQ, HAVE_IMX_ANATOP and PM_OPP are moved up to ARCH_MCX. The driver should show if the SOC_IMX6Q and/or SOC_IMX6SL is/are selected. Signed-off-by: John Tobias john.tobias...@gmail.com ---

Re: [PATCH v4 1/2] ARM: imx: add select on ARCH_MXC for cpufreq support

2014-01-12 Thread Shawn Guo
On Sun, Jan 12, 2014 at 08:54:18PM -0800, John Tobias wrote: I tested leaving the HAVE_IMX_ANATOP under SOC_IMX6Q and SOC_IMX6SL. The iMX6Q cpufreq driver won't show up in menu config / gconfig and that's the reason why I added it. I tested the following changes against my for-next branch, and

Re: [PATCH 2/2] ARM: dts: imx53: add support for Ka-Ro TX53 modules

2014-01-13 Thread Shawn Guo
On Mon, Jan 13, 2014 at 11:32:38AM +0100, Lothar Waßmann wrote: This patch adds support for the Ka-Ro electronics GmbH TX53 modules. There are two distinct module types. One with an LVDS display interface and SATA support, the other with a parallel LCD interface and no SATA interface.

Re: [PATCH RESEND v11 1/2] ARM: dts: vf610: Add eDMA node

2014-02-17 Thread Shawn Guo
On Tue, Feb 18, 2014 at 10:17:11AM +0800, Jingchang Lu wrote: Signed-off-by: Jingchang Lu b35...@freescale.com Acked-by: Arnd Bergmann a...@arndb.de Applied, thanks. Shawn --- no changes in v10 ~ v11. changes in v9: remove include/dt-bindings/dma/vf610-edma.h, the request source ID

Re: [PATCH] pfuze100-regulator: Revert regulator: pfuze100: Use of_get_child_by_name

2014-02-18 Thread Shawn Guo
On Tue, Feb 18, 2014 at 09:58:52PM +0530, Sachin Kamat wrote: On 18 February 2014 21:20, Fabio Estevam fabio.este...@freescale.com wrote: Since commit d7857c42 (regulator: pfuze100: Use of_get_child_by_name) we get the following probe failure: pfuze100-regulator 1-0008: Full layer: 1,

Re: [PATCH 2/4] ARM: dts: Enable SAI ALSA SoC DAI device for Vybrid VF610 TOWER board.

2014-02-18 Thread Shawn Guo
On Wed, Feb 19, 2014 at 01:38:41PM +0800, Xiubo Li wrote: This patch adds and enables the SAI device. Signed-off-by: Xiubo Li li.xi...@freescale.com --- arch/arm/boot/dts/vf610-twr.dts | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/vf610-twr.dts

Re: [PATCH 1/4] ARM: dts: Add Freescale SAI ALSA SoC Digital Audio Interface node for VF610.

2014-02-18 Thread Shawn Guo
On Wed, Feb 19, 2014 at 01:38:40PM +0800, Xiubo Li wrote: This patch adds the SAI's edma mux Tx and Rx support. Signed-off-by: Xiubo Li li.xi...@freescale.com 'ARM: dts: vf610: ...' for patch prefix. Shawn --- arch/arm/boot/dts/vf610.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [PATCH 2/4] ARM: dts: Enable SAI ALSA SoC DAI device for Vybrid VF610 TOWER board.

2014-02-18 Thread Shawn Guo
On Wed, Feb 19, 2014 at 01:38:41PM +0800, Xiubo Li wrote: This patch adds and enables the SAI device. Signed-off-by: Xiubo Li li.xi...@freescale.com The patch subject can be a little short like ARM: dts: vf610-twr: Enable SAI ALSA SoC DAI device Shawn ---

Re: [PATCH 3/4] ARM: dts: Enable SGTL5000 codec based audio driver node for VF610 TOWER.

2014-02-18 Thread Shawn Guo
On Wed, Feb 19, 2014 at 01:38:42PM +0800, Xiubo Li wrote: This patch adds and enables SGTL5000 codec support. Signed-off-by: Xiubo Li li.xi...@freescale.com --- arch/arm/boot/dts/vf610-twr.dts | 19 +++ 1 file changed, 19 insertions(+) diff --git

Re: linux-next: manual merge of the imx-mxs tree with the arm-soc tree

2014-02-19 Thread Shawn Guo
On Thu, Feb 20, 2014 at 11:42:42AM +1100, Stephen Rothwell wrote: Hi Shawn, Today's linux-next merge of the imx-mxs tree got conflicts in arch/arm/mach-imx/Makefile and arch/arm/mach-imx/common.h between commit 28a9f3b078c5 (ARM: imx6: build pm-imx6q.c independently of CONFIG_PM) from the

Re: [PATCH v2 0/4] Add audio card DT node support for Vybird-TWR board

2014-02-19 Thread Shawn Guo
On Wed, Feb 19, 2014 at 03:42:27PM +0800, Xiubo Li wrote: Xiubo Li (4): ARM: dts: vf610: Add edma mux Tx and Rx support for SAI node. ARM: dts: vf610-twr: Enable SAI ALSA SoC DAI device ARM: dts: vf610-twr: Enable SGTL5000 codec. ARM: dts: vf610-twr: Add simple-card support. Applied

Re: [PATCH V1] spi: imx: add dma support for ecspi

2014-02-12 Thread Shawn Guo
On Wed, Feb 12, 2014 at 06:02:59PM +0800, Robin Gong wrote: Add basical dma support for ecspi. Validate on i.MX6qsabresd board. Signed-off-by: Robin Gong b38...@freescale.com Robin, Are you aware of the submission [1] from Frank Li? You may want to coordinate the effort with him. Shawn

Re: [PATCH 4/5] ARM: dts: tx53: add simple-panel support

2014-03-22 Thread Shawn Guo
On Wed, Mar 19, 2014 at 02:28:40PM +0100, Lothar Waßmann wrote: Signed-off-by: Lothar Waßmann l...@karo-electronics.de --- arch/arm/boot/dts/imx53-tx53-x13x.dts | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.dts

Re: [PATCH 1/5] ARM: dts: tx53: remove redundant regulator-boot-on

2014-03-22 Thread Shawn Guo
On Wed, Mar 19, 2014 at 02:28:37PM +0100, Lothar Waßmann wrote: Signed-off-by: Lothar Waßmann l...@karo-electronics.de Please add something in the commit log, e.g. why regulator-boot-on is redundant in this case. Shawn --- arch/arm/boot/dts/imx53-tx53-x13x.dts |2 -- 1 file changed,

Re: [PATCH 5/5] ARM: dts: tx53: Add IPU DI ports and endpoints

2014-03-22 Thread Shawn Guo
On Wed, Mar 19, 2014 at 02:28:41PM +0100, Lothar Waßmann wrote: Signed-off-by: Lothar Waßmann l...@karo-electronics.de --- arch/arm/boot/dts/imx53-tx53-x03x.dts |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx53-tx53-x03x.dts

Re: [PATCH] ARM: dts: imx6: add support for Ka-Ro TX6 modules

2014-03-22 Thread Shawn Guo
On Wed, Mar 19, 2014 at 02:29:44PM +0100, Lothar Waßmann wrote: This patch adds support for the Ka-Ro electronics GmbH TX6 modules. There are five distinct module types with either i.MX6Q or i.MX6DL and LVDS or LCD display interface and one DTS file for a complete system with an i.MX6DL based

Re: [PATCH 2/2] ARM: dts: cfa10036: Change the OLED display to SSD1306

2013-05-08 Thread Shawn Guo
On Mon, Apr 22, 2013 at 11:55:55AM +0200, Maxime Ripard wrote: The SSD1307 was used in an early prototype that will never get distributed. The final board now has a SSD1306 instead, that has its own power generation unit and thus doesn't need any PWM. The panel attached to it also changed.

Re: [PATCH 1/4] ARM: cfa10036: dt: Change i2c0 clock frequency

2013-05-08 Thread Shawn Guo
On Mon, Apr 22, 2013 at 12:02:22PM +0200, Maxime Ripard wrote: The OLED display can work faster. Change the i2c controller clock frequency to remove the tearing effect that can be seen on the display. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Applied, thanks. -- To

Re: [PATCH 06/13] pwm: pwm-mxs: Let device core handle pinctrl

2013-05-08 Thread Shawn Guo
imx guys? I'm not sure why you're interested in this patch instead of [PATCH 01/13] usb: chipidea: ci13xxx_imx: Let device core handle pinctrl. I tested both patches, so Tested-by: Shawn Guo shawn@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH RFC 0/3] clk: dt: bindings for mux divider clocks

2013-06-07 Thread Shawn Guo
On Fri, Jun 07, 2013 at 10:52:54AM -0700, Mike Turquette wrote: Yes, there was a time when I was firmly against doing such a thing. However I'm not sure it is so bad now. More and more SoCs are going to keep getting merged into the kernel and that just means more and more clock data. Perhaps

Re: [PATCH 06/11] cpufreq: imx: select CPU_FREQ_TABLE

2013-06-12 Thread Shawn Guo
On Wed, Jun 12, 2013 at 01:45:13PM +0530, Viresh Kumar wrote: CPUFreq driver of this platform uses APIs from freq_table.c and so must select CPU_FREQ_TABLE. Cc: Shawn Guo shawn@linaro.org Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Shawn Guo shawn@linaro.org

Re: [PATCH 1/4] ARM: cfa10036: Add USB0 OTG port

2013-06-14 Thread Shawn Guo
On Fri, Jun 14, 2013 at 12:06:51AM +0200, Arnd Bergmann wrote: On Thursday 13 June 2013 15:43:42 Maxime Ripard wrote: + + ahb@8008 { + usb0: usb@8008 { + pinctrl-names = default; + pinctrl-0 = usb0_otg_cfa10036; +

Re: [PATCH 1/4] ARM: cfa10036: Add USB0 OTG port

2013-06-14 Thread Shawn Guo
On Fri, Jun 14, 2013 at 02:30:53PM +0800, Shawn Guo wrote: On Fri, Jun 14, 2013 at 12:06:51AM +0200, Arnd Bergmann wrote: On Thursday 13 June 2013 15:43:42 Maxime Ripard wrote: + + ahb@8008 { + usb0: usb@8008 { + pinctrl-names

Re: [PATCH 0/4] ARM: mxs: Various Crystalfontz DT additions

2013-06-14 Thread Shawn Guo
On Thu, Jun 13, 2013 at 03:43:41PM +0200, Maxime Ripard wrote: Brian Lilly (3): ARM: cfa10049: Switch the chip select pin of the LCD controller ARM: mxs: dt: Add the Crystalfontz CFA-10055 device tree ARM: mxs: dt: Add Crystalfontz CFA-10057 device tree Maxime Ripard (1): ARM:

Re: [PATCH v2 1/5] clk: divider: replace bitfield width with mask

2013-06-17 Thread Shawn Guo
that are based on struct clk_divider. Cc: Sascha Hauer ker...@pengutronix.de Cc: Shawn Guo shawn@linaro.org Signed-off-by: Mike Turquette mturque...@linaro.org --- No change since v1, new patch arch/arm/mach-imx/clk-busy.c | 2 +- drivers/clk/clk-divider.c| 31

Re: [PATCH] mxs: icoll: Add function to register an interrupt as FIQ source

2013-05-01 Thread Shawn Guo
On Mon, Apr 29, 2013 at 03:58:37PM +0200, Maxime Ripard wrote: MXS, unlike other ARM platforms, How are other ARM platforms handling that? has no way to make a FIQ from an interrupt from a driver, without poking directly into the icoll. Add an exported function to do this.

Re: [PATCH] gpio: mxs: Use set and clear capabilities of the gpio controller

2013-05-01 Thread Shawn Guo
it behave pretty much like a cache. This raises some coherency problem when a gpio is not modified by the gpio controller, while it can easily be fixed by using the set and clear registers. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Acked-by: Shawn Guo shawn@linaro.org

Re: [PATCH] cpufreq: cpu0: Free parent node for error cases

2013-05-01 Thread Shawn Guo
On Wed, May 01, 2013 at 10:34:43AM +0530, Viresh Kumar wrote: We are freeing parent node in success cases but not in failure cases. Lets do it. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/cpufreq/cpufreq-cpu0.c | 13 - 1 file changed, 8 insertions(+), 5

Re: [PATCH, RFC 04/22] staging/drm: imx: add missing dependencies

2013-05-02 Thread Shawn Guo
to `of_get_drm_display_mode' There is a patch [1] from Marek fixing this one. Shawn [1] http://thread.gmane.org/gmane.linux.ports.arm.kernel/233449 Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Shawn Guo shawn@linaro.org Cc: Philipp Zabel p.za...@pengutronix.de Signed-off-by: Arnd Bergmann

Re: [PATCH, RFC 20/22] media: coda: select GENERIC_ALLOCATOR

2013-05-02 Thread Shawn Guo
On Thu, May 02, 2013 at 09:53:19PM +0200, Arnd Bergmann wrote: Unfortunately, linux-next as of today is still broken. Shawn, did I miss a pull request from you? No, I haven't sent you a pull request for that. I have queued it for 3.10-rc but am still waiting for a stable base (3.10-rc1 where

Re: [PATCH V2] cpufreq: cpu0: Free parent node for error cases

2013-05-03 Thread Shawn Guo
On Fri, May 03, 2013 at 10:14:25AM +0530, Viresh Kumar wrote: We are freeing parent node in success cases but not in failure cases. Lets do it. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Shawn Guo shawn@linaro.org --- drivers/cpufreq/cpufreq-cpu0.c | 5 - 1

Re: [PATCH, RFC 04/22] staging/drm: imx: add missing dependencies

2013-05-04 Thread Shawn Guo
On Fri, May 03, 2013 at 05:21:37PM +0200, Arnd Bergmann wrote: On Friday 03 May 2013, Shawn Guo wrote: On Thu, May 02, 2013 at 05:16:08PM +0200, Arnd Bergmann wrote: The imx DRM driver needs a couple of extra Kconfig dependencies to avoid random build failures: drivers/staging/imx

Re: [PATCH 2/4] pinctrl: mxs: remove unnecessary platform_set_drvdata()

2013-05-06 Thread Shawn Guo
to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han jg1@samsung.com Acked-by: Shawn Guo shawn@linaro.org --- drivers/pinctrl/pinctrl-mxs.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-mxs.c b/drivers/pinctrl

Re: [PATCH RFC 0/3] clk: dt: bindings for mux divider clocks

2013-06-06 Thread Shawn Guo
Mike, On Mon, Jun 03, 2013 at 10:53:07AM -0700, Mike Turquette wrote: I am using this code while converting the OMAP4 clock data over to DT I see these basic clk bindings can be useful for platforms that have a relatively simple clock tree, but I'm a little surprised that you plan to move OMAP4

Re: [PATCH 001/001] gpio-mxs: Select faster gpio-generic set methods

2013-06-24 Thread Shawn Guo
On Fri, Jun 21, 2013 at 11:14:07AM -0700, Simon Pearson wrote: From: Simon Pearson spear...@acumalabs.com Kernel 3.8.4. By defining both the set and clear registers, the speed of the gpio isimproved. gpio-generic.c, selects the bgpio_set_with_clear() which isfaster than the current

Re: [PATCH] apf27dev: add rtc ds1374 to the device tree

2013-06-24 Thread Shawn Guo
On Fri, Jun 21, 2013 at 06:24:13PM +0200, Philippe Reynes wrote: Signed-off-by: Philippe Reynes trem...@yahoo.fr Applied, thanks. Shawn --- arch/arm/boot/dts/imx27-apf27dev.dts |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git

Re: [PATCH 1/1] clocksource: vf_pit_timer: Fix build breakage

2013-06-25 Thread Shawn Guo
/vf_pit_timer.c:15:29: fatal error: asm/sched_clock.h: No such file or directory Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Jingchang Lu b35...@freescale.com Cc: Daniel Lezcano daniel.lezc...@linaro.org Cc: Shawn Guo shawn@linaro.org Thanks. But there is already a patch [1

Re: RFC: [PATCH] clocksource: tcb: fix min_delta calculation

2013-04-23 Thread Shawn Guo
for the fixing, Marc. Acked-by: Shawn Guo shawn@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH] ASoC: don't call of_dma_request_slave_channel directly

2013-04-23 Thread Shawn Guo
...@metafoo.de Cc: Shawn Guo shawn@linaro.org Cc: Mark Brown broo...@opensource.wolfsonmicro.com --- sound/soc/soc-generic-dmaengine-pcm.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/sound/soc/soc-generic-dmaengine-pcm.c b/sound/soc/soc-generic-dmaengine

Re: [PATCH 16/20] ARM: mxs: Remove init_irq declaration in machine description

2013-05-16 Thread Shawn Guo
On Tue, May 14, 2013 at 05:38:49PM +0200, Maxime Ripard wrote: Commit ebafed7a (ARM: irq: Call irqchip_init if no init_irq function is specified) removed the need to explictly setup the init_irq field in the machine description when using only irqchip_init. Remove that declaration for mxs as

Re: [PATCH] can: flexcan: allow compilation on arm and powerpc

2013-05-16 Thread Shawn Guo
Hi Marc, On Thu, May 16, 2013 at 03:42:36PM +0200, Marc Kleine-Budde wrote: This patch removes the Kconfig symbols HAVE_CAN_FLEXCAN and IMX_HAVE_PLATFORM_FLEXCAN from arch/{arm,powerpc} and allowing compilation on all arm and powerpc platforms. I'm generally fine with the approach. But with

Re: [PATCH v2] can: flexcan: remove HAVE_CAN_FLEXCAN Kconfig symbol

2013-05-17 Thread Shawn Guo
dependency warning found by Arnd Bergmann: warning: (SOC_IMX28 SOC_IMX25 SOC_IMX35 IMX_HAVE_PLATFORM_FLEXCAN SOC_IMX53 SOC_IMX6Q) selects HAVE_CAN_FLEXCAN which has unmet direct dependencies (NET CAN CAN_DEV) Cc: Arnd Bergmann a...@arndb.de Cc: Shawn Guo shawn

Re: [PATCH v3] clocksource: add MVF600 pit timer support

2013-05-19 Thread Shawn Guo
On Thu, May 16, 2013 at 02:15:24PM +0800, Jingchang Lu wrote: Add Freescale Vybrid MVF600 period interrupt timer support. Signed-off-by: Jingchang Lu b35...@freescale.com --- v3: move the pit driver to drivers/clocksource. drivers/clocksource/Kconfig| 5 +

Re: [PATCH v3] clocksource: add MVF600 pit timer support

2013-05-19 Thread Shawn Guo
On Mon, May 20, 2013 at 03:08:54AM +, Lu Jingchang-B35083 wrote: [Lu Jingchang-B35083] I am not sure MVF5xx and MVF7xx have the same PIT block, if you have information that it is the same on other Vybrid SoCs, it is ok to change the driver name to mvf. Thanks! Even the PIT block on

Re: [PATCH 1/3] imx-drm: imx-tve: Check the return value of 'regulator_enable()'

2013-05-20 Thread Shawn Guo
as __must_check). Other than these, Acked-by: Shawn Guo shawn@linaro.org drivers/staging/imx-drm/imx-tve.c: In function 'imx_tve_probe': drivers/staging/imx-drm/imx-tve.c:671:19: warning: ignoring return value of 'regulator_enable', declared with attribute warn_unused_result [-Wunused-result

Re: [PATCH 2/3] imx-drm: imx-tve: Let device core handle pinctrl

2013-05-20 Thread Shawn Guo
...@freescale.com Acked-by: Shawn Guo shawn@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH 3/3] imx-drm: parallel-display: Let device core handle pinctrl

2013-05-20 Thread Shawn Guo
...@freescale.com Acked-by: Shawn Guo shawn@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH 1/6] drivers: bus: add a new driver for WEIM

2013-05-20 Thread Shawn Guo
On Mon, May 20, 2013 at 04:48:57PM +0800, Huang Shijie wrote: The WEIM(Wireless External Interface Module) works like a bus. You can attach many different devices on it, such as NOR, onenand. In the case of i.MX6q-sabreauto, the NOR is connected to WEIM. This patch also adds the devicetree

Re: [PATCH 2/6] ARM: dts: imx6q{dl}: fix the pin conflict between SPI and WEIM

2013-05-20 Thread Shawn Guo
On Mon, May 20, 2013 at 04:48:58PM +0800, Huang Shijie wrote: In the imx6q-sabreauto and imx6dl-sabreauto boards, the pin MX6Q{DL}_PAD_EIM_D19 is used as a GPIO for SPI NOR, but it is used as a data pin for the WEIM NOR. In order to fix the conflict, this patch removes the pin from the hog,

Re: [PATCH] dma: mxs-dma: Staticize mxs_dma_xlate

2013-05-27 Thread Shawn Guo
...@freescale.com Acked-by: Shawn Guo shawn@linaro.org --- drivers/dma/mxs-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c index b48a79c..7195930 100644 --- a/drivers/dma/mxs-dma.c +++ b/drivers/dma/mxs-dma.c

Re: [PATCH 10/12] ipu_idmac: re-use dma_cookie_status()

2013-05-28 Thread Shawn Guo
On Mon, May 27, 2013 at 03:14:40PM +0300, Andy Shevchenko wrote: It's better to use generic dma_cookie_status() that allows user to get standard possible return codes independently of the DMAC driver in charge. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Shawn Guo

Re: [PATCH] ARM: mxs: Include clk mxs header file

2013-05-28 Thread Shawn Guo
' was not declared. Should it be static? Signed-off-by: Fabio Estevam fabio.este...@freescale.com Acked-by: Shawn Guo shawn@linaro.org --- drivers/clk/mxs/clk-imx28.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/mxs/clk-imx28.c b/drivers/clk/mxs/clk-imx28.c index d0e5eed

<    1   2   3   4   5   6   7   8   9   10   >