[PATCH] Documentation/DMA-API-HOWTO.txt - minor grammar corrections

2012-10-29 Thread Shuah Khan
Minor grammar corrections. Signed-off-by: Shuah Khan shuah.k...@hp.com --- Documentation/DMA-API-HOWTO.txt |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/DMA-API-HOWTO.txt b/Documentation/DMA-API-HOWTO.txt index bf242bbe..14129f1 100644

Re: [PATCH RFT RESEND linux-next] mips: dma-mapping: support debug_dma_mapping_error

2012-10-30 Thread Shuah Khan
On Fri, 2012-10-26 at 15:31 -0700, David Daney wrote: On 10/26/2012 02:51 PM, Shuah Khan wrote: On 10/26/2012 09:01 AM, Shuah Khan wrote: Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status

Re: dma_mapping_error() interfaces

2012-11-01 Thread Shuah Khan
On Wed, 2012-10-31 at 09:39 -0400, Konrad Rzeszutek Wilk wrote: On Thu, Oct 25, 2012 at 01:56:20PM -0600, Shuah Khan wrote: I am working on changing dma_mapping_error() interfaces to add call to debug_dma_mapping_error() interface. I found several dma_mapping_error() defines in various arch

Re: [PATCH linux-next] ARM64: dma-mapping: support debug_dma_mapping_error

2012-11-02 Thread Shuah Khan
On Fri, 2012-10-26 at 09:23 -0600, Shuah Khan wrote: Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed

Re: [RFC] Second attempt at kernel secure boot support

2012-11-02 Thread Shuah Khan
On Fri, Nov 2, 2012 at 9:52 AM, Vivek Goyal vgo...@redhat.com wrote: On Fri, Nov 02, 2012 at 03:42:48PM +, Matthew Garrett wrote: On Fri, Nov 02, 2012 at 11:30:48AM -0400, Vivek Goyal wrote: crash utility has module which allows reading kernel memory. So leaking this private key will be

Re: [PATCH RFT RESEND linux-next] c6x: dma-mapping: support debug_dma_mapping_error

2012-11-02 Thread Shuah Khan
On Fri, 2012-10-26 at 09:40 -0600, Shuah Khan wrote: Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off

Re: [PATCH RFT RESEND linux-next] hexagon: dma-mapping: support debug_dma_mapping_error

2012-11-02 Thread Shuah Khan
On Fri, 2012-10-26 at 09:43 -0600, Shuah Khan wrote: Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off

Re: [PATCH RFT RESEND linux-next] c6x: dma-mapping: support debug_dma_mapping_error

2012-11-02 Thread Shuah Khan
On Fri, 2012-11-02 at 15:10 -0400, Mark Salter wrote: On Fri, 2012-11-02 at 10:44 -0600, Shuah Khan wrote: On Fri, 2012-10-26 at 09:40 -0600, Shuah Khan wrote: Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error

Re: [PATCH RFT RESEND linux-next] c6x: dma-mapping: support debug_dma_mapping_error

2012-11-02 Thread Shuah Khan
On Fri, 2012-11-02 at 16:15 -0400, Mark Salter wrote: On Fri, 2012-11-02 at 13:53 -0600, Shuah Khan wrote: On Fri, 2012-11-02 at 15:10 -0400, Mark Salter wrote: On Fri, 2012-11-02 at 10:44 -0600, Shuah Khan wrote: On Fri, 2012-10-26 at 09:40 -0600, Shuah Khan wrote: Add support

Re: [PATCH RFT RESEND linux-next] c6x: dma-mapping: support debug_dma_mapping_error

2012-11-02 Thread Shuah Khan
On Fri, 2012-11-02 at 16:59 -0400, Mark Salter wrote: On Fri, 2012-11-02 at 14:26 -0600, Shuah Khan wrote: On Fri, 2012-11-02 at 16:15 -0400, Mark Salter wrote: On Fri, 2012-11-02 at 13:53 -0600, Shuah Khan wrote: On Fri, 2012-11-02 at 15:10 -0400, Mark Salter wrote: On Fri, 2012-11

[PATCH v2] dma-debug: New interfaces to debug dma mapping errors

2012-09-25 Thread Shuah Khan
. Other architectures will be changed in a subsequent patch. Tested: Intel iommu and swiotlb (iommu=soft) on x86-64 with CONFIG_DMA_API_DEBUG enabled and disabled. Signed-off-by: Shuah Khan shuah.k...@hp.com --- Documentation/DMA-API.txt | 13 + arch/x86/include/asm/dma

Re: [PATCH v2] dma-debug: New interfaces to debug dma mapping errors

2012-09-26 Thread Shuah Khan
On Wed, 2012-09-26 at 09:12 -0400, Konrad Rzeszutek Wilk wrote: Thanks for improving this patch. It is looking more and more ready for the kernel. With that in mind, I've some comments below. Good. Thanks for the comments and good suggestions. Will work on v3. ---

Re: [PATCH v2] dma-debug: New interfaces to debug dma mapping errors

2012-09-27 Thread Shuah Khan
Hi Joerg, On Thu, 2012-09-27 at 12:20 +0200, Joerg Roedel wrote: Hi Shuah, the patch looks better then the older versions. It comes closer to a merge, but I see one issue here: On Tue, Sep 25, 2012 at 07:05:17PM -0600, Shuah Khan wrote: debug_dma_mapping_error(struct device *dev

[PATCH v3] dma-debug: New interfaces to debug dma mapping errors

2012-10-03 Thread Shuah Khan
iommu and swiotlb (iommu=soft) on x86-64 with CONFIG_DMA_API_DEBUG enabled and disabled. Signed-off-by: Shuah Khan shuah.k...@hp.com --- Documentation/DMA-API.txt | 13 arch/x86/include/asm/dma-mapping.h |1 + include/linux/dma-debug.h |7 ++ lib/dma

Re: [PATCH v3] dma-debug: New interfaces to debug dma mapping errors

2012-10-04 Thread Shuah Khan
On Thu, 2012-10-04 at 10:01 -0400, Konrad Rzeszutek Wilk wrote: On Wed, Oct 03, 2012 at 02:45:11PM -0700, Andrew Morton wrote: On Wed, 03 Oct 2012 08:55:59 -0600 Shuah Khan shuah.k...@hp.com wrote: A recent dma mapping error analysis effort showed that a large percentage

Re: [PATCH v3] dma-debug: New interfaces to debug dma mapping errors

2012-10-04 Thread Shuah Khan
On Thu, 2012-10-04 at 13:38 -0400, Konrad Rzeszutek Wilk wrote: On Wed, Oct 03, 2012 at 08:55:59AM -0600, Shuah Khan wrote: A recent dma mapping error analysis effort showed that a large percentage of dma_map_single() and dma_map_page() returns are not checked for mapping errors

[PATCH v4] dma-debug: New interfaces to debug dma mapping errors

2012-10-04 Thread Shuah Khan
architectures will be changed in a subsequent patch. Tested: Intel iommu and swiotlb (iommu=soft) on x86-64 with CONFIG_DMA_API_DEBUG enabled and disabled. Signed-off-by: Shuah Khan shuah.k...@hp.com Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- Documentation/DMA-API.txt

[PATCH] dma-debug: fix to not have dependency on get_dma_ops() interface

2012-11-03 Thread Shuah Khan
: https://lkml.org/lkml/2012/10/26/367 Signed-off-by: Shuah Khan shuah.k...@hp.com Reported-by: Mark Salter msal...@redhat.com --- lib/dma-debug.c | 29 +++-- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/lib/dma-debug.c b/lib/dma-debug.c index 59f4a1a

[PATCH] wireless: iwlwifi - add dma_mapping_error() checks to avoid warnings

2012-11-03 Thread Shuah Khan
[iwldvm] Signed-off-by: Shuah Khan shuah.k...@hp.com --- drivers/net/wireless/iwlwifi/pcie/rx.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/iwlwifi/pcie/rx.c b/drivers/net/wireless/iwlwifi/pcie/rx.c index 137af4c..3731442 100644 --- a/drivers/net/wireless/iwlwifi

Re: [PATCH] wireless: iwlwifi - add dma_mapping_error() checks to avoid warnings

2012-11-05 Thread Shuah Khan
On Sun, 2012-11-04 at 10:16 +0100, Johannes Berg wrote: On Sat, 2012-11-03 at 19:40 -0600, Shuah Khan wrote: Add missing dma_mapping_error() checks to validate dma addresses returned by dma_map_page() calls to avoid the following warning: [ 28.475686] WARNING: at lib/dma-debug.c:933

Re: [PATCH] wireless: iwlwifi - add dma_mapping_error() checks to avoid warnings

2012-11-05 Thread Shuah Khan
On Mon, 2012-11-05 at 17:29 +0100, Johannes Berg wrote: On Mon, 2012-11-05 at 09:26 -0700, Shuah Khan wrote: Thanks for the report. Since I think doing BUG_ON() in such a scenario is a really bad idea, I've applied a different patch with your Reported-by. Yeah. I wasn't sure about

Re: [PATCH 1/2] Xen acpi pad implement

2012-11-06 Thread Shuah Khan
On Thu, Oct 25, 2012 at 6:19 AM, Liu, Jinsong jinsong@intel.com wrote: From f233ad06cf924116693d7d38be9ae9d8c11f8a9b Mon Sep 17 00:00:00 2001 From: Liu, Jinsong jinsong@intel.com Date: Fri, 26 Oct 2012 02:32:48 +0800 Subject: [PATCH 1/2] Xen acpi pad implement PAD is acpi Processor

Re: [PATCH -stable] amd_iommu: attach device fails on the last pci device

2012-10-23 Thread Shuah Khan
On Fri, 2012-10-12 at 12:35 -0700, Jonathan Nieder wrote: Shuah Khan wrote: On Fri, 2012-10-12 at 11:38 -0700, Jonathan Nieder wrote: To save Willy time: am I correct in guessing the upstream commit you are referring to is 98fc5a693bbdda498a556654c70d1e31a186c988 (x86/amd-iommu: Use

Re: [PATCH v4] dma-debug: New interfaces to debug dma mapping errors

2012-10-08 Thread Shuah Khan
On Fri, 2012-10-05 at 15:51 -0700, Andrew Morton wrote: Still seems overly complicated to me, but whatev. I think the way to handle this is pretty simple: set a flag in the dma entry when someone runs dma_mapping_error() and, if that flag wasn't set at unmap time, emit a loud warning.

[PATCH v5] dma-debug: New interfaces to debug dma mapping errors

2012-10-08 Thread Shuah Khan
and swiotlb (iommu=soft) on x86-64 with CONFIG_DMA_API_DEBUG enabled and disabled. Signed-off-by: Shuah Khan shuah.k...@hp.com --- Documentation/DMA-API.txt | 12 ++ arch/x86/include/asm/dma-mapping.h |1 + include/linux/dma-debug.h |7 lib/dma-debug.c

[PATCH] virt/kvm: change kvm_assign_device() to print return value when iommu_attach_device() fails

2012-10-08 Thread Shuah Khan
Change existing kernel error message to include return value from iommu_attach_device() when it fails. This will help debug device assignment failures more effectively. Signed-off-by: Shuah Khan shuah.k...@hp.com --- virt/kvm/iommu.c |6 +- 1 file changed, 1 insertion(+), 5 deletions

Re: [RFC PATCH 1/5] amd_iommu: Split IOMMU group initialization

2012-10-09 Thread Shuah Khan
Alex, couple of comments in-lined: On Mon, Oct 8, 2012 at 10:49 PM, Alex Williamson alex.william...@redhat.com wrote: This needs to be broken apart, start with pulling all the IOMMU group init code into a new function. Signed-off-by: Alex Williamson alex.william...@redhat.com ---

Re: [PATCH v5] dma-debug: New interfaces to debug dma mapping errors

2012-10-09 Thread Shuah Khan
On Tue, 2012-10-09 at 13:12 -0400, Konrad Rzeszutek Wilk wrote: On Mon, Oct 08, 2012 at 11:08:06AM -0600, Shuah Khan wrote: Add dma-debug interface debug_dma_mapping_error() to debug drivers that fail to check dma mapping errors on addresses returned by dma_map_single() and dma_map_page

Re: [PATCH v5] dma-debug: New interfaces to debug dma mapping errors

2012-10-10 Thread Shuah Khan
On Tue, 2012-10-09 at 14:06 -0700, Andrew Morton wrote: On Mon, 08 Oct 2012 11:08:06 -0600 Shuah Khan shuah.k...@hp.com wrote: Add dma-debug interface debug_dma_mapping_error() to debug drivers that fail to check dma mapping errors on addresses returned by dma_map_single

Re: [PATCH] virt/kvm: change kvm_assign_device() to print return value when iommu_attach_device() fails

2012-10-10 Thread Shuah Khan
On Wed, Oct 10, 2012 at 10:51 AM, Marcelo Tosatti mtosa...@redhat.com wrote: On Mon, Oct 08, 2012 at 06:36:11PM -0600, Shuah Khan wrote: Change existing kernel error message to include return value from iommu_attach_device() when it fails. This will help debug device assignment failures more

Re: [PATCH v4] dma-debug: New interfaces to debug dma mapping errors

2012-10-10 Thread Shuah Khan
On Tue, 2012-10-09 at 14:02 -0700, Andrew Morton wrote: On Mon, 08 Oct 2012 11:07:20 -0600 Shuah Khan shuah.k...@hp.com wrote: Still seems overly complicated to me, but whatev. I think the way to handle this is pretty simple: set a flag in the dma entry when someone runs

[PATCH -stable] amd_iommu: attach device fails on the last pci device

2012-10-12 Thread Shuah Khan
in amd_iommu_attach_device() for linux-2.6.32. Signed-off-by: Shuah Khan shuah.k...@hp.com CC: sta...@vger.kernel.org v2.6.32 --- arch/x86/kernel/amd_iommu.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c index 3a44b75..67de7d7

Re: [PATCH -stable] amd_iommu: attach device fails on the last pci device

2012-10-12 Thread Shuah Khan
On Fri, 2012-10-12 at 11:38 -0700, Jonathan Nieder wrote: Shuah Khan wrote: This bug is in linux-2.6.32 and an equivalent fix in linux-2.6.33 and has been carried forward to later kernels and is in the upstream kernel. This equivalent fix includes restructuring and consolidating

[PATCH] ioat: Fix DMA memory sync direction correct flag

2012-10-25 Thread Shuah Khan
] [a01952c3] ioat_probe+0x2f8/0x348 [ioatdma] Signed-off-by: Shuah Khan shuah.k...@hp.com CC: sta...@vger.kernel.org --- drivers/dma/ioat/dma_v3.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c index f7f1dc6

dma_mapping_error() interfaces

2012-10-25 Thread Shuah Khan
I am working on changing dma_mapping_error() interfaces to add call to debug_dma_mapping_error() interface. I found several dma_mapping_error() defines in various arch specific dma-mapping.h files. Majority of these arch specific defines look identical - simply static inline int

[PATCH RFT] ARM64: dma-mapping: support debug_dma_mapping_error

2012-10-25 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com --- arch/arm64/include

[PATCH RFT] c6x: dma-mapping: support debug_dma_mapping_error

2012-10-25 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com --- arch/c6x/include/asm

[PATCH RFT] hexagon: dma-mapping: support debug_dma_mapping_error

2012-10-25 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com --- arch/hexagon/include

[PATCH RFT] ia64: dma-mapping: support debug_dma_mapping_error

2012-10-25 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com --- arch/ia64/include

[PATCH RFT] microblaze: dma-mapping: support debug_dma_mapping_error

2012-10-25 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com --- arch/microblaze

[PATCH RFT] mips: dma-mapping: support debug_dma_mapping_error

2012-10-25 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com --- arch/mips/include

[PATCH RFT] openrisc: dma-mapping: support debug_dma_mapping_error

2012-10-25 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com --- arch/openrisc

[PATCH RFT] powerpc: dma-mapping: support debug_dma_mapping_error

2012-10-25 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com --- arch/powerpc/include

[PATCH RFT] sparc: dma-mapping: support debug_dma_mapping_error

2012-10-25 Thread Shuah Khan
From 9e8feb61482288c5a5dd609e0dd17c1a262a48a3 Mon Sep 17 00:00:00 2001 From: Shuah Khan shuahk...@gmail.com Date: Thu, 25 Oct 2012 18:31:42 -0600 Subject: [PATCH RFT] sparc: dma-mapping: support debug_dma_mapping_error Add support for debug_dma_mapping_error() call to avoid warning from

[PATCH RFT RESEND] sparc: dma-mapping: support debug_dma_mapping_error

2012-10-25 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com --- arch/sparc/include

Re: [PATCH RFT] microblaze: dma-mapping: support debug_dma_mapping_error

2012-10-26 Thread Shuah Khan
On Fri, 2012-10-26 at 10:29 +0200, Michal Simek wrote: On 10/26/2012 01:29 AM, Shuah Khan wrote: Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed

[PATCH linux-next] ARM64: dma-mapping: support debug_dma_mapping_error

2012-10-26 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com Acked-by: Catalin

[PATCH RFT RESEND linux-next] c6x: dma-mapping: support debug_dma_mapping_error

2012-10-26 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com --- arch/c6x/include/asm

[PATCH RFT RESEDN linux-next] hexagon: dma-mapping: support debug_dma_mapping_error

2012-10-26 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com --- arch/hexagon/include

[PATCH RFT RESEND linux-next] ia64: dma-mapping: support debug_dma_mapping_error

2012-10-26 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com --- arch/ia64/include

[PATCH v2 linux-next] microblaze: dma-mapping: support debug_dma_mapping_error

2012-10-26 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com Acked-by: Michal Simek

[PATCH RFT RESEND linux-next] mips: dma-mapping: support debug_dma_mapping_error

2012-10-26 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com --- arch/mips/include

[PATCH RFT RESEND linux-next] openrisc: dma-mapping: support debug_dma_mapping_error

2012-10-26 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com --- arch/openrisc

[PATCH RFT RESEND linux-next] powerpc: dma-mapping: support debug_dma_mapping_error

2012-10-26 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com --- arch/powerpc/include

[PATCH RFT RESEND linux-next] sparc: dma-mapping: support debug_dma_mapping_error

2012-10-26 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com --- arch/sparc/include

[PATCH RFT linux-next] sh: dma-mapping: support debug_dma_mapping_error

2012-10-26 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com --- arch/sh/include/asm

[PATCH RFT linux-next] frv: dma-mapping: support debug_dma_mapping_error

2012-10-26 Thread Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan shuah.k...@hp.com --- arch/frv/include/asm

Re: [PATCH RFT RESEND linux-next] mips: dma-mapping: support debug_dma_mapping_error

2012-10-26 Thread Shuah Khan
On Fri, 2012-10-26 at 09:45 -0700, David Daney wrote: On 10/26/2012 09:01 AM, Shuah Khan wrote: Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check

Re: [PATCH RFT linux-next] frv: dma-mapping: support debug_dma_mapping_error

2012-10-26 Thread Shuah Khan
On Fri, 2012-10-26 at 10:48 -0600, Shuah Khan wrote: Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off

Re: [PATCH RFT RESEND linux-next] sparc: dma-mapping: support debug_dma_mapping_error

2012-10-26 Thread Shuah Khan
On Fri, 2012-10-26 at 15:10 -0400, David Miller wrote: From: David Miller da...@davemloft.net Date: Fri, 26 Oct 2012 15:01:53 -0400 (EDT) From: Shuah Khan shuah.k...@hp.com Date: Fri, 26 Oct 2012 10:13:09 -0600 Add support for debug_dma_mapping_error() call to avoid warning from

Re: [PATCH RFT RESEND linux-next] mips: dma-mapping: support debug_dma_mapping_error

2012-10-26 Thread Shuah Khan
On Fri, 2012-10-26 at 13:07 -0700, David Daney wrote: On 10/26/2012 10:06 AM, Shuah Khan wrote: On Fri, 2012-10-26 at 09:45 -0700, David Daney wrote: On 10/26/2012 09:01 AM, Shuah Khan wrote: Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface

Re: [PATCH RFT RESEND linux-next] sparc: dma-mapping: support debug_dma_mapping_error

2012-11-09 Thread Shuah Khan
On Fri, 2012-11-09 at 19:38 -0500, David Miller wrote: From: Shuah Khan shuah.k...@hp.com Date: Fri, 26 Oct 2012 10:13:09 -0600 Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without

Re: [PATCH RFT RESEND linux-next] sparc: dma-mapping: support debug_dma_mapping_error

2012-11-09 Thread Shuah Khan
On Fri, 2012-11-09 at 19:54 -0500, David Miller wrote: From: Shuah Khan shuah.k...@hp.com Date: Fri, 09 Nov 2012 17:52:23 -0700 On Fri, 2012-11-09 at 19:38 -0500, David Miller wrote: From: Shuah Khan shuah.k...@hp.com Date: Fri, 26 Oct 2012 10:13:09 -0600 Add support

NULL pointer dereference at task_numa_fault+0x36/0x140

2012-11-09 Thread Shuah Khan
I ran into NULL pointer dereference at task_numa_fault+0x36/0x140 when I was installing guest OS in a vm in kvm virt env. My test system doesn't have NUMA config and runs with Fake NUMA node: [0.00] ACPI: Local APIC address 0xfee0 [0.00] No NUMA configuration found [

Re: [PATCH 03/11] intel-iommu: Fix AB-BA lockdep report

2012-11-13 Thread Shuah Khan
On Sun, 2011-12-04 at 13:54 -0500, Steven Rostedt wrote: From: Roland Dreier rol...@purestorage.com When unbinding a device so that I could pass it through to a KVM VM, I got the lockdep report below. It looks like a legitimate lock ordering problem: Did this patch not make it into stable

[PATCH] Documentation DMA-API-HOWTO.txt Add dma mapping error check usage examples

2012-10-14 Thread Shuah Khan
mistakes in error paths especially when dma mapping fails when more than one dma mapping call is made. Signed-off-by: Shuah Khan shuah.k...@hp.com --- Documentation/DMA-API-HOWTO.txt | 128 ++- 1 file changed, 127 insertions(+), 1 deletion(-) diff --git

Re: WARNING: at lib/dma-debug.c:948 check_unmap()

2012-10-15 Thread Shuah Khan
On Mon, 2012-10-15 at 01:02 +0800, Fengguang Wu wrote: Hi Shuah, FYI, your debug commit commit 224d4b5563b005836628b1c02ebe374684df118f Author: Shuah Khan shuah.k...@hp.com Date: Fri Oct 12 15:23:05 2012 +1100 dma-debug: new interfaces to debug dma mapping errors triggers

Re: [PATCH 1/1] x86, e820: Remove direct mapping of reserved space for HT hole around 1TB

2012-10-16 Thread Shuah Khan
Jacob, On Tue, 2011-10-11 at 17:09 -0500, Jacob Shin wrote: The entire HT hole and also the unused address range before that hole need to be excluded from direct mapping. Otherwise speculative accesses to that reserved region can happen which cause machine checks. Has the HT support even

Re: [PATCH v3] Prevent devices with RMRRs from being placed into SI Domain during startup

2012-10-16 Thread Shuah Khan
On Tue, 2012-10-16 at 16:50 +, Tom Mingarelli wrote: This patch is to prevent devices that have RMRRs associated with them from getting placed into the SI Domain during init. We don't put USB devices into this category, however. This fixes the issue where the RMRR info for devices being

Re: [PATCH v3] Prevent devices with RMRRs from being placed into SI Domain during startup

2012-10-16 Thread Shuah Khan
On Tue, 2012-10-16 at 16:50 +, Tom Mingarelli wrote: This patch is to prevent devices that have RMRRs associated with them from getting placed into the SI Domain during init. We don't put USB devices into this category, however. This fixes the issue where the RMRR info for devices being

Re: [PATCH 1/1] x86, e820: Remove direct mapping of reserved space for HT hole around 1TB

2012-10-16 Thread Shuah Khan
On Tue, 2012-10-16 at 16:55 +, Shin, Jacob wrote: (Sorry for the top post, on mobile phone..) You can follow the latest thread here: https://lkml.org/lkml/2012/9/30/23 Yinghai's for-x86-mm branch should boot 1TB AMD with hoisting enabled. Thanks! Jacob, Thanks. This includes

Re: [PATCH 1/1] x86, e820: Remove direct mapping of reserved space for HT hole around 1TB

2012-10-17 Thread Shuah Khan
On Tue, 2012-10-16 at 12:02 -0700, H. Peter Anvin wrote: On 10/16/2012 11:26 AM, Jacob Shin wrote: HPA, it would be great if we can first get this patch upstream, and also into the stable trees .. and after that, we can work on getting Yinghai's mm refactoring in .. I'll be back

Re: [PATCH] Documentation DMA-API-HOWTO.txt Add dma mapping error check usage examples

2012-10-18 Thread Shuah Khan
On Thu, 2012-10-18 at 12:13 +0200, Michael Kerrisk (man-pages) wrote: On Thu, Oct 18, 2012 at 11:47 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Sun, Oct 14, 2012 at 09:54:24AM -0600, Shuah Khan wrote: diff --git a/Documentation/DMA-API-HOWTO.txt b/Documentation/DMA-API-HOWTO.txt

Re: [PATCH] lib/dma-debug.c: fix __hash_bucket_find

2012-10-18 Thread Shuah Khan
reliably because only device and dma_addr are passed to dma_mapping_error(). Cc: Joerg Roedel joerg.roe...@amd.com Cc: Shuah Khan shuah.k...@hp.com Cc: Paul Gortmaker paul.gortma...@windriver.com Cc: Andrew Morton a...@linux-foundation.org Cc: Jakub Kicinski kubak...@wp.pl Signed-off-by: Ming

[PATCH v2] Documentation DMA-API-HOWTO.txt Add dma mapping error check usage examples

2012-10-18 Thread Shuah Khan
mistakes in error paths especially when dma mapping fails when more than one dma mapping call is made. Signed-off-by: Shuah Khan shuah.k...@hp.com --- Documentation/DMA-API-HOWTO.txt | 126 +++ 1 file changed, 126 insertions(+) diff --git a/Documentation/DMA-API

Re: [PATCH] leds: Add LED driver for lm3554 chip

2012-07-13 Thread Shuah Khan
On Fri, 2012-07-13 at 18:11 +0900, G.Shark Jeong wrote: From: G.Shark Jeong gshark.je...@gmail.com LM3554 : The LM3554 is a 2 MHz fixed-frequency synchronous boost converter with 1.2A dual high side led drivers. Datasheet: www.ti.com Signed-off-by: G.Shark Jeong gshark.je...@gmail.com

[PATCH TRIVIAL] mm: Fix build warning in kmem_cache_create()

2012-07-13 Thread Shuah Khan
‘kmem_cache_create’: mm/slab_common.c:101:1: warning: label ‘oops’ defined but not used [-Wunused-label] Signed-off-by: Shuah Khan shuah.k...@hp.com --- mm/slab_common.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/slab_common.c b/mm/slab_common.c index 12637ce..aa3ca5b 100644 --- a/mm

Re: [PATCH TRIVIAL] mm: Fix build warning in kmem_cache_create()

2012-07-15 Thread Shuah Khan
On Sat, 2012-07-14 at 15:01 +0300, Pekka Enberg wrote: I'm not exactly loving that either. It'd probably be better to reshuffle the code so that the debug checks end up in separate functions that are no-op for !CONFIG_DEBUG_VM. That way the _labels_ are used unconditionally although there's

Re: [PATCH RFC] swiotlb: Disable swiotlb overflow support when CONFIG_ISA is enabled

2012-07-16 Thread Shuah Khan
On Mon, 2012-07-16 at 10:45 -0400, Konrad Rzeszutek Wilk wrote: On Thu, Jul 12, 2012 at 10:17:50AM -0600, Shuah Khan wrote: Disable iotlb overflow support when CONFIG_ISA is enabled. This is the first step towards removing overflow support, to be consistent with other iommu implementations

Re: [PATCH TRIVIAL] mm: Fix build warning in kmem_cache_create()

2012-07-16 Thread Shuah Khan
On Mon, 2012-07-16 at 09:17 -0500, Christoph Lameter wrote: On Mon, 16 Jul 2012, David Rientjes wrote: On Sun, 15 Jul 2012, Shuah Khan wrote: I can work on reshuffling the code. Do have a question though. This following sanity check is currently done only when CONFIG_DEBUG_VM

Re: [PATCH RFC] swiotlb: Disable swiotlb overflow support when CONFIG_ISA is enabled

2012-07-16 Thread Shuah Khan
On Mon, 2012-07-16 at 12:01 -0400, Konrad Rzeszutek Wilk wrote: On Mon, Jul 16, 2012 at 09:48:20AM -0600, Shuah Khan wrote: On Mon, 2012-07-16 at 10:45 -0400, Konrad Rzeszutek Wilk wrote: On Thu, Jul 12, 2012 at 10:17:50AM -0600, Shuah Khan wrote: Disable iotlb overflow support when

Re: [PATCH TRIVIAL] mm: Fix build warning in kmem_cache_create()

2012-07-17 Thread Shuah Khan
On Tue, 2012-07-17 at 17:46 +0300, Pekka Enberg wrote: On Mon, 16 Jul 2012, David Rientjes wrote: The kernel cannot check everything and will blow up in unexpected ways if someone codes something stupid. There are numerous debugging options that need to be switched on to get better

Re: [PATCH RFC] swiotlb: Disable swiotlb overflow support when CONFIG_ISA is enabled

2012-07-17 Thread Shuah Khan
On Mon, 2012-07-16 at 12:01 -0400, Konrad Rzeszutek Wilk wrote: The first goal is to figure out which of the drivers aren't doing this properly. This should be possible by just grepping for 'dma_map' and seeing which ones don't do the 'dma_check' right after. I did cscope searches

[PATCH] swiotlb: Disable swiotlb overflow support when CONFIG_ISA is disabled

2012-07-17 Thread Shuah Khan
is for finding drivers that don't call dma_mapping_error to check for errors returned by the mapping interface. Once drivers are fixed overflow support can be removed. Signed-off-by: Shuah Khan shuah.k...@hp.com --- Documentation/feature-removal-schedule.txt | 22 ++-- lib/swiotlb.c

Re: [PATCH 1/4] ACPI: Add acpi_pr_level() interfaces

2012-07-18 Thread Shuah Khan
On Wed, 2012-07-18 at 14:40 -0600, Toshi Kani wrote: This patch introduces acpi_pr_level(), where level is a message level such as err/warn/info, to support improved logging messages for ACPI, esp. in hotplug operations. acpi_pr_level() appends ACPI prefix and ACPI object path to the

Re: [PATCH 1/4] ACPI: Add acpi_pr_level() interfaces

2012-07-18 Thread Shuah Khan
On Wed, 2012-07-18 at 16:26 -0600, Toshi Kani wrote: On Wed, 2012-07-18 at 15:59 -0600, Shuah Khan wrote: On Wed, 2012-07-18 at 14:40 -0600, Toshi Kani wrote: This patch introduces acpi_pr_level(), where level is a message level such as err/warn/info, to support improved logging messages

Re: [PATCH 1/4] ACPI: Add acpi_pr_level() interfaces

2012-07-18 Thread Shuah Khan
On Wed, 2012-07-18 at 16:52 -0600, Toshi Kani wrote: On Wed, 2012-07-18 at 16:40 -0600, Shuah Khan wrote: On Wed, 2012-07-18 at 16:26 -0600, Toshi Kani wrote: On Wed, 2012-07-18 at 15:59 -0600, Shuah Khan wrote: On Wed, 2012-07-18 at 14:40 -0600, Toshi Kani wrote: This patch

Re: [PATCH 1/4] ACPI: Add acpi_pr_level() interfaces

2012-07-19 Thread Shuah Khan
On Wed, 2012-07-18 at 18:38 -0600, Toshi Kani wrote: This interface is defined in acpi/acpi_bus.h, which is intended for ACPI drivers which make many ACPI calls to proceed when they are called at run-time today. This interface does not change that, and I believe acpi_get_name() is much

Re: [PATCH 1/4] ACPI: Add acpi_pr_level() interfaces

2012-07-19 Thread Shuah Khan
On Thu, 2012-07-19 at 11:28 -0600, Toshi Kani wrote: On Thu, 2012-07-19 at 10:15 -0600, Shuah Khan wrote: On Wed, 2012-07-18 at 18:38 -0600, Toshi Kani wrote: This interface is defined in acpi/acpi_bus.h, which is intended for ACPI drivers which make many ACPI calls to proceed when

Re: [PATCH 1/4] ACPI: Add acpi_pr_level() interfaces

2012-07-19 Thread Shuah Khan
On Thu, 2012-07-19 at 14:51 -0600, Toshi Kani wrote: If your concern is actually a performance bottleneck in acpi_get_name() you found in the code, you should report it to the ACPI CA team. I have tried my best to get you to understand the problems in bigger picture your patch set can

Re: [ 00/11] 3.0.74-stable review

2013-04-15 Thread Shuah Khan
On Sun, Apr 14, 2013 at 8:17 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: This is the start of the stable review cycle for the 3.0.74 release. There are 11 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied,

Re: [ 00/17] 3.4.41-stable review

2013-04-15 Thread Shuah Khan
On Sun, Apr 14, 2013 at 8:25 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: This is the start of the stable review cycle for the 3.4.41 release. There are 17 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied,

Re: [ 00/27] 3.8.8-stable review

2013-04-15 Thread Shuah Khan
On Sun, Apr 14, 2013 at 8:42 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: This is the start of the stable review cycle for the 3.8.8 release. There are 27 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please

Re: [PATCH 8/9] iommu/amd: Don't report firmware bugs with cmd-line ivrs overrides

2013-04-10 Thread Shuah Khan
On Tue, Apr 9, 2013 at 2:13 PM, Joerg Roedel j...@8bytes.org wrote: When the IVRS entries for IOAPIC and HPET are overridden on the kernel command line, a problem detected in the check function might not be a firmware bug anymore. So disable the firmware bug reporting if the user provided

Re: [PATCH 1/9] iommu/amd: Remove map_sg_no_iommu()

2013-04-10 Thread Shuah Khan
. Signed-off-by: Joerg Roedel j...@8bytes.org --- Reviewed-by: Shuah Khan shuahk...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH 2/9] iommu/amd: Use AMD specific data structure for irq remapping

2013-04-10 Thread Shuah Khan
. Signed-off-by: Joerg Roedel j...@8bytes.org --- Reviewed-by: Shuah Khan shuahk...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH 0/9] AMD IOMMU cleanups, fixes and IVRS bug workarounds

2013-04-10 Thread Shuah Khan
to test machine. :( Reviewed-by: Shuah Khan shuahk...@gmail.com -- Shuah -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 2/2 V5] iommu/amd: Add logic to decode AMD IOMMU event flag

2013-04-10 Thread Shuah Khan
On Wed, Apr 10, 2013 at 10:27 AM, Suravee Suthikulanit suravee.suthikulpa...@amd.com wrote: On 4/10/2013 11:21 AM, Shuah Khan wrote: Good feature. Do you also plan to add decode logic for these flags. For example, RZ is only meaningful when PR=1, RW is only meaningful when PR=1, TR=0, and I

Re: [ 00/19] 3.0.73-stable review

2013-04-11 Thread Shuah Khan
On Wed, Apr 10, 2013 at 4:50 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: This is the start of the stable review cycle for the 3.0.73 release. There are 19 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied,

Re: [ 00/29] 3.4.40-stable review

2013-04-11 Thread Shuah Khan
On Wed, Apr 10, 2013 at 4:49 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: This is the start of the stable review cycle for the 3.4.40 release. There are 29 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied,

  1   2   3   4   5   6   7   8   9   10   >