sporadic
connectivity.
The patch was reverted in this patch:
c4fb19d21b003ec99ec490ba2cb60baffabc73f3
And superceded by this one:
87421cb6010a2f6494938fbe0a95e1b096b3b7af
(Out of Linus's upstream tree)
- Solomon
--
Solomon Peachy pizza at shaftnet dot org
ote debugging in this
situation, as I'm sure you know.
Thanks for getting the patches into -stable!
- Solomon
--
Solomon Peachy pizza at shaftnet dot org
Delray Beach, FL ^^ (email/xmpp) ^^
Quidquid latine dictum sit, altum viditur.
pgpyarUS
uiltin_fw'
This trivial patch fixes this oversight.
Signed-off-by: Solomon Peachy
CC: sta...@vger.kernel.org
---
drivers/base/firmware_class.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index 8945f4e..3474
ur .config?
The corresponding .config is attached. Note that it is for a uClinux
3.3.0-uc0 kernel.
Even in the absence of the compile error, I believe the patch is correct.
- Solomon
--
Solomon Peachy pizza at shaftnet dot org
Melbourne, FL
mpty builtin firmware list?) but the #ifdef is still
incorrect.
> Also, when sending patches, please cc: the proper maintainers (the
> scripts/get_maintainers.pl tool can help you with that.)
Ooops, sorry. I'll double-check that next time.
- Solomon
--
Solomon Peachy
ainder.
>
> Signed-off-by: Joe Perches
Acked-By: Solomon Peachy
> ---
> drivers/net/wireless/cw1200/hwio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/cw1200/hwio.c
> b/drivers/net/wireless/cw1200/hwio.c
> index 142f45ef..dad3fb3 1006
;ref_clk' field.
This would need to be made available to the probe() call (eg via
func->dev.platform_data) but from what I can tell there's currently no
mechanism to make that connection.
Anyway, it's time for bed.
- Solomon
--
Solomon Peachy pizza at sha
e in order to support
the variety of hardware designs already in the wild.
This driver will also be part of the compat-drivers/backports project,
and as such has to work within that framework as well.
If you have constructive suggestions on how to handle this set of
requirements in a cleaner
On Sun, Jun 02, 2013 at 08:29:54AM -0400, Solomon Peachy wrote:
> > * Add comments about passing GPIO numbers in platform_data:
> > You should not use IORESOURCE_IO, which is for legacy ISA
> > I/O ports on PCs, not for GPIOs.
>
> Fair enough. The use of resources
build.
I'll convert SDIO driver to using the sagrad data as default and add a
'set_platform_data' sort of function to allow it to be optionally
overridden. It shouldn't take long, and I'll post the patch as soon as
I'm finished.
(I don't know how lon
.
I can update my patch to include this, and rewrite the commit message so
it's relevant to modern kernels, or I can just drop this and forget the
whole affair.
- Solomon
--
Solomon Peachy pizza at shaftnet dot org
Melbourne, FL
*fw)
-{
- return false;
-}
-#endif
-
enum {
FW_STATUS_LOADING,
FW_STATUS_DONE,
The empty stub functions can never be compiled, as firmware_class.c
isn't compiled when CONFIG_FW_LOADER isn't enabled. So let's just nuke
this unused code entirely.
- Solomon
--
> + if (ret < 0)
> > + return ret;
> > +
> > + if (ret > 0)
> > + cw1200_bh_wakeup(priv);
>
> That doesn't look equivalent to me (when count == 1).
I concur, this patch should not be applied in its current form.
- Solomon
--
Solomon Peachy
13 matches
Mail list logo
