Looks good to me.
Reviewed-by: Subhash Jadavani
On 8/25/2013 4:06 PM, Dolev Raviv wrote:
In interrupt context, after reading and comparing the UTRLDBR to
hba->outstanding_request and before resetting the interrupt aggregation,
there might be completion of another transfer request (TR). S
On 8/27/2013 1:50 PM, Subhash Jadavani wrote:
Looks good to me.
Reviewed-by: Subhash Jadavani
On 8/25/2013 4:06 PM, Dolev Raviv wrote:
In interrupt context, after reading and comparing the UTRLDBR to
hba->outstanding_request and before resetting the interrupt aggregation,
there might
Thanks Maya. Looks good to me.
Reviewed-by: subha...@codeaurora.org
Regards,
Subhash
On 10/5/2012 3:58 AM, Maya Erez wrote:
Devices have various maintenance operations need to perform internally.
In order to reduce latencies during time critical operations like read
and write, it is better to
-gather nodes.
Signed-off-by: Subhash Jadavani
---
block/blk-merge.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/block/blk-merge.c b/block/blk-merge.c
index 936a110..623fca5 100644
--- a/block/blk-merge.c
+++ b/block/blk-merge.c
@@ -42,6 +42,9 @@ static unsigned
On 1/12/2013 2:12 AM, Maya Erez wrote:
mmc_cache_ctrl was called in runtime suspend before MMC interrupted
BKOPS in case it is still running on the card. This caused the cache
disable to timeout.
I guess even if the idle time bkops polling is not implemented, this
patch is good to have. cache co
-gather nodes.
Signed-off-by: Subhash Jadavani
---
block/blk-merge.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/block/blk-merge.c b/block/blk-merge.c
index 936a110..6eaef3d4 100644
--- a/block/blk-merge.c
+++ b/block/blk-merge.c
@@ -42,6 +42,9 @@ static unsigned
On 1/15/2013 9:49 PM, James Bottomley wrote:
On Tue, 2013-01-15 at 21:31 +0530, Subhash Jadavani wrote:
blk_rq_map_sg() function merges the physically contiguous pages to use same
scatter-gather node without checking if their page descriptors are
contiguous or not.
Now when dma_map_sg() is
On 1/16/2013 4:02 PM, James Bottomley wrote:
On Wed, 2013-01-16 at 12:07 +0530, Subhash Jadavani wrote:
Now consider this call stack from MMC block driver (this is on the ARmv7
based board):
[ 98.918174] [] (v7_dma_inv_range+0x30/0x48) from
[] (dma_cache_maint_page+0x1c4/0x24c
As Maya is going to fix the commit text,
Acked-by: Subhash Jadavani
On 1/17/2013 12:18 PM, Seungwon Jeon wrote:
On Thursday, January 17, 2013 , Ulf Hansson wrote:
On 13 January 2013 22:47, Maya Erez wrote:
-Original Message-
From: Subhash Jadavani [mailto:subha...@codeaurora.org
oblem test this patch?
Yes, this patch also fixes the issue. You may add: Tested-by: Subhash
Jadavani .
Regards,
Subhash
arch/arm/mm/dma-mapping.c | 18 ++
1 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.
X_MODEL_LEN] = '\0';
out:
+ kfree(desc_buf);
return err;
}
--
2.17.0
Looks good to me.
Reviewed-by: Subhash Jadavani
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
On 2018-05-03 04:07, Asutosh Das wrote:
From: Yaniv Gardi
Due to M-PHY issues, moving from HS to any other mode or gear or
even Hibern8 may cause some un-predicted behavior
of the device.
This patch adds provides a quirk to address that.
Signed-off-by: Yaniv Gardi
Signed-off-by: Subhash
On 2018-05-03 04:07, Asutosh Das wrote:
Enable UFSHCD_QUIRK_BROKEN_PWR_MODE_CHANGE quirk to avoid failures
in seen on some UFS devices.
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufs-qcom.c b/d
we don't want to disable the LCC
on both host & device; hence this change splits the quirk in 2 parts
one for host and one for device.
Signed-off-by: Subhash Jadavani
Signed-off-by: Venkat Gopalakrishnan
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufsh
retransmissions of the query requests,
in case of timeout.
Signed-off-by: Subhash Jadavani
Signed-off-by: Maya Erez
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufshcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs
On 2018-05-03 04:07, Asutosh Das wrote:
From: Subhash Jadavani
vendor specific setup_clocks ops may depend on clocks managed by ufshcd
driver so if the vendor specific setup_clocks callback is called when
the required clocks are turned off, it results into unclocked register
access.
This
On 2018-05-03 04:07, Asutosh Das wrote:
From: Subhash Jadavani
Currently we call the scsi_block_requests()/scsi_unblock_requests()
whenever we want to block/unblock scsi requests but as there is no
reference counting, nesting of these calls could leave us in undesired
state sometime. Consider
On 2018-05-03 04:07, Asutosh Das wrote:
From: Subhash Jadavani
UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION is only applicable for QCOM UFS
host
controller version 2.x.y and this has been fixed from version 3.x.y
onwards, hence this change removes this quirk for version 3.x.y
onwards.
Signed-off
_unlock(hba->host->host_lock);
return retval;
}
Looks good to me.
Reviewed-by: Subhash Jadavani
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
i/ufs/ufshcd.h
@@ -361,6 +361,7 @@ struct ufs_clk_gating {
struct device_attribute enable_attr;
bool is_enabled;
int active_reqs;
+ struct workqueue_struct *clk_gating_workq;
};
struct ufs_saved_pwr_info {
Looks good to me.
Reviewed-by: Subhash Jadavani
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
caling.workq);
+ ufshcd_devfreq_remove(hba);
}
ufshcd_setup_clocks(hba, false);
ufshcd_setup_hba_vreg(hba, false);
Looks good to me.
Reviewed-by: Subhash Jadavani
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
ist is just opposite.
+*/
+ #define UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR0x100
+
unsigned int quirks;/* Deviations from standard UFSHCI spec. */
/* Device deviations from standard UFS device spec. */
Looks good to me.
Reviewed-by: Subhash Jadavani
UIRK_SKIP_RESET_INTR_AGGR 0x200
+
unsigned int quirks;/* Deviations from standard UFSHCI spec. */
/* Device deviations from standard UFS device spec. */
Looks good to me.
Reviewed-by: Subhash Jadavani
--
The Qualcomm Innovation Center, Inc. is a member of C
ks;/* Deviations from standard UFSHCI spec. */
/* Device deviations from standard UFS device spec. */
Looks good to me.
Reviewed-by: Subhash Jadavani
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
);
+extern int ufshcd_config_pwr_mode(struct ufs_hba *hba,
+ struct ufs_pa_layer_attr *desired_pwr_mode);
/* UIC command interfaces for DME primitives */
#define DME_LOCAL 0
Looks good to me.
Reviewed-by: Subhash Jadavani
--
The Qualcomm Innovation Center, Inc. is a
On 2018-05-15 21:31, Alim Akhtar wrote:
Ping !!!
On Thu, Mar 8, 2018 at 4:33 PM, Alim Akhtar
wrote:
Currently DMA mask for UFS HCI is set by reading CAP register's
[64AS] bit. Some HCI controller like Exynos support 36-bit bus
address.
This works perfectly fine with DMA mask set as 64 in ca
goto out;
- }
}
hba->clk_scaling.is_allowed = true;
}
Looks good to me.
Reviewed-by: Subhash Jadavani
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
t;freq_table[0] = clki->min_freq;
+ profile->freq_table[1] = clki->max_freq;
+
devfreq = devm_devfreq_add_device(hba->dev,
- &ufs_devfreq_profile,
+ profile,
"simple_ondemand",
From: Yaniv Gardi
The UFS HCI v2.1 includes a few additional registers. This change
updates the HCI register, the UFS version register content and
the Interrupt Status register.
Signed-off-by: Yaniv Gardi
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 29
From: Yaniv Gardi
In case UFS driver is probed before the phy driver does, the
UFS driver should return a PROBE_DEFER code.
Signed-off-by: Yaniv Gardi
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs-qcom.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git
increase PA_SaveConfigTime to >32us as per vendor recommendation.
This change adds a quirk to increase the PA_SaveConfigTime parameter.
Reviewed-by: Venkat Gopalakrishnan
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs-qcom.c | 30 ++
drivers/scsi/ufs/
ufs_qcom_print_hw_debug_reg_all() function is having a bug
where it might incorrectly modify undesired bits in UFS_CFG1 register,
this change fixes it.
Reviewed-by: Venkat Gopalakrishnan
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs-qcom.c | 3 ++-
1 file changed, 2 insertions(+), 1
From: Yaniv Gardi
When sending query to the device, the index of the failure
is additional useful information that should be printed out as it
might specify the logical unit (LU) where the error occurred.
Signed-off-by: Yaniv Gardi
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs
From: Dolev Raviv
Some of the queries might fail during init. To avoid
system failure, we add retry mechanism to issue queries
several times.
Signed-off-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 54 +++
1 file
this issue.
Signed-off-by: Yaniv Gardi
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index ec4c99a..b826078 100644
--- a/drivers/scsi/ufs/ufshcd.c
f UFS device responds back with 2 resposes on same tag, host HW/SW
behaviour isn't predictable.
To avoid running into above scenario, we would basically allow device
to take longer (upto 1.5 seconds) for query response.
Reviewed-by: Gilad Broner
Signed-off-by: Subhash Jadavani
---
driver
Some UFS devices require host PA_TACTIVATE to be higher than
device PA_TACTIVATE otherwise it may get stuck during hibern8 sequence.
This change allows this by using quirk.
Reviewed-by: Venkat Gopalakrishnan
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs_quirks.h | 9 ++
drivers
adding proper state checks in
ufshcd_system_suspend().
Reviewed-by: Gilad Broner
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index b8
t the
correct size as part of Query Request UPIU).
Reviewed-by: Venkat Gopalakrishnan
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 40 +++-
1 file changed, 31 insertions(+), 9 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/driv
would have to issue the link startup 2
times to make sure that device moves to active state.
Reviewed-by: Gilad Broner
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 23 ---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/ufs
other than clearing the register is necessary.
Signed-off-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 11 +++
drivers/scsi/ufs/ufshci.h | 1 +
2 files changed, 12 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index
From: Yaniv Gardi
According to JESD220B - UFS v2.0, the maximum size of device descriptor
has changed from 0x1F to 0x40. This patch updates the maximum size of
this descriptor.
Signed-off-by: Yaniv Gardi
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs.h | 2 +-
1 file changed, 1
We would by default like to run in FAST/SLOW mode instead
of FASTAUTO/SLOWAUTO mode for performance reasons. This
change sets the default speed mode to FAST/SLOW mode.
Reviewed-by: Venkat Gopalakrishnan
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 8
1 file changed
acknowledge the fact that "name" is always a constant string and we
don't actually need to create a local copy of it, but rather just
reference the constant string.
Cc: Subhash Jadavani
Cc: Vivek Gautam
Signed-off-by: Bjorn Andersson
---
drivers/phy/phy-qcom-ufs.c | 9 +
1
should not ignore errors upon failing to acquire the
optional "vddp-ref-clk" supply.
Cc: Subhash Jadavani
Cc: Vivek Gautam
Signed-off-by: Bjorn Andersson
---
drivers/phy/phy-qcom-ufs.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers/ph
when this occur.
Cc: Subhash Jadavani
Cc: Vivek Gautam
Signed-off-by: Bjorn Andersson
---
drivers/phy/phy-qcom-ufs-qmp-14nm.c | 15 +++
drivers/phy/phy-qcom-ufs-qmp-20nm.c | 12 ++--
2 files changed, 5 insertions(+), 22 deletions(-)
diff --git a/drivers/phy/phy-qcom-ufs-qmp
regulator should be always on in a particular device,
mark it so by specifying "regulator-always-on" in the regulator node.
Cc: Subhash Jadavani
Cc: Vivek Gautam
Signed-off-by: Bjorn Andersson
---
Documentation/devicetree/bindings/ufs/ufs-qcom.txt | 1 -
drivers/phy/phy-qc
be retried once next scaling
window expires.
Reviewed-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 32
1 file changed, 32 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 304adce..5c93
etach.
Reviewed-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd-pci.c| 2 ++
drivers/scsi/ufs/ufshcd-pltfrm.c | 5 +
drivers/scsi/ufs/ufshcd.c| 3 ---
3 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/dr
they are still in LPM mode) causing voltage drop
on these rails. This change fixes this issue by bringing VCCQ & VCCQ2 rails
out of LPM before powering on VCC rail.
Reviewed-by: Venkat Gopalakrishnan
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file change
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 6c0082e..9ed96ae 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
"simple_ondemand", NULL);
if (IS_ERR(hba->devfreq)) {
dev_err(hba->dev, "Unable to register with devfreq
%ld\n",
LGTM.
Reviewed-by: Subhash Jadavani
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
be retried once next scaling
window expires.
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 32
1 file changed, 32 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 571a2f6..77700ee 100644
--- a/drivers/scsi/uf
On 2016-10-13 10:23, Joao Pinto wrote:
Signed-off-by: Joao Pinto
---
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5ac91d8a..d9855b5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12084,7 +12084,8 @@ F: Documentation/scsi/
change makes sure that
required clocks remain enabled before calling into vendor specific
setup_clocks callback.
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
change makes sure that
required clocks remain enabled before calling into vendor specific
setup_clocks callback.
Signed-off-by: Subhash Jadavani
---
Changes from v2:
* Don't call ufshcd_vops_setup_clocks() again for clock off
---
drivers/scsi/ufs/ufshcd.c | 22 +-
1 file ch
register access, this change makes sure
that
required clocks remain enabled before calling into vendor specific
setup_clocks callback.
Signed-off-by: Subhash Jadavani
---
Changes from v2:
* Don't call ufshcd_vops_setup_clocks() again for clock off
---
drivers/scsi/ufs/ufshcd.c
be retried once next scaling
window expires.
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 32
1 file changed, 32 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 05c7456..4011887 100644
--- a/drivers/scsi/uf
ck register access, this change makes sure
>> that
>> required clocks remain enabled before calling into vendor specific
>> setup_clocks callback.
>>
>> Signed-off-by: Subhash Jadavani
>> ---
>> Changes from v2:
>> * Don't call ufshcd_vops_setup
change adds one more
argument to setup_clocks callback to let it know whether it is called
pre/post the clock changes by core driver.
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs-qcom.c | 10 ++
drivers/scsi/ufs/ufshcd.c | 17 -
drivers/scsi/ufs/ufshcd.h | 8
change adds one more
argument to setup_clocks callback to let it know whether it is called
pre/post the clock changes by core driver.
Signed-off-by: Subhash Jadavani
---
Changes from v2:
* Added one more argument to setup_clocks callback, this should address
Kiwoong Kim's comments on v2.
Ch
On 2016-12-19 10:38, Rob Herring wrote:
On Tue, Dec 13, 2016 at 2:16 PM, Subhash Jadavani
wrote:
On 2016-12-13 12:04, Rob Herring wrote:
On Mon, Dec 12, 2016 at 04:54:20PM -0800, Subhash Jadavani wrote:
UFS device and link can be put in multiple different low power modes
hence
UFS driver
From: Dolev Raviv
Inserts driver dumps for UFS Host Controller registers, Transfer Requests
and Task Management Requests.
The dumps will occur on driver initialization failure, ufshcd_abort() and
on error handling path.
Signed-off-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
---
Changes
From: Sahitya Tummala
Provide an option to enable/disable clock scaling during runtime.
Write 1/0 to "clkscale_enable" sysfs node to enable/disable clock
scaling.
Signed-off-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs
are skipped
and the last step, reset and restore process, is initiated.
Signed-off-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs
ing/trace_pipe
Reviewed-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
Changes from v2 -> v3:
- Used TRACE_DEFINE_ENUM to print out enums
---
drivers/scsi/ufs/ufshcd.c | 85 ++---
include/trace/events/ufs.h | 185 +
2 files change
From: Sahitya Tummala
Provide an option to enable/disable clock gating during runtime.
Write 1 or 0 to "clkgate_enable" sysfs node to enable/disable
clock gating.
Signed-off-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs
ts/ufs/enable
cat /sys/kernel/debug/tracing/trace_pipe
Signed-off-by: Lee Susman
Signed-off-by: Subhash Jadavani
---
Changes from v2 -> v3:
- Removed conditional compilation based on CONFIG_TRACEPOINTS and
used trace_*_enabled() to skip unnecessary code path execution.
---
drivers/scsi/uf
This patch provides the sysfs attribute to choose the power management
level for UFS runtime and system suspend.
Reviewed-by: Sujit Reddy Thumma
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 144 ++
drivers/scsi/ufs/ufshcd.h | 2
: Subhash Jadavani
---
Changes from v1 -> v2:
- Added explicit new line character at the end of the printk messages.
---
drivers/scsi/ufs/ufshcd.c | 203 --
drivers/scsi/ufs/ufshcd.h | 47 +++
2 files changed, 208 insertions(+), 42 deletions(-)
d
good power savings with relatively less enter/exit
latencies.
Reviewed-by: Yaniv Gardi
Signed-off-by: Subhash Jadavani
---
Changes from v2 -> v3:
- Simplified patch to just set the default power management level.
Device tree capability to specify broken hardware will be taken up
doing any
regular data transfer but sometimes device may not behave properly if host
keeps the auto-bkops disabled. This change adds the capability to let the
device auto-bkops always enabled except suspend.
Reviewed-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs
.
Above issue is fixed by setting the default power mode immediately after
successful link startup.
Reviewed-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drive
This patch adds the profiling support for some of the time critical
operations like hibern8 enter/exit, clock gating & clock scaling.
Reviewed-by: Venkat Gopalakrishnan
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 24
include/trace/events/ufs.h
On 2016-10-26 00:38, Chanwoo Choi wrote:
This patch uses the resource-managed to add the devfreq device.
This function will make it easy to handle the devfreq device.
- struct devfreq *devm_devfreq_add_device(struct device *dev,
struct devfreq_dev_profile *profi
_device_id
ufs_qcom_of_match[] = {
{ .compatible = "qcom,ufshc"},
{},
};
+MODULE_DEVICE_TABLE(of, ufs_qcom_of_match);
static const struct dev_pm_ops ufs_qcom_pm_ops = {
.suspend= ufshcd_pltfrm_suspend,
Looks good to me.
Reviewed-by: Subhash Jadavani
--
The
From: Dolev Raviv
Inserts driver dumps for UFS Host Controller registers, Transfer Requests
and Task Management Requests.
The dumps will occur on driver initialization failure, ufshcd_abort() and
on error handling path.
Signed-off-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
---
drivers
ing/trace_pipe
Reviewed-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 133
include/trace/events/ufs.h | 149 +
2 files changed, 270 insertions(+), 12 deletions(-)
create mode 100
are skipped
and the last step, reset and restore process, is initiated.
Signed-off-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs
From: Sahitya Tummala
Provide an option to enable/disable clock gating during runtime.
Write 1 or 0 to "clkgate_enable" sysfs node to enable/disable
clock gating.
Signed-off-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs
From: Sahitya Tummala
Provide an option to enable/disable clock scaling during runtime.
Write 1/0 to "clkscale_enable" sysfs node to enable/disable clock
scaling.
Signed-off-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs
This patch provides the sysfs attribute to choose the power management
level for UFS runtime and system suspend.
Reviewed-by: Sujit Reddy Thumma
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 122 ++
drivers/scsi/ufs/ufshcd.h | 2
have to tune this default power mode for different chipset
platforms to meet the low power requirements/goals. Hence this patch
adds option to change default UFS low power mode (level).
Reviewed-by: Yaniv Gardi
Signed-off-by: Subhash Jadavani
---
.../devicetree/bindings/ufs/ufshcd-pltfrm.txt
doing any
regular data transfer but sometimes device may not behave properly if host
keeps the auto-bkops disabled. This change adds the capability to let the
device auto-bkops always enabled except suspend.
Reviewed-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs
.
Above issue is fixed by setting the default power mode immediately after
successful link startup.
Reviewed-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drive
This patch adds the profiling support for some of the time critical
operations like hibern8 enter/exit, clock gating & clock scaling.
Reviewed-by: Venkat Gopalakrishnan
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 24
include/trace/events/ufs.h
ts/ufs/enable
cat /sys/kernel/debug/tracing/trace_pipe
Signed-off-by: Lee Susman
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 52 +-
include/trace/events/ufs.h | 38 +
2 files changed, 89 insertions(+
: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 202 --
drivers/scsi/ufs/ufshcd.h | 47 +++
2 files changed, 207 insertions(+), 42 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index c19cf40..c13549f 100644
--- a
On 2016-12-12 17:19, Joe Perches wrote:
On Mon, 2016-12-12 at 16:56 -0800, Subhash Jadavani wrote:
Errors such as UIC error, illegal OCS values, and others may require
more information for debugging. Such information could be hibern8
events,
events sequences, recoverable errors, error history
ing/trace_pipe
Reviewed-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 133
include/trace/events/ufs.h | 149 +
2 files changed, 270 insertions(+), 12 deletions(-)
create mode 100
From: Sahitya Tummala
Provide an option to enable/disable clock scaling during runtime.
Write 1/0 to "clkscale_enable" sysfs node to enable/disable clock
scaling.
Signed-off-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs
From: Sahitya Tummala
Provide an option to enable/disable clock gating during runtime.
Write 1 or 0 to "clkgate_enable" sysfs node to enable/disable
clock gating.
Signed-off-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs
This patch provides the sysfs attribute to choose the power management
level for UFS runtime and system suspend.
Reviewed-by: Sujit Reddy Thumma
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 122 ++
drivers/scsi/ufs/ufshcd.h | 2
are skipped
and the last step, reset and restore process, is initiated.
Signed-off-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs
.
Above issue is fixed by setting the default power mode immediately after
successful link startup.
Reviewed-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drive
: Subhash Jadavani
---
Changes v1 -> v2:
- Added explicit new line character at the end of the printk messages.
---
drivers/scsi/ufs/ufshcd.c | 203 --
drivers/scsi/ufs/ufshcd.h | 47 +++
2 files changed, 208 insertions(+), 42 deletions(-)
diff --
have to tune this default power mode for different chipset
platforms to meet the low power requirements/goals. Hence this patch
adds option to change default UFS low power mode (level).
Reviewed-by: Yaniv Gardi
Signed-off-by: Subhash Jadavani
---
.../devicetree/bindings/ufs/ufshcd-pltfrm.txt
ts/ufs/enable
cat /sys/kernel/debug/tracing/trace_pipe
Signed-off-by: Lee Susman
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 52 +-
include/trace/events/ufs.h | 38 +
2 files changed, 89 insertions(+
doing any
regular data transfer but sometimes device may not behave properly if host
keeps the auto-bkops disabled. This change adds the capability to let the
device auto-bkops always enabled except suspend.
Reviewed-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs
This patch adds the profiling support for some of the time critical
operations like hibern8 enter/exit, clock gating & clock scaling.
Reviewed-by: Venkat Gopalakrishnan
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 24
include/trace/events/ufs.h
1 - 100 of 161 matches
Mail list logo
