Re: [PATCH v3] sched/fair: fix unthrottle_cfs_rq for leaf_cfs_rq list

2020-11-18 Thread Tao Zhou
Hi Guilherme, On Wed, Nov 18, 2020 at 07:56:38PM -0300, Guilherme G. Piccoli wrote: > Hi Vincent (and all CCed), I'm sorry to ping about such "old" patch, but > we experienced a similar condition to what this patch addresses; it's an > older kernel (4.15.x) but when suggesting the users to move to

Re: [PATCH v3] sched/fair: fix unthrottle_cfs_rq for leaf_cfs_rq list

2020-11-18 Thread Tao Zhou
On Wed, Nov 18, 2020 at 07:56:38PM -0300, Guilherme G. Piccoli wrote: > Hi Vincent (and all CCed), I'm sorry to ping about such "old" patch, but > we experienced a similar condition to what this patch addresses; it's an > older kernel (4.15.x) but when suggesting the users to move to an > updated 5

Re: [PATCH v3] sched/fair: fix unthrottle_cfs_rq for leaf_cfs_rq list

2020-11-18 Thread Tao Zhou
On Thu, Nov 19, 2020 at 07:50:15AM +0800, Tao Zhou wrote: > On Wed, Nov 18, 2020 at 07:56:38PM -0300, Guilherme G. Piccoli wrote: > > Hi Vincent (and all CCed), I'm sorry to ping about such "old" patch, but > > we experienced a similar condition to what this patc

[PATCH] rbtree: correct comments about rotation operation

2015-12-17 Thread Tao Zhou
The rotation operation is symmetric. So the comments about rotation operation need to be corrected. Signed-off-by: Tao Zhou --- lib/rbtree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/rbtree.c b/lib/rbtree.c index 1356454..750cfa8 100644 --- a/lib/rbtree.c

Re: [PATCH] sched/core: Add missing completion for affine_move_task() waiters

2020-11-15 Thread Tao Zhou
Hi, On Fri, Nov 13, 2020 at 11:24:14AM +, Valentin Schneider wrote: > Qian reported that some fuzzer issuing sched_setaffinity() ends up stuck on > a wait_for_completion(). The problematic pattern seems to be: > affine_move_task() > // task_running() case > stop_one_cpu(); >

Re: [PATCH v3] sched: revise the initial value of the util_avg.

2020-11-06 Thread Tao Zhou
On Fri, Nov 06, 2020 at 11:22:03AM +0800, Xuewen Yan wrote: > According to the original code logic: > cfs_rq->avg.util_avg > sa->util_avg = * se->load.weight > cfs_rq->avg.load_avg > but for fair_sched_class in 64bits platform: > se->load.weight =

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-08 Thread Tao Zhou
Hi Phil, On Thu, May 07, 2020 at 04:36:12PM -0400, Phil Auld wrote: > sched/fair: Fix enqueue_task_fair warning some more > > The recent patch, fe61468b2cb (sched/fair: Fix enqueue_task_fair warning) > did not fully resolve the issues with the rq->tmp_alone_branch != > &rq->leaf_cfs_rq_list warni

Re: [RFC PATCH v3 2/3] docs: scheduler: Add scheduler overview documentation

2020-05-08 Thread Tao Zhou
Hi John, On Thu, May 07, 2020 at 09:05:52PM +0300, John Mathew wrote: > Add documentation for > -scheduler overview > -scheduler state transtion > -CFS overview > -scheduler data structs > > Add rst for scheduler APIs and modify sched/core.c > to add kernel-doc comments. > > Suggested-by: Lu

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-08 Thread Tao Zhou
On Fri, May 08, 2020 at 05:27:44PM +0200, Vincent Guittot wrote: > On Fri, 8 May 2020 at 17:12, Tao Zhou wrote: > > > > Hi Phil, > > > > On Thu, May 07, 2020 at 04:36:12PM -0400, Phil Auld wrote: > > > sched/fair: Fix enqueue_task_fair warning some more >