[PATCH] sched_clock: Prevent 64bit inatomicity on 32bit systems

2013-04-06 Thread Thomas Gleixner
-by: Siegfried Wulsch siegfried.wul...@rovema.de Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: sta...@vger.kernel.org --- Index: linux-stable/kernel/sched/clock.c === --- linux.orig/kernel/sched/clock.c +++ linux/kernel/sched/clock.c

Re: kernel BUG at kernel/smpboot.c:134!

2013-04-06 Thread Thomas Gleixner
On Sat, 6 Apr 2013, Srivatsa S. Bhat wrote: Hi Dave, On 04/06/2013 03:13 AM, Dave Hansen wrote: Hey Thomas, I seem to be running in to smpboot_thread_fn()'s BUG_ON(td-cpu != smp_processor_id()); That should be WARN_ON of course. Stupid me. pretty regularly, both at boot

Re: kernel BUG at kernel/smpboot.c:134!

2013-04-07 Thread Thomas Gleixner
On Sat, 6 Apr 2013, Thomas Gleixner wrote: This is Hillfs proposed patch: --- a/kernel/kthread.c Sat Jan 19 13:03:52 2013 +++ b/kernel/kthread.c Sat Jan 19 13:17:54 2013 @@ -306,6 +306,7 @@ struct task_struct *kthread_create_on_cp return p; set_bit

Re: kernel BUG at kernel/smpboot.c:134!

2013-04-08 Thread Thomas Gleixner
On Sun, 7 Apr 2013, Borislav Petkov wrote: On Sun, Apr 07, 2013 at 11:20:10AM +0200, Thomas Gleixner wrote: And it's even more bogus because the cpu to which we would bind in kthread_create_on_cpu() is not yet online. In case you guys are wondering about reproducibility, I saw the same

Re: kernel BUG at kernel/smpboot.c:134!

2013-04-08 Thread Thomas Gleixner
On Mon, 8 Apr 2013, Borislav Petkov wrote: On Mon, Apr 08, 2013 at 11:24:14AM +0200, Thomas Gleixner wrote: + /* Rebind ourself to the target cpu */ + if (test_bit(KTHREAD_IS_PER_CPU, self-flags)) { + set_cpus_allowed_ptr(currrent, cpumask_of(self-cpu)); currrent is a typo

Re: [PATCH] Clean up kernel/timer.c

2013-04-09 Thread Thomas Gleixner
wrote this thing? Hehe :) Move some non timer related syscalls to kernel/sys.c Signed-off-by: Stephen Rothwell s...@canb.auug.org.au Acked-by: Thomas Gleixner t...@linutronix.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [patch 08/34] arm: Use generic idle loop

2013-04-09 Thread Thomas Gleixner
Russell, On Mon, 8 Apr 2013, Russell King - ARM Linux wrote: On Mon, Mar 25, 2013 at 03:02:39PM +0100, Thomas Gleixner wrote: So, how can I review these changes when all there is is a git URL, and I *do* not want to pull them into my tree without first looking at the patches, possibly

Re: [PATCH] x86: make IDT read-only

2013-04-09 Thread Thomas Gleixner
On Mon, 8 Apr 2013, H. Peter Anvin wrote: On 04/08/2013 03:43 PM, Kees Cook wrote: This makes the IDT unconditionally read-only. This primarily removes the IDT from being a target for arbitrary memory write attacks. It has an added benefit of also not leaking (via the sidt instruction) the

[PATCH] kthread: Prevent unpark race which puts threads on the wrong cpu

2013-04-09 Thread Thomas Gleixner
wakeups and use this state explicitely for the unpark wakeup. Reported-by: Dave Jones da...@redhat.com Reported-by: Dave Hansen d...@sr71.net Reported-by: Borislav Petkov b...@alien8.de Cc: sta...@vger.kernel.org Signed-off-by: Thomas Gleixner t...@linutronix.de --- fs/proc/array.c |1

Re: [PATCH] kthread: Prevent unpark race which puts threads on the wrong cpu

2013-04-09 Thread Thomas Gleixner
Dave, On Tue, 9 Apr 2013, Dave Hansen wrote: Hey Thomas, I don't think the patch helped my case. Looks like the same BUG_ON(). I accidentally booted with possible_cpus=10 instead of 160. I wasn't able to trigger this in that case, even repeatedly on/offlining them. But, once I booted

Re: [PATCH] kthread: Prevent unpark race which puts threads on the wrong cpu

2013-04-09 Thread Thomas Gleixner
On Tue, 9 Apr 2013, Thomas Gleixner wrote: Dave, On Tue, 9 Apr 2013, Dave Hansen wrote: Hey Thomas, I don't think the patch helped my case. Looks like the same BUG_ON(). I accidentally booted with possible_cpus=10 instead of 160. I wasn't able to trigger this in that case

Re: [PATCH] kthread: Prevent unpark race which puts threads on the wrong cpu

2013-04-10 Thread Thomas Gleixner
On Tue, 9 Apr 2013, Dave Hansen wrote: On 04/09/2013 12:30 PM, Thomas Gleixner wrote: On Tue, 9 Apr 2013, Thomas Gleixner wrote: Thought more about it and found, that the stupid binding only works when the task is really descheduled. So there is a small window left, which could lead

Re: [PATCH] kthread: Prevent unpark race which puts threads on the wrong cpu

2013-04-10 Thread Thomas Gleixner
On Wed, 10 Apr 2013, Thomas Gleixner wrote: On Tue, 9 Apr 2013, Dave Hansen wrote: On 04/09/2013 12:30 PM, Thomas Gleixner wrote: On Tue, 9 Apr 2013, Thomas Gleixner wrote: Thought more about it and found, that the stupid binding only works when the task is really descheduled. So

Re: [PATCH] CPU hotplug, smpboot: Fix crash in smpboot_thread_fn()

2013-04-11 Thread Thomas Gleixner
On Wed, 10 Apr 2013, Srivatsa S. Bhat wrote: Interestingly, in every single stack trace, the crashing task is the migration thread. Now, migration thread belongs to the highest priority stop_task sched class, and this particular sched class is very unique in the way it implements its internal

Re: [PATCH] kthread: Prevent unpark race which puts threads on the wrong cpu

2013-04-11 Thread Thomas Gleixner
Dave, On Wed, 10 Apr 2013, Dave Hansen wrote: I think I got a full trace this time: http://sr71.net/~dave/linux/bigbox-trace.1365621899.txt.gz The last timestamp is pretty close to the timestamp on the console: [ 2071.033434] smpboot_thread_fn(): [ 2071.033455]

Re: [PATCH] kthread: Prevent unpark race which puts threads on the wrong cpu

2013-04-11 Thread Thomas Gleixner
On Thu, 11 Apr 2013, Srivatsa S. Bhat wrote: On 04/11/2013 04:18 PM, Srivatsa S. Bhat wrote: On 04/11/2013 03:49 PM, Thomas Gleixner wrote: Dave, On Wed, 10 Apr 2013, Dave Hansen wrote: I think I got a full trace this time: http://sr71.net/~dave/linux/bigbox-trace.1365621899

Re: [PATCH] kthread: Prevent unpark race which puts threads on the wrong cpu

2013-04-11 Thread Thomas Gleixner
On Thu, 11 Apr 2013, Srivatsa S. Bhat wrote: On 04/11/2013 04:18 PM, Srivatsa S. Bhat wrote: On 04/11/2013 03:49 PM, Thomas Gleixner wrote: Dave, On Wed, 10 Apr 2013, Dave Hansen wrote: I think I got a full trace this time: http://sr71.net/~dave/linux/bigbox-trace.1365621899

Re: [PATCH] kthread: Prevent unpark race which puts threads on the wrong cpu

2013-04-11 Thread Thomas Gleixner
On Thu, 11 Apr 2013, Srivatsa S. Bhat wrote: The reason why we can't get rid of the bind in the unpark code is because, the threads are parked during CPU offline *after* calling CPU_DOWN_PREPARE. And during CPU_DOWN_PREPARE, the scheduler removes the CPU from the cpu_active_mask. So on any

Re: [PATCH] kthread: Prevent unpark race which puts threads on the wrong cpu

2013-04-11 Thread Thomas Gleixner
On Thu, 11 Apr 2013, Dave Hansen wrote: On 04/11/2013 03:19 AM, Thomas Gleixner wrote: --- linux-2.6.orig/kernel/smpboot.c +++ linux-2.6/kernel/smpboot.c @@ -185,8 +185,18 @@ __smpboot_create_thread(struct smp_hotpl } get_task_struct(tsk); *per_cpu_ptr(ht-store, cpu) = tsk

Re: [PATCH] kthread: Prevent unpark race which puts threads on the wrong cpu

2013-04-11 Thread Thomas Gleixner
Srivatsa, On Fri, 12 Apr 2013, Srivatsa S. Bhat wrote: On 04/09/2013 08:08 PM, Thomas Gleixner wrote: Add a new task state (TASK_PARKED) which prevents other wakeups and use this state explicitely for the unpark wakeup. Again, I think this is unnecessary. We are good as long as no one

Re: [PATCH] kthread: Prevent unpark race which puts threads on the wrong cpu

2013-04-12 Thread Thomas Gleixner
Srivatsa, On Fri, 12 Apr 2013, Srivatsa S. Bhat wrote: On 04/12/2013 02:17 AM, Thomas Gleixner wrote: + + /* + * Wait for p-on_rq to be reset to 0, to ensure that the per-cpu + * migration thread (which belongs to the stop_task sched class) + * doesn't run until the cpu

Re: [PATCH v2] sparc: Use generic idle loop

2013-04-12 Thread Thomas Gleixner
On Thu, 11 Apr 2013, Sam Ravnborg wrote: Add generic cpu_idle support sparc32: - replace call to cpu_idle() with cpu_startup_entry() - add arch_cpu_idle() sparc64: - smp_callin() now include cpu_startup_entry() call so we can skip calling cpu_idle from assembler - add

Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

2013-04-13 Thread Thomas Gleixner
On Mon, 8 Apr 2013, Kevin Strasser wrote: --- /dev/null +++ b/drivers/mfd/kempld-core.c +#include linux/kernel.h +#include linux/module.h +#include linux/init.h +#include linux/list.h +#include linux/device.h +#include linux/platform_device.h +#include linux/dmi.h +#include linux/slab.h

Re: [patch 07/34] alpha: Use generic idle loop

2013-03-29 Thread Thomas Gleixner
On Thu, 28 Mar 2013, Srivatsa S. Bhat wrote: (In all my replies, I'm referring to the code in your v2 on your git tree, but replying to the corresponding patches in your v1). So, in alpha, we poll in cpu idle. In the generic implementation in kernel/cpu/idle.c, arch_cpu_idle() is defined as:

Re: [patch 31/34] tile: Use generic idle loop

2013-03-29 Thread Thomas Gleixner
On Thu, 28 Mar 2013, Srivatsa S. Bhat wrote: That doesn't look quite right, since it returns -1 (instead of 0) when str == poll. Stupid me. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] timer: Fix possible issues with non serialized timer_pending( )

2013-04-03 Thread Thomas Gleixner
-by: Christian Ruppert christian.rupp...@abilis.com Cc: Thomas Gleixner t...@linutronix.de Cc: Christian Ruppert christian.rupp...@abilis.com Cc: Pierrick Hascoet pierrick.hasc...@abilis.com Cc: linux-kernel@vger.kernel.org --- include/linux/timer.h | 11 ++- 1 file changed, 10

Re: [patch 4/7] tick: Handle broadcast wakeup of multiple cpus

2013-03-13 Thread Thomas Gleixner
On Wed, 13 Mar 2013, Lorenzo Pieralisi wrote: + /* Take care of enforced broadcast requests */ + cpumask_or(tmpmask, tmpmask, tick_broadcast_force_mask); + cpumask_clear(tick_broadcast_force_mask); I tested the set and it works fine on a dual cluster big.LITTLE testchip using

Re: [PATCH 5/6] ARM: kill Hynix h720x platform

2013-03-14 Thread Thomas Gleixner
-by: Thomas Gleixner t...@linutronix.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] perf,x86: fix kernel crash with PEBS/BTS after suspend/resume

2013-03-15 Thread Thomas Gleixner
On Fri, 15 Mar 2013, Linus Torvalds wrote: On Fri, Mar 15, 2013 at 6:26 AM, Stephane Eranian eran...@google.com wrote: This patch fixes a kernel crash when using precise sampling (PEBS) after a suspend/resume. Yup, works. Applied. Can we please get rid of the crazy CPU notifier crap

[patch 21/34] microblaze: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
The microblaze idle loop provides a polling and a non polling version, which are suprisingly both polling, just with slightly different instrumentation. Remove them and use the generic poller. Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Michal Simek mon...@monstr.eu --- arch/microblaze

[patch 22/34] mips: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Ralf Baechle r...@linux-mips.org --- arch/mips/Kconfig |1 arch/mips/kernel/process.c | 46 - arch/mips/kernel/smp.c |2 - 3 files changed, 15 insertions(+), 34 deletions

[patch 34/34] xtensa: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Unfortunately this arch does not compile at all :( Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Chris Zankel ch...@zankel.net --- arch/xtensa/Kconfig |1 + arch/xtensa/kernel/process.c | 14 ++ 2 files changed, 3 insertions(+), 12 deletions(-) Index: linux

[patch 32/34] unicore: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Guan Xuetao g...@mprc.pku.edu.cn --- arch/unicore32/Kconfig |1 + arch/unicore32/kernel/process.c | 21 +++-- 2 files changed, 4 insertions(+), 18 deletions(-) Index: linux-2.6/arch/unicore32/Kconfig

[patch 33/34] x86: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: x...@kernel.org --- arch/x86/Kconfig |1 arch/x86/kernel/process.c | 106 -- arch/x86/kernel/smpboot.c |2 arch/x86/xen/smp.c|2 4 files changed, 32 insertions(+), 79

[patch 31/34] tile: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Chris Metcalf cmetc...@tilera.com --- arch/tile/kernel/process.c | 61 - arch/tile/kernel/smpboot.c |2 - 2 files changed, 7 insertions(+), 56 deletions(-) Index: linux-2.6/arch/tile/kernel

[patch 30/34] tile: Enter idle with preemption disabled

2013-03-21 Thread Thomas Gleixner
cpu_idle() needs to be called with preemption disabled. Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Chris Metcalf cmetc...@tilera.com --- arch/tile/kernel/smpboot.c |2 -- 1 file changed, 2 deletions(-) Index: linux-2.6/arch/tile/kernel/smpboot.c

[patch 29/34] sh: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Paul Mundt let...@linux-sh.org --- arch/sh/Kconfig |2 arch/sh/kernel/idle.c | 102 -- arch/sh/kernel/smp.c |2 3 files changed, 12 insertions(+), 94 deletions(-) Index: linux

[patch 20/34] metag: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: James Hogan james.ho...@imgtec.com --- arch/metag/Kconfig |1 + arch/metag/kernel/process.c | 32 +++- arch/metag/kernel/smp.c |2 +- 3 files changed, 5 insertions(+), 30 deletions(-) Index

[patch 26/34] powerpc: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Benjamin Herrenschmidt b...@kernel.crashing.org --- arch/powerpc/Kconfig |1 arch/powerpc/kernel/idle.c | 78 - arch/powerpc/kernel/smp.c |2 - 3 files changed, 24 insertions(+), 57

[patch 27/34] s390: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Heiko Carstens heiko.carst...@de.ibm.com --- arch/s390/kernel/process.c | 25 +++-- arch/s390/kernel/smp.c |3 +-- 2 files changed, 8 insertions(+), 20 deletions(-) Index: linux-2.6/arch/s390/kernel/process.c

[patch 28/34] score: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Lennox Wu lennox...@gmail.com --- arch/score/Kconfig |1 + arch/score/kernel/process.c | 18 -- 2 files changed, 1 insertion(+), 18 deletions(-) Index: linux-2.6/arch/score/Kconfig

[patch 25/34] parisc: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: James E.J. Bottomley j...@parisc-linux.org Cc: Helge Deller del...@gmx.de --- arch/parisc/Kconfig |1 + arch/parisc/kernel/process.c | 22 -- arch/parisc/kernel/smp.c |2 +- 3 files changed, 2

[patch 24/34] openrisc: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Idle poller with an extra check_pgt_cache() invocation. Use the core code. Signed-off-by: Thomas Gleixner t...@linutronix.de --- arch/openrisc/Kconfig |1 arch/openrisc/kernel/idle.c | 73 2 files changed, 1 insertion(+), 73 deletions

[patch 14/34] frv: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: David Howells dhowe...@redhat.com --- arch/frv/Kconfig |1 + arch/frv/kernel/process.c | 27 +-- 2 files changed, 6 insertions(+), 22 deletions(-) Index: linux-2.6/arch/frv/Kconfig

[patch 23/34] mn10300: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
default_idle() boils down to safe_halt() and the other option is idle polling. Use the core functionality. Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: David Howells dhowe...@redhat.com --- arch/mn10300/Kconfig |1 arch/mn10300/kernel/process.c | 70

[patch 19/34] m68k: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Geert Uytterhoeven ge...@linux-m68k.org --- arch/m68k/Kconfig |1 + arch/m68k/kernel/process.c | 32 2 files changed, 5 insertions(+), 28 deletions(-) Index: linux-2.6/arch/m68k/Kconfig

[patch 18/34] m32r: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Replace the private poller. Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Hirokazu Takata tak...@linux-m32r.org --- arch/m32r/Kconfig |1 + arch/m32r/kernel/process.c | 18 -- arch/m32r/kernel/smpboot.c |2 +- 3 files changed, 2 insertions(+), 19

[patch 17/34] ia64: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Tony Luck tony.l...@intel.com --- arch/ia64/Kconfig |1 arch/ia64/kernel/perfmon.c | 13 ++- arch/ia64/kernel/process.c | 83 + arch/ia64/kernel/smpboot.c |2 - 4 files

[patch 01/34] arch: Cleanup enable/disable_hlt

2013-03-21 Thread Thomas Gleixner
enable/disable_hlt() does not need to be exported and can be killed on architectures which do not use it at all. Signed-off-by: Thomas Gleixner t...@linutronix.de --- arch/arm/kernel/process.c |4 arch/cris/arch-v32/kernel/process.c |8 +++- arch/cris/include

[patch 03/34] idle: Implement set/clr functions for need_resched poll

2013-03-21 Thread Thomas Gleixner
Implement set/clear functions for the idle need_resched poll implementation. Signed-off-by: Thomas Gleixner t...@linutronix.de --- include/linux/sched.h | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) Index: linux-2.6/include/linux/sched.h

[patch 16/34] hexagon: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Richard Kuo r...@codeaurora.org --- arch/hexagon/Kconfig |1 + arch/hexagon/kernel/process.c | 23 +++ arch/hexagon/kernel/smp.c |2 +- 3 files changed, 5 insertions(+), 21 deletions(-) Index: linux

[patch 15/34] h8300: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Use the core idle poll function instead of the private one Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Yoshinori Sato ys...@users.sourceforge.jp --- arch/h8300/Kconfig |1 + arch/h8300/kernel/process.c | 35 --- 2 files changed, 5

[patch 13/34] cris: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Jesper Nilsson jesper.nils...@axis.com --- arch/cris/Kconfig |1 + arch/cris/arch-v10/kernel/process.c |3 ++- arch/cris/arch-v32/kernel/process.c | 10 -- arch/cris/arch-v32/kernel/smp.c |4

[patch 12/34] c6x: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Mark Salter msal...@redhat.com --- arch/c6x/Kconfig |1 + arch/c6x/kernel/process.c | 28 +--- 2 files changed, 2 insertions(+), 27 deletions(-) Index: linux-2.6/arch/c6x/Kconfig

[patch 10/34] avr32: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Also replace the idle poll enforcement by the generic functionality. Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Hans-Christian Egtvedt egtv...@samfundet.no --- arch/avr32/Kconfig |1 + arch/avr32/kernel/process.c | 13 ++--- arch/avr32

[patch 11/34] bfin: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Mike Frysinger vap...@gentoo.org --- arch/blackfin/Kconfig |1 + arch/blackfin/kernel/process.c | 30 ++ arch/blackfin/mach-common/smp.c |2 +- 3 files changed, 4 insertions(+), 29 deletions

[patch 09/34] arm64: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Catalin Marinas catalin.mari...@arm.com --- arch/arm64/Kconfig |1 + arch/arm64/kernel/process.c | 43 +-- arch/arm64/kernel/smp.c |2 +- 3 files changed, 7 insertions(+), 39

[patch 02/34] arch: Consolidate tsk_is_polling()

2013-03-21 Thread Thomas Gleixner
Move it to a common place. Preparatory patch for implementing set/clear for the idle need_resched poll implementation. Signed-off-by: Thomas Gleixner t...@linutronix.de --- arch/alpha/include/asm/thread_info.h |2 -- arch/ia64/include/asm/thread_info.h |2 -- arch/metag

[patch 08/34] arm: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
Use the generic idle loop and replace enable/disable_hlt with the respective core functions. Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Russell King li...@arm.linux.org.uk --- arch/arm/Kconfig |2 arch/arm/include/asm/system_misc.h |3 - arch/arm/kernel

[patch 07/34] alpha: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
The core provides a generic idle poll loop. Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Richard Henderson r...@twiddle.net Cc: Ivan Kokshaysky i...@jurassic.park.msu.ru Cc: Matt Turner matts...@gmail.com --- arch/alpha/Kconfig |1 + arch/alpha/kernel/process.c | 19

[patch 06/34] arc: Use generic idle loop

2013-03-21 Thread Thomas Gleixner
/cpu/idle.c Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Vineet Gupta vgu...@synopsys.com --- arch/arc/Kconfig |1 + arch/arc/kernel/process.c | 27 +-- arch/arc/kernel/smp.c |2 +- 3 files changed, 3 insertions(+), 27 deletions(-) Index

[patch 05/34] idle: Implement generic idle function

2013-03-21 Thread Thomas Gleixner
by the architecture code if needed. Signed-off-by: Thomas Gleixner t...@linutronix.de --- arch/Kconfig|3 + include/linux/cpu.h |8 +++ kernel/cpu/idle.c | 105 3 files changed, 116 insertions(+) Index: linux-2.6/arch/Kconfig

[patch 04/34] idle: Provide a generic entry point for the idle code

2013-03-21 Thread Thomas Gleixner
For now this calls cpu_idle(), but in the long run we want to move the cpu bringup code to the core and therefor we add a state argument. Signed-off-by: Thomas Gleixner t...@linutronix.de --- include/linux/cpu.h |8 init/main.c |2 +- kernel/Makefile |1 + kernel

[patch 00/34] idle: Consolidate idle implementations

2013-03-21 Thread Thomas Gleixner
Each architecture implements its own cpu_idle() code, which is more or less the same on all architectures (plus/minus a few bugs and a few missing extra functionalities, instrumentation ...). That also forces everyone who is interested in idle related features to add new functionality to every

Re: [patch 02/34] arch: Consolidate tsk_is_polling()

2013-03-22 Thread Thomas Gleixner
On Fri, 22 Mar 2013, Tony Breeds wrote: On Thu, Mar 21, 2013 at 09:52:57PM -, Thomas Gleixner wrote: +/* + * Idle thread specific functions to determine the need_resched + * polling state. We have two versions, one based on TS_POLLING in + * thread_info.status and one based

Re: PREEMPT_RT vs 'hrtimer: Prevent hrtimer_enqueue_reprogram race'

2013-03-22 Thread Thomas Gleixner
On Thu, 21 Mar 2013, Steven Rostedt wrote: On Fri, 2013-03-22 at 03:24 +, Ben Hutchings wrote: Note, I posted a fix on Tuesday: https://lkml.org/lkml/2013/3/19/369 Thanks. I did search GMANE with some obvious terms but I think its index is lagging. It didn't help that

[ANNOUNCE] 3.6.11-rt31

2013-03-22 Thread Thomas Gleixner
Dear RT Folks, I'm pleased to announce the 3.6.11-rt31 release. Changes since 3.6.11-rt31: 1) Highmem fixes (Sebastian Siewior) 2) Futex locking fix 3) Add a missing timer check (Zhao Hongjiang) 4) Make simple wait exports EXPORT_SYMBOL. As much as I hate it, but we have

[ANNOUNCE] 3.8.4-rt1

2013-03-22 Thread Thomas Gleixner
Dear RT Folks, I'm pleased to announce the 3.8.4-rt1 release. Again the credit for the heavy lifting goes to Sebastian Siewior, AKA bigeasy, who took up most of the work to get this out. He's on my companies engineering team and I hope you trust him as much as I do. Known issues: - SLUB

Re: [patch 05/34] idle: Implement generic idle function

2013-03-25 Thread Thomas Gleixner
On Sat, 23 Mar 2013, Heiko Carstens wrote: On Thu, Mar 21, 2013 at 09:53:00PM -, Thomas Gleixner wrote: All idle functions in arch/* are more or less the same, plus minus a few bugs and extra instrumentation, tickless support and other optional items. Implement a generic idle

Re: [patch 20/34] metag: Use generic idle loop

2013-03-25 Thread Thomas Gleixner
On Fri, 22 Mar 2013, James Hogan wrote: On 21/03/13 21:53, Thomas Gleixner wrote: Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: James Hogan james.ho...@imgtec.com --- arch/metag/Kconfig |1 + arch/metag/kernel/process.c | 32

Re: [patch 08/34] arm: Use generic idle loop

2013-03-25 Thread Thomas Gleixner
On Fri, 22 Mar 2013, Kevin Hilman wrote: Hi Thomas, Thomas Gleixner t...@linutronix.de writes: Use the generic idle loop and replace enable/disable_hlt with the respective core functions. Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Russell King li...@arm.linux.org.uk

Re: [patch 08/34] arm: Use generic idle loop

2013-03-25 Thread Thomas Gleixner
On Mon, 25 Mar 2013, Russell King - ARM Linux wrote: On Mon, Mar 25, 2013 at 12:31:20PM +0100, Thomas Gleixner wrote: On Fri, 22 Mar 2013, Kevin Hilman wrote: Hi Thomas, Thomas Gleixner t...@linutronix.de writes: Use the generic idle loop and replace enable/disable_hlt

[GIT pull] timer fixes for 3.9

2013-03-25 Thread Thomas Gleixner
Linus, please pull the latest timers-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers-urgent-for-linus A single bugfix which prevents that a non functional timer device is selected to provide the fallback device, which is supposed to serve

Re: [PATCHv3 01/10] clocksource: add generic dummy timer driver

2013-03-25 Thread Thomas Gleixner
On Mon, 25 Mar 2013, Mark Rutland wrote: Thomas, do you have an idea of if/when tip/timers/urgent will hit mainline? Thanks for the reminder. I just sent a pull request Linuswards. Thanks, tglx -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [PATCH 1/1] irq: get_irq_disable_depth.

2013-03-26 Thread Thomas Gleixner
On Mon, 25 Mar 2013, Andreas Fenkart wrote: Used to verify invariant in omap_hsmmc, were a gpio is used to detect sdio irqs during suspend phase. The ref count from irq_enable/irq_disable is used to control when the irq should be effectively enabled. irq en irq dis

Re: [PATCH v3b 0/9] refactoring for mask_cache

2013-03-26 Thread Thomas Gleixner
On Thu, 21 Mar 2013, Greg KH wrote: On Thu, Mar 21, 2013 at 06:12:02PM +0100, Gerlando Falauto wrote: This patchset addresses a regression found with the Orion GPIO controller when both Edge- and Level- based interrupts are requested within the same GPIO chip. The regression was introduced

Re: [PATCH v3b 0/9] refactoring for mask_cache

2013-03-26 Thread Thomas Gleixner
On Tue, 26 Mar 2013, Greg KH wrote: On Tue, Mar 26, 2013 at 09:37:53PM +0100, Thomas Gleixner wrote: On Thu, 21 Mar 2013, Greg KH wrote: On Thu, Mar 21, 2013 at 06:12:02PM +0100, Gerlando Falauto wrote: This patchset addresses a regression found with the Orion GPIO controller

Re: [PATCH] x86, cpa: Cleanup split_large_page and its callee

2013-03-26 Thread Thomas Gleixner
the caller to hand down struct page * directly and the callee can compute the pte_t itself. Net save is one virt_to_page() call and simpler code. While at it, make __split_large_page static. Signed-off-by: Borislav Petkov b...@suse.de Acked-by: Thomas Gleixner t...@linutronix.de

Re: [PATCH v4] clk: allow reentrant calls into the clk framework

2013-03-27 Thread Thomas Gleixner
On Wed, 27 Mar 2013, Mike Turquette wrote: Reentrancy into the clock framework from the clk.h api is necessary for clocks that are prepared and unprepared via i2c_transfer (which includes many PMICs and discrete audio chips) as well as for several other use cases. That explanation sucks.

Re: [PATCH v4] clk: allow reentrant calls into the clk framework

2013-03-27 Thread Thomas Gleixner
On Wed, 27 Mar 2013, Ulf Hansson wrote: On 27 March 2013 10:55, Viresh Kumar viresh.ku...@linaro.org wrote: On 27 March 2013 15:10, Thomas Gleixner t...@linutronix.de wrote: On Wed, 27 Mar 2013, Mike Turquette wrote: Reentrancy into the clock framework from the clk.h api is necessary

Re: [PATCH v4] clk: allow reentrant calls into the clk framework

2013-03-27 Thread Thomas Gleixner
On Wed, 27 Mar 2013, Mike Turquette wrote: +/*** locking reentrancy ***/ + +static void clk_fwk_lock(void) This function name sucks as much as the whole implementation does. +{ + /* hold the framework-wide lock, context == NULL */ + mutex_lock(prepare_lock); + + /* set

Re: [PATCH v4] clk: allow reentrant calls into the clk framework

2013-03-27 Thread Thomas Gleixner
On Wed, 27 Mar 2013, Mike Turquette wrote: Thanks for the review Thomas. I will steal your code and call it my own in the next version. Sure. In particular getting rid of the atomics makes things much nicer. I'd say using the helper functions and not having all these conditionals makes it

Re: [patch 13/34] cris: Use generic idle loop

2013-03-27 Thread Thomas Gleixner
On Wed, 27 Mar 2013, Jesper Nilsson wrote: On Thu, Mar 21, 2013 at 09:53:06PM -, Thomas Gleixner wrote: [snip] Index: linux-2.6/arch/cris/arch-v32/kernel/process.c === --- linux-2.6.orig/arch/cris/arch-v32/kernel

Re: [PATCH v4] clk: allow reentrant calls into the clk framework

2013-03-27 Thread Thomas Gleixner
On Wed, 27 Mar 2013, Mike Turquette wrote: Quoting Laurent Pinchart (2013-03-27 02:08:15) I wonder if it would make sense to abstract these operations in a generic recursive mutex. Given that it would delay this patch past v3.10 I won't push for that. Having a nice implementation

Re: [PATCH 2/2] timer_list: convert timer list to be a proper seq_file

2013-03-27 Thread Thomas Gleixner
On Wed, 27 Mar 2013, Andrew Morton wrote: On Tue, 26 Mar 2013 19:56:30 -0500 Nathan Zimmer nzim...@sgi.com wrote: +void sysrq_timer_list_show(void) +{ + u64 now = ktime_to_ns(ktime_get()); + int cpu; + + timer_list_header(NULL, now); for_each_online_cpu(cpu) hm, it

Re: [patch 00/34] idle: Consolidate idle implementations

2013-03-28 Thread Thomas Gleixner
On Thu, 28 Mar 2013, Chris Zankel wrote: For Xtensa: Acked-by: Chris Zankel ch...@zankel.net Thanks for going the extra mile and test-compiling it. Though, the build fails later with: arch/xtensa/kernel/built-in.o:(.init.literal+0x90): undefined reference to `platform_pcibios_init'

Re: [PATCH 1/2] clk: abstract locking out into helper functions

2013-03-28 Thread Thomas Gleixner
clk_enable_lock(unsigned long *flags) +{ + spin_lock_irqsave(enable_lock, *flags); +} +static void clk_enable_unlock(unsigned long *flags) Please just hand in the flags, no need for indirection. +{ + spin_unlock_irqrestore(enable_lock, *flags); +} + Reviewed-by: Thomas Gleixner t

Re: [PATCH 2/2] clk: allow reentrant calls into the clk framework

2013-03-28 Thread Thomas Gleixner
-interruptible, spinlock-protected operations. When the clk framework is entered we try to hold the global lock. If it is held we compare the current task id against the current owner; a s/task id/task/ We store a the task pointer in the owner variable. Reviewed-by: Thomas Gleixner t...@linutronix.de

Re: [PATCH 2/4][V2] time : set broadcast irq affinity

2013-03-07 Thread Thomas Gleixner
On Fri, 8 Mar 2013, Daniel Lezcano wrote: On 03/06/2013 10:48 AM, Thomas Gleixner wrote: I was wondering if it would be possible to take the 3/4 and 4/4 otherwise the flag dependency will prevent to send those to the maintainer's tree until they gain visibility on it. I can take them

Re: [PATCH 0/3] posix timers: Extend kernel API to report more info about timers (v2)

2013-03-08 Thread Thomas Gleixner
On Fri, 8 Mar 2013, Pavel Emelyanov wrote: On 02/21/2013 10:21 PM, Pavel Emelyanov wrote: Hi. Here's another approach to address the problems with insufficient API of posix timers. Gentlemen, Sir, that caught my attention. Will move it up on my todo list :) -- To unsubscribe from

Re: [PATCH 1/3] posix timers: Allocate timer id per process (v2)

2013-03-08 Thread Thomas Gleixner
Pavel, On Thu, 21 Feb 2013, Pavel Emelyanov wrote: Patch replaces global idr with global hash table for posix timers and makes timer ids unique not globally, but per process. Next free timer id is type of integer and stored on signal struct (posix_timer_id). If free timer id reaches negative

Re: [PATCH 3/4][V2] ARM: nomadik: add dynamic irq flag to the timer

2013-03-08 Thread Thomas Gleixner
On Fri, 8 Mar 2013, Daniel Lezcano wrote: Add the dynamic irq affinity feature to the timer clock device. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Vincent Guittot vincent.guit...@linaro.org Acked-by: Rickard Andersson rickard.anders...@stericsson.com ---

Re: [PATCH] genirq: Sanitize spurious interrupt detection of threaded irqs

2013-03-08 Thread Thomas Gleixner
On Fri, 8 Mar 2013, Till Straumann wrote: 1) I'm not sure adding the SPURIOUS_DEFERRED flag into threads_handled_last is OK - what happens if the atomic_t counter can hold more than 31 bits? In this case, when thread handlers increment the counter there is interference with the

Re: [PATCH] genirq: Sanitize spurious interrupt detection of threaded irqs

2013-03-08 Thread Thomas Gleixner
On Fri, 8 Mar 2013, Till Straumann wrote: On 03/08/2013 05:12 PM, Thomas Gleixner wrote: On Fri, 8 Mar 2013, Till Straumann wrote: 1) I'm not sure adding the SPURIOUS_DEFERRED flag into threads_handled_last is OK - what happens if the atomic_t counter can hold more than 31

Re: [PATCH v2 02/26] x86, irq: Modify irq chip once for irq remapping

2013-03-08 Thread Thomas Gleixner
On Fri, 8 Feb 2013, Yinghai Lu wrote: Now after irq remapping is enabled, irq_chip fields are modified during every irq setup. Only need to change them one during we enable irq mapping. Can you please start to write sensible changelogs? I'm really sick of your sloppyness. Also change

Re: [PATCH v2 02/26] x86, irq: Modify irq chip once for irq remapping

2013-03-08 Thread Thomas Gleixner
On Fri, 8 Mar 2013, Thomas Gleixner wrote: On Fri, 8 Feb 2013, Yinghai Lu wrote: Now after irq remapping is enabled, irq_chip fields are modified during every irq setup. Only need to change them one during we enable irq mapping. Can you please start to write sensible changelogs? I'm

Re: [PATCH 04/14] x86, ACPI: make acpi override finding work with 32bit flat mode

2013-03-08 Thread Thomas Gleixner
Yinghai, On Thu, 7 Mar 2013, Yinghai Lu wrote: On Thu, Mar 7, 2013 at 9:50 PM, Tejun Heo t...@kernel.org wrote: On Thu, Mar 07, 2013 at 08:58:30PM -0800, Yinghai Lu wrote: We will find acpi tables in initrd during head_32.S in 32bit flat mode. So need acpi_initrd_override_find could

Re: [PATCH 0/2] kthread: kill task_get_live_kthread()

2013-03-11 Thread Thomas Gleixner
Oleg, On Mon, 11 Mar 2013, Oleg Nesterov wrote: Imho, task_get_live_kthread() is very confusing and unneeded. 2a1d4460 copied get_task_struct() + vfork_done != NULL from kthread_stop(), but only kthread_stop() needs them both. It needs get_task_struct() because kthread_stop() can be used

Re: [PATCH 2/3] genirq: Do not consider the irqs with disabling and IRQF_NO_SUSPEND

2013-03-11 Thread Thomas Gleixner
On Tue, 12 Mar 2013, Chuansheng Liu wrote: According to commit 9c6079aa1bf(genirq: Do not consider disabled wakeup irqs), we should not break the suspend when one irq is pending but has been disabled before suspending. But there is another case missed, that one irq with flag IRQF_NO_SUSPEND,

Re: [PATCH 0/2] kthread: kill task_get_live_kthread()

2013-03-12 Thread Thomas Gleixner
On Tue, 12 Mar 2013, Oleg Nesterov wrote: Hi Thomas, On 03/11, Thomas Gleixner wrote: On Mon, 11 Mar 2013, Oleg Nesterov wrote: But the actual reason for this cleanup is that I do not understand why park/unpark abuse kthread.c. It's not abusing it :) Yes, yes, I didn't

<    4   5   6   7   8   9   10   11   12   13   >