Nigel Cunningham wrote:
...
Two way communication between a userspace policy manager and kernel
drivers is implemented via DBus.
In this scheme, 'kernel drivers' doesn't just refer to the drivers for
hardware. It refers to anything remotely power management related,
including code to implement
Advertise custom sets of system power states for non-ACPI systems.
Currently, /sys/power/state shows and accepts a static set of choices
that are not necessarily meaningful on all platforms (for example,
suspend-to-disk is an option even on diskless embedded systems, and the
meaning of standby vs.
An example of custom power states for the TI OMAP family.
/sys/power/states supports a state named deepsleep, which corresponds
to the platform state actually entered by the present-day system suspend
handler. It no longer offers the option of disk suspend which would
not normally be available in
Pavel Machek wrote:
Hi!
Advertise custom sets of system power states for non-ACPI systems.
Currently, /sys/power/state shows and accepts a static set of choices
that are not necessarily meaningful on all platforms (for example,
suspend-to-disk is an option even on diskless embedded systems, and
Pavel Machek wrote:
...
...but adding new /sys/power/state might be okay. We should not have
introduced standby in the first place [but I guess it is not worth
removing now]. If something has more than 2 states (does user really
want to enter different states in different usage?), I guess we can
* Remove duplicate include.
* Avoid mode set to '' message when error updating /sys/power/disk.
Signed-off-by: Todd Poynor [EMAIL PROTECTED]
--- linux-2.6.11-rc4-orig/kernel/power/disk.c 2005-02-23 09:47:03.0
-0800
+++ linux-2.6.11-rc4-pm/kernel/power/disk.c 2005-03-03 05:00
Pavel Machek wrote:
...
In most of the cases I'm thinking of, it wouldn't be a user
requesting a state but rather software (say, a cell phone
progressively entering lower power states due to inactivity). I
haven't noticed a platform with more than 3 low-power modes so far,
Are not your power
Print active wakeup sources, or the most recently active wakeup
source, when a PM transition is aborted due to wakeup source
events.
Signed-off-by: Todd Poynor toddpoy...@google.com
---
drivers/base/power/wakeup.c | 29 +
1 files changed, 29 insertions(+), 0
On Wed, Jul 18, 2012 at 09:47:34PM +0200, Rafael J. Wysocki wrote:
On Wednesday, July 18, 2012, Todd Poynor wrote:
...
+{
+ struct wakeup_source *ws;
+ int active = 0;
+ struct wakeup_source *last_activity_ws = NULL;
+
+ rcu_read_lock();
+ list_for_each_entry_rcu(ws
===
--- /dev/null
+++ linux-2.6.13-rc4/arch/arm/mach-omap1/powerop.c
@@ -0,0 +1,157 @@
+/*
+ * PowerOP support for OMAP1
+ *
+ * Based on DPM OMAP code by Matthew Locke, Dmitry Chigirev, Vladimir
+ * Barinov, and Todd Poynor.
+ *
+ * 2005 (c) MontaVista Software, Inc. This file
PowerOP is a system power parameter management API submitted for
discussion. PowerOP writes and reads power operating points,
comprised of arbitrary values, called power parameters, that correspond
to registers, clocks, dividers, voltage regulators, etc. that may be
modified to set a basic
A PowerOP sysfs UI backend for OMAP1 platforms, adding sysfs attributes
and show/store functions that correspond to the platform power
parameters.
An example usage on an OMAP1510 Innovator which does not have voltage
scaling and ignoring the DSP:
# echo -n 168-168-84 /sys/powerop/new # DPLL
/powerop_sysfs.c
===
--- /dev/null
+++ linux-2.6.13-rc4/drivers/powerop/powerop_sysfs.c
@@ -0,0 +1,398 @@
+/*
+ * PowerOP sysfs UI
+ *
+ * Author: Todd Poynor [EMAIL PROTECTED]
+ *
+ * 2005 (c) MontaVista Software, Inc. This file is licensed
Jordan Crouse wrote:
Todd - do you have a ChangeLog from Take 1? :)
Right, here's what's changed in this version...
The generic structure of an operating point as an array of integers is
dropped. A struct powerop_point is now an entirely backend-defined
struct of arbitrary fields.
There
David Brownell wrote:
Interesting. I start to like this shape better; it moves more of the
logic to operating point code, where it can make the sysfs interface
talk in terms of meaningful abstractions, not cryptic numeric offsets.
But it was odd to see the first patch be platform-specific
Geoff Levand wrote:
I'm wondering if anything could be gained by having the whole
struct powerop_point defined in asm/powerop.h, and treat it as an
opaque structure at this level. That way, things other than just
ints could be passed between the policy manager and the backend,
although I
Patrick Mochel wrote:
On Mon, 8 Aug 2005, Todd Poynor wrote:
(apologies for use of obsolete cpufreq mailing list address in my
initial message.)
...
PowerOP is intended to leave all power
policy decisions to higher layers.
What do those higher layers look like? Do you have a userspace
Pavel Machek wrote:
Depending on the ability of the hardware to make software-controlled
power/performance adjustments, this may be useful to select custom
voltages, bus speeds, etc. in desktop/server systems. Various embedded
systems have several parameters that can be set. For example, an
Bruno Ducrot wrote:
ATM I'm wondering what are the pro for those patches wrt current cpufreq
infrastructure (especially cpufreq's notion of notifiers).
I still don't find a good one but I'm surely missing something obvious.
This is lower layer than cpufreq, intended for use by cpufreq (and
Dave Jones wrote:
I'm glad I'm not the only one who feels he's too dumb to see
the advantages of this. The added complexity to expose something
that in all cases, we actually don't want to expose seems a little
pointless to me.
For example, most of the x86 drivers, if you set a speed, and then
Daniel Petrini wrote:
I'd like to have an idea of how the powerop would evolve to address:
a) exporting all operating points to sysfs - that would be useful for
a policy manager in user space, or the user policy will already be
aware of the ops?
For different usage models I'd expect to see
Jordan Crouse wrote:
When it comes
to embedded power management concepts, a consistant theme is that people
often question the usefulness, redundancy or complexity of a solution. This
is perfectly understandable, since such a huge majority of the power
management experts and users are
[EMAIL PROTECTED] wrote:
How well would _this_ notion of an operating point scale up?
I have this feeling that it's maybe better attuned to scale down
sorts of problems (maybe cell phones) than to a big NUMA box. I can
see how a batch scheduled server might want to fire up only enough
Dominik Brodowski wrote:
First, the table interface you suggest is ugly. If there's indeed the need for
such an abstraction, I'd favour something like
I'm planning to adopt the previous suggestions of an opaque data
structure and stop trying to have any generic structure to it. I'll try
to
Dominik Brodowski wrote:
A small add-on:
We need to make sure that we're capable of handling smart CPUs like Transmeta
Crusoe processors in a sane way. This means
b) Setting of values
is optional if the hardware itself can be set to a min/max value (step a
above in previous mail).
PowerOP is a system power parameter management API submitted for
discussion. PowerOP writes and reads power operating points,
comprised of arbitrary integer-valued values, called power parameters,
that correspond to registers, clocks, dividers, voltage regulators,
etc. that may be modified to set
/drivers/powerop/powerop.c 2005-08-04 19:50:38.0
+
@@ -0,0 +1,253 @@
+/*
+ * PowerOP generic core functions
+ *
+ * Author: Todd Poynor [EMAIL PROTECTED]
+ *
+ * 2005 (c) MontaVista Software, Inc. This file is licensed under
+ * the terms of the GNU General Public License version 2
Minimal PowerOP support for Intel Enhanced Speedstep Centrino
notebooks. These systems run at an operating point comprised of a cpu
frequency and a core voltage. The voltage could be set from the values
recommended in the datasheets if left unspecified (-1) in the operating
point, as cpufreq
A minimal example of modifying cpufreq to use PowerOP for reading and
writing power parameters on Intel Centrino platforms. It would be
possible to move voltage table lookups to the PowerOP layer.
Index: linux-2.6.12/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c
for 1 second while the alarm is allowed to be serviced or
other hopefully transient conditions preventing the alarm clear up.
Signed-off-by: Todd Poynor toddpoy...@google.com
---
kernel/time/alarmtimer.c | 18 +-
1 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/kernel
.
Signed-off-by: Todd Poynor toddpoy...@google.com
---
include/linux/alarmtimer.h | 4
kernel/time/alarmtimer.c | 39 ++-
2 files changed, 42 insertions(+), 1 deletion(-)
diff --git a/include/linux/alarmtimer.h b/include/linux/alarmtimer.h
index 9069694
Add support for clocks CLOCK_REALTIME_ALARM and CLOCK_BOOTTIME_ALARM,
thereby enabling wakeup alarm timers via file descriptors.
Signed-off-by: Todd Poynor toddpoy...@google.com
---
fs/timerfd.c | 131 ---
1 file changed, 108 insertions
Enable wakeup alarm timers via file descriptors. Hook up alarmtimer
to timerfd via clocks CLOCK_REALTIME_ALARM and CLOCK_BOOTTIME_ALARM,
and add needed functions to alarmtimer.
fs/timerfd.c | 131 +
include/linux/alarmtimer.h |4 +
Existing printk timestamps in a dmesg only log suspend activities
(e.g. filesystem syncs, freezing/unfreezing tasks etc) while the
system has already started to enter/exit the suspend state. Sometimes
it is handy to have suspend entry/exit overhead information while
debugging suspend issues.
On Fri, Aug 1, 2014 at 9:30 AM, Amit Pundir amit.pun...@linaro.org wrote:
From: Todd Poynor toddpoy...@google.com
Currently when a pending wakeup irq stops suspend, it can be difficult
to determine why suspend was prevented and which IRQ was actually
responsible.
In order to help debug
On Tue, Sep 2, 2014 at 7:54 AM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Tue, Sep 02, 2014 at 05:19:18PM +0530, Kiran Kumar Raparthy wrote:
...
diff --git a/drivers/usb/phy/otg-wakeupsource.c
b/drivers/usb/phy/otg-wakeupsource.c
index fca2010..70fa05e 100644
---
On Fri, Aug 22, 2014 at 10:12 AM, Felipe Balbi ba...@ti.com wrote:
...
you never explain why this is needed and you have also added some
information to commit log which shouldn't be here.
Android uses this to prevent suspend from interfering with USB
peripheral traffic, notably adb.
The wakeup
On Sat, Sep 20, 2014 at 5:04 PM, Rafael J. Wysocki r...@rjwysocki.net wrote:
On Friday, September 19, 2014 04:57:12 AM Amit Pundir wrote:
From: Todd Poynor toddpoy...@google.com
Existing timestamps in a dmesg only log suspend activities
(e.g. filesystem syncs, freezing/unfreezing tasks etc
On Wed, Nov 19, 2014 at 2:43 AM, Kiran Kumar Raparthy
kiran.ku...@linaro.org wrote:
From: Todd Poynor toddpoy...@google.com
usb: phy: introduce usb_phy_set_event interface
Hi Kiran, this is new stuff that is all your own work and you deserve
the credit.
Thanks for working to get this feature
On Thu, Sep 4, 2014 at 9:37 AM, Tc, Jenny jenny...@intel.com wrote:
If the intention is to prevent suspend while processing the power supply
uevents,
Isn't it a good option to use EPOLLWAKEUP? In Android, it's already used by
healthd to achieve the same.
It's a good idea for the userspace
On Wed, Sep 3, 2014 at 9:53 PM, Viresh Kumar viresh.ku...@linaro.org wrote:
On 4 September 2014 10:21, Viresh Kumar viresh.ku...@linaro.org wrote:
+ /* dependent power supplies (e.g. battery) may have changed
+* state as a result of this event, so poll again and hold
+
On Fri, Aug 29, 2014 at 1:50 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Wed, Aug 27, 2014 at 02:58:30PM -0700, Todd Poynor wrote:
On Fri, Aug 22, 2014 at 10:12 AM, Felipe Balbi ba...@ti.com wrote:
...
you never explain why this is needed and you have also added some
information to commit
From: Todd Poynor <toddpoy...@gmail.com>
Various structures embed a struct cgroup_subsys_state, typically at
the top of the containing structure. It is common for code that
accesses the structures to perform operations that iterate over the
chain of parent css pointers, also accessin
From: Todd Poynor <toddpoy...@google.com>
Various structures embed a struct cgroup_subsys_state, typically at
the top of the containing structure. It is common for code that
accesses the structures to perform operations that iterate over the
chain of parent css pointers, also accessin
operation with the mapping.
Signed-off-by: Todd Poynor <toddpoy...@google.com>
---
drivers/scsi/sg.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index 3a44b4bc872b..a20718e9f1f4 100644
--- a/drivers/scsi/sg.c
+++ b/d
M
should be returned in this case, instead of switching over to an
indirect buffer as for non-MMAP_IO requests.
Signed-off-by: Todd Poynor <toddpoy...@google.com>
---
drivers/scsi/sg.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/sg.c b/drivers/sc
initcall processing are not shown.
Example log messages added:
[0.505119] deferred probe my-sound-device @ 6
[0.517656] deferred probe my-sound-device returned after 1227 usecs
Signed-off-by: Todd Poynor <toddpoy...@google.com>
---
drivers/base/dd.c | 28 +
On Tue, Jul 25, 2017 at 4:40 PM, Greg Kroah-Hartman
<gre...@linuxfoundation.org> wrote:
> On Tue, Jul 25, 2017 at 04:31:59PM -0700, Todd Poynor wrote:
>> initcall_debug attributes all deferred device probe retries for the
>> late_initcall level to function deferred_prob
From: Todd Poynor
Add initcall_debug logs for the amount of time taken by each OF platform
bus device create call. For example:
of platform device create /reserved-memory/ramoops@a380 took
3255 usecs
initcall_debug already reports the total of all such device creates
as a single
From: Todd Poynor
Add initcall_debug logs for each driver device probe call, for example:
probe of a380.ramoops returned 1 after 3007 usecs
This replaces the previous code added to report times for deferred
probes. It also reports OF platform bus device creates that were
formerly
From: Todd Poynor
Add initcall_debug logs for each driver device probe call, for example:
probe of a380.ramoops returned after 3007 usecs
This replaces the previous code added to report times for deferred
probes. It also reports OF platform bus device creates that were
formerly lumped
From: Todd Poynor
Remove code with TODOs on it for working around apparent problems
previously seen in a qemu environment where dma_ops was not set
correctly. There is no user of this in the current code.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 2
From: Todd Poynor
Hold a reference on the struct device kobject while a pointer to that
device is in use by gasket.
Reported-by: Greg Kroah-Hartman
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
From: Todd Poynor
Apex chips with class 0 (PCI_CLASS_NOT_DEFINED) fixed up to
PCI_CLASS_SYSTEM_OTHER to enable PCI resource assignments.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/apex_driver.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/staging/gasket
From: Todd Poynor
The device pointer passed into get_mapping() will never be NULL; the
check is unnecessary.
Reported-by: Greg Kroah-Hartman
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_sysfs.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/gasket
From: Todd Poynor
Remove the check for refcount already zero, which shouldn't be
necessary.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_sysfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/gasket/gasket_sysfs.c
b/drivers/staging/gasket/gasket_sysfs.c
From: Todd Poynor
The fun continues with gasket+apex: remove dead code and unnecessary
stuff, fixup apex PCI class for devices that advertise class 0
(undefined), and make sure the struct device doesn't go away on us.
Most of these from review comments of previous patch series.
Todd Poynor (5
From: Todd Poynor
At device/driver registration time, convert a not-very-informative
info message to a more informative debug message, drop some not overly
helpful debug messages.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 7 ++-
1 file changed, 2 insertions
From: Todd Poynor
There's no need to take an additional reference on the pci_dev structure
for the pointer copy saved in gasket data structures.
This reverts commit:
8dd8a48b9a7d ("staging: gasket: core: hold reference to pci_dev while used")
Reported-by: Dmitry Torokhov
Signed-of
From: Todd Poynor
Identify gasket as the subsystem printing various messages.
Add the driver name to appropriate messages to indicate which driver
has a problem.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 13 +
1 file changed, 9 insertions(+), 4
From: Todd Poynor
Remove logs for loading gasket drivers.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/gasket/gasket_core.c
b/drivers/staging/gasket/gasket_core.c
index 2b75f100da4d3..fa477d0c3c74c
From: Todd Poynor
More cleanups for the gasket+apex drivers.
Patched changed in v2 from v1:
staging: gasket: core: print driver version code at registration time
staging: gasket: core: move driver loaded log after error cases
Above 2 patches replaced by new patch:
staging
Hi Dmitry,
On Mon, Jul 30, 2018 at 10:57 AM Dmitry Torokhov wrote:
>
> Hi Todd,
>
> On Sun, Jul 29, 2018 at 12:37 PM Todd Poynor wrote:
> > @@ -1064,7 +1067,8 @@ static int gasket_open(struct inode *inode, struct
> > file *filp)
> > char task_name[TASK
From: Todd Poynor
Hold a reference on the struct device while a pointer to that
device is in use by gasket.
Reported-by: Greg Kroah-Hartman
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
From: Todd Poynor
The fun continues with gasket+apex: remove dead code and unnecessary
stuff, fixup apex PCI class for devices that advertise class 0
(undefined), and make sure the struct device doesn't go away on us.
Most of these from review comments of previous patch series.
Changed patches
From: Todd Poynor
Use user namespace to determine whether gasket device file opener is
root, allowing root access to containers, if necessary.
Reported-by: Dmitry Torokhov
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 10 --
1 file changed, 8 insertions(+), 2
From: Todd Poynor
Static functions don't need kernel doc formatting, can be simplified.
Reformat comments that can be single-line. Remove extraneous text.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/apex_driver.c | 64 +---
1 file changed, 10 insertions
From: Todd Poynor
Static functions don't need kernel doc formatting, can be simplified.
Reformat comments that can be single-line. Remove extraneous text.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 151 ++-
1 file changed, 31 insertions
From: Todd Poynor
Static functions don't need kernel doc formatting, can be simplified.
Reformat comments that can be single-line. Remove extraneous text.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_interrupt.c | 18 +-
1 file changed, 1 insertion(+), 17
From: Todd Poynor
Fixes for device reference counting and root access based on user
namespace for containers, plus cleanups of comments, forward
declarations for static functions (more forthcoming) and multi-line
continuation style (more to come).
Todd Poynor (13):
staging: gasket: core: hold
From: Todd Poynor
Static functions don't need kernel doc formatting, can be simplified.
Reformat comments that can be single-line. Remove extraneous text.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_ioctl.c | 51 +--
1 file changed, 9 insertions
From: Todd Poynor
Remove forward declarations of static functions, move code to avoid
forward references, for kernel style.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/apex_driver.c | 416 ---
1 file changed, 190 insertions(+), 226 deletions(-)
diff --git
From: Todd Poynor
Remove the TODO entry for simplifying kernel doc style comments for
static functions, now that this has been addressed.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/TODO | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/gasket/TODO b/drivers/staging
From: Todd Poynor
Static functions don't need kernel doc formatting, can be simplified.
Reformat comments that can be single-line. Remove extraneous text.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_page_table.c | 323 +++--
1 file changed, 48 insertions
From: Todd Poynor
Fix multi-line alignment formatting to look like:
int ret = long_function_name(device, VARIABLE1, VARIABLE2,
VARIABLE3, VARIABLE4);
Many of these TODO items were previously cleaned up during the conversion
to standard logging functions
From: Todd Poynor
Hold references to the struct device and the pci_dev for the page table
while the data structures contian pointers to these.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_page_table.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
From: Todd Poynor
Hold a reference on the struct pci_dev while a pointer to it is held in
the gasket data structures.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gasket
From: Todd Poynor
Hold a reference to the struct device while a gasket sysfs mapping
exists for the device and a pointer to the struct is kept in the mapping
data structures.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_sysfs.c | 11 +--
1 file changed, 5 insertions
From: Todd Poynor
Static functions don't need kernel doc formatting, can be simplified.
Reformat comments that can be single-line. Remove extraneous text.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_sysfs.c | 28 ---
1 file changed, 4 insertions
On Mon, Jul 30, 2018 at 11:19 PM Dmitry Torokhov wrote:
>
> On Sun, Jul 29, 2018 at 12:37 PM Todd Poynor wrote:
> >
> > From: Todd Poynor
> >
> > Hold a reference on the struct pci_dev while a pointer to it is held in
> > the gasket data structures
From: Todd Poynor
Replace gasket logging calls with standard logging calls.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_page_table.c | 131 +
1 file changed, 54 insertions(+), 77 deletions(-)
diff --git a/drivers/staging/gasket/gasket_page_table.c
b
From: Todd Poynor
Print device addresses as unsigned long, not as kernel pointers.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_page_table.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/gasket/gasket_page_table.c
b/drivers
From: Todd Poynor
Convert gasket logging calls to standard functions.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_interrupt.c | 67 +++
1 file changed, 32 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/gasket/gasket_interrupt.c
b/drivers
From: Todd Poynor
Replace gasket logging calls with standard logging calls.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_ioctl.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/gasket/gasket_ioctl.c
b/drivers
From: Todd Poynor
Kill off gasket logging functions, convert to standard.
Fixup a few formatting/style problems in the process.
Todd Poynor (10):
staging: gasket: save struct device for a gasket device
staging: gasket: core: convert to standard logging
staging: gasket: interrupt: convert
From: Todd Poynor
Drop gasket logging calls in favor of standard logging.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/apex_driver.c | 61
1 file changed, 26 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/gasket/apex_driver.c
b/drivers
From: Todd Poynor
Use standard logging functions, drop use of gasket log functions.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 295 ---
1 file changed, 134 insertions(+), 161 deletions(-)
diff --git a/drivers/staging/gasket/gasket_core.c
b
From: Todd Poynor
Gasket logging functions no longer used.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_logging.h | 64 -
1 file changed, 64 deletions(-)
delete mode 100644 drivers/staging/gasket/gasket_logging.h
diff --git a/drivers/staging/gasket
From: Todd Poynor
Drop gasket logging calls in favor of standard logging.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_sysfs.c | 73 +--
1 file changed, 35 insertions(+), 38 deletions(-)
diff --git a/drivers/staging/gasket/gasket_sysfs.c
b/drivers
From: Todd Poynor
Save the struct device pointer to a gasket device in gasket's metadata,
to facilitate use of standard logging calls and in anticipation of
non-PCI gasket devices in the future.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 5 +++--
drivers/staging
From: Todd Poynor
Gasket/apex drivers now use standard logging, remove TODO entry for
this.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/TODO | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/gasket/TODO b/drivers/staging/gasket/TODO
index d3c44ca4fda25
On Fri, Jul 27, 2018 at 8:07 AM Greg Kroah-Hartman
wrote:
>
> On Thu, Jul 26, 2018 at 08:07:33PM -0700, Todd Poynor wrote:
> > From: Todd Poynor
> >
> > Drop gasket logging calls in favor of standard logging.
> >
> > Signed-off-by: Todd Poynor
> > ---
On Fri, Jul 27, 2018 at 8:09 AM Greg Kroah-Hartman
wrote:
>
> On Thu, Jul 26, 2018 at 08:07:28PM -0700, Todd Poynor wrote:
> > From: Todd Poynor
> >
> > Save the struct device pointer to a gasket device in gasket's metadata,
> > to facilitate use of standard log
From: Todd Poynor
Fix multi-line alignment formatting to look like:
int ret = long_function_name(device, VARIABLE1, VARIABLE2,
VARIABLE3, VARIABLE4);
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_sysfs.c | 26
From: Todd Poynor
Remove forward declarations of static functions, move code to avoid
forward references, for kernel style.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_interrupt.c | 499 +++---
1 file changed, 242 insertions(+), 257 deletions(-)
diff --git
From: Todd Poynor
Fix multi-line alignment formatting to look like:
int ret = long_function_name(device, VARIABLE1, VARIABLE2,
VARIABLE3, VARIABLE4);
Many of these TODO items were previously cleaned up during the conversion
to standard logging functions
From: Todd Poynor
The include guard symbol for gasket_page_table.h is out-of-date.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_page_table.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/gasket/gasket_page_table.h
b/drivers/staging
From: Todd Poynor
gasket_free_dev() is called only from driver PCI probe and remove
function. It is guaranteed that that pci_dev structure is not going
anywhere during that time; there is no need to take this additional
reference.
This reverts commit dd9d1502feea3c23d412f289aad79e1d4e86d45d
From: Todd Poynor
The static function declarations are removed, remove the TODO file entry
for this.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/TODO | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/gasket/TODO b/drivers/staging/gasket/TODO
index 7f4c13ce021b
From: Todd Poynor
Fix multi-line alignment formatting to look like:
int ret = long_function_name(device, VARIABLE1, VARIABLE2,
VARIABLE3, VARIABLE4);
Many of these TODO items were previously cleaned up during the conversion
to standard logging functions
1 - 100 of 746 matches
Mail list logo
