[PATCH v7 09/33] net: nl802154 - make add_iface take name assign type

2014-07-10 Thread Tom Gundersen
Signed-off-by: Tom Gundersen Cc: Dmitry Eremin-Solenikov Cc: linux-zigbee-de...@lists.sourceforge.net --- include/net/wpan-phy.h | 4 +++- net/ieee802154/nl-phy.c| 5 - net/mac802154/ieee802154_dev.c | 7 --- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git

[PATCH v7 05/33] net: set name assign type for names assigned using a static string

2014-07-10 Thread Tom Gundersen
This covers the trivial case: alloc_netdev(_, "bar", NET_NAME_PREDICTABLE, _); Signed-off-by: Tom Gundersen --- drivers/media/dvb-core/dvb_net.c | 2 +- drivers/misc/sgi-xp/xpnet.c | 2 +- drivers/net/caif/caif_virtio.c | 2 +- drivers/net/eql.c| 4 ++-- d

[PATCH v7 04/33] net: set name assign type for names assigned using a static template

2014-07-10 Thread Tom Gundersen
This covers the trivial case: alloc_netdev(_, "foo%d", NET_NAME_ENUM, _); Signed-off-by: Tom Gundersen --- drivers/firewire/net.c| 2 +- drivers/hsi/clients/ssi_protocol.c| 3 ++- drivers/net/caif/caif_spi.c | 4 ++-- drivers/net

[PATCH v7 02/33] net: set name assign type for renamed devices

2014-07-10 Thread Tom Gundersen
Based on a patch from David Herrmann. This is the only place devices can be renamed. Signed-off-by: Tom Gundersen Reviewed-by: David Herrmann --- net/core/dev.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index 30eedf6..7765ec5 100644 --- a/net

Re: [PATCH v7 00/33] Provide netdev naming-policy via sysfs

2014-07-10 Thread Tom Gundersen
Thanks for the quick answer. On Thu, Jul 10, 2014 at 10:43 AM, David Miller wrote: > It is not reasonable to expect people to review such a large number of > patches at one time. > > Split your series up into logical, and more reasonably sized chunks. > > I'd say 14 or 15 at a time is the limit.

Re: [PATCH v7 10/33] net: dummy - set name assign type

2014-07-10 Thread Tom Gundersen
On Thu, Jul 10, 2014 at 11:31 AM, Bjørn Mork wrote: > Tom Gundersen writes: > >> A fixed number of indistinguishable dummy devices are allocated at module >> init time, >> the names are therefore PREDICTABLE rather than ENUM. > > OK? So if I go do > > mo

Re: [PATCH v7 03/33] net: set name_assign_type in alloc_netdev()

2014-07-10 Thread Tom Gundersen
On Thu, Jul 10, 2014 at 11:16 AM, Bjørn Mork wrote: > Tom Gundersen writes: > >> diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c >> index 5dc638c..f405e05 100644 >> --- a/net/ethernet/eth.c >> +++ b/net/ethernet/eth.c >> @@ -390,7 +390,8 @@ EXPORT_SYMBOL

Re: [PATCH v7 10/33] net: dummy - set name assign type

2014-07-10 Thread Tom Gundersen
On Thu, Jul 10, 2014 at 12:26 PM, David Herrmann wrote: > Hi > >>> The same goes for NET_NAME_USER and NET_NAME_RENAMED. These are the same >>> from a kernel point of view. >> >> You mean to collapse the two, and just label renamed interfaces >> NET_NAME_USER instead? > > I have no real objections

Re: [PATCH v7 15/33] net: xen-netback - set name assign type

2014-07-10 Thread Tom Gundersen
On Thu, Jul 10, 2014 at 11:01 AM, Ian Campbell wrote: > On Thu, 2014-07-10 at 10:17 +0200, Tom Gundersen wrote: >> The name contains then xen handle, which is not guaranteed to be >> stable between restarts, so label this NET_NAME_ENUM. > > FWIW the N'th interface fo

Re: [PATCH v7 10/33] net: dummy - set name assign type

2014-07-10 Thread Tom Gundersen
On Thu, Jul 10, 2014 at 1:44 PM, Bjørn Mork wrote: > Tom Gundersen writes: > >> The result of >> >> modprobe dummy numdummies=2 >> >> is to create dummy0 and dummy1, always with the same names. >> >> The result of >> >> ip link add t

Re: [PATCH v7 03/33] net: set name_assign_type in alloc_netdev()

2014-07-10 Thread Tom Gundersen
On Thu, Jul 10, 2014 at 1:29 PM, Bjørn Mork wrote: > Tom Gundersen writes: >> On Thu, Jul 10, 2014 at 11:16 AM, Bjørn Mork wrote: >>> Tom Gundersen writes: >>> >>>> diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c >>>> index 5dc638c..f405

Re: [PATCH v7 00/33] Provide netdev naming-policy via sysfs

2014-07-10 Thread Tom Gundersen
On Thu, Jul 10, 2014 at 11:19 AM, Tom Gundersen wrote: > Thanks for the quick answer. > > On Thu, Jul 10, 2014 at 10:43 AM, David Miller wrote: >> It is not reasonable to expect people to review such a large number of >> patches at one time. >> >> Split your

Re: [PATCH v7 01/33] net: add name_assign_type netdev attribute

2014-07-10 Thread Tom Gundersen
On Thu, Jul 10, 2014 at 5:53 PM, Nicolas Dichtel wrote: > Le 10/07/2014 10:17, Tom Gundersen a écrit : > >> Based on a patch by David Herrmann. >> >> The name_assign_type attribute gives hints where the interface name of a >> given net-device comes from. Thes

Re: [PATCH v7 01/33] net: add name_assign_type netdev attribute

2014-07-10 Thread Tom Gundersen
On Thu, Jul 10, 2014 at 9:58 PM, Arend van Spriel wrote: > On 10-07-14 10:17, Tom Gundersen wrote: >> Based on a patch by David Herrmann. >> >> The name_assign_type attribute gives hints where the interface name of a >> given net-device comes from. These v

Re: [PATCH v7 29/33] net: brcmfmac - set name assign type

2014-07-10 Thread Tom Gundersen
On Thu, Jul 10, 2014 at 10:08 PM, Arend van Spriel wrote: > On 10-07-14 10:17, Tom Gundersen wrote: >> The name is given by the firmware, so we assume it is predictable. > > How about the scenario where one would have multiple broadcom wifi > devices in the system. Both driv

[PATCH v8 00/4] Provide netdev naming-policy via sysfs

2014-07-10 Thread Tom Gundersen
assign type as an argument. - introduce an internal assign type NET_NAME_UNKNOWN, which makes it simpler to split up the patches, but may eventually be dropped. - introduce a new assign type NET_NAME_PREDICTABLE to indicate to userspace that the kernel-assigned names are well-behaved. Tom

[PATCH v8 1/4] net: add name_assign_type netdev attribute

2014-07-10 Thread Tom Gundersen
ff-by: Tom Gundersen Reviewed-by: David Herrmann Reviewed-by: Kay Sievers v8: minor documentation fixes --- Documentation/ABI/testing/sysfs-class-net | 11 +++ include/linux/netdevice.h | 2 ++ include/uapi/linux/netdevice.h| 6 ++ net/core/

[PATCH v8 2/4] net: set name assign type for renamed devices

2014-07-10 Thread Tom Gundersen
Based on a patch from David Herrmann. This is the only place devices can be renamed. Signed-off-by: Tom Gundersen Reviewed-by: David Herrmann --- net/core/dev.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index 392c784..5d7b2a6 100644 --- a/net

[PATCH v8 4/4] net: rtnetlink - make create_link take name_assign_type

2014-07-10 Thread Tom Gundersen
This passes down NET_NAME_USER (or NET_NAME_ENUM) to alloc_netdev(), for any device created over rtnetlink. Signed-off-by: Tom Gundersen --- drivers/net/veth.c | 11 --- include/net/rtnetlink.h | 1 + net/core/rtnetlink.c| 12 3 files changed, 17 insertions(+), 7

Re: [PATCH v7 29/33] net: brcmfmac - set name assign type

2014-07-15 Thread Tom Gundersen
l resubmit this patch once the earlier patches introducing the infrastructure have been applied. Cheers, Tom [0]: <https://lkml.org/lkml/2014/7/10/94>. > On Thu, Jul 10, 2014 at 10:17:34AM +0200, Tom Gundersen wrote: >> The name is given by the firmware, so we assume it is predic

[PATCH v8] net: set name assign type for names assigned using a static string

2014-07-16 Thread Tom Gundersen
This covers the trivial case: alloc_netdev(_, "bar", NET_NAME_PREDICTABLE, _); Signed-off-by: Tom Gundersen --- This patch goes on top of net-next. drivers/media/dvb-core/dvb_net.c | 2 +- drivers/misc/sgi-xp/xpnet.c | 2 +- drivers/net/caif/caif_virtio.c | 2 +- drivers

[PATCH v8] net: isdn - set name assign type

2014-07-16 Thread Tom Gundersen
Signed-off-by: Tom Gundersen Cc: Karsten Keil --- This patch goes on top of net-next. drivers/isdn/i4l/isdn_common.c | 4 ++-- drivers/isdn/i4l/isdn_net.c| 10 +- drivers/isdn/i4l/isdn_net.h| 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/isdn

[PATCH v8] net: vlan - set name assign type

2014-07-16 Thread Tom Gundersen
When deriving the name from the real device, inherit the assign type, otherwise set PREDICTABLE as the name will be uniquely determined by the VLANID. Signed-off-by: Tom Gundersen Cc: Patrick McHardy --- This patch goes on top of net-next. net/8021q/vlan.c | 7 ++- 1 file changed, 6

[PATCH v8] net: nl80211 - make rdev_add_virtual_intf take name_assign_type

2014-07-16 Thread Tom Gundersen
Pass the value down and set it at the same place the name itself is set. Signed-off-by: Tom Gundersen Cc: Johannes Berg Cc: John Linville --- This patch goes on top of net-next. drivers/net/wireless/ath/ath6kl/cfg80211.c| 6 -- drivers/net/wireless/ath/ath6kl/cfg80211.h

[PATCH v8] net: openvswitch - set name assign type

2014-07-16 Thread Tom Gundersen
Signed-off-by: Tom Gundersen Cc: Pravin Shelar Cc: d...@openvswitch.org --- This patch goes on top of net-next. net/openvswitch/datapath.c | 1 + net/openvswitch/vport-internal_dev.c | 2 +- net/openvswitch/vport.h | 2 ++ 3 files changed, 4 insertions(+), 1 deletion

[PATCH v8] net: nl802154 - make add_iface take name assign type

2014-07-16 Thread Tom Gundersen
Signed-off-by: Tom Gundersen Acked-by: Alexander Aring Cc: Dmitry Eremin-Solenikov Cc: linux-zigbee-de...@lists.sourceforge.net --- This patch goes on top of net-next. include/net/wpan-phy.h | 4 +++- net/ieee802154/nl-phy.c| 5 - net/mac802154/ieee802154_dev.c | 7

[PATCH v8] net: ppp - set name assign type

2014-07-16 Thread Tom Gundersen
label it NET_NAME_USER. Signed-off-by: Tom Gundersen Cc: Paul Mackerras Cc: linux-...@vger.kernel.org --- This patch goes on top of net-next. drivers/net/ppp/ppp_generic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c index

Re: [PATCH v8] net: openvswitch - set name assign type

2014-07-16 Thread Tom Gundersen
On Thu, Jul 17, 2014 at 1:00 AM, Pravin Shelar wrote: > On Wed, Jul 16, 2014 at 3:43 PM, Tom Gundersen wrote: >> Signed-off-by: Tom Gundersen >> Cc: Pravin Shelar >> Cc: d...@openvswitch.org >> --- >> >> This patch goes on top of net-next. >>

Re: [PATCH v8] net: set name assign type for names assigned using a static string

2014-07-17 Thread Tom Gundersen
On Thu, Jul 17, 2014 at 8:56 AM, David Miller wrote: > Tom, even if the patches are sort of independent, they logically > belong together. > > So please number them, and provide an appropriate "[PATCH 0/N] ..." > cover letter. > > Please resubmit these patches with that done properly, thank you.

Re: [PATCH v8] net: set name assign type for names assigned using a static string

2014-07-17 Thread Tom Gundersen
On Thu, Jul 17, 2014 at 9:26 AM, Veaceslav Falico wrote: > On Thu, Jul 17, 2014 at 09:17:07AM +0200, Tom Gundersen wrote: >> >> On Thu, Jul 17, 2014 at 8:56 AM, David Miller wrote: >>> >>> Tom, even if the patches are sort of independent, they logically >&

[PATCH net-next v9 0/9] net: set the correct name_assign_type for more devices

2014-07-17 Thread Tom Gundersen
a problem) the correct name assign type Patch 4:do the same for devices created via ioctls Patch 5-9: cover a few individual drivers More individual drivers will be converted in a follow-up series. Tom Gundersen (9): net: set name assign type for names assigned using a static st

[PATCH net-next v9 1/9] net: set name assign type for names assigned using a static string

2014-07-17 Thread Tom Gundersen
This covers the trivial case: alloc_netdev(_, "bar", NET_NAME_PREDICTABLE, _); Signed-off-by: Tom Gundersen --- drivers/media/dvb-core/dvb_net.c | 2 +- drivers/misc/sgi-xp/xpnet.c | 2 +- drivers/net/caif/caif_virtio.c | 2 +- drivers/net/eql.c| 4 ++-- d

[PATCH net-next v9 2/9] net: nl80211 - make rdev_add_virtual_intf take name_assign_type

2014-07-17 Thread Tom Gundersen
Pass the value down and set it at the same place the name itself is set. Signed-off-by: Tom Gundersen Cc: Johannes Berg Cc: John Linville --- drivers/net/wireless/ath/ath6kl/cfg80211.c| 6 -- drivers/net/wireless/ath/ath6kl/cfg80211.h| 1 + drivers/net/wireless

[PATCH net-next v9 8/9] net: openvswitch - set name assign type

2014-07-17 Thread Tom Gundersen
Signed-off-by: Tom Gundersen Cc: Pravin Shelar Cc: d...@openvswitch.org --- v9: set NET_NAME_USER directly in internal_dev_create as requested by Pravin Shelar net/openvswitch/vport-internal_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/openvswitch/vport

[PATCH net-next v9 6/9] net: isdn - set name assign type

2014-07-17 Thread Tom Gundersen
Signed-off-by: Tom Gundersen Cc: Karsten Keil --- drivers/isdn/i4l/isdn_common.c | 4 ++-- drivers/isdn/i4l/isdn_net.c| 10 +- drivers/isdn/i4l/isdn_net.h| 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/isdn/i4l/isdn_common.c b/drivers/isdn/i4l

[PATCH net-next v9 7/9] net: vlan - set name assign type

2014-07-17 Thread Tom Gundersen
When deriving the name from the real device, inherit the assign type, otherwise set PREDICTABLE as the name will be uniquely determined by the VLANID. Signed-off-by: Tom Gundersen Cc: Patrick McHardy --- net/8021q/vlan.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a

[PATCH net-next v9 9/9] net: ppp - set name assign type

2014-07-17 Thread Tom Gundersen
label it NET_NAME_USER. Signed-off-by: Tom Gundersen Cc: Paul Mackerras Cc: linux-...@vger.kernel.org --- drivers/net/ppp/ppp_generic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c index c38ee90..6526057 100644 --- a/drivers/net

[PATCH net-next v9 4/9] net: set name_assign_type when setting names via ioctls

2014-07-17 Thread Tom Gundersen
When the user provides a name, set NET_NAME_USER, otherwise an enumerated name is used, so set NET_NAME_ENUM. Signed-off-by: Tom Gundersen --- drivers/net/tun.c | 9 ++--- drivers/tty/n_gsm.c | 10 +++--- net/atm/br2684.c | 5 +++-- net/bluetooth/bnep/core.c

[PATCH net-next v9 5/9] net: bond - make bond_create take name_assign_type

2014-07-17 Thread Tom Gundersen
Signed-off-by: Tom Gundersen Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek --- drivers/net/bonding/bond_main.c | 7 --- drivers/net/bonding/bond_sysfs.c | 2 +- drivers/net/bonding/bonding.h| 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net

[PATCH net-next v9 3/9] net: nl802154 - make add_iface take name assign type

2014-07-17 Thread Tom Gundersen
Signed-off-by: Tom Gundersen Acked-by: Alexander Aring Cc: Dmitry Eremin-Solenikov Cc: linux-zigbee-de...@lists.sourceforge.net --- include/net/wpan-phy.h | 4 +++- net/ieee802154/nl-phy.c| 5 - net/mac802154/ieee802154_dev.c | 7 --- 3 files changed, 11 insertions

Re: [PATCH net-next v9 2/9] net: nl80211 - make rdev_add_virtual_intf take name_assign_type

2014-07-17 Thread Tom Gundersen
On Thu, Jul 17, 2014 at 11:04 AM, Johannes Berg wrote: > On Thu, 2014-07-17 at 10:06 +0200, Tom Gundersen wrote: >> Pass the value down and set it at the same place the name itself is set. > > Huh? What's this? Can you explain why? Sure, sorry the context got lost. We want

Re: [PATCH v2] firmware loader: allow disabling of udev as firmware loader

2014-06-05 Thread Tom Gundersen
On Thu, Jun 5, 2014 at 3:31 PM, Ming Lei wrote: > On Thu, Jun 5, 2014 at 8:25 PM, Tom Gundersen wrote: >> >> On 5 Jun 2014 14:18, "Ming Lei" wrote: >>> >>> On Wed, Jun 4, 2014 at 11:48 PM, Takashi Iwai wrote: >>> > [The patch

Re: [PATCH v2] firmware loader: allow disabling of udev as firmware loader

2014-06-05 Thread Tom Gundersen
On Thu, Jun 5, 2014 at 3:59 PM, Ming Lei wrote: > On Thu, Jun 5, 2014 at 9:47 PM, Takashi Iwai wrote: >> At Thu, 5 Jun 2014 21:31:56 +0800, >> Ming Lei wrote: >>> >>> On Thu, Jun 5, 2014 at 8:25 PM, Tom Gundersen wrote: >>> > >>> > On

Re: [PATCH v2] firmware loader: allow disabling of udev as firmware loader

2014-06-05 Thread Tom Gundersen
Jun 2014 21:31:56 +0800, >>> > Ming Lei wrote: >>> >> >>> >> On Thu, Jun 5, 2014 at 8:25 PM, Tom Gundersen wrote: >>> >> > >>> >> > On 5 Jun 2014 14:18, "Ming Lei" wrote: >>> >> >> >>> >&

Re: [PATCH v2] firmware loader: allow disabling of udev as firmware loader

2014-06-05 Thread Tom Gundersen
On Thu, Jun 5, 2014 at 4:54 PM, Ming Lei wrote: >> Ubuntu currently enables the firmware loader in both the kernel and in >> udev, so would not yet have a problem here at the moment. However, I >> spoke with Martin Pitt and he told me that both Debian and Ubuntu >> would like to switch this off in

Re: [PATCH v2] firmware loader: allow disabling of udev as firmware loader

2014-06-06 Thread Tom Gundersen
On Fri, Jun 6, 2014 at 4:03 PM, Takashi Iwai wrote: > At Fri, 6 Jun 2014 07:00:22 +0800, > Ming Lei wrote: >> >> On Thu, Jun 5, 2014 at 11:15 PM, Tom Gundersen wrote: >> > On Thu, Jun 5, 2014 at 4:54 PM, Ming Lei wrote: >> >>> Ubuntu currently enables

Re: [PATCH] firmware loader: allow disabling of udev as firmware loader

2014-06-09 Thread Tom Gundersen
Hi Balaji, On Mon, Jun 9, 2014 at 3:26 PM, wrote: > The existing BIOS-DUP’s will not work on latest kernel, which has > CONFIG_FW_LOADER_USER_HELPER=n configured in Kernel config by default which > is not expected by the dell_rbu. > > > > We have made a changes in BIOS-Dell Update Package so th

Re: [PATCH] firmware loader: allow disabling of udev as firmware loader

2014-06-09 Thread Tom Gundersen
On Mon, Jun 9, 2014 at 4:01 PM, wrote: > Older userspace or existing DUP's doesn't work with your patch & > CONFIG_FW_LOADER_USER_HELPER=n. > > I will give a try with https://lkml.org/lkml/2014/6/4/327 new patch & let you > know ASAP. Thanks! Cheers, Tom -- To unsubscribe from this list: sen

Re: [PATCH v5 0/4] Provide netdev naming-policy via sysfs

2014-03-28 Thread Tom Gundersen
On Fri, Mar 28, 2014 at 7:54 PM, David Miller wrote: > From: David Herrmann > Date: Wed, 26 Mar 2014 14:05:13 +0100 > >> The main use-case is to allow udev to skip applying reliable ifnames to >> virtual >> devices. For instance, if wifi-P2P devices are created, wpas already >> provides a >> su

Re: [PATCH v5 0/4] Provide netdev naming-policy via sysfs

2014-03-28 Thread Tom Gundersen
On Fri, Mar 28, 2014 at 10:21 PM, David Miller wrote: > From: Tom Gundersen > Date: Fri, 28 Mar 2014 21:51:53 +0100 > >> On Fri, Mar 28, 2014 at 7:54 PM, David Miller wrote: >>> From: David Herrmann >>> Date: Wed, 26 Mar 2014 14:05:13 +0100 >>> >&

Re: [PATCH v5 0/4] Provide netdev naming-policy via sysfs

2014-03-29 Thread Tom Gundersen
On Sat, Mar 29, 2014 at 2:42 AM, David Miller wrote: > From: Tom Gundersen > Date: Fri, 28 Mar 2014 23:39:57 +0100 > >> You mean coordinate with each other in userspace? If so, I still don't >> see how this can ever be anything else than fragile. It will depend on &

[PATCH] firmware loader: allow disabling of udev as firmware loader

2014-06-02 Thread Tom Gundersen
al testing would be appreciated. Signed-off-by: Tom Gundersen Cc: Ming Lei Cc: Greg Kroah-Hartman Cc: Abhay Salunke Cc: Stefan Roese Cc: Arnd Bergmann Cc: Kay Sievers --- drivers/base/Kconfig | 10 +- drivers/base/firmware_class.c | 34 +++--

Re: [PATCH v2] net: tunnels - enable module autoloading

2014-06-02 Thread Tom Gundersen
On Wed, May 21, 2014 at 9:47 PM, David Miller wrote: > From: Tom Gundersen > Date: Thu, 15 May 2014 23:21:30 +0200 > >> Enable the module alias hookup to allow tunnel modules to be autoloaded on >> demand. >> >> This is in line with how most other netdev kinds w

Re: [PATCH] firmware loader: allow disabling of udev as firmware loader

2014-06-04 Thread Tom Gundersen
On Wed, Jun 4, 2014 at 4:20 PM, Takashi Iwai wrote: > At Mon, 2 Jun 2014 20:24:34 +0200, > Tom Gundersen wrote: >> >> Currently (at least) the dell-rbu driver selects FW_LOADER_USER_HELPER, >> which means that distros can't really stop loading firmware through u

Re: [PATCH] firmware loader: allow disabling of udev as firmware loader

2014-06-04 Thread Tom Gundersen
On Wed, Jun 4, 2014 at 4:31 PM, Takashi Iwai wrote: > At Wed, 04 Jun 2014 16:20:16 +0200, > Takashi Iwai wrote: >> >> At Mon, 2 Jun 2014 20:24:34 +0200, >> Tom Gundersen wrote: >> > >> > Currently (at least) the dell-rbu driver selects FW_LOADER_USER_H

Re: [PATCH] firmware loader: allow disabling of udev as firmware loader

2014-06-16 Thread Tom Gundersen
On Tue, Jun 10, 2014 at 5:13 PM, wrote: > I see contradiction of drivers/base/Kconfig here i.e, If I configure > DELL_RBU=y I cannot configure FW_LOADER_USER_HELPER=n. > with this patch https://lkml.org/lkml/2014/6/4/327 i cannot have > FW_LOADER_USER_HELPER=n & DELL_RBU=y at the same time. > I

Re: [PATCH] firmware loader: allow disabling of udev as firmware loader

2014-06-16 Thread Tom Gundersen
On Mon, Jun 16, 2014 at 4:08 PM, wrote: > Today I have tried with 3.15 the behavior is same as before. None of these patches were in 3.15, so that should behave as before. Cheers, Tom -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord.

[RFC][PATCH] module: allow multiple calls to MODULE_DEVICE_TABLE() per module

2014-01-27 Thread Tom Gundersen
Commit 78551277e4df5: "Input: i8042 - add PNP modaliases" had a bug, where the second call to MODULE_DEVICE_TABLE() overrode the first resulting in not all the modaliases being exposed. This fixes the problem by including the name of the device_id table in the __mod_*_device_table alias, allowing

Re: [RFC][PATCH] module: allow multiple calls to MODULE_DEVICE_TABLE() per module

2014-01-28 Thread Tom Gundersen
Hi Rusty, On Tue, Jan 28, 2014 at 2:35 AM, Rusty Russell wrote: > Tom Gundersen writes: >> Commit 78551277e4df5: "Input: i8042 - add PNP modaliases" had a bug, where >> the >> second call to MODULE_DEVICE_TABLE() overrode the first resulting in not all >>

[PATCH] module: allow multiple calls to MODULE_DEVICE_TABLE() per module

2014-01-28 Thread Tom Gundersen
, allowing us to export several device_id tables per module. Suggested-by: Kay Sievers Acked-by: Greg Kroah-Hartman Cc: Dmitry Torokhov Cc: Rusty Russell Signed-off-by: Tom Gundersen --- include/linux/module.h | 2 +- scripts/mod/file2alias.c | 14 +- 2 files changed, 10 insert

[PATCH] rtnetlink: return the newly created link in response to newlink

2014-01-30 Thread Tom Gundersen
Userspace needs to reliably know the ifindex of the netdevs it creates, as we cannot rely on the ifname staying unchanged. Earlier, a simlpe NLMSG_ERROR would be returned, but this returns the corresponding RTM_NEWLINK on success instead. Signed-off-by: Tom Gundersen Cc: Marcel Holtmann Cc

[PATCH] net: set default DEVTYPE for all ethernet based devices

2014-01-30 Thread Tom Gundersen
l#Type> [1]: <http://www.freedesktop.org/software/systemd/man/udev.html#Type> Signed-off-by: Tom Gundersen Cc: Marcel Holtmann Cc: Greg KH Cc: Kay Sievers --- net/ethernet/eth.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c in

Re: [PATCH] net: set default DEVTYPE for all ethernet based devices

2014-01-30 Thread Tom Gundersen
Hi Veaceslav, Thanks for your quick reply. On Thu, Jan 30, 2014 at 4:05 PM, Veaceslav Falico wrote: > On Thu, Jan 30, 2014 at 02:20:02PM +0100, Tom Gundersen wrote: >> >> In systemd's networkd and udevd, we would like to give the administrator a >> simple way to f

Re: [PATCH] rtnetlink: return the newly created link in response to newlink

2014-01-30 Thread Tom Gundersen
Hi Thomas, Thanks for your reply. On Thu, Jan 30, 2014 at 3:27 PM, Thomas Graf wrote: > On 01/30/14 at 02:05pm, Tom Gundersen wrote: >> Userspace needs to reliably know the ifindex of the netdevs it creates, >> as we cannot rely on the ifname staying unchanged. >>

Re: [PATCH RESEND][pciutils] libpci: pci_id_lookup - add udev/hwdb support

2013-10-25 Thread Tom Gundersen
On Fri, Sep 13, 2013 at 1:08 PM, Tom Gundersen wrote: > On Wed, Sep 4, 2013 at 4:59 PM, Tom Gundersen wrote: >> On Wed, Sep 4, 2013 at 3:57 PM, Martin Mares wrote: >>> Hello! >>> >>> First of all: Sorry for not replying to the first mail. I do not follow >

Re: [PATCH RESEND][pciutils] libpci: pci_id_lookup - add udev/hwdb support

2014-02-10 Thread Tom Gundersen
Ping? On Wed, Jan 29, 2014 at 5:13 PM, Tom Gundersen wrote: > Ping? > > On 30 Dec 2013 19:53, "Tom Gundersen" wrote: >> >> Hi Martin, >> >> On Sun, Dec 15, 2013 at 12:33 PM, Martin Mares wrote: >> > I see that a mechanism for fast lookup of

[PATCH] libpci: pci_id_lookup - add udev/hwdb support

2013-12-30 Thread Tom Gundersen
This lets you select hwdb support at compile time. hwdb is an efficient hardware database shipped with recent versions of udev. It contains among other sources pci.ids so querying hwdb rather than reading pci.ids directly should give the same result. Ideally Linux distros using udev could stop

Re: [PATCH RESEND][pciutils] libpci: pci_id_lookup - add udev/hwdb support

2013-12-30 Thread Tom Gundersen
Hi Martin, On Sun, Dec 15, 2013 at 12:33 PM, Martin Mares wrote: > I see that a mechanism for fast lookup of hardware identification data > is needed. However, why should such a mechanism depend on udev, systemd, > or Linux in general? > > What I would really like to have is a universal library f

Re: dell rbu driver and FW_LOADER_USER_HELPER

2014-08-26 Thread Tom Gundersen
On Tue, Aug 26, 2014 at 7:14 PM, Luis R. Rodriguez wrote: > On Tue, Aug 26, 2014 at 07:09:46PM +0200, Luis R. Rodriguez wrote: >> When Christian tried removing the udev firmware loader >> it was detected that the Dell rbu driver still required >> use of FW_LOADER_USER_HELPER [0]. This driver neede

Re: [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-09 Thread Tom Gundersen
On Tue, Sep 9, 2014 at 3:26 AM, Luis R. Rodriguez wrote: > On Mon, Sep 8, 2014 at 6:22 PM, Tejun Heo wrote: >> On Tue, Sep 09, 2014 at 10:10:59AM +0900, Tejun Heo wrote: >>> I'm not too convinced this is such a difficult problem to figure out. >>> We already have most of logic in place and the on

Re: [systemd-devel] [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-09 Thread Tom Gundersen
On Tue, Sep 9, 2014 at 10:45 PM, Luis R. Rodriguez wrote: > On Tue, Sep 9, 2014 at 12:35 PM, James Bottomley > wrote: >> On Tue, 2014-09-09 at 12:16 -0700, Luis R. Rodriguez wrote: >>> On Mon, Sep 8, 2014 at 10:38 PM, James Bottomley >>> wrote: >>> > If we want to sort out some sync/async mechan

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-08-11 Thread Tom Gundersen
On Mon, Aug 11, 2014 at 5:23 AM, Dexuan Cui wrote: >> -Original Message- >> From: Greg KH [mailto:gre...@linuxfoundation.org] >> > > > >> > > > IMO the most feasible and need-the-least-change solution may be: >> > > > the hyperv network VSC driver passes the event >> > > > RNDIS_STATUS_NET

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-08-13 Thread Tom Gundersen
On Tue, Aug 12, 2014 at 10:29 AM, Dexuan Cui wrote: >> From: Tom Gundersen >> > Unluckily this logic doesn't work because the user-space daemons >> > like ifplugd, usually don't renew the DHCP immediately as long as they >> > receive a link-down message

Re: [PATCH 00/12] Add kdbus implementation

2014-10-30 Thread Tom Gundersen
Hi Eric, On Thu, Oct 30, 2014 at 5:20 AM, Eric W. Biederman wrote: > The userspace API breaks userspace in an unfixable way. > > Nacked-by: "Eric W. Biederman" > > Problem the first. > - Using global names for containers makes it impossible to create > unprivileged containers. I don't follow.

Re: kdbus: add header file

2014-10-30 Thread Tom Gundersen
On Thu, Oct 30, 2014 at 9:20 AM, Arnd Bergmann wrote: > I think in general, using enum is great, but for ioctl command numbers, > we probably want to have defines so the user space implementation can > use #ifdef to see if the kernel version that it is being built for > knows a particular command.

Re: [PATCH 00/12] Add kdbus implementation

2014-10-30 Thread Tom Gundersen
On 10/30/2014 12:55 AM, Andy Lutomirski wrote:> It's worth noting that: > > - Proper credential passing could be added to UNIX sockets, and we > may want to do that anyway. Also, the current kdbus semantics seem to > be "spew lots of credentials and other miscellaneous > potentially-sensitive and

Re: [PATCH v1 5/5] driver-core: add driver asynchronous probe support

2014-10-01 Thread Tom Gundersen
On Tue, Sep 30, 2014 at 5:24 PM, Luis R. Rodriguez wrote: >> > commit e64fae5573e566ce4fd9b23c68ac8f3096603314 >> > Author: Kay Sievers >> > Date: Wed Jan 18 05:06:18 2012 +0100 >> > >> > udevd: kill hanging event processes after 30 seconds >> > >> > Some broken kernel drivers load firm

Re: [PATCH v1 5/5] driver-core: add driver asynchronous probe support

2014-10-03 Thread Tom Gundersen
On Thu, Oct 2, 2014 at 10:06 PM, Luis R. Rodriguez wrote: > On Thu, Oct 02, 2014 at 08:12:37AM +0200, Tom Gundersen wrote: >> Making kmod a special case is of course possible. However, as long as >> there is no fundamental reason why kmod should get this special >> treatment,

Re: udev/hwdb support in pciutils (Re: [PATCH RESEND][pciutils] libpci: pci_id_lookup - add udev/hwdb support)

2014-11-03 Thread Tom Gundersen
Hi Martin, On Sat, Nov 1, 2014 at 6:51 PM, Martin Mares wrote: > The support for hwdb has finally landed in mainline pciutils. > > I have modified your patch to bring it closer to the rest of device > naming logic. Namely: Great! Thanks for merging this, and for working on it. > Aside of the RE

Re: [systemd-devel] [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-10-10 Thread Tom Gundersen
On Fri, Oct 10, 2014 at 11:54 PM, Anatol Pomozov wrote: > 1) Why not to make the timeout configurable through config file? There > is already udev.conf you can put config option there. Thus people with > modprobe issues can easily "fix" the problem. And then decrease > default timeout back to 30 s

[PATCH] net: nl80211 - pass name_assign_type to rdev_add_virtual_intf()

2015-03-18 Thread Tom Gundersen
renamed, so userspace needs to be able to reliably tell the difference. Similar functionality was introduced for the rtnetlink core in commit 5517750. Signed-off-by: Tom Gundersen Cc: Kalle Valo Cc: Brett Rudley Cc: Arend van Spriel Cc: Franky (Zhenhui) Lin Cc: Hante Meuleman Cc: Johannes

Re: [RFC v1 02/14] bus1: provide stub cdev /dev/bus1

2016-10-26 Thread Tom Gundersen
On Thu, Oct 27, 2016 at 1:19 AM, Andy Lutomirski wrote: > This may have been covered elsewhere, but could this use syscalls instead? Yes, syscalls would work essentially the same. For now, we are using a cdev as it makes it a lot more convenient to develop and test as an out-of-tree module, but t

Re: [RFC v1 02/14] bus1: provide stub cdev /dev/bus1

2016-10-27 Thread Tom Gundersen
On Thu, Oct 27, 2016 at 11:11 AM, Arnd Bergmann wrote: > On Thursday, October 27, 2016 1:54:05 AM CEST Tom Gundersen wrote: >> On Thu, Oct 27, 2016 at 1:19 AM, Andy Lutomirski wrote: >> > This may have been covered elsewhere, but could this use syscalls instead? >> >

Re: [RFC v1 02/14] bus1: provide stub cdev /dev/bus1

2016-10-27 Thread Tom Gundersen
On Thu, Oct 27, 2016 at 6:37 PM, Linus Torvalds wrote: > On Thu, Oct 27, 2016 at 8:25 AM, Tom Gundersen wrote: >> >> Could you elaborate on why you think syscalls would be more >> appropriate than ioctls? > > ioctl's tend to be a horrid mess both for things like c

Re: [RFC v1 06/14] bus1: util - queue utility library

2016-10-28 Thread Tom Gundersen
On Thu, Oct 27, 2016 at 6:43 PM, Peter Zijlstra wrote: > On Wed, Oct 26, 2016 at 09:18:02PM +0200, David Herrmann wrote: > >> A bus1 message queue is a FIFO, i.e., messages are linearly ordered by >> the time they were sent. Moreover, atomic delivery of messages to >> multiple queues are supported

Re: [RFC v1 08/14] bus1: implement peer management context

2016-10-28 Thread Tom Gundersen
On Fri, Oct 28, 2016 at 2:06 PM, Richard Weinberger wrote: > David, Tom, > > On Wed, Oct 26, 2016 at 9:18 PM, David Herrmann wrote: >> +struct bus1_peer *bus1_peer_new(void) >> +{ >> + static atomic64_t peer_ids = ATOMIC64_INIT(0); >> + const struct cred *cred = current_cred(); >> +

Re: [RFC v1 08/14] bus1: implement peer management context

2016-10-28 Thread Tom Gundersen
On Fri, Oct 28, 2016 at 3:05 PM, Richard Weinberger wrote: > On Wed, Oct 26, 2016 at 9:18 PM, David Herrmann wrote: >> + /* initialize constant fields */ >> + peer->id = atomic64_inc_return(&peer_ids); >> + peer->flags = 0; >> + peer->cred = get_cred(current_cred()); >> +

Re: [RFC v1 00/14] Bus1 Kernel Message Bus

2016-10-28 Thread Tom Gundersen
On Fri, Oct 28, 2016 at 3:11 PM, Richard Weinberger wrote: > On Wed, Oct 26, 2016 at 9:17 PM, David Herrmann wrote: >> Hi >> >> This proposal introduces bus1.ko, a kernel messaging bus. This is not a >> request >> for inclusion, yet. It is rather an initial draft and a Request For Comments. >> >

Re: [RFC v1 06/14] bus1: util - queue utility library

2016-10-28 Thread Tom Gundersen
On Fri, Oct 28, 2016 at 3:33 PM, Peter Zijlstra wrote: > On Fri, Oct 28, 2016 at 01:33:25PM +0200, Tom Gundersen wrote: >> On Thu, Oct 27, 2016 at 6:43 PM, Peter Zijlstra wrote: >> > On Wed, Oct 26, 2016 at 09:18:02PM +0200, David Herrmann wrote: >> > >> >&

Re: [RFC v1 06/14] bus1: util - queue utility library

2016-10-28 Thread Tom Gundersen
On Fri, Oct 28, 2016 at 3:58 PM, Peter Zijlstra wrote: > On Fri, Oct 28, 2016 at 03:47:58PM +0200, Tom Gundersen wrote: >> On Fri, Oct 28, 2016 at 3:33 PM, Peter Zijlstra wrote: >> > On Fri, Oct 28, 2016 at 01:33:25PM +0200, Tom Gundersen wrote: > >> > And this, pr

Re: [PATCH 1/2] x86/sysfb: add support for 64bit EFI lfb_base

2016-11-15 Thread Tom Gundersen
ILITY_64BIT_BASE is set, the > screen_info->ext_lfb_base field will contain the upper 32bit of the > actual lfb_base. Make sure the address is not 0 (i.e., unset), as well as > does not overflow the physical address type. > > Signed-off-by: David Herrmann Reviewed-by: To

Re: [PATCH 2/2] x86/sysfb: fix lfb_size calculation

2016-11-15 Thread Tom Gundersen
e x86 simple-framebuffer setup code to use the correct size in the > non-VBE case. > > While at it, avoid variable abbreviations and rename 'len' to 'length', > and use the correct types matching the screen_info definition. > > Signed-off-by: David Herrmann Rev

[PATCH][RFC] usbhid: enable autosuspend for internal devices

2015-06-26 Thread Tom Gundersen
This policy used to be unconditionally applied by udev, but there is no reason to make userspace be involved in this and in the future udev will not be doing it by default. See: <https://github.com/systemd/systemd/pull/353>. Signed-off-by: Tom Gundersen Cc: Jiri Kosina Cc: Greg Kroah-H

Re: [!GIT PULL] kdbus for 4.2

2015-06-26 Thread Tom Gundersen
On Fri, Jun 26, 2015 at 9:33 PM, Andy Lutomirski wrote: > What's a good distro on which to poke at a full running system? Fedora Rawhide is probably currently your best bet. > Fedora Rawhide seems to still build systemd with --disable-kdbus, > although I suppose that means that I could boot it w

Re: [PATCH 2/8] driver-core: add asynchronous probing support for drivers

2015-07-07 Thread Tom Gundersen
On Tue, Jul 7, 2015 at 1:23 AM, Luis R. Rodriguez wrote: > On Sat, Jul 04, 2015 at 07:09:19AM -0700, Dan Williams wrote: >> On Fri, Jul 3, 2015 at 11:30 AM, Luis R. Rodriguez wrote: >> > On Sat, Jun 27, 2015 at 04:45:25PM -0700, Dan Williams wrote: >> >> On Mon, Mar 30, 2015 at 4:20 PM, Dmitry To

Re: [PATCH] net/unix: drop obsolete fd-recursion limits

2017-07-17 Thread Tom Gundersen
-Z > > With all of this in mind, lets drop the recursion limit. It has no > additional security value, anymore. On the contrary, it randomly > confuses message brokers that try to forward file-descriptors, since > any sendmsg(2) call can fail spuriously with ETOOMANYREFS if a client > ma

[tip:x86/urgent] x86/simplefb: Fix overflow causing bogus fall-back

2013-10-03 Thread tip-bot for Tom Gundersen
Commit-ID: e33a29a5ae711162c6b6fefc0a2ef18f4a4254bf Gitweb: http://git.kernel.org/tip/e33a29a5ae711162c6b6fefc0a2ef18f4a4254bf Author: Tom Gundersen AuthorDate: Tue, 1 Oct 2013 18:18:40 +0200 Committer: Ingo Molnar CommitDate: Wed, 2 Oct 2013 07:50:40 +0200 x86/simplefb: Fix overflow

<    1   2