Re: [PATCH linux-next] SUNRPC: rpcrdma_register_default_external: Dynamically allocate ib_phys_buf

2013-03-10 Thread Tom Tucker
rpc/xprtrdma/verbs.c:1774:1: warning: the frame size of 1056 bytes is larger than 1024 bytes [-Wframe-larger-than=] gcc version 4.6.3 Cc: Trond Myklebust Cc: "J. Bruce Fields" Cc: "David S. Miller" Cc: Tom Tucker Cc: Haggai Eran Cc: Or Gerlitz Cc: Shani Michael

Re: [PATCH linux-next v3] SUNRPC: rpcrdma_register_default_external: Dynamically allocate ib_phys_buf

2013-03-11 Thread Tom Tucker
3 Cc: Trond Myklebust Cc: "J. Bruce Fields" Cc: "David S. Miller" Cc: Tom Tucker Cc: Haggai Eran Cc: Or Gerlitz Cc: Shani Michaeli Cc: linux-...@vger.kernel.org Cc: net...@vger.kernel.org Signed-off-by: Tim Gardner --- v1 - Use kmalloc() to dynamically allocate and

Re: [PATCH linux-next v3] SUNRPC: rpcrdma_register_default_external: Dynamically allocate ib_phys_buf

2013-03-11 Thread Tom Tucker
AhOk On 3/11/13 9:53 PM, Tim Gardner wrote: On 03/11/2013 05:02 PM, Tom Tucker wrote: On 3/11/13 4:25 PM, J. Bruce Fields wrote: Looks good to me; wish we could get it tested I will test it. Tim could you please send me a final version that you'd like tested as a single me

Re: 2.6.24: RPC: bad TCP reclen 0x00020090 (large)

2008-02-18 Thread Tom Tucker
On Mon, 2008-02-18 at 04:58 -0800, Andrew Morton wrote: > (suitable cc added) > > (regression) > > On Wed, 13 Feb 2008 17:02:53 +0300 Michael Tokarev <[EMAIL PROTECTED]> wrote: > > > Hello! > > > > After upgrading to 2.6.24 (from .23), we're seeing ALOT > > of messages like in $subj in dmesg:

Re: 2.6.24: RPC: bad TCP reclen 0x00020090 (large)

2008-02-18 Thread Tom Tucker
On Mon, 2008-02-18 at 15:25 -0600, Tom Tucker wrote: > On Mon, 2008-02-18 at 04:58 -0800, Andrew Morton wrote: > > (suitable cc added) > > > > (regression) > > > > On Wed, 13 Feb 2008 17:02:53 +0300 Michael Tokarev <[EMAIL PROTECTED]> > > wrote: &

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-26 Thread Tom Tucker
On Tue, 2007-11-27 at 15:49 +1100, Rusty Russell wrote: > On Monday 26 November 2007 17:15:44 Roland Dreier wrote: > > > Except C doesn't have namespaces and this mechanism doesn't create them. > > > So this is just complete and utter makework; as I said before, noone's > > > going to confuse

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-27 Thread Tom Tucker
On Tue, 2007-11-27 at 18:15 +0100, Adrian Bunk wrote: > On Mon, Nov 26, 2007 at 11:35:42PM -0600, Tom Tucker wrote: > > On Tue, 2007-11-27 at 15:49 +1100, Rusty Russell wrote: > >... > > > No. That's the wrong question. What's the real upside? > > >

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-27 Thread Tom Tucker
On 11/27/07 7:27 PM, "Rusty Russell" <[EMAIL PROTECTED]> wrote: > On Tuesday 27 November 2007 16:35:42 Tom Tucker wrote: >> On Tue, 2007-11-27 at 15:49 +1100, Rusty Russell wrote: >> Explicitly documenting what comprises the kernel API (external, >> sup

Re: [ofa-general] iommu dma mapping alignment requirements

2007-12-20 Thread Tom Tucker
On Thu, 2007-12-20 at 11:14 -0600, Steve Wise wrote: > Hey Roland (and any iommu/ppc/dma experts out there): > > I'm debugging a data corruption issue that happens on PPC64 systems > running rdma on kernels where the iommu page size is 4KB yet the host > page size is 64KB. This "feature" was a

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-08-16 Thread Tom Tucker
On Wed, 2007-08-15 at 22:26 -0400, Jeff Garzik wrote: [...snip...] > > I think removing the RDMA stack is the wrong thing to do, and you > > shouldn't just threaten to yank entire subsystems because you don't like > > the technology. Lets keep this constructive, can we? RDMA should get > > t

Re: [PATCH v4 27/27] IB/Verbs: Cleanup rdma_node_get_transport()

2015-04-16 Thread Tom Tucker
On 4/16/15 8:45 AM, Michael Wang wrote: On 04/16/2015 03:42 PM, Hal Rosenstock wrote: On 4/16/2015 9:41 AM, Michael Wang wrote: On 04/16/2015 03:36 PM, Hal Rosenstock wrote: [snip] -EXPORT_SYMBOL(rdma_node_get_transport); - enum rdma_link_layer rdma_port_get_link_layer(struct ib_device *de

Re: [PATCH v5 19/27] IB/Verbs: Use management helper cap_iw_cm()

2015-04-20 Thread Tom Tucker
On 4/20/15 10:16 AM, Michael Wang wrote: On 04/20/2015 04:00 PM, Steve Wise wrote: On 4/20/2015 3:40 AM, Michael Wang wrote: [snip] diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 6805e3e..e4999f6 100644 --- a/include/rdma/ib_verbs.h +++ b/include/rdma/ib_verbs.h @@ -1818,

Re: [PATCH v5 19/27] IB/Verbs: Use management helper cap_iw_cm()

2015-04-20 Thread Tom Tucker
On 4/20/15 11:19 AM, Jason Gunthorpe wrote: On Mon, Apr 20, 2015 at 10:51:58AM -0500, Tom Tucker wrote: On 4/20/15 10:16 AM, Michael Wang wrote: On 04/20/2015 04:00 PM, Steve Wise wrote: On 4/20/2015 3:40 AM, Michael Wang wrote: [snip] diff --git a/include/rdma/ib_verbs.h b/include/rdma

Re: [PATCH v5 19/27] IB/Verbs: Use management helper cap_iw_cm()

2015-04-21 Thread Tom Tucker
On 4/21/15 2:39 AM, Michael Wang wrote: On 04/20/2015 05:51 PM, Tom Tucker wrote: [snip] int ib_query_gid(struct ib_device *device, u8 port_num, int index, union ib_gid *gid); iWARP devices _must_ support the IWCM so cap_iw_cm() is not really useful. Sean suggested to

Re: [PATCH 3.12 34/72] Fix regression in NFSRDMA server

2015-11-23 Thread Tom Tucker
Seems like part of a patch was dropped or there was a merge problem. The code in my tree has all these changes. Very strange. Tom On 11/23/15 7:08 AM, Jiri Slaby wrote: From: Tom Tucker 3.12-stable review patch. If anyone has any objections, please let me know. === commit