Re: [PATCH] watchdog: da9052: Fix invalid free of devm_ allocated data

2012-11-26 Thread Tushar Behera
On 11/26/2012 06:31 PM, Shubhrajyoti Datta wrote: > On Thu, Nov 22, 2012 at 10:13 AM, Tushar Behera > wrote: >> It is not required to free devm_ allocated data. Since kref_put >> needs a valid release function, da9052_wdt_release_resources() >> is not deleted. >&

[PATCH] clk: exynos5250: Fix divider values for sclk_mmc{0,1,2,3}

2013-04-02 Thread Tushar Behera
fixes this issue. dwmmc_exynos 1220.dwmmc0: data FIFO error (status=8020) mmcblk0: error -5 transferring data, sector 1, nr 7, cmd response 0x900, card status 0x0 end_request: I/O error, dev mmcblk0, sector 1 Signed-off-by: Tushar Behera CC: Thomas Abraham --- Based on Kukjin'

[PATCH V3 0/4] i2c: s3c2410: Add devm_* apis and cleanup

2013-01-24 Thread Tushar Behera
were replaced by devm_request_and_ioremap() call. * All devm_* related modifications (earlier patches 2-5) were merged to a single patch. Tushar Behera (4): i2c: s3c2410: Remove unnecessary label err_noclk i2c: s3c2410: Convert to use devm_* APIs i2c: s3c2410: Move location of

[PATCH V3 1/4] i2c: s3c2410: Remove unnecessary label err_noclk

2013-01-24 Thread Tushar Behera
err_noclk label redirects to a simple return statement. Move the return statement to the caller location and remove the label. Signed-off-by: Tushar Behera --- Changes since V2: * Rebased to v3.8-rc4. drivers/i2c/busses/i2c-s3c2410.c |9 +++-- 1 files changed, 3 insertions(+), 6

[PATCH V3 3/4] i2c: s3c2410: Move location of clk_prepare_enable() call in probe function

2013-01-24 Thread Tushar Behera
In i2c-s3c2410 driver probe, only s3c24xx_i2c_init() needs the I2C clock to be enabled. Moving clk_prepare_enable() and clk_disable_unprepare() calls to around this function simplifies the return path of probe call. Signed-off-by: Tushar Behera --- Changes since V2: * Rebased to v3.8-rc4

[PATCH V3 4/4] i2c: s3c2410: Remove err_cpufreq label

2013-01-24 Thread Tushar Behera
err_cpufreq label is now used only once. It can be removed and related code can be moved to the caller location. Signed-off-by: Tushar Behera --- Changes since V2: * Rebased to v3.8-rc4. Changes since V1: * Rebased as per the V2 patch series. drivers/i2c/busses/i2c-s3c2410.c |7

[PATCH V3 2/4] i2c: s3c2410: Convert to use devm_* APIs

2013-01-24 Thread Tushar Behera
i2c-s3c2410 driver is modified to use devm_clk_get() and devm_request_irq(). This also simplifies the return path in driver's probe. Signed-off-by: Tushar Behera --- Changes since V2: * Rebased on v3.8-rc4. devm_request_and_ioremap implementaion has already been merged. Changes sin

Re: Origen board hang with functionfs

2013-02-23 Thread Tushar Behera
On 22 February 2013 22:57, John Stultz wrote: > > On 02/21/2013 10:55 PM, Tushar Behera wrote: >> >> >> I think the issue is because of the USB phy regulators. LDO3 and LDO8 >> power the phy regulators for OTG and HOST. These regulators are disabled >> in OTG p

Re: Origen board hang with functionfs

2013-02-21 Thread Tushar Behera
active should solve the problem for the time being. I will follow-up with a patch shortly. But I am not sure if this patch will be considered for mainline as board patches are not getting accepted these days. -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe li

[PATCH] ARM: EXYNOS: Keep USB related LDOs always active on Origen

2013-02-21 Thread Tushar Behera
LDO3 and LDO8 are used for powering both device and host phy controllers. These regulators are not handled in USB host driver. Hence we get unexpected behaviour when the regulators are disabled elsewhere. It would be best to keep these regulators always on. Signed-off-by: Tushar Behera

[PATCH 0/2] ARM: EXYNOS: Set the capability of pdm0 and pdm1 as DMA_PRIVATE

2012-08-28 Thread Tushar Behera
DMA clients pdma0 and pdma1 are internal to the SoC and are used only by dedicated peripherals. Since they cannot be used for generic purpose, their capability should be set as DMA_PRIVATE. The patches are rebased on top of v3.6-rc3. Tushar Behera (2): ARM: EXYNOS: Set the capability of pdm0

[PATCH 1/2] ARM: EXYNOS: Set the capability of pdm0 and pdm1 as DMA_PRIVATE

2012-08-28 Thread Tushar Behera
DMA clients pdma0 and pdma1 are internal to the SoC and are used only by dedicated peripherals. Since they cannot be used for generic purpose, their capability should be set as DMA_PRIVATE. CC: Kukjin Kim Signed-off-by: Tushar Behera --- arch/arm/mach-exynos/dma.c |2 ++ 1 files changed, 2

[PATCH 2/2] DMA: PL330: Set the capability of pdm0 and pdm1 as DMA_PRIVATE

2012-08-28 Thread Tushar Behera
DMA clients pdma0 and pdma1 are internal to the SoC and are used only by dedicated peripherals. Since they cannot be used for generic purpose, their capability should be set as DMA_PRIVATE. CC: Vinod Koul Signed-off-by: Tushar Behera --- drivers/dma/pl330.c |1 + 1 files changed, 1

[PATCH] pwm: Fix compilation error when CONFIG_PWM is not defined

2012-09-10 Thread Tushar Behera
ed-by: Sachin Kamat Signed-off-by: Tushar Behera --- include/linux/pwm.h |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/include/linux/pwm.h b/include/linux/pwm.h index 21d076c..87e7f45 100644 --- a/include/linux/pwm.h +++ b/include/linux/pwm.h @@ -124,6 +124,7 @@ s

Re: [PATCH] pwm: Fix compilation error when CONFIG_PWM is not defined

2012-09-11 Thread Tushar Behera
On 09/11/2012 11:49 AM, Thierry Reding wrote: > On Tue, Sep 11, 2012 at 11:34:24AM +0530, Tushar Behera wrote: >> As per Documentation/pwm.txt, PWM_LOOKUP and pwm_add_table are used in >> board support files to add PWM chip entries. Currently these >> definitions are protec

[PATCH v2] pwm: Fix compilation error when CONFIG_PWM is not defined

2012-09-11 Thread Tushar Behera
Add dummy implemention of public symbols for compilation-safe inclusion of include/linux/pwm.h file when CONFIG_PWM is not defined. While at it, also reorganize the file. Reported-by: Sachin Kamat Signed-off-by: Tushar Behera --- Changes since v1: * Incorporated Thierry's suggestions rega

[PATCH] kbuild: setlocalversion: ignore private tags while reporting local version

2012-09-11 Thread Tushar Behera
ation with respect to Linux tags. CC: Michal Marek Signed-off-by: Tushar Behera --- scripts/setlocalversion |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/scripts/setlocalversion b/scripts/setlocalversion index bd6dca8..d2c857c 100755 --- a/scripts/setlocalversion +++

Re: [PATCH v2] pwm: Fix compilation error when CONFIG_PWM is not defined

2012-09-12 Thread Tushar Behera
On 09/11/2012 08:18 PM, Thierry Reding wrote: > On Tue, Sep 11, 2012 at 03:14:15PM +0530, Tushar Behera wrote: >> Add dummy implemention of public symbols for compilation-safe inclusion >> of include/linux/pwm.h file when CONFIG_PWM is not defined. >> >> While at i

[PATCH v3] pwm: Fix compilation error when CONFIG_PWM is not defined

2012-09-12 Thread Tushar Behera
Add dummy implemention of public symbols for compilation-safe inclusion of include/linux/pwm.h file when CONFIG_PWM is not defined. Reported-by: Sachin Kamat Signed-off-by: Tushar Behera --- Changes since v2: * #if condition for legacy functions modified * Reverted layout changes, can be taken

[PATCH v2] kbuild: setlocalversion: ignore private tags while reporting local version

2012-09-12 Thread Tushar Behera
nformation with respect to Linux tags. CC: Michal Marek Signed-off-by: Tushar Behera --- Changes since v1: * Extend the fix when the HEAD is a private tagged commit scripts/setlocalversion |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/setlocalversion

[PATCH v4] pwm: Fix compilation error when CONFIG_PWM is not defined

2012-09-12 Thread Tushar Behera
Add dummy implemention of public symbols for compilation-safe inclusion of include/linux/pwm.h file when CONFIG_PWM is not defined. Reported-by: Sachin Kamat Signed-off-by: Tushar Behera --- Changes since v3: * Nitpicks Changes since v2: * #if condition for legacy functions modified * Reverted

[PATCH] Staging: bcm: Fix udelay related compilation error

2012-09-13 Thread Tushar Behera
_wimax.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2 Cc: Kevin McKinney Cc: Greg Kroah-Hartman Signed-off-by: Tushar Behera --- drivers/staging/bcm/nvm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/bcm/nvm.c b/drivers/sta

Re: [PATCH] usb: phy: samsung-usb2: Toggle HSIC GPIO from device tree

2013-08-27 Thread Tushar Behera
On 28 August 2013 00:14, Felipe Balbi wrote: > On Tue, Aug 13, 2013 at 02:11:27PM +0530, Tushar Behera wrote: >> On 12 July 2013 12:27, Felipe Balbi wrote: >> > Hi, >> > >> > On Wed, Jul 10, 2013 at 10:42:27AM -0700, Julius Werner wrote: >> >> Hi F

Re: [PATCH] I2C: EXYNOS: Add slave support to i2c

2012-12-07 Thread Tushar Behera
msung,i2c-slave-addr", > &pdata->slave_addr); > of_property_read_u32(np, "samsung,i2c-max-bus-freq", > (u32 *)&pdata->frequency); > + of_property_read_u32(np, "samsung,i2c-mode", &i2c->i2c

Re: [PATCH 0/8] Fix coding style in sdhci.c

2012-11-11 Thread Tushar Behera
t; Best Regards, > Jaehoon Chung > > On 11/09/2012 08:39 PM, Tushar Behera wrote: >> Documents/CodingStyle Chapter 3 recommends usage of braces for both >> if and else statements if any of the branches contains multiple >> statements. >> >> Cleaning up drivers/mm

Re: [PATCH] regulator: core: Update regulator_is_supported_voltage for fixed voltages

2012-11-11 Thread Tushar Behera
On 11/09/2012 10:39 PM, Mark Brown wrote: > On Fri, Nov 09, 2012 at 04:21:49PM +0530, Tushar Behera wrote: > >> In case of fixed regulators for which voltage cannot be changed, >> regulator_is_supported_voltage should return success only if the >> min_uV and max_uV param

Re: [PATCH 0/8] Fix coding style in sdhci.c

2012-11-11 Thread Tushar Behera
On 11/12/2012 12:42 PM, Chris Ball wrote: > Hi, > > On Sun, Nov 11 2012, Tushar Behera wrote: >> Yes, I can do that. I did split it specifically so that we could drop >> any patches if required. >> >> I will wait for a word from Chris regarding what he prefer

[PATCH] [media] videobuf2-core: print current state of buffer in vb2_buffer_done

2012-11-12 Thread Tushar Behera
In vb2_buffer_done, it would be better the print the value of 'state' (current state of buffer) than to print 'vb->state' which is always VB2_BUF_STATE_ACTIVE. Signed-off-by: Tushar Behera --- drivers/media/v4l2-core/videobuf2-core.c |2 +- 1 files changed, 1 ins

[PATCH v2] regulator: core: Update regulator_is_supported_voltage for fixed voltages

2012-11-13 Thread Tushar Behera
Commit c5f3939b8fe0 ("regulator: core: Support fixed voltages in regulator_is_supported_voltage()") returns success when the regulator voltage is less than both min_uV and max_uV. Modify this to return success only when the regulator voltage is within the specified range. Signed-off-

[PATCH] regulator: core: Update regulator_is_supported_voltage for fixed voltages

2012-11-09 Thread Tushar Behera
ss only if the min_uV and max_uV parameters are same and it is equal to the current voltage of the regulator. Signed-off-by: Tushar Behera --- Currently this patch breaks MMC support for boards on which vmmc is a fixed regulator and the voltage is not equal to either of 3.3v, 3.0v or 1.8v. Earlier

[PATCH 0/8] Fix coding style in sdhci.c

2012-11-09 Thread Tushar Behera
Documents/CodingStyle Chapter 3 recommends usage of braces for both if and else statements if any of the branches contains multiple statements. Cleaning up drivers/mmc/host/sdhci.c for all these occurrences. Tushar Behera (8): mmc: sdhci: fix coding style in sdhci_calc_timeout mmc: sdhci

[PATCH 1/8] mmc: sdhci: fix coding style in sdhci_calc_timeout

2012-11-09 Thread Tushar Behera
Signed-off-by: Tushar Behera --- drivers/mmc/host/sdhci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index c7851c0..2ff2b9e 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -667,9 +667,9

[PATCH 3/8] mmc: sdhci: fix coding style in sdhci_finish_data

2012-11-09 Thread Tushar Behera
Signed-off-by: Tushar Behera --- drivers/mmc/host/sdhci.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 2d3d76e..73bb41f 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -924,9

[PATCH 5/8] mmc: sdhci: fix coding style in sdhci_do_set_ios

2012-11-09 Thread Tushar Behera
Signed-off-by: Tushar Behera --- drivers/mmc/host/sdhci.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 28da461..b947155 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -1386,9

[PATCH 6/8] mmc: sdhci: fix coding style in sdhci_execute_tuning

2012-11-09 Thread Tushar Behera
Signed-off-by: Tushar Behera --- drivers/mmc/host/sdhci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index b947155..4bed582 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -1792,9 +1792,9

[PATCH 7/8] mmc: sdhci: fix coding style in sdhci_data_irq

2012-11-09 Thread Tushar Behera
Signed-off-by: Tushar Behera --- drivers/mmc/host/sdhci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 4bed582..47cac71 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -2286,9 +2286,9

[PATCH 8/8] mmc: sdhci: fix coding style in sdhci_add_host

2012-11-09 Thread Tushar Behera
Signed-off-by: Tushar Behera --- drivers/mmc/host/sdhci.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 47cac71..5cddb74 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c

[PATCH 4/8] mmc: sdhci: fix coding style in sdhci_set_clock

2012-11-09 Thread Tushar Behera
Signed-off-by: Tushar Behera --- drivers/mmc/host/sdhci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 73bb41f..28da461 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -1138,9 +1138,9

[PATCH 2/8] mmc: sdhci: fix coding style in sdhci_set_transfer_mode

2012-11-09 Thread Tushar Behera
Signed-off-by: Tushar Behera --- drivers/mmc/host/sdhci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 2ff2b9e..2d3d76e 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -898,9 +898,9

Re: [PATCH 10/14] atm: Removed redundant check on unsigned variable

2012-12-27 Thread Tushar Behera
Ping. On 11/16/2012 12:20 PM, Tushar Behera wrote: > No need to check whether unsigned variable is less than 0. > > CC: Chas Williams > CC: linux-atm-gene...@lists.sourceforge.net > CC: net...@vger.kernel.org > Signed-off-by: Tushar Behera > --- > drivers/atm/fore200

Re: [PATCH 08/14] xen: netback: Remove redundant check on unsigned variable

2012-12-27 Thread Tushar Behera
On 11/16/2012 02:46 PM, Ian Campbell wrote: > On Fri, 2012-11-16 at 06:50 +0000, Tushar Behera wrote: >> No need to check whether unsigned variable is less than 0. >> >> CC: Ian Campbell >> CC: xen-de...@lists.xensource.com >> CC: net...@vger.kernel.org >> S

Re: [PATCH RESEND] ARM: dts: Add EHCI device tree node for Exynos4

2012-12-30 Thread Tushar Behera
st = { > OF_DEV_AUXDATA("arm,pl330", EXYNOS4_PA_MDMA1, "dma-pl330.2", NULL), > OF_DEV_AUXDATA("samsung,exynos4210-tmu", EXYNOS4_PA_TMU, > "exynos-tmu", NULL), > + OF_DEV_AUXDATA("samsung,exynos-ehci

[PATCH] ARM: DTS: exynos4210-origen: Add MAX8997 node entry

2013-01-04 Thread Tushar Behera
The node entry is added as per documentation and legacy board file. Signed-off-by: Tushar Behera --- The patch is rebased on v3.8-rc1. arch/arm/boot/dts/exynos4210-origen.dts | 150 +++ 1 files changed, 150 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot

[PATCH 01/14] [media] ivtv: Remove redundant check on unsigned variable

2012-11-15 Thread Tushar Behera
No need to check whether unsigned variable is less than 0. CC: Mauro Carvalho Chehab CC: ivtv-de...@ivtvdriver.org CC: linux-me...@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/media/pci/ivtv/ivtv-ioctl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a

[PATCH 04/14] [media] tlg2300: Remove redundant check on unsigned variable

2012-11-15 Thread Tushar Behera
No need to check whether unsigned variable is less than 0. CC: Mauro Carvalho Chehab CC: linux-me...@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/media/usb/tlg2300/pd-video.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/usb/tlg2300/pd

[PATCH 09/14] xen: events: Remove redundant check on unsigned variable

2012-11-15 Thread Tushar Behera
No need to check whether unsigned variable is less than 0. CC: Konrad Rzeszutek Wilk CC: Jeremy Fitzhardinge CC: xen-de...@lists.xensource.com CC: virtualizat...@lists.linux-foundation.org Signed-off-by: Tushar Behera --- drivers/xen/events.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 11/14] HID: hiddev: Remove redundant check on unsigned variable

2012-11-15 Thread Tushar Behera
No need to check whether unsigned variable is less than 0. CC: Jiri Kosina CC: linux-...@vger.kernel.org CC: linux-in...@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/hid/usbhid/hiddev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/hid/usbhid

[PATCH 13/14] misc: tsl2550: Remove redundant check on unsigned variable

2012-11-15 Thread Tushar Behera
No need to check whether unsigned variable is less than 0. CC: Arnd Bergmann Signed-off-by: Tushar Behera --- drivers/misc/tsl2550.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/tsl2550.c b/drivers/misc/tsl2550.c index 0beb298..0438569 100644 --- a

[PATCH 12/14] gru: Remove redundant check on unsigned variable

2012-11-15 Thread Tushar Behera
No need to check whether unsigned variable is less than 0. CC: Jack Steiner Signed-off-by: Tushar Behera --- drivers/misc/sgi-gru/grukdump.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru/grukdump.c index 9b2062d

[PATCH 14/14] wlcore: Remove redundant check on unsigned variable

2012-11-15 Thread Tushar Behera
No need to check whether unsigned variable is less than 0. CC: Luciano Coelho CC: linux-wirel...@vger.kernel.org CC: net...@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/net/wireless/ti/wlcore/debugfs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a

[PATCH 10/14] atm: Removed redundant check on unsigned variable

2012-11-15 Thread Tushar Behera
No need to check whether unsigned variable is less than 0. CC: Chas Williams CC: linux-atm-gene...@lists.sourceforge.net CC: net...@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/atm/fore200e.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/atm

[PATCH 00/14] Modify signed comparisons of unsigned variables

2012-11-15 Thread Tushar Behera
. Tushar Behera (14): [media] ivtv: Remove redundant check on unsigned variable [media] meye: Remove redundant check on unsigned variable [media] saa7134: Remove redundant check on unsigned variable [media] tlg2300: Remove redundant check on unsigned variable [media] atmel-isi: Update error check

[PATCH 03/14] [media] saa7134: Remove redundant check on unsigned variable

2012-11-15 Thread Tushar Behera
No need to check whether the unsigned variable is less than 0. CC: Mauro Carvalho Chehab CC: linux-me...@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/media/pci/saa7134/saa7134-video.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/pci

[PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables

2012-11-15 Thread Tushar Behera
Checking '< 0' for unsigned variables always returns false. For error codes, use IS_ERR_VALUE() instead. CC: Mauro Carvalho Chehab CC: linux-me...@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/media/platform/soc_camera/atmel-isi.c |2 +- 1 files changed, 1 ins

[PATCH 06/14] pinctrl: samsung: Update error check for unsigned variables

2012-11-15 Thread Tushar Behera
Checking '< 0' for unsigned variables always returns false. For error codes, use IS_ERR_VALUE() instead. CC: Linus Walleij Signed-off-by: Tushar Behera --- drivers/pinctrl/pinctrl-samsung.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/pi

[PATCH 08/14] xen: netback: Remove redundant check on unsigned variable

2012-11-15 Thread Tushar Behera
No need to check whether unsigned variable is less than 0. CC: Ian Campbell CC: xen-de...@lists.xensource.com CC: net...@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/net/xen-netback/netback.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net

[PATCH 07/14] pinctrl: SPEAr: Update error check for unsigned variables

2012-11-15 Thread Tushar Behera
Checking '< 0' for unsigned variables always returns false. For error codes, use IS_ERR_VALUE() instead. CC: Linus Walleij Signed-off-by: Tushar Behera --- drivers/pinctrl/spear/pinctrl-plgpio.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/

[PATCH 02/14] [media] meye: Remove redundant check on unsigned variable

2012-11-15 Thread Tushar Behera
No need to check whether unsigned variable is less than 0. CC: Mauro Carvalho Chehab CC: linux-me...@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/media/pci/meye/meye.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/pci/meye/meye.c b/drivers

Re: [PATCH 09/14] xen: events: Remove redundant check on unsigned variable

2012-11-18 Thread Tushar Behera
igned some error value, that would be caught by the check irq >= nr_irqs. > Konrad Rzeszutek Wilk wrote: > >> On Fri, Nov 16, 2012 at 12:20:41PM +0530, Tushar Behera wrote: >>> No need to check whether unsigned variable is less than 0. >>> >>> CC: Konrad

Re: [PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables

2012-11-18 Thread Tushar Behera
On 11/18/2012 04:46 AM, Guennadi Liakhovetski wrote: > On Fri, 16 Nov 2012, Tushar Behera wrote: > >> Checking '< 0' for unsigned variables always returns false. For error >> codes, use IS_ERR_VALUE() instead. > > Wouldn't just changing "irq"

Re: [Xen-devel] [PATCH 09/14] xen: events: Remove redundant check on unsigned variable

2012-11-19 Thread Tushar Behera
On 11/19/2012 04:01 PM, Ian Campbell wrote: > On Mon, 2012-11-19 at 03:52 +0000, Tushar Behera wrote: >> On 11/16/2012 10:23 PM, Jeremy Fitzhardinge wrote: >>> To be honest I'd nack this kind of patch. The test is only redundant in the >>> most trivial sense that

[PATCH] block: Fix sparse warning

2012-11-19 Thread Tushar Behera
blk_drain_queue is only used in this file, so should be marked static. Fixes following sparse warning. block/blk-core.c:361:6: warning: symbol 'blk_drain_queue' was not declared. Should it be static? Signed-off-by: Tushar Behera --- block/blk-core.c |2 +- 1 files changed, 1

[PATCH] fsnotify: Fix sparse warning

2012-11-19 Thread Tushar Behera
Fixes following sparse warning. fs/notify/inode_mark.c:127:22: warning: symbol 'fsnotify_find_inode_mark_locked' was not declared. Should it be static? Signed-off-by: Tushar Behera --- fs/notify/inode_mark.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a

[PATCH] bug: Fix sparse warning related to BUILD_BUG_ON_INVALID

2012-11-19 Thread Tushar Behera
lemap.c:396:9: error: undefined identifier 'BUILD_BUG_ON_INVALID' mm/filemap.c:397:9: error: undefined identifier 'BUILD_BUG_ON_INVALID' include/linux/mm.h:419:9: error: undefined identifier 'BUILD_BUG_ON_INVALID' include/linux/mm.h:419:9: error: not a function Sign

Re: [PATCH] clk: exynos5250: Fix divider values for sclk_mmc{0,1,2,3}

2013-04-22 Thread Tushar Behera
On 04/22/2013 11:10 PM, Olof Johansson wrote: > Hi, > > On Tue, Apr 16, 2013 at 12:35 PM, Doug Anderson wrote: >> Hi, >> >> On Mon, Apr 8, 2013 at 12:22 AM, Kukjin Kim wrote: >>> Mike Turquette wrote: >>>> >>>> Quoting Tushar Behera (

[PATCH] clk: exynos5250: Fix parent clock for sclk_mmc{0,1,2,3}

2013-04-22 Thread Tushar Behera
n its value set during preboot, sclk_mmc value was different for various boards. Setting the correct clock generation path should fix the issues reported in above referenced commit. The changes committed during the earlier patch has also been reverted here. Signed-off-by: Tushar Behera CC: D

Re: [PATCH 09/15] net: can: Convert to use devm_ioremap_resource

2013-06-12 Thread Tushar Behera
On 06/10/2013 05:05 PM, Tushar Behera wrote: > Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()") > introduced devm_ioremap_resource() and deprecated the use of > devm_request_and_ioremap(). > > Signed-off-by: Tushar Behera > CC: net...

Re: [PATCH v2 2/3] ARM: SAMSUNG: Consolidate uncompress subroutine

2013-06-12 Thread Tushar Behera
On 06/04/2013 09:49 AM, Tushar Behera wrote: > For mach-exynos, uart_base is a pointer and the value is calculated > in the machine folder. For other machines, uart_base is defined as > a macro in platform directory. For symmetry, the uart_base macro > definition is removed and t

Re: [PATCH v2 3/3] ARM: s5p64x0: Use common uncompress.h part for plat-samsung

2013-06-12 Thread Tushar Behera
On 06/04/2013 09:49 AM, Tushar Behera wrote: > From: Tomasz Figa > > Since uart_base can be set dynamically in arch_detect_cpu(), there is no > need to have a copy of all code locally, just to override UART base > address. > > This patch removes any duplicate code in un

Re: [PATCH 2/2] clk: exynos4: Add alias for cpufreq related clocks

2013-06-16 Thread Tushar Behera
On 06/11/2013 12:23 AM, Tomasz Figa wrote: > On Monday 10 of June 2013 09:13:11 Tushar Behera wrote: >> On 06/08/2013 05:20 PM, Tomasz Figa wrote: >>> On Thursday 06 of June 2013 16:52:28 Tushar Behera wrote: [ ... ] >>>>MUX_A(mout_core

Re: [PATCH 02/15] sudmac: Convert to use devm_ioremap_resource

2013-06-16 Thread Tushar Behera
On 06/10/2013 05:05 PM, Tushar Behera wrote: > Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()") > introduced devm_ioremap_resource() and deprecated the use of > devm_request_and_ioremap(). > > Signed-off-by: Tushar Behera > CC: Vi

Re: [PATCH 03/15] mmc: mvsdio: Convert to use devm_ioremap_resource

2013-06-16 Thread Tushar Behera
On 06/10/2013 05:05 PM, Tushar Behera wrote: > Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()") > introduced devm_ioremap_resource() and deprecated the use of > devm_request_and_ioremap(). > > Signed-off-by: Tushar Behera > CC: linux-...@vger

Re: [PATCH 04/15] gpio_msm: Convert to use devm_ioremap_resource

2013-06-16 Thread Tushar Behera
On 06/10/2013 05:05 PM, Tushar Behera wrote: > Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()") > introduced devm_ioremap_resource() and deprecated the use of > devm_request_and_ioremap(). > > Signed-off-by: Tushar Behera > CC: linux-g...@vger.ke

Re: [PATCH 05/15] gpio-sta2x11: Convert to use devm_ioremap_resource

2013-06-16 Thread Tushar Behera
On 06/10/2013 05:05 PM, Tushar Behera wrote: > Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()") > introduced devm_ioremap_resource() and deprecated the use of > devm_request_and_ioremap(). > > Signed-off-by: Tushar Behera > CC: linux-g...@vger.k

Re: [PATCH 11/15] regulator: ti-abb: Convert to use devm_ioremap_resource

2013-06-17 Thread Tushar Behera
On 06/10/2013 05:05 PM, Tushar Behera wrote: > Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()") > introduced devm_ioremap_resource() and deprecated the use of > devm_request_and_ioremap(). > > Signed-off-by: Tushar Behera > CC: Mar

[PATCH V2 1/15] sparc,leon: Convert to use devm_ioremap_resource

2013-06-17 Thread Tushar Behera
Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()") introduced devm_ioremap_resource() and deprecated the use of devm_request_and_ioremap(). While at it, also remove the error message as devm_ioremap_resource() also prints similar error message. Signed-off-by: Tus

[PATCH V2 12/15] ASoC: spear: Convert to use devm_ioremap_resource

2013-06-17 Thread Tushar Behera
rce prints error message on failure, there is no need to print an explicit warning message. Signed-off-by: Tushar Behera CC: alsa-de...@alsa-project.org CC: Liam Girdwood CC: Mark Brown --- Changes for V2: * Removed redundant print of error message from devm_ioremap_resource exit path

[PATCH V2 6/6] pci: mvebu: Convert to use devm_ioremap_resource

2013-06-17 Thread Tushar Behera
Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()") introduced devm_ioremap_resource() and deprecated the use of devm_request_and_ioremap(). While at it, modify mvebu_pcie_map_registers() to propagate error code. Signed-off-by: Tushar Behera CC: linux-...@vger.ker

Re: [PATCH 11/15] regulator: ti-abb: Convert to use devm_ioremap_resource

2013-06-17 Thread Tushar Behera
On 06/17/2013 03:35 PM, Mark Brown wrote: > On Mon, Jun 17, 2013 at 02:42:25PM +0530, Tushar Behera wrote: >> On 06/10/2013 05:05 PM, Tushar Behera wrote: >>> Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()") >>> introduced devm_ioremap

[PATCH V3 12/15] ASoC: spear: Convert to use devm_ioremap_resource

2013-06-17 Thread Tushar Behera
rce prints error message on failure, there is no need to print an explicit warning message. Signed-off-by: Tushar Behera CC: alsa-de...@alsa-project.org CC: Liam Girdwood CC: Mark Brown --- Changes for V3: * Rebased on for-next branch of sound/soc git tree git://git.kernel.org/pub/scm/linux/

[PATCH v2 0/3] Consolidate uncompress code for Samsung platform

2013-06-03 Thread Tushar Behera
that almost does the same thing. Tomasz Figa (1): ARM: s5p64x0: Use common uncompress.h part for plat-samsung Tushar Behera (2): ARM: EXYNOS: uncompress - print debug messages if DEBUG_LL is defined ARM: SAMSUNG: Consolidate uncompress subroutine arch/arm/mach-exynos/include/mach/uncompr

[PATCH v2 1/3] ARM: EXYNOS: uncompress - print debug messages if DEBUG_LL is defined

2013-06-03 Thread Tushar Behera
onfig file, we would be able to boot multiple boards with different default UART ports. With this current approach, we miss the print "Uncompressing Linux... done, booting the kernel." when DEBUG_LL is not defined. Signed-off-by: Tushar Behera --- Change for v2: * Instead of checking val

[PATCH v2 2/3] ARM: SAMSUNG: Consolidate uncompress subroutine

2013-06-03 Thread Tushar Behera
would help us consolidating uncompress subroutine for s5p64x0. Signed-off-by: Tushar Behera --- Changes for v2: * Remove ifdef's while calculating uart_base value. arch/arm/mach-exynos/include/mach/uncompress.h |3 --- arch/arm/mach-s3c24xx/include/mach/uncompress.h |3 +++ arch/arm

[PATCH v2 3/3] ARM: s5p64x0: Use common uncompress.h part for plat-samsung

2013-06-03 Thread Tushar Behera
initialize UART with SoC-specific parameters. While at it, replace hard-coded register address with macro. Signed-off-by: Tomasz Figa Signed-off-by: Tushar Behera --- (This patch replaces the original patch in this patchset as it was an earlier-posted near-identical patch.) Changes for v2

Re: [PATCH] ARM: EXYNOS: Consolidate multiple low-level UART port definitions

2013-06-04 Thread Tushar Behera
On 05/31/2013 11:50 PM, Kevin Hilman wrote: > Tushar Behera writes: > >> There are two definitions for low-level UART ports for Exynos platform. >> CONFIG_S3C_LOWLEVEL_UART_PORT is used for printing "Uncompressing >> Linux... done, booting the kernel." and CONF

[PATCH] clk: exynos5250: Add CLK_IGNORE_UNUSED flag for pmu clock

2013-06-06 Thread Tushar Behera
ing the default behaviour, system reboot starts working. Signed-off-by: Tushar Behera --- drivers/clk/samsung/clk-exynos5250.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/samsung/clk-exynos5250.c b/drivers/clk/samsung/clk-exynos5250.c index 5c97e75..3853da9 10064

Re: [PATCH 0/2] Clock changes for supporting CPUFreq on Exynos5250

2013-06-06 Thread Tushar Behera
On 05/30/2013 04:12 AM, Mike Turquette wrote: > Quoting Tushar Behera (2013-05-27 22:38:44) >> On 05/17/2013 11:25 AM, Tushar Behera wrote: >>> With the use of common clock framework, CPUFreq driver on EXYNOS5250 now >>> requires a few changes in clocks. >>> &g

Re: [PATCH v2 1/3] ARM: EXYNOS: uncompress - print debug messages if DEBUG_LL is defined

2013-06-06 Thread Tushar Behera
On 06/04/2013 09:49 AM, Tushar Behera wrote: > Printing low-level debug messages make an assumption that the specified > UART port has been preconfigured by the bootloader. Incorrectly > specified UART port results in system getting stalled while printing the > message "Uncompress

[PATCH 0/2] Clock update for EXYNOS4210-CPUFREQ driver

2013-06-06 Thread Tushar Behera
cpufreq driver for EXYNOS4 based SoCs are not platform drivers, hence we cannot currently pass the clock names through a device tree node. Instead, we need to make them available through global alias. The patches are based on next-20130606. Tushar Behera (2): clk: samsung: Add MUX_FA macro to

[PATCH 1/2] clk: samsung: Add MUX_FA macro to pass flag and alias

2013-06-06 Thread Tushar Behera
. Signed-off-by: Tushar Behera --- drivers/clk/samsung/clk.h |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/samsung/clk.h b/drivers/clk/samsung/clk.h index e4ad6ea..2f7dba2 100644 --- a/drivers/clk/samsung/clk.h +++ b/drivers/clk/samsung/clk.h @@ -144,6 +144,9 @@ struct

[PATCH 2/2] clk: exynos4: Add alias for cpufreq related clocks

2013-06-06 Thread Tushar Behera
lock aliases are defined. Signed-off-by: Tushar Behera --- drivers/clk/samsung/clk-exynos4.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk-exynos4.c index 3c1f888..1e4258a 100644 --- a/drivers/clk/samsung

Re: [PATCH 0/2] Clock changes for supporting CPUFreq on Exynos5250

2013-06-06 Thread Tushar Behera
was added during 3.10, this holds good for other EXYNOS5250 based systems. -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH V2 11/15] regulator: ti-abb: Convert to use devm_ioremap_resource

2013-06-17 Thread Tushar Behera
Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()") introduced devm_ioremap_resource() and deprecated the use of devm_request_and_ioremap(). While at it, remove the error message as devm_ioremap_resource prints a similar error message. Signed-off-by: Tushar Behera

Re: [PATCH -next] Staging: netlogic: fix missing free_netdev() on error in xlr_net_probe()

2013-06-18 Thread Tushar Behera
t, it was pointed that this error message is redundant. There is already a similar error message within devm_ioremap_resource call. > + err = ndev->base_addr; > + goto err_gmac; > } > > res = platform_get_resource(pdev, IORESOURC

Re: [PATCH 2/2] clk: exynos4: Add alias for cpufreq related clocks

2013-06-18 Thread Tushar Behera
On 06/17/2013 10:20 AM, Tushar Behera wrote: > On 06/11/2013 12:23 AM, Tomasz Figa wrote: >> On Monday 10 of June 2013 09:13:11 Tushar Behera wrote: >>> On 06/08/2013 05:20 PM, Tomasz Figa wrote: >>>> On Thursday 06 of June 2013 16:52:28 Tushar Behera wrote: > >

[PATCH] ARM: dts: Update range for vdd_arm on EXYNOS4412-origen board

2013-06-19 Thread Tushar Behera
EXYNOS4412 cpufreq driver requires the range of vdd_arm regulator to be from .9v to 1.35v. Since vdd_arm regulator (BUCK2 on S5M8767) has a supported range of .6v to 1.6v, the constraints are updated to match the requirement from cpufreq driver. Signed-off-by: Tushar Behera --- arch/arm/boot

[PATCH v2 0/2] Clock update for EXYNOS4210-CPUFREQ driver

2013-06-20 Thread Tushar Behera
to include EXYNOS4X12 releated clocks. Tushar Behera (2): clk: samsung: Add MUX_FA macro to pass flag and alias clk: exynos4: Fix clock aliases for cpufreq related clocks drivers/clk/samsung/clk-exynos4.c | 21 +++-- drivers/clk/samsung/clk.h |3 +++ 2 files

[PATCH RESEND 1/2] clk: samsung: Add MUX_FA macro to pass flag and alias

2013-06-20 Thread Tushar Behera
. Signed-off-by: Tushar Behera --- drivers/clk/samsung/clk.h |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/samsung/clk.h b/drivers/clk/samsung/clk.h index e4ad6ea..2f7dba2 100644 --- a/drivers/clk/samsung/clk.h +++ b/drivers/clk/samsung/clk.h @@ -144,6 +144,9 @@ struct

[PATCH v2 2/2] clk: exynos4: Fix clock aliases for cpufreq related clocks

2013-06-20 Thread Tushar Behera
c' is 'mout_mpll'. Some of the clock aliases are newly defined and some are fixed up. While at it, also modify the debug messages to print the clock values appropriately. Signed-off-by: Tushar Behera --- Changes for v2: * Clocks for EXYNOS4X12 has also been modified. * Debug messag

Re: [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board

2013-05-29 Thread Tushar Behera
ig update >> b. ARM: EXYNOS: Update defconfig for Arndale and Origen board >> c. [TEMP] ARM: EXYNOS: Set low-level UART port to 2 >> d. ARM: dts: Enabling samsung-usb2phy driver for exynos5250 >> e. usb: ehci-s5p: add the HSIC port initialization >> f. ARM: dts: Add USB gp

  1   2   3   4   >