Re: [PATCH v1] farsync: use generic power management

2020-07-29 Thread Vaibhav Gupta
On Wed, Jul 29, 2020 at 07:29:54AM -0500, Bjorn Helgaas wrote: > On Wed, Jul 29, 2020 at 03:47:30PM +0530, Vaibhav Gupta wrote: > > > > Agreed. Actually, as their presence only causes PCI core to call > > pci_legacy_suspend/resume() for them, I thought that after removing

[PATCH v1] scsi: stex: use generic power management

2020-07-29 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/scsi/stex.c | 35 +-- 1 file changed, 29 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index d4f10c0d813c..9500666b521a 100644 --- a/drivers/scsi/stex.c +++ b/driv

[PATCH v1 0/3] net: ethernet: use generic power management

2020-07-29 Thread Vaibhav Gupta
their job. The conversion requires the removal of those function calls, change the callbacks' definition accordingly and make use of dev_pm_ops structure. All patches are compile-tested only. Test tools: - Compiler: gcc (GCC) 10.1.0 - allmodconfig build: make -j$(nproc) W=1 all Vaibhav

[PATCH v1 1/3] sc92031: use generic power management

2020-07-29 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/net/ethernet/silan/sc92031.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/silan/sc92031.c b/drivers/net/ethernet/silan/sc92031.c index cb043eb1bdc1..f94078f8eb

[PATCH v1 3/3] tlan: use generic power management

2020-07-29 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/net/ethernet/ti/tlan.c | 31 ++- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c index 857709828058..c799945a39ef 100644 --

[PATCH v1 2/3] sis900: use generic power management

2020-07-29 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/net/ethernet/sis/sis900.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c index 81ed7589e33c..2af2c9816dfc 100644 --

[PATCH v1 3/3] tlan: use generic power management

2020-07-29 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/net/ethernet/ti/tlan.c | 31 ++- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c index 857709828058..c799945a39ef 100644 --

[PATCH v1 2/3] sis900: use generic power management

2020-07-29 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/net/ethernet/sis/sis900.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c index 81ed7589e33c..2af2c9816dfc 100644 --

[PATCH v1 0/3] net: ethernet: use generic power management

2020-07-29 Thread Vaibhav Gupta
their job. The conversion requires the removal of those function calls, change the callbacks' definition accordingly and make use of dev_pm_ops structure. All patches are compile-tested only. Test tools: - Compiler: gcc (GCC) 10.1.0 - allmodconfig build: make -j$(nproc) W=1 all Vaibhav

[PATCH v1 1/3] sc92031: use generic power management

2020-07-29 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/net/ethernet/silan/sc92031.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/silan/sc92031.c b/drivers/net/ethernet/silan/sc92031.c index cb043eb1bdc1..f94078f8eb

[PATCH v1] scsi: smartpqi: use generic power management

2020-07-30 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/scsi/smartpqi/smartpqi_init.c | 42 ++- 1 file changed, 29 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c index cd157f11eb22..dc85

[PATCH v2] scsi: stex: use generic power management

2020-07-30 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/scsi/stex.c | 37 +++-- 1 file changed, 31 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index d4f10c0d813c..5ef6f3cbac11 100644 --- a/drivers/scsi/stex.c +++

Re: [PATCH v2] scsi: stex: use generic power management

2020-07-30 Thread Vaibhav Gupta
The patch is compile-tested only. Thanks Vaibhav Gupta

[PATCH v2] scsi: smartpqi: use generic power management

2020-07-30 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/scsi/smartpqi/smartpqi_init.c | 44 +++ 1 file changed, 31 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c index cd157f11eb22..7061

Re: [PATCH v2] scsi: smartpqi: use generic power management

2020-07-30 Thread Vaibhav Gupta
This patch is compile tested only. Thanks Vaibhav Gupta

[PATCH v1] PCI: Drop pcibios_pm_ops from the PCI subsystem

2020-07-30 Thread Vaibhav Gupta
ower management support") patch. After that, instances of it are found only in drivers/pci/pci-driver.c and include/linux/pci.h, which are now unnecessary. Thus it is safe and reasonable to remove even that. Reported-by: Bjorn Helgaas Signed-off-by: Vaibhav Gupta --- drivers/p

Re: [PATCH v3] ata: use generic power management

2020-08-19 Thread Vaibhav Gupta
On Wed, Aug 19, 2020 at 12:40:20PM -0600, Jens Axboe wrote: > On 8/18/20 6:03 AM, Vaibhav Gupta wrote: > > On Mon, Aug 17, 2020 at 07:06:03AM -0700, Jens Axboe wrote: > >> On 8/17/20 2:25 AM, Vaibhav Gupta wrote: > >>> Hello, > >>> > >>> I am

[PATCH v3 00/12] video: fbdev: use generic power management

2020-08-19 Thread Vaibhav Gupta
job. The conversion requires the removal of those function calls, change the callbacks' definition accordingly and make use of dev_pm_ops structure. All patches are compile-tested only. Test tools: - Compiler: gcc (GCC) 10.1.0 - allmodconfig build: make -j$(nproc) W=1 all Vaibhav

[PATCH v3 01/12] fbdev: gxfb: use generic power management

2020-08-19 Thread Vaibhav Gupta
by binding the callback with only "gxfb_pm_ops.suspend" in the new framework. This also avoids the step of checking "if (state.event == PM_EVENT_SUSPEND)" every time the callback is invoked. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/geode/gxfb.h

[PATCH v3 02/12] fbdev: lxfb: use generic power management

2020-08-19 Thread Vaibhav Gupta
by binding the callback with only "lxfb_pm_ops.suspend" in the new framework. This also avoids the step of checking "if (state.event == PM_EVENT_SUSPEND)" every time the callback is invoked. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/geode/lxfb.h

[PATCH v3 04/12] fbdev: aty: use generic power management

2020-08-19 Thread Vaibhav Gupta
ernate() which in turn call atyfb_pci_suspend_late() by passing appropriate value for "pm_message_t" type parameter. - Bind the callbacks in "struct dev_pm_ops" type variable "atyfb_pci_pm_ops". Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/aty/atyfb_ba

[PATCH v3 03/12] fbdev: via-core: use generic power management

2020-08-19 Thread Vaibhav Gupta
voids the step of checking "if (state.event != PM_EVENT_SUSPEND)" every time the callback is invoked. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/via/via-core.c | 39 -- include/linux/via-core.h | 2 -- 2 files changed, 16 insertions(+), 25 deleti

[PATCH v3 08/12] fbdev: cyber2000fb: use generic power management

2020-08-19 Thread Vaibhav Gupta
Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. This way we can remove the legacy .suspend & .resume bindings from "lxfb_driver". Signed-off-by: Vaibhav Gupta --- drivers/video/

[PATCH v3 05/12] fbdev: aty128fb: use generic power management

2020-08-19 Thread Vaibhav Gupta
i_hibernate() which in turn call aty128_pci_suspend_late() by passing appropriate value for "pm_message_t" type parameter. - Bind the callbacks in "struct dev_pm_ops" type variable "aty128_pci_pm_ops". Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/aty/

[PATCH v3 06/12] fbdev: nvidia: use generic power management

2020-08-19 Thread Vaibhav Gupta
e() which in turn call nvidiafb_suspend_late() by passing appropriate value for "pm_message_t" type parameter. - Bind the callbacks in "struct dev_pm_ops" type variable "nvidiafb_pm_ops". Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/nvidia/nvidia.c

[PATCH v3 07/12] fbdev: savagefb: use generic power management

2020-08-19 Thread Vaibhav Gupta
e() which in turn call savagefb_suspend_late() by passing appropriate value for "pm_message_t" type parameter. - Bind the callbacks in "struct dev_pm_ops" type variable "savagefb_pm_ops". Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/savage/savagefb_

[PATCH v3 09/12] fbdev: i740fb: use generic power management

2020-08-19 Thread Vaibhav Gupta
by binding the callback with only ".suspend" and ".poweroff" in the "i740fb_pm_ops" const variable. This also avoids the step of checking "if (state.event == PM_EVENT_FREEZE)" every time the callback is invoked. Signed-off-by: Vaibhav Gupta --- drivers/v

[PATCH v3 11/12] fbdev: s3fb: use generic power management

2020-08-19 Thread Vaibhav Gupta
by binding the callback with only ".suspend" and ".poweroff" in the "s3_pci_pm_ops" const variable. This also avoids the step of checking "state.event == PM_EVENT_FREEZE" every time the callback is invoked. Signed-off-by: Vaibhav Gupta --- drivers/video/

[PATCH v3 12/12] fbdev: arkfb: use generic power management

2020-08-19 Thread Vaibhav Gupta
by binding the callback with only ".suspend" and ".poweroff" in the "ark_pci_pm_ops" const variable. This also avoids the step of checking "state.event == PM_EVENT_FREEZE" every time the callback is invoked. Signed-off-by: Vaibhav Gupta --- drivers/video/

[PATCH v3 10/12] fbdev: vt8623fb: use generic power management

2020-08-19 Thread Vaibhav Gupta
by binding the callback with only ".suspend" and ".poweroff" in the "vt8623_pci_pm_ops" const variable. This also avoids the step of checking "state.event == PM_EVENT_FREEZE" every time the callback is invoked. Signed-off-by: Vaibhav Gupta --- drivers/v

Re: [PATCH v1] i2c: eg20t: use generic power management

2020-08-05 Thread Vaibhav Gupta
On Wed, Aug 05, 2020 at 11:56:11AM -0500, Bjorn Helgaas wrote: > On Wed, Aug 05, 2020 at 09:51:54PM +0530, Vaibhav Gupta wrote: > > On Wed, Aug 05, 2020 at 10:28:32AM -0500, Bjorn Helgaas wrote: > > > On Wed, Aug 05, 2020 at 10:23:31AM -0500, Bjorn Helgaas wrote: > > > &

[PATCH v1 00/12] video: fbdev: use generic power management

2020-08-05 Thread Vaibhav Gupta
job. The conversion requires the removal of those function calls, change the callbacks' definition accordingly and make use of dev_pm_ops structure. All patches are compile-tested only. Test tools: - Compiler: gcc (GCC) 10.1.0 - allmodconfig build: make -j$(nproc) W=1 all Vaibhav

[PATCH v1 01/12] fbdev: gxfb: use generic power management

2020-08-05 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/geode/gxfb.h | 5 drivers/video/fbdev/geode/gxfb_core.c | 36 ++ drivers/video/fbdev/geode/suspend_gx.c | 4 --- 3 files changed, 20 insertions(+), 25 deletions(-) diff --git a/driv

[PATCH v1 05/12] fbdev: aty128fb: use generic power management

2020-08-05 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/aty/aty128fb.c | 51 -- 1 file changed, 34 insertions(+), 17 deletions(-) diff --git a/drivers/video/fbdev/aty/aty128fb.c b/drivers/video/fbdev/aty/aty128fb.c index d05d4195acad..dd7762fea0

[PATCH v1 12/12] fbdev: arkfb: use generic power management

2020-08-05 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/arkfb.c | 41 +++-- 1 file changed, 17 insertions(+), 24 deletions(-) diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c index 11ab9a153860..6a4114db0dfd 100644 --- a/driv

[PATCH v1 11/12] fbdev: s3fb: use generic power management

2020-08-05 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/s3fb.c | 39 -- 1 file changed, 16 insertions(+), 23 deletions(-) diff --git a/drivers/video/fbdev/s3fb.c b/drivers/video/fbdev/s3fb.c index 60c424fae988..5c74253e7b2c 100644 --- a/driv

[PATCH v1 10/12] fbdev: vt8623fb: use generic power management

2020-08-05 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/vt8623fb.c | 41 ++ 1 file changed, 17 insertions(+), 24 deletions(-) diff --git a/drivers/video/fbdev/vt8623fb.c b/drivers/video/fbdev/vt8623fb.c index 7b3eef1b893f..c488e0117758 100644 ---

[PATCH v1 07/12] fbdev: savagefb: use generic power management

2020-08-05 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/savage/savagefb_driver.c | 52 1 file changed, 32 insertions(+), 20 deletions(-) diff --git a/drivers/video/fbdev/savage/savagefb_driver.c b/drivers/video/fbdev/savage/savagefb_driver.c ind

[PATCH v1 04/12] fbdev: aty: use generic power management

2020-08-05 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/aty/atyfb_base.c | 50 1 file changed, 36 insertions(+), 14 deletions(-) diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c index b0ac895e5ac9..a24d5bf6ad

[PATCH v1 06/12] fbdev: nvidia: use generic power management

2020-08-05 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/nvidia/nvidia.c | 64 - 1 file changed, 35 insertions(+), 29 deletions(-) diff --git a/drivers/video/fbdev/nvidia/nvidia.c b/drivers/video/fbdev/nvidia/nvidia.c index c24de9107958..3a1a4330e0

[PATCH v1 09/12] fbdev: i740fb: use generic power management

2020-08-05 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/i740fb.c | 40 +++- 1 file changed, 16 insertions(+), 24 deletions(-) diff --git a/drivers/video/fbdev/i740fb.c b/drivers/video/fbdev/i740fb.c index c65ec7386e87..8d7f06fc8a5a 100644 ---

[PATCH v1 03/12] fbdev: via-core: use generic power management

2020-08-05 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/via/via-core.c | 39 -- include/linux/via-core.h | 2 -- 2 files changed, 16 insertions(+), 25 deletions(-) diff --git a/drivers/video/fbdev/via/via-core.c b/drivers/video/fbdev/via/v

[PATCH v1 08/12] fbdev: cyber2000fb: use generic power management

2020-08-05 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/cyber2000fb.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c index 42d37bed518a..d45355b9a58c 100644 --- a/driv

[PATCH v1 02/12] fbdev: lxfb: use generic power management

2020-08-05 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/geode/lxfb.h | 5 drivers/video/fbdev/geode/lxfb_core.c | 37 +++ drivers/video/fbdev/geode/lxfb_ops.c | 4 --- 3 files changed, 20 insertions(+), 26 deletions(-) diff --git a/drivers/vi

[PATCH v2 2/2] i2c: eg20t: use generic power management

2020-08-05 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/i2c/busses/i2c-eg20t.c | 36 +++--- 1 file changed, 7 insertions(+), 29 deletions(-) diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c index eb41de22d461..843b31a0f752 100644 --

[PATCH v2 1/2] i2c: eg20t: Drop PCI wakeup calls from .suspend/.resume

2020-08-05 Thread Vaibhav Gupta
i_dev, PCI_D0, false) during resume, drop it from .suspend() and .resume(). Reported-by: Bjorn Helgaas Signed-off-by: Vaibhav Gupta --- drivers/i2c/busses/i2c-eg20t.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c index 73f1396

[PATCH v2 0/2] i2c: eg20t: Power management upgrade and clean-ups

2020-08-05 Thread Vaibhav Gupta
the required operations. v2 : An additional patch had to be added in v1 to drop PCI wakeup calls. All patches are compile-tested only. Test tools: - Compiler: gcc (GCC) 10.1.0 - allmodconfig build: make -j$(nproc) W=1 all Vaibhav Gupta (2): i2c: eg20t: Drop PCI wakeup calls from

Re: [PATCH v1] i2c: eg20t: use generic power management

2020-08-05 Thread Vaibhav Gupta
On Wed, Aug 05, 2020 at 10:28:32AM -0500, Bjorn Helgaas wrote: > [update Linus's address, drop Qi's (bounced)] > > On Wed, Aug 05, 2020 at 10:23:31AM -0500, Bjorn Helgaas wrote: > > [+cc Tomoya, Linus, Qi, Ben from e9bc8fa5df1c] > > > > On Mon, Jul 20, 20

Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management

2020-08-05 Thread Vaibhav Gupta
On Wed, Aug 05, 2020 at 03:19:01PM -0500, Bjorn Helgaas wrote: > On Wed, Aug 05, 2020 at 11:37:11PM +0530, Vaibhav Gupta wrote: > > Drivers using legacy power management .suspen()/.resume() callbacks > > have to manage PCI states and device's PM states themselves. They also &

[PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups.

2020-08-06 Thread Vaibhav Gupta
tested only. Test tools: - Compiler: gcc (GCC) 10.1.0 - allmodconfig build: make -j$(nproc) W=1 all Vaibhav Gupta (2): video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container fbdev: radeonfb:use generic power management drivers/video/fbdev/aty/radeon_base.c | 10 --- dr

[PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups.

2020-08-06 Thread Vaibhav Gupta
tested only. Test tools: - Compiler: gcc (GCC) 10.1.0 - allmodconfig build: make -j$(nproc) W=1 all Vaibhav Gupta (2): video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container fbdev: radeonfb:use generic power management drivers/video/fbdev/aty/radeon_base.c | 10 --- dr

[PATCH v1 1/2] video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container

2020-08-06 Thread Vaibhav Gupta
. It also affected the "#ifdef CONFIG_PPC_OF" container (line 1943-2510). >From the current snapshot of radeon_pm.c, remove: 1434 | #if defined(CONFIG_PM) and, 2213 | #endif This removes the redundant CONFIG_PM directive as well as fixes the CONFIG_PPC (earlier CONFIG_PPC_O

[PATCH v1 2/2] fbdev: radeonfb:use generic power management

2020-08-06 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/aty/radeon_base.c | 10 +--- drivers/video/fbdev/aty/radeon_pm.c | 36 +-- drivers/video/fbdev/aty/radeonfb.h| 3 +-- 3 files changed, 35 insertions(+), 14 deletions(-) diff --git a/drivers/

Re: [PATCH v2 2/2] i2c: eg20t: use generic power management

2020-08-10 Thread Vaibhav Gupta
On Fri, Aug 07, 2020 at 03:23:21PM -0500, Bjorn Helgaas wrote: > [+cc Jean for i801 question below] > > On Thu, Aug 06, 2020 at 01:06:16AM +0530, Vaibhav Gupta wrote: > > Drivers using legacy power management .suspen()/.resume() callbacks > > have to manage PCI states a

Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management

2020-08-10 Thread Vaibhav Gupta
On Sat, Aug 08, 2020 at 01:17:46PM +0200, Sam Ravnborg wrote: > Hi Vaibhav > > On Wed, Aug 05, 2020 at 11:37:11PM +0530, Vaibhav Gupta wrote: > > Drivers using legacy power management .suspen()/.resume() callbacks > > have to manage PCI states and device's PM states them

Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management

2020-08-10 Thread Vaibhav Gupta
drvdata(&pdev->dev, data). Adding dev_get_drvdata() will be redundant. > s/dev_get_drvdata/dev_set_drvdata Thanks Vaibhav Gupta

Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management

2020-08-10 Thread Vaibhav Gupta
On Mon, Aug 10, 2020 at 06:54:58PM +0200, Sam Ravnborg wrote: > Hi Vaibhav > On Mon, Aug 10, 2020 at 03:09:48PM +0530, Vaibhav Gupta wrote: > > On Sat, Aug 08, 2020 at 01:17:46PM +0200, Sam Ravnborg wrote: > > > Hi Vaibhav > > > > > > On Wed, Aug 05, 2020 a

[PATCH v2 00/12] video: fbdev: use generic power management

2020-08-10 Thread Vaibhav Gupta
job. The conversion requires the removal of those function calls, change the callbacks' definition accordingly and make use of dev_pm_ops structure. All patches are compile-tested only. Test tools: - Compiler: gcc (GCC) 10.1.0 - allmodconfig build: make -j$(nproc) W=1 all Vaibhav

[PATCH v2 02/12] fbdev: lxfb: use generic power management

2020-08-10 Thread Vaibhav Gupta
this helps us to remove the unnecessary call to lxfb_suspend() in the event of Freeze and Hibernate, as the function does nothing in their case. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/geode/lxfb.h | 5 drivers/video/fbdev/geode/lxfb_core.c | 37 +++---

[PATCH v2 01/12] fbdev: gxfb: use generic power management

2020-08-10 Thread Vaibhav Gupta
this helps us to remove the unnecessary call to gxfb_suspend() in the event of Freeze and Hibernate, as the function does nothing in their case. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/geode/gxfb.h | 5 drivers/video/fbdev/geode/gxfb_core.c | 36 ++---

[PATCH v2 03/12] fbdev: via-core: use generic power management

2020-08-10 Thread Vaibhav Gupta
to remove the unnecessary call to via_suspend() in the event of Freeze and Hibernate, as the function does nothing in their case. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/via/via-core.c | 39 -- include/linux/via-core.h | 2 -- 2 files changed,

[PATCH v2 04/12] fbdev: aty: use generic power management

2020-08-10 Thread Vaibhav Gupta
handle them. Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove unnecessary calls to the PCI Helper functions along with the legacy .suspend & .resume bindings. Signed-off-by: Vaibhav Gupta

[PATCH v2 07/12] fbdev: savagefb: use generic power management

2020-08-10 Thread Vaibhav Gupta
handle them. Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove unnecessary calls to the PCI Helper functions along with the legacy .suspend & .resume bindings. Signed-off-by: Vaibhav Gupta

[PATCH v2 05/12] fbdev: aty128fb: use generic power management

2020-08-10 Thread Vaibhav Gupta
handle them. Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove unnecessary calls to the PCI Helper functions along with the legacy .suspend & .resume bindings. Signed-off-by: Vaibhav Gupta

[PATCH v2 06/12] fbdev: nvidia: use generic power management

2020-08-10 Thread Vaibhav Gupta
handle them. Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove unnecessary calls to the PCI Helper functions along with the legacy .suspend & .resume bindings. Signed-off-by: Vaibhav Gupta

[PATCH v2 12/12] fbdev: arkfb: use generic power management

2020-08-10 Thread Vaibhav Gupta
handle them. Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove unnecessary calls to the PCI Helper functions along with the legacy .suspend & .resume bindings. Signed-off-by: Vaibhav Gupta

[PATCH v2 08/12] fbdev: cyber2000fb: use generic power management

2020-08-10 Thread Vaibhav Gupta
Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/cyber2000fb.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c index 42d37bed518a..d45355b9a58c 100644 --- a/drivers/video/fbdev/cyber2000fb.c

[PATCH v2 10/12] fbdev: vt8623fb: use generic power management

2020-08-10 Thread Vaibhav Gupta
handle them. Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove unnecessary calls to the PCI Helper functions along with the legacy .suspend & .resume bindings. Signed-off-by: Vaibhav Gupta

[PATCH v2 11/12] fbdev: s3fb: use generic power management

2020-08-10 Thread Vaibhav Gupta
handle them. Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove unnecessary calls to the PCI Helper functions along with the legacy .suspend & .resume bindings. Signed-off-by: Vaibhav Gupta

[PATCH v2 09/12] fbdev: i740fb: use generic power management

2020-08-10 Thread Vaibhav Gupta
handle them. Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove unnecessary calls to the PCI Helper functions along with the legacy .suspend & .resume bindings. Signed-off-by: Vaibhav Gupta

Re: [PATCH v3] ata: use generic power management

2020-08-18 Thread Vaibhav Gupta
On Mon, Aug 17, 2020 at 07:06:03AM -0700, Jens Axboe wrote: > On 8/17/20 2:25 AM, Vaibhav Gupta wrote: > > Hello, > > > > I am working to upgrade power management framework support for PCI drivers, > > as > > my project under the Linux Kernel Mentorship Program.

[PATCH v2 1/3] amd64-agp: use generic power management

2021-01-12 Thread Vaibhav Gupta
ecame an empty-body function, hence defined as NULL. Signed-off-by: Vaibhav Gupta --- drivers/char/agp/amd64-agp.c | 24 ++-- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c index b40edae32817..dc78a

[PATCH v2 2/3] sis-agp: use generic power management

2021-01-12 Thread Vaibhav Gupta
ecame an empty-body function, hence defined as NULL. Signed-off-by: Vaibhav Gupta --- drivers/char/agp/sis-agp.c | 25 ++--- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/drivers/char/agp/sis-agp.c b/drivers/char/agp/sis-agp.c index 14909fc5d767..f8a02f4bef1

[PATCH v2 0/3] char: use generic power management

2021-01-12 Thread Vaibhav Gupta
based. Vaibhav Gupta (3): amd64-agp: use generic power management sis-agp: use generic power management via-agp: use generic power management drivers/char/agp/amd64-agp.c | 24 ++-- drivers/char/agp/sis-agp.c | 25 ++--- drivers/char/agp/via-agp.c

[PATCH v2 3/3] via-agp: use generic power management

2021-01-12 Thread Vaibhav Gupta
ecame an empty-body function, hence defined as NULL. Signed-off-by: Vaibhav Gupta --- drivers/char/agp/via-agp.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/drivers/char/agp/via-agp.c b/drivers/char/agp/via-agp.c index 87a92a044570..a460ae35277

[PATCH v4 1/3] mtip32xx: use generic power management

2021-01-14 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/block/mtip32xx/mtip32xx.c | 54 +++ 1 file changed, 12 insertions(+), 42 deletions(-) diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c index 53ac59d19ae5..de1ac3366b

[PATCH v4 2/3] rsxx: use generic power management

2021-01-14 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/block/rsxx/core.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c index 63f549889f87..937ad8a28e85 100644 --- a/drivers/block/rsxx/core.c +++ b/dri

[PATCH v4 3/3] skd: use generic power management

2021-01-14 Thread Vaibhav Gupta
device-specific jobs. Signed-off-by: Vaibhav Gupta Tested-by: Damien Le Moal --- drivers/block/skd_main.c | 30 -- 1 file changed, 8 insertions(+), 22 deletions(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index a962b4551bed..8194b58525e2 10064

[PATCH v4 0/3] block: use generic power management

2021-01-14 Thread Vaibhav Gupta
h-set rebased. Vaibhav Gupta (3): mtip32xx: use generic power management rsxx: use generic power management skd: use generic power management drivers/block/mtip32xx/mtip32xx.c | 54 +++ drivers/block/rsxx/core.c | 9 -- drivers/block/skd_main.c

[PATCH v2 0/3] Update dt-bindings and sa2ul driver for AM64x SoCs

2021-04-13 Thread Vaibhav Gupta
From: Vaibhav Gupta This patch series aims to modify necessary files before an entry for sa2ul can be made in the respective am64 device tree. v2? - Simplify the dt-binding changes. Peter Ujfalusi (3): dt-bindings: crypto: ti,sa2ul: Add new compatible for AM64 crypto: sa2ul: Support for

[PATCH v2 1/3] dt-bindings: crypto: ti,sa2ul: Add new compatible for AM64

2021-04-13 Thread Vaibhav Gupta
From: Peter Ujfalusi Add the AM64 version of sa2ul to the compatible list. [v_gu...@ti.com: Conditional dma-coherent requirement, clocks] Signed-off-by: Peter Ujfalusi Signed-off-by: Vaibhav Gupta --- .../devicetree/bindings/crypto/ti,sa2ul.yaml | 24 ++- 1 file changed, 23

[PATCH v2 3/3] crypto: sa2ul: Add support for AM64

2021-04-13 Thread Vaibhav Gupta
-off-by: Vaibhav Gupta --- drivers/crypto/sa2ul.c | 131 + drivers/crypto/sa2ul.h | 4 ++ 2 files changed, 96 insertions(+), 39 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index 6107bfea862d..8a17ab8af444 100644 --- a/drivers

[PATCH v2 2/3] crypto: sa2ul: Support for per channel coherency

2021-04-13 Thread Vaibhav Gupta
. Signed-off-by: Peter Ujfalusi Signed-off-by: Vaibhav Gupta --- drivers/crypto/sa2ul.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index f300b0a5958a..6107bfea862d 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto

Re: [PATCH v1 1/3] dt-bindings: crypto: ti,sa2ul: Add new compatible for AM64

2021-03-16 Thread Vaibhav Gupta
On Tue, Mar 16, 2021 at 04:05:58PM -0600, Rob Herring wrote: > On Tue, Mar 09, 2021 at 01:50:03AM +0530, Vaibhav Gupta wrote: > > From: Peter Ujfalusi > > > > Add the AM64 version of sa2ul to the compatible list. > > > > [v_gu...@ti.com: Conditional dma-coheren

[PATCH v1 0/3] Update dt-bindings and sa2ul driver for AM64x SoCs

2021-03-08 Thread Vaibhav Gupta
From: Vaibhav Gupta This patch series aims to modify necessary files before an entry for sa2ul can be made in the respective am64 device tree. Peter Ujfalusi (3): dt-bindings: crypto: ti,sa2ul: Add new compatible for AM64 crypto: sa2ul: Support for per channel coherency crypto: sa2ul: Add

[PATCH v1 2/3] crypto: sa2ul: Support for per channel coherency

2021-03-08 Thread Vaibhav Gupta
. Signed-off-by: Peter Ujfalusi Signed-off-by: Vaibhav Gupta --- drivers/crypto/sa2ul.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index f300b0a5958a..6107bfea862d 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto

[PATCH v1 3/3] crypto: sa2ul: Add support for AM64

2021-03-08 Thread Vaibhav Gupta
-off-by: Vaibhav Gupta --- drivers/crypto/sa2ul.c | 131 + drivers/crypto/sa2ul.h | 4 ++ 2 files changed, 96 insertions(+), 39 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index 6107bfea862d..8a17ab8af444 100644 --- a/drivers

[PATCH v1 1/3] dt-bindings: crypto: ti,sa2ul: Add new compatible for AM64

2021-03-08 Thread Vaibhav Gupta
From: Peter Ujfalusi Add the AM64 version of sa2ul to the compatible list. [v_gu...@ti.com: Conditional dma-coherent requirement, clocks] Signed-off-by: Peter Ujfalusi Signed-off-by: Vaibhav Gupta --- .../devicetree/bindings/crypto/ti,sa2ul.yaml | 40 +++ 1 file changed, 33

[Linux-kernel-mentees] [PATCH v2 0/2] realtek ethernet : remove legacy power management callbacks.

2020-04-28 Thread Vaibhav Gupta
recommended. The conversion requires the removal of the those function calls and change the callback definition accordingly. Vaibhav Gupta (2): realtek/8139too: Remove Legacy Power Management realtek/8139cp: Remove Legacy Power Management drivers/net/ethernet/realtek/8139cp.c | 25

[Linux-kernel-mentees] [PATCH v2 1/2] realtek/8139too: Remove Legacy Power Management

2020-04-28 Thread Vaibhav Gupta
definition to suppress compiler warnings. Generic callback requires an argument of type "struct device*". Hence, convert it to "struct net_device*" using "dev_get_drvdata()" to use it in the callback. Signed-off-by: Vaibhav Gupta --- drivers/net/ethernet/realtek/8139too.

[Linux-kernel-mentees] [PATCH v2 2/2] realtek/8139cp: Remove Legacy Power Management

2020-04-28 Thread Vaibhav Gupta
struct net_device*" using "dev_get_drv_data()" to use it in the callback. Most of the cleaning part is to remove pci_save_state(), pci_set_power_state(), etc power management function calls. Signed-off-by: Vaibhav Gupta --- drivers/net/ethernet/realtek/8139cp.c | 25 +++---

Re: [Linux-kernel-mentees] [PATCH v2 0/2] realtek ethernet : remove legacy power management callbacks.

2020-04-29 Thread Vaibhav Gupta
On Tue, 28 Apr 2020 at 23:24, Heiner Kallweit wrote: > > On 28.04.2020 16:43, Vaibhav Gupta wrote: > > The purpose of this patch series is to remove legacy power management > > callbacks > > from realtek ethernet drivers. > > > > The callbacks performing s

Re: [Linux-kernel-mentees] [PATCH v2 2/2] realtek/8139cp: Remove Legacy Power Management

2020-04-29 Thread Vaibhav Gupta
On Tue, 28 Apr 2020 at 22:59, Bjorn Helgaas wrote: > > On Tue, Apr 28, 2020 at 08:13:14PM +0530, Vaibhav Gupta wrote: > > Upgrade power management from legacy to generic using dev_pm_ops. > > > > Add "__maybe_unused" attribute to resume() and susend() callbacks &

Re: [Linux-kernel-mentees] [PATCH v2 1/2] realtek/8139too: Remove Legacy Power Management

2020-04-29 Thread Vaibhav Gupta
from the get_maintainer.pl script, yeah. > > but you can trim it a bit by omitting people who have just made > > occasional random fixups. These drivers are really unmaintained, so > > Dave M, netdev, Rafael, linux-pm, linux-pci, and maybe LKML are > > probably enough. I wi

[PATCH v1 2/2] atl2: use generic power management

2020-07-01 Thread Vaibhav Gupta
. Thus, it does not affect the normal functioning of the driver. __maybe_unused attribute is used with .resume() but not with .suspend(), as .suspend() is calleb by .shutdown(). Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/net/ethernet/atheros/atlx/atl2.c | 64

[PATCH v1 0/2] atheros: use generic power management

2020-07-01 Thread Vaibhav Gupta
handling the power management themselves, which is not recommended. The conversion requires the removal of the those function calls and change the callback definition accordingly and make use of dev_pm_ops structure. All patches are compile-tested only. Vaibhav Gupta (2): atl1e: use generic power

[PATCH v1 0/2] qlogic: use generic power management

2020-07-01 Thread Vaibhav Gupta
handling the power management themselves, which is not recommended. The conversion requires the removal of the those function calls and change the callback definition accordingly and make use of dev_pm_ops structure. All patches are compile-tested only. Vaibhav Gupta (2): netxen_nic: use generic

[PATCH v1 1/2] netxen_nic: use generic power management

2020-07-01 Thread Vaibhav Gupta
have done their job. Now, netxen_nic_attach_func() invokes netxen_nic_attach_late_func(), thus netxen_io_slot_reset() behaves normally. And, netxen_nic_resume() calls netxen_nic_attach_late_func() to avoid PCI helper functions calls. Compile-tested only. Signed-off-by: Vaibhav Gupta --- .../eth

[PATCH v1 2/2] qlcninc: use generic power management

2020-07-01 Thread Vaibhav Gupta
lcnic/qlcnic_main.c. Hence upgrade them and remove PCI function calls, like pci_save_state() and pci_enable_wake(), inside them Compile-tested only. Signed-off-by: Vaibhav Gupta --- .../net/ethernet/qlogic/qlcnic/qlcnic_hw.c| 10 ++ .../net/ethernet/qlogic/qlcnic/qlcnic_main.c

[PATCH v1 0/2] smsc: use generic power management

2020-07-02 Thread Vaibhav Gupta
the power management themselves, which is not recommended. The conversion requires the removal of the those function calls and change the callback definition accordingly and make use of dev_pm_ops structure. All patches are compile-tested only. Vaibhav Gupta (2): epic100: use generic power

  1   2   3   4   5   >