Hi Greg,
checkkconfigsymbols.py found some undefined Kconfig symbols (see
below) in the Makefile and Kconfig file. I could not find any patch
adding those symbols. Are there patches queued somewhere else?
Best regards,
Valentin
GREYBUS_AUDIO_MSM8994
Referencing files: drivers/staging/greybus/
On Wed, Sep 21, 2016 at 9:39 AM, Greg KH wrote:
> On Wed, Sep 21, 2016 at 08:30:01AM +0200, Valentin Rothberg wrote:
>> Hi Greg,
>
>
I was a little surprised, too, but that's the one in the signed-off
field in the greybus commits, so I used it.
>> checkkconfigsymbo
The Kconfig symbol for 32bit ARM is 'ARM', not 'ARM32'.
Signed-off-by: Valentin Rothberg
---
drivers/soc/fsl/qbman/dpaa_sys.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/fsl/qbman/dpaa_sys.h b/drivers/soc/fsl/qbman/dpaa_sys.h
index b63fd7
On Oct 06 '15 01:03, Luis R. Rodriguez wrote:
> On Sun, Oct 04, 2015 at 03:42:47PM +0200, Valentin Rothberg wrote:
> > Hi Luis,
> >
> > I finally found some time to read your patch. Thanks for doing this
> > work in such great detail.
> >
> > What I
Hi Paul,
On Oct 06 '15 10:32, Paul Bolle wrote:
> Hi Valentin,
>
> On di, 2015-10-06 at 10:19 +0200, Valentin Rothberg wrote:
> > I think that a general remark that using selects should be discouraged
> > as, besides causing the recursive issue, selects can also break
s/CONFIG_RT_MUTEX/CONFIG_RT_MUTEXES/
Signed-off-by: Valentin Rothberg
---
I detected the typo with scripts/checkkconfigsymbols.py
Documentation/locking/locktorture.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/locking/locktorture.txt
b/Documentation
Fix typo in conntrack.c
s/CONFIG_NF_CONNTRACK_LABEL/CONFIG_NF_CONNTRACK_LABELS/
Signed-off-by: Valentin Rothberg
---
The typo was added by commmit c2ac66735870 ("openvswitch: Allow matching
on conntrack label").
I detected the issue scripts/checkkconfigsymbols.py
net/openvswitch/c
Distribute the parsing of source and Kconfig files on all available
cores to speed up processing.
Signed-off-by: Valentin Rothberg
---
scripts/checkkconfigsymbols.py | 128 -
1 file changed, 102 insertions(+), 26 deletions(-)
diff --git a/scripts
On Oct 21 '15 18:58, Jarkko Sakkinen wrote:
> On Tue, Oct 20, 2015 at 05:58:35PM +0300, Jarkko Sakkinen wrote:
> > On Tue, Oct 20, 2015 at 01:49:02PM +0200, Andreas Ziegler wrote:
> > > Hi Jarkko,
> > >
> > > your patch "tpm, tpm_tis: fix tpm_tis ACPI detection issue with TPM 2.0"
> > > showed up
Hi Rabin,
your commit ("CRIS v32: remove old GPIO and LEDs code") is in today's
linux-next tree (i.e., 20151002). Among other Kconfig options, the
commit removes ETRAX_VIRTUAL_GPIO but leaves the following references in
the code:
0 arch/cris/arch-v32/kernel/setup.c 132 #ifdef CONFIG_ETRAX_
Hi Luis,
I finally found some time to read your patch. Thanks for doing this
work in such great detail.
What I miss in the text is a general discussion of the widespread use of
selects. In my opinion, selects should be (like gotos) considered
harmful:
First, selects ignore the user selection a
The comment for the current_pwq member in the worker struct has
not been tab aligned, which is inconsistent with the rest of the
code.
Signed-off-by: Valentin Rothberg
---
I am currently studying interrupt code. While reading, my eyes stopped at this
line to figure out what's wrong. I hesi
checkpatch.pl complained about two single statement macros in
do while (0) loops. The loops and the trailing semicolons are
now removed, which makes checkpatch happy and the two macros
consistent with the rest of the file.
Signed-off-by: Valentin Rothberg
---
include/linux/workqueue.h | 8
On Fri, Mar 20, 2015 at 11:52 AM, Paul Bolle wrote:
> On Fri, 2015-03-20 at 10:39 +, Vladimir Murzin wrote:
>> I should have tested it before...
>
> Valentin proposed an update to scripts/checkkconfigsymbols.py in
> https://lkml.org/lkml/2015/3/16/190 . It (or something like it) should
> have
Hi Alex,
your commit ("memory: jz4780-nemc: driver for the NEMC on JZ4780
SoCs") sets MACH_JZ4780 as Kconfig dependency for the JZ4780_NEMC
driver.
+config JZ4780_NEMC
[...]
+ depends on MACH_JZ4780
MACH_JZ4780 is not defined in Kconfig, so that JZ4780_NEMC is always
false and the driver c
clears the confusion.
>
> Regards,
> ZubairLK
>
> On 02/04/15 10:09, Valentin Rothberg wrote:
>> Hi Alex,
>>
>> your commit ("memory: jz4780-nemc: driver for the NEMC on JZ4780
>> SoCs") sets MACH_JZ4780 as Kconfig dependency for the JZ4780_NEMC
>
Hi Jassi,
your commit 1ccdd04f5365 ("clk: Add clock driver for mb86s7x") is in
today's Linux next tree. The clock driver clk-mb86s7x.c is
conditionally compiled depending on CONFIG_ARCH_MB86S7X. This option is
nowhere defined in Kconfig, so that the driver cannot be compiled at its
current tate.
Hi Scott,
your commit b3df664b85c7 ("bf609: add resources for lcd nl8048") is in
today's Linux next tree and adds the following #ifdef block:
+#if defined(CONFIG_FB_BF609_NL8048) \
+ || defined(CONFIG_FB_BF609_NL8048_MODULE)
[...]
At the current state, the ifdef guarded code cannot be comp
5440.o
> obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-audss.o
> obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o
>
>
> Regards,
> Chanwoo Choi
>
>
> On 03/11/2015 12:32 AM, Valentin Rothberg wrote:
>> Hi Chanwoo,
>>
>> your commit 96bd6224f07b (&q
Hi Stephen,
this is just a kind reminder that the issue below is still present and
made its way to v4.1-rc1. Any news from the maintainers' side?
Kind regards,
Valentin
On Wed, Apr 8, 2015 at 12:57 AM, Stephen Boyd wrote:
> On 04/07/15 07:12, Valentin Rothberg wrote:
>> On Tu
Hi Clément,
your commit dece45855a8b ("NFC: nxp-nci: Add support for NXP NCI
chips") adds the Makefile drivers/nfc/nxp-nci/Makefile with the
following line:
+ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
The Kconfig option NFC_DEBUG is not defined so the line turns out to
be a nop. There is another re
I took the email from the author field of the commit, which does not
exists anymore. Now I added Clément's correct email address.
On Mon, Apr 27, 2015 at 9:03 AM, Valentin Rothberg
wrote:
> Hi Clément,
>
> your commit dece45855a8b ("NFC: nxp-nci: Add support for NXP NCI
Hi Kevin,
this is just a kind reminder that the issue below is still present and
made its way to v4.1-rc1.
Kind regards,
Valentin
On Thu, Mar 26, 2015 at 11:47 AM, Valentin Rothberg
wrote:
> Hi Kevin,
>
> your commit dd6d84812b1a ("MIPS: BMIPS: Enable additional peripheral
>
Hi Scott,
your commit 374feb1f049b ("bf609: use new SND_BF6XX_PCM to choose
audio pcm driver") made its way to Linux v4.1-rc1. It replaces
CONFIG_SND_BF5XX_I2S with CONFIG_SND_BF6XX_PCM, which is not defined
Kconfig. Hence the affected #ifdef blocks cannot be compiled at the
current state.
Is t
Hi Clément,
thanks for your answer.
On Tue, Apr 28, 2015 at 10:23 AM, Clément Perrochaud
wrote:
> On Mon, Apr 27, 2015 at 9:03 AM, Valentin Rothberg wrote:
>> Hi Clément,
>>
>> your commit dece45855a8b ("NFC: nxp-nci: Add support for NXP NCI
>> chips")
The CPP identifier 'DEBUG' is not used in the source code of nfc at all,
so we can safely remove setting it in both Makefiles.
Signed-off-by: Valentin Rothberg
---
I detected this issue with ./scripts/checkkconfigsymbols.py since
CONFIG_NFC_DEBUG is not defined in Kconfig.
---
d
make static analysis tools happy.
Signed-off-by: Valentin Rothberg
---
I detected this issue with ./scripts/checkkconfigsymbols.py
---
drivers/scsi/arm/acornscsi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/arm/acornscsi.c b/drivers/scsi/arm/acornscsi.
Hi Geert,
I am cleaning up some Kconfig issues in ARM
(./scripts/checkkconfgisymbols.py) at the moment and came across
CONFIG_ARCH_R8A7793:
arch/arm/Kconfig.debug: depends on ARCH_R8A7790 ||
ARCH_R8A7791 || ARCH_R8A7793
drivers/clk/shmobile/Makefile:obj-$(CONFIG_ARCH_R8A7793)
+= clk-rcar
ARM_ERRATA_753970 is not defined in Kconfig, so that both selects turn
out to be nops. Hence, we can safely remove them.
Signed-off-by: Valentin Rothberg
---
I detected this issue with scripts/checkkconfigsymbols.py
---
arch/arm/mach-mvebu/Kconfig | 2 --
1 file changed, 2 deletions(-)
diff
CPU_ARM1020_CPU_IDLE is not defined in Kconfig. The last reference on
LKML dates back to 2001, so we can safely remove the comments to make
static analysis tools happy.
Signed-off-by: Valentin Rothberg
---
I detected this issue with scripts/checkkconfigsymbols.py
---
arch/arm/mm/proc-arm1020.S
The block could never be compiled; CPU_ICACHE_STREAMING_DISABLE has not
been defined in Kconfig since the very first Git commit. Hence, we can
safely remove the entire block.
Signed-off-by: Valentin Rothberg
---
There is a similar looking option 'CPU_ICACHE_DISABLE'. However, I
Hi Gregory,
thanks for your reply.
On Tue, Apr 28, 2015 at 6:41 PM, Gregory CLEMENT
wrote:
> Hi Valentin,
>
> On 28/04/2015 18:02, Valentin Rothberg wrote:
>> ARM_ERRATA_753970 is not defined in Kconfig, so that both selects turn
>> out to be nops. Hence, we can safely re
Hi Stephen,
your commit c0c89fafa289 ("ARM: Remove mach-msm and associated ARM
architecture code") removes config ARCH_MSM from Kconfig but leaves a
few references untouched:
arch/arm/Kconfig.debug:1563:default "debug/uncompress.h" if
ARCH_MULTIPLATFORM || ARCH_MSM || \
drivers/phy/Kconfig:28
On Tue, Apr 7, 2015 at 4:07 PM, Valentin Rothberg
wrote:
> Hi Stephen,
>
> your commit c0c89fafa289 ("ARM: Remove mach-msm and associated ARM
> architecture code") removes config ARCH_MSM from Kconfig but leaves a
> few references untouched:
>
> arch/arm/Kconfi
On Thu, Apr 09, 2015 at 02:54:29PM -0400, Rob Clark wrote:
> On Thu, Apr 9, 2015 at 2:12 PM, Paul Bolle wrote:
> > On Thu, 2015-04-09 at 19:07 +0200, Greg KH wrote:
> >> I really don't understand. Why is this code in the kernel tree if it
> >> can't be built? How does anyone use this? By taking
Hi Paul,
On Tue, Apr 28, 2015 at 9:10 PM, Paul Bolle wrote:
> On Tue, 2015-04-28 at 16:15 +0200, Valentin Rothberg wrote:
>> CONFIG_ACORNSCSI_CONSTANTS is a file local CPP identifier and thereby
>> violates the naming convention of Kconfig options in Make and CPP
>> syntax;
On Tue, Apr 28, 2015 at 9:24 PM, Paul Bolle wrote:
> On Tue, 2015-04-28 at 18:45 +0200, Valentin Rothberg wrote:
>> The block could never be compiled; CPU_ICACHE_STREAMING_DISABLE has not
>> been defined in Kconfig since the very first Git commit.
>
> Actually, this goes b
On Tue, Apr 28, 2015 at 9:34 PM, Paul Bolle wrote:
> Hi Valentin,
>
> On Tue, 2015-04-28 at 21:26 +0200, Valentin Rothberg wrote:
>> On Tue, Apr 28, 2015 at 9:10 PM, Paul Bolle wrote:
>> > Will the Erlangen bot still spot ACORNSCSI_CONSTANTS as a potential
>>
Hi Paul,
On Wed, Apr 29, 2015 at 10:27 AM, Paul Bolle wrote:
> [Added Joe.]
>
> On Tue, 2015-04-28 at 11:08 +0200, Valentin Rothberg wrote:
>> The CPP identifier 'DEBUG' is not used in the source code of nfc at all,
>> so we can safely remove setting it in both
CPU_S3C2413 is not defined in Kconfig, so that all references on it turn
out to be 0. Since CPU_S3C2412 supports both, S3C2412 and S3C2413 SoCs
from the S3C24XX line, we can safely remove all dead references on
CPU_S3C2413.
Signed-off-by: Valentin Rothberg
---
I detected this issue with scripts
The previous #ifdef block depends on ARCH_DAVINCI_DA8XX, not
on DAVINCI_DA8XX.
Signed-off-by: Valentin Rothberg
---
I detected this issue with scripts/checkkconfigsymbols.py
---
arch/arm/mach-davinci/usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-davinci
Sometimes a user might be interested to filter certain reports (e.g.,
the many defconfigs). Now, this can be achieved by specifying a Python
regex with -i / --ignore.
Signed-off-by: Valentin Rothberg
---
scripts/checkkconfigsymbols.py | 32 ++--
1 file changed, 26
iler since CONFIG_LEDS_TRIGGERS is always true for the second #ifdef.
This patch removes the second, redundant #ifdef and moves the code of
the #else branch to its proper place.
Signed-off-by: Valentin Rothberg
---
I found this issue with undertaker-checkpatch from the Undertaker
tools
Hi Hai,
your commit d5af49c92a8a ("drm/msm/mdp5: Enable DSI connector in msm drm
driver") in today's Linux next tree adds an #ifdef with CONFIG_MSM_BUS_SCALING
as condition. MSM_BUS_SCALING is not defined in Kconfig, so the code in this
#ifdef block won't be compiled at its current state.
I saw
)
#define led_get_trigger_data(x) (NULL)
#endif
#else
[...]
#endif
This patch removes the second, redundant #ifdef and moves the code of
the #else branch to its proper place.
Signed-off-by: Valentin Rothberg
---
I found this issue with undertaker-checkpatch from the Undertaker
tools
Correct reference on CONFIG_SERIAL_ALTERA_{JTAG}UART_CONSOLE in
C-comment after #endif.
Signed-off-by: Valentin Rothberg
---
I found this issue with ./scripts/checkkconfigsymbols.py
---
drivers/tty/serial/altera_jtaguart.c | 2 +-
drivers/tty/serial/altera_uart.c | 2 +-
2 files changed, 2
The Kconfig option ARCH_SH7372 has been removed by commit 59b89af1d555
("ARM: shmobile: sh7372: Remove Legacy C SoC code"). This patch removes
the last reference on this Kconfig option.
Signed-off-by: Valentin Rothberg
---
I found this issue with ./scripts/checkkconfigsymbols.py
--
issues with scripts/checkkconfigsymbols.py
Valentin Rothberg (4):
drivers/tty/serial/crisv10.c: remove dead #ifdef block
drivers/tty/serial/crisv10.c: remove dead #ifdef blocks
drivers/tty/serial/crisv10.c: remove dead #ifdef blocks
drivers/tty/serial/crisv10.c: rename CPP identifier
The 'CONFIG_' prefix is reserved for Kconfig options in Make and CPP
syntax only. Remove this prefix from the self-defined CPP identifier to
apply to this convention and make static analysis tools happy.
Signed-off-by: Valentin Rothberg
---
drivers/tty/serial/crisv10.c | 8 --
ETRAX_EXTERN_PB6CLK_ENABLED is not defined in Kconfig. The affected
#ifdef block has not been compiled for years, so remove it entirely.
Signed-off-by: Valentin Rothberg
---
drivers/tty/serial/crisv10.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/tty/serial
ETRAX_SERIAL_PROC_ENTRY is not defined in Kconfig. The affected #ifdef
block has not been compiled for years, and the embedded macro, PROCSTAT,
ended up as a NOOP. Hence, remove the block and all calls to PROCSTAT.
Signed-off-by: Valentin Rothberg
---
drivers/tty/serial/crisv10.c | 29
ETRAX_RS485_{ON_PORT_G, LTC1387} are not defined in Kconfig. The
affected #ifdef block have not been compiled for years, so remove them
entirely.
Signed-off-by: Valentin Rothberg
---
drivers/tty/serial/crisv10.c | 36
1 file changed, 36 deletions(-)
diff
The CONFIG_ prefix is reserved for Kconfig options in Make and CPP
syntax. CONFIG_MAGIC is a file local CPP identifier so strip the prefix
to apply to Kconfig's naming convention.
Signed-off-by: Valentin Rothberg
---
I found this issue with ./scripts/checkkconfigsymbols.py
---
driver
This file local CPP identifier is not referenced anywhere else, so we
can safely remove it.
Signed-off-by: Valentin Rothberg
---
I detected this issue with ./scripts/checkkconfigsymbols.py
---
drivers/tty/serial/8250/8250_core.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers
Correct reference in C-comment after #endif.
Signed-off-by: Valentin Rothberg
---
I found this issue with ./scripts/checkkconfigsymbols.py
---
drivers/tty/serial/mcf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/mcf.c b/drivers/tty/serial/mcf.c
index
Fix reference on PPC_MPC52xx in C comment after #endif.
Signed-off-by: Valentin Rothberg
---
drivers/tty/serial/mpc52xx_uart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/mpc52xx_uart.c
b/drivers/tty/serial/mpc52xx_uart.c
index 1589f17c1fca
Remove CONFIG_SERIAL_DETECT_IRQ and CONFIG_SERIAL_MANY_PORTS, and
substitute all references to the proper 8250 Kconfig options. Now, the
actual Kconfig dependencies are not hidden when reading the code and
static analyzers are less confused.
Signed-off-by: Valentin Rothberg
---
I detected this
The CONFIG_ prefix is reserved for Kconfig options in Make and CPP
syntax; static analysis tools rely on this convention. This patch
enforces this behavior for SERIAL_BFIN_{HARD_}CTSRTS.
Signed-off-by: Valentin Rothberg
---
I found this issue with ./scripts/checkkconfigsymbols.py
---
arch
Hi Peter,
On Sun, Apr 12, 2015 at 11:51:55AM -0400, Peter Hurley wrote:
> Hi Valentin,
>
> On 04/12/2015 11:10 AM, Valentin Rothberg wrote:
> > Correct reference in C-comment after #endif.
> >
> > Signed-off-by: Valentin Rothberg
> > ---
>
Correct reference in C-comment after #endif.
Signed-off-by: Valentin Rothberg
---
v2: The correct identifiers is CONFIG_SERIAL_MCF_CONSOLE (reported by
Peter Hurley)
---
drivers/tty/serial/mcf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/mcf.c b
Hi Peter,
On Sun, Apr 12, 2015 at 6:16 PM, Peter Hurley wrote:
> Hi Valentin,
>
> On 04/12/2015 10:56 AM, Valentin Rothberg wrote:
>> The CONFIG_ prefix is reserved for Kconfig options in Make and CPP
>> syntax. CONFIG_MAGIC is a file local CPP identifier so strip the
The CONFIG_ prefix is reserved for Kconfig options in Make and CPP
syntax. CONFIG_MAGIC is a file local CPP identifier so change the
prefix to apply to Kconfig's naming convention.
Signed-off-by: Valentin Rothberg
---
v2: MAGIC -> NOZOMI_CONFIG_MAGIC (suggested by Peter Hurley)
---
dri
Hi Raghu,
your commit f21fb3ed364b ("Add support of Cavium Liquidio ethernet
adapters") is in today's linux-next tree (i.e., next-20150612) adding
the following lines of code:
+config LIQUIDIO
[...]
+ select LIBCRC32
The select turns out to be a NOOP since there is no option LIBCRC32.
I gu
Hi Christian,
On Thu, Jun 4, 2015 at 6:47 PM, Christian König wrote:
> On 04.06.2015 17:09, Alex Deucher wrote:
>>
>> On Thu, Jun 4, 2015 at 10:04 AM, Valentin Rothberg
>> wrote:
>>>
>>> Hi Alex,
>>>
>>> On Thu, Jun 4, 2015 at 4:01 PM, Al
static analysis tools happy.
Signed-off-by: Valentin Rothberg
---
drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c | 10 +-
drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.h | 6 +++---
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
b/drivers/gpu/drm
On Sat, Jun 06, 2015 at 12:03:06PM +0200, Paul Bolle wrote:
> On Sat, 2015-06-06 at 00:46 -0700, Jean-Baptiste Theou wrote:
> > --- a/drivers/watchdog/Kconfig
> > +++ b/drivers/watchdog/Kconfig
>
> > +config GPIO_WATCHDOG_ARCH_INITCALL
> > + bool "Register the watchdog as early as possible"
> >
Hi Yair,
your commit fbeb661bfa89 ("drm/amdkfd: Add skeleton H/W debugger
module support") has shown up in today's linux-next tree (i.e.,
next-20150604). The commit adds the following lines of code to
drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.h:
+/* CONFIG reg space definition */
+enum {
+ CON
ree other
symbols SH_REG_{BASE,SIZE,END}, I would rename CONFIG_ to CONF_ to
avoid mix-ups.
Kind regards,
Valentin
> Oded
>
> On Thu, Jun 4, 2015 at 4:45 PM Valentin Rothberg
> wrote:
>>
>> Hi Yair,
>>
>> your commit fbeb661bfa89 ("drm/amdkfd: Add skeleto
x
>
>>
>> Oded
>>
>> On Thu, Jun 4, 2015 at 4:45 PM Valentin Rothberg
>> wrote:
>>>
>>> Hi Yair,
>>>
>>> your commit fbeb661bfa89 ("drm/amdkfd: Add skeleton H/W debugger
>>> module support") has shown up i
):
$ checkkconfigsymbols.py --diff v4.0..v4.1-rc1 --find
ARCH_EXYNOS5433 drivers/clk/samsung/Makefile
96bd6224f07b clk: samsung: exynos5433: Add clocks using common clock framework
ARCH_MB86S7Xdrivers/clk/Makefile
1ccdd04f5365 clk: Add clock driver for mb86s7x
Valentin Rothberg (2
Color output to make it more readable. Symbols will be printed yellow,
relevant commits (see --find) red.
Signed-off-by: Valentin Rothberg
Acked-by: Stefan Hengelein
Acked-by: Andreas Ruprecht
---
scripts/checkkconfigsymbols.py | 26 --
1 file changed, 20 insertions
e relevant commits are printed below the "SYMBOL\tFILES" line,
followed by an empty line to increase readability.
Signed-off-by: Valentin Rothberg
Acked-by: Stefan Hengelein
Acked-by: Andreas Ruprecht
---
scripts/checkkconfigsymbols.py | 21 +
1 file changed, 21 inserti
Hi Ralf,
your commit 1f1786e60b53 ("MIPS/IRQCHIP: Move irq_chip from arch/mips
to drivers/irqchip.") is in today's linux-next tree (i.e.,
next-20150601). It renames the Kconfig option IRQ_CPU to
IRQ_MIPS_CPU, but misses to rename a few Kconfig selects (see git
grep) in arch/mips.
If you agree, I
Hi Lee,
your commit d0c9e350b9a4 ("watchdog: st_wdt: Add new driver for ST's
LPC Watchdog") is in today's linux-next tree (i.e., next-20150601) and
adds the following lines of code to drivers/watchdog/Kconfig.
+config ST_LPC_WATCHDOG
...
+ select MFD_ST_LPC
The select turns out to be a NOO
Hi Ralf,
thanks for your answer.
On Mon, Jun 1, 2015 at 9:53 PM, Ralf Baechle wrote:
> On Mon, Jun 01, 2015 at 04:51:48PM +0200, Valentin Rothberg wrote:
>
>> Hi Ralf,
>>
>> your commit 1f1786e60b53 ("MIPS/IRQCHIP: Move irq_chip from arch/mips
>> to drivers/
Hi Chuck,
your commit ffe1f0df5862 ("rpcrdma: Merge svcrdma and xprtrdma modules
into one") has shown up in linux next-20150620. The commit merges
SUNRPC_XPRT_RDMA_CLIENT and SUNRPC_XPRT_RDMA_SERVER into
SUNRPC_XPRT_RDMA, but misses to update references in Documentation,
see:
Documentation/files
/* CONFIG_MPC52xx */´´).
These references can be misleading and should be removed or replaced.
Signed-off-by: Valentin Rothberg
Signed-off-by: Stefan Hengelein
---
scripts/checkkconfigsymbols.py | 134 +
scripts/checkkconfigsymbols.sh | 59
/* CONFIG_MPC52xx */´´).
These references can be misleading and should be removed or replaced.
Changelog:
v2: Fix of regural expressions
Signed-off-by: Valentin Rothberg
Signed-off-by: Stefan Hengelein
---
scripts/checkkconfigsymbols.py | 134 +
scripts
/* CONFIG_MPC52xx */´´).
These references can be misleading and should be removed or replaced.
Signed-off-by: Valentin Rothberg
Signed-off-by: Stefan Hengelein
---
Changelog:
v2: Fix of regural expressions
v3: Changelog replacement, and add changes of v2
---
scripts/checkkconfigsymbols.py | 131
On dim., 2014-09-21 at 23:28 +0200, Paul Bolle wrote:
> Valentin Rothberg schreef op zo 21-09-2014 om 21:53 [+0200]:
> > The scripts/checkkconfigsymbols.sh script searches Kconfig features
> > in the source code that are not defined in Kconfig. Such identifiers
> > always eval
On lun., 2014-09-22 at 10:24 +0200, Paul Bolle wrote:
> Hi Valentin,
>
> On Mon, 2014-09-22 at 09:43 +0200, Valentin Rothberg wrote:
> > On dim., 2014-09-21 at 23:28 +0200, Paul Bolle wrote:
> > > Valentin Rothberg schreef op zo 21-09-2014 om 21:53 [+0200]:
> > >
file list) as it simplifies the detection of the Kconfig
feature for long file lists.
Signed-off-by: Valentin Rothberg
Signed-off-by: Stefan Hengelein
---
Changelog:
v2: Fix of regular expressions
v3: Changelog replacement, and add changes of v2
v4: Based on comments from Paul Bolle
akefile
to "TEST_LKM", which still expresses the test of a LKM.
Signed-off-by: Valentin Rothberg
---
lib/Kconfig.debug | 2 +-
lib/Makefile | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 07c2832..db91c97 100644
---
On mar., 2014-09-23 at 09:49 -0700, Randy Dunlap wrote:
> On 09/22/14 23:58, Valentin Rothberg wrote:
> > The "_MODULE" suffix is reserved for tristates compiled as
> > loadable kernel modules (LKM). The "TEST_MODULE" feature thereby
>
> Is that doc
On mar., 2014-09-23 at 10:11 -0700, Randy Dunlap wrote:
> On 09/23/14 10:10, Valentin Rothberg wrote:
> > On mar., 2014-09-23 at 09:49 -0700, Randy Dunlap wrote:
> >> On 09/22/14 23:58, Valentin Rothberg wrote:
> >>> The "_MODULE" suffix is reserved for tri
ve it check each linux-next (and mainline) release.
>
> Very cool.
>
>> (I think Valentin Rothberg is trying to automate this properly. See
>> http://www.linuxplumbersconf.org/2014/ocw/sessions/1863 .)
>
> Have either of you guys thought about asking for this to be incl
feature) to
(feature file list) as it simplifies the detection of the Kconfig
feature for long file lists.
Signed-off-by: Valentin Rothberg
Signed-off-by: Stefan Hengelein
---
Changelog:
v2: Fix of regular expressions
v3: Changelog replacement, and add changes of v2
v4: Based on comments from
feature) to
(feature file list) as it simplifies the detection of the Kconfig
feature for long file lists.
Signed-off-by: Valentin Rothberg
Signed-off-by: Stefan Hengelein
---
Changelog:
v2: Fix of regular expressions
v3: Changelog replacement, and add changes of v2
v4: Based on comments from
at changed from (file list feature) to
(feature file list) as it simplifies the detection of the Kconfig
feature for long file lists.
Signed-off-by: Valentin Rothberg
Signed-off-by: Stefan Hengelein
---
Changelog:
v2: Fix of regular expressions
v3: Changelog replacement, and add changes of v2
v4
On Mon, Sep 29, 2014 at 12:28 PM, Paul Bolle wrote:
> [Added linux-kbu...@vger.kernel.org.]
>
> On Sun, 2014-09-28 at 17:55 +0200, Valentin Rothberg wrote:
>> The scripts/checkkconfigsymbols.sh script searches Kconfig features
>> in the source code that are not def
at changed from (file list feature) to
(feature file list) as it simplifies the detection of the Kconfig
feature for long file lists.
Signed-off-by: Valentin Rothberg
Signed-off-by: Stefan Hengelein
Acked-by: Paul Bolle
---
Changelog:
v2: Fix of regular expressions
v3: Changelog replacemen
On Mon, Sep 29, 2014 at 10:18 PM, Paul Bolle wrote:
> [Perhaps Kees hasn't seen this yet.]
>
> On Tue, 2014-09-23 at 20:27 +0200, Valentin Rothberg wrote:
>> On mar., 2014-09-23 at 10:11 -0700, Randy Dunlap wrote:
>> > On 09/23/14 10:10, Valentin Rothberg wrote:
>
On Wed, Oct 1, 2014 at 4:58 PM, Michal Marek wrote:
> On 2014-09-29 19:05, Valentin Rothberg wrote:
>> The scripts/checkkconfigsymbols.sh script searches Kconfig features
>> in the source code that are not defined in Kconfig. Such identifiers
>> always evaluate to false
- improve filtering of false positives (e.g, CONFIG_XXX)
- change output format from (feature:\tlist) to (feature\tlist)
Signed-off-by: Valentin Rothberg
---
Changelog:
This patch bases on version 6 (https://lkml.org/lkml/2014/9/27/93)
of a patch which has been picked up by Greg in his misc-char tree
On Mon, Nov 10, 2014 at 12:42 PM, Paul Bolle wrote:
> On Sat, 2014-11-08 at 20:56 +0100, Valentin Rothberg wrote:
>> This patch improves the detection of defects by updating the
>> regular expression to find Kconfig identifiers in the source
>> code, and fixes some cases of
commit 106542e7987c ("fs: Remove ext3 filesystem driver") removed ext3
and JBD, hence remove the superfluous condition.
Signed-off-by: Valentin Rothberg
---
I detected the issue with undertaker-checkpatch
(https://undertaker.cs.fau.de)
mm/Kconfig | 8 +---
1 file changed, 1 inser
Hi Jan,
On Thu, Jul 23, 2015 at 3:47 PM, Jan Kara wrote:
> On Thu 23-07-15 13:18:06, Valentin Rothberg wrote:
>> commit 106542e7987c ("fs: Remove ext3 filesystem driver") removed ext3
>> and JBD, hence remove the superfluous condition.
>>
>> Signed-off-by: Va
On Thu, Jul 23, 2015 at 4:01 PM, Valentin Rothberg
wrote:
> Hi Jan,
>
> On Thu, Jul 23, 2015 at 3:47 PM, Jan Kara wrote:
>> On Thu 23-07-15 13:18:06, Valentin Rothberg wrote:
>>> commit 106542e7987c ("fs: Remove ext3 filesystem driver") removed ext3
>>
NFC_DEBUG is not defined in Kconfig and since DEBUG is not used
anywhere in this directory, we can safely remove this line.
Signed-off-by: Valentin Rothberg
---
I detected the issue with scripts/checkkconfigsymbols.py
drivers/nfc/s3fwrn5/Makefile | 2 --
1 file changed, 2 deletions(-)
diff
The Kconfig option AVERAGE and its implementation has been removed by
commit f4e774f55fe0 ("average: remove out-of-line implementation").
Remove the dead build rule in lib/Makefile.
Signed-off-by: Valentin Rothberg
Reviewed-by: Johannes Berg
---
I detected the issue wi
1 - 100 of 278 matches
Mail list logo
